[PATCH v1 4/4] ARM: configs: imx_v6_v7_defconfig: add DMATEST support

2018-07-10 Thread Robin Gong
Add DMATEST support and remove invalid options, such as CONFIG_BT_HCIUART_H4 is default enabled and CONFIG_SND_SOC_IMX_WM8962 is out of date and not appear in any config file. Signed-off-by: Robin Gong --- arch/arm/configs/imx_v6_v7_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH v1 0/4] add memcpy support for sdma

2018-07-10 Thread Robin Gong
This patchset is to add memcpy interface for imx-sdma, besides,to support dmatest and enable config related, so that easily test dma without any other device support such as uart/audio/spi... Robin Gong (4): dmaengine: imx-sdma: add memcpy interface dmaengine: imx-sdma: add check_bd_buswidth

[PATCH v1 0/4] add memcpy support for sdma

2018-07-10 Thread Robin Gong
This patchset is to add memcpy interface for imx-sdma, besides,to support dmatest and enable config related, so that easily test dma without any other device support such as uart/audio/spi... Robin Gong (4): dmaengine: imx-sdma: add memcpy interface dmaengine: imx-sdma: add check_bd_buswidth

[PATCH v2] dmaengine: imx-sdma: add missing structure description

2018-07-03 Thread Robin Gong
rameter or member 'chn_real_count' not described in 'sdma_desc' drivers/dma/imx-sdma.c:326: warning: Function parameter or member 'chn_count' not described in 'sdma_desc Signed-off-by: Robin Gong Reported-by: Vinod Koul --- drivers/dma/imx-sdma.c | 85

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Robin Gong
On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote: > Hi Anson, > > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang > wrote: > > > > > It is NOT easy to identify which switch is critical or NOT, and > > different platforms > > have different board design, it will introduce many platform > > speci

[PATCH v1] dmaengine: imx-sdma: add structure description to eliminate build warning with 'W=1'

2018-07-03 Thread Robin Gong
rameter or member 'chn_real_count' not described in 'sdma_desc' drivers/dma/imx-sdma.c:326: warning: Function parameter or member 'chn_count' not described in 'sdma_desc Signed-off-by: Robin Gong Reported-by: Vinod Koul Signed-off-by: Robin Gong --- drivers/dma

Re: [PATCH v5 0/7] add virt-dma support for imx-sdma

2018-07-02 Thread Robin Gong
On 一, 2018-07-02 at 18:47 +0530, Vinod wrote: > On 02-07-18, 02:32, Robin Gong wrote: > > > > Hi Vinod, > > Do you have any comment for this patchset? Lucas and Sascha > > acked it and tty patch already merged in. > I was actually waiting for ACK/action on patch

Re: [PATCH v5 0/7] add virt-dma support for imx-sdma

2018-07-01 Thread Robin Gong
gressions spotted. As this should cover most common > use-cases, I think this series is good to go in. > > Tested-by: Lucas Stach > > Regards, > Lucas > > Am Mittwoch, den 20.06.2018, 00:56 +0800 schrieb Robin Gong: > > > > The legacy sdma driver has below li

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Robin Gong
On 日, 2018-07-01 at 22:17 -0300, Fabio Estevam wrote: > On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang > wrote: > > > > > On some new i.MX platforms, PFuze switches are used for supplying > > GPU/VPU > > or other non-critical modules only, these switches need to be > > turned off by > > runtime PM

RE: [PATCH v5 0/7] add virt-dma support for imx-sdma

2018-06-26 Thread Robin Gong
Thanks Lucas. Let's wait for comments from Vinod. -Original Message- From: Lucas Stach [mailto:l.st...@pengutronix.de] Sent: 2018年6月26日 23:04 To: Robin Gong ; vk...@kernel.org; s.ha...@pengutronix.de; dan.j.willi...@intel.com; gre...@linuxfoundation.org; jsl...@suse.com Cc: linu

[PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-06-24 Thread Robin Gong
'regulator-always-on' for SW4. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sl-evk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts index 37e792f..798df66 100644 --- a/arch/arm/boot/dts/imx6sl-evk.dts +++

RE: [PATCH v5 0/7] add virt-dma support for imx-sdma

2018-06-21 Thread Robin Gong
Hello Lucas, Would you like to try with the v5 for your Audio/UART case? -Original Message- From: Robin Gong Sent: 2018年6月20日 0:57 To: vk...@kernel.org; s.ha...@pengutronix.de; l.st...@pengutronix.de; dan.j.willi...@intel.com; gre...@linuxfoundation.org; jsl...@suse.com Cc

[PATCH v5 1/7] tty: serial: imx: correct dma cookie status

2018-06-19 Thread Robin Gong
Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1

[PATCH v5 3/7] dmaengine: imx-sdma: add virt-dma support

2018-06-19 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 263 - 2 files changed, 171 insertions(+), 93 deletions(-) diff --g

[PATCH v5 5/7] dmaengine: imx-sdma: remove the maximum limitation for bd numbers

2018-06-19 Thread Robin Gong
No this limitation now after virtual dma used since bd is allocated dynamically instead of static. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d1d3494..9f1a462

[PATCH v5 2/7] dmaengine: imx-sdma: factor out a struct sdma_desc from struct sdma_channel

2018-06-19 Thread Robin Gong
support it will be dynamically allocated. Signed-off-by: Sascha Hauer Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 137 ++--- 1 file changed, 83 insertions(+), 54 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v5 7/7] dmaengine: imx-sdma: alloclate bd memory from dma pool

2018-06-19 Thread Robin Gong
) from [] (snd_pcm_action_single+0x40/0x80) [ 29.356315] [] (snd_pcm_action_single) from [] (snd_pcm_action+0xf4/0xfc) [ 29.364883] r7:0001 r6:c0b9c4d0 r5:ecadb2d4 r4:ecadb200 [ 29.370593] [] (snd_pcm_action) from [] (snd_pcm_drop+0x58/0x9c) Signed-off-by: Robin Gong --- drivers/dma

[PATCH v5 4/7] dmaengine: imx-sdma: remove useless 'lock' and 'enabled' in 'struct sdma_channel'

2018-06-19 Thread Robin Gong
Since 'sdmac->vc.lock' and 'sdmac->desc' can be used as 'lock' and 'enabled' in 'struct sdma_channel sdmac', remove them. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 23 --- 1 file changed, 23 deletions(-

[PATCH v5 6/7] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap

2018-06-19 Thread Robin Gong
There are lot of codes overlap between prep_sg and prep_cyclic function. Add sdma_transfer_init() function to elimated the code overlap. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 83 ++ 1 file changed, 37 insertions(+), 46 deletions

[PATCH v5 0/7] add virt-dma support for imx-sdma

2018-06-19 Thread Robin Gong
struct sdma_channe. Change from v1: 1. split v1 patch into 5 patches. 2. remove some unnecessary condition check. 3. remove unnecessary 'pending' list. Robin Gong (6): tty: serial: imx: correct dma cookie status dmaengine: imx-sdma: add virt-dma support dmaengine: imx-sd

RE: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
Hi Lucas, I didn't met your unstable console issue before, anyway, I'll do more test and look into Audio issue. -Original Message- From: Lucas Stach [mailto:l.st...@pengutronix.de] Sent: 2018年6月14日 18:22 To: Robin Gong ; s.ha...@pengutronix.de; vk...@kernel.org; d

Re: [PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-14 Thread Robin Gong
1.499738] [<801022c8>] (gic_handle_irq) from [<801019f0>] > (__irq_svc+0x70/0xb0) > [   21.507233] Exception stack(0xee915f00 to 0xee915f48) > [   21.512303] 5f00: 0001 0004 ee926c00 ee9270a8 > ee926c00 ecc45e00 ee9270a8 > [   21.520498] 5f20: 80ec23b0 ee914

[PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-13 Thread Robin Gong
the main patch easier to review. Thanks Sacha. 2. remove useless 'desc'/'chan' in struct sdma_channe. Change from v1: 1. split v1 patch into 5 patches. 2. remove some unnecessary condition check. 3. remove unnecessary 'pending' list. Robin Gong (6): t

[PATCH v4 2/7] dmaengine: imx-sdma: factor out a struct sdma_desc from struct sdma_channel

2018-06-13 Thread Robin Gong
support it will be dynamically allocated. Signed-off-by: Sascha Hauer Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 137 ++--- 1 file changed, 83 insertions(+), 54 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v4 4/7] dmaengine: imx-sdma: remove useless 'lock' and 'enabled' in 'struct sdma_channel'

2018-06-13 Thread Robin Gong
Since 'sdmac->vc.lock' and 'sdmac->desc' can be used as 'lock' and 'enabled' in 'struct sdma_channel sdmac', remove them. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 23 --- 1 file changed, 23 deletions(-

[PATCH v4 6/7] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap

2018-06-13 Thread Robin Gong
There are lot of codes overlap between prep_sg and prep_cyclic function. Add sdma_transfer_init() function to elimated the code overlap. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 83 ++ 1 file changed, 37 insertions(+), 46 deletions

[PATCH v4 3/7] dmaengine: imx-sdma: add virt-dma support

2018-06-13 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 261 - 2 files changed, 170 insertions(+), 92 deletions(-) diff --g

[PATCH v4 5/7] dmaengine: imx-sdma: remove the maximum limitation for bd numbers

2018-06-13 Thread Robin Gong
No this limitation now after virtual dma used since bd is allocated dynamically instead of static. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 27b76eb..f56226f

[PATCH v4 7/7] tty: serial: imx: split all dma setup operations out of 'port.lock' protector

2018-06-13 Thread Robin Gong
7693]lock(&port_lock_key); [ 46.433707]lock(fs_reclaim); [ 46.439372] [ 46.441993] lock(&port_lock_key); [ 46.445661] [ 46.445661] *** DEADLOCK *** [ 46.445661] Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c

[PATCH v4 1/7] tty: serial: imx: correct dma cookie status

2018-06-13 Thread Robin Gong
Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1

[PATCH v4 4/7] dmaengine: imx-sdma: remove useless 'lock' and 'enabled' in 'struct sdma_channel'

2018-06-13 Thread Robin Gong
Since 'sdmac->vc.lock' and 'sdmac->desc' can be used as 'lock' and 'enabled' in 'struct sdma_channel sdmac', remove them. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 23 --- 1 file changed, 23 deletions(-

[PATCH v4 3/7] dmaengine: imx-sdma: add virt-dma support

2018-06-13 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 261 - 2 files changed, 170 insertions(+), 92 deletions(-) diff --g

[PATCH v4 6/7] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap

2018-06-13 Thread Robin Gong
There are lot of codes overlap between prep_sg and prep_cyclic function. Add sdma_transfer_init() function to elimated the code overlap. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 83 ++ 1 file changed, 37 insertions(+), 46 deletions

[PATCH v4 0/7] add virt-dma support for imx-sdma

2018-06-13 Thread Robin Gong
the main patch easier to review. Thanks Sacha. 2. remove useless 'desc'/'chan' in struct sdma_channe. Change from v1: 1. split v1 patch into 5 patches. 2. remove some unnecessary condition check. 3. remove unnecessary 'pending' list. Robin Gong (6): t

[PATCH v4 2/7] dmaengine: imx-sdma: factor out a struct sdma_desc from struct sdma_channel

2018-06-13 Thread Robin Gong
support it will be dynamically allocated. Signed-off-by: Sascha Hauer Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 137 ++--- 1 file changed, 83 insertions(+), 54 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index

[PATCH v4 1/7] tty: serial: imx: correct dma cookie status

2018-06-13 Thread Robin Gong
Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1

[PATCH v4 5/7] dmaengine: imx-sdma: remove the maximum limitation for bd numbers

2018-06-13 Thread Robin Gong
No this limitation now after virtual dma used since bd is allocated dynamically instead of static. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 27b76eb..f56226f

[PATCH v4 7/7] tty: serial: imx: split all dma setup operations out of 'port.lock' protector

2018-06-13 Thread Robin Gong
7693]lock(&port_lock_key); [ 46.433707]lock(fs_reclaim); [ 46.439372] [ 46.441993] lock(&port_lock_key); [ 46.445661] [ 46.445661] *** DEADLOCK *** [ 46.445661] Signed-off-by: Robin Gong --- drivers/tty/serial/imx.c

Re: [PATCH v3 0/6] add virt-dma support for imx-sdma

2018-06-13 Thread Robin Gong
stag, den 12.06.2018, 08:58 + schrieb Robin Gong: > > > > Hi Lucas, > > Is the below DEAD LOCK issue same as your side? If yes, then > > I'm afraid that we have to make another patch for uart to split dma > > functions in uart driver out of the code area w

Re: [PATCH v3 0/6] add virt-dma support for imx-sdma

2018-06-12 Thread Robin Gong
Please let me know if you can test/reproduce at your side, if > not > I'll try to find some time to collect some more debug info. > > Regards, > Lucas > > Am Montag, den 11.06.2018, 22:59 +0800 schrieb Robin Gong: > > > > The legacy sdma driver has below lim

Re: [PATCH v3 0/6] add virt-dma support for imx-sdma

2018-06-11 Thread Robin Gong
u can test/reproduce at your side, if not > I'll try to find some time to collect some more debug info. > > Regards, > Lucas > > Am Montag, den 11.06.2018, 22:59 +0800 schrieb Robin Gong: >> The legacy sdma driver has below limitations or drawbacks: >> 1. Hardcod

[PATCH v3 4/6] dmaengine: imx-sdma: remove usless lock

2018-06-11 Thread Robin Gong
No need anymore for 'lock' now since virtual dma will provide the common lock instead. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index e0af8ee..f150b38 100644 --- a/drive

[PATCH v3 3/6] Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled during interrupt"

2018-06-11 Thread Robin Gong
This reverts commit 2746e2c389f9d50043d21e2204270403efb9d62f. Don't need this patch anymore,since we can easily check 'sdmac->desc' to avoid handling dma interrupt after channel disabled if virt-dma used. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 21 ---

[PATCH v3 5/6] dmaengine: imx-sdma: remove the maximum limation for bd numbers

2018-06-11 Thread Robin Gong
No this limitation now after virtual dma used since bd is allocated dynamically instead of static. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index f150b38..0b0588d2

[PATCH v3 6/6] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap

2018-06-11 Thread Robin Gong
There are lot of codes overlap between prep_sg and prep_cyclic function. Add sdma_transfer_init() function to elimated the code overlap. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 83 ++ 1 file changed, 37 insertions(+), 46 deletions

[PATCH v3 2/6] dmaengine: imx-sdma: add virt-dma support

2018-06-11 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 258 - 2 files changed, 168 insertions(+), 91 deletions(-) diff --g

[PATCH v3 0/6] add virt-dma support for imx-sdma

2018-06-11 Thread Robin Gong
1. split v1 patch into 5 patches. 2. remove some unnecessary condition check. 3. remove unnecessary 'pending' list. Robin Gong (5): dmaengine: imx-sdma: add virt-dma support Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled during interrupt"

[PATCH v3 1/6] dmaengine: imx-sdma: factor out a struct sdma_desc from struct sdma_channel

2018-06-11 Thread Robin Gong
From: Sascha Hauer This is a preparation step to make the adding of virt-dma easier. We create a struct sdma_desc, move some fields from struct sdma_channel there and add a pointer from the former to the latter. For now we allocate the data statically in struct sdma_channel, but with virt-dma sup

RE: [PATCH v2 0/5] add virt-dma support for imx-sdma

2018-06-08 Thread Robin Gong
Thanks Sacha, I'll intergrate it into v3. -Original Message- From: Sascha Hauer [mailto:s.ha...@pengutronix.de] Sent: 2018年6月8日 16:43 To: Robin Gong Cc: vk...@kernel.org; dan.j.willi...@intel.com; dmaeng...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-ar

[PATCH v2 2/5] Revert "dmaengine: imx-sdma: fix pagefault when channel is disabled during interrupt"

2018-06-07 Thread Robin Gong
This reverts commit 2746e2c389f9d50043d21e2204270403efb9d62f. Don't need this patch anymore,since we can easily check 'sdmac->desc' to avoid handling dma interrupt after channel disabled if virt-dma used. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 21 ---

[PATCH v2 3/5] dmaengine: imx-sdma: remove usless lock

2018-06-07 Thread Robin Gong
No need anymore for 'lock' now since virtual dma will provide the common lock instead. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d93b58f..6faec89 100644 --- a/drive

[PATCH v2 5/5] dmaengine: imx-sdma: add sdma_transfer_init to decrease code overlap

2018-06-07 Thread Robin Gong
There are lot of codes overlap between prep_sg and prep_cyclic function. Add sdma_transfer_init() function to elimated the code overlap. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 83 ++ 1 file changed, 37 insertions(+), 46 deletions

[PATCH v2 1/5] dmaengine: imx-sdma: add virt-dma support

2018-06-07 Thread Robin Gong
--add specific BD0 for channel0 since such bd descriptor is must and basic for other dma channel, no need alloc/free as other channel,so request it during probe. --remove sdma_request_channel(),sdma_tx_submit(),etc. --alloc/free bd descriptor added and

[PATCH v2 0/5] add virt-dma support for imx-sdma

2018-06-07 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Change from v1: 1. split v1 patch into 5 patches. 2. remove some unnecessary condition check. 3. remove unneccessary 'pending' list. Robin Gong (5): dmaengine: imx-sdma: add virt-dma supp

[PATCH v2 4/5] dmaengine: imx-sdma: remove the maximum limation for bd numbers

2018-06-07 Thread Robin Gong
No this limitation now after virtual dma used since bd is allocated dynamically instead of static. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 6faec89..afaee72

Re: [PATCH v1] dma: imx-sdma: add virt-dma support

2018-05-23 Thread Robin Gong
Okay, I'll try to split it. On 三, 2018-05-23 at 19:04 +0530, Vinod wrote: > On 23-05-18, 12:56, s.ha...@pengutronix.de wrote: > > > > > Well, it's somewhat related to virtual dma support, but that's not > > my > > point. My point is that this patch is quite big and thus hard to > > review. > > If

Re: [PATCH v1] dma: imx-sdma: add virt-dma support

2018-05-23 Thread Robin Gong
On 二, 2018-05-22 at 12:09 +0200, Sascha Hauer wrote: > Hi Robin, > > Several comments inside. > > Sascha > > On Fri, Mar 23, 2018 at 12:18:19AM +0800, Robin Gong wrote: > > > > The legacy sdma driver has below limitations or drawbacks: > >   1. Ha

[PATCH v1] dmaengine: imx-sdma: add virt-dma support

2018-05-22 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 395 +++-- 2 files changed, 253 insertions(+), 143 deletions(-) diff --g

Re: [PATCH v1] dma: imx-sdma: add virt-dma support

2018-05-22 Thread Robin Gong
Ok, I'll resend it after rebase and test. On 二, 2018-05-22 at 12:25 +0530, Vinod wrote: > On 22-05-18, 06:16, Robin Gong wrote: > > > > Ping. > Looks like I missed this one, can you please rebase and resend. > While at it, modify the subject to dmaengine, as thats the subsystem > name >

RE: [PATCH v1] dma: imx-sdma: add virt-dma support

2018-05-21 Thread Robin Gong
Ping. -Original Message- From: Robin Gong Sent: 2018年3月23日 0:18 To: dan.j.willi...@intel.com; vinod.k...@intel.com Cc: dmaeng...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx Subject: [PATCH v1] dma: imx-sdma: add virt-dma support

[PATCH v1] dma: imx-sdma: add virt-dma support

2018-03-22 Thread Robin Gong
the unwanted interrupt coming. At last the common virt-dma is easier for sdma driver maintain. Signed-off-by: Robin Gong --- drivers/dma/Kconfig| 1 + drivers/dma/imx-sdma.c | 395 +++-- 2 files changed, 253 insertions(+), 143 deletions(-) diff --g

[PATCH v1] ARM: dts: imx6qdl-sabreauto: add ecspi dts for sabreauto board

2018-03-20 Thread Robin Gong
DIN pin of SPI-NOR muxed with I2C3_SDA which connected to one gpio expand chip, thus have to disable all those module which compacted by those gpios if enable SPI-NOR support on Sabreauto board. Signed-off-by: Robin Gong --- arch/arm/boot/dts/Makefile | 2 ++ arch/arm/boot

[PATCH v1] ARM: dts: imx6qdl-sabreauto: add ecspi dts for sabreauto board

2018-03-20 Thread Robin Gong
DIN pin of SPI-NOR muxed with I2C3_SDA which connected to one gpio expand chip, thus have to disable all those module which compacted by those gpios if enable SPI-NOR support on Sabreauto board. Signed-off-by: Robin Gong --- arch/arm/boot/dts/Makefile | 2 ++ arch/arm/boot

Re: [PATCH v6 8/8] spi: imx: add support for all SPI word width for DMA

2015-12-15 Thread Robin Gong
On Tue, Dec 08, 2015 at 07:43:50AM +0100, Anton Bondarenko wrote: > DMA transfer for SPI was limited to up to 8 bits word size until now. > Sync in SPI burst size and DMA bus width is necessary to correctly > support 16 and 32 BPW. > > Signed-off-by: Anton Bondarenko > --- > drivers/spi/spi-imx.

Re: [PATCH v2 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-03 Thread Robin Gong
On Tue, Nov 03, 2015 at 09:26:16AM -0800, Guenter Roeck wrote: > On 11/03/2015 12:04 AM, Robin Gong wrote: > >On Mon, Nov 02, 2015 at 11:48:29PM -0800, Guenter Roeck wrote: > >>On 11/02/2015 10:11 PM, Robin Gong wrote: > >>>Enable set_pretimeout interface and tr

Re: [PATCH v1] Revert "serial: imx: remove unbalanced clk_prepare"

2015-11-03 Thread Robin Gong
On Wed, Nov 04, 2015 at 01:39:17AM -0200, Fabio Estevam wrote: > On Wed, Nov 4, 2015 at 12:58 AM, Robin Gong wrote: > > commit 9e7b399d6528 ("serial: imx: remove unbalanced clk_prepare"). > > Otherwise below warning happen since there are some printk logs in > > i

[PATCH v1] Revert "serial: imx: remove unbalanced clk_prepare"

2015-11-03 Thread Robin Gong
9: r8:c133000c r7:0037 r6:edcf4000 r5:c12ef6c0 [ 16.386345] r4:c0afef38 [ 16.386355] [] (call_console_drivers.constprop.25) from [] (console_unlock+0x3fc/0x57c) [ 16.386367] r10:c132fff0 r9:0100 r8:0037 r7: r6:0005 r5:c12f4df0 Signed-off-by: Robin Gong --

[PATCH v3 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-03 Thread Robin Gong
Enable set_pretimeout interface and trigger the pretimeout interrupt before watchdog timeout event happen. Signed-off-by: Robin Gong --- drivers/watchdog/imx2_wdt.c | 58 - 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog

[PATCH v3 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-03 Thread Robin Gong
Enable set_pretimeout interface and trigger the pretimeout interrupt before watchdog timeout event happen. Signed-off-by: Robin Gong --- drivers/watchdog/imx2_wdt.c | 58 - 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog

[PATCH v3 1/2] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2015-11-03 Thread Robin Gong
Since the watchdog common framework centrialize the IOCTL interfaces of device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added in the common code. Signed-off-by: Robin Gong --- Documentation/watchdog/watchdog-kernel-api.txt | 12 + drivers/watchdog/watchdog_dev.c

[PATCH v3 1/2] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2015-11-03 Thread Robin Gong
Since the watchdog common framework centrialize the IOCTL interfaces of device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added in the common code. Signed-off-by: Robin Gong --- Documentation/watchdog/watchdog-kernel-api.txt | 12 + drivers/watchdog/watchdog_dev.c

Re: [PATCH v2 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-03 Thread Robin Gong
On Mon, Nov 02, 2015 at 11:48:29PM -0800, Guenter Roeck wrote: > On 11/02/2015 10:11 PM, Robin Gong wrote: > >Enable set_pretimeout interface and trigger the pretimeout interrupt before > >watchdog timeout event happen. > > > >Signed-off-by: Robin Gong > >--- >

Re: [PATCH v3 1/7] spi: imx: Fix DMA transfer

2015-11-02 Thread Robin Gong
On Sun, Nov 01, 2015 at 03:41:35PM +0100, Anton Bondarenko wrote: > From: Anton Bondarenko > > RX DMA tail data handling doesn't work correctly in many cases with > current implementation. It happens because SPI core was setup > to generates both RX watermark level and RX DATA TAIL events > incor

[PATCH v2 1/2] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2015-11-02 Thread Robin Gong
Since the watchdog common framework centrialize the IOCTL interfaces of device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added in the common code. Signed-off-by: Robin Gong --- drivers/watchdog/watchdog_dev.c | 37 + include/linux/watchdog.h

[PATCH v2 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-02 Thread Robin Gong
Enable set_pretimeout interface and trigger the pretimeout interrupt before watchdog timeout event happen. Signed-off-by: Robin Gong --- drivers/watchdog/imx2_wdt.c | 58 - 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog

Re: [PATCH v1 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-02 Thread Robin Gong
On Mon, Nov 02, 2015 at 08:19:12PM -0800, Guenter Roeck wrote: > On 11/02/2015 07:29 PM, Robin Gong wrote: > >Enable set_pretimeout interface and trigger the pretimeout interrupt before > >watchdog timeout event happen. > > > >Signed-off-by: Robin Gong > >--- >

Re: [PATCH v1 1/2] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2015-11-02 Thread Robin Gong
On Mon, Nov 02, 2015 at 08:04:20PM -0800, Guenter Roeck wrote: > On 11/02/2015 07:29 PM, Robin Gong wrote: > >Since the watchdog common framework centrialize the IOCTL interfaces of > >device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added > >in the common co

[PATCH v1 2/2] watchdog: imx2_wdt: add set_pretimeout interface

2015-11-02 Thread Robin Gong
Enable set_pretimeout interface and trigger the pretimeout interrupt before watchdog timeout event happen. Signed-off-by: Robin Gong --- drivers/watchdog/imx2_wdt.c | 67 - 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog

[PATCH v1 1/2] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2015-11-02 Thread Robin Gong
Since the watchdog common framework centrialize the IOCTL interfaces of device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added in the common code. Signed-off-by: Robin Gong --- drivers/watchdog/watchdog_dev.c | 38 ++ include/linux/watchdog.h

Re: [PATCH v2 3/8] spi: imx: add support for all SPI word width for DMA transfer

2015-10-08 Thread Robin Gong
On Thu, Oct 01, 2015 at 12:34:54AM +, Bondarenko, Anton wrote: > On 30.09.2015 10:35, Robin Gong wrote: > > On Fri, Sep 25, 2015 at 07:57:10PM +0200, Anton Bondarenko wrote: > >> @@ -91,11 +91,15 @@ struct spi_imx_data { > >> > >>struct completion x

Re: [PATCH v2 1/8] spi: imx: Fix DMA transfer

2015-10-08 Thread Robin Gong
On Thu, Oct 01, 2015 at 12:02:41AM +, Bondarenko, Anton wrote: > >> @@ -201,9 +202,8 @@ static bool spi_imx_can_dma(struct spi_master *master, > >> struct spi_device *spi, > >> { > >>struct spi_imx_data *spi_imx = spi_master_get_devdata(master); > >> > >> - if (spi_imx->dma_is_inited >

Re: [PATCH v2 5/8] spi: imx: Add support for loopback for ECSPI controllers

2015-10-08 Thread Robin Gong
On Thu, Oct 01, 2015 at 12:16:49AM +, Bondarenko, Anton wrote: > On 30.09.2015 10:42, Robin Gong wrote: > > On Fri, Sep 25, 2015 at 07:57:12PM +0200, Anton Bondarenko wrote: > >> @@ -370,8 +374,12 @@ static int __maybe_unused mx51_ecspi_config(struct > >> spi_im

Re: [PATCH v2 7/8] spi: imx: defer spi initialization, if DMA engine is pending

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:14PM +0200, Anton Bondarenko wrote: > If SPI device supports DMA mode, but DMA controller is not yet > available due to e.g. a delay in the corresponding kernel module > initialization, retry to initialize SPI driver later on instead of > falling back into PIO only mod

Re: [PATCH v2 5/8] spi: imx: Add support for loopback for ECSPI controllers

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:12PM +0200, Anton Bondarenko wrote: > Support for ECSPI loopback for IMX51,IMX53 and IMX6Q using TEST register. > > Signed-off-by: Mohsin Kazmi > Signed-off-by: Anton Bondarenko > --- > drivers/spi/spi-imx.c | 20 > 1 file changed, 16 insertion

Re: [PATCH v2 6/8] spi: imx: return error from dma channel request

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:13PM +0200, Anton Bondarenko wrote: > On SDMA initialization return exactly the same error, which is > reported by dma_request_slave_channel_reason(), it is a preceding > change to defer SPI DMA initialization, if SDMA module is not yet > available. > > Signed-off-by:

Re: [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated one

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:09PM +0200, Anton Bondarenko wrote: > Fixed timeout value can fire while transaction is ongoing. This may happen > because there are no strict requirements on SPI transaction duration. > Dynamic timeout value is generated based on SCLK and transaction size. > > There

Re: [PATCH v2 3/8] spi: imx: add support for all SPI word width for DMA transfer

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:10PM +0200, Anton Bondarenko wrote: > DMA transfer for SPI was limited to up to 8 bits word size until now. > Sync in SPI burst size and DMA bus width is necessary to correctly > support other BPW supported by HW. > > Signed-off-by: Anton Bondarenko > --- > drivers/

Re: [PATCH v2 1/8] spi: imx: Fix DMA transfer

2015-09-30 Thread Robin Gong
On Fri, Sep 25, 2015 at 07:57:08PM +0200, Anton Bondarenko wrote: > RX DMA tail data handling doesn't work correctly in many cases with > current implementation. It happens because SPI core was setup > to generates both RX watermark level and RX DATA TAIL events > incorrectly. SPI transfer triggeri

[PATCH v1] spi: check tx_buf and rx_buf in spi_unmap_msg

2015-04-15 Thread Robin Gong
dummy_tx/dummy_rx and the data which produced by the last tx or rx may be wrongly sent to the device or handled by the upper level protocol. This patch just keep the orignal value of tx_buf/rx_buf if they are NULL after this transfer processed. Signed-off-by: Robin Gong --- drivers/spi/spi.c | 9

[PATCH v4] dma: imx-sdma: switch to dynamic context mode after script loaded

2015-02-14 Thread Robin Gong
oaded during the context restore if the channel is re-started later" Unfortunately, the rule was broken by commit(5b28aa319bba96987316425a1131813d87cbab35) .This patch just take them back. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v1] spi: imx: use pio mode for i.mx6dl

2015-02-02 Thread Robin Gong
For TKT238285 hardware issue which may cause txfifo store data twice can only be caught on i.mx6dl, we use pio mode instead of DMA mode on i.mx6dl. Signed-off-by: Robin Gong --- drivers/spi/spi-imx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi

[PATCH v3] dma: imx-sdma: switch to dynamic context mode after script loaded

2015-01-22 Thread Robin Gong
oaded during the context restore if the channel is re-started later" Unfortunately, the rule was broken by commit(5b28aa319bba96987316425a1131813d87cbab35) .This patch just take them back. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v2] dma: imx-sdma: switch to dynamic context mode after script loaded

2015-01-21 Thread Robin Gong
oaded during the context restore if the channel is re-started later" Unfortunately, the rule was broken by commit(5b28aa319bba96987316425a1131813d87cbab35) .This patch just take them back. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 11 --- 1 file changed, 8 insertions(+), 3

Re: [PATCH v1] dma: imx-sdma: switch to dynamic context mode after script loaded

2015-01-21 Thread Robin Gong
On Tue, Jan 20, 2015 at 08:16:14AM +0100, Sascha Hauer wrote: > On Tue, Jan 13, 2015 at 01:09:17PM +0800, Robin Gong wrote: > > Below comments got from Page4724 of Reference Manual of i.mx6q: > > http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf > > >

[PATCH v1] dma: imx-sdma: switch to dynamic context mode after script loaded

2015-01-12 Thread Robin Gong
oaded during the context restore if the channel is re-started later" Unfortunately, the rule was broken by commit(5b28aa319bba96987316425a1131813d87cbab35) .This patch just take them back. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: [PATCH v5 3/3] dma: imx-sdma: reorg code to make code clean

2015-01-12 Thread Robin Gong
On Fri, Dec 05, 2014 at 10:11:44PM +0530, Vinod Koul wrote: > On Thu, Oct 23, 2014 at 10:22:20AM +0800, Robin Gong wrote: > > Code reorg for transfer prepare and bus width check to make code > > cleaner. > This should have been 1st patch :( > > -- > ~Vinod > Got it.

Re: [PATCH v5 1/3] dma: imx-sdma: add support for sdma memory copy

2015-01-12 Thread Robin Gong
On Fri, Dec 05, 2014 at 10:09:18PM +0530, Vinod Koul wrote: > On Thu, Oct 23, 2014 at 10:22:18AM +0800, Robin Gong wrote: > > > -static struct dma_async_tx_descriptor *sdma_prep_slave_sg( > > - struct dma_chan *chan, struct scatterlist *sgl, > > - u

[PATCH v1] regulator: pfuze100-regulator: add pfuze3000 support

2015-01-08 Thread Robin Gong
Add pfuze3000 chip support. Signed-off-by: Robin Gong --- .../devicetree/bindings/regulator/pfuze100.txt | 94 ++- drivers/regulator/pfuze100-regulator.c | 134 +++-- include/linux/regulator/pfuze100.h | 14 +++ 3 files changed, 232

Re: [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips

2014-11-21 Thread Robin Gong
Thanks Shawn and Soeren. :) On Wed, Nov 19, 2014 at 02:04:43PM +0800, Shawn Guo wrote: > On Wed, Nov 19, 2014 at 01:50:07PM +0800, Robin Gong wrote: > > Sorry, the patch resent wrongly... > > Hi Shawn, Can you apply the first v4 patches on Sep 26, or I resend it > > again? &

Re: [PATCH 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips

2014-11-18 Thread Robin Gong
Sorry, the patch resent wrongly... Hi Shawn, Can you apply the first v4 patches on Sep 26, or I resend it again? On Wed, Nov 19, 2014 at 06:26:43AM +0100, Soeren Moch wrote: > > On 19.11.2014 04:18, Shawn Guo wrote: > > On Wed, Nov 12, 2014 at 04:20:37PM +0800, Robin Gong wrote: &g

<    1   2   3   4   5   6   7   >