Re: [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays

On 2021-03-29 09:15, Geert Uytterhoeven wrote: Hoi Robin, On Mon, Mar 29, 2021 at 9:09 AM Robin van der Gracht wrote: On 2021-03-22 15:48, Geert Uytterhoeven wrote: > The Holtek HT16K33 LED controller is not only used for driving > dot-matrix displays, but also for driving segment di

Re: [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays

err = linedisp_register(>linedisp, dev, 4, seg->curr, + ht16k33_linedisp_update); + if (err) + goto err_remove_map_file; + + return 0; Groetjes/Kind regards, Robin van der Gracht

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

ight device in the fbdev case and register a led device for both. This makes the code cleaner and drops a dependency but will break backwards compatibility. I'd prefer a single solution that covers both use cases, but I'm not sure about the 'breaking backwards compatibility' consequence... Groetjes / Kind regards, Robin van der Gracht

[PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry

The value for AVID stop is relative to the width of the active video area, not the maximum register value. Zero means equal and a negative value means we're cropping on the right side. Signed-off-by: Robin van der Gracht --- drivers/media/i2c/tvp5150.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

power key with the older SoCs, we need to send a keypress AND release when we get the power down request irq. Signed-off-by: Robin van der Gracht --- Changes v2 -> v3: - Drop alt compatible string for identifying first revision snvs hardware, read minor revision from register instead. - D

[PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

power key with the older SoCs, we need to send a keypress AND release when we get the power down request irq. Signed-off-by: Robin van der Gracht --- .../devicetree/bindings/crypto/fsl-sec4.txt | 16 -- drivers/input/keyboard/Kconfig| 2 +- drivers/input/keyboard/snvs_pwrkey.c

[PATCH v2 2/2] arm: dts: imx6qdl: snvs-pwrkey: Change compatible string

The older imx6 SoCs do not send a power key press interrupt, instead it sends a power down request interrupt when the key is released between 750ms and 5 seconds. The driver uses a different compatible string to ID the older SoCs. Signed-off-by: Robin van der Gracht --- arch/arm/boot/dts

[PATCH] input: keyboard: snvs_pwrkey: Send press and release event for i.MX6 S,DL and Q

AND release when we get the powerdown request interrupt. Signed-off-by: Robin van der Gracht --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- arch/arm/boot/dts/imx6sll.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi| 2 +- arch/arm/boot/dts/imx6ul.dtsi| 2 +- arch/arm/boot/dts

Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant

On 2019-08-19 09:51, Nishka Dasgupta wrote: The static structures ht16k33_fb_fix and ht16k33_fb_var, of types fb_fix_screeninfo and fb_var_screeninfo respectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification. Issue

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

gt; - return vm_insert_page(vma, vma->vm_start, > - virt_to_page(priv->fbdev.buffer)); > + return vm_map_pages_zero(vma, , 1); > } > > static struct fb_ops ht16k33_fb_ops = { Acked-by: Robin van der Gracht

Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

> > - cancel_delayed_work(>work); > + cancel_delayed_work_sync(>work); > unregister_framebuffer(fbdev->info); > framebuffer_release(fbdev->info); > free_page((unsigned long) fbdev->buffer); Looks good Acked-by: Robin van der Gracht

Re: [PATCH v4] mmc: mxs-mmc: Introduce regulator support

On Thu, 31 Jan 2019 13:17:23 +0100 Ulf Hansson wrote: > On Thu, 31 Jan 2019 at 09:20, Robin van der Gracht wrote: > > > > On Mon, 28 Jan 2019 22:15:23 +0100 > > Ulf Hansson wrote: > > > > > On Mon, 28 Jan 2019 at 15:41, Martin Kepplinger > &g

Re: [PATCH v4] mmc: mxs-mmc: Introduce regulator support

_mmc_free; > > } > > > > ssp->clk = devm_clk_get(>dev, NULL); > > -- > > 2.20.1 > > > > BTW, you didn't really answer my earlier question about the TI WiFi > chip. Doesn't you need a special clock for WiFi chip as well? How do > you intend to manage that? I used an external 32K oscillator (SLOW_CLK) for my wl1271. Other clocks ware generated on the module. I had to supply a 'vmmc-supply' in your wl1271 devicetree node, which will be used to power on/off the wlan module. The supply should be a (delayed) GPIO controlled 'fixed-regulator' attached to the wlan_en pin on the module. 1: Documentation/devicetree/bindings/net/wireless/ti,wlcore.txt Kind regards, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag

Re: [PATCH v2] mmc: mxs-mmc: Introduce regulator support

nput! > > revision history > > v1: was just a question why this hasn't gone in earlier. Not sure why it never made it. I created it for use with a wl1271 which wan't properly reset in case of a fault. Also combined with imx28. Regards, Robin van der Gracht

Re: [PATCH] mmc: mxs-mmc: Introduce regulator support

ulator_enable(reg_vmmc); > - if (ret) { > - dev_err(>dev, > - "Failed to enable vmmc regulator: %d\n", ret); > - goto out_mmc_free; > - } > - } > + if (!IS_ERR(reg_vmmc)) > + host->vmmc = reg_vmmc; what about mmc_regulator_get_supply(mmc)? If we use that the vmmc will be made available under mmv->supply->vmmc if probe was successfull instead of storing it in the drivers private struct. > > ssp->clk = devm_clk_get(>dev, NULL); > if (IS_ERR(ssp->clk)) { Robin van der Gracht

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Gracht <ro...@protonic.nl> wrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > > > Cc: Willy Tarreau <w...@1wt.eu> > > Cc: Geert Uytterhoeven <ge...

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Gracht wrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda wrote: > > > Cc: Willy Tarreau > > Cc: Geert Uytterhoeven > > Cc: Linus Walleij > > Cc: Robin van der Gracht > > Cc: Paul

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > Cc: Willy Tarreau <w...@1wt.eu> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Linus Walleij <tr...@df.lth.se> > Cc: Robin van der Gracht <ro...@protonic.nl&g

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojeda wrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I wi

[PATCH] auxdisplay: ht16k33: Use generic device properties function

matrix_keypad_parse_of_params() was replaced early this year. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Early this year Dmitry Torokhov introduced a switch to using generic device properties instead of being OF-specific. Somehow this driver wasn't included in the

[PATCH] auxdisplay: ht16k33: Use generic device properties function

matrix_keypad_parse_of_params() was replaced early this year. Signed-off-by: Robin van der Gracht --- Early this year Dmitry Torokhov introduced a switch to using generic device properties instead of being OF-specific. Somehow this driver wasn't included in the update. For reference: https

[PATCH] auxdisplay: ht16k33: Use unique prefixed i2c client device name

Static naming causes problems when multiple devices are registered. Reported-by: Michael Kaplan <m.kap...@evva.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Michael Kaplan <m.kap...@evva.com> reported the issue with his multiple ht16k33 controller setup. [

[PATCH] auxdisplay: ht16k33: Use unique prefixed i2c client device name

Static naming causes problems when multiple devices are registered. Reported-by: Michael Kaplan Signed-off-by: Robin van der Gracht --- Michael Kaplan reported the issue with his multiple ht16k33 controller setup. [ 472.124385] sysfs: cannot create duplicate filename '/class/backlight

[PATCH] auxdisplay: ht16k33: Keyscan function should be optional

keyscan should be optional to support simple LED matrix displays (output only). Reported-by: Michael Kaplan <m.kap...@evva.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Documentation/devicetree/bindings/display/ht16k33.txt | 15 +-- drivers/auxdispl

[PATCH] auxdisplay: ht16k33: Keyscan function should be optional

keyscan should be optional to support simple LED matrix displays (output only). Reported-by: Michael Kaplan Signed-off-by: Robin van der Gracht --- Documentation/devicetree/bindings/display/ht16k33.txt | 15 +-- drivers/auxdisplay/ht16k33.c | 14

Re: [PATCH] auxdisplay: ht16k33: use le16_to_cpup() to fetch LE16 data

On Wed, 29 Mar 2017 00:42:08 -0700 Dmitry Torokhov wrote: > The data read from the device is 3 little-endian words, so let's annotate > them as such and use le16_to_cpu() to convert them to host endianness - it > might turn out to be a bit more performant, and it

Re: [PATCH] auxdisplay: ht16k33: use le16_to_cpup() to fetch LE16 data

On Wed, 29 Mar 2017 00:42:08 -0700 Dmitry Torokhov wrote: > The data read from the device is 3 little-endian words, so let's annotate > them as such and use le16_to_cpu() to convert them to host endianness - it > might turn out to be a bit more performant, and it expresses the conversion > more

Re: [PATCH] auxdisplay: ht16k33: don't access uninitialized data

Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Robin van der Gracht <ro...@protonic.nl> > --- > drivers/auxdisplay/ht16k33.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdispl

Re: [PATCH] auxdisplay: ht16k33: don't access uninitialized data

ad the data, but we are better > off not doing this, so this changes the code to only copy the data > that was actually initialized. To make sure we don't overflow the > stack with an incorrect DT, we also need to add a sanity checkin the > probe function. > > Signed-off-by: A

Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

On Fri, 3 Mar 2017 15:14:05 +0100 Robin van der Gracht <ro...@protonic.nl> wrote: > The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. > > Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> > Signed-off-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

On Fri, 3 Mar 2017 15:14:05 +0100 Robin van der Gracht wrote: > The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. > > Reviewed-by: Fabio Estevam > Signed-off-by: Robin van der Gracht Sasha or Shawn would you mind pushing this patch upstream? I don't have a

[PATCH v2] clk: imx: correct uart4_serial clock name in driver for i.MX6UL

Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- v2: Rebased on latest mainline drivers/clk/imx/clk-imx6ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers

[PATCH v2] clk: imx: correct uart4_serial clock name in driver for i.MX6UL

Reviewed-by: Fabio Estevam Signed-off-by: Robin van der Gracht --- v2: Rebased on latest mainline drivers/clk/imx/clk-imx6ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index dbd6e59..b4e0dff 100644

[PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Fixed another title typo in v3 drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 inse

[PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Reviewed-by: Fabio Estevam Signed-off-by: Robin van der Gracht --- Fixed another title typo in v3 drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk

[PATCH v2] clk: imx: clk-imxul: The i.mx6ul has no aips_tz3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a

[PATCH v2] clk: imx: clk-imxul: The i.mx6ul has no aips_tz3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Reviewed-by: Fabio Estevam Signed-off-by: Robin van der Gracht --- drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk

[PATCH] clk: imx: clk-imxul: The i.mx6ul has no aips_tx3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-im

[PATCH] clk: imx: clk-imxul: The i.mx6ul has no aips_tx3 clock

The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. Signed-off-by: Robin van der Gracht --- drivers/clk/imx/clk-imx6ul.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index 75c35fb..dbd6e59

[PATCH] clk: imx: correct uart4_serial clock name in driver for i.MX6UL

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- drivers/clk/imx/clk-imx6ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index 0f1f17a..4dcd107 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/d

[PATCH] clk: imx: correct uart4_serial clock name in driver for i.MX6UL

Signed-off-by: Robin van der Gracht --- drivers/clk/imx/clk-imx6ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index 0f1f17a..4dcd107 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/drivers/clk/imx/clk-imx6ul.c

Re: [PATCH v2 2/3] auxdisplay: ht16k33: rework input device initialization

> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> > --- > > v2: addressed Robin's feedback - changed interrupt trigger from > IRQF_TRIGGER_RISING to IRQF_TRIGGER_HIGH > Works like a charm! Tested-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH v2 2/3] auxdisplay: ht16k33: rework input device initialization

ov > --- > > v2: addressed Robin's feedback - changed interrupt trigger from > IRQF_TRIGGER_RISING to IRQF_TRIGGER_HIGH > Works like a charm! Tested-by: Robin van der Gracht

Re: [PATCH 3/3] auxdisplay: ht16k33: remove private workqueue

t ht16k33_probe(struct i2c_client *client, > framebuffer_release(fbdev->info); > err_fbdev_buffer: > free_page((unsigned long) fbdev->buffer); > -err_destroy_wq: > - destroy_workqueue(priv->workqueue); > > return err; > } > @@ -521,7 +512,6 @@ static int ht16k33_remove(struct i2c_client *client) > framebuffer_release(fbdev->info); > free_page((unsigned long) fbdev->buffer); > > - destroy_workqueue(priv->workqueue); > return 0; > } > Acked-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH 3/3] auxdisplay: ht16k33: remove private workqueue

(fbdev->info); > err_fbdev_buffer: > free_page((unsigned long) fbdev->buffer); > -err_destroy_wq: > - destroy_workqueue(priv->workqueue); > > return err; > } > @@ -521,7 +512,6 @@ static int ht16k33_remove(struct i2c_client *client) > framebuffer_release(fbdev->info); > free_page((unsigned long) fbdev->buffer); > > - destroy_workqueue(priv->workqueue); > return 0; > } > Acked-by: Robin van der Gracht

Re: [PATCH 2/3] auxdisplay: ht16k33: rework input device initialization

On Tue, 31 Jan 2017 12:54:37 -0800 Dmitry Torokhov wrote: ... > + > +static irqreturn_t ht16k33_keypad_irq_thread(int irq, void *dev) > +{ > + struct ht16k33_keypad *keypad = dev; > + > + do { > + wait_event_timeout(keypad->wait, keypad->stopped, >

Re: [PATCH 2/3] auxdisplay: ht16k33: rework input device initialization

On Tue, 31 Jan 2017 12:54:37 -0800 Dmitry Torokhov wrote: ... > + > +static irqreturn_t ht16k33_keypad_irq_thread(int irq, void *dev) > +{ > + struct ht16k33_keypad *keypad = dev; > + > + do { > + wait_event_timeout(keypad->wait, keypad->stopped, > +

Re: [PATCH 1/3] auxdisplay: ht16k33: do not try to free fbdev

che = devm_kmalloc(>dev, HT16K33_FB_SIZE, GFP_KERNEL); > @@ -510,8 +510,6 @@ static int ht16k33_probe(struct i2c_client *client, > framebuffer_release(fbdev->info); > err_fbdev_buffer: > free_page((unsigned long) fbdev->buffer); > -err_free_fbdev: > - kfree(fbdev); > err_destroy_wq: > destroy_workqueue(priv->workqueue); > Acked-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH 1/3] auxdisplay: ht16k33: do not try to free fbdev

-510,8 +510,6 @@ static int ht16k33_probe(struct i2c_client *client, > framebuffer_release(fbdev->info); > err_fbdev_buffer: > free_page((unsigned long) fbdev->buffer); > -err_free_fbdev: > - kfree(fbdev); > err_destroy_wq: > destroy_workqueue(priv->workqueue); > Acked-by: Robin van der Gracht

Re: [PATCH 1/3] auxdisplay: ht16k33: do not try to free fbdev

Hello Dmitry, Thank you for submitting your changes. I was out of office last week and I'll try to test and review your changes on my hardware this week. Best regards, Robin van der Gracht

Re: [PATCH 1/3] auxdisplay: ht16k33: do not try to free fbdev

Hello Dmitry, Thank you for submitting your changes. I was out of office last week and I'll try to test and review your changes on my hardware this week. Best regards, Robin van der Gracht

Re: [PATCH] auxdisplay: fix new ht16k33 build errors

lrect' > drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea' > drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit' > > Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules) > > Signed-off-by: Randy Dunlap <rdun...

Re: [PATCH] auxdisplay: fix new ht16k33 build errors

ndefined reference to `sys_copyarea' > drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit' > > Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules) > > Signed-off-by: Randy Dunlap > Cc: Robin van der Gracht > Cc: Miguel Ojeda Sandonis

[PATCH] auxdisplay: ht16k33: select framebuffer helper modules

-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Greg: Bugfix for your char-misc-* tree drivers/auxdisplay/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index a230

[PATCH] auxdisplay: ht16k33: select framebuffer helper modules

-by: Arnd Bergmann Signed-off-by: Robin van der Gracht --- Greg: Bugfix for your char-misc-* tree drivers/auxdisplay/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index a230ea7..4ef4c5c 100644 --- a/drivers/auxdisplay

Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers

7AM +0100, Robin van der Gracht wrote: > > > > This selects the respective helpers required in addition to the one > > > > Arnd Bergmann pointer out earlier. > > > > > > > > Signed-off-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers

On Tue, 29 Nov 2016 21:04:30 +0100 Greg Kroah-Hartman wrote: > On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote: > > On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote: > > > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin va

[PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers

This selects the respective helpers required in addition to the one Arnd Bergmann pointer out earlier. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- This is a responce to https://lkml.org/lkml/2016/11/25/66 This patch complements the changes Arnd submitted earlier. d

[PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers

This selects the respective helpers required in addition to the one Arnd Bergmann pointer out earlier. Signed-off-by: Robin van der Gracht --- This is a responce to https://lkml.org/lkml/2016/11/25/66 This patch complements the changes Arnd submitted earlier. drivers/auxdisplay/Kconfig | 3

Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

Hi Arnd, On Wed, 23 Nov 2016 14:06:49 +0100 Arnd Bergmann wrote: > The new driver caused a rare randconfig failure: > > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference > to `fb_sys_read' > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10):

Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

Hi Arnd, On Wed, 23 Nov 2016 14:06:49 +0100 Arnd Bergmann wrote: > The new driver caused a rare randconfig failure: > > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference > to `fb_sys_read' > drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined

[PATCH v7 RESEND 1/3] of: add vendor prefix for Holtek Semiconductor

This patch introduces a vendor prefix for Holtek Semiconductor Inc. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/D

[PATCH v7 RESEND 1/3] of: add vendor prefix for Holtek Semiconductor

This patch introduces a vendor prefix for Holtek Semiconductor Inc. Signed-off-by: Robin van der Gracht Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b

[PATCH v7 RESEND 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> CC: Miguel Ojeda Sandonis <miguel.ojeda.sando...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Linus Walleij <linus.wall...@linaro.org

[PATCH v7 RESEND 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> CC: Miguel Ojeda Sandonis <miguel.ojeda.sando...@gmail.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 411e3

[PATCH v7 RESEND 0/3] auxdisplay: Introduce ht16k33 driver

Rebased and resend for Greg. This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree binding documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. Robin van der Gracht (3): of: add vendor prefix for Holtek Semiconductor

[PATCH v7 RESEND 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht CC: Miguel Ojeda Sandonis Acked-by: Linus Walleij --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 411e3b8..15d9712 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3030,6 +3030,12 @@ F: drivers

[PATCH v7 RESEND 0/3] auxdisplay: Introduce ht16k33 driver

Rebased and resend for Greg. This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree binding documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. Robin van der Gracht (3): of: add vendor prefix for Holtek Semiconductor

[PATCH v7 RESEND 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht CC: Miguel Ojeda Sandonis Acked-by: Rob Herring Reviewed-by: Linus Walleij --- .../devicetree/bindings/display/ht16k33.txt| 42 ++ drivers/auxdisplay/Kconfig

Re: [char-misc:char-misc-testing] warning

Hi Randy, On Tue, 1 Nov 2016 09:34:04 -0700 Randy Dunlap <rdun...@infradead.org> wrote: > On 11/01/16 09:02, Robin van der Gracht wrote: > > Hi Tobias, > > > > On Tue, 1 Nov 2016 16:33:03 +0100 > > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote:

Re: [char-misc:char-misc-testing] warning

Hi Randy, On Tue, 1 Nov 2016 09:34:04 -0700 Randy Dunlap wrote: > On 11/01/16 09:02, Robin van der Gracht wrote: > > Hi Tobias, > > > > On Tue, 1 Nov 2016 16:33:03 +0100 > > Tobias Jakobi wrote: > > > >> Hello Robin, > >> > >>

Re: [char-misc:char-misc-testing] warning

msg113011.html So.. I should contact Daniel Vetter about this..? > I don't have any nouveau platform here. Me neither, the warning is shown when invoking Kconfig. So when I use the config file supplied on my previous email, and start a build or a menuconfig on my (x86_64) system its showing.

Re: [char-misc:char-misc-testing] warning

t Daniel Vetter about this..? > I don't have any nouveau platform here. Me neither, the warning is shown when invoking Kconfig. So when I use the config file supplied on my previous email, and start a build or a menuconfig on my (x86_64) system its showing. Regards, -- Robin van der Gracht Protonic Holland

[char-misc:char-misc-testing] warning

FB, the warning mentioned above is raised. Would you like to verify this? Regards, -- Robin van der Gracht Protonic Holland config.gz Description: application/gzip

[char-misc:char-misc-testing] warning

FB, the warning mentioned above is raised. Would you like to verify this? Regards, -- Robin van der Gracht Protonic Holland config.gz Description: application/gzip

[PATCH v2] auxdisplay: ht16k33: Keyscan function is now optional

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Changes in v2: - Removed the trailing dot in the patch subject .../devicetree/bindings/display/ht16k33.txt| 15 ++- drivers/auxdisplay/ht16k33.c | 126 +++-- 2 files chang

[PATCH v2] auxdisplay: ht16k33: Keyscan function is now optional

Signed-off-by: Robin van der Gracht --- Changes in v2: - Removed the trailing dot in the patch subject .../devicetree/bindings/display/ht16k33.txt| 15 ++- drivers/auxdisplay/ht16k33.c | 126 +++-- 2 files changed, 73 insertions(+), 68

[PATCH] auxdisplay: ht16k33: Keyscan function is now optional.

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- .../devicetree/bindings/display/ht16k33.txt| 15 ++- drivers/auxdisplay/ht16k33.c | 126 +++-- 2 files changed, 73 insertions(+), 68 deletions(-) diff --git a/Documentation/devi

[PATCH] auxdisplay: ht16k33: Keyscan function is now optional.

Signed-off-by: Robin van der Gracht --- .../devicetree/bindings/display/ht16k33.txt| 15 ++- drivers/auxdisplay/ht16k33.c | 126 +++-- 2 files changed, 73 insertions(+), 68 deletions(-) diff --git a/Documentation/devicetree/bindings/display/ht16k33

[PATCH] auxdisplay: ht16k33: Use unique i2c client device name

Static naming causes problems when multiple devices are registered. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- drivers/auxdisplay/ht16k33.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht1

[PATCH] auxdisplay: ht16k33: Use unique i2c client device name

Static naming causes problems when multiple devices are registered. Signed-off-by: Robin van der Gracht --- drivers/auxdisplay/ht16k33.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index eeb323f..9c09bbc

[PATCH v7 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> CC: Miguel Ojeda Sandonis <miguel.ojeda.sando...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v7: - Fixed unit for deboun

[PATCH v7 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht CC: Miguel Ojeda Sandonis Acked-by: Rob Herring --- Changes in v7: - Fixed unit for debounce-delay-ms in doc (microseconds -> milliseconds) .../devicetree/bindings/display/ht16k33.

[PATCH v7 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> CC: Miguel Ojeda Sandonis <miguel.ojeda.sando...@gmail.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 841ff

[PATCH v7 1/3] of: add vendor prefix for Holtek Semiconductor

This patch introduces a vendor prefix for Holtek Semiconductor Inc. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/D

[PATCH v7 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht CC: Miguel Ojeda Sandonis Acked-by: Linus Walleij --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 841ffa3..7e7368e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2998,6 +2998,12 @@ F: drivers

[PATCH v7 1/3] of: add vendor prefix for Holtek Semiconductor

This patch introduces a vendor prefix for Holtek Semiconductor Inc. Signed-off-by: Robin van der Gracht Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b

[PATCH v7 0/3] auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree binding documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. @Greg: Would you like to review and push this upstream? Robin van der Gracht (3): of: add vendor prefix

[PATCH v7 0/3] auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree binding documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. @Greg: Would you like to review and push this upstream? Robin van der Gracht (3): of: add vendor prefix

Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

On Wed, 18 May 2016 08:09:24 -0700 Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Wed, May 18, 2016 at 02:23:16PM +0200, Robin van der Gracht wrote: > > This patchset adds a new driver to the auxdisplay subsystem. It > > also adds devicetree bindings documenta

Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

On Wed, 18 May 2016 08:09:24 -0700 Greg Kroah-Hartman wrote: > On Wed, May 18, 2016 at 02:23:16PM +0200, Robin van der Gracht wrote: > > This patchset adds a new driver to the auxdisplay subsystem. It > > also adds devicetree bindings documentation and a new vendor prefix. &

[PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree bindings documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. Robin van der Gracht (3): of: add vendor prefix for Holtek Semiconductor auxdisplay: ht16k33: Driver

[PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver

This patchset adds a new driver to the auxdisplay subsystem. It also adds devicetree bindings documentation and a new vendor prefix. I added myself as maintainer to the MAINTAINERS file. Robin van der Gracht (3): of: add vendor prefix for Holtek Semiconductor auxdisplay: ht16k33: Driver

[PATCH v6 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c567a4..54aed16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2816,6 +2816,12 @@ F: drivers/usb/host/whci/ F: drive

[PATCH v6 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver

Signed-off-by: Robin van der Gracht --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9c567a4..54aed16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2816,6 +2816,12 @@ F: drivers/usb/host/whci/ F: drivers/usb/wusbcore/ F

[PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor

Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 8

[PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Changes in v6: - Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10' .../devicetree/bindings/display/ht16k33.txt| 42 ++ drivers/auxdispla

[PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor

Signed-off-by: Robin van der Gracht --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 86740d4..84fb85d 100644

[PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller

Added a driver for the Holtek HT16K33 LED controller with keyscan. Signed-off-by: Robin van der Gracht --- Changes in v6: - Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10' .../devicetree/bindings/display/ht16k33.txt| 42 ++ drivers/auxdisplay/Kcon

Re: [GIT PULL] move ARM LCD display driver to auxdisplay

On Mon, 9 May 2016 16:27:00 +0200 Linus Walleij <linus.wall...@linaro.org> wrote: > On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht > <ro...@protonic.nl> wrote: > > On Mon, 9 May 2016 15:19:26 +0200 > > Linus Walleij <linus.wall...@linaro.org> wrote: >

  1   2   >