Re: [PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

On 26/01/17 17:56, Tony Lindgren wrote: > * Roger Quadros [170123 03:21]: >> USB1 port is micro-AB type and can function as peripheral >> as well as host. Enable dual-role mode for USB1. > > Good to see this happening :) Can you please send the dts changes > separately

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Felipe, On 03/01/17 14:53, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> Mathias & Felipe, >> >> On 17/11/16 17:01, Roger Quadros wrote: >>> Hi, >>> >>> Some XHCI controllers e.g. dwc3 based have a

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Felipe, On 03/01/17 14:53, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Mathias & Felipe, >> >> On 17/11/16 17:01, Roger Quadros wrote: >>> Hi, >>> >>> Some XHCI controllers e.g. dwc3 based have a broken Port disable

[PATCH] extcon: palmas: Don't spam console

User is not interested in USB cable events appearing on the console. Use dev_dbg() instead of dev_info() for these events. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/extcon/extcon-palmas.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/d

[PATCH] extcon: palmas: Don't spam console

User is not interested in USB cable events appearing on the console. Use dev_dbg() instead of dev_info() for these events. Signed-off-by: Roger Quadros --- drivers/extcon/extcon-palmas.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon

[PATCH 8/8] ARM: dts: am57xx-idk: Enable dual-role mode for USB2

USB port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB2. Signed-off-by: Roger Quadros <rog...@ti.com> --- arch/arm/boot/dts/am57xx-idk-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am57

[PATCH 8/8] ARM: dts: am57xx-idk: Enable dual-role mode for USB2

USB port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB2. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am57xx-idk-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b

[PATCH 4/8] usb: dwc3: core.h: add some register definitions

Add OTG and GHWPARAMS6 register definitions Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d514dca..f

[PATCH 4/8] usb: dwc3: core.h: add some register definitions

Add OTG and GHWPARAMS6 register definitions Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index d514dca..fc82d2e 100644

[PATCH 1/8] usb: otg-fsm: Prevent build warning "VDBG" redefined

, from drivers/usb/dwc3/ep0.c:33: include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined In file included from drivers/usb/dwc3/ep0.c:31: include/linux/usb/composite.h:615:1: warning: this is the location of the previous definition Signed-off-by: Roger Quadros <rog...@ti.

[PATCH 0/8] usb: dwc3: add dual-role support

con?). cheers, -roger Roger Quadros (8): usb: otg-fsm: Prevent build warning "VDBG" redefined usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() usb: dwc3: use BIT() macro where possible usb: dwc3: core.h: add some register definitions usb: dwc3: add dual-role support AR

[PATCH 3/8] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 192 +-- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/us

[PATCH 1/8] usb: otg-fsm: Prevent build warning "VDBG" redefined

, from drivers/usb/dwc3/ep0.c:33: include/linux/usb/otg-fsm.h:30:1: warning: "VDBG" redefined In file included from drivers/usb/dwc3/ep0.c:31: include/linux/usb/composite.h:615:1: warning: this is the location of the previous definition Signed-off-by: Roger Quadros Reviewed-

[PATCH 0/8] usb: dwc3: add dual-role support

con?). cheers, -roger Roger Quadros (8): usb: otg-fsm: Prevent build warning "VDBG" redefined usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() usb: dwc3: use BIT() macro where possible usb: dwc3: core.h: add some register definitions usb: dwc3: add dual-role support AR

[PATCH 3/8] usb: dwc3: use BIT() macro where possible

To avoid checkpatch warnings with new patches let's start using the BIT() macro wherever possible. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 192 +-- drivers/usb/dwc3/dwc3-omap.c | 48 +-- drivers/usb/dwc3/gadget.h| 20

[PATCH 7/8] ARM: dts: am43xx: Enable dual-role mode for USB1

USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros <rog...@ti.com> --- arch/arm/boot/dts/am437x-gp-evm.dts | 2 +- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- arch/arm/boot/dts/am43x-epos-evm.dts | 2

[PATCH 7/8] ARM: dts: am43xx: Enable dual-role mode for USB1

USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/am437x-gp-evm.dts | 2 +- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- arch/arm/boot/dts/am43x-epos-evm.dts | 2 +- 3 files changed, 3

[PATCH 5/8] usb: dwc3: add dual-role support

OST - Host controller active 1 0 B_IDLE - Both Host and Gadget controllers inactive 1 1 B_PERIPHERAL - Gadget controller active Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.c | 583 -- drivers/usb/dwc

[PATCH 5/8] usb: dwc3: add dual-role support

OST - Host controller active 1 0 B_IDLE - Both Host and Gadget controllers inactive 1 1 B_PERIPHERAL - Gadget controller active Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.c | 583 -- drivers/usb/dwc3/core.h | 38 ++

[PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

We need to break from all cases if we want to treat each one of them separately. Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/dwc3-omap.c | 1 + 1 file changed, 1 insertio

[PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

We need to break from all cases if we want to treat each one of them separately. Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently") Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-omap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb

[PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros <rog...@ti.com> --- arch/arm/boot/dts/dra7-evm.dts | 2 +- arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +- 2 files changed, 2 insertions

[PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

USB1 port is micro-AB type and can function as peripheral as well as host. Enable dual-role mode for USB1. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 2 +- arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

Vivek, On 19/01/17 17:15, vivek.gau...@codeaurora.org wrote: > Hi Roger, > > On 2017-01-19 17:45, Roger Quadros wrote: >> Vivek, >> >> On 19/01/17 13:56, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Wed, Jun 22, 2016 at 2:00 PM, Roger

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

Vivek, On 19/01/17 17:15, vivek.gau...@codeaurora.org wrote: > Hi Roger, > > On 2017-01-19 17:45, Roger Quadros wrote: >> Vivek, >> >> On 19/01/17 13:56, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Wed, Jun 22, 2016 at 2:00 PM, Roger

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

Vivek, On 19/01/17 13:56, Vivek Gautam wrote: > Hi, > > > On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros <rog...@ti.com> wrote: > > Luckily hit this thread while checking about DRD role functionality for DWC3. > >> On 22/06/16 11:14, Felipe Balbi wrote: >&

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

Vivek, On 19/01/17 13:56, Vivek Gautam wrote: > Hi, > > > On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: > > Luckily hit this thread while checking about DRD role functionality for DWC3. > >> On 22/06/16 11:14, Felipe Balbi wrote: >>> &

Re: [PATCH v2] usb: host: xhci: plat: check hcc_params after add hcd

sets hcc_params in xhci_gen_setup() called from > usb_add_hcd(). > > This patch checks the Maximum Primary Stream Array Size > in the hcc_params register after add primary hcd. > > Signed-off-by: William wu <william...@rock-chips.com> Acked-by: Roger Quadros <rog...@t

Re: [PATCH v2] usb: host: xhci: plat: check hcc_params after add hcd

xhci_gen_setup() called from > usb_add_hcd(). > > This patch checks the Maximum Primary Stream Array Size > in the hcc_params register after add primary hcd. > > Signed-off-by: William wu Acked-by: Roger Quadros > --- > drivers/usb/host/xhci-plat.c | 6 +++--- > 1 file c

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

Hi, On 13/01/17 05:18, William Wu wrote: > From: William wu > > The commit 4ac53087d6d4 ("usb: xhci: plat: Create both > HCDs before adding them") move add hcd to the end of > probe, this cause hcc_params uninitiated, because xHCI > driver sets hcc_params in

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

Hi, On 13/01/17 05:18, William Wu wrote: > From: William wu > > The commit 4ac53087d6d4 ("usb: xhci: plat: Create both > HCDs before adding them") move add hcd to the end of > probe, this cause hcc_params uninitiated, because xHCI > driver sets hcc_params in xhci_gen_setup() called from >

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

On 12/01/17 17:33, Alan Stern wrote: > On Thu, 12 Jan 2017, Roger Quadros wrote: > >> William, >> >> On 12/01/17 14:03, William Wu wrote: >>> From: William wu <w...@rock-chips.com> >>> >>> On some platforms(e.g. rk3399 board), we

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

On 12/01/17 17:33, Alan Stern wrote: > On Thu, 12 Jan 2017, Roger Quadros wrote: > >> William, >> >> On 12/01/17 14:03, William Wu wrote: >>> From: William wu >>> >>> On some platforms(e.g. rk3399 board), we can call hcd_add/remove >>&

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

William, On 12/01/17 14:03, William Wu wrote: > From: William wu > > On some platforms(e.g. rk3399 board), we can call hcd_add/remove > consecutively without calling usb_put_hcd/usb_create_hcd in between, > so hcd->flags can be stale. > > If the HC dies due to whatever

Re: [PATCH] usb: hcd: initialize hcd->flags to 0 when rm hcd

William, On 12/01/17 14:03, William Wu wrote: > From: William wu > > On some platforms(e.g. rk3399 board), we can call hcd_add/remove > consecutively without calling usb_put_hcd/usb_create_hcd in between, > so hcd->flags can be stale. > > If the HC dies due to whatever reason then without this

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

Mathias, On 11/01/17 17:08, Alan Stern wrote: > On Wed, 11 Jan 2017, Mathias Nyman wrote: > >> On 17.11.2016 13:43, Sriram Dash wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

Mathias, On 11/01/17 17:08, Alan Stern wrote: > On Wed, 11 Jan 2017, Mathias Nyman wrote: > >> On 17.11.2016 13:43, Sriram Dash wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops for dwc3 devices. So, set

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

Grygorii, On 10/01/17 22:00, Grygorii Strashko wrote: > Hi > > On 01/10/2017 06:18 AM, Roger Quadros wrote: >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplify a

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

Grygorii, On 10/01/17 22:00, Grygorii Strashko wrote: > Hi > > On 01/10/2017 06:18 AM, Roger Quadros wrote: >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplify a

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

On 11/01/17 17:38, Linus Walleij wrote: > On Tue, Jan 10, 2017 at 1:18 PM, Roger Quadros <rog...@ti.com> wrote: > >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplif

Re: gpio: pcf857x: lockdep warning on v4.10-rc3

On 11/01/17 17:38, Linus Walleij wrote: > On Tue, Jan 10, 2017 at 1:18 PM, Roger Quadros wrote: > >> Hi Linus, >> >> I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. >> >> reverting (d245b3f9bd3 "gpio: simplify adding threaded interrup

gpio: pcf857x: lockdep warning on v4.10-rc3

Hi Linus, I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. reverting (d245b3f9bd3 "gpio: simplify adding threaded interrupts") seems to fix it. [2.358337] [ cut here ] [2.363194] WARNING: CPU: 1 PID: 76 at kernel/locking/lockdep.c:3124

gpio: pcf857x: lockdep warning on v4.10-rc3

Hi Linus, I see the following lockdep warning on v4.10-rc3 on TI's dra7-evm. reverting (d245b3f9bd3 "gpio: simplify adding threaded interrupts") seems to fix it. [2.358337] [ cut here ] [2.363194] WARNING: CPU: 1 PID: 76 at kernel/locking/lockdep.c:3124

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

On 05/01/17 19:16, Greg KH wrote: > On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: >> Hi, >> >> On 17/11/16 13:43, Sriram Dash wrote: >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

On 05/01/17 19:16, Greg KH wrote: > On Thu, Jan 05, 2017 at 05:21:09PM +0200, Roger Quadros wrote: >> Hi, >> >> On 17/11/16 13:43, Sriram Dash wrote: >>> For xhci-hcd platform device, all the DMA parameters are not >>> configured properly, notably dma ops

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

Hi, On 17/11/16 13:43, Sriram Dash wrote: > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. > > The idea here is that you pass in the parent of_node along > with the child device pointer, so it would behave exactly > like the

Re: [PATCH v5 0/6] inherit dma configuration from parent dev

Hi, On 17/11/16 13:43, Sriram Dash wrote: > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. > > The idea here is that you pass in the parent of_node along > with the child device pointer, so it would behave exactly > like the

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Mathias & Felipe, On 17/11/16 17:01, Roger Quadros wrote: > Hi, > > Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. > > If the attached high-speed device is misbehaving, the USB stack typically > disables the port using the PED bit in PORTS

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Mathias & Felipe, On 17/11/16 17:01, Roger Quadros wrote: > Hi, > > Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. > > If the attached high-speed device is misbehaving, the USB stack typically > disables the port using the PED bit in PORTS

[PATCH v2] usb: dwc3: gadget: Fix full speed mode

n.y...@synopsys.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 6 ++ drivers/usb/dwc3/gadget.c | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index de5a857..389dd6d 100644 --- a/driv

[PATCH v2] usb: dwc3: gadget: Fix full speed mode

-by: Roger Quadros --- drivers/usb/dwc3/core.h | 6 ++ drivers/usb/dwc3/gadget.c | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index de5a857..389dd6d 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h

Re: [PATCH 1/1] extcon: usb-gpio: add pinctrl operation during system PM

Hi Peter, On 03/01/17 10:17, Peter Chen wrote: > At some systems, the pinctrl setting will be lost or needs to > set as "sleep" state to save power consumption. So, we need to > configure pinctrl as "sleep" state when system enters suspend, > and as "default" state after system resumes. In this

Re: [PATCH 1/1] extcon: usb-gpio: add pinctrl operation during system PM

Hi Peter, On 03/01/17 10:17, Peter Chen wrote: > At some systems, the pinctrl setting will be lost or needs to > set as "sleep" state to save power consumption. So, we need to > configure pinctrl as "sleep" state when system enters suspend, > and as "default" state after system resumes. In this

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

Hi, On 17/11/16 13:43, Sriram Dash wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the

Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration

Hi, On 17/11/16 13:43, Sriram Dash wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. So, set > the dma for xhci from sysdev. sysdev is pointing to device that > is known to the system firmware

[PATCH v2] extcon: palmas: Check the parent instance to prevent the NULL

-off-by: Roger Quadros <rog...@ti.com> --- Changelog: v2: - updated error message and commit message subject drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..a128fd2

[PATCH v2] extcon: palmas: Check the parent instance to prevent the NULL

-off-by: Roger Quadros --- Changelog: v2: - updated error message and commit message subject drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..a128fd2 100644 --- a/drivers/extcon

Re: [PATCH] extcon: palmas: Fail gracefully if invalid configuration

NULL pointer error I'm OK with this. > > On 2016년 12월 07일 21:12, Roger Quadros wrote: >> extcon-palmas must be child of palmas and expects parent's >> drvdata to be valid. Check for non NULL parent drvdata and >> fail if it is NULL. Not doing so will result in a NULL >>

Re: [PATCH] extcon: palmas: Fail gracefully if invalid configuration

NULL pointer error I'm OK with this. > > On 2016년 12월 07일 21:12, Roger Quadros wrote: >> extcon-palmas must be child of palmas and expects parent's >> drvdata to be valid. Check for non NULL parent drvdata and >> fail if it is NULL. Not doing so will result in a NULL >>

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, On 29/11/16 14:28, Roger Quadros wrote: > Hi, > > On 29/11/16 13:51, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rog...@ti.com> writes: >>> DCFG.DEVSPD == 0x3 is not valid and we need to set >>> DCFG.DEVSPD to 0x1 for f

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, On 29/11/16 14:28, Roger Quadros wrote: > Hi, > > On 29/11/16 13:51, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> DCFG.DEVSPD == 0x3 is not valid and we need to set >>> DCFG.DEVSPD to 0x1 for full speed mode. >> >&

[PATCH] extcon: palmas: Fail gracefully if invalid configuration

-off-by: Roger Quadros <rog...@ti.com> --- drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..ec987ab 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-pa

[PATCH] extcon: palmas: Fail gracefully if invalid configuration

-off-by: Roger Quadros --- drivers/extcon/extcon-palmas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 634ba70..ec987ab 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -190,6 +190,11

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, On 29/11/16 13:51, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> DCFG.DEVSPD == 0x3 is not valid and we need to set >> DCFG.DEVSPD to 0x1 for full speed mode. > > seems like it has been made invalid somewhere between 1.73a and

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, On 29/11/16 13:51, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> DCFG.DEVSPD == 0x3 is not valid and we need to set >> DCFG.DEVSPD to 0x1 for full speed mode. > > seems like it has been made invalid somewhere between 1.73a and > 2.60a. Can you

[PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro

DCFG/DSTS.FULLSPEED can be either 0x1 or 0x3. Let's call 0x1 as DCFG/DSTS_FULLSPEED1 and 0x3 as DCFG/DSTS_FULLSPEED3. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/core.h | 8 drivers/usb/dwc3/gadget.c | 4 ++-- 2 files changed, 6 insertions(+), 6 del

[PATCH 2/2] usb: dwc3: gadget: Clean up DCFG/DSTS FULLSPEED macro

DCFG/DSTS.FULLSPEED can be either 0x1 or 0x3. Let's call 0x1 as DCFG/DSTS_FULLSPEED1 and 0x3 as DCFG/DSTS_FULLSPEED3. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 8 drivers/usb/dwc3/gadget.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c

[PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1dfa56a5f

[PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration

Hi, Although full speed gadget mode isn't really broken on my boards, we are not strictly following the dwc3 manual with regards to the DCFG.DEVSPD configuration. This series fixes that. cheers, -roger Roger Quadros (2): usb: dwc3: gadget: Fix full speed mode usb: dwc3: gadget: Clean up

[PATCH 0/2] usb: dwc3: fix full speed gadget mode configuration

Hi, Although full speed gadget mode isn't really broken on my boards, we are not strictly following the dwc3 manual with regards to the DCFG.DEVSPD configuration. This series fixes that. cheers, -roger Roger Quadros (2): usb: dwc3: gadget: Fix full speed mode usb: dwc3: gadget: Clean up

Re: [PATCH v7 9/9] ARM: dts: omap3: Fix NAND device nodess

Hi Adam On 24/11/16 00:34, Adam Ford wrote: > > On Tue, Feb 23, 2016 at 10:37 AM, Roger Quadros <rog...@ti.com > <mailto:rog...@ti.com>> wrote: > > Add compatible id, GPMC register resource and interrupt > resource to NAND controller nodes. >

Re: [PATCH v7 9/9] ARM: dts: omap3: Fix NAND device nodess

Hi Adam On 24/11/16 00:34, Adam Ford wrote: > > On Tue, Feb 23, 2016 at 10:37 AM, Roger Quadros <mailto:rog...@ti.com>> wrote: > > Add compatible id, GPMC register resource and interrupt > resource to NAND controller nodes. > > The GPMC node will p

[PATCH v3 1/3] usb: xhci: add quirk flag for broken PED bits

f Section i896— USB xHCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi <ba...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/

[PATCH v3 1/3] usb: xhci: add quirk flag for broken PED bits

HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

On 21/11/16 13:56, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index f945380..6553903 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

On 21/11/16 13:56, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index f945380..6553903 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1656,

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

On 18/11/16 12:49, Sergei Shtylyov wrote: > Hello. > > On 11/17/2016 6:01 PM, Roger Quadros wrote: > >> From: Felipe Balbi <ba...@ti.com> >> >> Some devices from Texas Instruments [1] suffer from >> a silicon bug where Port Enabled/Disabled bit >

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

On 18/11/16 12:49, Sergei Shtylyov wrote: > Hello. > > On 11/17/2016 6:01 PM, Roger Quadros wrote: > >> From: Felipe Balbi >> >> Some devices from Texas Instruments [1] suffer from >> a silicon bug where Port Enabled/Disabled bit >> should

[PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

f Section i896— USB xHCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi <ba...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/

[PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

[PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. If the attached high-speed device is misbehaving, the USB stack typically disables the port using the PED bit in PORTSC. For the controllers that have broken port disable, the port fails to detect further attach/detach

[PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. If the attached high-speed device is misbehaving, the USB stack typically disables the port using the PED bit in PORTSC. For the controllers that have broken port disable, the port fails to detect further attach/detach

[PATCH 3/3] usb: dwc3: host: pass quirk-broken-port-ped property for known broken revisions

property. Signed-off-by: Felipe Balbi <ba...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/dwc3/host.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index f6533c6..626d87d 100

[PATCH 3/3] usb: dwc3: host: pass quirk-broken-port-ped property for known broken revisions

off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/dwc3/host.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index f6533c6..626d87d 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc3/hos

[PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

f Section i896— USB xHCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi <ba...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/

[PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

HCI Port Disable Feature Does Not Work Signed-off-by: Felipe Balbi Signed-off-by: Roger Quadros --- drivers/usb/host/xhci-hub.c | 6 ++ drivers/usb/host/xhci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 0ef1

[PATCH 2/3] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested

Felipe Balbi <ba...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-plat.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.tx

[PATCH 2/3] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested

-by: Roger Quadros --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-plat.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt index

[PATCH] net: phy: dp83848: add dp83822 PHY support

This PHY has a compatible register set with DP83848x so add support for it. Acked-by: Andrew F. Davis <a...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> --- drivers/net/phy/dp83848.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83848.c b/dri

[PATCH] net: phy: dp83848: add dp83822 PHY support

This PHY has a compatible register set with DP83848x so add support for it. Acked-by: Andrew F. Davis Signed-off-by: Roger Quadros --- drivers/net/phy/dp83848.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c index 03d54c4..800b39f

Re: [PATCH] extcon: usb-gpio: Add VBUS detection support

Hi Chanwoo, On 27/09/16 08:48, Peter Chen wrote: > On Tue, Sep 20, 2016 at 05:53:55PM +0300, Roger Quadros wrote: >> Driver can now work with both ID and VBUS pins or either one of >> them. >> >> There can be the following 3 cases >> >> 1) Both ID and V

Re: [PATCH] extcon: usb-gpio: Add VBUS detection support

Hi Chanwoo, On 27/09/16 08:48, Peter Chen wrote: > On Tue, Sep 20, 2016 at 05:53:55PM +0300, Roger Quadros wrote: >> Driver can now work with both ID and VBUS pins or either one of >> them. >> >> There can be the following 3 cases >> >> 1) Both ID and V

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

Hi, On 12/09/16 14:38, Roger Quadros wrote: > Hi Santosh & Russell, > > On 19/08/16 19:38, Santosh Shilimkar wrote: >> >> On 8/19/2016 12:30 AM, Roger Quadros wrote: >>> Hi Santosh, >>> >> >>>>> So I'm 99.9% conv

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

Hi, On 12/09/16 14:38, Roger Quadros wrote: > Hi Santosh & Russell, > > On 19/08/16 19:38, Santosh Shilimkar wrote: >> >> On 8/19/2016 12:30 AM, Roger Quadros wrote: >>> Hi Santosh, >>> >> >>>>> So I'm 99.9% conv

[PATCH] extcon: usb-gpio: Add VBUS detection support

= LOW -> USB_HOST active, USB inactive ID = HIGH -> USB_HOST inactive, USB active 3) Only VBUS GPIO is available: VBUS = LOW -> USB_HOST inactive, USB inactive VBUS = HIGH -> USB_HOST inactive, USB active Signed-off-by: Roger Quadros <rog...@ti.com> --- .../devicetree/bindings/ex

[PATCH] extcon: usb-gpio: Add VBUS detection support

= LOW -> USB_HOST active, USB inactive ID = HIGH -> USB_HOST inactive, USB active 3) Only VBUS GPIO is available: VBUS = LOW -> USB_HOST inactive, USB inactive VBUS = HIGH -> USB_HOST inactive, USB active Signed-off-by: Roger Quadros --- .../devicetree/bindings/extcon/extcon-usb-gpio.tx

[PATCH v4] usb: core: setup dma_pfn_offset for USB devices and, interfaces

() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros <rog...@ti.com> --- Changelog: v4: - added comment in the code as to why we need to set dma_mask and dma_pfn_offset for usb devices. v3: - removed comments from code as commit log is sufficient. v2: - added more information in comm

[PATCH v4] usb: core: setup dma_pfn_offset for USB devices and, interfaces

() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros --- Changelog: v4: - added comment in the code as to why we need to set dma_mask and dma_pfn_offset for usb devices. v3: - removed comments from code as commit log is sufficient. v2: - added more information in commit log and code. drivers

[PATCH v3] usb: core: setup dma_pfn_offset for USB devices and, interfaces

() = dma_mask_pfn + dma_pfn_offset Signed-off-by: Roger Quadros <rog...@ti.com> --- Changelog: v3: - removed comments from code as commit log is sufficient. v2: - added more information in commit log and code. drivers/usb/core/message.c | 1 + drivers/usb/core/usb.c | 1 + 2 files chan

<    5   6   7   8   9   10   11   12   13   14   >