by us.
>
> Signed-off-by: Jia-Ju Bai
Reviewed-by: Roland Kammerer
4 files changed, 5 insertions(+), 4 deletions(-)
>
Hi Gustavo,
as also discussed with Lars in person, obviously OK for the DRBD part.
Acked-by: Roland Kammerer
Best, rck
On Tue, Apr 24, 2018 at 03:14:10PM +0200, Luc Van Oostenryck wrote:
> print_st_err() is defined with its 4th argument taking an
> 'enum drbd_state_rv' but its prototype use an int for it.
>
> Fix this by using 'enum drbd_state_rv' in the prototype too.
>
> Signed-off-by: Luc Van Oostenryck
On Tue, Apr 24, 2018 at 03:14:10PM +0200, Luc Van Oostenryck wrote:
> print_st_err() is defined with its 4th argument taking an
> 'enum drbd_state_rv' but its prototype use an int for it.
>
> Fix this by using 'enum drbd_state_rv' in the prototype too.
>
> Signed-off-by: Luc Van Oostenryck
>
On Wed, Oct 04, 2017 at 09:33:18AM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a RCU lock, and the function call path is:
> drbd_sync_handshake (acquire the RCU lock)
> drbd_asb_recover_1p
> drbd_khelper
> drbd_bcast_event
> genlmsg_new(GFP_NOIO) --> may sleep
>
> To
On Wed, Oct 04, 2017 at 09:33:18AM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a RCU lock, and the function call path is:
> drbd_sync_handshake (acquire the RCU lock)
> drbd_asb_recover_1p
> drbd_khelper
> drbd_bcast_event
> genlmsg_new(GFP_NOIO) --> may sleep
>
> To
On Thu, Jul 06, 2017 at 08:02:41PM +0200, Greg KH wrote:
> On Thu, Jul 06, 2017 at 07:56:07PM +0200, Roland Kammerer wrote:
> > On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote:
> > > From: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > >
> &g
On Thu, Jul 06, 2017 at 08:02:41PM +0200, Greg KH wrote:
> On Thu, Jul 06, 2017 at 07:56:07PM +0200, Roland Kammerer wrote:
> > On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote:
> > > From: Greg Kroah-Hartman
> > >
> > > Nothing like having a very gene
t happen magically in mainline, I
queued it up in our out-of-tree repo.
>
> Note, there are many other "generic" named global variables in the drbd
> subsystem, someone should fix those up one day before they hit a linking
> error.
Did that as well.
Both should hit some me
queued it up in our out-of-tree repo.
>
> Note, there are many other "generic" named global variables in the drbd
> subsystem, someone should fix those up one day before they hit a linking
> error.
Did that as well.
Both should hit some merge-window soon.
Thanks, rc
bd_nl.c
> @@ -2294,7 +2294,7 @@ static bool conn_ov_running(struct drbd_connection
> *connection)
> static enum drbd_ret_code
> check_net_options(struct drbd_connection *connection, struct net_conf
> *new_net_conf)
> {
> - static enum drbd_ret_code rv;
> + enum
294,7 @@ static bool conn_ov_running(struct drbd_connection
> *connection)
> static enum drbd_ret_code
> check_net_options(struct drbd_connection *connection, struct net_conf
> *new_net_conf)
> {
> - static enum drbd_ret_code rv;
> + enum drbd_ret_code rv;
> struct drbd_peer_device *peer_device;
> int i;
Yes, that already got dropped for drbd9 and is obviously correct for
in-tree drbd8.
Signed-off-by: Roland Kammerer
Regards, rck
12 matches
Mail list logo
