Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

2017-05-08 Thread Rui Miguel Silva
e fixed, you can add my: Reviewed-by: Rui Miguel Silva <rmf...@gmail.com> Cheers, Rui --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 1681362..861a249 100644 ---

Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

2017-05-08 Thread Rui Miguel Silva
kcalloc. Signed-off-by: Karthik Tummala Can you send a v2 with a subject similar to the other commits in the file. i.e, starting with staging: greybus: light: ... And you have a typo in the change log s/arugment/argument/. If this two are fixed, you can add my: Reviewed-by: Rui Miguel Silva

Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

2016-11-18 Thread Rui Miguel Silva
com> Reviewed-by: Rui Miguel Silva <rmf...@gmail.com> --- drivers/staging/greybus/sdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c index 5649ef1..66b37ea 100644 --- a/drivers/staging/greybus/sdio.c +

Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

2016-11-18 Thread Rui Miguel Silva
Hi Rahul, Thanks for the patch. Now looks great. On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote: This patch fixes the following checkpath.pl warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Rahul Krishnan Reviewed-by: Rui Miguel Silva

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-13 Thread Rui Miguel Silva
Hi Viresh, On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org> Reviewed-by: Rui Miguel Silva <rmf...@gmail.com> Thanks, Rui --- dri

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-13 Thread Rui Miguel Silva
Hi Viresh, On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar Reviewed-by: Rui Miguel Silva Thanks, Rui --- drivers/staging/greybus/gpio.c | 6 ++ 1 file changed, 2

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Rui Miguel Silva
;haslam_a...@projectara.com> Cc: Johan Hovold <jo...@hovoldconsulting.com> Cc: Sandeep Patil <patil_sand...@projectara.com> Cc: Rui Miguel Silva <rui.si...@linaro.org> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Rui Miguel Silva
: Rui Miguel Silva Cc: Greg Kroah-Hartman Signed-off-by: Linus Walleij This was a necessary change for recent kernels. Looks good to me. Thanks. Reviewed-by: Rui Miguel Silva --- ChangeLog v1->v2: - Add the hunk adding select GPIOLIB_IRQCHIP to Kconfig, sorry for sending patches too l

<    1   2