Sjur BRENDELAND writes:
> Hi Rusty,
>
>> From: Rusty Russell [mailto:ru...@rustcorp.com.au]
>> sjur.brandel...@stericsson.com writes:
>> > +struct cfv_napi_context {
>> > + struct vringh_kiov riov;
>> > + unsigned short head;
>> > +};
>&
Johannes Weiner writes:
> On Mon, Feb 11, 2013 at 01:43:03PM +1030, Rusty Russell wrote:
>> I am writing an app which really wants to know if a file is on the
>> disk or not (ie. do I need to sync?).
>
> When the page is under writeback, it's not necessarily on disk
Andrew Morton writes:
> On Mon, 11 Feb 2013 11:27:01 -0500
> Johannes Weiner wrote:
>
>> > Is PG_dirty the right choice? Is that right for huge pages? Should I
>> > assume is_migration_entry(entry) means it's not dirty, or is there some
>> > other check here?
>>
>> If your only consequence of
sjur.brandel...@stericsson.com writes:
> From: Vikram ARV
>
> Add the the Virtio shared memory driver for STE Modems.
> caif_virtio is implemented utilizing the virtio framework
> for data transport and is managed with the remoteproc frameworks.
>
> The Virtio queue is used for transmitting data t
I am writing an app which really wants to know if a file is on the
disk or not (ie. do I need to sync?).
mincore() bits other than 0 are undefined (as documented in the man
page); in fact my Ubuntu 12.10 i386 system seems to write 129 in some
bytes, so it really shouldn't break anyone.
Is PG_dirt
James Hogan writes:
> Hi Rusty,
>
> The metag architecture tree adds an add_taint(TAINT_DIE) like other
> architectures do, and the modules-next tree adds the
> LOCKDEP_NOW_UNRELIABLE flag to all uses of add_taint (but obviously
> misses arch/metag since it doesn't exist yet), causing a compile er
Paolo Bonzini writes:
> The virtqueue_add_buf function has two limitations:
>
> 1) it requires the caller to provide all the buffers in a single call;
>
> 2) it does not support chained scatterlists: the buffers must be
> provided as an array of struct scatterlist.
>
> Because of these limitations
Thomas Gleixner writes:
> On Fri, 1 Feb 2013, Linus Torvalds wrote:
>> So for me it's the "expose these states" that I get worried about.. A
>> random driver should not necessarily even be able to *see* this, and
>> decide to be clever and take advantage of the ordering.
>>
>> So I'd hope there w
Joe Perches writes:
> alloc failures already get standardized OOM
> messages and a dump_stack.
>
> Signed-off-by: Joe Perches
Why not, less code is always good.
Acked-by: Rusty Russell (virtio_net)
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe
"Srivatsa S. Bhat" writes:
> On 01/22/2013 01:03 PM, Srivatsa S. Bhat wrote:
> Avg. latency of 1 CPU offline (ms) [stop-cpu/stop-m/c
> latency]
>
> # online CPUsMainline (with stop-m/c) This patchset (no stop-m/c)
>
> 8 17.04
The following changes since commit 9a9284153d965a57edc7162a8e57c14c97f3a935:
Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
(2013-01-20 20:55:49 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git
tags/fixes
Ben Hutchings writes:
> On Mon, 2013-02-04 at 16:29 +1030, Rusty Russell wrote:
>> Cong Wang writes:
>> > Hello, Rusty, Jesse,
>> >
>> > I met an interesting problem when I compile openvswitch module as a
>> > built-in (actually I compile ALL kerne
Cong Wang writes:
> Hello, Rusty, Jesse,
>
> I met an interesting problem when I compile openvswitch module as a
> built-in (actually I compile ALL kernel modules as built-in), there is
> no /sys/module/openvswitch/ directory created by the kernel in this
> case.
...
> What's worse, the user-space
Stephan Mueller writes:
> On 25.01.2013 00:36:01, +0100, Rusty Russell wrote:
>> "the module signature" here being the signature of any crypto module,
>> I'm guessing from Kyle's awful patch. Any crypto module, or just some?
>> Presumably any modul
Tejun Heo writes:
>> It also implements two stage shutdown, as we need it to tear down the
>> percpu counts. Before dropping the initial refcount, you must call
>> percpu_ref_kill(); this puts the refcount in "shutting down mode" and
>> switches back to a single atomic refcount with the appropriat
David Howells writes:
> Feel free to add:
>
> Acked-by: David Howells
>
> to your patches.
Thanks, done and applied.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vge
Kyle McMartin writes:
> After thinking about it a while, this seems like the best way to solve
> the problem, although it does still kind of offend my delicate
> sensibilities...
You're far too polite. This patch was horrible, partial and ugly.
Stephan Mueller wrote:
> FIPS requires the module
Kyle McMartin writes:
> Commit 1d0059f3a added a test to check if the system is booted in fips
> mode, and if so, panic the system if an unsigned module is loaded.
> However the wording of the changelog "in signature enforcing mode" leads
> one to assume that sig_enforce should be set for the pani
Vivek Goyal writes:
> Hi,
>
> This is a very crude RFC for ELF executable signing and verification. This
> has been done along the lines of module signature verification.
Yes, but I'm the first to admit that's the wrong lines.
The reasons we didn't choose that for module signatures:
1) I was una
Chris Samuel writes:
> /* Please CC me, I'm not on LKML */
>
> On 21/01/13 10:36, Rusty Russell wrote:
>
>> We have errnos for a reason; let's not pollute the kernel logs. That's
>> a userspace job.
>
> Fair enough.
>
>> This part is OK,
Greg KH writes:
> Rusty, should the commit below be applied to the 3.7-stable kernel tree?
>
> thanks,
>
> greg k-h
Good point. looks like commit which caused this (e9bda3b) went in 3.6
so I think you'll want the following:
0d21b0e3477395e7ff2acc269f15df6e6a8d356d module: add new state
MODULE_S
Wanlong Gao writes:
> As Michael mentioned, set affinity and select queue will not work very
> well when CPU IDs are not consecutive, this can happen with hot unplug.
> Fix this bug by traversal the online CPUs, and create a per cpu variable
> to find the mapping from CPU to the preferable virtua
Steven Rostedt writes:
> On Wed, 2013-01-09 at 18:09 -0500, Sasha Levin wrote:
>> Modify the parameters of all the lookup and the bookkeeping functions which
>> should be const to const.
>>
>> For example, jump_label_text_reserved() doesn't modify the memory it works
>> on,
>> it just checks whe
"Michael S. Tsirkin" writes:
> On Thu, Jan 17, 2013 at 12:40:29PM +1030, Rusty Russell wrote:
>> I resist sprinkling __user everywhere because it's *not* always user
>> addresses, and it's deeply misleading to anyone reading it. I'd rather
>> have it
Linus Torvalds writes:
> On Sun, Jan 20, 2013 at 5:20 PM, Rusty Russell wrote:
>> Dan Carpenter writes:
>>> We take the lock twice if we hit this goto.
>>>
>>> Signed-off-by: Dan Carpenter
>>
>> Damn, just pushed that to Linus: should hav
Linus Torvalds writes:
> On Sun, Jan 20, 2013 at 5:32 PM, Rusty Russell wrote:
>>
>> Due to the delay on git.kernel.org, git request-pull fails. It *looks*
>> like it succeeds, except the warning, but (as we learned last time I
>> screwed up), it doesn't put
"Frank Ch. Eigler" writes:
> Hi -
>
>> [...]
>> -add_taint(TAINT_DIE);
>> +add_taint(TAINT_DIE, LOCKDEP_NOW_UNRELIABLE);
>> [...]
>
> If "UNRELIABLE" a good way to describe it - not DANGEROUS or
> COUNTERPRODUCTIVE or something, then maybe lockdep *can* produce
> reasonable results followi
Stephen Rothwell writes:
> Hi Rusty,
>
> On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell
> wrote:
>>
>> #ifdef CONFIG_MODULE_SIG
>> mod->sig_ok = info->sig_ok;
>> -if (!mod->sig_ok)
>> +if (!mod->sig_ok) {
>> +
Linus Torvalds writes:
> On Sun, Jan 20, 2013 at 4:08 PM, Rusty Russell wrote:
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git fixes
>
> Ugh.
>
> You *meant* the "fixes-for-linus&
om Dan, thanks)
Alexander Graf (1):
virtio-blk: Don't free ida when disk is in use
Dan Carpenter (1):
module: potential deadlock in error path
Rusty Russell (2):
module: add new state MODULE_STATE_UNFORMED.
module:
introduced recently by kvm id changes.
Alexander Graf (1):
virtio-blk: Don't free ida when disk is in use
Rusty Russell (2):
module: add new state MODULE_STATE_UNFORMED.
module: put modules in list much earlier.
d mod->name to the printk.
How's this:
module: printk message when module signature fail taints kernel.
Reported-by: Chris Samuel
Signed-off-by: Rusty Russell
diff --git a/kernel/module.c b/kernel/module.c
index ec535aa..e095e19 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -31
Rusty Russell writes:
> "Michael S. Tsirkin" writes:
>> On Wed, Jan 16, 2013 at 01:43:32PM +1030, Rusty Russell wrote:
>>> "Michael S. Tsirkin" writes:
>>> >> +static int resize_iovec(struct vringh_iov *iov, gfp_t gfp)
>>> >>
ch was the entire point!
Here it is:
taint: add explicit flag to show whether lock dep is still OK.
Fix up all callers as they were before, with make one change: an
unsigned module taints the kernel, but doesn't turn off lockdep.
Signed-off-by: Rusty Russell
diff --git a/arch/alpha/kernel/tra
"Michael S. Tsirkin" writes:
> On Wed, Jan 16, 2013 at 01:43:32PM +1030, Rusty Russell wrote:
>> "Michael S. Tsirkin" writes:
>> >> +static int resize_iovec(struct vringh_iov *iov, gfp_t gfp)
>> >> +{
>> >> + struct iovec *new;
>
Tejun Heo writes:
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3058,8 +3064,25 @@ static int do_init_module(struct module
> blocking_notifier_call_chain(&module_notify_list,
>MODULE_STATE_LIVE, mod);
>
> - /* We need to finish all async code
the kernel.
How about this, instead? Ingo?
taint: add explicit flag to show whether lock dep is still OK.
Fix up all callers as they were before, with make one change: an
unsigned module taints the kernel, but doesn't turn off lockdep.
Signed-off-by: Rusty Russell
diff --git a/arch/alpha
Wanlong Gao writes:
> Add hot cpu notifier to reset the request virtqueue affinity
> when doing cpu hotplug.
You need to be careful to get_online_cpus() and put_online_cpus() here,
so CPUs can't go up and down in the middle of operations.
In particular, get_online_cpus()/put_online_cpus() around
"Michael S. Tsirkin" writes:
>> +static int resize_iovec(struct vringh_iov *iov, gfp_t gfp)
>> +{
>> +struct iovec *new;
>> +unsigned int new_num = iov->max * 2;
>
> We must limit this I think, this is coming
> from userspace. How about UIO_MAXIOV?
We limit it to the ring size already; UI
Prarit Bhargava writes:
> On 01/10/2013 10:48 PM, Rusty Russell wrote:
> The timing were similar. I didn't see any huge delays, etc. Can the
> relocations really cause a long delay? I thought we were pretty much writing
> values to memory...
For x86 that's true, but loo
Sjur Brændeland writes:
> How do you see the in-kernel API for this? I would like to see
> something similar to my previous patches, where we extend
> the virtqueue API. E.g. something like this:
> struct virtqueue *vring_new_virtqueueh(unsigned int index,
> u
Josh Boyer writes:
> On Fri, Jan 11, 2013 at 4:44 AM, Chris Samuel wrote:
>> /* Please CC me in responses, I am not subscribed to LKML */
>>
>> Currently if a signature check fails on module load due to not having
>> the appropriate key (-ENOKEY) and we are not doing strict checking
>> there is
rtio_host.h
new file mode 100644
index 000..07bb4f6
--- /dev/null
+++ b/include/linux/virtio_host.h
@@ -0,0 +1,88 @@
+/*
+ * Linux host-side vring helpers; for when the kernel needs to access
+ * someone else's vring.
+ *
+ * Copyright IBM Corporation, 2013.
+ * Parts taken from dri
es list.
We add the state at the end, to avoid gratuitous ABI break (ksplice).
Signed-off-by: Rusty Russell
diff --git a/include/linux/module.h b/include/linux/module.h
index 7760c6d..4432373 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -199,11 +199,11 @@ struct
Sjur Brændeland writes:
> Hi Rusty,
>
> On Thu, Jan 10, 2013 at 11:30 AM, Rusty Russell wrote:
> ...
>>I now have some lightly-tested code (via a userspace harness).
>
> Great - thank you for looking into this. I will start integrating this
> with my patches
> wh
Rusty Russell writes:
> It basically involves moving much of vring.c into a virtio_host.c: the
> parts which actually touch the ring. Then it provides accessors for
> vring.c to use which are __user-safe (all casts are inside
> virtio_host.c).
>
> I should have something to po
Sasha Levin writes:
> These helper functions just check a set intersection with a range, and
> don't actually modify struct module.
>
> Signed-off-by: Sasha Levin
Thanks, applied.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
Wanlong Gao writes:
> On 01/09/2013 07:31 AM, Rusty Russell wrote:
>> Wanlong Gao writes:
>>> */
>>> static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff
>>> *skb)
>>> {
>>> - int t
Wanlong Gao writes:
> */
> static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff *skb)
> {
> - int txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) :
> - smp_processor_id();
> + int txq = 0;
> +
> + if (skb_rx_queue_recorded(skb))
> +
Paolo Bonzini writes:
> Il 07/01/2013 01:02, Rusty Russell ha scritto:
>> Paolo Bonzini writes:
>>> Il 02/01/2013 06:03, Rusty Russell ha scritto:
>>>> Paolo Bonzini writes:
>>>>> The virtqueue_add_buf function has two limitations:
>>>
"Michael Kerrisk (man-pages)" writes:
> Hi David, Rusty,
>
> Linux 3.7 added signed modules. As a consequence, init_module()
> acquired some new possible error returns. I've put together the text
> below to describe the new errors. Does the text look okay?
Looks good. I liked the finit_module t
Sasha Levin writes:
> On 01/02/2013 07:41 PM, Rusty Russell wrote:
>> Sasha Levin writes:
>>
>>> If we try to finit_module on a file sized 0 bytes vmalloc will
>>> scream and spit out a warning.
>>>
>>> Since modules have to be bigger than 0
Paolo Bonzini writes:
> Il 02/01/2013 06:03, Rusty Russell ha scritto:
>> Paolo Bonzini writes:
>>> The virtqueue_add_buf function has two limitations:
>>>
>>> 1) it requires the caller to provide all the buffers in a single call;
>>>
>>> 2)
Josh Boyer writes:
> With module signing enabled but not in enforcing mode, we don't consider
> unsigned modules to be an error. However, we only mark sig_ok as true if
> a signature verified. This causes the module to be tainted with the
> TAINT_FORCED_MODULE flag.
Wait, what? So, what does C
Tejun Heo writes:
> Hello, Rusty.
>
> On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote:
>> > So, I guess this currently is caught in a place which isn't here or
>> > there. I'm pretty skeptical whether it makes sense to bother about
>>
Wanlong Gao writes:
> On 01/02/2013 01:03 PM, Rusty Russell wrote:
>> Paolo Bonzini writes:
>>> The virtqueue_add_buf function has two limitations:
>>>
>>> 1) it requires the caller to provide all the buffers in a single call;
>>>
>>> 2) it d
Sasha Levin writes:
> If we try to finit_module on a file sized 0 bytes vmalloc will
> scream and spit out a warning.
>
> Since modules have to be bigger than 0 bytes anyways we can just
> check that beforehand and avoid the warning.
Applied, but I added the comment you somehow missed :)
Thanks
Jonathan Kliegman writes:
> The section mismatch warning can be easy to miss during the kernel build
> process. Allow it to be marked as fatal to be easily caught and prevent
> bugs from slipping in.
>
> Signed-off-by: Jonathan Kliegman
Hmm, a CONFIG option with no Kconfig entry? That seems we
Tejun Heo writes:
> Hello, Rusty.
>
> On Wed, Jan 02, 2013 at 03:12:15PM +1030, Rusty Russell wrote:
>> > Hmmm? cpumask_t can't be used for stack but other than that I don't
>> > see how it would be deprecated completely. Rusty, can you please
>> >
Michael Kerrisk writes:
> Hi Rusty,
Hi Michael,
> The description here is rather thin. Could you supply a sentence or
> two for each of MODULE_INIT_IGNORE_MODVERSIONS and
> MODULE_INIT_IGNORE_VERMAGIC that would be suitable for the manual
> page?
>
> Thanks,
There are one or two safety checks b
plementation by having another interface is pretty
nasty; I think I'd prefer the chained scatterlists, if that's optimal
for you.
Cheers,
Rusty.
From: Rusty Russell
Subject: virtio: use chained scatterlists.
Rather than handing a scatterlist[] and out and in numbers to
virtqueue_add_b
Sam Ravnborg writes:
> On Thu, Dec 27, 2012 at 04:17:20PM +0530, Vineet Gupta wrote:
>> ARC relocatable object files contain one/more .gnu.linkonce.arcextmap.*
>> sections (collated by kernel/vmlinux.lds into .arcextmap in final link).
>> This section is used by debuggers to display the extension
Tejun Heo writes:
> (cc'ing Rusty, hi!)
>
> Hello, Li.
>
> On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote:
>> On 2012/11/29 5:34, Tejun Heo wrote:
>> > cpuset_can_attach() prepare global variables cpus_attach and
>> > cpuset_attach_nodemask_{to|from} which are used by cpuset_attach().
>
Rusty Russell writes:
> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git
> tags/virtio-next-for-linus
>
> for you to fetch changes up to 1b6370463e88b0c1c317de16d7b962acc1dab4f2:
>
> virtio_console: Add support for remoteproc serial (2012-12-18 15:20:44
>
Stephen Rothwell writes:
> Hi Rusty,
>
> Today's linux-next merge of the modules tree got a conflict in
> kernel/modsign_pubkey.c between commit 84ecfd15f554 ("modsign: add symbol
> prefix to certificate list") from Linus' tree and commit bb8f5966421d
> ("MODSIGN: Avoid using .incbin in C source")
apacity math on ring full
virtio-net: remove unused skb_vnet_hdr->num_sg field
Pawel Moll (1):
virtio-mmio: Fix irq parsing in command line parameter
Rusty Russell (9):
lguest: fix block request handling in example launcher.
virtio: move queue_index and num_free fields int
Stephen Rothwell writes:
> The virtio tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git#virtio-next)
> has a conflict with the net-next tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git#master)
> that requires the following extra fix up patch:
>
> diff --
Amit Shah writes:
> On (Tue) 11 Dec 2012 [09:39:41], Rusty Russell wrote:
>> Amit Shah writes:
>>
>> > On (Fri) 16 Nov 2012 [11:22:09], Rusty Russell wrote:
>> >> Amit Shah writes:
>> >> > From: Sjur Brændeland
>> >> >
Stephen Rothwell writes:
> Hi Rusty,
>
> After merging the virtio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/net/virtio_net.c: In function 'vq2txq':
> drivers/net/virtio_net.c:150:2: error: implicit declaration of function
> 'virtqueue_get_queue_index' [
Amit Shah writes:
> On (Fri) 16 Nov 2012 [11:22:09], Rusty Russell wrote:
>> Amit Shah writes:
>> > From: Sjur Brændeland
>> >
>> > Remove buffers from the out-queue when a port is removed. Rproc_serial
>> > communicates with remote processors tha
Michal Marek writes:
> Added David and Rusty.
>
> On Sun, Nov 18, 2012 at 03:05:14PM -0500, pefol...@verizon.net wrote:
>> From: Peter Foley
>>
>> Silence the touch extra_certificates command
>>
>> Signed-off-by: Peter Foley
>
> I think we should tell the user that the default empty extra
> ce
d7a6a2ae7af6b6fbcea401, so I removed it -- RR ]
Tested-by: Michal Marek
Signed-off-by: Takashi Iwai
Signed-off-by: Rusty Russell
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 7d8dfc7..a123b13 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -701,13 +701,
Tim Gardner writes:
> It is $(obj)/oid_registry.o that is dependent on $(obj)/oid_registry_data.c.
> The object file cannot be built until $(obj)/oid_registry_data.c has been
> generated.
>
> A periodic and hard to reproduce parallel build failure is due to
> this incorrect lib/Makefile dependency
Linus Torvalds writes:
> On Tue, Dec 4, 2012 at 5:45 PM, Rusty Russell wrote:
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git
>
> Nothing there. Forgot to push? Forgot to send me the proper tag/
David gave me these a month ago, during my git workflow churn :(
The following changes since commit df2fc246c8ee8b6067af1fa55d3bc23107457f61:
Merge branch 'fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux (2012-12-04 09:32:12
-0800)
are available in the git repository at:
Michal Marek writes:
> Signed-off-by: Michal Marek
> ---
> scripts/sign-file |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file b/scripts/sign-file
> index 87ca59d..974a20b 100755
> --- a/scripts/sign-file
> +++ b/scripts/sign-file
> @@ -156,12 +
David Howells writes:
> Michal Marek wrote:
>
>> Using the asm .incbin statement in C sources breaks any gcc wrapper which
>> assumes that preprocessed C source is self-contained. Use a separate .S
>> file to include the siging key and certificate.
>
> I was trying to avoid that as .S files gene
"Srivatsa S. Bhat" writes:
> From: Michael Wang
>
> With stop_machine() gone from the CPU offline path, we can't depend on
> preempt_disable() to prevent CPUs from going offline from under us.
Minor gripe: I'd prefer this paragraph to use the future rather than
past tense, like: "Once stop_machi
The following changes since commit 3c46f3d6406b1d0c53575774b2d1fd013cd7f76f:
Merge branch 'for-3.7-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq (2012-12-01 17:55:13 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git
Jason Wang writes:
> On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote:
>> > +
>> > + /* Work struct for refilling if we run low on memory. */
>> > + struct delayed_work refill;
>>
>> I can't really see the justificaiton for a refill pe
" passed to module_param_named(). Admittedly, the
>> documentation says that "name" must be "a valid C identifier which is the
>> parameter name", but the (ab)usage here used to work (the name starts
>> with a number).
>
> I prefer not to change module paramete
Jason Wang writes:
> +static const struct ethtool_ops virtnet_ethtool_ops;
> +
> +/*
> + * Converting between virtqueue no. and kernel tx/rx queue no.
> + * 0:rx0 1:tx0 2:cvq 3:rx1 4:tx1 ... 2N+1:rxN 2N+2:txN
> + */
> +static int vq2txq(struct virtqueue *vq)
> +{
> + int index = virtqueue_get_
Mimi Zohar writes:
> Using the same name for ephemeral and "persistent" keys results
> in deleting the "persistent" key. This patch renames the normal
> kbuild asymmetric key pair name to "default_signing_key" and the
> ephemeral key pair name to "ephemeral_signing_key".
I like the idea: I was a
c7057ca00a9a3f47 (module: fix out-by-one error
in kallsyms) we now loop from zero, so we don't need to add an extra
byte for the first empty string.
Reported-by: satoru takeuchi
Signed-off-by: Rusty Russell
diff --git a/kernel/module.c b/kernel/module.c
index a1d2ed8..79a526d 100644
--- a/
Jason Wang writes:
> To support multiqueue transmitq/receiveq, the first step is to separate queue
> related structure from virtnet_info. This patch introduce send_queue and
> receive_queue structure and use the pointer to them as the parameter in
> functions handling sending/receiving.
OK, seems
James Hogan writes:
> These patches fix linker errors on blackfin and metag when module
> signing is enabled. This is due to the use of symbol prefixes on these
> architectures, and the asm in modsign_pubkey.c not prefixing one.
Sorry, I was away last week.
I've applied these to my fixes branch,
Mimi Zohar writes:
> From: Dmitry Kasatkin
>
> Signed modules are only as secure as the private key used to sign
> them. This patch limits access to the private key by limiting the
> private key's existence to 'modules_install'(ie. this is meant for
> local developers, not distros.)
>
> This pat
sat writes:
> From: Satoru Takeuchi
>
> There is a extra null character('\0') at the top of module->strtab for
> each module. Commit 59ef28b introduced this bug and this patch fixes it.
Hi Satoru!
Unfortunately I took a week off last week, and when I read my
mail I read your previous re
Amit Shah writes:
> From: Sjur Brændeland
>
> Remove buffers from the out-queue when a port is removed. Rproc_serial
> communicates with remote processors that may crash and leave buffers in
> the out-queue. The virtio serial ports may have buffers in the out-queue
> as well, e.g. for non-blockin
Mathias LEBLANC writes:
> Variable interrupts value must be 0 or 1. This restriction is defined by the
> fact of using the bool parameter (true or false)
But you can't pass an int to module_param(..., bool,...).
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-
Ben Hutchings writes:
> This doesn't have anyone's Signed-off-by:
>
> commit 59ef28b1f14899b10d6b2682c7057ca00a9a3f47
> Author: Rusty Russell
> Date: Thu Oct 25 10:49:25 2012 +1030
>
> module: fix out-by-one error in kallsyms
>
> It's a bit lat
Rafael Aquini writes:
> On Thu, Nov 08, 2012 at 09:32:18AM +1030, Rusty Russell wrote:
>> The first one can be delayed, the second one can be delayed if the host
>> didn't ask for VIRTIO_BALLOON_F_MUST_TELL_HOST (qemu doesn't).
>>
>> We could implement
cc'd to stable.
Cornelia Huck (1):
virtio: Don't access index after unregister.
Rusty Russell (2):
module: fix out-by-one error in kallsyms
modules: don't break modules_install on external modules with no
Cornelia Huck writes:
> Virtio wants to release used indices after the corresponding
> virtio device has been unregistered. However, virtio does not
> hold an extra reference, giving up its last reference with
> device_unregister(), making accessing dev->index afterwards
> invalid.
>
> I actually
Lee Jones writes:
>> > Resorted to poaching now have we Pawel?
>
>> I hope you were joking!
>
> Yes, of course. I thought that was clearly indicated by the jovial winking
> smiley. :)
>
> I realise it wasn't obvious soley by this exchange, but Pawel and I are
> actually ol' friends.
>
>> Doing yo
Mathias Leblanc writes:
> +static int interrupts ;
> +module_param(interrupts, bool, 0444);
> +MODULE_PARM_DESC(interrupts, "Enable interrupts");
> +
> +static int power_mgt = 1;
> +module_param(power_mgt, bool, 0444);
> +MODULE_PARM_DESC(power_mgt, "Power Management");
These are not bools, so wh
Rafael Aquini writes:
> + * virtballoon_migratepage - perform the balloon page migration on behalf of
> + *a compation thread. (called under page lock)
> + if (!mutex_trylock(&vb->balloon_lock))
> + return -EAGAIN;
Erk, OK...
> + /* balloon's page
Lee Jones writes:
> On Mon, 05 Nov 2012, Pawel Moll wrote:
>
>> On 64-bit machines resource_size_t is a 64-bit value, while
>> sscanf() format for this argument was defined as "%u". Fixed
>> by using an intermediate local value of a known length.
>>
>> Also added cleaned up the resource creation
sjur.brandel...@stericsson.com writes:
> From: Sjur Brændeland
>
> Free pending output buffers from the virtio out-queue when
> host has acknowledged port_close. Also removed WARN_ON()
> in remove_port_data().
>
> Signed-off-by: Sjur Brændeland
> ---
>
> Resending, this time including a proper "
Jan Beulich writes:
>>>> On 07.11.12 at 02:03, Rusty Russell wrote:
>>>> __COUNTER__:
>>>> Used to make a unique id. Let's define __UNIQUE_ID(prefix) for
>>>> this (using __COUNTER__ or __LINE__). 4.3 and above.
>>>
1001 - 1100 of 2237 matches
Mail list logo
