Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:48 PM, Felipe Balbi wrote: > On Fri, Sep 21, 2012 at 10:47:30PM +0530, S, Venkatraman wrote: >> On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman wrote: >> > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: >> >> The EDMA DMAC has a har

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman wrote: > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: >> The EDMA DMAC has a hardware limitation that prevents supporting >> scatter gather lists with any number of segments. Since the EDMA >> DMA Engine driver sets

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > Note: this can be removed once the

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter mpor...@ti.com wrote: The EDMA DMAC has a hardware limitation that prevents supporting scatter gather lists with any number of segments. Since the EDMA DMA Engine driver sets the maximum segments to 16, we do the same. Note: this can be removed

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman svenk...@ti.com wrote: On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter mpor...@ti.com wrote: The EDMA DMAC has a hardware limitation that prevents supporting scatter gather lists with any number of segments. Since the EDMA DMA Engine driver sets

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-21 Thread S, Venkatraman
On Fri, Sep 21, 2012 at 10:48 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Sep 21, 2012 at 10:47:30PM +0530, S, Venkatraman wrote: On Fri, Sep 21, 2012 at 10:45 PM, S, Venkatraman svenk...@ti.com wrote: On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter mpor...@ti.com wrote: The EDMA DMAC has

Re: [PATCH V2] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-17 Thread S, Venkatraman
On Thu, Sep 13, 2012 at 12:01 PM, Hebbar, Gururaja wrote: > From: Vaibhav Bedia > > In some cases mmc_suspend_host() is not able to claim the > host and proceed with the suspend process. The core returns > -EBUSY to the host controller driver. Unfortunately, the > host controller driver does not

Re: [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code

2012-09-17 Thread S, Venkatraman
On Mon, Sep 17, 2012 at 1:45 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows:

Re: [PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code

2012-09-17 Thread S, Venkatraman
On Mon, Sep 17, 2012 at 1:45 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this

Re: [PATCH V2] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-17 Thread S, Venkatraman
On Thu, Sep 13, 2012 at 12:01 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: From: Vaibhav Bedia vaibhav.be...@ti.com In some cases mmc_suspend_host() is not able to claim the host and proceed with the suspend process. The core returns -EBUSY to the host controller driver. Unfortunately,

Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja wrote: > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > Other platforms like TI81xx, OMAP4 may need this as-well. This depends > on the HSMMC IP timing closure done for the high speed cards. > > From AM335x TRM (SPRUH73F -

Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: HSMMC IP on AM33xx need a special setting to handle High-speed cards. Other platforms like TI81xx, OMAP4 may need this as-well. This depends on the HSMMC IP timing closure done for the high speed cards. From AM335x

Re: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-10 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja wrote: > From: Vaibhav Bedia > > In some cases mmc_suspend_host() is not able to claim the > host and proceed with the suspend process. The core returns > -EBUSY to the host controller driver. Unfortunately, the > host controller driver does not

Re: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-10 Thread S, Venkatraman
On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja gururaja.heb...@ti.com wrote: From: Vaibhav Bedia vaibhav.be...@ti.com In some cases mmc_suspend_host() is not able to claim the host and proceed with the suspend process. The core returns -EBUSY to the host controller driver. Unfortunately,

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-08-28 Thread S, Venkatraman
On Mon, Aug 27, 2012 at 11:58 PM, wrote: > > On Fri, July 27, 2012 2:07 am, S, Venkatraman wrote: >> On Fri, Jul 27, 2012 at 12:24 AM, wrote: >>> >>> On Thu, July 26, 2012 8:28 am, S, Venkatraman wrote: >>>> On Tue, Jul 24, 2012 at 2:14 PM, wro

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-08-28 Thread S, Venkatraman
On Mon, Aug 27, 2012 at 11:58 PM, me...@codeaurora.org wrote: On Fri, July 27, 2012 2:07 am, S, Venkatraman wrote: On Fri, Jul 27, 2012 at 12:24 AM, me...@codeaurora.org wrote: On Thu, July 26, 2012 8:28 am, S, Venkatraman wrote: On Tue, Jul 24, 2012 at 2:14 PM, me...@codeaurora.org wrote

Re: [PATCH RESEND v5] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-08-02 Thread S, Venkatraman
the cost of providing > DMA-capable buffer from upper caller(but on-stack buffer is allowed > with no performance gain). > > Signed-off-by: Kyungsik Lee > Signed-off-by: S, Venkatraman I don't think my sign off is warranted. I gave just an illustration. You can add my Re

Re: [PATCH RESEND v5] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-08-02 Thread S, Venkatraman
of providing DMA-capable buffer from upper caller(but on-stack buffer is allowed with no performance gain). Signed-off-by: Kyungsik Lee kyungsik@lge.com Signed-off-by: S, Venkatraman svenk...@ti.com I don't think my sign off is warranted. I gave just an illustration. You can add my Reviewed

Re: [PATCH RESEND v3] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-07-31 Thread S, Venkatraman
On Tue, Jul 31, 2012 at 7:30 AM, Kyungsik Lee wrote: > It is expected that Extended CSD register(the size of this register > is larger than CID/CSD) will be referenced more frequently as more > fields have been added to Extended CSD and it seems that it is not > a good option to double the memory

Re: [PATCH RESEND v3] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-07-31 Thread S, Venkatraman
On Tue, Jul 31, 2012 at 7:30 AM, Kyungsik Lee kyungsik@lge.com wrote: It is expected that Extended CSD register(the size of this register is larger than CID/CSD) will be referenced more frequently as more fields have been added to Extended CSD and it seems that it is not a good option to

Re: [PATCH RESEND v2] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-07-30 Thread S, Venkatraman
On Mon, Jul 30, 2012 at 7:34 AM, Kyungsik Lee wrote: > It is expected that Extended CSD register(the size of this register > is larger than CID/CSD) will be referenced more frequently as more > fields have been added to Extended CSD and it seems that it is not > a good option to double the memory

Re: [PATCH RESEND v2] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

2012-07-30 Thread S, Venkatraman
On Mon, Jul 30, 2012 at 7:34 AM, Kyungsik Lee kyungsik@lge.com wrote: It is expected that Extended CSD register(the size of this register is larger than CID/CSD) will be referenced more frequently as more fields have been added to Extended CSD and it seems that it is not a good option to

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-27 Thread S, Venkatraman
On Fri, Jul 27, 2012 at 12:24 AM, wrote: > > On Thu, July 26, 2012 8:28 am, S, Venkatraman wrote: >> On Tue, Jul 24, 2012 at 2:14 PM, wrote: >>> On Mon, July 23, 2012 5:22 am, S, Venkatraman wrote: >>>> On Mon, Jul 23, 2012 at 5:13 PM, wrote: >>>>

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-27 Thread S, Venkatraman
On Fri, Jul 27, 2012 at 12:24 AM, me...@codeaurora.org wrote: On Thu, July 26, 2012 8:28 am, S, Venkatraman wrote: On Tue, Jul 24, 2012 at 2:14 PM, me...@codeaurora.org wrote: On Mon, July 23, 2012 5:22 am, S, Venkatraman wrote: On Mon, Jul 23, 2012 at 5:13 PM, me...@codeaurora.org wrote

Re: [PATCH RESEND v8 2/2] mmc: card: Adding support for sanitize in eMMC 4.5

2012-07-26 Thread S, Venkatraman
On Wed, Jul 25, 2012 at 5:01 PM, Yaniv Gardi wrote: > This feature delete the unmap memory region of the eMMC card, > by writing to a specific register in the EXT_CSD > unmap region is the memory region that were previously deleted > (by erase, trim or discard operation) > > Signed-off-by: Yaniv

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-26 Thread S, Venkatraman
On Tue, Jul 24, 2012 at 2:14 PM, wrote: > On Mon, July 23, 2012 5:22 am, S, Venkatraman wrote: >> On Mon, Jul 23, 2012 at 5:13 PM, wrote: >>> On Wed, July 18, 2012 12:26 am, Chris Ball wrote: >>>> Hi, [removing Jens and the documentation list, since now we're >

Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-07-26 Thread S, Venkatraman
On Thu, Jul 26, 2012 at 4:42 PM, vinayak holikatti wrote: > On Thu, Jul 26, 2012 at 4:02 PM, S, Venkatraman wrote: >> On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti >> wrote: >>> This patch set adds following features >>> - Seggregate PCI specific code

Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-07-26 Thread S, Venkatraman
On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti wrote: > This patch set adds following features > - Seggregate PCI specific code in ufshcd.c > - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module > - Adds Platform glue driver ufshcd-pltfrm.c > - Update correct transfer size

Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-07-26 Thread S, Venkatraman
On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti vinholika...@gmail.com wrote: This patch set adds following features - Seggregate PCI specific code in ufshcd.c - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module - Adds Platform glue driver ufshcd-pltfrm.c - Update

Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-07-26 Thread S, Venkatraman
On Thu, Jul 26, 2012 at 4:42 PM, vinayak holikatti vinholika...@gmail.com wrote: On Thu, Jul 26, 2012 at 4:02 PM, S, Venkatraman svenk...@ti.com wrote: On Thu, Jul 26, 2012 at 2:12 PM, Vinayak Holikatti vinholika...@gmail.com wrote: This patch set adds following features - Seggregate PCI

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-26 Thread S, Venkatraman
On Tue, Jul 24, 2012 at 2:14 PM, me...@codeaurora.org wrote: On Mon, July 23, 2012 5:22 am, S, Venkatraman wrote: On Mon, Jul 23, 2012 at 5:13 PM, me...@codeaurora.org wrote: On Wed, July 18, 2012 12:26 am, Chris Ball wrote: Hi, [removing Jens and the documentation list, since now we're

Re: [PATCH RESEND v8 2/2] mmc: card: Adding support for sanitize in eMMC 4.5

2012-07-26 Thread S, Venkatraman
On Wed, Jul 25, 2012 at 5:01 PM, Yaniv Gardi yga...@codeaurora.org wrote: This feature delete the unmap memory region of the eMMC card, by writing to a specific register in the EXT_CSD unmap region is the memory region that were previously deleted (by erase, trim or discard operation)

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-23 Thread S, Venkatraman
On Mon, Jul 23, 2012 at 5:13 PM, wrote: > On Wed, July 18, 2012 12:26 am, Chris Ball wrote: >> Hi, [removing Jens and the documentation list, since now we're >> talking about the MMC side only] >> >> On Wed, Jul 18 2012, me...@codeaurora.org wrote: >>> Is there anything else that holds this

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-23 Thread S, Venkatraman
On Mon, Jul 23, 2012 at 5:13 PM, me...@codeaurora.org wrote: On Wed, July 18, 2012 12:26 am, Chris Ball wrote: Hi, [removing Jens and the documentation list, since now we're talking about the MMC side only] On Wed, Jul 18 2012, me...@codeaurora.org wrote: Is there anything else that holds

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-16 Thread S, Venkatraman
On Mon, Jul 16, 2012 at 8:16 AM, Chris Ball wrote: > Hi, > > On Sun, Jul 15 2012, Muthu Kumar wrote: >>> I've already replied to a later version of the patch, but just to get >>> this comment in at the appropriate point of the discussion as well: >>> >>> Even though it would result in a cleaner

Re: [PATCH v2 1/1] mmc: block: Add write packing control

2012-07-16 Thread S, Venkatraman
On Mon, Jul 16, 2012 at 8:16 AM, Chris Ball c...@laptop.org wrote: Hi, On Sun, Jul 15 2012, Muthu Kumar wrote: I've already replied to a later version of the patch, but just to get this comment in at the appropriate point of the discussion as well: Even though it would result in a cleaner

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-13 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:31 AM, wrote: > The mm-of-the-moment snapshot 2012-07-10-16-59 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > > * drivers-scsi-ufs-use-module_pci_driver.patch > * drivers-scsi-ufs-reverse-the-ufshcd_is_device_present-logic.patch > *

Re: mmotm 2012-07-10-16-59 uploaded

2012-07-13 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:31 AM, a...@linux-foundation.org wrote: The mm-of-the-moment snapshot 2012-07-10-16-59 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ * drivers-scsi-ufs-use-module_pci_driver.patch * drivers-scsi-ufs-reverse-the-ufshcd_is_device_present-logic.patch *

Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-12 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman wrote: > If platform_get_resource_by_name() fails, driver probe is aborted an > should return an error so the driver is not bound to the device. > > However, in the current error path of platform_get_resource_by_name(), > probe returns zero since the

Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-12 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman khil...@ti.com wrote: If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero