Re: [PATCH 1/1] net/mlx5: Call pci_disable_sriov() on remove

On Thu, 2020-04-30 at 14:03 +0200, Niklas Schnelle wrote: > as described in Documentation/PCI/pci-iov-howto.rst a driver with SR- > IOV > support should call pci_disable_sriov() in the remove handler. Hi Niklas, looking at the documentation, it doesn't say "should" it just gives the code as

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

unately there is no good error handling > in case the allocation fails. > I don't really mind this, since this is only for debugfs and 0 is not a valid value anyway. Acked-by: Saeed Mahameed this should go to mlx5-next, i will let Leon decide and pick this up. > Fixes: 57a6c5e992f5 (&qu

Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

On Tue, 2019-10-15 at 20:29 +, Saeed Mahameed wrote: > On Tue, 2019-10-01 at 17:14 +0200, Michal Kubecek wrote: > > On Mon, Sep 30, 2019 at 08:40:31PM +0200, Borislav Petkov wrote: > > > On Mon, Sep 30, 2019 at 09:55:16AM -0700, Stephen Hemminger > > > wrote: > &

Re: [PATCH] net/mlx5: prevent memory leak in mlx5_fpga_conn_create_cq

On Fri, 2019-09-27 at 10:33 +0200, David Miller wrote: > From: Navid Emamdoost > Date: Tue, 24 Sep 2019 22:20:34 -0500 > > > In mlx5_fpga_conn_create_cq if mlx5_vector2eqn fails the allocated > > memory should be released. > > > > Signed-off-by: Navid Emamdoost > > Saeed, please queue this

Re: [PATCH] net/mlx5: fix memory leak in mlx5_fw_fatal_reporter_dump

On Fri, 2019-09-27 at 17:37 -0500, Navid Emamdoost wrote: > In mlx5_fw_fatal_reporter_dump if mlx5_crdump_collect fails the > allocated memory for cr_data must be released otherwise there will be > memory leak. To fix this, this commit changes the return instruction > into goto error handling. >

Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

On Tue, 2019-10-01 at 17:14 +0200, Michal Kubecek wrote: > On Mon, Sep 30, 2019 at 08:40:31PM +0200, Borislav Petkov wrote: > > On Mon, Sep 30, 2019 at 09:55:16AM -0700, Stephen Hemminger wrote: > > > Could also us div_u64_rem here? > > > > Yah, the below seems to work and the resulting asm looks

Re: [PATCH] net/mlx5: Remove unneeded variable in mlx5_unload_one

On Sun, 2019-09-15 at 19:53 +0100, David Miller wrote: > From: zhong jiang > Date: Fri, 13 Sep 2019 00:59:02 +0800 > > > mlx5_unload_one do not need local variable to store different > value, > > Hence just remove it. > > > > Signed-off-by: zhong jiang > > Saeed, just take this directly via

Re: [PATCH] net/mlx5: Remove unneeded variable in mlx5_unload_one

mlx5_drain_health_wq(dev); > @@ -1257,7 +1255,7 @@ static int mlx5_unload_one(struct mlx5_core_dev > *dev, bool cleanup) > mlx5_function_teardown(dev, cleanup); > out: > mutex_unlock(>intf_state_mutex); > - return err; > + return 0; > } > > static int mlx5_mdev_init(struct mlx5_core_dev *dev, int > profile_idx) Acked-by: Saeed Mahameed

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

On Tue, 2019-09-10 at 15:38 +, David Laight wrote: > From: Arnd Bergmann > > Sent: 10 September 2019 09:15 > ... > > > I am not sure how this would work, since the format parameters > > > can > > > changes depending on the FW string and the specific traces. > > > > Ah, so the format string

Re: [PATCH] net/mlx5: Declare 'rt' as corresponding enum type

On Tue, 2019-09-10 at 18:27 +0900, Austin Kim wrote: > When building kernel with clang, we can observe below warning > message: > > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9: > warning: implicit conversion from enumeration type 'enum > mlx5_reformat_ctx_type' > to

Re: [PATCH net-next 2/2] mlx5: fix type mismatch

On Mon, 2019-09-09 at 21:50 +0200, Arnd Bergmann wrote: > In mlx5, pointers to 'phys_addr_t' and 'u64' are mixed since the > addition > of the pool memory allocator, leading to incorrect behavior on 32-bit > architectures and this compiler warning: > >

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

On Mon, 2019-09-09 at 22:18 +0200, Arnd Bergmann wrote: > On Mon, Sep 9, 2019 at 9:39 PM Saeed Mahameed > wrote: > > On Fri, 2019-09-06 at 17:11 +0200, Arnd Bergmann wrote: > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c > > > +++ b/drivers/n

Re: [PATCH] net/mlx5: reduce stack usage in FW tracer

On Fri, 2019-09-06 at 17:11 +0200, Arnd Bergmann wrote: > It's generally not ok to put a 512 byte buffer on the stack, as > kernel > stack is a scarce resource: > > drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c:660:13: > error: stack frame size of 1032 bytes in function >

Re: [PATCH][next] net/mlx5: fix missing assignment of variable err

On Wed, 2019-09-04 at 20:29 +0100, Colin King wrote: > From: Colin Ian King > > The error return from a call to mlx5_flow_namespace_set_peer is not > being assigned to variable err and hence the error check following > the call is currently not working. Fix this by assigning ret as > intended.

Re: [PATCH][next] net/mlx5: fix spelling mistake "offlaods" -> "offloads"

On Wed, 2019-09-04 at 20:38 +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a NL_SET_ERR_MSG_MOD error message. > Fix it. > > Signed-off-by: Colin Ian King > Applied to net-next-mlx5. Thanks, Saeed.

Re: [PATCH] net/mlx5: Use PTR_ERR_OR_ZERO rather than its implementation

On Tue, 2019-09-03 at 20:08 +, Saeed Mahameed wrote: > On Tue, 2019-09-03 at 14:56 +0800, zhong jiang wrote: > > PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better > > to use it directly. hence just replace it. > > > > Signed-off-by: zhong jian

Re: [PATCH] net/mlx5: Use PTR_ERR_OR_ZERO rather than its implementation

eturn PTR_ERR(flow->rule[0]); > - > - return 0; > + return PTR_ERR_OR_ZERO(flow->rule[0]); > } > > static void mlx5e_tc_del_nic_flow(struct mlx5e_priv *priv, Acked-by: Saeed Mahameed

Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies

On Tue, 2019-08-27 at 11:12 +0800, Mao Wenan wrote: > When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors The issue happens when PCI_HYPERV_INTERFACE is a module and mlx5_core is built-in. > are found: > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function >

Re: linux-next: Tree for Aug 29 (mlx5)

On Thu, 2019-08-29 at 21:48 +, Haiyang Zhang wrote: > > -Original Message- > > From: Saeed Mahameed > > Sent: Thursday, August 29, 2019 2:32 PM > > To: s...@canb.auug.org.au; Eran Ben Elisha ; > > linux- > > n...@vger.kernel.org; rdun...@infradead.o

Re: linux-next: Tree for Aug 29 (mlx5)

On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote: > On 8/29/19 12:54 PM, Randy Dunlap wrote: > > On 8/29/19 4:08 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20190828: > > > > > > > on x86_64: > > when CONFIG_PCI_HYPERV=m > > and CONFIG_PCI_HYPERV_INTERFACE=m >

Re: [PATCH v3 03/11] net/mlx5e: Remove unlikely() from WARN*() condition

On Thu, 2019-08-29 at 19:50 +0300, Denis Efremov wrote: > "unlikely(WARN_ON_ONCE(x))" is excessive. WARN_ON_ONCE() already uses > unlikely() internally. > > Signed-off-by: Denis Efremov > Cc: Boris Pismenny > Cc: Saeed Mahameed > Cc: Leon Romanovsky > Cc

Re: [PATCH] net/mlx5: fix a -Wstringop-truncation warning

On Fri, 2019-08-23 at 15:56 -0400, Qian Cai wrote: > In file included from ./arch/powerpc/include/asm/paca.h:15, > from ./arch/powerpc/include/asm/current.h:13, > from ./include/linux/thread_info.h:21, > from ./include/asm-generic/preempt.h:5, >

Re: [PATCH] net/mlx5: fix a -Wstringop-truncation warning

On Tue, 2019-08-27 at 16:12 -0400, Qian Cai wrote: > On Mon, 2019-08-26 at 21:11 +0000, Saeed Mahameed wrote: > > On Fri, 2019-08-23 at 15:56 -0400, Qian Cai wrote: > > > In file included from ./arch/powerpc/include/asm/paca.h:15, > > > from ./arch/power

Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies

On Tue, 2019-08-27 at 17:51 +0800, maowenan wrote: > > On 2019/8/27 15:24, walter harms wrote: > > > > Am 27.08.2019 05:12, schrieb Mao Wenan: > > > When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below > > > errors are found: > > > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In

Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies

On Tue, 2019-08-27 at 11:12 +0800, Mao Wenan wrote: > When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors > are found: > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function > `mlx5e_nic_enable': > en_main.c:(.text+0xb649): undefined reference to >

Re: [PATCH] net: Adding parameter detection in __ethtool_get_link_ksettings.

On Mon, 2019-08-26 at 17:47 +0800, Dongxu Liu wrote: > > On 8/26/19 9:23 AM, Dongxu Liu wrote: > > The __ethtool_get_link_ksettings symbol will be exported, > > and external users may use an illegal address. > > We should check the parameters before using them, > > otherwise the system will crash.

Re: [PATCH] net/mlx5: fix a -Wstringop-truncation warning

On Fri, 2019-08-23 at 15:56 -0400, Qian Cai wrote: > In file included from ./arch/powerpc/include/asm/paca.h:15, > from ./arch/powerpc/include/asm/current.h:13, > from ./include/linux/thread_info.h:21, > from ./include/asm-generic/preempt.h:5, >

Re: [PATCH] net/mlx5: fix a -Wstringop-truncation warning

On Fri, 2019-08-23 at 15:18 -0700, David Miller wrote: > Saeed, I assume I'll get this from you. Yes, i will handle it.

Re: [PATCH net-next,v5, 0/6] Add software backchannel and mlx5e HV VHCA stats

On Thu, 2019-08-22 at 15:39 -0700, David Miller wrote: > From: Haiyang Zhang > Date: Thu, 22 Aug 2019 22:37:13 + > > > The v5 is pretty much the same as v4, except Eran had a fix to > patch #3 in response to > > Leon Romanovsky . > > Well you now have to send me a patch relative to v4 in

Re: [PATCH] net/mlx5: Fix a memory leak bug

On Tue, 2019-08-13 at 03:21 -0500, Wenwen Wang wrote: > In mlx5_cmd_invoke(), 'ent' is allocated through kzalloc() in > alloc_cmd(). > After the work is queued, wait_func() is invoked to wait the > completion of > the work. If wait_func() returns -ETIMEDOUT, the following execution > will > be

Re: [PATCH v3] mlx5: Use refcount_t for refcount

On Wed, 2019-08-07 at 06:17 +0300, Leon Romanovsky wrote: > On Tue, Aug 06, 2019 at 08:40:11PM +0000, Saeed Mahameed wrote: > > On Tue, 2019-08-06 at 09:59 +0800, Chuhong Yuan wrote: > > > Reference counters are preferred to use refcount_t instead of > > > atom

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

On Tue, 2019-08-06 at 13:48 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 6 Aug 2019 20:42:56 + > > > On Sat, 2019-08-03 at 00:48 +0800, Chuhong Yuan wrote: > > > refcount_t is better for reference counters since its > > > implementatio

Re: [PATCH][net-next][V2] net/mlx5: remove self-assignment on esw->dev

On Fri, 2019-08-02 at 16:13 +0100, Colin King wrote: > From: Colin Ian King > > There is a self assignment of esw->dev to itself, clean this up by > removing it. Also make dev a const pointer. > > Addresses-Coverity: ("Self assignment") > Fixes: 6cedde451399 ("net/mlx5: E-Switch, Verify support

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

On Sat, 2019-08-03 at 00:48 +0800, Chuhong Yuan wrote: > refcount_t is better for reference counters since its > implementation can prevent overflows. > So convert atomic_t ref counters to refcount_t. > > Signed-off-by: Chuhong Yuan > --- > Changes in v2: > - Add #incl

Re: [PATCH v3] mlx5: Use refcount_t for refcount

On Tue, 2019-08-06 at 09:59 +0800, Chuhong Yuan wrote: > Reference counters are preferred to use refcount_t instead of > atomic_t. > This is because the implementation of refcount_t can prevent > overflows and detect possible use-after-free. > So convert atomic_t ref counters to refcount_t. > >

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

On Tue, 2019-08-06 at 15:38 -0300, Jason Gunthorpe wrote: > On Tue, Aug 06, 2019 at 09:59:58AM +0300, Leon Romanovsky wrote: > > On Mon, Aug 05, 2019 at 08:06:36PM +0000, Saeed Mahameed wrote: > > > On Mon, 2019-08-05 at 14:55 +0800, Chuhong Yuan wrote: > > > > On Mo

Re: [PATCH v2] net/mlx5e: Use refcount_t for refcount

On Mon, 2019-08-05 at 14:55 +0800, Chuhong Yuan wrote: > On Mon, Aug 5, 2019 at 2:13 PM Leon Romanovsky > wrote: > > On Sun, Aug 04, 2019 at 10:44:47PM +0800, Chuhong Yuan wrote: > > > On Sun, Aug 4, 2019 at 8:59 PM Leon Romanovsky > > > wrote: > > > > On Sat, Aug 03, 2019 at 12:48:28AM +0800,

Re: [PATCH] net/mlx4_core: Use refcount_t for refcount

On Sat, 2019-08-03 at 00:10 +0800, Chuhong Yuan wrote: > Chuhong Yuan 于2019年8月2日周五 下午8:10写道： > > refcount_t is better for reference counters since its > > implementation can prevent overflows. > > So convert atomic_t ref counters to refcount_t. > > > > Also convert refcount from 0-based to

Re: [PATCH V2] mlx5: Fix formats with line continuation whitespace

On Fri, 2019-08-02 at 11:09 -0700, Joe Perches wrote: > On Tue, 2018-11-06 at 16:34 -0500, Doug Ledford wrote: > > On Thu, 2018-11-01 at 09:34 +0200, Leon Romanovsky wrote: > > > On Thu, Nov 01, 2018 at 12:24:08AM -0700, Joe Perches wrote: > > > > The line continuations unintentionally add

Re: [PATCH] net/mlx5: fix -Wtype-limits compilation warnings

On Mon, 2019-07-22 at 14:34 -0400, Qian Cai wrote: > The commit b9a7ba556207 ("net/mlx5: Use event mask based on device > capabilities") introduced a few compilation warnings due to it bumps > MLX5_EVENT_TYPE_MAX from 0x27 to 0x100 which is always greater than > an "struct {mlx5_eqe|mlx5_nb}.type"

Re: [PATCH V4 net-next 00/10] net: hns3: some code optimizations & bugfixes & features

gt;V4: replace netif_info with netif_dbg in [patch 6/10] > V2->V3: fixes comments from Saeed Mahameed and Joe Perches. > V1->V2: fixes comments from Saeed Mahameed and > removes previous [patch 4/11] and [patch 11/11] > which needs further discussion, and adds a new > patch [10/10] suggested by Saeed Mahameed. > Reviewed-by: Saeed Mahameed

Re: [PATCH net-next 08/11] net: hns3: add interrupt affinity support for misc interrupt

On Thu, 2019-07-25 at 10:05 +0800, Yunsheng Lin wrote: > On 2019/7/25 3:24, Saeed Mahameed wrote: > > On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > > > From: Yunsheng Lin > > > [...] > > > > > > +static void hclge_irq_affinity_no

Re: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause

On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote: > From: Yonglong Liu > > Some times just see the eth interface have been down/up via > dmesg, but can not know why the eth down. So adds some debug > messages to identify the cause for this. > > Signed-off-by: Yonglong Liu > Signed-off-by:

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

On Thu, 2019-07-25 at 20:28 +0800, liuyonglong wrote: > > On 2019/7/25 3:12, Saeed Mahameed wrote: > > On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > > > From: Yonglong Liu > > > > > > Some times just see the eth interface have been down/u

Re: [PATCH net-next 06/11] net: hns3: modify firmware version display format

On Thu, 2019-07-25 at 10:34 +0800, tanhuazhong wrote: > > On 2019/7/25 2:34, Saeed Mahameed wrote: > > On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > > > From: Yufeng Mo > > > > > > This patch modifies firmware version display format in > >

Re: [PATCH net-next 08/11] net: hns3: add interrupt affinity support for misc interrupt

On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > From: Yunsheng Lin > > The misc interrupt is used to schedule the reset and mailbox > subtask, and a 1 sec timer is used to schedule the service > subtask, which does periodic work. > > This patch sets the above three subtask's affinity

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

On Mon, 2019-04-29 at 12:03 +, Jeroen Hofstee wrote: > As already mentioned in [1] and included in [2], there is an off by > one > issue since the high bank is already enabled when the _next_ mailbox > to > be read has index 12, so the mailbox being read was 13. The message > can > therefore

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

On Wed, 2019-07-24 at 13:19 +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi, > > Saeed Mahameed 於 2019/7/24 上午 05:38 寫道: > > On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: > > > This patch add support for Fintek PCIE to 2 CAN controller > > > suppo

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > From: Yonglong Liu > > Some times just see the eth interface have been down/up via > dmesg, but can not know why the eth down. So adds some debug > messages to identify the cause for this. > I really don't like this. your default msg lvl

Re: [PATCH net-next 06/11] net: hns3: modify firmware version display format

On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > From: Yufeng Mo > > This patch modifies firmware version display format in > hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds > some optimizations for firmware version display format. > > Signed-off-by: Yufeng Mo > Signed-off-by:

Re: [PATCH net-next 04/11] net: hns3: fix mis-counting IRQ vector numbers issue

On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: > From: Yonglong Liu > > The num_msi_left means the vector numbers of NIC, but if the > PF supported RoCE, it contains the vector numbers of NIC and > RoCE(Not expected). > > This may cause interrupts lost in some case, because of the > NIC

Re: [PATCH net-next] [net-next] mlx4: avoid large stack usage in mlx4_init_hca()

c allocation instead of putting them > on stack. This gets the combined stack frame down to 424 bytes. > > Signed-off-by: Arnd Bergmann Reviewed-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx4/main.c | 66 +-- > > 1 file changed, 39 ins

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: > This patch add support for Fintek PCIE to 2 CAN controller support > > Signed-off-by: Ji-Ze Hong (Peter Hong) > > --- > Changelog: > v2: > 1: Fix comment on the spinlock with write access. > 2: Use ARRAY_SIZE instead

Re: [PATCH net-next 1/3] enetc: Add mdio bus driver for the PCIe MDIO endpoint

On Tue, 2019-07-23 at 18:15 +0300, Claudiu Manoil wrote: > ENETC ports can manage the MDIO bus via local register > interface. However there's also a centralized way > to manage the MDIO bus, via the MDIO PCIe endpoint > device integrated by the same root complex that also > integrates the ENETC

Re: [PATCH] net: broadcom: Use dev_get_drvdata

On Tue, 2019-07-23 at 21:19 +0800, Chuhong Yuan wrote: > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > Hi Chuhong, i see that you have generated many stand alone patches that belong to the same series/patchset. A better way to do this is to

Re: [PATCH] linux/dim: fix -Wunused-const-variable warnings

On Mon, 2019-07-22 at 09:08 -0400, Qian Cai wrote: > There are a lot of compilation warnings due to tx_profile[] and > rx_profile[] are only used in lib/dim/net_dim.c but > include/linux/dim.h > is included elsewhere. > > In file included from ./include/rdma/ib_verbs.h:64, > from

Re: [PATCH] net/mlx5: fix -Wtype-limits compilation warnings

On Mon, Jul 22, 2019 at 12:09 PM David Miller wrote: > > From: Qian Cai > Date: Mon, 22 Jul 2019 14:34:42 -0400 > > > The commit b9a7ba556207 ("net/mlx5: Use event mask based on device > > capabilities") introduced a few compilation warnings due to it bumps > > MLX5_EVENT_TYPE_MAX from 0x27 to

Re: [PATCH v2] net/mlx5: Replace kfree with kvfree

gt; dump") > Signed-off-by: Chuhong Yuan Acked-by: Saeed Mahameed Dave, i guess this can go to net. Thanks, Saeed. > --- > Changes in v2: > - Add corresponding Fixes tag > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] [net-next, netfilter] mlx5: avoid unused variable warning

On Fri, 2019-07-12 at 10:57 +0200, Arnd Bergmann wrote: > Without CONFIG_MLX5_ESWITCH we get a harmless warning: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3467:21: error: > unused variable 'priv' [-Werror,-Wunused-variable] > struct mlx5e_priv *priv = netdev_priv(dev); > Hi

Re: [PATCH] net/mlx5e: Move priv variable into case statement in mlx5e_setup_tc

On Wed, Jul 10, 2019 at 12:05 PM Nathan Chancellor wrote: > > There is an unused variable warning on arm64 defconfig when > CONFIG_MLX5_ESWITCH is unset: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3467:21: warning: > unused variable 'priv' [-Wunused-variable] > struct

Re: [PATCH net-next] net: mlx5: Fix compiling error in tls.c

On Wed, Jul 10, 2019 at 2:33 AM Mao Wenan wrote: > > There are some errors while compiling tls.c if > CONFIG_MLX5_FPGA_TLS is not obvious on. > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c: In function > mlx5e_tls_set_ipv4_flow: > ./include/linux/mlx5/device.h:61:39: error: invalid

Re: [PATCH v7 net-next 1/5] net: core: page_pool: add user refcnt and reintroduce page_pool_destroy

ctually have a bug in this area, which is > > solved by this API change. > > This patch and the mlx5 part looks good to me, Reviewed-by: Saeed Mahameed > > This patch is a modified version of Ivan Khoronzhu's original patch. > > > > Link: > > https://lore.kernel.org

Re: linux-next: manual merge of the mlx5-next tree with the net-next tree

On Wed, Jun 26, 2019 at 9:09 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the mlx5-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > > between commits: > > 955858009708 ("net/mlx5e: Fix number of vports for ingress ACL >

Re: [PATCH] [v2] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create

en to, we can statically allocate > it to avoid the stack usage. To be on the safe side, mark all > subsequent function arguments that we pass it into as 'const' > as well. > > Fixes: 10caabdaad5a ("net/mlx5e: Use termination table for VLAN push > actions") > Signed-off-by: A

Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

devlink_alloc(void) > { > return devlink_alloc(_devlink_ops, sizeof(struct > mlx5_core_dev)); > } Acked-by: Saeed Mahameed Dave, this one can go to net-next. Thanks, Saeed.

Re: [PATCH] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create

On Mon, 2019-06-17 at 14:02 -0700, David Miller wrote: > From: Arnd Bergmann > Date: Mon, 17 Jun 2019 13:08:22 +0200 > > > Putting an empty 'mlx5_flow_spec' structure on the stack is a bit > > wasteful and causes a warning on 32-bit architectures when building > > with clang -fsanitize-coverage:

Re: [PATCH] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create

On Mon, 2019-06-17 at 13:08 +0200, Arnd Bergmann wrote: > Putting an empty 'mlx5_flow_spec' structure on the stack is a bit > wasteful and causes a warning on 32-bit architectures when building > with clang -fsanitize-coverage: > >

Re: [PATCH v2 net-next 7/7] net: ethernet: ti: cpsw: add XDP support

On Fri, 2019-05-31 at 20:03 +0300, Ivan Khoronzhuk wrote: > On Fri, May 31, 2019 at 06:32:41PM +0200, Jesper Dangaard Brouer > wrote: > > On Fri, 31 May 2019 19:25:24 +0300 Ivan Khoronzhuk < > > ivan.khoronz...@linaro.org> wrote: > > > > > On Fri, May 31, 2019 at 05:46:43PM +0200, Jesper Dangaard

Re: mlx5_core failed to load with 5.1.0-rc7-next-20190430+

On Wed, 2019-05-01 at 10:24 -0400, Qian Cai wrote: > On Tue, 2019-04-30 at 20:26 -0700, Saeed Mahameed wrote: > > On Tue, Apr 30, 2019 at 8:00 PM Saeed Mahameed > > wrote: > > > On Tue, Apr 30, 2019 at 6:23 PM Qian Cai wrote: > > > > Reverted the commit b169e

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, 2019-04-01 at 09:11 +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c > > between commit: > > e28408e98bce ("net/mlx5e: Update xon formula") > > from the net

Re: [PATCH] net: mlx5: fix a potential NULL pointer dereference

On Mon, 2019-03-11 at 01:33 -0500, Kangjie Lu wrote: > In case skb_header_pointer fails, the fix issues a warning. > This case is impossible: mlx5 driver builds this skb itself so we are sure skb_header_pointer never fails. What is the motivation behind this fix? static checker or actual issue

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

On Tue, 2019-03-05 at 19:03 -0800, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 5 Mar 2019 22:21:39 + > > > On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > > > On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: > > > > On 0

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

f fixes line is relevant or not. > > beside that looks ok. > > It doesn't matter if it is real issue or not, the code is wrong and > should be fixed. This alone is enough to see the Fixes line. > > Thanks, > Acked-by: Leon Romanovsky Acked-by: Saeed Mahameed Dave, Do you think such patch should go to net, or do you want me to send it in my next pull request to net-next, once it is open of course ?

Re: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

On Thu, 2019-02-28 at 23:37 -0600, Parav Pandit wrote: > Add a subdev driver to probe the subdev devices and create fake > netdevice for it. > > Signed-off-by: Parav Pandit > --- > drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/main.c |

Re: linux-next: manual merge of the rdma tree with the net tree

On Sun, Dec 16, 2018 at 4:08 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > include/linux/mlx5/mlx5_ifc.h > > between commit: > > 663f146f2ecf ("net/mlx5: E-Switch, Fix fdb cap bits swap") > > from the net tree and commit: > >

Re: linux-next: manual merge of the net-next tree with the net tree

On Sun, Dec 16, 2018 at 4:25 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > between commit: > > 154e62abe9cd ("net/mlx5e: Properly initialize flow attributes for slow path >

Re: [PATCH, net-next] net/mlx5e: fix TLS dependency

tually work. The existing dependency on TLS_DEVICE is > not sufficient here since MLX5_EN_TLS is a 'bool' symbol. > > Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- LGTM Acked-by: Saeed Mahame

Re: [PATCH, net-next] net/mlx5e: fix TLS dependency

tually work. The existing dependency on TLS_DEVICE is > not sufficient here since MLX5_EN_TLS is a 'bool' symbol. > > Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support") > Signed-off-by: Arnd Bergmann > --- LGTM Acked-by: Saeed Mahameed Thank you Arnd!

Re: [PATCH v3] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

On Wed, 2018-05-16 at 21:07 +0200, Christophe JAILLET wrote: > When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used > to > free it. > > Fixes: 1cbe6fc86ccfe ("IB/mlx5: Add support for CQE compressing") > Fixes: fed9ce22bf8ae ("net/mlx5: E-Switch, Add API to create vport rx >

Re: [PATCH v3] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

On Wed, 2018-05-16 at 21:07 +0200, Christophe JAILLET wrote: > When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used > to > free it. > > Fixes: 1cbe6fc86ccfe ("IB/mlx5: Add support for CQE compressing") > Fixes: fed9ce22bf8ae ("net/mlx5: E-Switch, Add API to create vport rx >

Re: [PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

>> err_cqb: >> - kfree(*cqb); >> + kvfree(*cqb); > > For the infiniband part: > > Acked-by: Jason Gunthorpe <j...@mellanox.com> > > Since this is mostly ethernet, can it go through netdev? thanks > for the mlx5 core parts: Acked-by: Saeed Ma

Re: [PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

ee(*cqb); > > For the infiniband part: > > Acked-by: Jason Gunthorpe > > Since this is mostly ethernet, can it go through netdev? thanks > for the mlx5 core parts: Acked-by: Saeed Mahameed Yes i will take v3 to mlx5-next branch. > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

On Mon, May 14, 2018 at 11:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Sat, 12 May 2018 19:09:25 +0200 > >> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. >> >> Signed-off-by: Christophe JAILLET

Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

On Mon, May 14, 2018 at 11:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Sat, 12 May 2018 19:09:25 +0200 > >> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. >> >> Signed-off-by: Christophe JAILLET > > Saeed, I assume I will see this in one of your

Re: linux-next: Tree for May 9 (mlx5)

On Wed, 2018-05-09 at 08:31 -0700, Randy Dunlap wrote: > On 05/09/2018 04:21 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180508: > > > > on x86_64: > # CONFIG_SMP is not set > > In file included from > ../drivers/net/ethernet/mellanox/mlx5/core/main.c:43:0: >

Re: linux-next: Tree for May 9 (mlx5)

On Wed, 2018-05-09 at 08:31 -0700, Randy Dunlap wrote: > On 05/09/2018 04:21 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180508: > > > > on x86_64: > # CONFIG_SMP is not set > > In file included from > ../drivers/net/ethernet/mellanox/mlx5/core/main.c:43:0: >

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

On Wed, 2018-05-09 at 15:19 -0700, Guenter Roeck wrote: > On Sun, May 06, 2018 at 09:33:26AM +0200, Thomas Gleixner wrote: > > On Sat, 5 May 2018, Guenter Roeck wrote: > > > > > On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > > > > Adding the vector offset when calling to

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

On Wed, 2018-05-09 at 15:19 -0700, Guenter Roeck wrote: > On Sun, May 06, 2018 at 09:33:26AM +0200, Thomas Gleixner wrote: > > On Sat, 5 May 2018, Guenter Roeck wrote: > > > > > On Thu, Apr 12, 2018 at 09:49:11AM +, Israel Rukshin wrote: > > > > Adding the vector offset when calling to

Re: [PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

On Thu, 2018-05-03 at 14:44 -0400, David Miller wrote: > From: Colin King > Date: Thu, 3 May 2018 14:35:03 +0100 > > > From: Colin Ian King > > > > Trivial fix to spelling mistake in netdev_warn warning message > > > > Signed-off-by: Colin

Re: [PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

On Thu, 2018-05-03 at 14:44 -0400, David Miller wrote: > From: Colin King > Date: Thu, 3 May 2018 14:35:03 +0100 > > > From: Colin Ian King > > > > Trivial fix to spelling mistake in netdev_warn warning message > > > > Signed-off-by: Colin Ian King > > Saeed, please send this to me in your

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 4:30 PM, Saeed Mahameed <sae...@dev.mellanox.co.il> wrote: > On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang <qing.hu...@oracle.com> wrote: >> >> >> On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >>> >>> On Thu, Apr 26, 2018 a

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 4:30 PM, Saeed Mahameed wrote: > On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang wrote: >> >> >> On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >>> >>> On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: >>>>

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang <qing.hu...@oracle.com> wrote: > > > On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >> >> On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang <qing.hu...@oracle.com> wrote: >>> >>> Current stats collec

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 3:37 PM, Qing Huang wrote: > > > On 04/26/2018 02:50 PM, Saeed Mahameed wrote: >> >> On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: >>> >>> Current stats collecting scheme in mlx5 driver is to periodically fetch >>> ag

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: > Current stats collecting scheme in mlx5 driver is to periodically fetch > aggregated stats from all the active mlx5 software channels associated > with the device. However when a mlx5 interface is brought down(ifdown), >

Re: [PATCH] net/mlx5: report persistent netdev stats across ifdown/ifup commands

On Thu, Apr 26, 2018 at 1:37 PM, Qing Huang wrote: > Current stats collecting scheme in mlx5 driver is to periodically fetch > aggregated stats from all the active mlx5 software channels associated > with the device. However when a mlx5 interface is brought down(ifdown), > all the channels will

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Mon, 2018-04-09 at 13:43 +0100, Colin King wrote: > From: Colin Ian King > > There are several lines where there is an extraneous space causing > indentation misalignment. Remove them. > > Cleans up Cocconelle warnings: > >

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Mon, 2018-04-09 at 13:43 +0100, Colin King wrote: > From: Colin Ian King > > There are several lines where there is an extraneous space causing > indentation misalignment. Remove them. > > Cleans up Cocconelle warnings: > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Tue, 2018-04-10 at 17:27 -0600, Jason Gunthorpe wrote: > On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote: > > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > > > From: Colin Ian King > > > > > > There are several lines where there is

Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations

On Tue, 2018-04-10 at 17:27 -0600, Jason Gunthorpe wrote: > On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote: > > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote: > > > From: Colin Ian King > > > > > > There are several lines where there is an extraneous space > > >

<    1   2   3   >