[PATCHv2] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-08-17 Thread Sai Prakash Ranjan
commit msg change) Signed-off-by: Sai Prakash Ranjan --- Changes in v2: * Fix build errors reported by kernel test robot. --- drivers/soc/qcom/llcc-qcom.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qc

Re: [PATCH] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-08-17 Thread Sai Prakash Ranjan
to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sai-Prakash-Ranjan/soc-qcom-llcc-Support-chipsets-that-can-write-to-llcc-registers/20200817-161342

[PATCH] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-08-17 Thread Sai Prakash Ranjan
commit msg change) Signed-off-by: Sai Prakash Ranjan --- drivers/soc/qcom/llcc-qcom.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 429b5a60a1ba..20619d15ecba 100644 --- a/drivers/soc/qcom/llcc-qc

[PATCH] arm64: dts: qcom: sc7180: Fix the LLCC base register size

2020-08-16 Thread Sai Prakash Ranjan
Add Last level cache controller node") Signed-off-by: Sai Prakash Ranjan --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index d46b3833e52f..e875f6c3b6

Re: [PATCH] arm64: Add KRYO4XX gold CPU core to spectre-v2 safe list

2020-08-14 Thread Sai Prakash Ranjan
On 2020-08-14 13:47, Marc Zyngier wrote: On 2020-08-14 05:34, Sai Prakash Ranjan wrote: On 2020-08-13 23:29, Marc Zyngier wrote: [...] We'd need to disable the late onlining of CPUs that would change the mitigation state, and this is... ugly. Ugh, yes indeed and here I was thinking

Re: [PATCH] soc: qcom: socinfo: add SC7180 entry to soc_id array

2020-08-13 Thread Sai Prakash Ranjan
machine(struct device *dev, unsigned int id) From the chipinfo document that I have at hand, this is correct soc id for SC7180, so Reviewed-by: Sai Prakash Ranjan Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] arm64: Add KRYO4XX gold CPU core to spectre-v2 safe list

2020-08-13 Thread Sai Prakash Ranjan
On 2020-08-13 23:29, Marc Zyngier wrote: On 2020-08-13 13:33, Sai Prakash Ranjan wrote: On 2020-08-13 16:09, Marc Zyngier wrote: On 2020-08-13 10:40, Will Deacon wrote: On Thu, Aug 13, 2020 at 02:49:37PM +0530, Sai Prakash Ranjan wrote: On 2020-08-13 14:33, Will Deacon wrote: > On Thu,

Re: [PATCH] arm64: Add KRYO4XX gold CPU core to spectre-v2 safe list

2020-08-13 Thread Sai Prakash Ranjan
On 2020-08-13 16:09, Marc Zyngier wrote: On 2020-08-13 10:40, Will Deacon wrote: On Thu, Aug 13, 2020 at 02:49:37PM +0530, Sai Prakash Ranjan wrote: On 2020-08-13 14:33, Will Deacon wrote: > On Thu, Aug 13, 2020 at 01:48:34PM +0530, Sai Prakash Ranjan wrote: > > KRYO4XX gold/big

Re: [PATCH] arm64: Add KRYO4XX gold CPU core to spectre-v2 safe list

2020-08-13 Thread Sai Prakash Ranjan
On 2020-08-13 14:33, Will Deacon wrote: On Thu, Aug 13, 2020 at 01:48:34PM +0530, Sai Prakash Ranjan wrote: KRYO4XX gold/big CPU cores are based on Cortex-A76 which has CSV2 bits set and are spectre-v2 safe. But on big.LITTLE systems where they are coupled with other CPU cores

[PATCH] arm64: Add KRYO4XX gold CPU core to spectre-v2 safe list

2020-08-13 Thread Sai Prakash Ranjan
that CSV2 bits are not set for KRYO4XX gold cores. Reported-by: Stephen Boyd Signed-off-by: Sai Prakash Ranjan --- arch/arm64/kernel/cpu_errata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c index 6bd1d3ad037a..6cbdd2d98a2a 100644

[PATCH] scsi: ufs-qcom: Remove unused msm bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
as they are currently no-op anyways and the scaling support that may be added in future will use interconnect apis. Signed-off-by: Sai Prakash Ranjan --- drivers/scsi/ufs/ufs-qcom.c | 225 +--- drivers/scsi/ufs/ufs-qcom.h | 11 -- 2 files changed, 1 insertion(+), 235

[PATCH 2/2] drm/msm/mdp5: Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Signed-off-by: Sai Prakash Ranjan --- .../gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 24

[PATCH 1/2] drm/msm/mdp4: Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Signed-off-by: Sai Prakash Ranjan --- .../gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 51

[PATCH 0/2] Remove unused downstream bus scaling apis

2020-08-04 Thread Sai Prakash Ranjan
MSM bus scaling has moved on to use interconnect framework and downstream bus scaling apis are not present anymore. Remove them as they are nop anyways in the current code, no functional change. Sai Prakash Ranjan (2): drm/msm/mdp4: Remove unused downstream bus scaling apis drm/msm/mdp5

Re: [PATCH] coresight: etm4x: Add Support for HiSilicon ETM device

2020-08-03 Thread Sai Prakash Ranjan
Hi Qi Liu, On 2020-08-03 19:05, Qi Liu wrote: Add ETMv4 periperhal ID for HiSilicon Hip08 and Hip09 platform. Hip08 contains ETMv4.2 device and Hip09 contains ETMv4.5 device. Signed-off-by: Qi Liu --- drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCHv3] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Sai Prakash Ranjan
tate machine") Suggested-by: Suzuki K Poulose Signed-off-by: Sai Prakash Ranjan --- Changes in v3: * Minor cleanups from v2 and change to device_initcall (Stephen Boyd) * Move to non cpuslocked cpuhp callbacks and rename to etm_pm_setup() (Mike Leach) Changes in v2: * Rearrange cpuhp callback

Re: [PATCHv2] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Sai Prakash Ranjan
Hi Mike, On 2020-07-29 01:46, Mike Leach wrote: Hi Sai, On Tue, 28 Jul 2020 at 08:51, Sai Prakash Ranjan wrote: etm4_count keeps track of number of ETMv4 registered and on some systems, a race is observed on etm4_count variable which can lead to multiple calls

Re: [PATCHv2] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Sai Prakash Ranjan
On 2020-07-28 13:59, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2020-07-28 00:51:02) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index 6d7d2169bfb2..adb71987a1e3 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b

[PATCHv2] coresight: etm4x: Fix etm4_count race by moving cpuhp callbacks to init

2020-07-28 Thread Sai Prakash Ranjan
ely remove etm4_count usage. Fixes: 9b6a3f3633a5 ("coresight: etmv4: Fix CPU power management setup in probe() function") Fixes: 58eb457be028 ("hwtracing/coresight-etm4x: Convert to hotplug state machine") Suggested-by: Suzuki K Poulose Signed-off-by: Sai Prakash Ranjan --

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-28 Thread Sai Prakash Ranjan
On 2020-07-28 11:58, Bjorn Andersson wrote: On Mon 27 Jul 21:40 PDT 2020, Sai Prakash Ranjan wrote: On 2020-07-28 02:28, Bjorn Andersson wrote: > On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Bjorn, > > > > On 2020-06-21 13:39, Sai Prakash Ranj

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-07-27 Thread Sai Prakash Ranjan
On 2020-07-28 02:28, Bjorn Andersson wrote: On Tue 23 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: Hi Bjorn, On 2020-06-21 13:39, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-06-21 12:52, Bjorn Andersson wrote: > > On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: &

Re: [PATCH] coresight: etm4x: Fix etm4_count race using atomic variable

2020-07-27 Thread Sai Prakash Ranjan
On 2020-07-27 15:09, Suzuki K Poulose wrote: On 07/27/2020 07:07 AM, Sai Prakash Ranjan wrote: etm4_count keeps track of number of ETMv4 registered and on some systems, a race is observed on etm4_count variable which can lead to multiple calls to cpuhp_setup_state_nocalls_cpuslocked

Re: [PATCH] coresight: etm4x: Fix etm4_count race using atomic variable

2020-07-27 Thread Sai Prakash Ranjan
On 2020-07-27 11:37, Sai Prakash Ranjan wrote: etm4_count keeps track of number of ETMv4 registered and on some systems, a race is observed on etm4_count variable which can lead to multiple calls to cpuhp_setup_state_nocalls_cpuslocked(). This function internally calls cpuhp_store_callbacks

[PATCH] coresight: etm4x: Fix etm4_count race using atomic variable

2020-07-27 Thread Sai Prakash Ranjan
tate machine") Suggested-by: Mike Leach (Mike: Rootcause and context for commit message) Signed-off-by: Sai Prakash Ranjan --- drivers/hwtracing/coresight/coresight-etm4x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresigh

[PATCH] arm64: dts: qcom: sdm845: Support ETMv4 power management

2020-07-21 Thread Sai Prakash Ranjan
Add "arm,coresight-loses-context-with-cpu" property to coresight ETM nodes to avoid failure of trace session because of losing context on entering deep idle states. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 1 file changed, 8 insertion

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Sai Prakash Ranjan
_abort_xfer(gi2c); Tested-by: Sai Prakash Ranjan -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] drm/msm: dsi: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-20 Thread Sai Prakash Ranjan
that dev_pm_opp_put_clkname() is called only when an opp_table exists. Fixes: f99131fa7a23 ("drm/msm: dsi: Use OPP API to set clk/perf state") Reported-by: Sai Prakash Ranjan Signed-off-by: Rajendra Nayak --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] drm/msm/dpu: dev_pm_opp_put_clkname() only when an opp_table exists

2020-07-20 Thread Sai Prakash Ranjan
has_opp_table) dev_pm_opp_of_remove_table(dev); - dev_pm_opp_put_clkname(dpu_kms->opp_table); + if (dpu_kms->opp_table) + dev_pm_opp_put_clkname(dpu_kms->opp_table); } static const struct component_ops dpu_ops = { Tested-by: Sai Prakash Ranj

Re: [PATCH V2] soc: qcom: geni: Fix NULL pointer dereference

2020-07-20 Thread Sai Prakash Ranjan
for return values to fix the issue. We were hitting this issue when one of QUP is disabled. Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash") Reported-by: Sai Prakash Ranjan Reviewed-by: Matthias Kaehlcke Signed-off-by: Akash Asthana Nit: my

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Sai Prakash Ranjan
On 2020-07-14 00:43, Jordan Crouse wrote: On Mon, Jul 13, 2020 at 08:03:32PM +0100, Will Deacon wrote: On Mon, Jul 13, 2020 at 11:00:32AM -0600, Jordan Crouse wrote: > On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote:

Re: [PATCH] arm64: Add missing sentinel to erratum_1463225

2020-07-08 Thread Sai Prakash Ranjan
Gold (rcpe to rfpf) => (r0p0 to r3p1) */ MIDR_RANGE(MIDR_QCOM_KRYO_4XX_GOLD, 0xc, 0xe, 0xf, 0xf), + {}, }; #endif My bad missing this, thanks for the fix. Reviewed-by: Sai Prakash Ranjan -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code

Re: [PATCHv3 7/7] drm/msm/a6xx: Add support for using system cache(LLC)

2020-07-03 Thread Sai Prakash Ranjan
On 2020-07-03 21:34, Rob Clark wrote: On Fri, Jul 3, 2020 at 7:53 AM Sai Prakash Ranjan wrote: Hi Will, On 2020-07-03 19:07, Will Deacon wrote: > On Mon, Jun 29, 2020 at 09:22:50PM +0530, Sai Prakash Ranjan wrote: >> diff --git a/drivers/gpu/drm/msm/msm_iommu.c >> b/driv

Re: [PATCH] iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag

2020-07-03 Thread Sai Prakash Ranjan
On 2020-07-03 21:55, Will Deacon wrote: The IOMMU_SYS_CACHE_ONLY flag was never exposed via the DMA API and has no in-tree users. Remove it. Cc: Robin Murphy Cc: "Isaac J. Manjarres" Cc: Joerg Roedel Cc: Christoph Hellwig Cc: Sai Prakash Ranjan Cc: Rob Clark Signed-off-by: W

Re: [PATCHv3 7/7] drm/msm/a6xx: Add support for using system cache(LLC)

2020-07-03 Thread Sai Prakash Ranjan
Hi Will, On 2020-07-03 19:07, Will Deacon wrote: On Mon, Jun 29, 2020 at 09:22:50PM +0530, Sai Prakash Ranjan wrote: diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index f455c597f76d..bd1d58229cc2 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu

Re: [PATCH 3/3] arm64: Add KRYO4XX silver CPU cores to erratum list 1530923 and 1024718

2020-07-03 Thread Sai Prakash Ranjan
Hi Will, On 2020-07-03 19:25, Will Deacon wrote: On Tue, Jun 30, 2020 at 11:30:55PM +0530, Sai Prakash Ranjan wrote: KRYO4XX silver/LITTLE CPU cores with revision r1p0 are affected by erratum 1530923 and 1024718, so add them to the respective list. The variant and revision bits

Re: [PATCH v9 0/7] iommu/arm-smmu: Enable split pagetable support

2020-07-01 Thread Sai Prakash Ranjan
Hi Will, Robin, On 2020-06-27 01:30, Jordan Crouse wrote: Another iteration of the split-pagetable support for arm-smmu and the Adreno GPU SMMU. After email discussions [1] we opted to make a arm-smmu implementation for specifically for the Adreno GPU and use that to enable split pagetable

[PATCH 0/3] Add Kryo4xx gold and silver cores to applicable errata list

2020-06-30 Thread Sai Prakash Ranjan
1463225 and 1418040. Patch 3 adds Kryo4xx silver CPU cores to erratum list 1530923 and 1024718. Sai Prakash Ranjan (3): arm64: Add MIDR value for KRYO4XX gold CPU cores arm64: Add KRYO4XX gold CPU cores to erratum list 1463225 and 1418040 arm64: Add KRYO4XX silver CPU cores to erratum list

[PATCH 2/3] arm64: Add KRYO4XX gold CPU cores to erratum list 1463225 and 1418040

2020-06-30 Thread Sai Prakash Ranjan
) is equivalent to (rcpe to rfpf). Signed-off-by: Sai Prakash Ranjan --- Documentation/arm64/silicon-errata.rst | 4 arch/arm64/kernel/cpu_errata.c | 19 +-- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/Documentation/arm64/silicon-errata.rst b

[PATCH 3/3] arm64: Add KRYO4XX silver CPU cores to erratum list 1530923 and 1024718

2020-06-30 Thread Sai Prakash Ranjan
to rdpe. Signed-off-by: Sai Prakash Ranjan --- Documentation/arm64/silicon-errata.rst | 4 arch/arm64/kernel/cpu_errata.c | 2 ++ arch/arm64/kernel/cpufeature.c | 2 ++ 3 files changed, 8 insertions(+) diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation

[PATCH 1/3] arm64: Add MIDR value for KRYO4XX gold CPU cores

2020-06-30 Thread Sai Prakash Ranjan
Add MIDR value for KRYO4XX gold/big CPU cores which are used in Qualcomm Technologies, Inc. SoCs. This will be used to identify and apply erratum which are applicable for these CPU cores. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/include/asm/cputype.h | 2 ++ 1 file changed, 2 insertions

Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID

2020-06-30 Thread Sai Prakash Ranjan
erty") Cc: sta...@vger.kernel.org Reported-by: Sai Prakash Ranjan Signed-off-by: Sibi Sankar --- arch/arm64/boot/dts/qcom/sc7180-idp.dts| 2 +- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.d

[PATCHv3 4/7] iommu: arm-smmu-impl: Remove unwanted extra blank lines

2020-06-29 Thread Sai Prakash Ranjan
There are few places in arm-smmu-impl where there are extra blank lines, remove them and while at it fix the checkpatch warning for space required before the open parenthesis. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu-impl.c | 6 +- 1 file changed, 1 insertion(+), 5

[PATCHv3 0/7] System Cache support for GPU and required SMMU support

2020-06-29 Thread Sai Prakash Ranjan
series [1] https://lore.kernel.org/patchwork/cover/1264446/ [2] https://lore.kernel.org/patchwork/cover/1264460/ Jordan Crouse (1): iommu/arm-smmu: Add a init_context_bank implementation hook Sai Prakash Ranjan (4): iommu/io-pgtable-arm: Add support to use system cache iommu/arm-smmu: Add

[PATCHv3 5/7] iommu: arm-smmu-impl: Convert to use of_match_node() for qcom impl

2020-06-29 Thread Sai Prakash Ranjan
Use of_match_node() to match qcom implementation instead of multiple of_device_compatible() calls for each qcom implementation. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu-impl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu

[PATCHv3 7/7] drm/msm/a6xx: Add support for using system cache(LLC)

2020-06-29 Thread Sai Prakash Ranjan
it. Similarly DOMAIN_ATTR_SYS_CACHE is another domain level attribute used by the IOMMU driver to set the right attributes to cache the hardware pagetables into the system cache. Signed-off-by: Sharat Masetty (sai: fix to set attr before device attach to IOMMU and rebase) Signed-off-by: Sai Prakash

[PATCHv3 1/7] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-06-29 Thread Sai Prakash Ranjan
transactions. Doing so could hang the GPU if one of the terminated transactions is a CP read. This depends on the arm-smmu adreno SMMU implementation [1]. [1] https://lore.kernel.org/patchwork/patch/1264452/ Signed-off-by: Jordan Crouse Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu

[PATCHv3 3/7] iommu/arm-smmu: Add domain attribute for system cache

2020-06-29 Thread Sai Prakash Ranjan
Add iommu domain attribute for using system cache aka last level cache by client drivers like GPU to set right attributes for caching the hardware pagetables into the system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu.c | 17 + drivers/iommu/arm-smmu.h

[PATCHv3 6/7] drm/msm: rearrange the gpu_rmw() function

2020-06-29 Thread Sai Prakash Ranjan
Prakash Ranjan --- drivers/gpu/drm/msm/msm_drv.c | 8 drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/msm_gpu.h | 5 + 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 0c219b954943..5aa070929220

[PATCHv3 2/7] iommu/io-pgtable-arm: Add support to use system cache

2020-06-29 Thread Sai Prakash Ranjan
Add a quirk IO_PGTABLE_QUIRK_SYS_CACHE to override the attributes set in TCR for the page table walker when using system cache. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/io-pgtable-arm.c | 7 ++- include/linux/io-pgtable.h | 4 2 files changed, 10 insertions(+), 1

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-26 Thread Sai Prakash Ranjan
On 2020-06-26 02:48, Guenter Roeck wrote: On Fri, Jun 26, 2020 at 12:52:31AM +0530, Sai Prakash Ranjan wrote: > > > I don't think the watchdog mailing list has been copied on this series, > meaning I don't have a copy that I could apply if I wanted to. I kept you in CC for all t

[RESEND PATCHv3 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML

2020-06-25 Thread Sai Prakash Ranjan
Convert QCOM watchdog timer bindings to DT schema format using json-schema. Signed-off-by: Sai Prakash Ranjan Reviewed-by: Stephen Boyd Reviewed-by: Rob Herring --- .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 .../bindings/watchdog/qcom-wdt.yaml | 44

[RESEND PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

2020-06-25 Thread Sai Prakash Ranjan
Add missing compatible for watchdog timer on QCS404, SC7180, SDM845 and SM8150 SoCs. Signed-off-by: Sai Prakash Ranjan Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 1 file changed, 4 insertions(+) diff --git

[RESEND PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-25 Thread Sai Prakash Ranjan
use of const:qcom,kpss-wdt and made use of enum. Sai Prakash Ranjan (2): dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 --- .../bindings

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-25 Thread Sai Prakash Ranjan
On 2020-06-25 21:30, Guenter Roeck wrote: On Mon, Jun 22, 2020 at 11:50:52AM +0530, Sai Prakash Ranjan wrote: On 2020-06-21 13:03, Bjorn Andersson wrote: > On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Bjorn, > > > > Hi Sai, > > > On 2020-02-1

[PATCH] arm64: Add KRYO{3,4}XX silver CPU cores to SSB safelist

2020-06-25 Thread Sai Prakash Ranjan
QCOM KRYO{3,4}XX silver/LITTLE CPU cores are based on Cortex-A55 and are SSB safe, hence add them to SSB safelist -> arm64_ssb_cpus[]. Reported-by: Stephen Boyd Signed-off-by: Sai Prakash Ranjan --- arch/arm64/kernel/cpu_errata.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/ar

[PATCH] arm64: kpti: Add KRYO{3,4}XX silver CPU cores to kpti safelist

2020-06-24 Thread Sai Prakash Ranjan
QCOM KRYO{3,4}XX silver/LITTLE CPU cores are based on Cortex-A55 and are meltdown safe, hence add them to kpti_safe_list[]. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/kernel/cpufeature.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-06-24 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-06-21 13:39, Sai Prakash Ranjan wrote: Hi Bjorn, On 2020-06-21 12:52, Bjorn Andersson wrote: On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: Define iommus property for Coresight ETR component in SC7180 SoC with the SID and mask to enable SMMU translation

Re: [PATCHv3] coresight: tmc: Add shutdown callback for TMC ETR

2020-06-24 Thread Sai Prakash Ranjan
On 2020-06-23 22:55, Mathieu Poirier wrote: On Tue, Jun 16, 2020 at 10:26:23AM +0530, Sai Prakash Ranjan wrote: Implement a shutdown callback to ensure ETR hardware is properly shutdown in reboot/shutdown path. This is required for ETR which has SMMU address translation enabled like on SC7180

Re: [PATCH] venus: core: add shutdown callback for venus

2020-06-24 Thread Sai Prakash Ranjan
Hi Mansur, On 2020-06-13 16:03, Mansur Alisha Shaik wrote: After the SMMU translation is disabled in the arm-smmu shutdown callback during reboot, if any subsystem are still alive then IOVAs they are using will become PAs on bus, which may lead to crash. Below are the consumers of smmu from

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-22 Thread Sai Prakash Ranjan
On 2020-06-21 13:03, Bjorn Andersson wrote: On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: Hi Bjorn, Hi Sai, On 2020-02-12 03:54, Sai Prakash Ranjan wrote: > This series converts QCOM watchdog timer bindings to YAML. Also > it adds the missing SoC-specific compatible for

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-06-21 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-06-21 12:52, Bjorn Andersson wrote: On Tue 09 Jun 06:30 PDT 2020, Sai Prakash Ranjan wrote: Define iommus property for Coresight ETR component in SC7180 SoC with the SID and mask to enable SMMU translation for this master. We don't have _smmu in linux-next, as we've yet

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-17 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-02-12 03:54, Sai Prakash Ranjan wrote: This series converts QCOM watchdog timer bindings to YAML. Also it adds the missing SoC-specific compatible for QCS404, SC7180, SDM845 and SM8150 SoCs. v1: https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ran

[PATCHv3] coresight: tmc: Add shutdown callback for TMC ETR

2020-06-15 Thread Sai Prakash Ranjan
translation is disabled and device_link in SMMU driver will take care of ordering of shutdown callbacks such that SMMU shutdown callback is not called before any of its consumer shutdown callbacks. Signed-off-by: Sai Prakash Ranjan --- Changes since v2: * Remove ETF/ETB disable as suggested by Mathieu

[PATCH] coresight: tmc: Fix TMC mode read in tmc_read_unprepare_etb()

2020-06-15 Thread Sai Prakash Ranjan
x2 : x1 : 0004 x0 : 0001 Kernel panic - not syncing: Asynchronous SError Interrupt Fixes: 4525412a5046 ("coresight: tmc: making prepare/unprepare functions generic") Reported-by: Mike Leach Signed-off-by: Sai Prakash Ranjan --- drivers

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-09 Thread Sai Prakash Ranjan
Hi Mathieu, On 2020-06-09 20:57, Mathieu Poirier wrote: On Mon, 8 Jun 2020 at 08:07, Sai Prakash Ranjan wrote: Hi Mathieu, Mike On 2020-06-04 12:57, Sai Prakash Ranjan wrote: > [...] >> >> Robin has a point - user space is long gone at this time. As such the >> fir

Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Add support to skip powering up of ETM

2020-06-09 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-05-15 16:21, Sai Prakash Ranjan wrote: Add "qcom,skip-power-up" property to skip powering up ETM on SC7180 SoC to workaround a hardware errata where CPU watchdog counter is stopped when ETM power up bit is set (i.e., when TRCPDCR.PU = 1). Signed-off-by: Sai Prak

[PATCH 1/4] arm64: dts: qcom: sc7180: Add support to skip powering up of ETM

2020-06-09 Thread Sai Prakash Ranjan
Add "qcom,skip-power-up" property to skip powering up ETM on SC7180 SoC to workaround a hardware errata where CPU watchdog counter is stopped when ETM power up bit is set (i.e., when TRCPDCR.PU = 1). Signed-off-by: Sai Prakash Ranjan --- Depends on ETM driver change here:

[PATCH 3/4] arm64: dts: qcom: sc7180: Add support for context losing replicator

2020-06-09 Thread Sai Prakash Ranjan
Add "qcom,replicator-loses-context" property to the replicator in Always-on domain in SC7180 SoC to enable coresight replicator driver to handle this variation of replicator designs. Signed-off-by: Sai Prakash Ranjan --- Depends on coresight replicator change here: - https://git.

[PATCH 4/4] arm64: dts: qcom: sm8150: Add Coresight support

2020-06-09 Thread Sai Prakash Ranjan
Add coresight components found on Qualcomm SM8150 SoC. Signed-off-by: Sai Prakash Ranjan --- Depends on following coresight driver and SM8150 SMMU support: - https://git.linaro.org/kernel/coresight.git/commit/?h=next-v5.8-rc1=159e248e75b1b548276b6571d7740a35cab1f5be - https://git.linaro.org

[PATCH 2/4] arm64: dts: qcom: sc7180: Add iommus property to ETR

2020-06-09 Thread Sai Prakash Ranjan
Define iommus property for Coresight ETR component in SC7180 SoC with the SID and mask to enable SMMU translation for this master. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH 0/4] Add coresight support for SM8150 and few changes to SC7180

2020-06-09 Thread Sai Prakash Ranjan
=159e248e75b1b548276b6571d7740a35cab1f5be - https://git.linaro.org/kernel/coresight.git/commit/?h=next-v5.8-rc1=1b6cddfb7ebb5ed293124698f147e914b15315a1 - https://lore.kernel.org/lkml/20200524023815.21789-2-jonat...@marek.ca/ Tested this series on SM8150 and SC7180. Sai Prakash Ranjan (4): arm64: dts: qcom

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-08 Thread Sai Prakash Ranjan
Hi Mathieu, Mike On 2020-06-04 12:57, Sai Prakash Ranjan wrote: [...] Robin has a point - user space is long gone at this time. As such the first question to ask is what kind of CS session was running at the time the system was shutting down. Was it a perf session of a sysfs session

Re: [RFC PATCH] iommu/arm-smmu: Remove shutdown callback

2020-06-08 Thread Sai Prakash Ranjan
Hi Will, On 2020-06-08 17:08, Will Deacon wrote: On Mon, Jun 08, 2020 at 02:43:03PM +0530, Sai Prakash Ranjan wrote: On 2020-06-08 13:48, Will Deacon wrote: > On Sun, Jun 07, 2020 at 04:39:18PM +0530, Sai Prakash Ranjan wrote: > > Remove SMMU shutdown callback since it seems to c

Re: [RFC PATCH] iommu/arm-smmu: Remove shutdown callback

2020-06-08 Thread Sai Prakash Ranjan
Hi Robin, On 2020-06-08 16:56, Robin Murphy wrote: On 2020-06-08 10:13, Sai Prakash Ranjan wrote: Hi Will, On 2020-06-08 13:48, Will Deacon wrote: On Sun, Jun 07, 2020 at 04:39:18PM +0530, Sai Prakash Ranjan wrote: Remove SMMU shutdown callback since it seems to cause more problems than

Re: [RFC PATCH] iommu/arm-smmu: Remove shutdown callback

2020-06-08 Thread Sai Prakash Ranjan
Hi Will, On 2020-06-08 13:48, Will Deacon wrote: On Sun, Jun 07, 2020 at 04:39:18PM +0530, Sai Prakash Ranjan wrote: Remove SMMU shutdown callback since it seems to cause more problems than benefits. With this callback, we need to make sure that all clients/consumers of SMMU do not perform any

[RFC PATCH] iommu/arm-smmu: Remove shutdown callback

2020-06-07 Thread Sai Prakash Ranjan
, we need to identify the client of SMMU causing the memory corruption and add appropriate shutdown callback to the client rather than to the SMMU. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu-v3.c | 6 -- drivers/iommu/arm-smmu.c| 6 -- 2 files changed, 12 deletions

Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-06-05 Thread Sai Prakash Ranjan
On 2020-06-05 20:21, Nicolas Dechesne wrote: On Fri, Jun 5, 2020 at 4:39 PM Sai Prakash Ranjan wrote: Hi Nico, On 2020-06-05 20:01, Nicolas Dechesne wrote: > On Fri, Jun 5, 2020 at 4:14 PM Sai Prakash Ranjan > wrote: >> >> On 2020-06-05 19:40, Jonathan Marek wrote: >&

Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-06-05 Thread Sai Prakash Ranjan
Hi Nico, On 2020-06-05 20:01, Nicolas Dechesne wrote: On Fri, Jun 5, 2020 at 4:14 PM Sai Prakash Ranjan wrote: On 2020-06-05 19:40, Jonathan Marek wrote: > On 6/5/20 10:03 AM, Sai Prakash Ranjan wrote: >> On 2020-05-29 08:45, Bjorn Andersson wrote: >>> On Thu 28 May 20:02

Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-06-05 Thread Sai Prakash Ranjan
On 2020-05-25 15:07, Sai Prakash Ranjan wrote: Hi Jonathan, On 2020-05-24 08:08, Jonathan Marek wrote: Add the apps_smmu node for sm8150. Note that adding the iommus field for UFS is required because initializing the iommu removes the bypass mapping that created by the bootloader. Signed

Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-06-05 Thread Sai Prakash Ranjan
On 2020-06-05 19:40, Jonathan Marek wrote: On 6/5/20 10:03 AM, Sai Prakash Ranjan wrote: On 2020-05-29 08:45, Bjorn Andersson wrote: On Thu 28 May 20:02 PDT 2020, Jonathan Marek wrote: On 5/28/20 10:52 PM, Bjorn Andersson wrote: > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wr

Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-06-05 Thread Sai Prakash Ranjan
On 2020-05-29 08:45, Bjorn Andersson wrote: On Thu 28 May 20:02 PDT 2020, Jonathan Marek wrote: On 5/28/20 10:52 PM, Bjorn Andersson wrote: > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > > > Add the apps_smmu node for sm8150. Note that adding the iommus field for > > UFS is required

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-04 Thread Sai Prakash Ranjan
Hi Mathieu, +Will On 2020-06-03 23:14, Mathieu Poirier wrote: On Wed, Jun 03, 2020 at 02:34:10PM +0100, Robin Murphy wrote: On 2020-06-03 14:22, Mike Leach wrote: > Hi Sai, > > On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan > wrote: > > > > Hi Mike, > > >

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-06-03 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-06-03 23:39, Bjorn Andersson wrote: On Thu 28 May 23:56 PDT 2020, Sai Prakash Ranjan wrote: Hi Bjorn, On 2020-05-29 06:41, Bjorn Andersson wrote: > On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Jonathan, > > > > On 2020-05-25 02:

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Mike, On 2020-06-03 19:21, Mike Leach wrote: Hi, On Wed, 3 Jun 2020 at 14:34, Robin Murphy wrote: On 2020-06-03 14:22, Mike Leach wrote: > Hi Sai, > > On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan > wrote: >> >> Hi Mike, >> >> On 2020-0

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Robin, On 2020-06-03 19:10, Robin Murphy wrote: On 2020-06-03 13:26, Sai Prakash Ranjan wrote: Hi Robin, On 2020-06-03 17:51, Robin Murphy wrote: On 2020-06-03 13:00, Sai Prakash Ranjan wrote: Hi Robin, Mathieu On 2020-06-03 17:07, Robin Murphy wrote: On 2020-06-01 22:28, Mathieu

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Mike, On 2020-06-03 19:04, Robin Murphy wrote: On 2020-06-03 14:22, Mike Leach wrote: Hi Sai, On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan wrote: Hi Mike, On 2020-06-03 16:57, Mike Leach wrote: Hi, On Wed, 3 Jun 2020 at 11:24, Sai Prakash Ranjan wrote: Hi Mike, Thanks again

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Robin, On 2020-06-03 17:51, Robin Murphy wrote: On 2020-06-03 13:00, Sai Prakash Ranjan wrote: Hi Robin, Mathieu On 2020-06-03 17:07, Robin Murphy wrote: On 2020-06-01 22:28, Mathieu Poirier wrote: That being said I'm sure that dependencies on an IOMMU isn't a problem confined

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Mike, On 2020-06-03 16:57, Mike Leach wrote: Hi, On Wed, 3 Jun 2020 at 11:24, Sai Prakash Ranjan wrote: Hi Mike, Thanks again for looking at this. On 2020-06-03 03:42, Mike Leach wrote: [...] >> >> SMMU/IOMMU won't be able to do much here as it is the client's >

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Robin, Mathieu On 2020-06-03 17:07, Robin Murphy wrote: On 2020-06-01 22:28, Mathieu Poirier wrote: That being said I'm sure that dependencies on an IOMMU isn't a problem confined to coresight. I am adding Robin Murphy, who added this commit [1], to the thread in the hope that he can

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Sai Prakash Ranjan
Hi Mike, Thanks again for looking at this. On 2020-06-03 03:42, Mike Leach wrote: [...] SMMU/IOMMU won't be able to do much here as it is the client's responsiblity to properly shutdown and SMMU device link just makes sure that SMMU(supplier) shutdown is called only after its consumers

Re: [v2] drm/msm: add shutdown support for display platform_driver

2020-06-02 Thread Sai Prakash Ranjan
Hi Emil, On 2020-06-02 21:09, Emil Velikov wrote: On Tue, 2 Jun 2020 at 15:49, Sai Prakash Ranjan wrote: Hi Emil, On 2020-06-02 19:43, Emil Velikov wrote: > Hi Krishna, > > On Tue, 2 Jun 2020 at 08:17, Krishna Manikandan > wrote: >> >> Define shutdown callback for d

Re: [v2] drm/msm: add shutdown support for display platform_driver

2020-06-02 Thread Sai Prakash Ranjan
Hi Emil, On 2020-06-02 19:43, Emil Velikov wrote: Hi Krishna, On Tue, 2 Jun 2020 at 08:17, Krishna Manikandan wrote: Define shutdown callback for display drm driver, so as to disable all the CRTCS when shutdown notification is received by the driver. This change will turn off the timing

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-02 Thread Sai Prakash Ranjan
Hi Mathieu, Thanks for taking your time for review. On 2020-06-02 02:58, Mathieu Poirier wrote: Hi Sai, On top of the comments already privided by Mike, I have the following: On Mon, Jun 01, 2020 at 01:32:26PM +0530, Sai Prakash Ranjan wrote: Implement a shutdown callback to ensure ETR/ETF

[PATCHv2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
SMMU translation is disabled and device_link in SMMU driver will take care of ordering of shutdown callbacks such that SMMU shutdown callback is not called before any of its consumer shutdown callbacks. Signed-off-by: Sai Prakash Ranjan --- Changes since v1: * Use mode flag and drop enable flag

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
Hi Mike, Thanks for the review. On 2020-06-01 19:05, Mike Leach wrote: Hi, On Mon, 1 Jun 2020 at 09:02, Sai Prakash Ranjan wrote: Implement a shutdown callback to ensure ETR/ETF hardware is properly shutdown in reboot/shutdown path. This is required for ETR/ETF which has SMMU address

Re: [PATCH 1/2] coresight: tmc: Add enable flag to indicate the status of ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
Hi Mike, Thanks for the review. On 2020-06-01 18:57, Mike Leach wrote: Hi, On Mon, 1 Jun 2020 at 09:02, Sai Prakash Ranjan wrote: Add a flag to check whether TMC ETR/ETF is enabled or not. This is later used in shutdown callback to determine if we require to disable ETR/ETF. Signed-off

[PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
SMMU translation is disabled and device_link in SMMU driver will take care of ordering of shutdown callbacks such that SMMU shutdown callback is not called before any of its consumer shutdown callbacks. Signed-off-by: Sai Prakash Ranjan --- .../hwtracing/coresight/coresight-tmc-etf.c | 4

[PATCH 0/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
is shutdown before SMMU translation is disabled and device_link in SMMU driver will take care of ordering of shutdown callbacks such that SMMU shutdown callback is not called before any of its consumer shutdown callbacks. Sai Prakash Ranjan (2): coresight: tmc: Add enable flag to indicate the status

[PATCH 1/2] coresight: tmc: Add enable flag to indicate the status of ETR/ETF

2020-06-01 Thread Sai Prakash Ranjan
Add a flag to check whether TMC ETR/ETF is enabled or not. This is later used in shutdown callback to determine if we require to disable ETR/ETF. Signed-off-by: Sai Prakash Ranjan --- drivers/hwtracing/coresight/coresight-tmc.c | 2 ++ drivers/hwtracing/coresight/coresight-tmc.h | 2 ++ 2 files

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-05-29 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-05-29 06:41, Bjorn Andersson wrote: On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: Hi Jonathan, On 2020-05-25 02:36, Jonathan Marek wrote: > Add support for the graphics clock controller found on SM8250 > based devices. This would allow graphics drivers to

<    1   2   3   4   5   6   7   8   >