[PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr

Since goto statement merely returns NULL, replace it with return statement. Signed-off-by: Salah Triki <salah.tr...@gmail.com> --- fs/befs/io.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 4223b77..af631a6 100644 --- a/fs/bef

[PATCH 2/4] fs: befs: Coding style fix

Constant has to be capitalized. Signed-off-by: Salah Triki <salah.tr...@gmail.com> --- fs/befs/btree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 307645f9..e59ad20 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@

[PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr

Since goto statement merely returns NULL, replace it with return statement. Signed-off-by: Salah Triki --- fs/befs/io.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 4223b77..af631a6 100644 --- a/fs/befs/io.c +++ b/fs/befs/io.c

[PATCH 2/4] fs: befs: Coding style fix

Constant has to be capitalized. Signed-off-by: Salah Triki --- fs/befs/btree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 307645f9..e59ad20 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -85,7 +85,7 @@ struct

[PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect

The calls to brelse are useless since dbl_indir_block and indir_block are NULL. Signed-off-by: Salah Triki <salah.tr...@gmail.com> --- fs/befs/datastream.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index e224b9a..b68b6f9 100644 --- a/f

[PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect

The calls to brelse are useless since dbl_indir_block and indir_block are NULL. Signed-off-by: Salah Triki --- fs/befs/datastream.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index e224b9a..b68b6f9 100644 --- a/fs/befs/datastream.c +++ b/fs

[PATCH] fs: befs: Replace befs_bread by sb_bread

Since befs_bread merely calls sb_bread, replace it by sb_bread. Signed-off-by: Salah Triki <salah.tr...@gmail.com> --- fs/befs/datastream.c | 6 +++--- fs/befs/io.c | 24 fs/befs/io.h | 2 -- fs/befs/linuxvfs.c | 2 +- 4 files changed, 4 inse

[PATCH] fs: befs: Replace befs_bread by sb_bread

Since befs_bread merely calls sb_bread, replace it by sb_bread. Signed-off-by: Salah Triki --- fs/befs/datastream.c | 6 +++--- fs/befs/io.c | 24 fs/befs/io.h | 2 -- fs/befs/linuxvfs.c | 2 +- 4 files changed, 4 insertions(+), 30 deletions

[PATCH V3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup inserts NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index c734f21..2fea87b 100644 --- a/f

[PATCH V3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup inserts NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index c734f21..2fea87b 100644 --- a/fs/befs/linuxvfs.c +++ b/fs

Re: [PATCH 3/3] fs: befs: Increment i_count when inode is found

On Sat, Jun 04, 2016 at 08:32:42PM +0100, Al Viro wrote: > On Sat, Jun 04, 2016 at 07:53:21PM +0100, Salah Triki wrote: > > As VFS expects, i_count field is incremented when the named inode is found. > > VFS expects no such thing. Incidentally, you have neither bothered t

Re: [PATCH 3/3] fs: befs: Increment i_count when inode is found

On Sat, Jun 04, 2016 at 08:32:42PM +0100, Al Viro wrote: > On Sat, Jun 04, 2016 at 07:53:21PM +0100, Salah Triki wrote: > > As VFS expects, i_count field is incremented when the named inode is found. > > VFS expects no such thing. Incidentally, you have neither bothered t

[PATCH V2 3/3] fs: befs: Increment i_count when inode is found

As VFS expects, i_count.counter field should be incremented when the named inode is found. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 91740dd..1a67990 100644 --

[PATCH V2 3/3] fs: befs: Increment i_count when inode is found

As VFS expects, i_count.counter field should be incremented when the named inode is found. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 91740dd..1a67990 100644 --- a/fs/befs/linuxvfs.c +++ b

[PATCH V2 1/3] fs: befs: Lookup must return error code only on real error

File not found is not an error and lookup must return error code only on real error, otherwise creating inodes with functions like create, mkdir and so on will fail. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH V2 1/3] fs: befs: Lookup must return error code only on real error

File not found is not an error and lookup must return error code only on real error, otherwise creating inodes with functions like create, mkdir and so on will fail. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs

[PATCH V2 2/3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup should insert NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e0bd6c7..91740dd

[PATCH V2 2/3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup should insert NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e0bd6c7..91740dd 100644 --- a/fs/befs/linuxvfs.c

[PATCH 3/3] fs: befs: Increment i_count when inode is found

As VFS expects, i_count field is incremented when the named inode is found. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 91740dd..05153b3 100644 --- a/fs/befs/linu

[PATCH 3/3] fs: befs: Increment i_count when inode is found

As VFS expects, i_count field is incremented when the named inode is found. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 91740dd..05153b3 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs

[PATCH 2/3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup inserts NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e0bd6c7..91740dd 100644 --- a/f

[PATCH 2/3] fs: befs: Insert NULL inode to dentry

As VFS expects, lookup inserts NULL inode to dentry when the named inode does not exist. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index e0bd6c7..91740dd 100644 --- a/fs/befs/linuxvfs.c +++ b/fs

[PATCH 1/3] fs: befs: Lookup must return error code only on real error

File not found is not an error and lookup must return error code only on real error, otherwise creating inodes with functions like create, mkdir and so on will fail. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 1/3] fs: befs: Lookup must return error code only on real error

File not found is not an error and lookup must return error code only on real error, otherwise creating inodes with functions like create, mkdir and so on will fail. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs

[PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200

[PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200 100644 --- a/fs/ubifs/super.c

[PATCH V4 4/6] fs: befs: Remove useless befs_error

Remove befs_error since when kmalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 5b47b0f..04541f3 100644 --

[PATCH V4 3/6] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5

[PATCH V4 4/6] fs: befs: Remove useless befs_error

Remove befs_error since when kmalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 5b47b0f..04541f3 100644 --- a/fs/befs/linuxvfs.c +++ b

[PATCH V4 3/6] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5b47b0f 100644 --- a/fs/befs

[PATCH V4 1/6] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH V4 5/6] fs: befs: Remove useless pr_err

Remove pr_err since kmem_cache_create log error and dump stack. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 04541f3..c734f21 100644 --- a/f

[PATCH V4 1/6] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b

[PATCH V4 5/6] fs: befs: Remove useless pr_err

Remove pr_err since kmem_cache_create log error and dump stack. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 04541f3..c734f21 100644 --- a/fs/befs/linuxvfs.c +++ b/fs

[PATCH V4 6/6] fs: befs: Coalesce format in log messages

Coalese format is more readable, even if it goes over 80 column width, so group format snippets together. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/fs/befs/linuxvfs.

[PATCH V4 2/6] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linu

[PATCH V4 6/6] fs: befs: Coalesce format in log messages

Coalese format is more readable, even if it goes over 80 column width, so group format snippets together. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index

[PATCH V4 2/6] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs

[PATCH V3 2/4] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linu

[PATCH V3 2/4] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs

[PATCH V2 2/3] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linu

[PATCH V2 2/3] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..edee857 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs

[PATCH V2 1/3] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH V2 1/3] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b

[PATCH V3 4/4] fs: befs: Remove useless befs_error

Remove befs_error since when kmalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 5b47b0f..04541f3 100644 --

[PATCH V3 4/4] fs: befs: Remove useless befs_error

Remove befs_error since when kmalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 5b47b0f..04541f3 100644 --- a/fs/befs/linuxvfs.c +++ b

[PATCH V3 1/4] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH V3 1/4] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b

[PATCH V3 3/4] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5

[PATCH V3 3/4] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5b47b0f 100644 --- a/fs/befs

[PATCH V2 3/3] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5

[PATCH V2 3/3] fs: befs: Remove useless pr_err

Remove pr_err since when kzalloc fails there is a generic out of memory and stack dump. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index edee857..5b47b0f 100644 --- a/fs/befs

[PATCH] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Use kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200 100644 --- a/fs/ubifs/super.c ++

[PATCH] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Use kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c

[PATCH 1/2] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 1/2] fs: befs: Move useless assignment

Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b

[PATCH 2/2] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..5b30d1f 100644 --- a/f

[PATCH 2/2] fs: befs: Check silent flag before logging errors

Log errors only when silent flag is not set. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 75ec9a7..5b30d1f 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs

[PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS

Since this is a filesystem driver, using the flag GFP_NOFS is more appropriate than the flag GFP_KERNEL. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c

[PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS

Since this is a filesystem driver, using the flag GFP_NOFS is more appropriate than the flag GFP_KERNEL. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index cc0e082..ef6f6b0 100644

[PATCH] bfs: rename should update ctime and mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/

[PATCH] bfs: rename should update ctime and mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -254,6 +254,8

bfs: rename should update ctime and mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/

bfs: rename should update ctime and mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -254,6 +254,8

[PATCH V3] bfs: rename should update mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/

[PATCH V3] bfs: rename should update mtime

bfs_rename should update ctime and mtime on target, and mark the target as dirty. Signed-off-by: Salah Triki --- fs/bfs/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..da30bb7 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -254,6 +254,8

[PATCH] fs: jffs2: initialize the field fs_flags

jffs2 requires device, so the field fs_flags of the structure file_system_type must be initialized to FS_REQUIRES_DEV. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/jffs2/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 0

[PATCH] fs: jffs2: initialize the field fs_flags

jffs2 requires device, so the field fs_flags of the structure file_system_type must be initialized to FS_REQUIRES_DEV. Signed-off-by: Salah Triki --- fs/jffs2/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 0a9a114..fd24af9 100644 --- a/fs

[PATCH] fs: befs: use flags field to validate fs state

flags field records the state of the superblock, so it is more appropriate to use this field for validating the fs state than using the fields log_start and log_end. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] fs: befs: use flags field to validate fs state

flags field records the state of the superblock, so it is more appropriate to use this field for validating the fs state than using the fields log_start and log_end. Signed-off-by: Salah Triki --- fs/befs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs

[PATCH 3/4] fs: befs: remove unneeded initialization to NULL

raw_inode is reinitialized to bh->b_data so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvf

[PATCH 2/4] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_bread() so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index d

[PATCH 3/4] fs: befs: remove unneeded initialization to NULL

raw_inode is reinitialized to bh->b_data so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 3610c61..85c77e1 100

[PATCH 2/4] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_bread() so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index dded1c7..3610c61 100644

[PATCH 4/4] fs: befs: remove unneeded initialization to NULL

befs_ino is reinitialized by BEFS_I() so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 8

[PATCH 1/4] fs: befs: remove unneeded initialization to NULL

inode is reinitialized by befs_iget() so no need to init it with NULL in the beginning of befs_lookup() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c

[PATCH 4/4] fs: befs: remove unneeded initialization to NULL

befs_ino is reinitialized by BEFS_I() so no need to init it with NULL in the beginning of befs_iget() Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 85c77e1..20b3f8d 100644

[PATCH 1/4] fs: befs: remove unneeded initialization to NULL

inode is reinitialized by befs_iget() so no need to init it with NULL in the beginning of befs_lookup() Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index cc0e082..dded1c7 100644

[PATCH 1/2] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by sb_bread() so no need to init it with NULL in the beginning of befs_bread_iaddr() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 7a5b4ec..1341fa3

[PATCH 2/2] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by sb_bread() so no need to init it with NULL in the beginning of befs_bread() Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 1341fa3..523c8af

[PATCH 1/2] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by sb_bread() so no need to init it with NULL in the beginning of befs_bread_iaddr() Signed-off-by: Salah Triki --- fs/befs/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 7a5b4ec..1341fa3 100644 --- a/fs/befs/io.c

[PATCH 2/2] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by sb_bread() so no need to init it with NULL in the beginning of befs_bread() Signed-off-by: Salah Triki --- fs/befs/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/io.c b/fs/befs/io.c index 1341fa3..523c8af 100644 --- a/fs/befs/io.c +++ b

[PATCH 1/3] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_bread_iaddr() so no need to init it with NULL in the beginning of befs_read_datastream(). Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/datastream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/datastream.c b/f

[PATCH 1/3] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_bread_iaddr() so no need to init it with NULL in the beginning of befs_read_datastream(). Signed-off-by: Salah Triki --- fs/befs/datastream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index ebd5071

[PATCH 2/3] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_read_datastream() so no need to init it with NULL in the beginning of befs_read_lsymlink(). Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/datastream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/datastream.c b/f

[PATCH 2/3] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_read_datastream() so no need to init it with NULL in the beginning of befs_read_lsymlink(). Signed-off-by: Salah Triki --- fs/befs/datastream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index

[PATCH 3/3] fs: befs: remove unneeded initializations to NULL

iaddr_array is unconditionally initialized to NULL in befs_find_brun_dblindirect(). Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/befs/datastream.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index 068f7be..4

[PATCH 3/3] fs: befs: remove unneeded initializations to NULL

iaddr_array is unconditionally initialized to NULL in befs_find_brun_dblindirect(). Signed-off-by: Salah Triki --- fs/befs/datastream.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index 068f7be..4cbd4c2 100644 --- a/fs/befs

[PATCH V2] bfs: rename should update mtime

bfs_rename should update ctime and mtime on target. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/bfs/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..c69f7dc 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -254,6 +254,7 @@ stat

[PATCH V2] bfs: rename should update mtime

bfs_rename should update ctime and mtime on target. Signed-off-by: Salah Triki --- fs/bfs/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..c69f7dc 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -254,6 +254,7 @@ static int bfs_rename(struct

[PATCH] bfs: rename should update mtime

bfs_rename should update mtime on target. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- fs/bfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..d5902d9 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -252,7

[PATCH] bfs: rename should update mtime

bfs_rename should update mtime on target. Signed-off-by: Salah Triki --- fs/bfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 3ec6113..d5902d9 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -252,7 +252,7 @@ static int bfs_rename

[PATCH V3 0/1] zram: Remove useless check

The previous versions of this patch contain spelling errors and cryptic messages, please ignore them. The patch removes the check of the return value of lzo1x_1_compress, since it returns always LZO_E_OK. Salah Triki (1): zram: Remove useless check drivers/block/zram/zcomp_lzo.c | 3 +-- 1

[PATCH V3 1/1] zram: Remove useless check

lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the check of the return value is useless. Signed-off-by: Salah Triki --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram

[PATCH] regmap: Remove useless check

lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the return value is useless. Signed-off-by: Salah Triki --- drivers/base/regmap/regcache-lzo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/regmap/regcache-lzo.c b/drivers/base/regmap

[PATCH V2] zram: Remove useless check

lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Signed-off-by: Salah Triki --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c index da1bc47..3cf30c9 100644

[PATCH] zram: Remove useless check

lzo1x_1_compress always LZO_E_OK that is equal to 0. Signed-off-by: Salah Triki --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c index da1bc47..3cf30c9 100644 --- a/drivers

[PATCH V2] zram: Remove useless check

lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c index da1bc47

[PATCH] regmap: Remove useless check

lzo1x_1_do_compress always returns LZO_E_OK. Thus, the check of the return value is useless. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/base/regmap/regcache-lzo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/regmap/regcache-lzo.c b

[PATCH V3 1/1] zram: Remove useless check

lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the check of the return value is useless. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/block/zram/zcomp_lzo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/zram/zcomp_lzo.c b

<    1   2   3   >