Re: [PATCH] ttyprintk: Add TTY hangup callback.

2021-04-18 Thread Samo Pogačnik
Dne 15.04.2021 (čet) ob 09:22 +0900 je Tetsuo Handa napisal(a): > syzbot is reporting hung task due to flood of > > tty_warn(tty, "%s: tty->count = 1 port count = %d\n", __func__, >port->count); > > message [1], for ioctl(TIOCVHANGUP) prevents tty_port_close() from > decrementing

Re: How to handle concurrent access to /dev/ttyprintk ?

2021-04-14 Thread Samo Pogačnik
Dne 14.04.2021 (sre) ob 20:11 +0900 je Tetsuo Handa napisal(a): > On 2021/04/14 9:45, Tetsuo Handa wrote: > > On 2021/04/12 21:04, Greg Kroah-Hartman wrote: > > > > Since syzkaller is a fuzzer, syzkaller happily opens /dev/ttyprintk from > > > > multiple threads. Should we update syzkaller to use

Re: How to handle concurrent access to /dev/ttyprintk ?

2021-04-13 Thread Samo Pogačnik
Dne 13.04.2021 (tor) ob 16:32 +0200 je Petr Mladek napisal(a): > On Tue 2021-04-13 13:10:50, Samo Pogačnik wrote: > > Dne 13.04.2021 (tor) ob 11:41 +0200 je Petr Mladek napisal(a): > > > On Mon 2021-04-12 14:41:27, Samo Pogačnik wrote: > > > > Dne 12.04.2021 (pon)

Re: How to handle concurrent access to /dev/ttyprintk ?

2021-04-13 Thread Samo Pogačnik
Dne 13.04.2021 (tor) ob 11:41 +0200 je Petr Mladek napisal(a): > On Mon 2021-04-12 14:41:27, Samo Pogačnik wrote: > > Dne 12.04.2021 (pon) ob 19:39 +0900 je Tetsuo Handa napisal(a): > > > What is the intended usage of /dev/ttyprintk ? > > > > > > > The int

Re: How to handle concurrent access to /dev/ttyprintk ?

2021-04-12 Thread Samo Pogačnik
Dne 12.04.2021 (pon) ob 19:39 +0900 je Tetsuo Handa napisal(a): > What is the intended usage of /dev/ttyprintk ? > The intended use of 'ttyprintk' is to redirect console to /dev/ttyprintk via the TIOCCONS ioctl. After successfull redirection, all console messages get "merged" with kernel

Re: [PATCH 2/2] ttyprintk: Allow built as a module

2014-04-05 Thread Samo Pogačnik
Dne 03.04.2014 (čet) ob 08:13 +0200 je Takashi Iwai napisal(a): > At Wed, 2 Apr 2014 12:32:22 -0700, > Greg Kroah-Hartman wrote: > > > > On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote: > > > The driver is well written to be used as a module, just the exit call > > > is missing. > >

Re: [PATCH 2/2] ttyprintk: Allow built as a module

2014-04-05 Thread Samo Pogačnik
Dne 03.04.2014 (čet) ob 08:13 +0200 je Takashi Iwai napisal(a): At Wed, 2 Apr 2014 12:32:22 -0700, Greg Kroah-Hartman wrote: On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote: The driver is well written to be used as a module, just the exit call is missing.