Re: [PATCH v3] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-28 Thread Samuel Čavoj
Hi, On 28.10.2020 12:50, Hans de Goede wrote: > Hi, > > On 10/21/20 12:09 AM, Samuel Čavoj wrote: > > The UX360CA has a WMI device id 0x00060062, which reports whether the > > lid is flipped in tablet mode (1) or in normal laptop mode (0). > > > > Add a qui

Re: [PATCH v3] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-20 Thread Samuel Čavoj
Hi, naturally I notice this right after I send the patch, but my whitespace is wrong. Time to set a pre-commit hook up. I guess that means a v4, unless you would fix it on your end? It's just a single line. Sorry about all the noise, Sam On 21.10.2020 00:09, Samuel Čavoj wrote: > @

Re: [PATCH v3] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-20 Thread Samuel Čavoj
Hi, On 21.10.2020 00:09, Samuel Čavoj wrote: > The UX360CA has a WMI device id 0x00060062, which reports whether the > lid is flipped in tablet mode (1) or in normal laptop mode (0). > > Add a quirk (quirk_asus_use_lid_flip_devid) for devices on which this > WMI device should be

[PATCH v3] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-20 Thread Samuel Čavoj
not have a 360 degree hinge (at least FX503VD and GL503VD from Hans' DSTS collection) and therefore its presence cannot be relied on. Signed-off-by: Samuel Čavoj Cc: Hans de Goede --- changed v2 -> v3: - added check on resume from sleep and restore --- drivers/platform/x86/asus-nb-

Re: [PATCH v2] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-18 Thread Samuel Čavoj
Hi, On 18.10.2020 11:26, Hans de Goede wrote: > Hi, > > On 10/18/20 1:33 AM, Samuel Čavoj wrote: > > Hello everyone. > > > > On 17.09.2020 15:34, Samuel Čavoj wrote: > >> The UX360CA has a WMI device id 0x00060062, which reports whether the > >> l

Re: [PATCH v2] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-10-17 Thread Samuel Čavoj
Hello everyone. On 17.09.2020 15:34, Samuel Čavoj wrote: > The UX360CA has a WMI device id 0x00060062, which reports whether the > lid is flipped in tablet mode (1) or in normal laptop mode (0). > > This commit adds a quirk (quirk_asus_use_lid_flip_devid) for devices on > which

Re: [PATCH] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-09-17 Thread Samuel Čavoj
On 17.09.2020 14:56, mark gross wrote: > On Wed, Sep 16, 2020 at 09:12:33PM +0200, Samuel Čavoj wrote: > > The UX360CA has a WMI device id 0x00060062, which reports whether the > > lid is flipped in tablet mode (1) or in normal laptop mode (0). > > > &g

[PATCH v2] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-09-17 Thread Samuel Čavoj
: Fix SW_TABLET_MODE always reporting 1 on many different models" by Hans de Goede. Signed-off-by: Samuel Čavoj Cc: Hans de Goede --- v1 -> v2: - inherit wmi_backlight_set_devstate from default quirk --- drivers/platform/x86/asus-nb-wmi.c | 15 +++ drivers/platform/x8

Re: [PATCH] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-09-17 Thread Samuel Čavoj
Hi. On 17.09.2020 14:23, Hans de Goede wrote: > Hi, > > On 9/16/20 9:12 PM, Samuel Čavoj wrote: > > The UX360CA has a WMI device id 0x00060062, which reports whether the > > lid is flipped in tablet mode (1) or in normal laptop mode (0). > > &

[PATCH] platform/x86: asus-wmi: Add support for SW_TABLET_MODE on UX360

2020-09-16 Thread Samuel Čavoj
: Fix SW_TABLET_MODE always reporting 1 on many different models" by Hans de Goede. Signed-off-by: Samuel Čavoj Cc: Hans de Goede --- drivers/platform/x86/asus-nb-wmi.c | 14 + drivers/platform/x86/asus-wmi.c| 23 ++ drivers/platform/x86/a

Re: platform/x86: asus-wmi: SW_TABLET_MODE is always 1 on some devices

2020-09-10 Thread Samuel Čavoj
Hello! On 10.09.2020 19:44, Hans de Goede wrote: > Hi, > > On 9/4/20 7:17 PM, Samuel Čavoj wrote: > > Hi, > > > > On 04.09.2020 12:06, Hans de Goede wrote: > > > Hi, > > > > > > On 9/4/20 11:45 AM, Samuel Čavoj wrote: > > > &g

Re: platform/x86: asus-wmi: SW_TABLET_MODE is always 1 on some devices

2020-09-04 Thread Samuel Čavoj
Hi, On 04.09.2020 12:06, Hans de Goede wrote: > Hi, > > On 9/4/20 11:45 AM, Samuel Čavoj wrote: > > Hello! > > > > On 02.09.2020 14:52, Samuel Čavoj wrote: > > > Hello, > > > > > > On 02.09.2020 13:52, Hans de Goede wrote: > > &g

platform/x86: asus-wmi: SW_TABLET_MODE is always 1 on some devices

2020-09-01 Thread Samuel Čavoj
Hello! A bug was introduced with the following commit[1]: b0dbd97de: platform/x86: asus-wmi: Add support for SW_TABLET_MODE The SW_TABLET_MODE switch seems to be always 1 on some devices, including my UX360CA and a UX390UAK[2]. This can be seen in the output of evtest: # evtest /dev/in

Re: [GIT PULL] HID for 5.7

2020-05-09 Thread Samuel Čavoj
On 03.04.2020 12:05, Jiri Kosina wrote: > It would still be possible to access the report via hidraw, and maybe > that's analogy of what the Windows driver/special Glorious software :) > does, I don't know. It's hard to believe that Windows would be actually > willing to report any changes comin