Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
> > + dev = cdev->dev->platform_data;
>
> Umm, platform data is not the best place for storing this. Why not drvdata?
Ah, actually led_classdev already makes use of it, see the
device_create_with_groups call in
Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
+ dev = cdev-dev-platform_data;
Umm, platform data is not the best place for storing this. Why not drvdata?
Ah, actually led_classdev already makes use of it, see the
device_create_with_groups call in led_classdev_register.
Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit :
Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
+ dev = cdev-dev-platform_data;
Umm, platform data is not the best place for storing this. Why not drvdata?
Ah, actually led_classdev already makes use of it, see
Dmitry Torokhov, le Thu 22 Jan 2015 16:37:02 -0800, a écrit :
On Friday, January 23, 2015 01:30:11 AM Samuel Thibault wrote:
Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit :
Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
+ dev = cdev-dev-platform_data
Dmitry Torokhov, le Thu 22 Jan 2015 16:51:16 -0800, a écrit :
No. Please take a look at other users of platform data. Platform is the box
we
are running on, not parent device. Platform data is supposed to be constant,
not changing between driver runs.
Ok, well, then we can just use
Hello,
Pavel Machek, le Fri 02 Jan 2015 20:53:51 +0100, a écrit :
> > Here is v5 coming, with separate patches for the kbd and the input
> > parts.
>
> After booting with this, capslock led does not seem to work on text
> console.
>
> input4::capsl/trigger was none by default, that can't be
Hello,
Pavel Machek, le Fri 02 Jan 2015 20:53:51 +0100, a écrit :
Here is v5 coming, with separate patches for the kbd and the input
parts.
After booting with this, capslock led does not seem to work on text
console.
input4::capsl/trigger was none by default, that can't be right,
Dmitry Torokhov, le Mon 05 Jan 2015 09:42:05 -0800, a écrit :
> The input device's capabilities (with the exception of keymap) should
> not change after device registration. If uinput allows that we should
> fix it there.
Ah, I didn't notice the content of uinput_set_bit() there. It seems to
be
Dmitry Torokhov, le Mon 05 Jan 2015 09:42:05 -0800, a écrit :
The input device's capabilities (with the exception of keymap) should
not change after device registration. If uinput allows that we should
fix it there.
Ah, I didn't notice the content of uinput_set_bit() there. It seems to
be
Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
> I'd rather we did not have a separate config option for this. Do we really
> need to
> support case where LEDs are disabled?
I don't really mind.
> I'd rather stub it out instead of providing 2 separate code paths.
Ok.
> > +/*
Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit :
I'd rather we did not have a separate config option for this. Do we really
need to
support case where LEDs are disabled?
I don't really mind.
I'd rather stub it out instead of providing 2 separate code paths.
Ok.
+/* LED
Pavel Machek, le Fri 02 Jan 2015 20:53:51 +0100, a écrit :
> input4::capsl/trigger was none by default, that can't be right, right?
Indeed. And I don't see how it can be that way, since the input4::capsl
LED and the input4-capsl trigger get initialized at the same time in
input_led_connect...
Pavel Machek, le Fri 02 Jan 2015 20:53:51 +0100, a écrit :
input4::capsl/trigger was none by default, that can't be right, right?
Indeed. And I don't see how it can be that way, since the input4::capsl
LED and the input4-capsl trigger get initialized at the same time in
input_led_connect... (and
LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault
Signed-off-by: Evan Broder
Acked-by: Peter Korsgaard
Signed-off-by: John Crispin
Signed-off-by: Andrew Morton
---
Changed in this version:
- separate kbd LED ch
...@mokafive.com: Rebased to 3.2-rc1 or so, cleaned up some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault
Signed-off-by: Evan Broder
Acked
Here is v5 coming, with separate patches for the kbd and the input
parts.
Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
Here is v5 coming, with separate patches for the kbd and the input
parts.
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
...@mokafive.com: Rebased to 3.2-rc1 or so, cleaned up some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
Signed-off-by: Evan Broder e...@ebroder.net
Acked-by: Peter Korsgaard jac...@sunsite.dk
Signed-off-by: John Crispin blo...@openwrt.org
Signed-off
Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +, a écrit :
> Combine the consecutive string
>
> Signed-off-by: Panir Nyan
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +, a écrit :
> Split the comment to fit the length.
>
> Signed-off-by: Panir Nyan
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/synth.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff
Panir.Nyan, le Wed 24 Dec 2014 04:07:31 +, a écrit :
Split the comment to fit the length.
Signed-off-by: Panir Nyan panir.n...@gmail.com
Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
drivers/staging/speakup/synth.c |6 +++---
1 file changed, 3 insertions(+), 3
Panir.Nyan, le Wed 24 Dec 2014 04:07:32 +, a écrit :
Combine the consecutive string
Signed-off-by: Panir Nyan panir.n...@gmail.com
Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
drivers/staging/speakup/kobjects.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
Dmitry Torokhov, le Fri 19 Dec 2014 23:27:15 -0800, a écrit :
> Yes, I believe it is.
Good :)
> Also, can you please split off input core changes from tty changes in
> your patch?
Yes. I this new formulation they become really completely separate
matters.
Samuel
--
To unsubscribe from this
Dmitry Torokhov, le Fri 19 Dec 2014 23:27:15 -0800, a écrit :
Yes, I believe it is.
Good :)
Also, can you please split off input core changes from tty changes in
your patch?
Yes. I this new formulation they become really completely separate
matters.
Samuel
--
To unsubscribe from this list:
Dmitry Torokhov, le Fri 19 Dec 2014 15:07:21 -0800, a écrit :
> On Sat, Dec 20, 2014 at 12:02:53AM +0100, Pavel Machek wrote:
> > On Fri 2014-12-19 23:59:33, Samuel Thibault wrote:
> > > Andrew Morton, le Fri 19 Dec 2014 14:46:41 -0800, a écrit :
> > > > > Changed
Andrew Morton, le Fri 19 Dec 2014 14:46:41 -0800, a écrit :
> > Changed in this version:
> > - Use kcalloc instead of kzalloc
> > - to avoid any mutex order violation, defer LED update into a work callback.
>
> Confused. This patch is identical to the one that's presently in -mm.
Well, yes: I'm
Andrew Morton, le Fri 19 Dec 2014 14:46:41 -0800, a écrit :
Changed in this version:
- Use kcalloc instead of kzalloc
- to avoid any mutex order violation, defer LED update into a work callback.
Confused. This patch is identical to the one that's presently in -mm.
Well, yes: I'm
Dmitry Torokhov, le Fri 19 Dec 2014 15:07:21 -0800, a écrit :
On Sat, Dec 20, 2014 at 12:02:53AM +0100, Pavel Machek wrote:
On Fri 2014-12-19 23:59:33, Samuel Thibault wrote:
Andrew Morton, le Fri 19 Dec 2014 14:46:41 -0800, a écrit :
Changed in this version:
- Use kcalloc instead
Peter Korsgaard, le Tue 09 Dec 2014 21:22:03 +0100, a écrit :
> > I would like you to remind you this patch which is waiting for
> > your review since April 2014!
>
> Hah, I'm pretty sure it dates back to 2010 atleast.
Yes, the first version was posted on February 2010. There has been some
cleaned up some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault
Signed-off-by: Evan Broder
Reviewed-by: David Herrmann
Tested-by: Pa
some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
Signed-off-by: Evan Broder e...@ebroder.net
Reviewed
Peter Korsgaard, le Tue 09 Dec 2014 21:22:03 +0100, a écrit :
I would like you to remind you this patch which is waiting for
your review since April 2014!
Hah, I'm pretty sure it dates back to 2010 atleast.
Yes, the first version was posted on February 2010. There has been some
wing build error when input is built as a module:
leds.c:(.init.text+0x0): multiple definition of `init_module'
leds.c:(.exit.text+0x0): multiple definition of `cleanup_module'
This also adds a proper clean of the vt_led_work queues in the exit
function.
Signed-off-by: Samuel Thibaul
as a module:
leds.c:(.init.text+0x0): multiple definition of `init_module'
leds.c:(.exit.text+0x0): multiple definition of `cleanup_module'
This also adds a proper clean of the vt_led_work queues in the exit
function.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
This is a follow
Pali Rohár, le Sun 12 Oct 2014 16:52:08 +0200, a écrit :
> I would like to ask if something was changed and if this patch
> (in any way) is going to mainline kernel.
Well, the latest news I got from Dmity was on 12 Apr 2014, to which I
answered, and never got more news since then. I'm indeed
Pali Rohár, le Sun 12 Oct 2014 16:52:08 +0200, a écrit :
I would like to ask if something was changed and if this patch
(in any way) is going to mainline kernel.
Well, the latest news I got from Dmity was on 12 Apr 2014, to which I
answered, and never got more news since then. I'm indeed
Andrew Morton, le Wed 01 Oct 2014 11:42:57 -0700, a écrit :
> On Mon, 31 Mar 2014 14:23:23 +0200 Samuel Thibault
> wrote:
> > This permits to reassign keyboard LEDs to something else than keyboard
> > "leds"
> > state, by adding keyboard led and modifier trigge
Andrew Morton, le Wed 01 Oct 2014 11:42:57 -0700, a écrit :
On Mon, 31 Mar 2014 14:23:23 +0200 Samuel Thibault
samuel.thiba...@ens-lyon.org wrote:
This permits to reassign keyboard LEDs to something else than keyboard
leds
state, by adding keyboard led and modifier triggers connected
.
Signed-off-by: Samuel Thibault
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1155,13 +1155,13 @@ int sock_getsockopt(struct socket *sock,
case SO_PEERNAME:
{
- char address[128];
+ struct sockaddr_storage address;
- if (sock->
.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1155,13 +1155,13 @@ int sock_getsockopt(struct socket *sock,
case SO_PEERNAME:
{
- char address[128];
+ struct sockaddr_storage address
hooting himself in the foot by creating a
vt::capsl <-> vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault
---
Difference with v1: uses schedule_work instead of its own workqueue.
in the foot by creating a
vt::capsl - vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
Difference with v1: uses schedule_work instead of its own workqueue
Samuel Thibault, le Tue 26 Aug 2014 15:24:10 +0200, a écrit :
> Johannes Berg, le Tue 26 Aug 2014 15:22:07 +0200, a écrit :
> > On Tue, 2014-08-26 at 11:17 +0200, Samuel Thibault wrote:
> >
> > > - led_trigger_event(_led_triggers[led], !!brightness);
> > > +
Johannes Berg, le Tue 26 Aug 2014 15:22:07 +0200, a écrit :
> On Tue, 2014-08-26 at 11:17 +0200, Samuel Thibault wrote:
>
> > - led_trigger_event(_led_triggers[led], !!brightness);
> > + vt_led_state[led] = !!brightness;
> > + schedule_work(_led_work[led]);
>
ent the user from shooting himself in the foot by creating a
vt::capsl <-> vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault
---
Difference with v1: uses schedule_work instead o
Johannes Berg, le Tue 26 Aug 2014 10:01:35 +0200, a écrit :
> On Tue, 2014-08-26 at 03:54 +0200, Samuel Thibault wrote:
>
> > + vt_led_wq = alloc_workqueue("input_leds", WQ_UNBOUND, 0);
> > + if (!vt_led_wq)
> > + return -ENOMEM;
>
> Do
Johannes Berg, le Tue 26 Aug 2014 10:01:35 +0200, a écrit :
On Tue, 2014-08-26 at 03:54 +0200, Samuel Thibault wrote:
+ vt_led_wq = alloc_workqueue(input_leds, WQ_UNBOUND, 0);
+ if (!vt_led_wq)
+ return -ENOMEM;
Does this really need a separate workqueue rather than just
the user from shooting himself in the foot by creating a
vt::capsl - vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
Difference with v1: uses
Johannes Berg, le Tue 26 Aug 2014 15:22:07 +0200, a écrit :
On Tue, 2014-08-26 at 11:17 +0200, Samuel Thibault wrote:
- led_trigger_event(vt_led_triggers[led], !!brightness);
+ vt_led_state[led] = !!brightness;
+ schedule_work(vt_led_work[led]);
+static int __init
Samuel Thibault, le Tue 26 Aug 2014 15:24:10 +0200, a écrit :
Johannes Berg, le Tue 26 Aug 2014 15:22:07 +0200, a écrit :
On Tue, 2014-08-26 at 11:17 +0200, Samuel Thibault wrote:
- led_trigger_event(vt_led_triggers[led], !!brightness);
+ vt_led_state[led] = !!brightness
ent the user from shooting himself in the foot by creating a
vt::capsl <-> vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault
--- a/drivers/input/leds.c
+++ b/drivers/input/leds.c
@
Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit :
> On Mon, 25 Aug 2014, Samuel Thibault wrote:
> > Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
> > > We could indeed have a loop if the user was making the VT::* leds use
> > > the vt-* trigge
Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
> We could indeed have a loop if the user was making the VT::* leds use
> the vt-* trigger,
Actually, while there can be a loop, it wouldn't be possible to inject
events in it: a VT::* led only makes the corresponding vt-* t
Hello,
Sabrina Dubroca, le Mon 25 Aug 2014 23:13:40 +0200, a écrit :
> 2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote:
> > On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said:
> > > Can we safely revert your 8b37e1bef5a6 ("leds: convert blink timer to
> > > workqueue"), or have there
Hello,
Sabrina Dubroca, le Mon 25 Aug 2014 23:13:40 +0200, a écrit :
2014-08-19, 13:06:07 -0400, valdis.kletni...@vt.edu wrote:
On Sat, 16 Aug 2014 20:27:01 -0700, Hugh Dickins said:
Can we safely revert your 8b37e1bef5a6 (leds: convert blink timer to
workqueue), or have there been other
Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
We could indeed have a loop if the user was making the VT::* leds use
the vt-* trigger,
Actually, while there can be a loop, it wouldn't be possible to inject
events in it: a VT::* led only makes the corresponding vt-* trigger
Hugh Dickins, le Mon 25 Aug 2014 15:00:44 -0700, a écrit :
On Mon, 25 Aug 2014, Samuel Thibault wrote:
Samuel Thibault, le Mon 25 Aug 2014 23:23:24 +0200, a écrit :
We could indeed have a loop if the user was making the VT::* leds use
the vt-* trigger,
Actually, while there can
the user from shooting himself in the foot by creating a
vt::capsl - vt-capsl loop, but the only consequence is the workqueue
threads eating some CPU until the user breaks the loop, which is not too
bad.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
--- a/drivers/input/leds.c
+++ b/drivers
The speakup mailing list only works on the linux-speakup.org domain now.
Signed-off-by: Samuel Thibault
diff --git a/MAINTAINERS b/MAINTAINERS
index 61a8f48..bcf5efd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8646,7 +8646,7 @@ M:William Hubbs
M: Chris Brannon
M: Kirk
The speakup mailing list only works on the linux-speakup.org domain now.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
diff --git a/MAINTAINERS b/MAINTAINERS
index 61a8f48..bcf5efd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8646,7 +8646,7 @@ M:William Hubbs w.d.hu
Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
>
> Signed-off-by: Sasha Levin
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/synth.c |3 +++
> 1 file changed, 3 insertions(
Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
Setting a 'silent' parameter without a synth would crash the kernel.
Signed-off-by: Sasha Levin sasha.le...@oracle.com
Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
drivers/staging/speakup/synth.c |3 +++
1 file
Hello,
Dmitry Torokhov, le Sat 12 Apr 2014 18:25:57 -0700, a écrit :
> On Fri, Apr 11, 2014 at 08:12:02AM +0200, Samuel Thibault wrote:
> > I'm sorry this went out with a few mistakes.
> >
> > Samuel Thibault, le Wed 09 Apr 2014 01:33:06 +0200, a écrit :
> > > Dmitr
Hello,
Dmitry Torokhov, le Sat 12 Apr 2014 18:25:57 -0700, a écrit :
On Fri, Apr 11, 2014 at 08:12:02AM +0200, Samuel Thibault wrote:
I'm sorry this went out with a few mistakes.
Samuel Thibault, le Wed 09 Apr 2014 01:33:06 +0200, a écrit :
Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40
Hello,
I'm sorry this went out with a few mistakes.
Samuel Thibault, le Wed 09 Apr 2014 01:33:06 +0200, a écrit :
> Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40 -0700, a écrit :
> > It is not about the VT, I am talking about pure input core. If I
> > repurpose CapsLock LED for my
Hello,
I'm sorry this went out with a few mistakes.
Samuel Thibault, le Wed 09 Apr 2014 01:33:06 +0200, a écrit :
Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40 -0700, a écrit :
It is not about the VT, I am talking about pure input core. If I
repurpose CapsLock LED for my WiFi indicator I do
Hello,
Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40 -0700, a écrit :
> It is not about the VT, I am talking about pure input core. If I
> repurpose CapsLock LED for my WiFi indicator I do not want to go into
> other programs and teach them that they should stay away from trying to
> control this
Hello,
Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40 -0700, a écrit :
It is not about the VT, I am talking about pure input core. If I
repurpose CapsLock LED for my WiFi indicator I do not want to go into
other programs and teach them that they should stay away from trying to
control this LED.
Dmitry Torokhov, le Sun 06 Apr 2014 19:10:15 -0700, a écrit :
> On Mon, Mar 31, 2014 at 02:23:23PM +0200, Samuel Thibault wrote:
> > This permits to reassign keyboard LEDs to something else than keyboard
> > "leds"
> > state, by adding keyboard led and modifier
Dmitry Torokhov, le Sun 06 Apr 2014 19:10:15 -0700, a écrit :
On Mon, Mar 31, 2014 at 02:23:23PM +0200, Samuel Thibault wrote:
This permits to reassign keyboard LEDs to something else than keyboard
leds
state, by adding keyboard led and modifier triggers connected to a series
of VT input
cleaned up some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault
Signed-off-by: Evan Broder
Reviewed-by: David Herrmann
Tested-by: Pa
some includes, and
fixed some constants]
[blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline]
[a...@linux-foundation.org: remove unneeded `extern', fix comment layout]
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
Signed-off-by: Evan Broder e...@ebroder.net
Reviewed
Pavel Machek, le Fri 28 Mar 2014 08:01:36 +0100, a écrit :
> On Thu 2014-03-27 02:08:17, Pali Rohár wrote:
> > 2014-03-16 11:19 GMT+01:00 Samuel Thibault :
> > > Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit :
> > >> Hello, what happened with th
Pavel Machek, le Fri 28 Mar 2014 08:01:36 +0100, a écrit :
On Thu 2014-03-27 02:08:17, Pali Rohár wrote:
2014-03-16 11:19 GMT+01:00 Samuel Thibault samuel.thiba...@ens-lyon.org:
Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit :
Hello, what happened with this patch? Is there any
The Hardware Locality (hwloc) team is pleased to announce the release
of v1.9:
http://www.open-mpi.org/projects/hwloc/
v1.9 is a major new release series.
It adds a couple enhanced API functions, many object attributes for
better representing CPU and I/O device characteristics, and more.
*
The Hardware Locality (hwloc) team is pleased to announce the release
of v1.9:
http://www.open-mpi.org/projects/hwloc/
v1.9 is a major new release series.
It adds a couple enhanced API functions, many object attributes for
better representing CPU and I/O device characteristics, and more.
*
Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit :
> Hello, what happened with this patch? Is there any problem with accepting it?
Dmitry finding time to review it, I guess.
Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit :
Hello, what happened with this patch? Is there any problem with accepting it?
Dmitry finding time to review it, I guess.
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
> Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
The Hardware Locality (hwloc) team is pleased to announce the release
of v1.8:
http://www.open-mpi.org/projects/hwloc/
v1.8 is a major new release series.
It adds PCI discovery on Linux without dependencies on external libs,
a new API to manipulate differences between very similar topologies,
The Hardware Locality (hwloc) team is pleased to announce the release
of v1.8:
http://www.open-mpi.org/projects/hwloc/
v1.8 is a major new release series.
It adds PCI discovery on Linux without dependencies on external libs,
a new API to manipulate differences between very similar topologies,
Samuel Thibault, le Sun 03 Nov 2013 13:36:21 +0100, a écrit :
> So in the end it would probably be simpler to just stuff leds.c along
> input.c in input.ko or built-in. CONFIG_INPUT_LEDS will thus become a
> bool. I'm working on that now.
Here it is. This replaces both
input-route
Fengguang Wu, le Sun 03 Nov 2013 20:08:53 +0800, a écrit :
> It's a bug fix that unveils the link errors.
>
>drivers/built-in.o: In function `__input_unregister_device':
>input.c:(.text+0xf0e55): undefined reference to `input_led_disconnect'
Ok, so the "something like this" in the patch
Fengguang Wu, le Sun 03 Nov 2013 20:08:53 +0800, a écrit :
It's a bug fix that unveils the link errors.
drivers/built-in.o: In function `__input_unregister_device':
input.c:(.text+0xf0e55): undefined reference to `input_led_disconnect'
Ok, so the something like this in the patch review
Samuel Thibault, le Sun 03 Nov 2013 13:36:21 +0100, a écrit :
So in the end it would probably be simpler to just stuff leds.c along
input.c in input.ko or built-in. CONFIG_INPUT_LEDS will thus become a
bool. I'm working on that now.
Here it is. This replaces both
input-route-kbd-leds-through
IG_INPUT_LEDS=m
>
> ERROR: "input_led_disconnect" [drivers/input/input-core.ko] undefined!
> ERROR: "input_led_connect" [drivers/input/input-core.ko] undefined!
>
>
> Full randconfig file is attached.
Ah, right, in that config an export is needed, here is a p
/input/input-core.ko] undefined!
Full randconfig file is attached.
Ah, right, in that config an export is needed, here is a patch.
Samuel
Export input led symbols for input core module.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
--- drivers/input/leds.c.orig 2013-11-01 01
eds-layer.patch
or perhaps rather fold into it?
Samuel
Really mark inlines as static inlines, so they are not defined multiple
times.
Signed-off-by: Samuel Thibault
--- include/linux/input.h.orig 2013-10-30 12:42:41.169038670 +0100
+++ include/linux/input.h 2013-10-30 12:42:42.908987157 +0
-layer.patch
or perhaps rather fold into it?
Samuel
Really mark inlines as static inlines, so they are not defined multiple
times.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
--- include/linux/input.h.orig 2013-10-30 12:42:41.169038670 +0100
+++ include/linux/input.h 2013-10-30 12
Hello,
Andrew Morton, le Tue 08 Oct 2013 16:01:52 -0700, a écrit :
> Do you believe that the earlier controversies are now addressed and if
> so, how?
Yes. Dmitry thought more about how to integrate that nicely on 12th
Jan 2011, which I did. The patch was rebased on 3.x, and I submitted a
Hello,
Andrew Morton, le Tue 08 Oct 2013 16:01:52 -0700, a écrit :
Do you believe that the earlier controversies are now addressed and if
so, how?
Yes. Dmitry thought more about how to integrate that nicely on 12th
Jan 2011, which I did. The patch was rebased on 3.x, and I submitted a
fies the code
> and allows code reusing.
>
> Signed-off-by: Raphael S.Carvalho
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c | 71
>
> 1 files changed, 39 insertions(+), 32 deletions(-)
>
> diff --git a/drivers
w user input that was used to select the voice.
> Note that using the raw input can also lead to an invalid memory read
> in the case of invalid or malicious user input.
>
> Signed-off-by: Christopher Brannon
Acked-by: Samuel Thibault
> ---
> drivers/staging/speakup/kobjects.c
that was used to select the voice.
Note that using the raw input can also lead to an invalid memory read
in the case of invalid or malicious user input.
Signed-off-by: Christopher Brannon ch...@the-brannons.com
Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
drivers/staging/speakup
-by: Raphael S.Carvalho raphael.sc...@gmail.com
Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
drivers/staging/speakup/kobjects.c | 71
1 files changed, 39 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers
ge the LED
behavior of (a priori) all input devices, or of particular input devices.
This also permits to fix #7063 from userland by using a modifier to implement
proper CapsLock behavior and have the keyboard caps lock led show that modifier
state.
Signed-off-by: Samuel Thibault
[ebro...@mo
behavior of (a priori) all input devices, or of particular input devices.
This also permits to fix #7063 from userland by using a modifier to implement
proper CapsLock behavior and have the keyboard caps lock led show that modifier
state.
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
> link:
> http://lkml.kernel.org/r/1350999678-17441-1-git-send-email-ming....@canonical.com
> cc: Samuel Thibault
Reviewed-By: Samuel Thibault
Thanks,
Samuel
> cc: Ming Lei
> Signed-off-by: Joe Perches
> ---
> drivers/accessibility/braille/braille_console
401 - 500 of 700 matches
Mail list logo
