Re: [PATCH v8 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2021-04-20 Thread Sanjay R Mehta
On 3/22/2021 10:36 PM, Randy Dunlap wrote: > [CAUTION: External Email] > > On 3/21/21 9:59 PM, Sanjay R Mehta wrote: >> From: Sanjay R Mehta >> >> Add support for AMD PTDMA controller. It performs high-bandwidth >> memory to memory and IO copy operation. Dev

Re: [PATCH v8 0/3] Add support for AMD PTDMA controller driver

2021-04-06 Thread Sanjay R Mehta
On 3/22/2021 10:29 AM, Sanjay R Mehta wrote: > From: Sanjay R Mehta > > This patch series add support for AMD PTDMA controller which > performs high bandwidth memory-to-memory and IO copy operation, > performs DMA transfer through queue based descriptor management. > &

Re: [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2021-03-21 Thread Sanjay R Mehta
On 3/22/2021 11:34 AM, Vinod Koul wrote: > [CAUTION: External Email] > > On 18-03-21, 16:16, Sanjay R Mehta wrote: >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include

[PATCH v8 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2021-03-21 Thread Sanjay R Mehta
From: Sanjay R Mehta Add support for AMD PTDMA controller. It performs high-bandwidth memory to memory and IO copy operation. Device commands are managed via a circular queue of 'descriptors', each of which specifies source and destination addresses for copying a single buffer of dat

[PATCH v8 0/3] Add support for AMD PTDMA controller driver

2021-03-21 Thread Sanjay R Mehta
From: Sanjay R Mehta This patch series add support for AMD PTDMA controller which performs high bandwidth memory-to-memory and IO copy operation, performs DMA transfer through queue based descriptor management. AMD Processor has multiple ptdma device instances with each controller having single

[PATCH v8 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA

2021-03-21 Thread Sanjay R Mehta
From: Sanjay R Mehta Expose data about the configuration and operation of the PTDMA through debugfs entries: device name, capabilities, configuration, statistics. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Makefile| 2 +- drivers/dma/ptdma/ptdma-debugfs.c | 115

[PATCH v8 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2021-03-21 Thread Sanjay R Mehta
From: Sanjay R Mehta Register ptdma queue to Linux dmaengine framework as general-purpose DMA channels. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Kconfig | 2 + drivers/dma/ptdma/Makefile | 2 +- drivers/dma/ptdma/ptdma-dev.c | 32 +++ drivers/dma/ptdma

Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2021-03-18 Thread Sanjay R Mehta
>> + dma_dev->dst_addr_widths = PT_DMA_WIDTH(dma_get_mask(pt->dev)); >> + dma_dev->directions = DMA_MEM_TO_MEM; >> + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; >> + dma_cap_set(DMA_MEMCPY, dma_dev->cap_mask); >> + dma_cap_set(DMA_INTERRUPT, dma_dev->cap_m

Re: [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2021-03-18 Thread Sanjay R Mehta
>> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > why do you need sched.h here? > >> + >> +#include "ptdma.h" >> + >> +/* Ever-increasing value to produce unique unit numbers */ >> +static atomic_t pt_ordinal; > > Wh

Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-11-24 Thread Sanjay R Mehta
On 11/24/2020 7:53 PM, Vitaly Mayatskih wrote: > [CAUTION: External Email] > > On Wed, Nov 18, 2020 at 7:20 AM Vinod Koul wrote: > >> this should be single line > > Vinod, do you see any obvious functional defects still present in the > driver, or can it be finally merged for us to start tes

Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-11-24 Thread Sanjay R Mehta
On 11/24/2020 10:48 PM, Vinod Koul wrote: > [CAUTION: External Email] > > Hello Vitaly, > > On 24-11-20, 09:23, Vitaly Mayatskih wrote: >> On Wed, Nov 18, 2020 at 7:20 AM Vinod Koul wrote: >> >>> this should be single line >> >> Vinod, do you see any obvious functional defects still present i

Re: [PATCH v7 0/3] Add support for AMD PTDMA controller driver

2020-11-11 Thread Sanjay R Mehta
On 10/16/2020 1:09 PM, Sanjay R Mehta wrote: > From: Sanjay R Mehta > > This patch series adds support for AMD PTDMA controller which > performs high bandwidth memory-to-memory and IO copy operation, > performs DMA transfer through queue based descriptor management. > &

Re: [PATCH v7 0/3] Add support for AMD PTDMA controller driver

2020-11-08 Thread Sanjay R Mehta
> Sanjay R Mehta (3): > dmaengine: ptdma: Initial driver for the AMD PTDMA > dmaengine: ptdma: register PTDMA controller as a DMA resource > dmaengine: ptdma: Add debugfs entries for PTDMA information > > MAINTAINERS | 6 + >

[PATCH v2] pciehp: Add check for DL_ACTIVE bit in pciehp_check_link_status()

2020-10-19 Thread Sanjay R Mehta
From: Sanjay R Mehta if DL_ACTIVE bit is set it means that there is no need to check PCI_EXP_LNKSTA_LT bit, as DL_ACTIVE would have set only if the link is already trained. Hence adding a check which takes care of this scenario. Signed-off-by: Sanjay R Mehta --- drivers/pci/hotplug

[PATCH v7 0/3] Add support for AMD PTDMA controller driver

2020-10-16 Thread Sanjay R Mehta
From: Sanjay R Mehta This patch series adds support for AMD PTDMA controller which performs high bandwidth memory-to-memory and IO copy operation, performs DMA transfer through queue based descriptor management. AMD Processor has multiple ptdma device instances with each controller having

[PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-10-16 Thread Sanjay R Mehta
From: Sanjay R Mehta Register ptdma queue to Linux dmaengine framework as general-purpose DMA channels. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Kconfig | 2 + drivers/dma/ptdma/Makefile | 2 +- drivers/dma/ptdma/ptdma-dev.c | 32 +++ drivers/dma/ptdma

[PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2020-10-16 Thread Sanjay R Mehta
From: Sanjay R Mehta Adding support for AMD PTDMA controller. It performs high-bandwidth memory to memory and IO copy operation. Device commands are managed via a circular queue of 'descriptors', each of which specifies source and destination addresses for copying a single buff

[PATCH v7 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-10-16 Thread Sanjay R Mehta
From: Sanjay R Mehta Expose data about the configuration and operation of the PTDMA through debugfs entries: device name, capabilities, configuration, statistics. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Makefile| 2 +- drivers/dma/ptdma/ptdma-debugfs.c | 115

[PATCH v6 0/3] Add support for AMD PTDMA controller driver

2020-10-12 Thread Sanjay R Mehta
From: Sanjay R Mehta This patch series adds support for AMD PTDMA controller which performs high bandwidth memory-to-memory and IO copy operation, performs DMA transfer through queue based descriptor management. AMD Processor has multiple ptdma device instances with each controller having

[PATCH v6 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-10-12 Thread Sanjay R Mehta
From: Sanjay R Mehta Expose data about the configuration and operation of the PTDMA through debugfs entries: device name, capabilities, configuration, statistics. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Makefile| 2 +- drivers/dma/ptdma/ptdma-debugfs.c | 115

[PATCH v6 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-10-12 Thread Sanjay R Mehta
From: Sanjay R Mehta Register ptdma queue to Linux dmaengine framework as general-purpose DMA channels. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Kconfig | 2 + drivers/dma/ptdma/Makefile | 2 +- drivers/dma/ptdma/ptdma-dev.c | 32 ++ drivers/dma/ptdma

[PATCH v6 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

2020-10-12 Thread Sanjay R Mehta
From: Sanjay R Mehta Adding support for AMD PTDMA controller. It performs high-bandwidth memory to memory and IO copy operation. Device commands are managed via a circular queue of 'descriptors', each of which specifies source and destination addresses for copying a single buff

Re: [PATCH] PCI: pciehp: Add check for DL_ACTIVE bit in pciehp_check_link_status()

2020-10-08 Thread Sanjay R Mehta
On 10/7/2020 1:08 AM, Lukas Wunner wrote: > [CAUTION: External Email] > > On Tue, Oct 06, 2020 at 01:24:28PM -0500, Sanjay R Mehta wrote: >> if DL_ACTIVE bit is set it means that there is no need to check >> PCI_EXP_LNKSTA_LT bit, as DL_ACTIVE would have set only if t

[PATCH] PCI: pciehp: Add check for DL_ACTIVE bit in pciehp_check_link_status()

2020-10-06 Thread Sanjay R Mehta
From: Sanjay R Mehta if DL_ACTIVE bit is set it means that there is no need to check PCI_EXP_LNKSTA_LT bit, as DL_ACTIVE would have set only if the link is already trained. Hence adding a check which takes care of this scenario. Signed-off-by: Sanjay R Mehta --- drivers/pci/hotplug

[PATCH] watchdog: amd-wdt: Add AMD FCH hw watchdog driver support

2020-09-22 Thread Sanjay R Mehta
This driver supports hardware watchdog for AMD SoCs. Signed-off-by: Sanjay R Mehta --- MAINTAINERS| 5 + drivers/watchdog/Kconfig | 14 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/amd_wdt.c | 361 + 4 files changed, 381

Re: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-08-25 Thread Sanjay R Mehta
> On 24-08-20, 13:11, Sanjay R Mehta wrote: >> Apologies for my delayed response. >> >> On 7/3/2020 12:48 PM, Vinod Koul wrote: >>> [CAUTION: External Email] >>> >>> On 16-06-20, 20:11, Sanjay R Mehta wrote: >>> >

Re: [PATCH v5 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-08-24 Thread Sanjay R Mehta
On 7/3/2020 1:07 PM, Vinod Koul wrote: > > On 16-06-20, 20:11, Sanjay R Mehta wrote: > >> --- a/drivers/dma/ptdma/Makefile >> +++ b/drivers/dma/ptdma/Makefile >> @@ -5,6 +5,7 @@ >> >> obj-$(CONFIG_AMD_PTDMA) += ptdma.o >> >> -ptdm

Re: [PATCH v5 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-08-24 Thread Sanjay R Mehta
> > On 16-06-20, 20:11, Sanjay R Mehta wrote: >> From: Sanjay R Mehta >> >> Expose data about the configuration and operation of the >> PTDMA through debugfs entries: device name, capabilities, >> configuration, statistics. >> >> Signed-off-

Re: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-08-24 Thread Sanjay R Mehta
Apologies for my delayed response. On 7/3/2020 12:48 PM, Vinod Koul wrote: > [CAUTION: External Email] > > On 16-06-20, 20:11, Sanjay R Mehta wrote: > >> +static int pt_core_execute_cmd(struct ptdma_desc *desc, >> +struct pt_cmd_queue *cmd_

[PATCH v5 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-06-16 Thread Sanjay R Mehta
From: Sanjay R Mehta Expose data about the configuration and operation of the PTDMA through debugfs entries: device name, capabilities, configuration, statistics. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Makefile| 3 +- drivers/dma/ptdma/ptdma-debugfs.c | 130

[PATCH v5 0/3] Add support for AMD PTDMA controller driver

2020-06-16 Thread Sanjay R Mehta
From: Sanjay R Mehta This patch series adds support for AMD PTDMA controller which performs high bandwidth memory-to-memory and IO copy operation and performs DMA transfer through queue based descriptor management. AMD Processor has multiple ptdma device instances and each controller has single

[PATCH v5 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-06-16 Thread Sanjay R Mehta
From: Sanjay R Mehta This registers the ptdma queue to Linux dmaengine framework as general-purpose DMA channels. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Kconfig | 2 + drivers/dma/ptdma/Makefile | 3 +- drivers/dma/ptdma/ptdma-dev.c | 33 ++ drivers

[PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-06-16 Thread Sanjay R Mehta
From: Sanjay R Mehta This driver add support for AMD PTDMA controller. This device performs high-bandwidth memory to memory and IO copy operation. Device commands are managed via a circular queue of 'descriptors', each of which specifies source and destination addresses for copyin

Re: [PATCH v4 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-05-25 Thread Sanjay R Mehta
On 5/4/2020 11:44 AM, Vinod Koul wrote: > [CAUTION: External Email] > > On 28-04-20, 16:13, Sanjay R Mehta wrote: > >> +static void pt_do_cmd_complete(unsigned long data) >> +{ >> + struct pt_tasklet_data *tdata = (struct pt_tasklet_data *)data; >> +

Re: [PATCH v4 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-05-25 Thread Sanjay R Mehta
On 5/26/2020 11:59 AM, Greg KH wrote: > [CAUTION: External Email] > > On Tue, May 26, 2020 at 11:35:02AM +0530, Sanjay R Mehta wrote: >> Apologies for my delayed response. >> >>>> +#include >>>> +#include >>>> +#include >&

Re: [PATCH v4 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-05-25 Thread Sanjay R Mehta
>> +static const struct file_operations pt_debugfs_info_ops = { >> + .owner = THIS_MODULE, >> + .open = simple_open, >> + .read = ptdma_debugfs_info_read, >> + .write = NULL, >> +}; >> + >> +static const struct file_operations pt_debugfs_queue_ops = { >> + .owner = THIS_MODULE,

Re: [PATCH v4 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-05-25 Thread Sanjay R Mehta
Apologies for my delayed response. >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "ptdma.h" >> + >> +static int cmd_queue_length = 32; >> +module_param(cmd_queue_length, uint, 0644); >> +MODULE_PARM_DESC(cmd_queue_length, >> + " length of the c

[PATCH v3 4/5] ntb_perf: increase sleep time from one milli sec to one sec

2020-05-05 Thread Sanjay R Mehta
After trying to send commands for a maximum of MSG_TRIES re-tries, link-up fails due to short sleep time(1ms) between re-tries. Hence increasing the sleep time to one second providing sufficient time for perf link-up. Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath --- drivers/ntb

[PATCH v3 2/5] ntb_perf: pass correct struct device to dma_alloc_coherent

2020-05-05 Thread Sanjay R Mehta
eve this is by changing the first parameter of dma_alloc_coherent() as ntb->pdev->dev instead. Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath --- drivers/ntb/test/ntb_per

[PATCH v3 3/5] ntb_tool: pass correct struct device to dma_alloc_coherent

2020-05-05 Thread Sanjay R Mehta
eve this is by changing the first parameter of dma_alloc_coherent() as ntb->pdev->dev instead. Fixes: 5648e56 ("NTB: ntb_perf: Add full multi-port NTB API support") Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath --- drivers/ntb/test/ntb_tool.c | 6 +++--- 1 file changed,

[PATCH v3 5/5] ntb_perf: avoid false dma unmap of destination address

2020-05-05 Thread Sanjay R Mehta
The DMA map and unmap of destination address is already being done in perf_init_test() and perf_clear_test() functions. Hence avoiding it by making necessary changes in perf_copy_chunk() function. Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath --- drivers/ntb/test/ntb_perf.c | 11

[PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

2020-05-05 Thread Sanjay R Mehta
: hw: remove the code that sets the DMA mask Sanjay R Mehta (4): ntb_perf: pass correct struct device to dma_alloc_coherent ntb_tool: pass correct struct device to dma_alloc_coherent ntb_perf: increase sleep time from one milli sec to one sec ntb_perf: avoid false dma unmap of destination

[PATCH v3 1/5] ntb: hw: remove the code that sets the DMA mask

2020-05-05 Thread Sanjay R Mehta
From: Logan Gunthorpe This patch removes the code that sets the DMA mask as it no longer makes sense to do this. Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Tested-by: Alexander Fomichev Signed-off-by: Sanjay R Mehta --

[PATCH v4 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource

2020-04-28 Thread Sanjay R Mehta
From: Sanjay R Mehta This registers the ptdma queue to Linux dmaengine framework as general-purpose DMA channels. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Kconfig | 2 + drivers/dma/ptdma/Makefile | 3 +- drivers/dma/ptdma/ptdma-dev.c | 35 +++ drivers

[PATCH v4 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information

2020-04-28 Thread Sanjay R Mehta
From: Sanjay R Mehta Expose data about the configuration and operation of the PTDMA through debugfs entries: device name, capabilities, configuration, statistics. Signed-off-by: Sanjay R Mehta --- drivers/dma/ptdma/Makefile| 3 +- drivers/dma/ptdma/ptdma-debugfs.c | 237

[PATCH v4 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-04-28 Thread Sanjay R Mehta
From: Sanjay R Mehta This driver add support for AMD PTDMA controller. This device performs high-bandwidth memory to memory and IO copy operation. Device commands are managed via a circular queue of 'descriptors', each of which specifies source and destination addresses for copyin

[PATCH v4 0/3] Add support for AMD PTDMA controller driver

2020-04-28 Thread Sanjay R Mehta
From: Sanjay R Mehta This patch series adds support for AMD PTDMA controller which performs high bandwidth memory-to-memory and IO copy operation and performs DMA transfer through queue based descriptor management. AMD Processor has multiple ptdma device instances and each controller has single

Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

2019-10-03 Thread Sanjay R Mehta
On 9/25/2019 12:42 AM, Vinod Koul wrote: > [CAUTION: External Email] > > On 24-09-19, 07:31, Mehta, Sanju wrote: >> From: Sanjay R Mehta >> >> This is the driver for the AMD passthrough DMA Engine > Please fix threading for your series, they are all over my inbox

Re: [PATCH 0/4] *** AMD PTDMA driver ***

2019-10-03 Thread Sanjay R Mehta
On 9/24/2019 10:07 PM, Vinod Koul wrote: > [CAUTION: External Email] > > On 24-09-19, 07:31, Mehta, Sanju wrote: >> From: Sanjay R Mehta >> >> *** This patch series adds support for AMD PTDMA engine *** > What lots of stars! > > Can you describe the controll

Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

2019-10-03 Thread Sanjay R Mehta
On 9/24/2019 8:05 PM, Randy Dunlap wrote: > [CAUTION: External Email] > > On 9/24/19 12:31 AM, Mehta, Sanju wrote: >> From: Sanjay R Mehta >> >> This is the driver for the AMD passthrough DMA Engine >> >> Signed-off-by: Sanjay R Mehta >> Reviewed

Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information

2019-09-25 Thread Sanjay R Mehta
On 9/24/2019 1:35 PM, gre...@linuxfoundation.org wrote: > [CAUTION: External Email] > > On Tue, Sep 24, 2019 at 07:33:02AM +, Mehta, Sanju wrote: >> +static const struct file_operations pt_debugfs_info_ops = { >> + .owner = THIS_MODULE, >> + .open = simple_open, >> + .read = ptdma_

Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information

2019-09-25 Thread Sanjay R Mehta
On 9/24/2019 1:35 PM, gre...@linuxfoundation.org wrote: > [CAUTION: External Email] > > On Tue, Sep 24, 2019 at 07:33:02AM +, Mehta, Sanju wrote: >> +static const struct file_operations pt_debugfs_info_ops = { >> + .owner = THIS_MODULE, >> + .open = simple_open, >> + .read = ptdma_

Re: [PATCH 1/4] NTB: ntb_perf: Increased the number of message retries to 1000

2019-05-20 Thread Sanjay R Mehta
On 3/20/2019 11:20 PM, Jon Mason wrote: > On Fri, Feb 15, 2019 at 09:20:07AM +, Mehta, Sanju wrote: >> From: Sanjay R Mehta >> >> while waiting for the peer ntb_perf to initialize scratchpad >> registers, local side ntb_perf might have already exhausted the &