Re: linux-next: manual merge of the omap tree with the keystone tree

2017-12-21 Thread Santosh Shilimkar
On 12/21/2017 3:12 PM, Tony Lindgren wrote: * Stephen Rothwell [171221 21:48]: Hi Tony, Today's linux-next merge of the omap tree got a conflict in: arch/arm/configs/multi_v7_defconfig between commit: d3b15c54ed7e ("ARM: config: sync multi-v7 config with keystone peripherals") from

Re: KASAN: stack-out-of-bounds Read in rds_sendmsg

2017-12-21 Thread Santosh Shilimkar
+Avinash On 12/21/2017 1:10 AM, syzbot wrote: syzkaller has found reproducer for the following crash on [..] audit: type=1400 audit(1513847224.110:7): avc:  denied  { map } for pid=3157 comm="syzkaller455006" path="/root/syzkaller455006870" dev="sda1" ino=16481

Re: KASAN: stack-out-of-bounds Read in rds_sendmsg

2017-12-21 Thread Santosh Shilimkar
+Avinash On 12/21/2017 1:10 AM, syzbot wrote: syzkaller has found reproducer for the following crash on [..] audit: type=1400 audit(1513847224.110:7): avc:  denied  { map } for pid=3157 comm="syzkaller455006" path="/root/syzkaller455006870" dev="sda1" ino=16481

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-18 Thread Santosh Shilimkar
On 12/16/2017 6:02 PM, Knut Omang wrote: On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: On 12/16/17 10:24 AM, Joe Perches wrote: [...] Most of these existing messages from checkpatch should probably be inspected and corrected where possible to minimize the style

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-18 Thread Santosh Shilimkar
On 12/16/2017 6:02 PM, Knut Omang wrote: On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: On 12/16/17 10:24 AM, Joe Perches wrote: [...] Most of these existing messages from checkpatch should probably be inspected and corrected where possible to minimize the style

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 9:12 AM, David Miller wrote: From: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Mon, 18 Dec 2017 08:28:05 -0800 On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 9:12 AM, David Miller wrote: From: Santosh Shilimkar Date: Mon, 18 Dec 2017 08:28:05 -0800 On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux

Re: BUG: spinlock bad magic (2)

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

Re: BUG: spinlock bad magic (2)

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

Re: [PATCH net] rds: Fix NULL pointer dereference in __rds_rdma_map

2017-12-06 Thread Santosh Shilimkar
Håkon Bugge <haakon.bu...@oracle.com> Reported-by: syzbot <syzkal...@googlegroups.com> --- Thanks Haakon for testing and posting out the discussed change out. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] rds: Fix NULL pointer dereference in __rds_rdma_map

2017-12-06 Thread Santosh Shilimkar
Håkon Bugge Reported-by: syzbot --- Thanks Haakon for testing and posting out the discussed change out. Acked-by: Santosh Shilimkar

Re: [PATCH] ARM: multi_v7_defconfig: Add configs for peripherals on Keystone2 SoCs

2017-12-05 Thread Santosh Shilimkar
On 12/5/2017 1:19 AM, Vignesh R wrote: Enable Cadence QSPI present on 66AK2G SoC and Keystone USB PHY driver for K2E. Signed-off-by: Vignesh R --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig

Re: [PATCH] ARM: multi_v7_defconfig: Add configs for peripherals on Keystone2 SoCs

2017-12-05 Thread Santosh Shilimkar
On 12/5/2017 1:19 AM, Vignesh R wrote: Enable Cadence QSPI present on 66AK2G SoC and Keystone USB PHY driver for K2E. Signed-off-by: Vignesh R --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig

Re: [PATCH 6/6] ARM: configs: keystone_defconfig: Enable few peripheral drivers

2017-12-04 Thread Santosh Shilimkar
On 12/4/2017 1:00 AM, Vignesh R wrote: Hi, On Sunday 03 December 2017 09:30 AM, santosh.shilim...@oracle.com wrote: On 11/22/17 11:51 PM, Vignesh R wrote: Enable drivers for QSPI, LEDS, gpio-decoder that are present on 66AK2G EVM and 66AK2G ICE boards. Signed-off-by: Vignesh R

Re: [PATCH 6/6] ARM: configs: keystone_defconfig: Enable few peripheral drivers

2017-12-04 Thread Santosh Shilimkar
On 12/4/2017 1:00 AM, Vignesh R wrote: Hi, On Sunday 03 December 2017 09:30 AM, santosh.shilim...@oracle.com wrote: On 11/22/17 11:51 PM, Vignesh R wrote: Enable drivers for QSPI, LEDS, gpio-decoder that are present on 66AK2G EVM and 66AK2G ICE boards. Signed-off-by: Vignesh R --- Please

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-04 Thread Santosh Shilimkar
On 12/3/2017 8:36 AM, Tony Lindgren wrote: * santosh.shilim...@oracle.com [171203 04:03]: On 11/30/17 2:56 PM, Dave Gerlach wrote: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-04 Thread Santosh Shilimkar
On 12/3/2017 8:36 AM, Tony Lindgren wrote: * santosh.shilim...@oracle.com [171203 04:03]: On 11/30/17 2:56 PM, Dave Gerlach wrote: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram and run from there during low

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-01 Thread Santosh Shilimkar
On 12/1/2017 9:54 AM, Tony Lindgren wrote: * Dave Gerlach [171130 22:58]: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram and run from there during low power mode entry. The patches still have

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-01 Thread Santosh Shilimkar
On 12/1/2017 9:54 AM, Tony Lindgren wrote: * Dave Gerlach [171130 22:58]: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram and run from there during low power mode entry. The patches still have the previous ACKs

Re: general protection fault in __rds_rdma_map

2017-11-27 Thread Santosh Shilimkar
On 11/27/2017 10:30 AM, syzbot wrote: Hello, syzkaller hit the following crash on e1d1ea549b57790a3d8cf6300e6ef86118d692a3 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. C

Re: general protection fault in __rds_rdma_map

2017-11-27 Thread Santosh Shilimkar
On 11/27/2017 10:30 AM, syzbot wrote: Hello, syzkaller hit the following crash on e1d1ea549b57790a3d8cf6300e6ef86118d692a3 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. C

Re: [PATCH] ARM: dts: keystone-k2l: Add the second gpio bank node

2017-11-13 Thread Santosh Shilimkar
On 11/9/2017 3:42 AM, Keerthy wrote: In case of k2l there are 2 more banks with 16 pins each. Adding the node as the da-vinci driver now supports multiple banks. Signed-off-by: Keerthy --- This is based on linux-next branch. Boot tested on keystone-k2l-evm. Will pick this

Re: [PATCH] ARM: dts: keystone-k2l: Add the second gpio bank node

2017-11-13 Thread Santosh Shilimkar
On 11/9/2017 3:42 AM, Keerthy wrote: In case of k2l there are 2 more banks with 16 pins each. Adding the node as the da-vinci driver now supports multiple banks. Signed-off-by: Keerthy --- This is based on linux-next branch. Boot tested on keystone-k2l-evm. Will pick this up Keerthy !!

Re: [PATCH v5 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-11-13 Thread Santosh Shilimkar
On 11/10/2017 8:39 AM, Russell King - ARM Linux wrote: On Mon, Oct 16, 2017 at 08:31:59AM -0700, Santosh Shilimkar wrote: Hi Russell, On 10/13/2017 1:59 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend

Re: [PATCH v5 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-11-13 Thread Santosh Shilimkar
On 11/10/2017 8:39 AM, Russell King - ARM Linux wrote: On Mon, Oct 16, 2017 at 08:31:59AM -0700, Santosh Shilimkar wrote: Hi Russell, On 10/13/2017 1:59 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend

Re: [PATCH net] rds: ib: Fix NULL pointer dereference in debug code

2017-11-07 Thread Santosh Shilimkar
f-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Wei Lin Guay <wei.lin.g...@oracle.com> --- net/rds/ib_recv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] rds: ib: Fix NULL pointer dereference in debug code

2017-11-07 Thread Santosh Shilimkar
on Bugge Reviewed-by: Knut Omang Reviewed-by: Wei Lin Guay --- net/rds/ib_recv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Acked-by: Santosh Shilimkar

Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs

2017-10-24 Thread Santosh Shilimkar
On 10/24/2017 9:15 AM, Håkon Bugge wrote: On 24 Oct 2017, at 18:05, Santosh Shilimkar <santosh.shilim...@oracle.com <mailto:santosh.shilim...@oracle.com>> wrote: [...] Instead of partially doing changes inside/outside helper, can also add inline helper for solicite

Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs

2017-10-24 Thread Santosh Shilimkar
On 10/24/2017 9:15 AM, Håkon Bugge wrote: On 24 Oct 2017, at 18:05, Santosh Shilimkar mailto:santosh.shilim...@oracle.com>> wrote: [...] Instead of partially doing changes inside/outside helper, can also add inline helper for solicited state like rds_ib_set_wr_solicited_state() a

Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs

2017-10-24 Thread Santosh Shilimkar
On 10/24/2017 7:16 AM, Håkon Bugge wrote: The number of unsignaled work-requests posted to the IB send queue is tracked by a counter in the rds_ib_connection struct. When it reaches zero, or the caller explicitly asks for it, the send-signaled bit is set in send_flags and the counter is reset.

Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs

2017-10-24 Thread Santosh Shilimkar
On 10/24/2017 7:16 AM, Håkon Bugge wrote: The number of unsignaled work-requests posted to the IB send queue is tracked by a counter in the rds_ib_connection struct. When it reaches zero, or the caller explicitly asks for it, the send-signaled bit is set in send_flags and the counter is reset.

Re: [PATCH] rds: Fix uninitialized variable

2017-10-24 Thread Santosh Shilimkar
$subject s/rds:/rds: ib: On 10/24/2017 8:02 AM, Håkon Bugge wrote: send_flags needs to be initialized before calling rds_ib_set_wr_signal_state(). Signed-off-by: Håkon Bugge <haakon.bu...@oracle.com> --- Looks fine otherwise. Please re-post with subject fixed. Acked-by: Santosh Shi

Re: [PATCH] rds: Fix uninitialized variable

2017-10-24 Thread Santosh Shilimkar
$subject s/rds:/rds: ib: On 10/24/2017 8:02 AM, Håkon Bugge wrote: send_flags needs to be initialized before calling rds_ib_set_wr_signal_state(). Signed-off-by: Håkon Bugge --- Looks fine otherwise. Please re-post with subject fixed. Acked-by: Santosh Shilimkar

Re: [PATCH v5 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-10-16 Thread Santosh Shilimkar
Hi Russell, On 10/13/2017 1:59 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory into self-refresh. One requirement

Re: [PATCH v5 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-10-16 Thread Santosh Shilimkar
Hi Russell, On 10/13/2017 1:59 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory into self-refresh. One requirement

Re: [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes

2017-10-03 Thread Santosh Shilimkar
.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) This patch is fine but it will be nice if you can collect these changes in series as you are trying to update the FRWR support. Like this patch and other cleanup patch you posted yesterday. With that log fixed, Acked-by: Santosh Shi

Re: [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes

2017-10-03 Thread Santosh Shilimkar
insertions(+), 2 deletions(-) This patch is fine but it will be nice if you can collect these changes in series as you are trying to update the FRWR support. Like this patch and other cleanup patch you posted yesterday. With that log fixed, Acked-by: Santosh Shilimkar

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread Santosh Shilimkar
Hi Dave, On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller <da...@davemloft.net> [...] Actually, reverted, this breaks the build. net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory   #include

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread Santosh Shilimkar
Hi Dave, On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller [...] Actually, reverted, this breaks the build. net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory   #include "ib.h" Although I

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-03 Thread Santosh Shilimkar
On 10/3/2017 9:52 AM, Grygorii Strashko wrote: Hi Santosh, On 10/03/2017 11:41 AM, Santosh Shilimkar wrote: [...] This was one of the concern I was thinking when GPIO IRQ conversion was done. Grygorii since you did that conversion, can you please check since I see now that the irq code

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-03 Thread Santosh Shilimkar
On 10/3/2017 9:52 AM, Grygorii Strashko wrote: Hi Santosh, On 10/03/2017 11:41 AM, Santosh Shilimkar wrote: [...] This was one of the concern I was thinking when GPIO IRQ conversion was done. Grygorii since you did that conversion, can you please check since I see now that the irq code

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-03 Thread Santosh Shilimkar
On 10/3/2017 9:17 AM, Grygorii Strashko wrote: Now acking of edge irqs happens the following way: - omap_gpio_irq_handler - "isr" = read irq status - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask); ^ clear edge status, so irq can be accepted - loop while "isr"

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-03 Thread Santosh Shilimkar
On 10/3/2017 9:17 AM, Grygorii Strashko wrote: Now acking of edge irqs happens the following way: - omap_gpio_irq_handler - "isr" = read irq status - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask); ^ clear edge status, so irq can be accepted - loop while "isr"

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-02 Thread Santosh Shilimkar
On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT) From: Avinash Repaka Date: Fri, 29 Sep 2017 18:13:50 -0700 This patch fixes the scope of has_fr and has_fmr variables as they are needed

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-02 Thread Santosh Shilimkar
On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT) From: Avinash Repaka Date: Fri, 29 Sep 2017 18:13:50 -0700 This patch fixes the scope of has_fr and has_fmr variables as they are needed only in rds_ib_add_one(). Signed-off-by:

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-09-29 Thread Santosh Shilimkar
looks good to me. Thanks !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-09-29 Thread Santosh Shilimkar
!! Acked-by: Santosh Shilimkar

Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init

2017-09-18 Thread Santosh Shilimkar
. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Acked-by: Santosh Shilimkar <ssant...@kernel.org>

Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init

2017-09-18 Thread Santosh Shilimkar
. Signed-off-by: Arnd Bergmann --- Acked-by: Santosh Shilimkar

Re: [PATCH 04/14] ti_sci: Use %pS printk format for direct addresses

2017-09-08 Thread Santosh Shilimkar
it for consistency across the kernel. Signed-off-by: Helge Deller <del...@gmx.de> Cc: Nishanth Menon <n...@ti.com> Cc: Tero Kristo <t-kri...@ti.com> Cc: Santosh Shilimkar <ssant...@kernel.org> Cc: linux-arm-ker...@lists.infradead.org OK with me. Thanks for doing the p

Re: [PATCH 04/14] ti_sci: Use %pS printk format for direct addresses

2017-09-08 Thread Santosh Shilimkar
it for consistency across the kernel. Signed-off-by: Helge Deller Cc: Nishanth Menon Cc: Tero Kristo Cc: Santosh Shilimkar Cc: linux-arm-ker...@lists.infradead.org OK with me. Thanks for doing the patch. Acked-by: Nishanth Menon Santosh, Tero: maybe queue for an rc or later cycle, I think

Re: [PATCH net v2] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
pdate. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net v2] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
not count this event correctly. This commit counts the race condition correctly. Changes from v1: - Removed check for *someone_on_xmit()* - Fixed incorrect indentation Signed-off-by: Håkon Bugge Reviewed-by: Knut Omang --- Thanks for the update. Acked-by: Santosh Shilimkar

Re: [PATCH net] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
On 9/6/2017 9:12 AM, Håkon Bugge wrote: [...] Hi Santosh, Yes, I agree with accuracy of s_send_lock_queue_raced. But the main point is that the existing code counts some partial share of when it is _not_ raced. So, in the critical path, my patch adds one test_bit(), which hits the local

Re: [PATCH net] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
On 9/6/2017 9:12 AM, Håkon Bugge wrote: [...] Hi Santosh, Yes, I agree with accuracy of s_send_lock_queue_raced. But the main point is that the existing code counts some partial share of when it is _not_ raced. So, in the critical path, my patch adds one test_bit(), which hits the local

Re: [PATCH net] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
On 9/6/2017 8:29 AM, Håkon Bugge wrote: In rds_send_xmit() there is logic to batch the sends. However, if another thread has acquired the lock, it is considered a race and we yield. The code incrementing the s_send_lock_queue_raced statistics counter did not count this event correctly. This

Re: [PATCH net] rds: Fix incorrect statistics counting

2017-09-06 Thread Santosh Shilimkar
On 9/6/2017 8:29 AM, Håkon Bugge wrote: In rds_send_xmit() there is logic to batch the sends. However, if another thread has acquired the lock, it is considered a race and we yield. The code incrementing the s_send_lock_queue_raced statistics counter did not count this event correctly. This

Re: [PATCH net] rds: Fix non-atomic operation on shared flag variable

2017-09-05 Thread Santosh Shilimkar
SG_ACK_REQUIRED, >m_flags); list_add_tail(>m_sock_item, >rs_send_queue); set_bit(RDS_MSG_ON_SOCK, >m_flags); Indeed, these couple of instances remained for the m_flags. Patch looks good. Thanks !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] rds: Fix non-atomic operation on shared flag variable

2017-09-05 Thread Santosh Shilimkar
set_bit(RDS_MSG_ON_SOCK, >m_flags); Indeed, these couple of instances remained for the m_flags. Patch looks good. Thanks !! Acked-by: Santosh Shilimkar

Re: [PATCH 5/7] RDS: make rhashtable_params const

2017-08-25 Thread Santosh Shilimkar
8/25/2017 7:21 AM, Bhumika Goyal wrote: Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 5/7] RDS: make rhashtable_params const

2017-08-25 Thread Santosh Shilimkar
8/25/2017 7:21 AM, Bhumika Goyal wrote: Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init Signed-off-by: Bhumika Goyal --- Acked-by: Santosh Shilimkar

Re: [PATCH net] rds: Reintroduce statistics counting

2017-08-08 Thread Santosh Shilimkar
from_cq. Signed-off-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Wei Lin Guay <wei.lin.g...@oracle.com> --- Looks fine. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] rds: Reintroduce statistics counting

2017-08-08 Thread Santosh Shilimkar
from_cq. Signed-off-by: Håkon Bugge Reviewed-by: Knut Omang Reviewed-by: Wei Lin Guay --- Looks fine. Acked-by: Santosh Shilimkar

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

2017-08-04 Thread Santosh Shilimkar
Hi Franklin, On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: Add D CAN nodes to 66AK2G based SoC dtsi. Franklin S Cooper Jr (2): dt-bindings: net: c_can: Update binding for clock and power-domains property ARM: configs: keystone: Enable D_CAN driver Lokesh Vutla (1): ARM: dts:

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

2017-08-04 Thread Santosh Shilimkar
Hi Franklin, On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: Add D CAN nodes to 66AK2G based SoC dtsi. Franklin S Cooper Jr (2): dt-bindings: net: c_can: Update binding for clock and power-domains property ARM: configs: keystone: Enable D_CAN driver Lokesh Vutla (1): ARM: dts:

Re: [PATCH 0/7] K2G: Add QSPI support

2017-08-02 Thread Santosh Shilimkar
8/1/2017 10:52 PM, Vignesh R wrote: Hi, On Tuesday 01 August 2017 11:31 PM, Santosh Shilimkar wrote: On 7/31/2017 9:54 PM, Vignesh R wrote: This series adds support for Cadence QSPI for 66AK2G SoC. The first three patches enhance the cadence-quadspi driver to support loopback clock

Re: [PATCH 0/7] K2G: Add QSPI support

2017-08-02 Thread Santosh Shilimkar
8/1/2017 10:52 PM, Vignesh R wrote: Hi, On Tuesday 01 August 2017 11:31 PM, Santosh Shilimkar wrote: On 7/31/2017 9:54 PM, Vignesh R wrote: This series adds support for Cadence QSPI for 66AK2G SoC. The first three patches enhance the cadence-quadspi driver to support loopback clock

Re: [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC

2017-08-01 Thread Santosh Shilimkar
On 7/31/2017 9:41 PM, Lokesh Vutla wrote: This series adds DT nodes and documentation for eDMA and MMC IPs on Keystone 66AK2G SoC. Also enable the required configs in keystone_defconfig. This series depends on Keerthy's gpio node patches on 66AK2G: Am waiting for Keerthy to send refresh

Re: [PATCH 0/6] ARM: dts: keystone-k2g: Add support for eDMA and MMC

2017-08-01 Thread Santosh Shilimkar
On 7/31/2017 9:41 PM, Lokesh Vutla wrote: This series adds DT nodes and documentation for eDMA and MMC IPs on Keystone 66AK2G SoC. Also enable the required configs in keystone_defconfig. This series depends on Keerthy's gpio node patches on 66AK2G: Am waiting for Keerthy to send refresh

Re: [PATCH v3 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-08-01 Thread Santosh Shilimkar
On 7/26/2017 9:54 AM, Santosh Shilimkar wrote: On 7/24/2017 2:24 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory

Re: [PATCH v3 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-08-01 Thread Santosh Shilimkar
On 7/26/2017 9:54 AM, Santosh Shilimkar wrote: On 7/24/2017 2:24 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory

Re: [PATCH 0/7] K2G: Add QSPI support

2017-08-01 Thread Santosh Shilimkar
On 7/31/2017 9:54 PM, Vignesh R wrote: This series adds support for Cadence QSPI for 66AK2G SoC. The first three patches enhance the cadence-quadspi driver to support loopback clock and pm_runtime and tweaks for 66AK2G SoC. Remaining patches add DT nodes and enable the driver in defconfig.

Re: [PATCH 0/7] K2G: Add QSPI support

2017-08-01 Thread Santosh Shilimkar
On 7/31/2017 9:54 PM, Vignesh R wrote: This series adds support for Cadence QSPI for 66AK2G SoC. The first three patches enhance the cadence-quadspi driver to support loopback clock and pm_runtime and tweaks for 66AK2G SoC. Remaining patches add DT nodes and enable the driver in defconfig.

Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

2017-07-31 Thread Santosh Shilimkar
On 7/30/2017 9:31 PM, Keerthy wrote: knav_pool_create is an exported function. In the event of a call before knav_queue_probe, we encounter a NULL pointer dereference in the following line. Hence return -EPROBE_DEFER to the caller till the kdev pointer is non-NULL. Signed-off-by: Keerthy

Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

2017-07-31 Thread Santosh Shilimkar
On 7/30/2017 9:31 PM, Keerthy wrote: knav_pool_create is an exported function. In the event of a call before knav_queue_probe, we encounter a NULL pointer dereference in the following line. Hence return -EPROBE_DEFER to the caller till the kdev pointer is non-NULL. Signed-off-by: Keerthy ---

Re: [PATCH v3 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-26 Thread Santosh Shilimkar
On 7/24/2017 2:24 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory into self-refresh. One requirement for these

Re: [PATCH v3 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-26 Thread Santosh Shilimkar
On 7/24/2017 2:24 PM, Dave Gerlach wrote: Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory into self-refresh. One requirement for these

Re: [PATCH 0/3] Keystone defconfig updates

2017-07-21 Thread Santosh Shilimkar
On 7/17/2017 9:45 PM, santosh.shilim...@oracle.com wrote: On 7/17/17 8:26 PM, Suman Anna wrote: Hi Santosh, The following patch series adds the necessary defconfig options to keystone_defconfig to enable the TI-SCI protocol and their respective genpd/clock/reset drivers. This is the first

Re: [PATCH 0/3] Keystone defconfig updates

2017-07-21 Thread Santosh Shilimkar
On 7/17/2017 9:45 PM, santosh.shilim...@oracle.com wrote: On 7/17/17 8:26 PM, Suman Anna wrote: Hi Santosh, The following patch series adds the necessary defconfig options to keystone_defconfig to enable the TI-SCI protocol and their respective genpd/clock/reset drivers. This is the first

Re: [PATCH v2] dt-bindings: Drop k2g genpd device ID macros

2017-07-20 Thread Santosh Shilimkar
On 7/20/2017 11:04 AM, Dave Gerlach wrote: Commit 7cc119f29b19 ("dt-bindings: Add TI SCI PM Domains") introduced a number of K2G_DEV_x macros to represent each device ID available on the K2G platform for use by the genpd, clock, and reset drivers. Rather than use these macros, which are only

Re: [PATCH v2] dt-bindings: Drop k2g genpd device ID macros

2017-07-20 Thread Santosh Shilimkar
On 7/20/2017 11:04 AM, Dave Gerlach wrote: Commit 7cc119f29b19 ("dt-bindings: Add TI SCI PM Domains") introduced a number of K2G_DEV_x macros to represent each device ID available on the K2G platform for use by the genpd, clock, and reset drivers. Rather than use these macros, which are only

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Santosh Shilimkar
with me. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Santosh Shilimkar
NCE(), and ACCESS_ONCE(). Clause 5.1.2.4/25 in the C standard is also relevant. Signed-off-by: Håkon Bugge Reviewed-by: Knut Omang --- Having said that, {READ,WRITE}_ONCE usages seems to make it clear and explicit. So its fine with me. Acked-by: Santosh Shilimkar

Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers

2017-07-17 Thread Santosh Shilimkar
On 7/17/2017 10:04 AM, Rob Herring wrote: On Tue, Jul 11, 2017 at 06:09:23PM -0700, Stephen Boyd wrote: On 07/11, Suman Anna wrote: The clock consumer usage description was erroneously referring to couple of dt-binding headers that are no longer valid. The definition and/or usage of these

Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers

2017-07-17 Thread Santosh Shilimkar
On 7/17/2017 10:04 AM, Rob Herring wrote: On Tue, Jul 11, 2017 at 06:09:23PM -0700, Stephen Boyd wrote: On 07/11, Suman Anna wrote: The clock consumer usage description was erroneously referring to couple of dt-binding headers that are no longer valid. The definition and/or usage of these

Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

2017-06-13 Thread Santosh Shilimkar
On 6/13/2017 1:16 PM, Dave Gerlach wrote: Santosh, On 05/31/2017 11:28 AM, Rob Herring wrote: On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote: [...] [1] https://www.spinics.net/lists/arm-kernel/msg577079.html .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +-

Re: [PATCH] dt-bindings: Drop k2g genpd device ID macros

2017-06-13 Thread Santosh Shilimkar
On 6/13/2017 1:16 PM, Dave Gerlach wrote: Santosh, On 05/31/2017 11:28 AM, Rob Herring wrote: On Mon, May 22, 2017 at 01:37:37PM -0500, Dave Gerlach wrote: [...] [1] https://www.spinics.net/lists/arm-kernel/msg577079.html .../devicetree/bindings/soc/ti/sci-pm-domain.txt | 5 +-

Re: [PATCH v2 1/3] dt-bindings: remoteproc: Add Keystone DSP remoteproc binding

2017-06-10 Thread Santosh Shilimkar
ped unstable binding status - Dropped the 'label' property and replaced the device node description to use an alias - Renamed 'kick-gpio' to 'kick-gpios' - Updated the example Looks reasonable to me. Ofcourse you need Rob's ack for this one. Acked-by: Santosh Shilimkar <ssant...@kernel.org>

Re: [PATCH v2 1/3] dt-bindings: remoteproc: Add Keystone DSP remoteproc binding

2017-06-10 Thread Santosh Shilimkar
the 'label' property and replaced the device node description to use an alias - Renamed 'kick-gpio' to 'kick-gpios' - Updated the example Looks reasonable to me. Ofcourse you need Rob's ack for this one. Acked-by: Santosh Shilimkar

Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe

2017-06-10 Thread Santosh Shilimkar
e the DSP resets are asserted, and if not, throw a eye-catchy warning and assert the resets specifically. Signed-off-by: Andrew F. Davis <a...@ti.com> [s-a...@ti.com: replace warning with a WARN] Signed-off-by: Suman Anna <s-a...@ti.com> --- Acked-by: Santosh Shilimkar <ssant...@kernel.org>

Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe

2017-06-10 Thread Santosh Shilimkar
e asserted, and if not, throw a eye-catchy warning and assert the resets specifically. Signed-off-by: Andrew F. Davis [s-a...@ti.com: replace warning with a WARN] Signed-off-by: Suman Anna --- Acked-by: Santosh Shilimkar

Re: [PATCH v2 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs

2017-06-10 Thread Santosh Shilimkar
s. Signed-off-by: Suman Anna <s-a...@ti.com> Signed-off-by: Sam Nelson <sam.nel...@ti.com> Signed-off-by: Andrew F. Davis <a...@ti.com> --- Acked-by: Santosh Shilimkar <ssant...@kernel.org>

Re: [PATCH v2 2/3] remoteproc/keystone: Add a remoteproc driver for Keystone 2 DSPs

2017-06-10 Thread Santosh Shilimkar
s. Signed-off-by: Suman Anna Signed-off-by: Sam Nelson Signed-off-by: Andrew F. Davis --- Acked-by: Santosh Shilimkar

Re: [PATCH 1/3] RDS: IB: Delete an error message for a failed memory allocation in rds_ib_add_one()

2017-05-22 Thread Santosh Shilimkar
(!rds_ibdev->vector_load) goto put_dev; - } Well the ENOMEM is not carried here so the message was usefu but its not critical so its fine to clean that up. Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 1/3] RDS: IB: Delete an error message for a failed memory allocation in rds_ib_add_one()

2017-05-22 Thread Santosh Shilimkar
Well the ENOMEM is not carried here so the message was usefu but its not critical so its fine to clean that up. Acked-by: Santosh Shilimkar

Re: [PATCH 2/3] RDS: IB: Improve a size determination in rds_ib_add_one()

2017-05-22 Thread Santosh Shilimkar
rresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 2/3] RDS: IB: Improve a size determination in rds_ib_add_one()

2017-05-22 Thread Santosh Shilimkar
according to the Linux coding style convention. Signed-off-by: Markus Elfring --- Acked-by: Santosh Shilimkar

Re: [PATCH v2 0/4] ARM: dts: keystone: Add support for new K2G evm

2017-05-10 Thread Santosh Shilimkar
On 4/24/2017 1:22 PM, Franklin S Cooper Jr wrote: This patchset adds support for new K2G Industrial Communication Engine evm. For now only a bare minimal dts which will allow ram boot. Additional peripherals will be added when base K2G SoC patches are upstreamed allowing peripherals to be

<    1   2   3   4   5   6   7   8   9   10   >