Re: [PATCH 1/6] cpuset write dirty map

2007-09-14 Thread Satyam Sharma
On 9/15/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 15 Sep 2007 05:17:48 +0530 > "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > > > > It's unobvious why the break point is at MAX_NUMNODES = BITS_PER_LONG and > > > we might want t

Re: [PATCH 1/6] cpuset write dirty map

2007-09-14 Thread Satyam Sharma
On 9/15/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 11 Sep 2007 18:36:34 -0700 > Ethan Solomita <[EMAIL PROTECTED]> wrote: > > The dirty map may be stored either directly in the mapping (for NUMA > > systems with less then BITS_PER_LONG nodes) or separately allocated > > for systems

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Satyam Sharma
in kernel.h, but > > pr_err() was defined > > multiple times in several other places > > > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> I think it's a useful cleanup, patch looks good to me ... Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]> [ Original diff i

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
On 9/14/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > [snip] Ick, threading breaks in Gmail with Subject: changes, so I missed the latest updates on this thread ... oh well, never mind. Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
[ Argh, just noticed this thread got broke and had been living a parallel life due to Subject: changes, dropped Cc:'s, and munged In-Reply-To:'s. Adding back all interested folk here. ] > Hi Antoine, Ingo, > > > On 9/14/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > * Ingo Molnar <[EMAIL

Re: [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202

2007-09-14 Thread Satyam Sharma
Hi Kamalesh, There's two things at work here ... On 9/14/07, Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi, > > With 2.6.23-rc6 running on the ppc64 box, following oops is hit > > Oops: Machine check, sig: 7 [#1] > > SMP NR_CPUS=128 pSeries > > Modules linked in: binfmt_misc ipv6 dm_mod

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
Hi Antoine, Ingo, On 9/14/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > hm, could you try the patch below ontop of 2.6.23-rc6 and do: > > > > echo 1 > /proc/sys/kernel/sched_yield_bug_workaround > > > > does this improve the numbers? Hmm, I know

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
Hi Antoine, Ingo, On 9/14/07, Ingo Molnar [EMAIL PROTECTED] wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: hm, could you try the patch below ontop of 2.6.23-rc6 and do: echo 1 /proc/sys/kernel/sched_yield_bug_workaround does this improve the numbers? Hmm, I know diddly about Java,

Re: [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202

2007-09-14 Thread Satyam Sharma
Hi Kamalesh, There's two things at work here ... On 9/14/07, Kamalesh Babulal [EMAIL PROTECTED] wrote: Hi, With 2.6.23-rc6 running on the ppc64 box, following oops is hit Oops: Machine check, sig: 7 [#1] SMP NR_CPUS=128 pSeries Modules linked in: binfmt_misc ipv6 dm_mod ehci_hcd

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
On 9/14/07, Satyam Sharma [EMAIL PROTECTED] wrote: [snip] Ick, threading breaks in Gmail with Subject: changes, so I missed the latest updates on this thread ... oh well, never mind. Satyam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: CFS: some bad numbers with Java/database threading

2007-09-14 Thread Satyam Sharma
[ Argh, just noticed this thread got broke and had been living a parallel life due to Subject: changes, dropped Cc:'s, and munged In-Reply-To:'s. Adding back all interested folk here. ] Hi Antoine, Ingo, On 9/14/07, Ingo Molnar [EMAIL PROTECTED] wrote: * Ingo Molnar [EMAIL PROTECTED]

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Satyam Sharma
Signed-off-by: Emil Medve [EMAIL PROTECTED] I think it's a useful cleanup, patch looks good to me ... Reviewed-by: Satyam Sharma [EMAIL PROTECTED] [ Original diff is at: http://lkml.org/lkml/diff/2007/9/12/182/1 ] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 1/6] cpuset write dirty map

2007-09-14 Thread Satyam Sharma
On 9/15/07, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 11 Sep 2007 18:36:34 -0700 Ethan Solomita [EMAIL PROTECTED] wrote: The dirty map may be stored either directly in the mapping (for NUMA systems with less then BITS_PER_LONG nodes) or separately allocated for systems with a large

Re: [PATCH 1/6] cpuset write dirty map

2007-09-14 Thread Satyam Sharma
On 9/15/07, Andrew Morton [EMAIL PROTECTED] wrote: On Sat, 15 Sep 2007 05:17:48 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: It's unobvious why the break point is at MAX_NUMNODES = BITS_PER_LONG and we might want to tweak that in the future. Yet another argument for centralising

Re: [2.6 patch] always visit drivers/usb/misc/

2007-09-11 Thread Satyam Sharma
ems. > > <-- snip --> > > Currently, every driver under drivers/usb/misc/ also has to be listed in > drivers/usb/Makefile. This has been forgotten more than once, and this > patch changes drivers/usb/Makefile to simply always visit > drivers/usb/misc/ when bui

Re: [2.6 patch] always visit drivers/usb/misc/

2007-09-11 Thread Satyam Sharma
visit drivers/usb/misc/ when building the USB code. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Makes sense, I like the patch ... Acked-by: Satyam Sharma [EMAIL PROTECTED] --- drivers/usb/Makefile | 22 +- 1 file changed, 1 insertion(+), 21 deletions

Re: 2.6.23-rc4-mm1 build issue: ia64 link error

2007-09-08 Thread Satyam Sharma
On 9/8/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > On 9/7/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Fri, 7 Sep 2007 00:34:59 -0700 "Luck, Tony" <[EMAIL PROTECTED]> wrote: > > > > local symbol 0: discarded in section `.

Re: 2.6.23-rc4-mm1 build issue: ia64 link error

2007-09-08 Thread Satyam Sharma
_cpu_callback() referenced the .exit.text-resident remove_palinfo_proc_entries(), thereby causing link error. So this is the second goof-up in that "misc cpuinit/exit annotations" series of mine, apologies. I've installed the ia64 cross-compile toolchain now, so hopefully should be able to

Re: 2.6.23-rc4-mm1 build issue: ia64 link error

2007-09-08 Thread Satyam Sharma
in that misc cpuinit/exit annotations series of mine, apologies. I've installed the ia64 cross-compile toolchain now, so hopefully should be able to avoid such in future ... Patch attached (have gmail access only for next few days). Satyam Signed-off-by: Satyam Sharma [EMAIL PROTECTED] --- arch/ia64

Re: 2.6.23-rc4-mm1 build issue: ia64 link error

2007-09-08 Thread Satyam Sharma
On 9/8/07, Satyam Sharma [EMAIL PROTECTED] wrote: On 9/7/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 7 Sep 2007 00:34:59 -0700 Luck, Tony [EMAIL PROTECTED] wrote: local symbol 0: discarded in section `.exit.text' from arch/ia64/kernel/built-in.o This usually means

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, Johannes Berg wrote: > On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote: > > On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote: > > > > > > > > [ 382.529041] [] dev_close+0x24/0x67 > > > > > [

Re: WARNING native_smp_call_function mask 2.6.22.6 SMP on Single CPU System

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, Michael Stiller wrote: > Hi, > > i get the following warning if i call vfree some memory allocated by > vmalloc on a single cpu machine running 2.6.22.6 SMP: > > WARNING: at arch/i386/kernel/smp.c:559 native_smp_call_function_mask() > []

Re: [2/2] 2.6.23-rc5: known regressions with patches

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, David Woodhouse wrote: > > This isn't really a regression -- it's been like this for years. It's a > non-functional configuration which doesn't really make sense, and would > only crop up with randconfig (or crack). > > Linus was offered the patch a few weeks ago, but

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-06 Thread Satyam Sharma
On Tue, 4 Sep 2007, Mark Hindley wrote: > On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote: > > Hi Steffen, > > > > > > On Tue, 4 Sep 2007, Steffen Klassert wrote: > > > > > On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma w

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, Herbert Xu wrote: > On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote: > > > > > > [ 382.529041] [] dev_close+0x24/0x67 > > > > [ 382.529052] [] ieee80211_master_stop+0x4a/0x6d [mac80211] > > This is where the

Re: NFS4 authentification / fsuid

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, Satyam Sharma wrote: > > On Thu, 30 Aug 2007, J. Bruce Fields wrote: > > > On Thu, Aug 30, 2007 at 11:04:00AM -0400, Trond Myklebust wrote: > > > > > What I'm saying is that the superuser can pretty much do whatever it > > > takes to

Re: NFS4 authentification / fsuid

2007-09-06 Thread Satyam Sharma
On Thu, 30 Aug 2007, J. Bruce Fields wrote: > On Thu, Aug 30, 2007 at 11:04:00AM -0400, Trond Myklebust wrote: > > With CIFS or other password based protocols (including RPCSEC_GSS) > > Well, rpcsec_gss isn't inherently password based, and you can > authenticate in some way that doesn't

[PATCH] sched: Use show_regs() to improve __schedule_bug() output

2007-09-06 Thread Satyam Sharma
scheduling while atomic:" header a bit to keep task->comm and task->pid together and preempt_count() after them. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- kernel/sched.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/kernel/sche

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-06 Thread Satyam Sharma
On Tue, 4 Sep 2007, Mark Hindley wrote: On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote: Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In function 'vortex_up

Re: [2/2] 2.6.23-rc5: known regressions with patches

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, David Woodhouse wrote: This isn't really a regression -- it's been like this for years. It's a non-functional configuration which doesn't really make sense, and would only crop up with randconfig (or crack). Linus was offered the patch a few weeks ago, but didn't take

Re: WARNING native_smp_call_function mask 2.6.22.6 SMP on Single CPU System

2007-09-06 Thread Satyam Sharma
On Thu, 6 Sep 2007, Michael Stiller wrote: Hi, i get the following warning if i call vfree some memory allocated by vmalloc on a single cpu machine running 2.6.22.6 SMP: WARNING: at arch/i386/kernel/smp.c:559 native_smp_call_function_mask() [c010e77c]

Re: [BUG] 2.6.23-rc5 panics

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Roland Dreier wrote: > FWIW, I was running 2.6.23-rc5 on my laptop (along with iwlwifi-0.1.14 > for wireless) and I saw the same symptom: panic (blinking capslock) > while in X. I saw one panic out of maybe 12 hours of uptime over a > few reboots. The same system is quite

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-05 Thread Satyam Sharma
Hi, > On 02/09/07, Florian Lohoff <[EMAIL PROTECTED]> wrote: > > > > Hi, > > with current git i got this when "ifconfig eth1" down. eth1 had a mac > > address which looked really like an eth1394 ethernet although the module > > was not loaded. Something is really broken in 2.6.23-currentgit. I

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Dale Farnsworth wrote: > On Wed, Sep 05, 2007 at 08:24:52AM -0700, Andrew Morton wrote: > > > On Mon, 20 Aug 2007 14:38:57 +0800 gshan <[EMAIL PROTECTED]> wrote: > > > Hi All, > > > > > > After I started the NFS server, it crashed: > > > > > > <3>Badness in local_bh_enable

Re: 2.4.35.1 and panic at boot with arch=c3 and gcc-4.x

2007-09-05 Thread Satyam Sharma
On Thu, 6 Sep 2007, Willy Tarreau wrote: > > I finally tracked the problem down to a dirty trick used to prevent > do_test_wp_bit() from being inlined (Axel, you identified the right > file). Unfortunately, this trick does not work anymore when gcc-4.x > is used without -fno-unit-at-a-time, so

Re: Hang in 2.6.23-rc5

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Jean Delvare wrote: > > On Mon, Sep 03, 2007 at 04:15:01AM +0530, Satyam Sharma wrote: > > > That's my impression as well. That's way too core/busy a codepath to have > > > a bug in. As I said earlier, almost anybody testing -rc5 is sure to hit >

Re: Kernel 2.6.22.6 iPod conflict with PS/2 device.

2007-09-05 Thread Satyam Sharma
On Fri, 31 Aug 2007, Justin Piszcz wrote: > When I have an iPod attached via USB to an ABIT IC7-G board before it boots up > and let X start etc, the mouse (PS/2) does not function, but the keyboard > works OK. > > GPM does not work either. > > When I attach the iPod after the machine has

Re: Kernel 2.6.22.6 iPod conflict with PS/2 device.

2007-09-05 Thread Satyam Sharma
On Fri, 31 Aug 2007, Justin Piszcz wrote: When I have an iPod attached via USB to an ABIT IC7-G board before it boots up and let X start etc, the mouse (PS/2) does not function, but the keyboard works OK. GPM does not work either. When I attach the iPod after the machine has booted up,

Re: Hang in 2.6.23-rc5

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Jean Delvare wrote: On Mon, Sep 03, 2007 at 04:15:01AM +0530, Satyam Sharma wrote: That's my impression as well. That's way too core/busy a codepath to have a bug in. As I said earlier, almost anybody testing -rc5 is sure to hit this within a few hours (probably

Re: 2.4.35.1 and panic at boot with arch=c3 and gcc-4.x

2007-09-05 Thread Satyam Sharma
On Thu, 6 Sep 2007, Willy Tarreau wrote: I finally tracked the problem down to a dirty trick used to prevent do_test_wp_bit() from being inlined (Axel, you identified the right file). Unfortunately, this trick does not work anymore when gcc-4.x is used without -fno-unit-at-a-time, so let's

Re: kernel crashes inside MV643xx driver

2007-09-05 Thread Satyam Sharma
On Wed, 5 Sep 2007, Dale Farnsworth wrote: On Wed, Sep 05, 2007 at 08:24:52AM -0700, Andrew Morton wrote: On Mon, 20 Aug 2007 14:38:57 +0800 gshan [EMAIL PROTECTED] wrote: Hi All, After I started the NFS server, it crashed: 3Badness in local_bh_enable at

[PATCH -mm] ufs: Fix mount check in ufs_fill_super()

2007-09-04 Thread Satyam Sharma
ses in the compound conditional to me, especially given that ufs_get_fs_state() handles the UFS_ST_44BSD case perfectly well. So, let's fix the compound condition appropriately. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- fs/ufs/super.c | 15 --- 1 file changed, 8 i

Re: [PATCH] Fix tsk->exit_state usage (resend)

2007-09-04 Thread Satyam Sharma
Hi Eugene, This already got merged into -mm, but ... On Sun, 19 Aug 2007, Eugene Teo wrote: > > tsk->exit_state can only be 0, EXIT_ZOMBIE, or EXIT_DEAD. A non-zero test > is the same as tsk->exit_state & (EXIT_ZOMBIE | EXIT_DEAD), so just testing > tsk->exit_state is sufficient. ... IMHO

Re: [mtd] allow modular mtdsuper

2007-09-04 Thread Satyam Sharma
nd remove duplicate MODULE_ declarations in mtdpart.c, as mtdcore.c already has them. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- drivers/mtd/Makefile |2 +- drivers/mtd/mtdpart.c |4 2 files changed, 1 inser

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
On Tue, 4 Sep 2007, Satyam Sharma wrote: > Hi Micah, > > > On Tue, 4 Sep 2007, Micah Gruber wrote: > > > This patch fixes a potential null dereference bug where we dereference > > dev before a null check. This patch simply moves the dereferencing after > > th

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Satyam Sharma
Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: > On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: > > > > drivers/net/3c59x.c: In function 'vortex_up': > > drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this > &

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
Hi Micah, On Tue, 4 Sep 2007, Micah Gruber wrote: > This patch fixes a potential null dereference bug where we dereference > dev before a null check. This patch simply moves the dereferencing after > the null check. > > Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> > --- > > ---

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
Hi Micah, On Tue, 4 Sep 2007, Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] --- ---

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Satyam Sharma
Hi Steffen, On Tue, 4 Sep 2007, Steffen Klassert wrote: On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: drivers/net/3c59x.c: In function 'vortex_up': drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function This came in with the recently

Re: [PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c

2007-09-04 Thread Satyam Sharma
On Tue, 4 Sep 2007, Satyam Sharma wrote: Hi Micah, On Tue, 4 Sep 2007, Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah

Re: [mtd] allow modular mtdsuper

2007-09-04 Thread Satyam Sharma
duplicate MODULE_ declarations in mtdpart.c, as mtdcore.c already has them. Signed-off-by: Satyam Sharma [EMAIL PROTECTED] Signed-off-by: David Woodhouse [EMAIL PROTECTED] --- drivers/mtd/Makefile |2 +- drivers/mtd/mtdpart.c |4 2 files changed, 1 insertions(+), 5 deletions(-) diff

Re: [PATCH] Fix tsk-exit_state usage (resend)

2007-09-04 Thread Satyam Sharma
Hi Eugene, This already got merged into -mm, but ... On Sun, 19 Aug 2007, Eugene Teo wrote: tsk-exit_state can only be 0, EXIT_ZOMBIE, or EXIT_DEAD. A non-zero test is the same as tsk-exit_state (EXIT_ZOMBIE | EXIT_DEAD), so just testing tsk-exit_state is sufficient. ... IMHO this change

[PATCH -mm] ufs: Fix mount check in ufs_fill_super()

2007-09-04 Thread Satyam Sharma
that ufs_get_fs_state() handles the UFS_ST_44BSD case perfectly well. So, let's fix the compound condition appropriately. Signed-off-by: Satyam Sharma [EMAIL PROTECTED] --- fs/ufs/super.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) --- linux-2.6.23-rc4-mm1/fs/ufs/super.c~fix 2007-09

Re: [PATCH] Make rcutorture RNG use temporal entropy

2007-09-03 Thread Satyam Sharma
Hi Paul, On Wed, 15 Aug 2007, Paul E. McKenney wrote: > > The locking used by get_random_bytes() can conflict with the > preempt_disable() and synchronize_sched() form of RCU. This patch changes > rcutorture's RNG to gather entropy from the new cpu_clock() interface > (relying on interrupts,

Re: BUG: unable to handle kernel NULL pointer dereference - nfs v3

2007-09-03 Thread Satyam Sharma
Hi David, On Fri, 27 Jul 2007, David CHANIAL wrote: > > Le vendredi 20 juillet 2007 15:36, Satyam Sharma a ecrit: > > Yes, you can apply the patch Neil just sent to your kernel, > > re-build, and test that. > > Hi, I have no patched the kernel as asked by

Re: 2.6.23-rc4-mm1

2007-09-03 Thread Satyam Sharma
have a look at it. How about ... (unrelated cleanup thrown in, but SCNR) * Fix this warning: drivers/watchdog/core/watchdog_dev.c:84: warning: format '%i' expects type 'int', but argument 5 has type 'size_t' * CONFIG_xxx options are directly usable by preprocessor directives. Signed-off-by: S

[PATCH -mm 2/2] 3c59x MAINTAINERS

2007-09-03 Thread Satyam Sharma
Remove duplicate entry for the same driver. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- MAINTAINERS |6 -- 1 file changed, 6 deletions(-) --- linux-2.6.23-rc4-mm1/MAINTAINERS~fix2007-09-04 03:49:16.0 +0530 +++ linux-2.6.23-rc4-mm1/MAINTAINERS2007-09

[PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-03 Thread Satyam Sharma
initializing 'err' to zero. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/net/3c59x.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/net/3c59x.c~fix2007-09-04 03:29:40.0 +0530 +++ linux-2.6.23-rc4-mm1/drive

Re: bug in 2.6.22.6, net/sunrpc/svcsock.c

2007-09-03 Thread Satyam Sharma
Hi Wolfgang, On Mon, 3 Sep 2007, Wolfgang Walter wrote: > > in 2.6.22.6, net/sunrpc/svcsock.c > > random characters are printed by svc_tcp_accept: > > lockd: last TCP connect from > [...] > > --- linux-2.6.22.6/net/sunrpc/svcsock.c 2007-08-27 18:10:14.0 > +0200 > +++

Re: [PATCH 01/32] VFS: export release_open_intent symbol

2007-09-03 Thread Satyam Sharma
On Sun, 2 Sep 2007, Josef 'Jeff' Sipek wrote: > > diff --git a/fs/namei.c b/fs/namei.c > index a83160a..b2b7c8e 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -374,6 +374,7 @@ void release_open_intent(struct nameidata *nd) > else > fput(nd->intent.open.file); > } >

Re: [PATCH 01/32] VFS: export release_open_intent symbol

2007-09-03 Thread Satyam Sharma
On Sun, 2 Sep 2007, Josef 'Jeff' Sipek wrote: diff --git a/fs/namei.c b/fs/namei.c index a83160a..b2b7c8e 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -374,6 +374,7 @@ void release_open_intent(struct nameidata *nd) else fput(nd-intent.open.file); }

Re: bug in 2.6.22.6, net/sunrpc/svcsock.c

2007-09-03 Thread Satyam Sharma
Hi Wolfgang, On Mon, 3 Sep 2007, Wolfgang Walter wrote: in 2.6.22.6, net/sunrpc/svcsock.c random characters are printed by svc_tcp_accept: lockd: last TCP connect from some random chars [...] --- linux-2.6.22.6/net/sunrpc/svcsock.c 2007-08-27 18:10:14.0 +0200

[PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-03 Thread Satyam Sharma
initializing 'err' to zero. Signed-off-by: Satyam Sharma [EMAIL PROTECTED] --- drivers/net/3c59x.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1/drivers/net/3c59x.c~fix2007-09-04 03:29:40.0 +0530 +++ linux-2.6.23-rc4-mm1/drivers/net/3c59x.c

[PATCH -mm 2/2] 3c59x MAINTAINERS

2007-09-03 Thread Satyam Sharma
Remove duplicate entry for the same driver. Signed-off-by: Satyam Sharma [EMAIL PROTECTED] --- MAINTAINERS |6 -- 1 file changed, 6 deletions(-) --- linux-2.6.23-rc4-mm1/MAINTAINERS~fix2007-09-04 03:49:16.0 +0530 +++ linux-2.6.23-rc4-mm1/MAINTAINERS2007-09-04 03

Re: 2.6.23-rc4-mm1

2007-09-03 Thread Satyam Sharma
cleanup thrown in, but SCNR) * Fix this warning: drivers/watchdog/core/watchdog_dev.c:84: warning: format '%i' expects type 'int', but argument 5 has type 'size_t' * CONFIG_xxx options are directly usable by preprocessor directives. Signed-off-by: Satyam Sharma [EMAIL PROTECTED

Re: BUG: unable to handle kernel NULL pointer dereference - nfs v3

2007-09-03 Thread Satyam Sharma
Hi David, On Fri, 27 Jul 2007, David CHANIAL wrote: Le vendredi 20 juillet 2007 15:36, Satyam Sharma a ecrit: Yes, you can apply the patch Neil just sent to your kernel, re-build, and test that. Hi, I have no patched the kernel as asked by Neil, but i would notice that with 2.6.22.1

Re: [PATCH] Make rcutorture RNG use temporal entropy

2007-09-03 Thread Satyam Sharma
Hi Paul, On Wed, 15 Aug 2007, Paul E. McKenney wrote: The locking used by get_random_bytes() can conflict with the preempt_disable() and synchronize_sched() form of RCU. This patch changes rcutorture's RNG to gather entropy from the new cpu_clock() interface (relying on interrupts,

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Satyam Sharma
On Mon, 3 Sep 2007, Alexey Dobriyan wrote: > > Try this from net-2.6 tree: > > --- a/net/ipv4/tcp_input.c > +++ b/net/ipv4/tcp_input.c > @@ -560,7 +560,7 @@ static u32 tcp_rto_min(struct sock *sk) > struct dst_entry *dst = __sk_dst_get(sk); > u32 rto_min = TCP_RTO_MIN; > > -

Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jeff Garzik wrote: > Satyam Sharma wrote: > > drivers/scsi/ips.c: In function ‘ips_register_scsi’: > > drivers/scsi/ips.c:6869: > > warning: ignoring return value of ‘scsi_add_host’, declared with attribute > > warn_unused_result > > > &

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma
On Mon, 3 Sep 2007, Rene Herman wrote: > > On 09/02/2007 10:15 PM, Satyam Sharma wrote: > > > sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: > > Blah. Your message has: > > Content-Type: TEXT/PLAIN; charset=iso-2022-jp > > This apparently

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Mon, 3 Sep 2007, Satyam Sharma wrote: > > On Sun, 2 Sep 2007, Alistair John Strachan wrote: > > > > The encoding is set to ISO-2022-JP, this is probably breaking things. > > ??? I have no clue how/why/when that suddenly happened. > > I clearly see "C

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alistair John Strachan wrote: > On Sunday 02 September 2007 21:23:16 Jesper Juhl wrote: > > On 02/09/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > Hi Jesper, > > > > > > On Sun, 2 Sep 2007, Jesper Juhl wrote: > > &g

Re: Hang in 2.6.23-rc5

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Alessandro Suardi wrote: > > On 9/2/07, charles gagalac <[EMAIL PROTECTED]> wrote: > > On 9/2/07, daryll q wrote: > > > Upgraded my kernel from 2.6.23-rc2 to 2.6.23-rc5. > > > > > > System hangs (caps lock and scroll lock leds are both flashing). > > > > > > It *randomly*

Re: [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jeff Garzik wrote: > Satyam Sharma wrote: > > drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’: > > drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used > > uninitialized in this function > > > > d

Re: [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jeff Garzik wrote: > > Satyam Sharma wrote: > > drivers/scsi/dc395x.c: In function ‘dc395x_init_one’: > > drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this > > function > > > > has been verified to

Re: [-mm patchset] War on warnings

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Jesper Juhl wrote: > > Thank you for doing this, I hope some of your patches get merged. > > Btw; it would be easier to see if one has got all the patches if you > numbered your patch series with the usual "[PATCH XX/YY]". Hey, thanks ;-) There are 13 in all, I just felt

Re: [PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
Hi Jesper, On Sun, 2 Sep 2007, Jesper Juhl wrote: > > > - if (!(interface = usb_find_interface(_driver, subminor))) { > > - dev_err(>sisusb_dev->dev, "Failed to find > > interface¥n"); > > Odd how in your patch the line ends with "¥n" but if I look in my > local copy of

[PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning

2007-09-02 Thread Satyam Sharma
drivers/scsi/dc395x.c: In function ‘dc395x_init_one’: drivers/scsi/dc395x.c:4272: warning: ‘ptr’ may be used uninitialized in this function has been verified to be a bogus warning. Let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/scsi/dc395x.c |2 +-

[PATCH -mm] i386 cpuid_count: Fix argument signedness warnings

2007-09-02 Thread Satyam Sharma
as unsigned. Do some codingstyle here and there while at it. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- include/asm-i386/processor.h |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) --- linux-2.6.23-rc4-mm1/include/asm-i386/processor.h~fix 2007-09-02 23:54:23.000

[PATCH -mm] drivers/md/: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
drivers/md/dm-exception-store.c: In function ‘persistent_read_metadata’: drivers/md/dm-exception-store.c:452: warning: ‘new_snapshot’ may be used uninitialized in this function drivers/md/dm-ioctl.c: In function ‘ctl_ioctl’: drivers/md/dm-ioctl.c:1407: warning: ‘param’ may be used uninitialized

[PATCH -mm] mpt fusion: Shut up uninitialized variable warnings

2007-09-02 Thread Satyam Sharma
e warnings. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/message/fusion/mptctl.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) --- linux-2.6.23-rc4-mm1/drivers/message/fusion/mptctl.c~fix2007-09-02 21:51:14.0 +0530 +++ linux-2.6.23-rc4-mm1

[PATCH -mm] es18xx: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma
sound/isa/es18xx.c: In function ‘snd_es18xx_isa_probe’: sound/isa/es18xx.c:2251: warning: ‘err’ may be used uninitialized in this function gcc is a sad, sad compiler. This warning is bogus so let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- sound/isa/es18xx.c

[PATCH -mm] I2O: Fix "defined but not used" build warnings

2007-09-02 Thread Satyam Sharma
of forward prototype. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- I have no clue who owns this subsystem, and recent git history is all over the place. drivers/message/i2o/exec-osm.c | 94 - 1 file changed, 47 insertions(+), 47 del

[PATCH -mm] sb16: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma
sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: sound/isa/sb16/sb16.c:559: warning: ‘err’ may be used uninitialized in this function is a bogus warning, so let's shut it up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- sound/isa/sb/sb16.c |3 ++- 1 file chan

[PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning

2007-09-02 Thread Satyam Sharma
drivers/mmc/core/bus.c: In function ‘mmc_bus_uevent’: drivers/mmc/core/bus.c:77: warning: unused variable ‘length’ drivers/mmc/core/bus.c:77: warning: unused variable ‘i’ Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/mmc/core/bus.c |1 - 1 file changed, 1 de

[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

2007-09-02 Thread Satyam Sharma
drivers/scsi/ips.c: In function ‘ips_register_scsi’: drivers/scsi/ips.c:6869: warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result scsi_add_host() is __must_check, so let's check it's return and cleanup appropriately on errors. Signed-off-by: Satyam

[PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning

2007-09-02 Thread Satyam Sharma
usb_serial_driver, not a struct usb_driver. This is not a runtime bug, because the function is an empty stub and never dereferences the passed pointer anyway. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/usb/serial/bus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH -mm] net/wireless/sysfs.c: Shut up build warning

2007-09-02 Thread Satyam Sharma
net/wireless/sysfs.c:108: warning: ‘wiphy_uevent’ defined but not used when CONFIG_HOTPLUG=n is because the only usage site of this function is #ifdef'ed as such, so let's #ifdef the definition also. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- net/wireless/sysfs.c |2 ++

[PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning

2007-09-02 Thread Satyam Sharma
() restore to happen only after the kernel_thread() is forked. Alas, we have to use cpus_clear() to initialize oldmask instead to keep gcc happy. Also add some comments to describe what's happening in the function. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- net/sunrpc/svc.c

[PATCH -mm] sisusbvga: Fix bug and build warnings

2007-09-02 Thread Satyam Sharma
rived from "interface" later. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/usb/misc/sisusbvga/sisusb.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) --- linux-2.6.23-rc4-mm1/drivers/usb/misc/sisusbvga/sisusb.c~fix 2007-09-02 19:06:01.0 +053

[-mm patchset] War on warnings

2007-09-02 Thread Satyam Sharma
I decided to ruin my Sunday with an utterly pointless activity -- waging war on -mm build warnings. Some of the code I touched belonged to grotty, unused, dying drivers, but still, the end result was that I can now only see 5 warnings remaining on my typical .config (those have to do with

[PATCH -mm] drivers/char/nozomi.c: __devexit_p usage build fix

2007-09-02 Thread Satyam Sharma
A typo results in build breakage: drivers/char/nozomi.c:2204: error: syntax error before ‘__attribute__’ make[2]: *** [drivers/char/nozomi.o] Error 1 when CONFIG_HOTPLUG=n. This was actually meant to be __devexit_p. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- drivers/char/no

[PATCH -mm][resend] softlockup-improve-debug-output.patch fix

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Satyam Sharma wrote: > > --- kernel/softlockup.c~fix 2007-09-02 04:23:49.0 +0530 > +++ kernel/softlockup.c 2007-09-02 04:34:45.0 +0530 ^^ Ick, I botched a trivial patch, it doesn't even apply. Updated one below (with indent

Re: [OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Mark Hindley wrote: > > BUG: unable to handle kernel NULL pointer dereference at virtual address > 0025 > [...] > Call Trace: > [] tcp_rtt_estimator+0xba/0x100 > [...] > EIP: [] tcp_rto_min+0x8/0x12 SS:ESP 0068:c0341dec Third report of this oops within

Re: 2.6.23-rc4-mm1 OOPS in forcedeth?

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, [EMAIL PROTECTED] wrote: > > > > [EMAIL PROTECTED] wrote: > > > > > > > > On this machine (Athlon 64 X2 4600, 4 GiB memory, lots of disks), > > > > 2.6.23-rc1-mm2 runs fine. 2.6.23-rc4-mm1 reproducably dies within > > > > seconds of > > > > starting > > > > a rsync session

Re: [ANNOUNCE/RFC] Really Fair Scheduler

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Ingo Molnar wrote: > > Although it _should_ have been a net code size win, because if you look > at the diff you'll see that other useful things were removed as well: > sleeper fairness, CPU time distribution smarts, tunings, scheduler > instrumentation code, etc. To be

Re: [ANNOUNCE/RFC] Really Fair Scheduler

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Ingo Molnar wrote: Although it _should_ have been a net code size win, because if you look at the diff you'll see that other useful things were removed as well: sleeper fairness, CPU time distribution smarts, tunings, scheduler instrumentation code, etc. To be fair

Re: 2.6.23-rc4-mm1 OOPS in forcedeth?

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: On this machine (Athlon 64 X2 4600, 4 GiB memory, lots of disks), 2.6.23-rc1-mm2 runs fine. 2.6.23-rc4-mm1 reproducably dies within seconds of starting a rsync session on another PC against this

Re: [OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Mark Hindley wrote: BUG: unable to handle kernel NULL pointer dereference at virtual address 0025 [...] Call Trace: [c0259b1b] tcp_rtt_estimator+0xba/0x100 [...] EIP: [c0259a57] tcp_rto_min+0x8/0x12 SS:ESP 0068:c0341dec Third report of this oops

[PATCH -mm][resend] softlockup-improve-debug-output.patch fix

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Satyam Sharma wrote: --- kernel/softlockup.c~fix 2007-09-02 04:23:49.0 +0530 +++ kernel/softlockup.c 2007-09-02 04:34:45.0 +0530 ^^ Ick, I botched a trivial patch, it doesn't even apply. Updated one below (with indentation fix as added

<    1   2   3   4   5   6   7   8   9   10   >