Hi,
On Thu, 2 Aug 2007, Sam Ravnborg wrote:
> > >
> > > ...
> > > endif # NETDEVICES
> > >
> > > config NETPOLL
> > > depends on NETDEVICES
> > > def_bool NETCONSOLE
> > >
> > > config NETPOLL_TRAP
> > > bool "Netpoll traffic trapping"
> > > default n
> > >
Hi,
On Thu, 2 Aug 2007, Rafał Bilski wrote:
> > > block2mtd: version $Revision: 1.30 $
> > > block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536]
> > > mtdsuper: module license 'unspecified' taints kernel.
> > > mtdsuper: Unknown symbol get_mtd_device
> > > mtdsuper: Unknown symbol
Hi Miklos,
On Wed, 1 Aug 2007, Miklos Szeredi wrote:
> I wonder why we don't have type safe object allocators a-la new() in
> C++ or g_new() in glib?
>
> fooptr = k_new(struct foo, GFP_KERNEL);
>
> is nicer and more descriptive than
>
> fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL);
>
>
Hi,
On Tue, 31 Jul 2007, Alexey Dobriyan wrote:
> [...]
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -281,6 +281,13 @@ EXPORT_SYMBOL(seq_lseek);
> int seq_release(struct inode *inode, struct file *file)
> {
> struct seq_file *m = (struct seq_file *)file->private_data;
> +
> + if
Hi,
On Tue, 31 Jul 2007, Alexey Dobriyan wrote:
[...]
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -281,6 +281,13 @@ EXPORT_SYMBOL(seq_lseek);
int seq_release(struct inode *inode, struct file *file)
{
struct seq_file *m = (struct seq_file *)file-private_data;
+
+ if
Hi Miklos,
On Wed, 1 Aug 2007, Miklos Szeredi wrote:
I wonder why we don't have type safe object allocators a-la new() in
C++ or g_new() in glib?
fooptr = k_new(struct foo, GFP_KERNEL);
is nicer and more descriptive than
fooptr = kmalloc(sizeof(*fooptr), GFP_KERNEL);
and more
Hi,
On Thu, 2 Aug 2007, Rafał Bilski wrote:
block2mtd: version $Revision: 1.30 $
block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536]
mtdsuper: module license 'unspecified' taints kernel.
mtdsuper: Unknown symbol get_mtd_device
mtdsuper: Unknown symbol put_mtd_device
Hi,
On Thu, 2 Aug 2007, Sam Ravnborg wrote:
...
endif # NETDEVICES
config NETPOLL
depends on NETDEVICES
def_bool NETCONSOLE
config NETPOLL_TRAP
bool Netpoll traffic trapping
default n
depends on NETPOLL
config
On Thu, 2 Aug 2007, John Sigler wrote:
Hello,
I'm trying to build a 2.6.22.1-rt9 kernel for a P3.
I used 'make xconfig' to create .config
http://linux.kernel.free.fr/latency/config-2.6.22.1-rt9-adlink
I get the following warning:
LD vmlinux
SYSMAP System.map
SYSMAP
On Thu, 2 Aug 2007, Jarek Poplawski wrote:
On Thu, Aug 02, 2007 at 04:02:21PM +0530, Satyam Sharma wrote:
[...]
How often common developer has to make such decisions in Kconfig?
Probably no more than once per year. So, it's fair to blame anybody
for not reading lkml to find
[ Read through the thread, looked at Kconfig files,
did some tests. Adding Kconfig experts to Cc: list. ]
On Thu, 2 Aug 2007, Sam Ravnborg wrote:
...
endif # NETDEVICES
config NETPOLL
depends on NETDEVICES
def_bool NETCONSOLE
config
into the same mtd.ko module. Fix the Makefile to ensure this, and remove
duplicate MODULE_ declarations in mtdpart.c, as mtdcore.c already has them.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
drivers/mtd/Makefile |2 +-
drivers/mtd/mtdpart.c |4
2 files changed, 1 insertions
On Thu, 2 Aug 2007, Jan Engelhardt wrote:
On Aug 2 2007 21:55, Guennadi Liakhovetski wrote:
[...]
struct {
char c[4];
int i;
} t;
t.i = 0x12345678;
strcpy(t.c, c);
and t.i is silently corrupted. Just wanted to ask if this is known,
Hi,
On Thu, 2 Aug 2007, Stefan Walter wrote:
Steve Dickson wrote:
Stefan Walter wrote:
We do this on a much larger scale though. The bug we ran into is
in line 96 in utils/mountd/auth.c. The strcpy can corrupt
memory when it copies the string returned by client_compose() to
On Thu, 2 Aug 2007, Heiko Carstens wrote:
> From: Heiko Carstens <[EMAIL PROTECTED]>
>
> Fixes WARN_ON() on bitfiels ops for all architectures that have
> been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f.
Well, considering ...
On Tue, 31 Jul 2007, Alexey Dobriyan wrote:
> But I
Hi Rokas,
[ Your mailer does not maintain the Cc: list. That's not good
when posting to LKML. Adding back Jan Engelhardt to Cc: ]
On Wed, 1 Aug 2007, Rokas Masiulis wrote:
> On Wed, Aug 01, 2007 at 09:51:06PM +0200, Jan Engelhardt wrote:
> > [...]
> > echo t >/proc/sysrq-trigger
>
> # cat
On Thu, 2 Aug 2007, Satyam Sharma wrote:
> On Wed, 1 Aug 2007, Alexey Dobriyan wrote:
>
> > On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote:
> > > Callers (especially "store" functions for sysfs or configfs attributes)
> > > that want to
Hi Alexey,
On Wed, 1 Aug 2007, Alexey Dobriyan wrote:
> On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote:
> > Callers (especially "store" functions for sysfs or configfs attributes)
> > that want to convert an input string to a number may often also wan
Hi,
On Wed, 1 Aug 2007, Christopher Hoover wrote:
> Satyam Sharma infradead.org> writes:
> > On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
> >
> > > On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote:
> > > Currently the RFC says to you
On Wed, 1 Aug 2007, Rafał Bilski wrote:
> block2mtd: version $Revision: 1.30 $
> block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536]
> mtdsuper: module license 'unspecified' taints kernel.
> mtdsuper: Unknown symbol get_mtd_device
> mtdsuper: Unknown symbol put_mtd_device
> jffs2:
On Wed, 1 Aug 2007, Chris Rankin wrote:
> --- Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > I expect this is easy to reproduce at will (when shutting down nfs
> > services, probably), right?
>
> I'm not sure about the "at will" part because this is the fi
Hi Chris,
On Wed, 1 Aug 2007, Chris Rankin wrote:
> I am running a 2.6.22 kernel on a dual P4 Xeon (HT enabled) with 2 GB RAM,
> and I have just found
> this BUG in my dmesg log:
>
> nfsd: last server has exited
> nfsd: unexporting all filesystems
> BUG: atomic counter underflow at:
> []
Hi Ulrich,
On Wed, 1 Aug 2007, Ulrich Drepper wrote:
> How about adding the attached text to the Documentation directory? I
> had to correct over the years to one or the other system call design
> problems. Other problems couldn't be corrected anymore and we have to
> live with them. Maybe
Hi Ulrich,
On Wed, 1 Aug 2007, Ulrich Drepper wrote:
How about adding the attached text to the Documentation directory? I
had to correct over the years to one or the other system call design
problems. Other problems couldn't be corrected anymore and we have to
live with them. Maybe
On Wed, 1 Aug 2007, Chris Rankin wrote:
--- Satyam Sharma [EMAIL PROTECTED] wrote:
I expect this is easy to reproduce at will (when shutting down nfs
services, probably), right?
I'm not sure about the at will part because this is the first time I've
seen it since 2.6.22 was
released
Hi Chris,
On Wed, 1 Aug 2007, Chris Rankin wrote:
I am running a 2.6.22 kernel on a dual P4 Xeon (HT enabled) with 2 GB RAM,
and I have just found
this BUG in my dmesg log:
nfsd: last server has exited
nfsd: unexporting all filesystems
BUG: atomic counter underflow at:
[c01a382a]
On Wed, 1 Aug 2007, Rafał Bilski wrote:
block2mtd: version $Revision: 1.30 $
block2mtd: mtd0: [d: /dev/sdc2] erase_size = 64KiB [65536]
mtdsuper: module license 'unspecified' taints kernel.
mtdsuper: Unknown symbol get_mtd_device
mtdsuper: Unknown symbol put_mtd_device
jffs2: Unknown
Hi,
On Wed, 1 Aug 2007, Christopher Hoover wrote:
Satyam Sharma satyam at infradead.org writes:
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote:
Currently the RFC says to you that you should open the serial port:
fd
Hi Alexey,
On Wed, 1 Aug 2007, Alexey Dobriyan wrote:
On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote:
Callers (especially store functions for sysfs or configfs attributes)
that want to convert an input string to a number may often also want to
check for simple input sanity
On Thu, 2 Aug 2007, Satyam Sharma wrote:
On Wed, 1 Aug 2007, Alexey Dobriyan wrote:
On Tue, Jul 31, 2007 at 10:04:10PM +0530, Satyam Sharma wrote:
Callers (especially store functions for sysfs or configfs attributes)
that want to convert an input string to a number may often also
Hi Rokas,
[ Your mailer does not maintain the Cc: list. That's not good
when posting to LKML. Adding back Jan Engelhardt to Cc: ]
On Wed, 1 Aug 2007, Rokas Masiulis wrote:
On Wed, Aug 01, 2007 at 09:51:06PM +0200, Jan Engelhardt wrote:
[...]
echo t /proc/sysrq-trigger
# cat
On Thu, 2 Aug 2007, Heiko Carstens wrote:
From: Heiko Carstens [EMAIL PROTECTED]
Fixes WARN_ON() on bitfiels ops for all architectures that have
been left out in 8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f.
Well, considering ...
On Tue, 31 Jul 2007, Alexey Dobriyan wrote:
But I question
Hi,
On Tue, 31 Jul 2007, Rodolfo Giometti wrote:
> Sorry for wasting your time. :'( Maybe you can provide your solution
> for PPS support and get it included into kernel tree so we can use it
> and live happy! :)
Please stop embarrassing me (and yourself).
Sorry, I did lose my patience
On Tue, 31 Jul 2007, Andrew Morton wrote:
> On Tue, 31 Jul 2007 21:56:12 +0530 (IST)
> Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> > --- a/include/linux/kernel.h
> > +++ b/include/linux/kernel.h
> > @@ -30,6 +30,9 @@ extern const char linux_proc_banner[];
&g
On Tue, 31 Jul 2007, Rodolfo Giometti wrote:
> On Tue, Jul 31, 2007 at 03:31:22AM +0530, Satyam Sharma wrote:
> > Yup, this would avoid races, but then we will lose events. Why is that
> > acceptable, when better alternative (above) exists?
>
> Because is better lossign
On Tue, 31 Jul 2007, Greg KH wrote:
> On Tue, Jul 31, 2007 at 06:20:29PM +0200, Andreas Schwab wrote:
> > Greg KH <[EMAIL PROTECTED]> writes:
> >
> > > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote:
> > >> However, I think using resource_size_t is a bit better than unsigned
> > >>
On Tue, 31 Jul 2007, Neil Horman wrote:
> As Jeremy and I had discussed in a previous thread, it would be nice if the
> argv_split library function could gracefully handle a NULL pointer in the
> argcp
> parameter, so as to allow functions using it that did not care about the value
> of argc
On Tue, 31 Jul 2007, David Woodhouse wrote:
> On Tue, 2007-07-31 at 22:10 +0530, Satyam Sharma wrote:
> > "make headers_check" is too verbose. It likes to chat even if it has
> > just _successfully_ checked a header, and not just on seeing errors.
> > What is wo
and have CONFIG_HEADERS_CHECK=n
set in my .config -- but that could lead to breakages. Hence:
[PATCH] Make headers_check less chatty for success cases
We still echo verbosely (and fail, obviously) for any errors encountered.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
[ just removing t
it
generic w.r.t. base, and export it to the rest of the kernel and modules.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
[ On top of previously posted netconsole patches, and
the just-posted "Introduce U16_MAX and U32_MAX" patch. ]
[ checkpatch.pl doesn't particula
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
[ On top of previously posted netconsole patches. ]
drivers/net/netconsole.c|7 +++
include/linux/kernel.h |3 +++
include/linux/reiserfs_fs.h |1 +
net/ipv4/tcp_illinois.c |2 +-
4 files changed, 8
On Tue, 31 Jul 2007, Andi Kleen wrote:
> "Jesper Juhl" <[EMAIL PROTECTED]> writes:
>
> > [...]
> > Go to "Processor type and features" - then enable "Paravirtualization
> > support (EXPERIMENTAL)", you'll get a new option called "Enable
> > support for Xen hypervisor".
>
> Perhaps it would be
On Tue, 31 Jul 2007, WANG Cong wrote:
> On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote:
> > [...]
> >It better not be, else we have a bug already anyway. Pointers are 64-bit
> >on 64-bit archs. [ it turns out res->start is resource_size_t which i
On Tue, 31 Jul 2007, Christian Borntraeger wrote:
> Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]:
> > --- a/drivers/pci/rom.c
> > +++ b/drivers/pci/rom.c
> > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc
> > IORESOURCE_ROM_BIOS_COPY))
> >
On Tue, 31 Jul 2007, Felipe Balbi wrote:
> On 7/31/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > [...]
> > Ugh, you should at least be checking if you've built the kernel with the
> > same config options :-) Of course, if you did a simple "make oldconfig
Hi,
On Tue, 31 Jul 2007, Felipe Balbi wrote:
> On 7/31/07, Akinobu Mita <[EMAIL PROTECTED]> wrote:
> > > > "Failed to setup dm-crypt key mapping.
> > > > Check kernel for support for the aes-cbc-essiv:sha256 cipher spec and
> > > > verify that /dev/hda4 contains at least 133 sectors.
> > > >
On Tue, 31 Jul 2007, Tejun Heo wrote:
> With the previous sysfs_add_one() update, there is only one user of
> the return value of sysfs_addrm_finish() and the user can switch to
> testing @sd easily. Make sysfs_addrm_finish() return void for cleaner
> semantics as suggested by S
Hi Tejun,
On Tue, 31 Jul 2007, Tejun Heo wrote:
> Tejun Heo wrote:
> > While shadow directories appear to be a good idea, the current scheme
> > of controlling their creation and destruction outside of sysfs appears
> > to be a locking and maintenance nightmare in the face of sysfs
> >
Hi Tejun,
On Tue, 31 Jul 2007, Tejun Heo wrote:
Tejun Heo wrote:
While shadow directories appear to be a good idea, the current scheme
of controlling their creation and destruction outside of sysfs appears
to be a locking and maintenance nightmare in the face of sysfs
directories
On Tue, 31 Jul 2007, Tejun Heo wrote:
With the previous sysfs_add_one() update, there is only one user of
the return value of sysfs_addrm_finish() and the user can switch to
testing @sd easily. Make sysfs_addrm_finish() return void for cleaner
semantics as suggested by Satyam Sharma
Hi,
On Tue, 31 Jul 2007, Felipe Balbi wrote:
On 7/31/07, Akinobu Mita [EMAIL PROTECTED] wrote:
Failed to setup dm-crypt key mapping.
Check kernel for support for the aes-cbc-essiv:sha256 cipher spec and
verify that /dev/hda4 contains at least 133 sectors.
Failed to read from
On Tue, 31 Jul 2007, Felipe Balbi wrote:
On 7/31/07, Satyam Sharma [EMAIL PROTECTED] wrote:
[...]
Ugh, you should at least be checking if you've built the kernel with the
same config options :-) Of course, if you did a simple make oldconfig
but still lost some config options
On Tue, 31 Jul 2007, Christian Borntraeger wrote:
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]:
--- a/drivers/pci/rom.c
+++ b/drivers/pci/rom.c
@@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc
IORESOURCE_ROM_BIOS_COPY))
return
On Tue, 31 Jul 2007, WANG Cong wrote:
On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote:
[...]
It better not be, else we have a bug already anyway. Pointers are 64-bit
on 64-bit archs. [ it turns out res-start is resource_size_t which is
set properly as per
On Tue, 31 Jul 2007, Andi Kleen wrote:
Jesper Juhl [EMAIL PROTECTED] writes:
[...]
Go to Processor type and features - then enable Paravirtualization
support (EXPERIMENTAL), you'll get a new option called Enable
support for Xen hypervisor.
Perhaps it would be clearer to make
-by: Satyam Sharma [EMAIL PROTECTED]
---
[ On top of previously posted netconsole patches. ]
drivers/net/netconsole.c|7 +++
include/linux/kernel.h |3 +++
include/linux/reiserfs_fs.h |1 +
net/ipv4/tcp_illinois.c |2 +-
4 files changed, 8 insertions(+), 5 deletions
w.r.t. base, and export it to the rest of the kernel and modules.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
[ On top of previously posted netconsole patches, and
the just-posted Introduce U16_MAX and U32_MAX patch. ]
[ checkpatch.pl doesn't particularly like this patch, but I wanted
to breakages. Hence:
[PATCH] Make headers_check less chatty for success cases
We still echo verbosely (and fail, obviously) for any errors encountered.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
[ just removing that line also works, but that loses symmetry with others ]
scripts
On Tue, 31 Jul 2007, David Woodhouse wrote:
On Tue, 2007-07-31 at 22:10 +0530, Satyam Sharma wrote:
make headers_check is too verbose. It likes to chat even if it has
just _successfully_ checked a header, and not just on seeing errors.
What is worse, even if you touch just one little
On Tue, 31 Jul 2007, Neil Horman wrote:
As Jeremy and I had discussed in a previous thread, it would be nice if the
argv_split library function could gracefully handle a NULL pointer in the
argcp
parameter, so as to allow functions using it that did not care about the value
of argc to not
On Tue, 31 Jul 2007, Greg KH wrote:
On Tue, Jul 31, 2007 at 06:20:29PM +0200, Andreas Schwab wrote:
Greg KH [EMAIL PROTECTED] writes:
On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote:
However, I think using resource_size_t is a bit better than unsigned
long,
so that
On Tue, 31 Jul 2007, Rodolfo Giometti wrote:
On Tue, Jul 31, 2007 at 03:31:22AM +0530, Satyam Sharma wrote:
Yup, this would avoid races, but then we will lose events. Why is that
acceptable, when better alternative (above) exists?
Because is better lossign events then recording them
On Tue, 31 Jul 2007, Andrew Morton wrote:
On Tue, 31 Jul 2007 21:56:12 +0530 (IST)
Satyam Sharma [EMAIL PROTECTED] wrote:
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -30,6 +30,9 @@ extern const char linux_proc_banner[];
#define LLONG_MIN (-LLONG_MAX - 1
Hi,
On Tue, 31 Jul 2007, Rodolfo Giometti wrote:
Sorry for wasting your time. :'( Maybe you can provide your solution
for PPS support and get it included into kernel tree so we can use it
and live happy! :)
Please stop embarrassing me (and yourself).
Sorry, I did lose my patience (others
Hi Denis,
On Mon, 30 Jul 2007, Denis Vlasenko wrote:
> Hi Satyam,
>
> On Monday 23 July 2007 17:05, Satyam Sharma wrote:
> > There was a lot of bogus stuff that include/asm-i386/bitops.h was doing,
> > that was unnecessary and not required for the correctness o
On Mon, 30 Jul 2007, Andrew Morton wrote:
> On Mon, 30 Jul 2007 08:19:10 +0530
> Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> > +/*
> > + * Wrapper over simple_strtol (base 10) with sanity and range checking.
> > + * We return (signed) long only because we may
On Mon, 30 Jul 2007, Andrew Morton wrote:
> On Mon, 30 Jul 2007 08:17:41 +0530
> Satyam Sharma <[EMAIL PROTECTED]> wrote:
>
> > [0/9] netconsole: Multiple targets and dynamic reconfigurability
> >
> > This is v3 of the patchset
>
> That all looks pre
ove it.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
drivers/net/pcmcia/nmclan_cs.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c
index 73da611..3446be9 100644
--- a/drivers/net/pcmcia/nm
Hi Jeff,
On Mon, 30 Jul 2007, Jeff Garzik wrote:
> Fix a potential NULL pointer dereference in mace_interrupt() in
> drivers/net/pcmcia/nmclan_cs.c
This oops is _programmatically_ impossible (the only way it can occur
is if the kernel has gone bazooka already anyway ...)
[ BTW even if
On Mon, 30 Jul 2007, Christoph Hellwig wrote:
> On Mon, Jul 30, 2007 at 11:27:20AM -0700, Andrew Morton wrote:
> > ho hum, crap. Yes, ioctl_by_bdev() doesn't have a file* and so it makes
> > unlocked_ioctl() rather tricky. We could cook up a `struct file' on the
> > stack (we do that in
On Mon, 30 Jul 2007, Adrian Bunk wrote:
> The arm26 port has been in a state where it was far from even compiling
> for quite some time.
>
> Ian Molton agreed with the removal.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> Due to its size, the patch is attached compressed.
You
Hi Rodolfo,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
> On Mon, Jul 30, 2007 at 02:37:26PM +0530, Satyam Sharma wrote:
>
> > > Maybe you meant I should using spin_lock_irqsave/restore() in user
> > > context, but doing like this I will disable interrupts
&g
On Mon, 30 Jul 2007, John W. Linville wrote:
> On Mon, Jul 30, 2007 at 12:50:31PM +0530, Satyam Sharma wrote:
> > On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
> >
> > > [...]
> > > The Host AP driver uses a semaphore as mutex. Use the mutex API
> &
On Mon, 30 Jul 2007, Andrew Morton wrote:
> On Mon, 30 Jul 2007 19:09:38 +0200
> Michael Buesch <[EMAIL PROTECTED]> wrote:
>
> > On Monday 30 July 2007, Satyam Sharma wrote:
> > >
> > > On Mon, 30 Jul 2007, Michael Buesch wrote:
> > >
> &g
Hi Rodolfo,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
> On Mon, Jul 30, 2007 at 10:39:38AM +0530, Satyam Sharma wrote:
> >
> > Nopes, this isn't quite correct/safe. I suggest you should read:
> >
> > http://www.kernel.org/pub/linux/kernel/people/rusty/
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
> On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote:
> >
> > Fair enough, but I think the code could become a trifle simpler/easier
> > after the conversion, so probably greater chances of getting merged :-)
&
Hi,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
> On Mon, Jul 30, 2007 at 09:49:20AM +0530, Satyam Sharma wrote:
> >
> > Hmm? I still don't see why you can't introduce spin_lock_irqsave/restore()
> > in pps_event() around the access to pps_source.
>
> In pps_
On Mon, 30 Jul 2007, Petko Manolov wrote:
> On Sun, 29 Jul 2007, Oliver Neukum wrote:
>
> > [...]
> > pegasus == NULL there would be a kernel bug. Silently ignoring
> > it, like the code now wants to do is bad. As the oops has never been
> > reported, I figure turning it into an explicit
On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
> [...]
>
> The Host AP driver uses a semaphore as mutex. Use the mutex API
> instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
Reviewed-by: Satyam Sharma <[EMAIL PROTEC
On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
[...]
The Host AP driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
Reviewed-by: Satyam Sharma [EMAIL PROTECTED]
-
To unsubscribe from this list: send
On Mon, 30 Jul 2007, Petko Manolov wrote:
On Sun, 29 Jul 2007, Oliver Neukum wrote:
[...]
pegasus == NULL there would be a kernel bug. Silently ignoring
it, like the code now wants to do is bad. As the oops has never been
reported, I figure turning it into an explicit debugging test
Hi,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
On Mon, Jul 30, 2007 at 09:49:20AM +0530, Satyam Sharma wrote:
Hmm? I still don't see why you can't introduce spin_lock_irqsave/restore()
in pps_event() around the access to pps_source.
In pps_event() is not useful using
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
On Mon, Jul 30, 2007 at 10:33:35AM +0530, Satyam Sharma wrote:
Fair enough, but I think the code could become a trifle simpler/easier
after the conversion, so probably greater chances of getting merged :-)
I see. I'll start thinging about
Hi Rodolfo,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
On Mon, Jul 30, 2007 at 10:39:38AM +0530, Satyam Sharma wrote:
Nopes, this isn't quite correct/safe. I suggest you should read:
http://www.kernel.org/pub/linux/kernel/people/rusty/kernel-locking/
I read it but still I don't
On Mon, 30 Jul 2007, Andrew Morton wrote:
On Mon, 30 Jul 2007 19:09:38 +0200
Michael Buesch [EMAIL PROTECTED] wrote:
On Monday 30 July 2007, Satyam Sharma wrote:
On Mon, 30 Jul 2007, Michael Buesch wrote:
On Sunday 29 July 2007 23:34, Matthias Kaehlcke wrote
On Mon, 30 Jul 2007, John W. Linville wrote:
On Mon, Jul 30, 2007 at 12:50:31PM +0530, Satyam Sharma wrote:
On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
[...]
The Host AP driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off
Hi Rodolfo,
On Mon, 30 Jul 2007, Rodolfo Giometti wrote:
On Mon, Jul 30, 2007 at 02:37:26PM +0530, Satyam Sharma wrote:
Maybe you meant I should using spin_lock_irqsave/restore() in user
context, but doing like this I will disable interrupts
Yup, but the goal is to avoid races
On Mon, 30 Jul 2007, Adrian Bunk wrote:
The arm26 port has been in a state where it was far from even compiling
for quite some time.
Ian Molton agreed with the removal.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Due to its size, the patch is attached compressed.
You could've
On Mon, 30 Jul 2007, Christoph Hellwig wrote:
On Mon, Jul 30, 2007 at 11:27:20AM -0700, Andrew Morton wrote:
ho hum, crap. Yes, ioctl_by_bdev() doesn't have a file* and so it makes
unlocked_ioctl() rather tricky. We could cook up a `struct file' on the
stack (we do that in various
Hi Jeff,
On Mon, 30 Jul 2007, Jeff Garzik wrote:
Fix a potential NULL pointer dereference in mace_interrupt() in
drivers/net/pcmcia/nmclan_cs.c
This oops is _programmatically_ impossible (the only way it can occur
is if the kernel has gone bazooka already anyway ...)
[ BTW even if it
it.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
drivers/net/pcmcia/nmclan_cs.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/net/pcmcia/nmclan_cs.c b/drivers/net/pcmcia/nmclan_cs.c
index 73da611..3446be9 100644
--- a/drivers/net/pcmcia/nmclan_cs.c
+++ b
On Mon, 30 Jul 2007, Andrew Morton wrote:
On Mon, 30 Jul 2007 08:17:41 +0530
Satyam Sharma [EMAIL PROTECTED] wrote:
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This is v3 of the patchset
That all looks pretty reasonable, thanks.
Are we all comfortable
On Mon, 30 Jul 2007, Andrew Morton wrote:
On Mon, 30 Jul 2007 08:19:10 +0530
Satyam Sharma [EMAIL PROTECTED] wrote:
+/*
+ * Wrapper over simple_strtol (base 10) with sanity and range checking.
+ * We return (signed) long only because we may want to return errors.
+ * Do not use
Hi Denis,
On Mon, 30 Jul 2007, Denis Vlasenko wrote:
Hi Satyam,
On Monday 23 July 2007 17:05, Satyam Sharma wrote:
There was a lot of bogus stuff that include/asm-i386/bitops.h was doing,
that was unnecessary and not required for the correctness of those APIs.
All that superfluous
Hi Rodolfo,
On Sun, 29 Jul 2007, Rodolfo Giometti wrote:
> On Sat, Jul 28, 2007 at 05:11:17AM +0530, Satyam Sharma wrote:
>
> > Take the race between the time_pps_setparams() syscall and a concurrent
> > pps_event() from an interrupt for instance. From sys_
Hi,
On Sun, 29 Jul 2007, Rodolfo Giometti wrote:
> On Sat, Jul 28, 2007 at 05:11:17AM +0530, Satyam Sharma wrote:
>
> > > [ Also, have you considered making pps_source a list and not an array?
> > > It'll help you lose a whole lot of MAX_SOURCES, pps_is_allocated, etc
Hi Rodolfo,
On Sun, 29 Jul 2007, Rodolfo Giometti wrote:
> On Sat, Jul 28, 2007 at 02:17:24AM +0530, Satyam Sharma wrote:
> >
> > I only glanced through the code, so could be wrong, but I noticed that
> > the only global / shared data you have in there is a global &
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:
> The DVB frontend tuning interface uses a semaphore as mutex. Use the
> mutex API instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]&g
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:
> The ISDN subsystem common functions use a semaphore as mutex. Use the
> mutex API instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
Reviewed-by: Satyam Sharma <[EMAIL PROTECTED]&g
Whoops ...
On Mon, 30 Jul 2007, Satyam Sharma wrote:
> On Mon, 30 Jul 2007, Michael Buesch wrote:
>
> > On Sunday 29 July 2007 23:34, Matthias Kaehlcke wrote:
> > > The Host AP driver uses a semaphore as mutex. Use the mutex API
> > > instead of the (binary) sema
501 - 600 of 1619 matches
Mail list logo
