Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

_dsi_set_max_return_packet_size(dsi, msg->rx_len); > + if (ret < 0) > + return ret; > + ret = dw_mipi_dsi_dcs_read(dsi, msg); > + break; > default: > dev_err(dsi->dev, "unsupported message type 0x%02x\n", > msg->type); > -- > 2.11.0.197.gb556de5.dirty > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

et_max_return_packet_size(dsi, msg->rx_len); > + if (ret < 0) > + return ret; > + ret = dw_mipi_dsi_dcs_read(dsi, msg); > + break; > default: > dev_err(dsi->dev, "unsupported message type 0x%02x\n", > msg->type); > -- > 2.11.0.197.gb556de5.dirty > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 5/5] drm/rockchip/dsi: add dw-mipi power domain support

On Fri, Jan 20, 2017 at 06:10:51PM +0800, Chris Zhong wrote: > Reference the power domain incase dw-mipi power down when > in use. > Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Chris Zhong <z...@rock-chips.com> > --- > > Changes in v3: None

Re: [PATCH v3 5/5] drm/rockchip/dsi: add dw-mipi power domain support

On Fri, Jan 20, 2017 at 06:10:51PM +0800, Chris Zhong wrote: > Reference the power domain incase dw-mipi power down when > in use. > Reviewed-by: Sean Paul > Signed-off-by: Chris Zhong > --- > > Changes in v3: None > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16

Re: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function

_SEL_VOP_LIT, > .dsi1_en_bit = RK3288_DSI1_SEL_VOP_LIT, > .grf_switch_reg = RK3288_GRF_SOC_CON6, > .max_data_lanes = 4, > - .mode_valid = rk3288_mipi_dsi_mode_valid, > }; > > static struct dw_mipi_dsi_plat_data rk3399_mipi_dsi_drv_data = { > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function

OP_LIT, > .dsi1_en_bit = RK3288_DSI1_SEL_VOP_LIT, > .grf_switch_reg = RK3288_GRF_SOC_CON6, > .max_data_lanes = 4, > - .mode_valid = rk3288_mipi_dsi_mode_valid, > }; > > static struct dw_mipi_dsi_plat_data rk3399_mipi_dsi_drv_data = { > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 2/5] drm/rockchip/dsi: dw-mipi: support RK3399 mipi dsi

}, { > + .compatible = "rockchip,rk3399-mipi-dsi", > + .data = _mipi_dsi_drv_data, > }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, dw_mipi_dsi_dt_ids); > > static int dw_mipi_dsi_bind(struct device *dev, struct device *master, &

Re: [PATCH v3 2/5] drm/rockchip/dsi: dw-mipi: support RK3399 mipi dsi

p,rk3399-mipi-dsi", > + .data = _mipi_dsi_drv_data, > }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, dw_mipi_dsi_dt_ids); > > static int dw_mipi_dsi_bind(struct device *dev, struct device *master, > - void *data) > + void *data) Unrelated whitespace change > { > const struct of_device_id *of_id = > of_match_device(dw_mipi_dsi_dt_ids, dev); > @@ -1249,6 +1292,10 @@ static int dw_mipi_dsi_bind(struct device *dev, struct > device *master, > clk_disable_unprepare(dsi->pclk); > } > > + dsi->phy_cfg_clk = devm_clk_get(dev, "phy_cfg"); > + if (IS_ERR(dsi->phy_cfg_clk)) > + dev_dbg(dev, "have not phy_cfg_clk\n"); > + > ret = clk_prepare_enable(dsi->pllref_clk); > if (ret) { > dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); > @@ -1280,7 +1327,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct > device *master, > } > > static void dw_mipi_dsi_unbind(struct device *dev, struct device *master, > - void *data) > +void *data) Unrelated whitespace change > { > struct dw_mipi_dsi *dsi = dev_get_drvdata(dev); > > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2] drm: Schedule the output_poll_work with 1s delay if we have delayed event

* was enabled before. > +*/ > poll = true; > - delay = 0; > + delay = HZ; > } > > if (poll) > -- > 2.11.0 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2] drm: Schedule the output_poll_work with 1s delay if we have delayed event

* fail in a mysterious way if the delayed event is handled as > +* soon as possible like it is done in > +* drm_helper_probe_single_connector_modes() in case the poll > +* was enabled before. > +*/ > poll = t

Re: [PATCH v4 3/5] drm/dp: add helpers for capture of frame CRCs

C that is using the > eDP connector, so it's passed to userspace. > > v2: Reuse drm_crtc_wait_one_vblank > Update locking, as drm_crtc_add_crc_entry now takes the lock > > v3: Don't call wake_up_interruptible directly, that's now done in > drm_crtc_add_crc_entry. > > v4: St

Re: [PATCH v4 3/5] drm/dp: add helpers for capture of frame CRCs

it's passed to userspace. > > v2: Reuse drm_crtc_wait_one_vblank > Update locking, as drm_crtc_add_crc_entry now takes the lock > > v3: Don't call wake_up_interruptible directly, that's now done in > drm_crtc_add_crc_entry. > > v4: Style fixes (Sean Paul) >

Re: [PATCH v3 1/5] drm/dp: add connector backpointer to drm_dp_aux

On Mon, Jan 9, 2017 at 4:03 AM, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > On 6 January 2017 at 16:56, Sean Paul <seanp...@chromium.org> wrote: >> On Fri, Jan 6, 2017 at 9:30 AM, Tomeu Vizoso <tomeu.viz...@collabora.com> >> wrote: >>> Th

Re: [PATCH v3 1/5] drm/dp: add connector backpointer to drm_dp_aux

On Mon, Jan 9, 2017 at 4:03 AM, Tomeu Vizoso wrote: > On 6 January 2017 at 16:56, Sean Paul wrote: >> On Fri, Jan 6, 2017 at 9:30 AM, Tomeu Vizoso >> wrote: >>> This backpointer allows DP helpers to access the connector it's being >>> used for. &g

Re: [PATCH v3 3/5] drm/dp: add helpers for capture of frame CRCs

ansfer: transfers a message representing a single AUX transaction > * > * The .dev field should be set to a pointer to the device that implements > @@ -760,6 +762,8 @@ struct drm_dp_aux { > struct device *dev; > struct drm_connector *connector; > struct mutex hw_mutex; > + struct work_struct crc_work; > + u8 crc_count; > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > /** > @@ -838,4 +842,7 @@ void drm_dp_aux_init(struct drm_dp_aux *aux); > int drm_dp_aux_register(struct drm_dp_aux *aux); > void drm_dp_aux_unregister(struct drm_dp_aux *aux); > > +int drm_dp_start_crc(struct drm_dp_aux *aux); > +int drm_dp_stop_crc(struct drm_dp_aux *aux); > + > #endif /* _DRM_DP_HELPER_H_ */ > -- > 2.9.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 3/5] drm/dp: add helpers for capture of frame CRCs

gt; * > * The .dev field should be set to a pointer to the device that implements > @@ -760,6 +762,8 @@ struct drm_dp_aux { > struct device *dev; > struct drm_connector *connector; > struct mutex hw_mutex; > + struct work_struct crc_work; > + u8 crc_count; > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > /** > @@ -838,4 +842,7 @@ void drm_dp_aux_init(struct drm_dp_aux *aux); > int drm_dp_aux_register(struct drm_dp_aux *aux); > void drm_dp_aux_unregister(struct drm_dp_aux *aux); > > +int drm_dp_start_crc(struct drm_dp_aux *aux); > +int drm_dp_stop_crc(struct drm_dp_aux *aux); > + > #endif /* _DRM_DP_HELPER_H_ */ > -- > 2.9.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 5/5] drm/rockchip: Implement CRC debugfs API

tate, > + .set_crc_source = vop_crtc_set_crc_source, > }; > > static void vop_fb_unref_worker(struct drm_flip_work *work, void *val) > -- > 2.9.3 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 5/5] drm/rockchip: Implement CRC debugfs API

-1112,6 +1159,7 @@ static const struct drm_crtc_funcs vop_crtc_funcs = { > .reset = vop_crtc_reset, > .atomic_duplicate_state = vop_crtc_duplicate_state, > .atomic_destroy_state = vop_crtc_destroy_state, > + .set_crc_source = vop_crtc_set_crc_source, >

Re: [PATCH v3 1/5] drm/dp: add connector backpointer to drm_dp_aux

o pointers needed). Reasonable? Sean > struct mutex hw_mutex; > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > -- > 2.9.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 1/5] drm/dp: add connector backpointer to drm_dp_aux

struct mutex hw_mutex; > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > -- > 2.9.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr

On Wed, Dec 14, 2016 at 12:03 AM, Archit Taneja <arch...@codeaurora.org> wrote: > Hi, > > On 12/12/2016 08:28 PM, Sean Paul wrote: >> >> On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang <w...@rock-chips.com> wrote: >>> >>> Look likes, the BOE p

Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr

On Wed, Dec 14, 2016 at 12:03 AM, Archit Taneja wrote: > Hi, > > On 12/12/2016 08:28 PM, Sean Paul wrote: >> >> On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang wrote: >>> >>> Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host >

Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr

On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang wrote: > Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host > device, that will cause the panel hang on the startup display. > The root cause we use the fast link mode during enter and exit the psr, > this

Re: [PATCH] drm/bridge: analogix_dp: set the DPCD600 during disabling the psr

On Fri, Dec 9, 2016 at 9:49 PM, Caesar Wang wrote: > Look likes, the BOE panel FW didn't ack the DPCD600 signal from the host > device, that will cause the panel hang on the startup display. > The root cause we use the fast link mode during enter and exit the psr, > this issue is gone if

Re: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

On Sat, Dec 3, 2016 at 10:11 AM, Pan Bian wrote: > In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, > it returns value 0 and parameter *ret is uninitialized. 0 means no error > to the callers of qxl_release_alloc(). The callers keep going and will > try

Re: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

On Sat, Dec 3, 2016 at 10:11 AM, Pan Bian wrote: > In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, > it returns value 0 and parameter *ret is uninitialized. 0 means no error > to the callers of qxl_release_alloc(). The callers keep going and will > try to reference the

Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

On Sun, Dec 4, 2016 at 10:13 PM, Archit Taneja <arch...@codeaurora.org> wrote: > > > On 12/02/2016 09:33 PM, Sean Paul wrote: >> >> On Thu, Dec 1, 2016 at 10:54 PM, Archit Taneja <arch...@codeaurora.org> >> wrote: >>> >>> Hi, >>&

Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

On Sun, Dec 4, 2016 at 10:13 PM, Archit Taneja wrote: > > > On 12/02/2016 09:33 PM, Sean Paul wrote: >> >> On Thu, Dec 1, 2016 at 10:54 PM, Archit Taneja >> wrote: >>> >>> Hi, >>> >>> On 12/02/2016 08:02 AM, zain wang wrote: >>

Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

On Thu, Dec 1, 2016 at 10:54 PM, Archit Taneja wrote: > Hi, > > On 12/02/2016 08:02 AM, zain wang wrote: >> >> We will ignored PSR setting if panel not support it. So, in this case, we >> should >> return from analogix_dp_enable/disable_psr() without any error code. >>

Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

On Thu, Dec 1, 2016 at 10:54 PM, Archit Taneja wrote: > Hi, > > On 12/02/2016 08:02 AM, zain wang wrote: >> >> We will ignored PSR setting if panel not support it. So, in this case, we >> should >> return from analogix_dp_enable/disable_psr() without any error code. >> Let's retrun 0 instead of

[PATCH v16 1/3] drm/rockchip: cdn-dp: add cdn DP support for rk3399

ixed up some races between the worker and modeset] [seanpaul squashed ~15 commits from chromium.org gerrit] Signed-off-by: Sean Paul <seanp...@chromium.org> [groeck fixed compilation errors when building as module] Signed-off-by: Guenter Roeck <gro...@chromium.org> ---

[PATCH v16 1/3] drm/rockchip: cdn-dp: add cdn DP support for rk3399

] [seanpaul squashed ~15 commits from chromium.org gerrit] Signed-off-by: Sean Paul [groeck fixed compilation errors when building as module] Signed-off-by: Guenter Roeck --- Previous changelog https://patchwork.kernel.org/patch/9324737/ Changes in v16: - Fixed races between worker & mod

[PATCH 3/3] drm/rockchip: cdn-dp: Do not run worker while suspended

/0x424 [] kthread+0x10c/0x114 [] ret_from_fork+0x10/0x40 Problem is two-fold: The worker should not run while suspended, and the suspend function should not call cdn_dp_disable() while the worker is running. Signed-off-by: Guenter Roeck <gro...@chromium.org> Signed-off-by: Sean Paul <seanp.

[PATCH 2/3] drm/rockchip: cdn-dp: Load firmware if no monitor connected

fixes the problem. Note that we can not just call schedule_work conditionally in cdn_dp_pd_event() if the insertion status changed. The problem would still be seen if a monitor is connected for the first time during suspend. Signed-off-by: Guenter Roeck <gro...@chromium.org> Signed-off-b

[PATCH 3/3] drm/rockchip: cdn-dp: Do not run worker while suspended

[] ret_from_fork+0x10/0x40 Problem is two-fold: The worker should not run while suspended, and the suspend function should not call cdn_dp_disable() while the worker is running. Signed-off-by: Guenter Roeck Signed-off-by: Sean Paul --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 15

[PATCH 2/3] drm/rockchip: cdn-dp: Load firmware if no monitor connected

that we can not just call schedule_work conditionally in cdn_dp_pd_event() if the insertion status changed. The problem would still be seen if a monitor is connected for the first time during suspend. Signed-off-by: Guenter Roeck Signed-off-by: Sean Paul --- drivers/gpu/drm/rockchip/cdn-dp-core.c

[PATCH 0/3] drm/rockchip: Add CDN DP driver

This series adds support for the CDN DP controller to the rockchip drm driver. This version of includes the version we merged into the chromium.org repo plus ~15 fixes squashed on top. Notable fixes include: - Fixed races between hotplug/extcon worker and modeset - Greater support

[PATCH 0/3] drm/rockchip: Add CDN DP driver

This series adds support for the CDN DP controller to the rockchip drm driver. This version of includes the version we merged into the chromium.org repo plus ~15 fixes squashed on top. Notable fixes include: - Fixed races between hotplug/extcon worker and modeset - Greater support

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

On Tue, Nov 22, 2016 at 1:06 PM, Ville Syrjälä wrote: > On Tue, Nov 22, 2016 at 12:35:53PM -0500, Rob Clark wrote: >> On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä >> wrote: >> > On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

On Tue, Nov 22, 2016 at 1:06 PM, Ville Syrjälä wrote: > On Tue, Nov 22, 2016 at 12:35:53PM -0500, Rob Clark wrote: >> On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä >> wrote: >> > On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: >> >> On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä >>

Re: [PATCH] drm/atomic: cleanup debugfs entries on un-registering the driver.

On Thu, Nov 17, 2016 at 7:26 AM, Brian Starkey wrote: > On Thu, Nov 17, 2016 at 11:41:29AM +, Liviu Dudau wrote: >> >> Cleanup the debugfs entries created by commit 6559c901cb48 when >> the driver's minor gets un-registered. Without it, DRM drivers >> compiled as

Re: [PATCH] drm/atomic: cleanup debugfs entries on un-registering the driver.

On Thu, Nov 17, 2016 at 7:26 AM, Brian Starkey wrote: > On Thu, Nov 17, 2016 at 11:41:29AM +, Liviu Dudau wrote: >> >> Cleanup the debugfs entries created by commit 6559c901cb48 when >> the driver's minor gets un-registered. Without it, DRM drivers >> compiled as modules cannot be rmmod-ed

Re: [PATCH 2/5] drm/modes: Support modes names on the command line

On Tue, Oct 18, 2016 at 4:29 AM, Maxime Ripard wrote: > The drm subsystem also uses the video= kernel parameter, and in the > documentation refers to the fbdev documentation for that parameter. > > However, that documentation also says that instead of giving the

Re: [PATCH 2/5] drm/modes: Support modes names on the command line

On Tue, Oct 18, 2016 at 4:29 AM, Maxime Ripard wrote: > The drm subsystem also uses the video= kernel parameter, and in the > documentation refers to the fbdev documentation for that parameter. > > However, that documentation also says that instead of giving the mode using > its resolution we can

Re: [PATCH 1/5] drm/modes: Rewrite the command line parser

On Tue, Oct 18, 2016 at 4:29 AM, Maxime Ripard wrote: > Rewrite the command line parser in order to get away from the state machine > parsing the video mode lines. > > Hopefully, this will allow to extend it more easily to support named modes > and / or

Re: [PATCH 1/5] drm/modes: Rewrite the command line parser

On Tue, Oct 18, 2016 at 4:29 AM, Maxime Ripard wrote: > Rewrite the command line parser in order to get away from the state machine > parsing the video mode lines. > > Hopefully, this will allow to extend it more easily to support named modes > and / or properties set directly on the command

Re: [PATCH] drm/bridge: analogix_dp: return error if transfer none byte

if (err == -EBUSY) > continue; > > goto unlock; > } > } > > Cc: zain wang <w...@rock-chips.com> > Cc: Sean Paul <seanp...@chromium.org> > Signed-off-by: Jianqun Xu <jay...@rock-chips.com> Reviewed-by: Sean Paul <se

Re: [PATCH] drm/bridge: analogix_dp: return error if transfer none byte

continue; > > goto unlock; > } > } > > Cc: zain wang > Cc: Sean Paul > Signed-off-by: Jianqun Xu Reviewed-by: Sean Paul > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH v12 0/3] drm: add explicit fencing

ools.git/log/ > > Please review! > > Gustavo > > [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1253822.html > > Gustavo Padovan (3): > drm/fence: add in-fences support > drm/fence: add fence timeline to drm_crtc > drm/fence: add out-fences s

Re: [PATCH v12 0/3] drm: add explicit fencing

] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1253822.html > > Gustavo Padovan (3): > drm/fence: add in-fences support > drm/fence: add fence timeline to drm_crtc > drm/fence: add out-fences support > Thanks Gustavo, everything looks good to me. For the series:

Re: [PATCH v8 3/3] drm/fence: add out-fences support

On Fri, Nov 11, 2016 at 12:11 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Fri, Nov 11, 2016 at 11:48:09AM -0500, Sean Paul wrote: >> On Fri, Nov 11, 2016 at 9:15 AM, Gustavo Padovan <gust...@padovan.org> wrote: >> > +static void complete_crtc_si

Re: [PATCH v8 3/3] drm/fence: add out-fences support

On Fri, Nov 11, 2016 at 12:11 PM, Daniel Vetter wrote: > On Fri, Nov 11, 2016 at 11:48:09AM -0500, Sean Paul wrote: >> On Fri, Nov 11, 2016 at 9:15 AM, Gustavo Padovan wrote: >> > +static void complete_crtc_signaling(struct drm_device *dev, >> > +

Re: [PATCH v8 3/3] drm/fence: add out-fences support

On Fri, Nov 11, 2016 at 9:15 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > that sets the OUT_FENCE_PTR property. > > We use the out_fence pointer received in

Re: [PATCH v8 3/3] drm/fence: add out-fences support

On Fri, Nov 11, 2016 at 9:15 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > that sets the OUT_FENCE_PTR property. > > We use the out_fence pointer received in the OUT_FENCE_PTR prop to send > the sync_file fd

Re: [PATCH v8 2/3] drm/fence: add fence timeline to drm_crtc

ents > > - rebase after fence -> dma_fence rename > > v5: Comment by Daniel Vetter > - Add doc for drm_crtc_fence_ops > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > Reviewed-by: Daniel Vetter <daniel.v

Re: [PATCH v8 2/3] drm/fence: add fence timeline to drm_crtc

_fence rename > > v5: Comment by Daniel Vetter > - Add doc for drm_crtc_fence_ops > > Signed-off-by: Gustavo Padovan > Reviewed-by: Daniel Vetter Reviewed-by: Sean Paul > --- > drivers/gpu/drm/drm_crtc.c | 31 +++ > include/drm/drm_crtc.h | 4

Re: [PATCH v8 1/3] drm/fence: add in-fences support

gt; - fail if IN_FENCE_FD was already set > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > Reviewed-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > drivers/gpu/drm/Kconfig

Re: [PATCH v8 1/3] drm/fence: add in-fences support

ot;fence" > - re-introduce WARN_ON if fence set but no fb > > - rebase after fence -> dma_fence rename > > v7: Comments by Brian Starkey > - set state->fence to NULL when duplicating the state > - fail if IN_FENCE_FD was already set > > Sign

Re: [PATCH 0/5] drm/sun4i: Handle TV overscan

On Thu, Nov 3, 2016 at 3:01 AM, Maxime Ripard wrote: > Hi Russell, > > On Mon, Oct 31, 2016 at 08:42:34AM +, Russell King - ARM Linux wrote: >> On Tue, Oct 18, 2016 at 12:03:49PM +0200, Maxime Ripard wrote: >> > The first one is that this overscanning should

Re: [PATCH 0/5] drm/sun4i: Handle TV overscan

On Thu, Nov 3, 2016 at 3:01 AM, Maxime Ripard wrote: > Hi Russell, > > On Mon, Oct 31, 2016 at 08:42:34AM +, Russell King - ARM Linux wrote: >> On Tue, Oct 18, 2016 at 12:03:49PM +0200, Maxime Ripard wrote: >> > The first one is that this overscanning should be reported by the >> > connector

Re: [PATCH] drm: mark drm_of_component_match_add dummy inline

On Wed, Oct 26, 2016 at 4:57 AM, Arnd Bergmann wrote: > The newly added drm_of_component_match_add helper is defined as > 'static' in a header when CONFIG_OF is disabled, causing a warning > each time the header is included: > > In file included from

Re: [PATCH] drm: mark drm_of_component_match_add dummy inline

On Wed, Oct 26, 2016 at 4:57 AM, Arnd Bergmann wrote: > The newly added drm_of_component_match_add helper is defined as > 'static' in a header when CONFIG_OF is disabled, causing a warning > each time the header is included: > > In file included from

Re: [PATCH] drm/virtio: kconfig: Fixup white space.

On Sat, Oct 8, 2016 at 3:55 AM, Peter Griffin wrote: > Use tabs instead of spaces. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones Applied to drm-misc, thanks > --- > drivers/gpu/drm/virtio/Kconfig | 6 +++--- >

Re: [PATCH] drm/virtio: kconfig: Fixup white space.

On Sat, Oct 8, 2016 at 3:55 AM, Peter Griffin wrote: > Use tabs instead of spaces. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones Applied to drm-misc, thanks > --- > drivers/gpu/drm/virtio/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

[PATCH] drm/rockchip: Don't use atomic constructs for psr

Instead of using timer and spinlocks, use delayed_work and mutexes for rockchip psr. This allows us to make blocking calls when enabling/disabling psr (which is sort of important given we're talking over dpcd to the display). Cc: zain wang <w...@rock-chips.com> Signed-off-by: Sean Paul

[PATCH] drm/rockchip: Don't use atomic constructs for psr

Instead of using timer and spinlocks, use delayed_work and mutexes for rockchip psr. This allows us to make blocking calls when enabling/disabling psr (which is sort of important given we're talking over dpcd to the display). Cc: zain wang Signed-off-by: Sean Paul --- drivers/gpu/drm/rockchip

Re: [PATCH 6/6] drm: bridge/analogix: enable vop standby when entry PSR

On Tue, Oct 18, 2016 at 2:22 AM, Zain Wang wrote: > From: zain wang > > make VOP standby when entry PSR to save some power. This is super racey and will cause bugs. Hopefully once you base it on the updated locking it won't be. I'll wait until then to

Re: [PATCH 6/6] drm: bridge/analogix: enable vop standby when entry PSR

On Tue, Oct 18, 2016 at 2:22 AM, Zain Wang wrote: > From: zain wang > > make VOP standby when entry PSR to save some power. This is super racey and will cause bugs. Hopefully once you base it on the updated locking it won't be. I'll wait until then to review. Sean > > Signed-off-by: zain

Re: [PATCH v3 5/6] drm: bridge/analogix: add fast link train for eDP

On Tue, Oct 18, 2016 at 2:22 AM, Zain Wang wrote: > From: zain wang > > we would meet a short black screen when exit PSR with the full link > training, In this case, we should use fast link train instead of full > link training. > > Signed-off-by: zain

Re: [PATCH v3 5/6] drm: bridge/analogix: add fast link train for eDP

On Tue, Oct 18, 2016 at 2:22 AM, Zain Wang wrote: > From: zain wang > > we would meet a short black screen when exit PSR with the full link > training, In this case, we should use fast link train instead of full > link training. > > Signed-off-by: zain wang > --- >

Re: [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind

On Tue, Oct 18, 2016 at 2:14 AM, Zain Wang <w...@rock-chips.com> wrote: > From: zain wang <w...@rock-chips.com> > > phy_power_on() and analogix_dp_init_dp would be called in bridge_eanble, > so remove them from analogix_dp_bind to be clear. > Reviewed-by: Sean

Re: [PATCH v3 2/6] drm/bridge: remove dp init from analogix_dp_bind

On Tue, Oct 18, 2016 at 2:14 AM, Zain Wang wrote: > From: zain wang > > phy_power_on() and analogix_dp_init_dp would be called in bridge_eanble, > so remove them from analogix_dp_bind to be clear. > Reviewed-by: Sean Paul > Signed-off-by: zain wang > --- > > Change

Re: [PATCH v3 4/6] drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

On Tue, Oct 18, 2016 at 2:21 AM, Zain Wang wrote: > From: zain wang > > turn off Main-link and power down eDP PHY when enable psr, > turn on Main-link and power up eDP PHY when disable psr. > > Signed-off-by: zain wang > --- > >

Re: [PATCH v3 4/6] drm: bridge/analogix: switch Main-link and eDP PHY when enable/disable psr

On Tue, Oct 18, 2016 at 2:21 AM, Zain Wang wrote: > From: zain wang > > turn off Main-link and power down eDP PHY when enable psr, > turn on Main-link and power up eDP PHY when disable psr. > > Signed-off-by: zain wang > --- > > Changes in v3: > - detecting PSR state at enable/disable_psr()

Re: [PATCH v3 3/6] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

On Tue, Oct 18, 2016 at 2:21 AM, Zain Wang wrote: > From: Yakir Yang > > Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() > function, or print the sink PSR error state if we failed to apply the > requested PSR setting. > >

Re: [PATCH v3 3/6] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

On Tue, Oct 18, 2016 at 2:21 AM, Zain Wang wrote: > From: Yakir Yang > > Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() > function, or print the sink PSR error state if we failed to apply the > requested PSR setting. > > Signed-off-by: zain wang > Signed-off-by:

Re: [PATCH v3 1/6] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge

operate eDP > without power shutdowned by bridge_disable. > In this case, moving activate/deactivate to enable/disable bridge to avoid it. > Reviewed-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: zain wang <w...@rock-chips.com> > --- > > Changes in v3

Re: [PATCH v3 1/6] drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge

le. > In this case, moving activate/deactivate to enable/disable bridge to avoid it. > Reviewed-by: Sean Paul > Signed-off-by: zain wang > --- > > Changes in v3: > - remove changes before. > - move psr activat/deactivate to enable/disable bridge. > > Chang

Re: [PATCH v2] drm/bridge: analogix: protect power when get_modes or detect

gt; [] do_vfs_ioctl+0x4b8/0x58c > [] SyS_ioctl+0x60/0x88 > > Cc: Inki Dae <inki@samsung.com> > Cc: Sean Paul <seanp...@chromium.org> > Cc: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > Cc: "Ville Syrjälä" <ville.syrj...@linux.intel.com> >

Re: [PATCH v2] drm/bridge: analogix: protect power when get_modes or detect

t; [] SyS_ioctl+0x60/0x88 > > Cc: Inki Dae > Cc: Sean Paul > Cc: Gustavo Padovan > Cc: "Ville Syrjälä" > > Signed-off-by: Mark Yao Thanks for revising, this is much better. Reviewed-by: Sean Paul > --- > Changes in v2: > - remove sub device power

Re: Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

[] drm_helper_probe_single_connector_modes+0x10/0x18 > [] drm_mode_getconnector+0xf4/0x304 > [] drm_ioctl+0x23c/0x390 > [] do_vfs_ioctl+0x4b8/0x58c > [] SyS_ioctl+0x60/0x88 > > Cc: Inki Dae <inki@samsung.com> > Cc: Sean Paul <seanp...@chromium.org> > Cc: Gustav

Re: Question: Re: [PATCH] drm/bridge: analogix: protect power when get_modes or detect

ctor_modes+0x10/0x18 > [] drm_mode_getconnector+0xf4/0x304 > [] drm_ioctl+0x23c/0x390 > [] do_vfs_ioctl+0x4b8/0x58c > [] SyS_ioctl+0x60/0x88 > > Cc: Inki Dae > Cc: Sean Paul > Cc: Gustavo Padovan > Cc: "Ville Syrjälä" > > Signed-off-by: Mark Yao

Re: [PATCH v2 2/4] drm/bridge: analogix_dp: get sync PM when init eDP

On Fri, Sep 30, 2016 at 8:40 AM, zain wang wrote: Can you please add a commit message describing why this is needed. Sean > Signed-off-by: zain wang > > --- > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ > 1

Re: [PATCH v2 2/4] drm/bridge: analogix_dp: get sync PM when init eDP

On Fri, Sep 30, 2016 at 8:40 AM, zain wang wrote: Can you please add a commit message describing why this is needed. Sean > Signed-off-by: zain wang > > --- > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

On Thu, Sep 29, 2016 at 8:04 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Hi, > > On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: >> As an aside, it seems like (from the diff, I haven't looked at the >> code) the bridge_pre_enable an

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

On Thu, Sep 29, 2016 at 8:04 AM, Maxime Ripard wrote: > Hi, > > On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: >> As an aside, it seems like (from the diff, I haven't looked at the >> code) the bridge_pre_enable and bridge_post_disable calls are missing, >

Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit

On Tue, Sep 27, 2016 at 11:54 AM, Sean Paul <seanp...@chromium.org> wrote: > On Mon, Sep 26, 2016 at 4:36 AM, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: >> On Sun, Sep 25, 2016 at 07:18:34PM -0700, Joe Perches wrote: >>> Remove function name and spec

Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit

On Tue, Sep 27, 2016 at 11:54 AM, Sean Paul wrote: > On Mon, Sep 26, 2016 at 4:36 AM, Chris Wilson > wrote: >> On Sun, Sep 25, 2016 at 07:18:34PM -0700, Joe Perches wrote: >>> Remove function name and special " *ERROR*" from argument list >>> >&g

Re: [PATCH] uapi: add missing install of sync_file.h

On Tue, Sep 27, 2016 at 12:06 PM, Gustavo Padovan wrote: > 2016-09-27 Emilio López : > >> As part of the sync framework destaging, the sync_file.h header >> was moved, but an entry was not added on Kbuild to install it. >> This patch

Re: [PATCH] uapi: add missing install of sync_file.h

On Tue, Sep 27, 2016 at 12:06 PM, Gustavo Padovan wrote: > 2016-09-27 Emilio López : > >> As part of the sync framework destaging, the sync_file.h header >> was moved, but an entry was not added on Kbuild to install it. >> This patch resolves this omission so that "make headers_install" >>

Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

@perches.com> wrote: >>> > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: >>> > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches <j...@perches.com> wrote: >>> > > > Use a bit more consistent style with kernel loglevels >>> > > I'

Re: [PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

On Tue, Sep 27, 2016 at 12:54 PM, Emil Velikov wrote: > On 27 September 2016 at 17:43, Joe Perches wrote: >> On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: >>> On 27 September 2016 at 17:04, Joe Perches wrote: >>> > On Tue, 2016-09-27 at 11:58 -0400, Sean P

Re: [PATCH] drm/mediatek: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:41 AM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/mediatek/mtk_hdmi.c:1089:6: warning: no previous prototype > for 'mtk_hdmi_audio_enable' [-Wmissing-prototypes] >

Re: [PATCH] drm/mediatek: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:41 AM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/mediatek/mtk_hdmi.c:1089:6: warning: no previous prototype > for 'mtk_hdmi_audio_enable' [-Wmissing-prototypes] > drivers/gpu/drm/mediatek/mtk_hdmi.c:1095:6: warning: no

Re: [PATCH 2/2] drm/rockchip: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:43 AM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous > prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] >

Re: [PATCH 2/2] drm/rockchip: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:43 AM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous > prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6:

Re: [PATCH] drm/sti: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:57 AM, Baoyou Xie wrote: > We get 6 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_mixer.c:361:6: warning: no previous prototype for > 'sti_mixer_set_matrix' [-Wmissing-prototypes] > drivers/gpu/drm/sti/sti_dvo.c:109:5: warning:

Re: [PATCH] drm/sti: mark symbols static where possible

On Sun, Sep 25, 2016 at 3:57 AM, Baoyou Xie wrote: > We get 6 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_mixer.c:361:6: warning: no previous prototype for > 'sti_mixer_set_matrix' [-Wmissing-prototypes] > drivers/gpu/drm/sti/sti_dvo.c:109:5: warning: no previous prototype

Re: [PATCH 1/2] drm/rockchip: add missing header dependencies

On Sun, Sep 25, 2016 at 3:38 AM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous > prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] >

Re: [PATCH 1/2] drm/rockchip: add missing header dependencies

On Sun, Sep 25, 2016 at 3:38 AM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous > prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] >

<    3   4   5   6   7   8   9   10   11   12   >