Re: [PATCH] power: supply: ds2780: Switch to using the new API kobj_to_dev()

2021-01-16 Thread Sebastian Reichel
Hi, On Tue, Dec 15, 2020 at 09:00:24AM +0800, Tian Tao wrote: > fixed the following coccicheck: > drivers/power/supply/ds2780_battery.c:627:60-61: WARNING opportunity for > kobj_to_dev() > drivers/power/supply/ds2780_battery.c:672:60-61: WARNING opportunity for > kobj_to_dev() > drivers/power/supp

Re: [PATCH v2] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2021-01-16 Thread Sebastian Reichel
Hi, On Wed, Dec 23, 2020 at 12:40:09AM +, Hermes Zhang wrote: > On 12/22/20 7:53 PM, Pali Rohár wrote: > > On Tuesday 22 December 2020 19:07:20 Hermes Zhang wrote: > >> From: Hermes Zhang > >> > >> The CHARGE_NOW is map to REG_NAC for all the gauge chips beofre. But for > >> some chips (e.g.

Re: [PATCH v3 2/2] power: supply: mt6360_charger: add MT6360 charger support

2021-01-16 Thread Sebastian Reichel
Hi, On Mon, Jan 11, 2021 at 08:15:33PM +0800, Gene Chen wrote: > Sebastian Reichel 於 2021年1月7日 週四 上午4:16寫道: > > > +static int mt6360_charger_get_ichg(struct mt6360_chg_info *mci, > > > +union power_supply_propval *val) > &g

Re: [PATCH][next] power: supply: cpcap-charger: Fix power_supply_put on null battery pointer

2021-01-15 Thread Sebastian Reichel
Hi, On Fri, Jan 15, 2021 at 03:24:17PM +0200, Tony Lindgren wrote: > * Colin King [210115 13:15]: > > From: Colin Ian King > > > > Currently if the pointer battery is null there is a null pointer > > dereference on the call to power_supply_put. Fix this by only > > performing the put if batter

Re: linux-next: Fixes tags need some work in the battery tree

2021-01-14 Thread Sebastian Reichel
Hi Stephen, On Fri, Jan 15, 2021 at 09:23:01AM +1100, Stephen Rothwell wrote: > Hi all, > > In commit > > c339b3aec780 ("power: supply: cpcap-battery: Fix missing > power_supply_put()") > > Fixes tag > > Fixes: b0134cc14b9 ("power: supply: cpcap-battery: Fix handling of lowered > charger

Re: linux-next: Fixes tag needs some work in the battery tree

2021-01-14 Thread Sebastian Reichel
Hi Stephen, On Fri, Jan 15, 2021 at 06:39:35AM +1100, Stephen Rothwell wrote: > In commit > > e1cc2d7d3868 ("power: supply: bq256xx: Fix BQ256XX_NUM_WD_VAL and > bq256xx_watchdog_time[] overrun") > > Fixes tag > > Fixes: 32e4978bb92 ("power: supply: bq256xx: Introduce the BQ256XX charger

Re: [PATCH v8 3/3] power: supply: Add battery gauge driver for Acer Iconia Tab A500

2021-01-14 Thread Sebastian Reichel
Hi, On Mon, Dec 28, 2020 at 07:05:47PM +0300, Dmitry Osipenko wrote: > This patch adds battery gauge driver for Acer Iconia Tab A500 device. > The battery gauge function is provided via the Embedded Controller, > which is found on the Acer A500. > > Reviewed-by: Sebastian Reiche

Re: [PATCH] power: supply: bq256xx: Fix BQ256XX_NUM_WD_VAL and bq256xx_watchdog_time[] overrun

2021-01-14 Thread Sebastian Reichel
Hi, On Wed, Jan 13, 2021 at 04:53:52PM -0600, Ricardo Rivera-Matos wrote: > Corrects BQ256XX_NUM_WD_VAL from value of "8" to "4" and fixes the issue when > 'i' > is equal to array size then array index over runs the array > > Fixes: 32e4978bb92 ("power: supply: bq256xx: Introduce the BQ256XX cha

Re: [PATCH v5 5/7] power: reset: Add poweroff driver for ATC260x PMICs

2021-01-13 Thread Sebastian Reichel
Hi, On Wed, Jan 13, 2021 at 01:05:55PM +0200, Cristian Ciocaltea wrote: > This driver provides poweroff and reboot support for a system through > the ATC2603C and ATC2609A chip variants of the Actions Semi ATC260x > family of PMICs. > > Signed-off-by: Cristian Ciocaltea > --- Thanks, queued to

Re: [PATCH 0/2] power: supply: Constify static struct attribute_group

2021-01-13 Thread Sebastian Reichel
Hi, On Wed, Jan 13, 2021 at 09:32:41PM +0100, Rikard Falkeborn wrote: > Constify two static struct attribute_group. The only place they are > used is to put their address in an array of pointers to const struct > attribute_group. With these patches applied, all static attribute_group > structs in

Re: [PATCH v5] power/supply: Add ltc4162-l-charger

2021-01-12 Thread Sebastian Reichel
Hi, On Thu, Jan 07, 2021 at 03:32:48PM +0100, Mike Looijmans wrote: > Add support for the LTC4162-L Li-Ion battery charger. The driver allows > reading back telemetry and to set some charging options like the input > current limit. > > Signed-off-by: Mike Looijmans > --- Thanks, queued. -- Seb

Re: [PATCH] power: supply: remove duplicated argument in power_supply_hwmon_info

2021-01-12 Thread Sebastian Reichel
Hi, On Mon, Jan 11, 2021 at 05:49:31PM -0800, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > 'HWMON_T_INPUT' and 'HWMON_T_MIN_ALARM' in power_supply_hwmon_info are > duplicated and can be removed. > > Signed-off-by: Menglong Dong > --- Thanks, queued. -- Sebastian > drivers/powe

omapfb removal (was: Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive)

2021-01-12 Thread Sebastian Reichel
[dropped linux-next from Cc] Hi, On Tue, Jan 12, 2021 at 03:10:56PM +0200, Tomi Valkeinen wrote: > >> But why is it it we need omapfb at all when we have omapdrm? > > > > I think there are two reasons omapfb has not been killed yet. One > > reason was missing support for manually updated DSI pan

Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-12 Thread Sebastian Reichel
[replace Tomi's TI mail address with something working] Hi, On Fri, Jan 08, 2021 at 08:58:39PM +0100, Sam Ravnborg wrote: > Hi Sebastian, > > On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote: > > Standard DRM panel driver for DSI command mode panel use

[PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-08 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- Laurent introduced and fixed the same issue for the other panels and this simply replicates the same solution for DSI command mode panel. --- drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbd

Re: [PATCH v10 0/2] Introduce the BQ256XX family of chargers

2021-01-06 Thread Sebastian Reichel
Hi Ricardo, On Wed, Jan 06, 2021 at 01:58:47PM -0600, Ricardo Rivera-Matos wrote: > Hello, > > This patchset introduces the bq256xx family of charging ICs. The bq256xx > ICs are highly integrated, buck, switching chargers intended for use in > smartphones, tablets, and portable electronics. > >

Re: [PATCH v3 2/2] power: supply: mt6360_charger: add MT6360 charger support

2021-01-06 Thread Sebastian Reichel
Hi Gene, I have a bunch of comments, please take a look at my inline comments. On Thu, Dec 24, 2020 at 03:48:04PM +0800, Gene Chen wrote: > From: Gene Chen > > Add basic support for the battery charger for MT6360 PMIC > > Signed-off-by: Gene Chen > --- > drivers/power/supply/Kconfig

Re: [PATCH][next] power: supply: max8997_charger: fix spelling mistake "diconnected" -> "disconnected"

2021-01-06 Thread Sebastian Reichel
Hi, On Mon, Jan 04, 2021 at 01:05:13PM +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/power/supply/max8997_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH v4] power/supply: Add ltc4162-l-charger

2021-01-06 Thread Sebastian Reichel
Hi, On Wed, Jan 06, 2021 at 08:55:57AM +0100, Mike Looijmans wrote: > Add support for the LTC4162-L Li-Ion battery charger. The driver allows > reading back telemetry and to set some charging options like the input > current limit. > > Signed-off-by: Mike Looijmans > --- > v2: Use microohm units

Re: [PATCH 4/4] Input: omap4-keypad - simplify probe with devm

2021-01-06 Thread Sebastian Reichel
Hi Tony, On Wed, Jan 06, 2021 at 02:58:22PM +0200, Tony Lindgren wrote: > Simplify probe with devm. [...] > /* input device allocation */ > - keypad_data->input = input_dev = input_allocate_device(); > + keypad_data->input = input_dev = devm_input_allocate_device(&pdev->dev); >

Re: [PATCH v9 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2021-01-05 Thread Sebastian Reichel
Hi, On Tue, Jan 05, 2021 at 02:29:49PM -0600, Ricardo Rivera-Matos wrote: > The BQ256XX family of devices are highly integrated buck chargers > for single cell batteries. > > Signed-off-by: Ricardo Rivera-Matos > > v9 - resolves two warnings issued by kernel test robot changelog needs to be be

Re: [PATCH v8 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2021-01-05 Thread Sebastian Reichel
Hi Ricardo, On Tue, Jan 05, 2021 at 11:24:18AM +0800, kernel test robot wrote: > Hi Ricardo, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on power-supply/for-next] > [also build test WARNING on robh/for-next v5.11-rc2 next-20210104] > [If your patch is

Re: mmotm 2021-01-04-16-56 uploaded (drivers/power/supply/max8997_charger.c)

2021-01-05 Thread Sebastian Reichel
Hi Randy, On Mon, Jan 04, 2021 at 08:26:04PM -0800, Randy Dunlap wrote: > Commit bb118e5178b3 in linux-next seems to introduce a few build problems: > > ld: drivers/power/supply/max8997_charger.o: in function > `max8997_battery_extcon_evt_worker': > max8997_charger.c:(.text+0xa3): undefined refe

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Sebastian Reichel
./bindings/power/supply/bq25980.yaml | 1 + > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v4 5/7] power: reset: Add poweroff driver for ATC260x PMICs

2021-01-02 Thread Sebastian Reichel
Hi, On Tue, Dec 29, 2020 at 07:31:20PM +0200, Cristian Ciocaltea wrote: > This driver provides poweroff and reboot support for a system through > the ATC2603C and ATC2609A chip variants of the Actions Semi ATC260x > family of PMICs. > > Signed-off-by: Cristian Ciocaltea > --- > Changes in v4: >

Re: [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit

2021-01-02 Thread Sebastian Reichel
Hi, On Wed, Dec 30, 2020 at 08:52:15PM +, Timon Baetz wrote: > Register for extcon notification and set charging current depending on > the detected cable type. Current values are taken from vendor kernel, > where most charger types end up setting 650mA [0]. > > Also enable and disable the CH

Re: [PATCH v7 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2021-01-02 Thread Sebastian Reichel
Hi Ricardo, On Wed, Dec 30, 2020 at 05:01:16PM -0600, Ricardo Rivera-Matos wrote: > The BQ256XX family of devices are highly integrated buck chargers > for single cell batteries. > > Signed-off-by: Ricardo Rivera-Matos > > v5 - adds power_supply_put_battery_info() and devm_add_action_or_rest()

Re: [PATCH] HSI: Fix PM usage counter unbalance in ssi_hw_init

2021-01-01 Thread Sebastian Reichel
Hi, On Mon, Nov 23, 2020 at 06:18:27PM +0800, Zhang Qilong wrote: > pm_runtime_get_sync will increment pm usage counter > even it failed. Forgetting to putting operation will > result in reference leak here. We fix it by replacing > it with pm_runtime_resume_and_get to keep usage counter > balance

Re: [PATCH v3] power/supply: Add ltc4162-l-charger

2020-12-29 Thread Sebastian Reichel
Hi, Sorry for slow processing of this. Driver looks mostly fine, but I do have some comments. On Mon, Nov 02, 2020 at 10:21:31AM +0100, Mike Looijmans wrote: > Add support for the LTC4162-L Li-Ion battery charger. The driver allows > reading back telemetry and to set some charging options like th

Re: [PATCH v4 2/2] power: supply: bq25790: Introduce the BQ25790 charger driver

2020-12-27 Thread Sebastian Reichel
Hi, Sorry, took me a lot longer than expected... On Fri, Oct 09, 2020 at 09:41:12AM -0500, Dan Murphy wrote: > BQ25790 is a highly integrated switch-mode buck-boost charger > for 1-4 cell Li-ion battery and Li-polymer battery. > > Signed-off-by: Ricardo Rivera-Matos > Signed-off-by: Dan Murphy

[GIT PULL] power-supply changes for 5.11

2020-12-18 Thread Sebastian Reichel
Hi Linus, The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git tags/for-v5.11 for you to fetch cha

[GIT PULL] hsi changes for 5.11

2020-12-18 Thread Sebastian Reichel
Hi Linus, The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git tags/hsi-for-5.11 for you to fetch changes up

Re: [PATCH] dt-bindings: Fix JSON pointers

2020-12-18 Thread Sebastian Reichel
ellWise. The only way to obtain >it is to mail two batteries to a test facility of CellWise and receive >back a test report with the binary blob. > -$ref: /schemas/types.yaml#definitions/uint8-array > +$ref: /schemas/types.yaml#/definitions/uint8-array > minItems: 64 > maxItems: 64 > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v5 1/3] power: reset: new driver regulator-poweroff

2020-12-14 Thread Sebastian Reichel
Hi Maxime, On Mon, Dec 14, 2020 at 11:02:04AM +0100, Maxime Ripard wrote: > Hi Sebastian, > > On Sun, Dec 13, 2020 at 12:41:16AM +0100, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Dec 11, 2020 at 04:14:43PM +0100, Michael Klein wrote: > > > This driver

Re: [PATCH] power: supply: Fix a typo in warning message

2020-12-12 Thread Sebastian Reichel
Hi, On Sat, Dec 05, 2020 at 10:25:32AM +0900, Masanari Iida wrote: > This patch fix a warning messages in power_supply_sysfs.c > > Signed-off-by: Masanari Iida > --- Thanks, queued. -- Sebastian > drivers/power/supply/power_supply_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v5 2/3] Documentation: DT: binding documentation for regulator-poweroff

2020-12-12 Thread Sebastian Reichel
Hi, On Fri, Dec 11, 2020 at 04:14:44PM +0100, Michael Klein wrote: > Add devicetree binding documentation for regulator-poweroff driver. > > Signed-off-by: Michael Klein > --- Thanks, queued. -- Sebastian > .../power/reset/regulator-poweroff.yaml | 37 +++ > 1 file chan

Re: [PATCH v5 1/3] power: reset: new driver regulator-poweroff

2020-12-12 Thread Sebastian Reichel
Hi, On Fri, Dec 11, 2020 at 04:14:43PM +0100, Michael Klein wrote: > This driver registers a pm_power_off function to turn off the board > by force-disabling a devicetree-defined regulator. > > Signed-off-by: Michael Klein > --- Thanks, queued. -- Sebastian > drivers/power/reset/Kconfig

Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Sebastian Reichel
(I shortened the Cc) Hi, On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote: > [...] > index d956c67d5155..f737de0470de 100644 > --- a/drivers/power/supply/max17040_battery.c > +++ b/drivers/power/supply/max17040_battery.c > @@ -367,7 +367,7 @@ static int max17040_enable_alert_ir

Re: [PATCH v5 01/16] HSI: fix a kernel-doc markup

2020-12-02 Thread Sebastian Reichel
Hi, On Tue, Dec 01, 2020 at 01:08:54PM +0100, Mauro Carvalho Chehab wrote: > A function has a different name between their prototype > and its kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab > --- Thanks, queued to HSI tree. -- Sebastian > [...] > /** > - * hsi_unregister_port -

Re: [PATCH] Input: add SW_COVER_ATTACHED and SW_EXT_PEN_ATTACHED

2020-10-30 Thread Sebastian Reichel
Hi, On Fri, Oct 30, 2020 at 10:15:52PM +0900, Jungrae Kim wrote: > From 23aed4567e234b7e108c31abadb9f3a3f7d2 Mon Sep 17 00:00:00 2001 > From: Jungrae Kim > Date: Fri, 30 Oct 2020 21:23:12 +0900 > Subject: [PATCH] Input: add SW_COVER_ATTACHED and SW_EXT_PEN_ATTACHED > > SW_COVER_ATTACHED repr

Re: [PATCH v6 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-10-19 Thread Sebastian Reichel
Hi Ricardo, On Mon, Oct 05, 2020 at 04:47:09PM -0500, Ricardo Rivera-Matos wrote: > The BQ256XX family of devices are highly integrated buck chargers > for single cell batteries. > > Signed-off-by: Ricardo Rivera-Matos > > v5 - adds power_supply_put_battery_info() and devm_add_action_or_rest()

[GIT PULL] power-supply changes for 5.10

2020-10-19 Thread Sebastian Reichel
Sparx5 Linus Walleij (1): power: supply: gpio-charger: Convert to GPIO descriptors Lucas Stach (1): power: supply: ucs1002: fix some health status issues Michał Mirosław (2): power: supply: bq25890: support IBAT compensation power: supply: bq25890: document IBAT compensati

Re: [PATCH] power: reset: POWER_RESET_OCELOT_RESET should depend on Ocelot or Sparx5

2020-10-15 Thread Sebastian Reichel
Hi, On Wed, Oct 14, 2020 at 03:14:15PM +0200, Geert Uytterhoeven wrote: > To add support for Sparx5, the dependency on MSCC_OCELOT was removed. > However, this increases exposure of the driver question not only to > Sparx5 platforms, but to everyone. Hence re-add the dependency on > MSCC_OCELOT,

Re: [PATCH] power: supply: bq25980: Fix uninitialized wd_reg_val and overrun

2020-10-13 Thread Sebastian Reichel
Hi Dan, On Tue, Oct 13, 2020 at 01:03:13PM -0500, Dan Murphy wrote: > On 10/9/20 7:12 AM, Dan Murphy wrote: > > Fix the issue when 'i' is equal to array size then array index over > > runs the array when checking for the watch dog value. > > > > This also fixes the uninitialized wd_reg_val if the

Re: [PATCH v4 1/2] dt-bindings: power: Add the bq25790 dt bindings

2020-10-13 Thread Sebastian Reichel
Hi Dan, On Tue, Oct 13, 2020 at 01:03:52PM -0500, Dan Murphy wrote: > On 10/9/20 9:41 AM, Dan Murphy wrote: > > Add the bindings for the bq25790. > > Also any updates on this series? Sorry, It's not gonna make it into this merge window. I did not yet fully review it and merge window is already o

Re: [PATCH] power: supply: ltc2941: Fix ptr to enum cast

2020-10-10 Thread Sebastian Reichel
Hi, On Sat, Oct 10, 2020 at 09:55:26AM +0300, Iskren Chernev wrote: > clang complains about casting pointers to smaller enum types. > > Signed-off-by: Iskren Chernev > --- Thanks, queued. -- Sebastian > drivers/power/supply/ltc2941-battery-gauge.c | 3 ++- > 1 file changed, 2 insertions(+),

[GIT PULL] power-supply changes for 5.9-rc

2020-10-09 Thread Sebastian Reichel
error checking for battery data on Chromebooks, since some of their embedded controllers do not handle it correctly. Sebastian Reichel (1): power: supply: sbs-battery: chromebook workaround for PEC drivers/power/supply/sbs

Re: [PATCH] power: supply: max17040: Fix ptr to enum cast

2020-10-08 Thread Sebastian Reichel
Hi, On Mon, Oct 05, 2020 at 11:00:38PM +0300, Iskren Chernev wrote: > clang complains about casting pointers to smaller enum types. > > Reported-by: kernel test robot > Signed-off-by: Iskren Chernev > --- Thanks, queued. > P.S. I fixed a similar issue in v5, but it was in another patch, and t

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-08 Thread Sebastian Reichel
Hi, On Mon, Oct 05, 2020 at 04:44:17AM +, Harley A.W. Lorenzo wrote: > On Monday, October 5, 2020 12:19 AM, Joe Perches wrote: > > I did not suggest this. > > My apologies. Revised patch (still diffing from Xiongfeng Wang) here. > > [PATCH v2] test_power: revise parameter printing to use sp

Re: [PATCH v3 1/5] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding

2020-10-08 Thread Sebastian Reichel
Hi, On Sun, Sep 06, 2020 at 10:50:59PM +0300, Dmitry Osipenko wrote: > Add binding document for the ENE KB930 Embedded Controller. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/mfd/ene-kb930.yaml| 66 +++ > 1 file changed, 66 insertions(+) > create mode

Re: [PATCH v3 3/5] power: supply: Add battery gauge driver for Acer Iconia Tab A500

2020-10-08 Thread Sebastian Reichel
Dmitry Osipenko > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/Kconfig | 6 + > drivers/power/supply/Makefile| 1 + > drivers/power/supply/acer_a500_battery.c | 297 +++ > 3 files changed, 304 insertions(+) > create

Re: [PATCH][next] charger-manager: fix incorrect check on charging_duration_ms

2020-10-08 Thread Sebastian Reichel
Hi Colin, On Wed, Sep 02, 2020 at 02:31:17PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the duration check on the discharging duration setting is > checking the charging duration rather than the discharging duration > due to a cut-n-paste coding error. Fix this by checking the

Re: [PATCH] power: supply: charger-manager: Tidy function

2020-10-08 Thread Sebastian Reichel
Hi, On Wed, Sep 02, 2020 at 05:58:16PM +0100, Alex Dewar wrote: > check_charging_duration() contains some copy-pasted code, which makes it > less readable. Refactor the function to be a bit tidier. > > I've also fixed a couple of typos. > > Signed-off-by: Alex Dewar > --- > drivers/power/suppl

Re: [PATCH v2 0/3] power: Add reset support for Microchip Sparx5 SoC

2020-10-08 Thread Sebastian Reichel
Hi, On Tue, Oct 06, 2020 at 10:03:13PM +0200, Lars Povlsen wrote: > This adds reset support for the Sparx5 SoC, using the ocelot reset > driver. > > Changes in v2: > - Dropped the parts for resetting the switch core upon load time - > controlled by the 'microchip,reset-switch-core' DT property.

Re: [PATCH][next] power: supply: bq25980: remove redundant zero check on ret

2020-10-08 Thread Sebastian Reichel
Hi, On Tue, Oct 06, 2020 at 12:23:06PM -0500, Dan Murphy wrote: > Colin > > On 10/6/20 12:06 PM, Colin King wrote: > > From: Colin Ian King > > > > Currently ret is assigned to zero and the following statement checks > > if it is non-zero. This check is redundant and can be removed > > > > Add

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-05 Thread Sebastian Reichel
allow for > additionalProperties. > > Signed-off-by: Rob Herring > --- > [...] > .../devicetree/bindings/power/supply/power-supply.yaml | 2 ++ > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-05 Thread Sebastian Reichel
ll take this thru the DT tree. > > [...] > .../bindings/power/supply/cw2015_battery.yaml | 2 ++ > .../bindings/power/supply/rohm,bd99954.yaml | 8 > [...] Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 2/2] power: bq25980: Add support for the BQ259xx family

2020-10-04 Thread Sebastian Reichel
Hi, On Mon, Aug 31, 2020 at 11:48:49AM -0500, Dan Murphy wrote: > Add support for the BQ25980, BQ25975 and BQ25960 family of flash > chargers. > > Signed-off-by: Dan Murphy > --- Thanks, queued (together with the binding) -- Sebastian > drivers/power/supply/Kconfig |9 + > driv

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-04 Thread Sebastian Reichel
Hi, On Sat, Oct 03, 2020 at 02:55:41PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 23:50 +0200, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > > > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel

Re: [PATCH 3/3] power: supply: Constify static w1_family_ops structs

2020-10-04 Thread Sebastian Reichel
1_family_ops i={}; > // > > Signed-off-by: Rikard Falkeborn > --- I suggest that this simply goes through the w1 tree together with the other patches: Acked-by: Sebastian Reichel -- Sebastian > drivers/power/supply/bq27xxx_battery_hdq.c | 2 +- > drivers/power/supply/ds2

Re: [PATCH 1/3] w1: Constify struct w1_family_ops

2020-10-04 Thread Sebastian Reichel
low > the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/w1/w1.c| 2 +- > include/linux/w1.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH][next] power: supply: fix spelling mistake "unprecise" -> "imprecise"

2020-10-03 Thread Sebastian Reichel
Hi, On Wed, Sep 02, 2020 at 11:16:56AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_info message. Fix it. > > Signed-off-by: Colin Ian King > --- Thanks, queued. -- Sebastian > drivers/power/supply/rn5t618_power.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Sebastian Reichel
Hi, On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote: > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote: > > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > > > When I cat some module parameters by sysfs, it displays as follows. > >

Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

2020-10-03 Thread Sebastian Reichel
Hi, On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote: > When I cat some module parameters by sysfs, it displays as follows. > It's better to add a newline for easy reading. > > root@syzkaller:~# cd /sys/module/test_power/parameters/ > root@syzkaller:/sys/module/test_power/parameters

Re: [PATCH 1/7] power: supply: bq24257: skip 'struct acpi_device_id' when !CONFIG_ACPI

2020-10-03 Thread Sebastian Reichel
Hi, Thanks for the cleanup, I queued all 7 patches. -- Sebastian On Fri, Sep 11, 2020 at 06:27:23PM +0200, Krzysztof Kozlowski wrote: > Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the > struct acpi_device_id becomes unused: > > drivers/power/supply/bq24257_charger.c:1155:

Re: [PATCH v5 0/7] power: supply: max17040 support compatible devices

2020-10-03 Thread Sebastian Reichel
Hi, On Tue, Sep 22, 2020 at 02:42:30PM +0300, Iskren Chernev wrote: > The max17040 fuel gauge is part of a family of 8 chips that have very > similar mode of operations and registers. > > This patch set adds: > - compatible strings for all supported devices and handles the minor > differences b

Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-10-03 Thread Sebastian Reichel
Hi Ricardo, On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote: > The BQ256XX family of devices are highly integrated buck chargers > for single cell batteries. > > Signed-off-by: Ricardo Rivera-Matos > > v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset()

Re: [PATCHv1] power: supply: document current direction

2020-10-03 Thread Sebastian Reichel
Hi, On Fri, Oct 02, 2020 at 06:23:03PM +0200, Andreas Kemnade wrote: > On Thu, 27 Aug 2020 16:02:48 +0200 > Sebastian Reichel wrote: > > > Currently the sign for CURRENT_NOW and CURRENT_AVG is a bit > > of a mess. There are basically 3 different ways battery fuel > >

Re: [PATCH v2 0/6] power: supply: bq27xxx: add bq34z100

2020-10-01 Thread Sebastian Reichel
Hi, On Sat, Sep 19, 2020 at 04:04:12PM +0200, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Squash patch 3 and 4 - cleanups, as suggested. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (6): > dt-bindings: power: bq27xxx: add bq34z100 > power: supply: bq27xxx: report "not chargi

Re: [PATCH v4 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2020-09-30 Thread Sebastian Reichel
Hi, You are leaking some resources, otherwise LGTM. On Wed, Sep 23, 2020 at 10:24:16AM -0500, Ricardo Rivera-Matos wrote: > [...] > +static int bq256xx_hw_init(struct bq256xx_device *bq) > +{ > + struct power_supply_battery_info bat_info = { }; > + int wd_reg_val = BQ256XX_WATCHDOG_DIS; >

Re: [PATCH] MAINTAINERS: Remove Andrew F Davis from list

2020-09-29 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2020 at 02:01:06PM +0200, Krzysztof Kozlowski wrote: > On Thu, 17 Sep 2020 at 22:02, Dan Murphy wrote: > > > > Andrews TI email is no longer valid and he indicated that it is > > OK to remove him from the MAINTAINERS file for the DMA HEAPS FRAMEWORK. > > > > For the BQ27xxx li

Re: [PATCH] power: fix spelling typo

2020-09-29 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2020 at 02:37:56PM +0800, Wang Qing wrote: > Modify the comment typo: "compliment" -> "complement". > > Signed-off-by: Wang Qing > --- Thanks, queued with modified patch subject. -- Sebastian > drivers/power/supply/ab8500_fg.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH] power: supply: fix spelling typo

2020-09-29 Thread Sebastian Reichel
Hi, On Sat, Sep 26, 2020 at 10:41:07AM +0800, Wang Qing wrote: > Modify the comment typo: "compliment" -> "complement". > > Signed-off-by: Wang Qing > --- Thanks, queued. -- Sebastian > drivers/power/supply/ds2780_battery.c | 6 +++--- > drivers/power/supply/ds2781_battery.c | 6 +++--- > 2

Re: [PATCH v3 1/2] dt-bindings: power: Convert ingenic,battery.txt to YAML

2020-09-29 Thread Sebastian Reichel
Hi, On Sat, Sep 26, 2020 at 07:35:28PM +0200, Artur Rojek wrote: > Convert the textual documentation of Device Tree bindings for the > Ingenic JZ47xx SoCs battery to YAML. > > Signed-off-by: Artur Rojek > --- Thanks, queued (both patches). -- Sebastian > > Changes: > v2: move introductio

Re: [PATCH v4 0/2] power: bq25890: IBAT compensation support

2020-09-29 Thread Sebastian Reichel
Hi, On Sat, Sep 26, 2020 at 09:05:31PM +0200, Michał Mirosław wrote: > These two patches add support for IBAT compensation feature of bq2589x > chargers. Thanks, queued. -- Sebastian > v4 fixed property names for the features and dropped other applied or rejected >patches > > Michał Mirosł

Re: [PATCH v2] MAINTAINERS: add Dan Murphy as TP LP8xxx drivers maintainer

2020-09-29 Thread Sebastian Reichel
regulator) drivers. > > > > > > > > > > Cc: Dan Murphy > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > Acked-by: Dan Murphy > > > > > > > Not sure who will pick this one up, but > > > Acked-by: Jonathan Cameron > > > > I guess whoever is first. :) > > This spans across systems but the common part is MFD, so maybe Lee - > > could you pick it up? > > Yes, I'll handle it. Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCHv2 3/4] Input: rotary-encoder - Use dev_err_probe

2020-09-10 Thread Sebastian Reichel
Hi Rob, On Wed, Sep 09, 2020 at 01:48:49PM -0600, Rob Herring wrote: > On Mon, Sep 7, 2020 at 2:40 PM Sebastian Reichel > wrote: > > > > Simplify driver a bit by making use of dev_err_probe. > > > > Signed-off-by: Sebastian Reichel > > --- > >

[PATCHv1] gpu: ipu-v3: Add 8 pixel alignment fix

2020-09-10 Thread Sebastian Reichel
kernel at default loglevel is: [1.876609] [drm] Initialized imx-drm 1.0.0 20120507 for display-subsystem on minor 1 After this patch the system boots fine and it is possible to start X.org and Weston from Debian testing. Suggested-by: Boris Brezillon Signed-off-by: Sebastian Reichel --- Hi

[PATCHv2 0/4] Rotary Encoder Push Button Support

2020-09-07 Thread Sebastian Reichel
/ -- Sebastian Mylène Josserand (1): Input: rotary-encoder - Add gpio as push button Sebastian Reichel (3): dt-bindings: input: Convert rotary-encoder bindings to schema Input: rotary-encoder - Fix steps property reading Input: rotary-encoder - Use dev_err_probe .../bindings/input/rotary-encoder.txt

[PATCHv2 2/4] Input: rotary-encoder - Fix steps property reading

2020-09-07 Thread Sebastian Reichel
The DT binding specifies 24 being used by default, but driver initializes to 0. The steps variable will be used for a modulo operation at a later step, so do not allow 0 (does not make sense in any case). Signed-off-by: Sebastian Reichel --- drivers/input/misc/rotary_encoder.c | 5 + 1 file

[PATCHv2 1/4] dt-bindings: input: Convert rotary-encoder bindings to schema

2020-09-07 Thread Sebastian Reichel
Convert rotary-encoder bindings to YAML schema. Signed-off-by: Sebastian Reichel --- .../bindings/input/rotary-encoder.txt | 50 - .../bindings/input/rotary-encoder.yaml| 100 ++ 2 files changed, 100 insertions(+), 50 deletions(-) delete mode 100644

[PATCHv2 4/4] Input: rotary-encoder - Add gpio as push button

2020-09-07 Thread Sebastian Reichel
eys). Signed-off-by: Mylène Josserand [code cleanup to current standards and renamed some properties] Signed-off-by: Sebastian Reichel --- .../bindings/input/rotary-encoder.yaml| 21 + drivers/input/misc/rotary_encoder.c | 43 +++ 2 files changed, 64 inserti

[PATCHv2 3/4] Input: rotary-encoder - Use dev_err_probe

2020-09-07 Thread Sebastian Reichel
Simplify driver a bit by making use of dev_err_probe. Signed-off-by: Sebastian Reichel --- drivers/input/misc/rotary_encoder.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c index

Re: [PATCH] drivers: power: axp20x-battery: support setting charge_full_design

2020-08-28 Thread Sebastian Reichel
Hi, On Wed, Jul 29, 2020 at 11:49:13AM +0100, Jack Mitchell wrote: > Signed-off-by: Jack Mitchell > --- ^ missing long description Also the patch does not apply and needs to be rebased. -- Sebastian > drivers/power/supply/axp20x_battery.c | 39 +++ > 1 file changed, 3

Re: [PATCH v3 1/6] power: supply: max17040: Use regmap i2c

2020-08-28 Thread Sebastian Reichel
Hi, On Wed, Jun 24, 2020 at 06:56:28PM +0300, Iskren Chernev wrote: > Rewrite i2c operations from i2c client read/write to regmap i2c. As > a result, most private functions now accept the private driver data > instead of an i2c client pointer. > > Signed-off-by: Iskren Chernev > --- This still

Re: [PATCH 00/10] power: supply: Charger-manager improvements

2020-08-28 Thread Sebastian Reichel
Hi, On Thu, May 14, 2020 at 04:04:25PM -0700, Jonathan Bakker wrote: > Charger-manager is a virtual driver for unifying chargers, fuel gauges, > extcon devices, and a thermal device into a battery management system. > > Unfortunately, it has been broken since commit 830ae442202e ("extcon: > Remov

Re: [PATCH v3] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-28 Thread Sebastian Reichel
Hi, On Fri, Aug 28, 2020 at 01:49:06PM +0200, Andreas Kemnade wrote: > Both chips have charger and a fuel gauge. > > This adds basic support for displaying the state of the battery and the > input power, settings are not modified. There are some defaults set via > OTP. > > Charging also starts a

Re: [PATCH v4] power: supply: sbs-battery: don't assume i2c errors as battery disconnect

2020-08-28 Thread Sebastian Reichel
Hi, On Fri, Aug 28, 2020 at 12:36:26PM +0800, Ikjoon Jang wrote: > Current sbs-battery considers all smbus errors as disconnection events > when battery-detect pin isn't supplied, and restored to present state back > when any successful transaction is made. > > This can lead to unwanted state cha

Re: [PATCHv1 0/2] power: supply: smb347-charger: Cleanups

2020-08-28 Thread Sebastian Reichel
Hi, On Fri, Aug 28, 2020 at 10:47:21AM +0300, Dmitry Osipenko wrote: > 26.08.2020 17:41, Sebastian Reichel пишет: > > Please check the following cleanup patches for smb347 driver > > do not break functionality on your Nexus 7. > > > > -- Sebastian > > >

Re: [PATCH] power: pm2301_charger: fix spelling mistake "chargind" -> "charging"

2020-08-27 Thread Sebastian Reichel
Hi, On Wed, Aug 05, 2020 at 11:38:57AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- Thanks, queued. -- Sebastian > drivers/power/supply/pm2301_charger.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH v3 2/2] power: supply: sbs-battery: don't assume i2c errors as battery disconnect

2020-08-27 Thread Sebastian Reichel
Hi, On Thu, Aug 13, 2020 at 01:10:08PM +0800, Ikjoon Jang wrote: > Current sbs-battery considers all smbus errors as disconnection events > when battery-detect pin isn't supplied, and restored to present state back > when any successful transaction is made. > > This can lead to unlimited state ch

Re: [PATCH v3 1/2] power: supply: sbs-battery: combine get_presence_and_health

2020-08-27 Thread Sebastian Reichel
Hi, On Thu, Aug 13, 2020 at 01:10:07PM +0800, Ikjoon Jang wrote: > This patch enables calling sbs_get_battery_presence_and_health() > without checking its chip type. No functional changes. > > Signed-off-by: Ikjoon Jang > --- Thanks, queued. -- Sebastian > drivers/power/supply/sbs-battery.c

Re: [PATCH v2] power: supply: sbs-battery: remove unused enable_detection flags

2020-08-27 Thread Sebastian Reichel
Hi, On Tue, Aug 11, 2020 at 12:41:41PM +0800, Ikjoon Jang wrote: > Remove unused enable_detection flag which is always true after > the device is proved. > > Signed-off-by: Ikjoon Jang > --- > v2: initialize work queue before registering power supply > --- Thanks, queued. -- Sebastian > driv

[PATCHv1] power: supply: document current direction

2020-08-27 Thread Sebastian Reichel
-case basis. The 'negative value = battery discharging' has been choosen, since there are only very few drivers doing it the other way around. Signed-off-by: Sebastian Reichel --- Documentation/ABI/testing/sysfs-class-power | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Sebastian Reichel
Hi, On Wed, Aug 26, 2020 at 08:28:34PM +0200, Andreas Kemnade wrote: > On Wed, 26 Aug 2020 19:48:17 +0200 > Sebastian Reichel wrote: > > On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > > > [...] > > > +static int rn5t618_battery_current_now(s

Re: [PATCH 1/2] power: supply: Add support for RN5T618/RC5T619 charger and fuel gauge

2020-08-26 Thread Sebastian Reichel
Hi, Driver looks mostly good. On Sat, Aug 15, 2020 at 06:56:09PM +0200, Andreas Kemnade wrote: > [...] > +static int rn5t618_battery_current_now(struct rn5t618_power_info *info, > +union power_supply_propval *val) > +{ > + u16 res; > + int ret; > + > +

Re: [PATCH 5/5] power: supply: lego_ev3: Simplify with dev_err_probe()

2020-08-26 Thread Sebastian Reichel
Hi, On Wed, Aug 26, 2020 at 10:11:02AM -0500, David Lechner wrote: > On 8/26/20 9:48 AM, Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v1 1/1] power: supply: add wireless power_supply_type

2020-08-26 Thread Sebastian Reichel
Hi, On Thu, Aug 13, 2020 at 11:34:08AM -0700, Guru Das Srinagesh wrote: > From: Subbaraman Narayanamurthy > > Currently, power_supply framework supports only Battery, UPS, > Mains and USB power_supply_type. Add wireless power_supply_type > so that the drivers which supports wireless can register

[PATCHv1 1/2] power: supply: smb347-charger: Drop pdata support

2020-08-26 Thread Sebastian Reichel
There are no platforms using the pdata support, so let's drop it to simplify the driver. Signed-off-by: Sebastian Reichel --- drivers/power/supply/smb347-charger.c | 287 ++ include/linux/power/smb347-charger.h | 114 -- 2 files changed, 159 insertions(+)

[PATCHv1 0/2] power: supply: smb347-charger: Cleanups

2020-08-26 Thread Sebastian Reichel
Hi Dmitry, Please check the following cleanup patches for smb347 driver do not break functionality on your Nexus 7. -- Sebastian Sebastian Reichel (2): power: supply: smb347-charger: Drop pdata support power: supply: smb347-charger: Use generic property framework drivers/power/supply

<    1   2   3   4   5   6   7   8   9   10   >