[PATCHv2 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support

2020-05-19 Thread Sebastian Reichel
This adds support for EXC80H60 and EXCH84 controllers, which use a different event type id and have two extra bits for the resolution (so the maximum is 16K instead of 4K). Signed-off-by: Sebastian Reichel --- .../bindings/input/touchscreen/exc3000.yaml | 5 +- drivers/input/touchscreen

[PATCHv2 2/5] Input: EXC3000: switch to i2c's probe_new API

2020-05-19 Thread Sebastian Reichel
Switch to the "new" I2C probe API. Signed-off-by: Sebastian Reichel --- drivers/input/touchscreen/exc3000.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c index e007e2e8f626..555a14305

[PATCHv2 4/5] Input: EXC3000: Add support to query model and fw_version

2020-05-19 Thread Sebastian Reichel
not work. Sending the command and waiting for some time is also not an option, since there might be touch events in the mean time. Last but not least we do not cache the results, since this interface can be used to check the I2C communication is still working as expected. Signed-off-by: Sebastian

[PATCHv2 1/5] dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to json-schema

2020-05-19 Thread Sebastian Reichel
Convert the EETI EXC3000 binding to DT schema format using json-schema Signed-off-by: Sebastian Reichel --- .../bindings/input/touchscreen/exc3000.txt| 26 - .../bindings/input/touchscreen/exc3000.yaml | 53 +++ 2 files changed, 53 insertions(+), 26 deletions

[PATCHv2 0/5] EXC3000 Updates

2020-05-19 Thread Sebastian Reichel
Touch Screen 00_T6 Orion_1320 Thanks in advance for looking at the patches, -- Sebastian [PATCHv1] https://lore.kernel.org/linux-input/20191107181010.17211-1-sebastian.reic...@collabora.com/ Sebastian Reichel (5): dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to json-schema

Re: [not urgent] ROHM PMIC/Charger IC driver maintenance.

2020-05-18 Thread Sebastian Reichel
ER R: Andrew F. Davis F: drivers/power/supply/bq27xxx_battery.c F: drivers/power/supply/bq27xxx_battery_i2c.c F: include/linux/power/bq27xxx_battery.h -------- It will result in get_maintainer.pl to output this: $ ./scripts/get_main

Re: [PATCHv1 03/19] power: supply: core: add manufacture date properties

2020-05-15 Thread Sebastian Reichel
Hi, On Fri, May 15, 2020 at 03:47:32PM +0100, Emil Velikov wrote: > On 2020/05/13, Sebastian Reichel wrote: > > Some smart batteries store their manufacture date, which is > > useful to identify the battery and/or to know about the cell > > quality. > > >

[PATCHv1] ARM: dts/imx6q-bx50v3: Set display interface clock parents

2020-05-14 Thread Sebastian Reichel
of IMX6QDL_CLK_PLL2_PFD2_396M originally chosen by Robert Beckett to avoid affecting eMMC clock by DRM atomic updates] Signed-off-by: Ian Ray [Squash Robert's and Ian's commits for bisectability, update patch description and add stable tag] Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/imx6q-b450v3.dts | 7

[PATCHv1 09/19] power: supply: sbs-battery: add POWER_SUPPLY_PROP_CURRENT_AVG support

2020-05-13 Thread Sebastian Reichel
Expose averaged current information, which is part of the SBS standard and should be supported by all batteries. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/sbs

[PATCHv1 02/19] power: supply: core: add capacity error margin property

2020-05-13 Thread Sebastian Reichel
Add a property for reporting the error margin expected by fuel gauge chips. Signed-off-by: Sebastian Reichel --- Documentation/ABI/testing/sysfs-class-power | 15 +++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 1 + 3 files

[PATCHv1 04/19] power: supply: core: add POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED

2020-05-13 Thread Sebastian Reichel
Some battery fuel gauges know when the battery needs to be recalibrated before providing usable values. This should be reported via the health property. Signed-off-by: Sebastian Reichel --- Documentation/ABI/testing/sysfs-class-power | 2 +- drivers/power/supply/power_supply_sysfs.c | 1

[PATCHv1 01/19] kobject: increase allowed number of uevent variables

2020-05-13 Thread Sebastian Reichel
SBS battery driver exposes 32 power supply properties now, which will result in uevent failure on (un)plugging the battery. Other drivers (e.g. bq27xxx) are also coming close to this limit, so increase it. Signed-off-by: Sebastian Reichel --- include/linux/kobject.h | 2 +- 1 file changed, 1

[PATCHv1 00/19] Improve SBS battery support

2020-05-13 Thread Sebastian Reichel
POWER_SUPPLY_MANUFACTURE_YEAR=2017 POWER_SUPPLY_MANUFACTURE_MONTH=7 POWER_SUPPLY_MANUFACTURE_DAY=3 POWER_SUPPLY_MANUFACTURER=UR18650A POWER_SUPPLY_MODEL_NAME=GEHC -- Sebastian Jean-Francois Dagenais (1): power: supply: sbs-battery: add ability to disable charger broadcasts Sebastian Reichel (18): kobject: increase

[PATCHv1 06/19] power: supply: sbs-battery: add POWER_SUPPLY_PROP_CAPACITY_ERROR_MARGIN support

2020-05-13 Thread Sebastian Reichel
Add support for reporting the MaxError register from battery fuel gauges following the smart battery standard. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power

[PATCHv1 07/19] power: supply: sbs-battery: simplify read_read_string_data

2020-05-13 Thread Sebastian Reichel
ementation does not properly handle packet error checking (PEC). This change requires, that I2C bus drivers support I2C_M_RECV_LEN or directly provide the SMBus API to access device manufacturer and model name. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-batt

[PATCHv1 11/19] power: supply: sbs-battery: add POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT/VOLTAGE_MAX support

2020-05-13 Thread Sebastian Reichel
Expose maximum charge current/voltage information requested by the battery. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index

[PATCHv1 12/19] power: supply: sbs-battery: add MANUFACTURE_DATE support

2020-05-13 Thread Sebastian Reichel
Expose the battery's manufacture date to userspace. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index

[PATCHv1 19/19] dt-bindings: power: sbs-battery: Convert to yaml

2020-05-13 Thread Sebastian Reichel
Convert sbs-battery bindings to YAML. Signed-off-by: Sebastian Reichel --- .../power/supply/sbs,sbs-battery.yaml | 83 +++ .../bindings/power/supply/sbs_sbs-battery.txt | 30 --- 2 files changed, 83 insertions(+), 30 deletions(-) create mode 100644 Documentation

[PATCHv1 14/19] power: supply: sbs-battery: fix idle battery status

2020-05-13 Thread Sebastian Reichel
A battery, that is neither charged, nor discharged is not always Full. If the charger is disabled for other reasons it might simply be idle and should be marked accordingly. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCHv1 05/19] power: supply: sbs-battery: Add TI BQ20Z65 support

2020-05-13 Thread Sebastian Reichel
Add support for BQ20Z65 manufacturer data to the sbs-battery driver. Implementation has been verified using the public TRM available from [0] and tested using a GE Flex 3S2P battery. [0] http://www.ti.com/lit/pdf/sluu386 Signed-off-by: Sebastian Reichel --- .../bindings/power/supply/sbs_sbs

[PATCHv1 13/19] power: supply: sbs-battery: add POWER_SUPPLY_HEALTH_CALIBRATION_REQUIRED support

2020-05-13 Thread Sebastian Reichel
Add support for reporting the SBS battery's condition flag to userspace using the new "Calibration required" health status. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-)

[PATCHv1 16/19] power: supply: sbs-battery: switch from of_property_* to device_property_*

2020-05-13 Thread Sebastian Reichel
Switch from DT specific of_property_* API to generic and more modern device_property_* API. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers

[PATCHv1 03/19] power: supply: core: add manufacture date properties

2020-05-13 Thread Sebastian Reichel
Some smart batteries store their manufacture date, which is useful to identify the battery and/or to know about the cell quality. Signed-off-by: Sebastian Reichel --- Documentation/ABI/testing/sysfs-class-power | 28 + drivers/power/supply/power_supply_sysfs.c | 3

[PATCHv1 08/19] power: supply: sbs-battery: add PEC support

2020-05-13 Thread Sebastian Reichel
generations. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 72 -- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index a9a1d28dabbe..ab774d491269 100644

[PATCHv1 15/19] power: supply: sbs-battery: add ability to disable charger broadcasts

2020-05-13 Thread Sebastian Reichel
y is first seen on the bus. Signed-off-by: Jean-Francois Dagenais [rebased code] Signed-off-by: Sebastian Reichel --- .../bindings/power/supply/sbs_sbs-battery.txt | 2 ++ drivers/power/supply/sbs-battery.c| 29 +++ 2 files changed, 31 insertions(+) diff --git a/Doc

[PATCHv1 18/19] power: supply: sbs-battery: constify power-supply property array

2020-05-13 Thread Sebastian Reichel
Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index f0392be350eb..f4f73e669460 100644 --- a/drivers/power/supply/sbs-battery.c

[PATCHv1 10/19] power: supply: sbs-battery: Improve POWER_SUPPLY_PROP_TECHNOLOGY support

2020-05-13 Thread Sebastian Reichel
This reads the battery chemistry from the battery chip instead of incorrectly hardcoding the type to be Li-Ion. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 43 -- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCHv1 17/19] power: supply: sbs-battery: switch to i2c's probe_new

2020-05-13 Thread Sebastian Reichel
sbs-battery does not use the ID parameter, so switch to i2c's probe_new API. Signed-off-by: Sebastian Reichel --- drivers/power/supply/sbs-battery.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c

[PATCHv1 1/2] power: supply: gpio-charger: add charge-current-limit feature

2020-05-13 Thread Sebastian Reichel
Add new charge-current-limit feature to gpio-charger. This also makes the online status GPIO optional, since hardware might only expose the charge-current-limit feature and there is no good reason to have it mandatory now that different GPIOs are supported. Signed-off-by: Sebastian Reichel

[PATCHv1 2/2] dt-bindings: power: supply: gpio-charger: convert to yaml

2020-05-13 Thread Sebastian Reichel
Convert the gpio-charger bindings from text format to new YAML based representation. Signed-off-by: Sebastian Reichel --- .../bindings/power/supply/gpio-charger.txt| 38 -- .../bindings/power/supply/gpio-charger.yaml | 75 +++ 2 files changed, 75 insertions(+), 38

Re: [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()

2020-05-12 Thread Sebastian Reichel
Hi Wolfram, On Tue, May 12, 2020 at 06:27:23PM +0200, Wolfram Sang wrote: > On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote: > > Move away from the deprecated API in this comment. > > > > Signed-off-by: Wolfram Sang > > Can we have this now so I can remove the old API in the next

Re: [PATCH] hwmon: da9052: Synchronize access with mfd

2020-05-12 Thread Sebastian Reichel
Hi Guenter, On Mon, May 11, 2020 at 09:51:25AM -0700, Guenter Roeck wrote: > On 5/11/20 4:02 AM, Sebastian Reichel wrote: > > From: Samu Nuutamo > > > > When tsi-as-adc is configured it is possible for in7[0123]_input read to > > return an incorrect value if a concu

Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-11 Thread Sebastian Reichel
Hi, On Mon, May 11, 2020 at 09:55:11AM -0500, Dan Murphy wrote: > On 5/11/20 9:57 AM, Sebastian Reichel wrote: > > On Mon, May 11, 2020 at 09:29:59AM -0500, Dan Murphy wrote: > > > On 5/11/20 9:32 AM, Sebastian Reichel wrote: > > > > On Mon, May 11, 2020 at 07:2

Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-11 Thread Sebastian Reichel
Hi, On Mon, May 11, 2020 at 09:29:59AM -0500, Dan Murphy wrote: > On 5/11/20 9:32 AM, Sebastian Reichel wrote: > > On Mon, May 11, 2020 at 07:25:06AM -0500, Dan Murphy wrote: > > > On 5/10/20 11:17 AM, Sebastian Reichel wrote: > > > > This needs is missing the power-

Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-11 Thread Sebastian Reichel
Hi, On Mon, May 11, 2020 at 07:25:06AM -0500, Dan Murphy wrote: > On 5/10/20 11:17 AM, Sebastian Reichel wrote: > > This needs is missing the power-supplies property. The N900 DT > > contains a bq27200 referencing the charger, so it should fail the DT > > check without the

[PATCHv3 4/5] ASoC: da7213: move set_pll to codec level

2020-05-11 Thread Sebastian Reichel
Move set_pll function to component level, so that it can be used at both component and DAI level. Reviewed-by: Adam Thomson Signed-off-by: Sebastian Reichel --- sound/soc/codecs/da7213.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/da7213.c b

[PATCHv3 3/5] ASoC: da7213: move set_sysclk to codec level

2020-05-11 Thread Sebastian Reichel
Move set_sysclk function to component level, so that it can be used at both component and DAI level. Reviewed-by: Adam Thomson Signed-off-by: Sebastian Reichel --- sound/soc/codecs/da7213.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs

[PATCHv3 1/5] ASoC: da7213: Add da7212 DT compatible

2020-05-11 Thread Sebastian Reichel
This adds a compatible for da7212. It's handled exactly the same way as DA7213 and follows the ACPI bindings. Signed-off-by: Sebastian Reichel --- PATCHv2 -> PATCHv3: fixed typo in DT binding file's compatible string --- Documentation/devicetree/bindings/sound/da7213.txt | 4 ++-- sound/

[PATCHv3 0/5] ASoC: da7213: support for usage with simple-card

2020-05-11 Thread Sebastian Reichel
s not enabled when PLL is configured manually * update clock patch, so that automatic PLL is disabled when the device is suspended * update clock patch, so that automatic PLL is configured into bypass mode when possible -- Sebastian Sebastian Reichel (5): ASoC: da7213: Add da721

[PATCHv3 2/5] ASoC: da7213: Add regulator support

2020-05-11 Thread Sebastian Reichel
This adds support for most regulators of da7212 for improved power management. The only thing skipped was the speaker supply, which has some undocumented dependencies. It's supposed to be either always-enabled or always-disabled. Reviewed-by: Adam Thomson Signed-off-by: Sebastian Reichel

[PATCHv3 5/5] ASoC: da7213: add default clock handling

2020-05-11 Thread Sebastian Reichel
This adds default clock/PLL configuration to the driver for usage with generic drivers like simple-card for usage with a fixed rate clock. Signed-off-by: Sebastian Reichel --- sound/soc/codecs/da7213.c | 76 --- sound/soc/codecs/da7213.h | 2 ++ 2 files

[PATCH] hwmon: da9052: Synchronize access with mfd

2020-05-11 Thread Sebastian Reichel
for synchronization. Switch hwmon to use the same lock as mfd when accessing the TSI channel. Fixes: 4f16cab19a3d5 ("hwmon: da9052: Add support for TSI channel") Signed-off-by: Samu Nuutamo [rebase to current master, reword commit message slightly] Signed-off-by: Sebastian Reichel --

Re: [PATCH 1/3] power: supply: max17040: Correct voltage reading

2020-05-10 Thread Sebastian Reichel
Hi, On Mon, May 04, 2020 at 03:12:58PM -0700, Jonathan Bakker wrote: > According to the datasheet available at (1), the bottom four > bits are always zero and the actual voltage is 1.25x this value > in mV. Since the kernel API specifies that voltages should be in > uV, it should report 1250x

Re: [PATCH 3/3] power: supply: max17040: Set rcomp value

2020-05-10 Thread Sebastian Reichel
Hi, On Mon, May 04, 2020 at 03:13:00PM -0700, Jonathan Bakker wrote: > According to the datasheet (1), the rcomp parameter can > vary based on the typical operating temperature and the > battery chemistry. If provided, make sure we set it after > we reset the chip on boot. > > 1)

Re: [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()

2020-05-10 Thread Sebastian Reichel
Please adviece me if this patch is not the way to go. > > Oh, and I am really sorry for the trouble. I saw I had regulators=y > in all of my compilations due to some pincontrol dependencies. So > linear-ranges was not built as module in any of my test compilations :( > > Thanks for testing

Re: [PATCH 3/3] power: charger: max14577: Add proper dt-compatible strings

2020-05-10 Thread Sebastian Reichel
Hi, On Thu, Feb 20, 2020 at 03:51:27PM +0100, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. > >

Re: [PATCH 6/9] power: supply: smb347-charger: Support SMB345 and SMB358

2020-05-10 Thread Sebastian Reichel
Hi, On Sun, Mar 29, 2020 at 06:21:25PM +0200, David Heidelberg wrote: > Tested SMB345 on Nexus 7 2013. Works. > > Based on: > - https://patchwork.kernel.org/patch/4922431/ > - https://patchwork.ozlabs.org/patch/666877/ > > Signed-off-by: David Heidelberg > --- LGTM. -- Sebastian >

Re: [PATCH 3/9] power: supply: smb347-charger: Use resource-managed API

2020-05-10 Thread Sebastian Reichel
Hi, On Sun, Mar 29, 2020 at 06:15:46PM +0200, David Heidelberg wrote: > Simplify code, more convenient to use with Device Tree. > > Reviewed-by: Dmitry Osipenko > Signed-off-by: David Heidelberg > --- Generally I like this change a lot, but it changes the removal order, so that the IRQ is

Re: [PATCH 1/9] power: supply: smb347-charger: IRQSTAT_D is volatile

2020-05-10 Thread Sebastian Reichel
Hi, On Sun, Mar 29, 2020 at 06:15:44PM +0200, David Heidelberg wrote: > From: Dmitry Osipenko > > Fix failure when USB cable is connected: > smb347 2-006a: reading IRQSTAT_D failed > > Fixes: 1502cfe19bac ("smb347-charger: Fix battery status reporting logic for > charger faults") > >

Re: [PATCH 2/9] power: supply: smb347-charger: Add delay before getting IRQSTAT

2020-05-10 Thread Sebastian Reichel
Hi, On Sun, Mar 29, 2020 at 06:15:45PM +0200, David Heidelberg wrote: > This delay-fix is picked up from downstream driver, > we measured that 25 - 35 ms delay ensure that we get required data. > > Tested on SMB347 on Nexus 7 2012. Otherwise IRQSTAT_E fails to provide > correct information. > >

Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-10 Thread Sebastian Reichel
icetree/bindings/power/supply/bq27xxx.yaml > b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > new file mode 100644 > index ..54f497c291f2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > @@ -0,0 +1,86 @@ > +# SPDX-Lice

Re: [PATCH v12 00/11] Support ROHM BD99954 charger IC

2020-05-10 Thread Sebastian Reichel
Hi, On Fri, May 08, 2020 at 06:38:17PM +0300, Matti Vaittinen wrote: > Please note that this series should be applied to two trees. Patches > 1-4 (or 1-5 as suggested by Sebastian) should go to regulator tree. > Perhaps Mark can provide an immutable branch to Sebastian? Rest of the > patches can

Re: [PATCH v12 00/11] Support ROHM BD99954 charger IC

2020-05-09 Thread Sebastian Reichel
Hi, On Fri, May 08, 2020 at 06:20:24PM +0100, Mark Brown wrote: > On Fri, May 08, 2020 at 06:38:17PM +0300, Matti Vaittinen wrote: > > Please note that this series should be applied to two trees. Patches > > 1-4 (or 1-5 as suggested by Sebastian) should go to regulator tree. > > Perhaps Mark can

Re: [PATCH V2] power: supply: lp8788: Fix an error handling path in 'lp8788_charger_probe()'

2020-05-09 Thread Sebastian Reichel
Hi, On Sat, May 09, 2020 at 10:23:23AM +0200, Christophe JAILLET wrote: > In the probe function, in case of error, resources allocated in > 'lp8788_setup_adc_channel()' must be released. > > This can be achieved easily by using the devm_ variant of > 'iio_channel_get()'. > This has the extra

Re: [PATCH -next] power: reset: ltc2952: remove set but used variable

2020-05-09 Thread Sebastian Reichel
Hi, On Sat, May 09, 2020 at 06:36:11PM +0800, Hongbo Yao wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable > ‘overruns’ set but not used [-Wunused-but-set-variable] > unsigned long overruns; > > Reported-by: Hulk Robot >

Re: [PATCH 4/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx

2020-05-08 Thread Sebastian Reichel
Hi, On Wed, Apr 15, 2020 at 06:30:02PM +0300, Dmitry Osipenko wrote: > 15.04.2020 17:27, Rob Herring пишет: > > On Fri, Apr 10, 2020 at 2:02 PM Dmitry Osipenko wrote: > >> > >> 10.04.2020 19:49, Rob Herring пишет: > >> ... > + summit,max-chg-curr: > +description: Maximum current

Re: [PATCH v2 0/4] Cleanup power_supply_sysfs.c

2020-05-08 Thread Sebastian Reichel
Hi, Thanks for this nice patchset, I queued all patches to power-supply's for-next branch. Next time please rebase to latest state of for-next branch before sending new patch versions. I had to fix patch context to apply them because of de46e0289310 ("power: supply: core: reduce

Re: [PATCH v2 1/3] dt-bindings: power: reset: Convert syscon-reboot-mode to DT schema

2020-05-08 Thread Sebastian Reichel
entation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml > b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml > new file mode 100644 > index ..9b1ffceefe3d > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mo

Re: [PATCH -next] power/supply/cw2015: Make some symbols static

2020-05-08 Thread Sebastian Reichel
Hi, On Wed, May 06, 2020 at 09:49:26PM +0200, Tobias Schramm wrote: > > Fix the following warning: > > > > drivers/power/supply/cw2015_battery.c:96:5: warning: > > 'cw_update_profile' was not declared. Should it be static? > > drivers/power/supply/cw2015_battery.c:712:1: warning: > >

Re: [PATCH] power: supply: lp8788: Fix an error handling path in 'lp8788_charger_probe()'

2020-05-08 Thread Sebastian Reichel
Hi, Please change the driver to call devm_iio_channel_get() instead of iio_channel_get() and drop the lp8788_release_adc_channel() function. -- Sebastian On Fri, May 08, 2020 at 09:11:50AM +0200, Christophe JAILLET wrote: > In case of error, resources allocated in 'lp8788_setup_adc_channel()'

Re: [PATCH v2 09/11] power: bq25890: implement INPUT_CURRENT_LIMIT property

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:13PM +0200, Michał Mirosław wrote: > Report REG00.IINLIM value as INPUT_CURRENT_LIMIT property. > > Signed-off-by: Michał Mirosław > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/bq25890_charger.c | 11 +++ &g

Re: [PATCH v2 08/11] power: bq25890: implement PRECHARGE_CURRENT property

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:13PM +0200, Michał Mirosław wrote: > Report configured precharge current. > > Signed-off-by: Michał Mirosław > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/bq25890_charger.c | 5 + > 1 file changed, 5 inser

Re: [PATCH v2 07/11] power: bq25890: implement CHARGE_TYPE property

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:12PM +0200, Michał Mirosław wrote: > Report charging type based on recently read state. > > Signed-off-by: Michał Mirosław > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/bq25890_charger.c | 13 + >

Re: [PATCH v2 06/11] power: bq25890: update state on property read

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:12PM +0200, Michał Mirosław wrote: > Edge interrupts from the charger may be lost or stuck in fault mode > since probe(). Check if something changed everytime userspace wants > some data. > > Signed-off-by: Michał Mirosław > --- Reviewed-by:

Re: [PATCH v2 04/11] power: bq25890: protect view of the chip's state

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:11PM +0200, Michał Mirosław wrote: > Extend bq->lock over whole updating of the chip's state. Might get > useful later for switching ADC modes correctly. > > Signed-off-by: Michał Mirosław > --- Thanks, queued. -- Sebastian >

Re: [PATCH v2 05/11] power: bq25890: fix ADC mode configuration

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:11PM +0200, Michał Mirosław wrote: > Datasheet describes two modes for reading ADC measurements: > 1. continuous, 1 Hz - enabled and started by CONV_RATE bit > 2. one-shot - triggered by CONV_START bit > > In continuous mode, CONV_START is read-only and

Re: [PATCH v2 01/11] power: bq25890: remove redundant I2C bus check

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:10PM +0200, Michał Mirosław wrote: > regmap initialization will check I2C adapter functionality. > Remove redundant check in the driver. > > Signed-off-by: Michał Mirosław > --- Thanks, queued. -- Sebastian > drivers/power/supply/bq25890_charger.c | 6

Re: [PATCH v2 03/11] power: bq25890: make property table const

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:10PM +0200, Michał Mirosław wrote: > Property list should not change, so mark it const. > > Signed-off-by: Michał Mirosław > --- Thanks, queued. -- Sebastian > drivers/power/supply/bq25890_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v2 02/11] power: bq25890: simplify chip name property getter

2020-05-03 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 05:21:10PM +0200, Michał Mirosław wrote: > Driver rejects unknown chips early in the probe(), so when > bq25890_power_supply_get_property() is made reachable, bq->chip_version > will already be set to correct value - there is no need to check > it again. > >

Re: [RESEND v6 0/3] Add support for CellWise cw2015 fuel gauge

2020-05-03 Thread Sebastian Reichel
Hi, On Tue, Apr 14, 2020 at 02:52:05PM +0200, Tobias Schramm wrote: > This patchset adds support for the CellWise cw2015 fuel gauge. > > The CellWise cw2015 fuel gauge is a shuntless, single-cell Li-Ion fuel > gauge. It is used in the pine64 Pinebook Pro laptop. > > This is just a resend of v6

Re: [PATCH v10 00/11] Support ROHM BD99954 charger IC

2020-05-03 Thread Sebastian Reichel
or styling to BD70528 power/supply driver as suggested by Andy > > Changelog v9: > General: >- rebased on top of v5.7-rc1 >- re-ordered patches as suggested by Sebastian Reichel >- added few acks > BD99954 driver: >- Moved bd99954-charger.h to

Re: [RESEND PATCH v5 0/3] BQ25150/155 Charger

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 01:09:13PM -0500, Ricardo Rivera-Matos wrote: > On 5/1/20 12:55 PM, Dan Murphy wrote: > > Sebastian > > > > On 5/1/20 12:24 PM, Sebastian Reichel wrote: > > > Hi, > > > > > > I don't see any PATCHv5 (with or without

Re: [PATCH 4/4] power_supply: Add power supply type property to uevent env

2020-05-02 Thread Sebastian Reichel
plicitly add it to the udev env. > > Signed-off-by: Mathew King > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/power_supply_sysfs.c | 61 ++- > 1 file changed, 37 insertions(+), 24 deletions(-) > > diff --git a/drivers/power/supply/

Re: [PATCH 3/4] power_supply: Add a macro that maps enum properties to text values

2020-05-02 Thread Sebastian Reichel
n > array with the text values named POWER_SUPPLY_${PROPNAME}_TEXT and > adding POWER_SUPPLY_ENUM_ATTR(${PROPNAME}) to the power_supply_attrs > array. > > Signed-off-by: Mathew King > --- nice cleanup :) Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/sup

Re: [PATCH v5 3/3] power: supply: bq25150 introduce the bq25150

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 12:51:18PM -0500, Dan Murphy wrote: > From: Ricardo Rivera-Matos > > Introduce the bq2515x family of chargers. > > Description: > The BQ2515X family of devices are highly integrated battery management > ICs that integrate the most common functions for wearbale

Re: [PATCH v5 2/3] Add the bindings for the bq25150 and bq25155 500mA charging ICs from Texas Instruments.

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 12:51:17PM -0500, Dan Murphy wrote: > From: Ricardo Rivera-Matos > > Description: > The BQ2515X family of devices are highly integrated battery management > ICs that integrate the most common functions for wearbale devices > namely a charger, an output voltage rail,

Re: [PATCH v5 1/3] power_supply: Add additional health properties to the header

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 12:51:16PM -0500, Dan Murphy wrote: > Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum. > > Tested-by: Guru Das Srinagesh > Signed-off-by: Dan Murphy > --- What is going on? Ricardo wrote, that he added the JEITA spec reference to the commit message.

Re: [PATCH] power: supply: fix memory leaks (v2)

2020-05-02 Thread Sebastian Reichel
Hi, On Sat, May 02, 2020 at 06:33:38PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function power_supply_add_hwmon_sysfs(), psyhw->props is > allocated by bitmap_zalloc(). But this pointer is not deallocated > when devm_add_action fail, which lead to a memory leak bug. To fix >

Re: [PATCH v4 2/4] power: supply: core: add input voltage/current measurements

2020-05-02 Thread Sebastian Reichel
Hi, On Sun, May 03, 2020 at 01:11:58AM +0200, Michał Mirosław wrote: > On Sun, May 03, 2020 at 12:45:26AM +0200, Michał Mirosław wrote: > > On Sun, May 03, 2020 at 12:23:49AM +0200, Sebastian Reichel wrote: > > > On Fri, May 01, 2020 at 05:11:18PM +0200, Mic

Re: [PATCH] power: supply: fix memory leaks

2020-05-02 Thread Sebastian Reichel
Hi, On Sat, May 02, 2020 at 04:10:56PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function power_supply_add_hwmon_sysfs(), psyhw->props is > allocated by bitmap_zalloc(). But this pointer is not deallocated > in several error paths, which lead to memory leak bugs. To fix > this, we

Re: [PATCH v2] dt-bindings: power: Convert power_supply text to yaml

2020-05-02 Thread Sebastian Reichel
t;http://devicetree.org/meta-schemas/core.yaml#; > + > +title: Power Supply Core Support > + > +maintainers: > + - Sebastian Reichel > + > +properties: > + power-supplies: > +$ref: /schemas/types.yaml#/definitions/phandle-array > +description: > + Thi

Re: [PATCH v4 1/4] power: supply: core: tabularize HWMON temperature labels

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 05:11:18PM +0200, Michał Mirosław wrote: > Rework power_supply_hwmon_read_string() to check it's parameters. > This allows to extend it later with labels for other types of > measurements. > > Signed-off-by: Michał Mirosław > --- > v2: split from fix temperature

Re: [PATCH v4 2/4] power: supply: core: add input voltage/current measurements

2020-05-02 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 05:11:18PM +0200, Michał Mirosław wrote: > Introduce input voltage and current limits and measurements. > This makes room for e.g. VBUS measurements in USB chargers. We already have properties for charger input voltage/current. Unfortunately the naming is not as

Re: [PATCH 2/4] power_supply: Use designated initializer for property text arrays

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 24, 2020 at 11:35:31AM -0600, Mathew King wrote: > Use designated initializers for the sysfs power supply text values. This > will help ensure that the text values are kept in sync with the enum > values from power_supply.h. > > Signed-off-by: Mathew King > --- Thanks, looks

Re: [PATCH 1/4] power_supply: Cleanup power supply sysfs attribute list

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 24, 2020 at 11:35:30AM -0600, Mathew King wrote: > Make the device attribute list used to create sysfs attributes more > robust by decoupling the list order from order of the enum defined in > power_supply.h. This is done by using a designated initializer in the >

Re: [RESEND PATCH v5 0/3] BQ25150/155 Charger

2020-05-01 Thread Sebastian Reichel
Hi, I don't see any PATCHv5 (with or without RESEND) for bq25150 and lore does not see anything either: https://lore.kernel.org/linux-pm/?q=PATCH+v5+0%2F3%5D+BQ25150%2F155+Charger -- Sebastian On Tue, Mar 24, 2020 at 10:14:20AM -0500, Ricardo Rivera-Matos wrote: > bump > > On 3/4/20 11:40 AM,

Re: [PATCH] dt-bindings: power: Convert power_supply text to yaml

2020-05-01 Thread Sebastian Reichel
-2.0 > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/power/supply/power_supply.yaml#; This should be power-supply instead of power_supply, which is also reported by dtb_binding_check on my system :) > +$schema: "http://devicetree.org/meta-schemas/core.yaml#;

Re: [PATCH 0/4] Add support for constant power-supply property tables

2020-05-01 Thread Sebastian Reichel
Hi, On Mon, Apr 13, 2020 at 08:38:49PM +0200, Sebastian Reichel wrote: > This marks the properties and usb_types entries in > struct power_supply_desc as const, so that drivers > can constify those tables. > > Sebastian Reichel (4): > power: supply: core: Constify usb_types

Re: [PATCH] power: charger-manager: clarify num_properties starting value

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 04:30:43PM +0200, Michał Mirosław wrote: > Initialize num_properties with length of the copied array instead > of relying on previously memcpy'd value. This makes it clear how > the array and the counter are related. > > Signed-off-by: Michał Mirosław > --- Thanks,

Re: [PATCH] power: charger-manager: fix adding of optional properties

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 03:39:53PM +0200, Michał Mirosław wrote: > Use num_properties to index added property. > This will prevent overwriting POWER_SUPPLY_PROP_CHARGE_NOW with > POWER_SUPPLY_PROP_CURRENT_NOW and leaving the latter entry > uninitialized. > > For clarity, num_properties is

Re: [PATCH v3 02/11] power: charger-manager: don't write through desc->properties

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, May 01, 2020 at 03:30:08PM +0200, Michał Mirosław wrote: > On Fri, May 01, 2020 at 02:38:49PM +0200, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Apr 03, 2020 at 10:20:31PM +0200, Michał Mirosław wrote: > > > psy_desc->properties will become

Re: [PATCH v3 08/11] power: supply: core: hide unused HWMON labels

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2020 at 10:20:34PM +0200, Michał Mirosław wrote: > Currently HWMON emulation shows all labels (temp and ambient temp) > regardless if power supply supports reading the values. Check that at > least one property is enabled for each label. > > Signed-off-by: Michał Mirosław >

Re: [PATCH v3 07/11] power: supply: core: tabularize HWMON temperature labels

2020-05-01 Thread Sebastian Reichel
Hi, On Mon, Apr 20, 2020 at 11:22:09AM +0200, Michał Mirosław wrote: > On Tue, Apr 07, 2020 at 11:13:50AM -0700, Nick Desaulniers wrote: > > On Sat, Apr 4, 2020 at 6:53 PM kbuild test robot wrote: > > > > > > Hi "Michał, > > > > > > I love your patch! Perhaps something to improve: > > > > > >

Re: [PATCH v3 06/11] power: supply: core: fix HWMON temperature labels

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2020 at 10:20:33PM +0200, Michał Mirosław wrote: > tempX_label files are swapped compared to what > power_supply_hwmon_temp_to_property() uses. Make them match. > > Cc: sta...@vger.kernel.org > Fixes: e67d4dfc9ff1 ("power: supply: Add HWMON compatibility layer") >

Re: [PATCH v3 02/11] power: charger-manager: don't write through desc->properties

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2020 at 10:20:31PM +0200, Michał Mirosław wrote: > psy_desc->properties will become pointer to const. Avoid writing > through the pointer to enable constification of the tables elsewhere. > > Signed-off-by: Michał Mirosław > --- For patches 1-3 I used my version, that I

Re: [PATCH v3 05/11] power: supply: core: allow to constify property lists

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2020 at 10:20:32PM +0200, Michał Mirosław wrote: > Since tables pointed to by power_supply_desc->properties and > ->usb_types are not expected to change after registration, mark > the pointers accordingly > > Signed-off-by: Michał Mirosław > --- Thanks, queued. --

Re: [PATCH v3 04/11] power: supply: core: reduce power_supply_show_usb_type() parameters

2020-05-01 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2020 at 10:20:32PM +0200, Michał Mirosław wrote: > Reduce power_supply_show_usb_type() parameter count by folding > power_supply_desc dereference into the function. This makes following > patch making usb_types const easier. > > Signed-off-by: Michał Mirosław > --- Thanks,

Re: [PATCH v11 0/6] Add battery charger driver support for MP2629

2020-05-01 Thread Sebastian Reichel
Hi, I expect, that Lee will provide an immutable branch for me and Jonathan once the MFD bits have been reviewed. Please tell me, if I should prepare one instead. -- Sebastian On Thu, Apr 30, 2020 at 05:58:04PM +0200, Saravanan Sekar wrote: > changes in v11: > - module_remove part replaced by

Re: [PATCH v11 6/6] MAINTAINERS: Add entry for mp2629 Battery Charger driver

2020-05-01 Thread Sebastian Reichel
Hi, On Thu, Apr 30, 2020 at 05:58:10PM +0200, Saravanan Sekar wrote: > Add MAINTAINERS entry for Monolithic Power Systems mp2629 Charger driver. > > Signed-off-by: Saravanan Sekar > Reviewed-by: Andy Shevchenko > --- Reviewed-by: Sebastian Reichel -- Sebastian > MAINTAIN

Re: [PATCH v11 5/6] power: supply: mp2629: Add impedance compensation config

2020-05-01 Thread Sebastian Reichel
Hi, On Thu, Apr 30, 2020 at 05:58:09PM +0200, Saravanan Sekar wrote: > Allows the user to compensate the intrinsic resistance of the battery > to accelerate the charging cycle. > > Signed-off-by: Saravanan Sekar > Reviewed-by: Andy Shevchenko > --- Reviewed-by:

<    1   2   3   4   5   6   7   8   9   10   >