[PATCH 13/20] net: stmmac: Move DMA Tx/Rx init methods to DW MAC lib

These methods are identical for both DW MAC100 and DW MAC1000 cores, so their implementation can be moved to the common for the core library. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/dwmac1000_dma.c | 20 ++- .../ethernet/stmicro/stmmac/dwmac100_dma.c| 20

[PATCH 11/20] net: stmmac: Discard index usage in the dirty_rx init

Indeed in accordance with the initialization loop logics the statement "(i - priv->dma_rx_size)" will always equal to zero. Just initialize the dirty_rx pointer with zero then. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed

[PATCH 12/20] net: stmmac: Discard dwmac1000_dma_ops declaration from dwmac100.h

Indeed it's redundant to have that variable declaration in the dwmac1000.h header file since it's used in the hwif.c module only and declared in its header together with the rest of the ops descriptors. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 1 - 1 file

[PATCH 10/20] net: stmmac: Discard Rx copybreak ethtool setting

6ae949 ("net: stmmac: Introducing support for Page Pool") and in commit d66e67bd4cc7 ("net: stmmac: Remove unused inline function stmmac_rx_threshold_count"). Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 - .../ethern

[PATCH 09/20] net: stmmac: Discard mii_irq array from private data

There has been no user of the denoted array of the device private data since commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core"). Discard it then. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 - 1 file changed, 1 deletion(-)

[PATCH 08/20] net: stmmac: Fix typo in the XGMAC_L3_ADDR3 macro name

The macro has been declared as XMGAC_L3_ADDR3 with obvious second and third chars confused. Revert them then. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac

[PATCH 05/20] net: stmmac: Use dwmac410_disable_dma_irq for DW MAC v4.10 DMA

herent driver code. Fixes: 021bd5e36970 ("net: stmmac: Let TX and RX interrupts be independently enabled/disabled") Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[PATCH 07/20] net: stmmac: Clear descriptors before initializing them

of that by discarding the Rx descriptor clearance from the init_dma_rx_desc_rings() method and move the generic method of all descriptors clearance to the head of the init_dma_desc_rings() function. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ++ 1 file changed

[PATCH 06/20] net: stmmac: Use LPI IRQ status-related macro in DW MAC1000 isr

because the bits position match in both DW MAC IRQ mask and status registers, but semantically the code still doesn't look correct. Let's fix that by using the correct macro there. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 +- 1 file changed, 1 insertion

[PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

fix that problem we suggest to locally re-implement the MMD write method for RTL8211E PHY and perform a dummy read right after the PC1R register is accessed to enable the RXC stopping in LPI mode. Signed-off-by: Serge Semin --- drivers/net/phy/realtek.c | 37 +

[PATCH 03/20] net: stmmac: Fix false MTL RX overflow handling for higher queues

pared for multiple queues") Signed-off-by: Serge Semin --- Folks, I haven't seen an effect of that bug. The patch has been created purely based on the code visual perception. If you think the handler is supposed to work like that and I am missing something (though I have much doubt about that),

[PATCH 04/20] net: stmmac: Assert reset control after MDIO de-registration

-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index d45af1ea2565..1c40dc26fbf7 100644 --- a/drivers/net

[PATCH 02/20] net: stmmac: Free Rx descs on Tx allocation failure

the method a bit. Just move the Rx descriptors allocation method invocation out of the local variables declaration block and discard a pointless comment from there. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH 00/20] net: stmmac: Obvious cleanups and several fixes

: 7bac4e1ec3ca ("net: stmmac: stmmac interrupt treatment prepared for multiple queues") Fixes: 021bd5e36970 ("net: stmmac: Let TX and RX interrupts be independently enabled/disabled") Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Vyacheslav Mi

[PATCH v2 23/24] net: stmmac: Use pclk to set MDC clock frequency

e Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 424. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/

[PATCH v2 20/24] net: stmmac: dwc-qos: Discard Tx/Rx clocks request

. Note also the deprecated clock "phy_ref_clk" have been defined as the Tx clock in the DWC QoS Eth bindings. Let's use a pointer to the Tx clock defined in the platform data then instead of the unrelated pclk pointer. Signed-off-by: Serge Semin --- .../stmicro/stmmac/dwmac-dwc

[PATCH v2 22/24] net: stmmac: Call stmmaceth clock as system clock in warn-message

failed to be requested. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index

[PATCH v2 17/24] net: stmmac: dwc-qos: Cleanup STMMAC platform data clock pointers

The pointers need to be nullified otherwise the stmmac_remove_config_dt() method called after them being initialized will disable the clocks. That then will cause a WARN() backtrace being printed since the clocks would be also disabled in the locally defined remove method. Signed-off-by: Serge

[PATCH v2 18/24] net: stmmac: dwc-qos: Use dev_err_probe() for probe errors handling

There is a very handy dev_err_probe() method to handle the deferred probe error number. It reduces the code size and identations, uniforms error handling, records the defer probe reason, etc. Use it to print the probe callback error message. Signed-off-by: Serge Semin Cc: Anson Huang

[PATCH v2 24/24] net: stmmac: dwc-qos: Save master/slave clocks in the plat-data

pecified. So in order to have the STMMAC platform data properly initialized we need to set the "master_bus" clock handler to the "stmmaceth" clock pointer, and the "slave_bus" clock handler to the "pclk" clock pointer. Signed-off-by: Serge Semin --- drivers

[PATCH v2 21/24] net: stmmac: dwmac-imx: Discard Tx clock request

Since the Tx clock is now requested and enabled/disabled in the STMMAC DT-based platform config method, there is no need in duplicating the same procedures in the DW MAC iMX sub-driver. Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 21 +-- 1 file

[PATCH v2 19/24] net: stmmac: Add Tx/Rx platform clocks support

to the generic STMMAC DT-based platform data initialization method under the names "tx" and "rx" respectively. The bindings schema has already been altered in accordance with that. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 22 ++

[PATCH v2 15/24] net: stmmac: Use optional clock request method to get ptp_clk

. The later will correctly handle it. So just discard the conditional statement of priv->plat->clk_ptp_ref pointer value testing in the stmmac_resume() method. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- drivers/net/ethernet/stmicro/

[PATCH v2 16/24] net: stmmac: Use optional reset control API to work with stmmaceth

uot;net: stmmac: platform: use optional clk/reset get APIs") Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/eth

[PATCH v2 11/24] net: stmmac: dwmac-stm32: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH v2 06/24] dt-bindings: net: dwmac: Add Tx/Rx clock sources

Generic DW *MAC can be connected to an external Transmit and Receive clock generators. Add the corresponding clocks description and clock-names to the generic bindings schema so new DW *MAC-based bindings wouldn't declare its own names of the same clocks. Signed-off-by: Serge Semin Reviewed

[PATCH v2 07/24] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

r-specific MAC bindings which refer to the common bindings file, while the generic DW MAC DT nodes will be checked against the new snps,dwmac-generic.yaml DT schema. Signed-off-by: Serge Semin --- Changelog v2: - Add a note to the snps,dwmac-generic.yaml bindings file description of a r

[PATCH v2 08/24] net: stmmac: Add {axi,mtl-rx,mtl-tx}-config sub-nodes support

s to the DW MAC device DT node with vendor-prefixless names. Make sure the STMMAC driver supports them. Signed-off-by: Serge Semin --- Changelog v2: - Discard "snps" vendor-prefix from the new AXI/MTL Tx/Rx config sub-nodes. --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 9

[PATCH v2 14/24] net: stmmac: Use optional clock request method to get stmmaceth

e error message from being printed. All of that can be fixed by using the devm_clk_get_optional() method here provided by the common clock framework. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 19 ++- 1 file changed, 10 insertions(+), 9 dele

[PATCH v2 12/24] net: stmmac: Directly call reverse methods in stmmac_probe_config_dt()

and stmmac_rst to platform structure") Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 23 ++- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmm

[PATCH v2 13/24] net: stmmac: Fix clocks left enabled on glue-probes failure

of course is wrong. Fix it by moving the clocks disable/unprepare methods invocation to the stmmac_remove_config_dt() function. Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signed-off-by: Serge Semin --- drivers/net/ethernet/

[PATCH v2 10/24] net: stmmac: dwmac-sti: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH v2 09/24] net: stmmac: dwmac-rk: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH v2 05/24] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk description

be considered as a source of clocks for both application and CSR. But if "pclk" is also specified in the list of the device clocks, then it will be perceived as the separate CSR clock. [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 564. Signed-off-by: Serge Semin

[PATCH v2 00/24] net: stmmac: Fix clocks/reset-related procedures

ch [PATCH 15/25] net: stmmac: Use optional clock request method to get pclk since the corresponding functionality has already been integrated into the driver. - Rebase on top of the kernel 5.11-rc7. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks")

[PATCH v2 03/24] dt-bindings: net: dwmac: Fix the TSO property declaration

mally done in the most of the DT schemas. Signed-off-by: Serge Semin --- Note this won't break the bindings description, since the "snps,tso" property isn't parsed by the Allwinner SunX GMAC glue driver, but only by the generic platform DT-parser. Changelog v2: - Use correct syntax of t

[PATCH v2 04/24] dt-bindings: net: dwmac: Refactor snps,*-config properties

nfigs sub-nodes bindings right in the snps,dwmac.yaml file. Note the former "snps,axi-config", "snps,mtl-rx-config" and "snps,mtl-tx-config" properties have been marked as deprecated in favor of the added by this commit "axi-config", "mtl-rx-config" and

[PATCH v2 01/24] dt-bindings: net: dwmac: Validate PBL for all IP-cores

-by: Serge Semin Reviewed-by: Rob Herring --- Changelog v2: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- .../devicetree/bindings/net/snps,dwmac.yaml | 69 +++ 1 file changed, 26 insertions(+), 43 deletions(-) diff --git

[PATCH v2 02/24] dt-bindings: net: dwmac: Extend number of PBL values

Universal Databook, Revision 3.73a, October 2013, p. 380. Signed-off-by: Serge Semin Reviewed-by: Rob Herring Changelog v2: - Use correct syntax of the JSON pointers, so the later would begin with a '/' after the '#'. --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 11 +++ 1

[PATCH v5 07/10] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v5 10/10] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v5 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

deprecated naming so not to fail on the legacy DTS-files passed to the newer kernels. Signed-off-by: Serge Semin Reviewed-by: Bjorn Andersson --- drivers/usb/dwc3/dwc3-qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/d

[PATCH v5 08/10] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH v5 06/10] arm: dts: keystone: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v5 05/10] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df1

[PATCH v5 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

..@lists.ozlabs.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-o...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (10): arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name arm: dts: keystone: Correct DWC USB

[PATCH v5 04/10] arm: dts: lpc18xx: Harmonize EHCI/OHCI DT nodes name

ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Vladimir Zapolskiy Acked-by: Krzysztof Kozlowski --- arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/l

[PATCH v5 02/10] arm: dts: keystone: Correct DWC USB3 compatible string

Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. Use it instead of the deprecated "synopsys" one. Signed-off-by: Serge Semin Reviewed-by: Krzysztof Kozlowski --- arch/arm/boot/dts/keystone-k2e.dtsi | 2 +- arch/arm/boot/dts/keystone.dtsi | 2 +-

[PATCH v5 03/10] arc: dts: Harmonize EHCI/OHCI DT nodes name

ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Alexey Brodkin Acked-by: Krzysztof Kozlowski --- arch/arc/boot/dts/axc003.dtsi| 4 ++-- arch/arc/boot/dts/axc003_idu.dtsi| 4 ++-- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dt

[PATCH v5 01/10] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH] Revert "mips: Manually call fdt_init_reserved_mem() method"

ally after having Paul reported that the second fdt_init_reserved_mem() call causes the reserved memory pool being created twice bigger than implied. Fixes: a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") Reported-by: Paul Cercueil Signed-off-by: Serge Semin --- arch/mips/kernel/set

Re: [PATCH] bus: bt1-apb:Fix duplicate included linux/clk.h

On Sun, Feb 07, 2021 at 10:20:50PM +0800, alex_l...@163.com wrote: > From: Zhang Kun > > Remove one of the duplicate header hlinux/clk.h which isn't necessary. Thanks! Acked-by: Serge Semin Arnd, could you merge it in? -Sergey > > Signed-off-by: Zhang Kun > --- >

Re: [PATCH v3 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

On Wed, Feb 03, 2021 at 10:06:46AM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 02, 2021 at 05:02:08PM -0600, Bjorn Andersson wrote: > > On Sat 05 Dec 09:56 CST 2020, Serge Semin wrote: > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are &

Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it

> > > > > On 2020/12/7 2:50, Marc Zyngier wrote: > > > > On 2020-12-06 15:02, Linus Walleij wrote: > > > >> On Sat, Dec 5, 2020 at 11:15 PM Serge Semin > > > >> wrote: > > > >> > > > >>> Hmm, that sound

Re: [PATCH 5.10 134/717] spi: dw: fix build error by selecting MULTIPLEXER

On Thu, Dec 31, 2020 at 09:51:21AM +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 31, 2020 at 11:49:56AM +0300, Serge Semin wrote: > > Hello Greg, > > The next patch has been created to supersede the one you've applied: > > https://lore.kernel.org/linux-spi/2020112714

Re: [PATCH 5.10 134/717] spi: dw: fix build error by selecting MULTIPLEXER

_control_get' > > Fixes: abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver") > Reported-by: kernel test robot > Signed-off-by: Randy Dunlap > Cc: Serge Semin > Cc: Ramil Zaripov > Cc: Mark Brown > Cc: linux-...@vger.kernel.org > Acked-by: Serge

Re: [PATCH 07/25] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

On Tue, Dec 15, 2020 at 11:50:02AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:57PM +0300, Serge Semin wrote: > > Currently the snps,dwmac.yaml DT bindings file is used for both DT nodes > > describing generic DW MAC devices and as DT schema with common properties >

Re: [PATCH 03/25] dt-bindings: net: dwmac: Fix the TSO property declaration

On Tue, Dec 15, 2020 at 11:22:40AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:53PM +0300, Serge Semin wrote: > > Indeed the STMMAC driver doesn't take the vendor-specific compatible > > string into account to parse the "snps,tso" boolean property. It jus

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

On Tue, Dec 15, 2020 at 08:08:35AM -0600, Rob Herring wrote: > On Tue, Dec 15, 2020 at 2:54 AM Serge Semin > wrote: > > > > Hello Rob, > > > > On Mon, Dec 14, 2020 at 08:30:06AM -0600, Rob Herring wrote: > > > On Mon, Dec 14, 2020 at 12:15:54PM +030

Re: [PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

On Tue, Dec 15, 2020 at 11:32:04AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:56PM +0300, Serge Semin wrote: > > Generic DW *MAC can be connected to an external Tramit and Receive clock > > s/Tramit/Transmit/ Thanks. I'll fix it in v2. -Sergey > &

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

On Wed, Dec 16, 2020 at 03:03:55AM +0100, Andrew Lunn wrote: > > > From what you are saying, it sounds like from software you cannot > > > independently control the GPIO controller reset? > > > > No. The hardware implements the default MAC reset behavior. So the > > GPIO controller gets reset

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

On Tue, Dec 15, 2020 at 02:58:37PM +0100, Andrew Lunn wrote: > > > > Anyway the hardware setup depicted above doesn't seem > > > > problematic at the first glance, but in fact it is. See, the DW *MAC > > > > driver > > > > (STMMAC ethernet driver) is doing the MAC reset each time it performs > >

Re: [PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

Hello Rob, On Mon, Dec 14, 2020 at 08:30:06AM -0600, Rob Herring wrote: > On Mon, Dec 14, 2020 at 12:15:54PM +0300, Serge Semin wrote: > > Currently the "snps,axi-config", "snps,mtl-rx-config" and > > "snps,mtl-tx-config" properties are declare

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

Hello Andrew, On Mon, Dec 14, 2020 at 04:31:43PM +0100, Andrew Lunn wrote: > On Mon, Dec 14, 2020 at 12:25:16PM +0300, Serge Semin wrote: > > Hello folks, > > > > I've got a problem, which has been blowing by head up for more than three > > weeks now, and I'm

Re: [RFC] net: stmmac: Problem with adding the native GPIOs support

s cleared PHY gets to be in reset state, and it concerns all the devices.( -Sergey > > regards > Alex > > On 12/14/20 10:25 AM, Serge Semin wrote: > > Hello folks, > > > > I've got a problem, which has been blowing by head up for more than three > > weeks no

[PATCH 01/25] dt-bindings: net: dwmac: Validate PBL for all IP-cores

-by: Serge Semin --- .../devicetree/bindings/net/snps,dwmac.yaml | 69 +++ 1 file changed, 26 insertions(+), 43 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 11a6fdb657c9..4b672499f20d

[PATCH 25/25] net: stmmac: dwc-qos: Save master/slave clocks in the plat-data

pecified. So in order to have the STMMAC platform data properly initialized we need to set the "master_bus" clock handler to the "stmmaceth" clock pointer, and the "slave_bus" clock handler to the "pclk" clock pointer. Signed-off-by: Serge Semin --- drivers

[PATCH 15/25] net: stmmac: Use optional clock request method to get pclk

the clock framework failed to request it. Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_platform.c| 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmm

[PATCH 22/25] net: stmmac: dwmac-imx: Discard Tx clock request

Since the Tx clock is now requested and enabled/disabled in the STMMAC DT-based platform config method, there is no need in duplicating the same procedures in the DW MAC iMX sub-driver. Signed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 21 +-- 1 file

[RFC] net: stmmac: Problem with adding the native GPIOs support

Hello folks, I've got a problem, which has been blowing by head up for more than three weeks now, and I'm desperately need your help in that matter. See our Baikal-T1 SoC is created with two DW GMAC v3.73a IP-cores. Each core has been synthesized with two GPIOs: one as GPI and another as GPO.

[PATCH 21/25] net: stmmac: dwc-qos: Discard Tx/Rx clocks request

. Note also the deprecated clock "phy_ref_clk" have been defined as the Tx clock in the DWC QoS Eth bindings. Let's use a pointer to the Tx clock defined in the platform data then instead of the unrelated pclk pointer. Signed-off-by: Serge Semin --- .../stmicro/stmmac/dwmac-dwc

[PATCH 10/25] net: stmmac: dwmac-sti: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH 08/25] net: stmmac: Add snps,*-config sub-nodes support

sub-nodes to the DW MAC device DT node. Make sure the STMMAC driver supports it. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_plat

[PATCH 06/25] dt-bindings: net: dwmac: Add Tx/Rx clock sources

Generic DW *MAC can be connected to an external Tramit and Receive clock generators. Add the corresponding clocks description and clock-names to the generic bindings schema so new DW *MAC-based bindings wouldn't declare its own names of the same clocks. Signed-off-by: Serge Semin

[PATCH 19/25] net: stmmac: dwc-qos: Use dev_err_probe() for probe errors handling

There is a very handy dev_err_probe() method to handle the deferred probe error number. It reduces the code size, uniforms error handling, records the defer probe reason, etc. Use it to print the probe callback error message. Signed-off-by: Serge Semin Cc: Anson Huang --- drivers/net/ethernet

[PATCH 14/25] net: stmmac: Use optional clock request method to get stmmaceth

e error message from being printed. All of that can be fixed by using the devm_clk_get_optional() method here provided by the common clock framework. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 20 ++- 1 file changed, 11 insertions(+), 9 dele

[PATCH 13/25] net: stmmac: Fix clocks left enabled on glue-probes failure

of course is wrong. Fix it by moving the clocks disable/unprepare methods invocation to the stmmac_remove_config_dt() function. Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signed-off-by: Serge Semin --- drivers/net/ethernet/

[PATCH 24/25] net: stmmac: Use pclk to set MDC clock frequency

e Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 424. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/

[PATCH 18/25] net: stmmac: dwc-qos: Cleanup STMMAC platform data clock pointers

The pointers need to be nullified otherwise the stmmac_remove_config_dt() method called after them being initialized will disable the clocks. That then will cause a WARN() backtrace being printed since the clocks would be also disabled in the locally defined remove method. Signed-off-by: Serge

[PATCH 17/25] net: stmmac: Use optional reset control API to work with stmmaceth

ed-off-by: Serge Semin --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 14 +- 2 files changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/et

[PATCH 23/25] net: stmmac: Call stmmaceth clock as system clock in warn-message

By all means of the stmmac_clk clock usage it isn't CSR clock, but the system or application clock, which in particular cases can be used as a clock source for the CSR interface. Make sure the warning message correctly identify the clock. Signed-off-by: Serge Semin --- drivers/net/ethernet

[PATCH 12/25] net: stmmac: Directly call reverse methods in stmmac_probe_config_dt()

and stmmac_rst to platform structure") Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 26 --- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmm

[PATCH 16/25] net: stmmac: Use optional clock request method to get ptp_clk

. The later will correctly handle it. So just discard the conditional statement of priv->plat->clk_ptp_ref pointer value testing in the stmmac_resume() method. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- drivers/net/ethernet/stmicro/

[PATCH 20/25] net: stmmac: Add Tx/Rx platform clocks support

to the generic STMMAC DT-based platform data initialization method under the names "tx" and "rx" respectively. The bindings schema has already been altered in accordance with that. Signed-off-by: Serge Semin --- .../ethernet/stmicro/stmmac/stmmac_platform.c | 24 ++

[PATCH 07/25] dt-bindings: net: dwmac: Detach Generic DW MAC bindings

r-specific MAC bindings which refer to the common bindings file, while the generic DW MAC DT nodes will be checked against the new snps,dwmac-generic.yaml DT schema. Signed-off-by: Serge Semin --- .../bindings/net/snps,dwmac-generic.yaml | 148 ++ .../devicetree/binding

[PATCH 05/25] dt-bindings: net: dwmac: Elaborate stmmaceth/pclk description

be considered as a source of clocks for both application and CSR. But if "pclk" is also specified in the list of the device clocks, then it will be perceived as the separate CSR clock. [1] DesignWare Cores Ethernet MAC Universal Databook, Revision 3.73a, October 2013, p. 564. Signed-off-by: Serge Semi

[PATCH 11/25] net: stmmac: dwmac-stm32: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH 09/25] net: stmmac: dwmac-rk: Cleanup STMMAC DT-config in remove cb

The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/ne

[PATCH 00/25] net: stmmac: Fix clocks/reset-related procedures

next series will concern the GPIOs support and Baikal-T1 SoC specific bindings. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signe

[PATCH 04/25] dt-bindings: net: dwmac: Refactor snps,*-config properties

nfigs sub-nodes bindings right in the snps,dwmac.yaml file. Note the former "snps,axi-config", "snps,mtl-rx-config" and "snps,mtl-tx-config" bindings have been marked as deprecated. Signed-off-by: Serge Semin --- Note the current DT schema tool requires the vendor-spe

[PATCH 03/25] dt-bindings: net: dwmac: Fix the TSO property declaration

evaluated for the compatibles having the corresponding IP-core version. While at it move the whole allOf-block from the tail of the binding file to the head of it, as it's normally done in the most of the DT schemas. Signed-off-by: Serge Semin --- Note this won't break the bindings description, since the

[PATCH 02/25] dt-bindings: net: dwmac: Extend number of PBL values

Universal Databook, Revision 3.73a, October 2013, p. 380. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation

[PATCH v4 01/10] arm: dts: keystone: Correct DWC USB3 compatible string

Syonpsys IP cores are supposed to be defined with "snps" vendor-prefix. Use it instead of the deprecated "synopsys" one. Signed-off-by: Serge Semin Reviewed-by: Krzysztof Kozlowski --- arch/arm/boot/dts/keystone-k2e.dtsi | 2 +- arch/arm/boot/dts/keystone.dtsi | 2 +-

[PATCH v4 08/10] arm64: dts: apm: Harmonize DWC USB3 DT nodes name

spite of the warning comment about possible backward compatibility issues. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 4 ++-- arch/arm64/boot/dts/apm/apm-storm.dtsi | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-

[PATCH v4 05/10] powerpc: dts: akebono: Harmonize EHCI/OHCI DT nodes name

ic-ohci"-compatible nodes are correctly named. Signed-off-by: Serge Semin Acked-by: Krzysztof Kozlowski --- arch/powerpc/boot/dts/akebono.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/akebono.dts b/arch/powerpc/boot/dts/akebono.dts index df1

[PATCH v4 10/10] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v4 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

deprecated naming so not to fail on the legacy DTS-files passed to the newer kernels. Signed-off-by: Serge Semin Reviewed-by: Bjorn Andersson --- drivers/usb/dwc3/dwc3-qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/d

[PATCH v4 07/10] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH v4 06/10] arm: dts: keystone: Harmonize DWC USB3 DT nodes name

In accordance with the DWC USB3 bindings the corresponding node name is suppose to comply with the Generic USB HCD DT schema, which requires the USB nodes to have the name acceptable by the regexp: "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly named.

[PATCH RESEND v4 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

: linux-st...@st-md-mailman.stormreply.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-m...@vger.kernel.org Cc: linux-media...@lists.infradead.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-o...@vger.kernel.org Cc: linux-arm-...@vger.kernel.org Cc: devicet...@vger.

<    1   2   3   4   5   6   7   8   9   10   >