[PATCH v3 09/16] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-20 Thread Serge Semin
the DWC USB3 nodes are also validated against the usb-xhci.yaml schema. Note we have to discard the nodename restriction of being prefixed with "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes are supposed to be named as "^usb(@.*)". Signed-off-by: Serge Se

[PATCH v3 16/16] dt-bindings: usb: qcom,dwc3: Validate DWC3 sub-node

2020-10-20 Thread Serge Semin
to be named as generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name regexp and fix the DT node example. Signed-off-by: Serge Semin Reviewed-by: Rob Herring --- Changelog v2: - Discard the "^dwc3@[0-9a-f]+$" nodes from being acceptable as sub-nodes

[PATCH v3 13/16] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value

2020-10-20 Thread Serge Semin
. Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-sergey.se...@baikalelectronics.ru/ Signed-off-by: Serge Semin Acked-by: Neil Armstrong Reviewed-by: Rob Herring Reviewed-by: Martin Blumenstingl --- Note the same problem is in the DT source file arch/arm64/boot/dts/amlogic/meson

Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-19 Thread Serge Semin
On Fri, Oct 16, 2020 at 01:53:40PM -0500, Rob Herring wrote: > On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote: > > On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > > > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > >

Re: [PATCH] gpio: dwapb: Fix missing conversion to GPIO-lib-based IRQ-chip

2020-10-16 Thread Serge Semin
ddress between user and kernel address ranges" on a Ampere armv8a > server and cause a panic. It's strange I didn't get the same panic. Anyway, good catch! Certainly: Acked-by: Serge Semin > > Fixes: 0ea683931adb ("gpio: dwapb: Convert driver to using the > GPIO-lib-based

Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

2020-10-16 Thread Serge Semin
On Fri, Oct 16, 2020 at 05:43:08PM +0300, Andy Shevchenko wrote: > On Thu, Oct 15, 2020 at 3:33 PM Serge Semin wrote: > > On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > > > The compatible string is never used. > > > > Before sending v2 could

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-16 Thread Serge Semin
Hello Alexandre, On Fri, Oct 16, 2020 at 09:08:23AM +0200, Alexandre Torgue wrote: > Hi Serge, > > On 10/14/20 12:14 PM, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-15 Thread Serge Semin
On Thu, Oct 15, 2020 at 08:14:39AM +0200, Krzysztof Kozlowski wrote: > On Thu, Oct 15, 2020 at 02:51:05AM +0300, Serge Semin wrote: > > > > > > > So to speak thanks for suggesting it. I'll try it to validate the > > > > proposed > > > > change

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-15 Thread Serge Semin
On Thu, Oct 15, 2020 at 01:15:37PM +0300, Felipe Balbi wrote: > Serge Semin writes: > > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > >> > >> Hi Serge, > >> > >> Serge Semin writes: > >> > In accor

Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

2020-10-15 Thread Serge Semin
On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > The compatible string is never used. Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this: make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check

Re: [PATCH 0/8] remove never-used "snps,dw-apb-gpio-port"

2020-10-15 Thread Serge Semin
Hello Jisheng, Thanks for sending this cleanup and for the work you've done in its framework. The compatible property is indeed redundant in the DW APB GPIO bindings, because any sub-node is considered as one of the device port from the set {A,B,C,D} and I don't see why would we need to be there

Re: [PATCH v2] MIPS: DEC: Restore bootmem reservation for firmware working memory area

2020-10-14 Thread Serge Semin
Maciej, Regardless of a comment below feel free to add: Reviewed-by: Serge Semin On Wed, Oct 14, 2020 at 10:34:56PM +0100, Maciej W. Rozycki wrote: > Fix a crash on DEC platforms starting with: > > VFS: Mounted root (nfs filesystem) on device 0:11. > Freeing unused PROM memory: 124k

Re: [PATCH v2] MIPS: DEC: Restore bootmem reservation for firmware working memory area

2020-10-14 Thread Serge Semin
On Thu, Oct 15, 2020 at 01:03:10AM +0100, Maciej W. Rozycki wrote: > On Thu, 15 Oct 2020, Serge Semin wrote: > > > > Table 2-2 REX Memory Regions > > > - > > > Starting

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 10:04:32PM +0200, Krzysztof Kozlowski wrote: > On Wed, 14 Oct 2020 at 19:16, Serge Semin > wrote: > > > > On Wed, Oct 14, 2020 at 12:33:25PM +0200, Krzysztof Kozlowski wrote: > > > On Wed, 14 Oct 2020 at 12:23, Serge Semin > > >

Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > expects the DWC USB3 DT node to have the compatible string with th

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 01:35:16PM -0500, Rob Herring wrote: > On Wed, Oct 14, 2020 at 9:37 AM Serge Semin > wrote: > > > > On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > > > > > Hi Serge, > > > > > > Serge Semin wr

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 11:41:17AM -0700, Florian Fainelli wrote: > On 10/14/20 11:11 AM, Serge Semin wrote: > > On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: > >> On 10/14/20 3:14 AM, Serge Semin wrote: > >>> In accordance with the Generic EHCI/O

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: > On 10/14/20 3:14 AM, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires

Re: [PATCH] MIPS: DEC: Restore bootmem reservation for firmware working memory area

2020-10-14 Thread Serge Semin
Hello Maciej, On Wed, Oct 14, 2020 at 12:10:09PM +0100, Maciej W. Rozycki wrote: > Fix a crash on DEC platforms starting with: > ... > @@ -146,6 +150,9 @@ void __init plat_mem_setup(void) > > ioport_resource.start = ~0UL; > ioport_resource.end = 0UL; > + > + /* Stay away from

Re: [PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema

2020-10-14 Thread Serge Semin
Ah, forgot to mark the series as v2. Sorry about that. The next one will be v3 then... -Sergey On Wed, Oct 14, 2020 at 01:13:42PM +0300, Serge Semin wrote: > We've performed some work on the Generic USB HCD, xHCI and DWC USB3 DT > bindings in the framework of the Baikal-T1 SoC s

Re: [PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 08:32:19AM -0500, Rob Herring wrote: > On Wed, 14 Oct 2020 13:13:51 +0300, Serge Semin wrote: > > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > > Controller schema, but with additional vendor-specific properties, the > > controll

Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 08:27:56AM -0500, Rob Herring wrote: > On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > > The host controller device might be designed to work for the particular > > products or applications. In that case its DT node is supposed to be > >

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 12:33:25PM +0200, Krzysztof Kozlowski wrote: > On Wed, 14 Oct 2020 at 12:23, Serge Semin > wrote: > > > > In accordance with the DWC USB3 bindings the corresponding node name is > > suppose to comply with Generic USB HCD DT schema, which requires t

Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > Hi Serge, > > Serge Semin writes: > > In accordance with the DWC USB3 bindings the corresponding node name is > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > DW

[PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction

2020-10-14 Thread Serge Semin
There are only four OTG revisions are currently supported by the kernel: 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as invalid. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name

2020-10-14 Thread Serge Semin
es names of arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the in-source comment says that the nodes name need to be preserved as "^dwusb@.*" for some backward compatibility. Signed-off-by: Serge Semin --- Please, test the patch out to make sure it doesn't brake the

[PATCH 17/20] dt-bindings: usb: qcom,dwc3: Validate DWC3 sub-node

2020-10-14 Thread Serge Semin
to be named as generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name regexp and fix the DT node example. Signed-off-by: Serge Semin --- Changelog v2: - Discard the "^dwc3@[0-9a-f]+$" nodes from being acceptable as sub-nodes. --- Documentation/devicetr

[PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Serge Semin
compatible names. Signed-off-by: Serge Semin --- Please, test the patch out to make sure it doesn't brake the dependent DTS files. I did only a manual grepping of the possible nodes dependencies. --- arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/boot/dts/hsdk.dts

[PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-14 Thread Serge Semin
Amlogic G12A USB DT sub-nodes are supposed to be compatible with the generic DWC USB2 and USB3 devices. Since now we've got DT schemas for both of the later IP cores let's make sure that the Amlogic G12A USB DT nodes are fully evaluated including the DWC sub-nodes. Signed-off-by: Serge Semin

[PATCH 00/20] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema

2020-10-14 Thread Serge Semin
nodes name [PATCH 19/20] arch: dts: Fix xHCI DT nodes name [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Andy Gross Cc: Bjorn Andersson Cc: Manu Gautam Cc: Roger Quadros Cc: Lad Prabhakar Cc: Yoshihiro Sh

[PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property

2020-10-14 Thread Serge Semin
d in the generic USB HCD binding file so it would be validated against the nodes in which it's specified. Mark the property as deprecated to discourage the developers from using it. Signed-off-by: Serge Semin --- Changelog v2: - Discard '|' from the property description, since we don't need to

[PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value

2020-10-14 Thread Serge Semin
. Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-sergey.se...@baikalelectronics.ru/ Signed-off-by: Serge Semin Acked-by: Neil Armstrong --- Note the same problem is in the DT source file arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . --- .../devicetree/bindings/usb/amlogic

[PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-14 Thread Serge Semin
For some reason the "brcm,xhci-brcm-v2" compatible string has been missing in the original bindings file. Add it to the Generic xHCI Controllers DT schema since the controller driver expects it to be supported. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/u

[PATCH 19/20] arch: dts: Fix xHCI DT nodes name

2020-10-14 Thread Serge Semin
compatible names. Signed-off-by: Serge Semin --- Please, test the patch out to make sure it doesn't brake the dependent DTS files. I did only a manual grepping of the possible nodes dependencies. --- arch/arm/boot/dts/bcm5301x.dtsi | 2 +- arch/arm64/boot/dts/marvell/armada-cp11

[PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file

2020-10-14 Thread Serge Semin
With minor peculiarities (like uploading some vendor-specific firmware) these are just Generic xHCI controllers fully compatible with its properties. Make sure the Renesas USB xHCI DT nodes are also validated against the Generic xHCI DT schema. Signed-off-by: Serge Semin --- Documentation

[PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema

2020-10-14 Thread Serge Semin
The generic USB HCD properties have been described in the legacy bindings text file: Documentation/devicetree/bindings/usb/generic.txt . Let's convert it' content into the USB HCD DT schema properties so all USB DT nodes would be validated to have them properly utilized. Signed-off-by: Serge

[PATCH 09/20] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-14 Thread Serge Semin
the DWC USB3 nodes are also validated against the usb-xhci.yaml schema. Note we have to discard the nodename restriction of being prefixed with "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes are supposed to be named as "^usb(@.*)". Signed-off-by: Serge Se

[PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema

2020-10-14 Thread Serge Semin
, single interrupts source, and is supposed to optionally contain up to two reference clocks for the controller core and CSRs. Signed-off-by: Serge Semin --- Changelog v2: - Add explicit "additionalProperties: true" to the usb-xhci.yaml schema, since additionalProperties/unevaluated

[PATCH 16/20] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node

2020-10-14 Thread Serge Semin
TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 compatible sub-node to describe a fully functioning USB interface. Since DWC USB3 has now got a DT schema describing its DT node, let's make sure the TI Keystone DWC3 sub-node passes validation against it. Signed-off-by: Serge

[PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types

2020-10-14 Thread Serge Semin
Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types that can be specified in the phy_type HCD property. Add them to the enumeration of the acceptable values. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/PHY types can be/PHY types that can be" - D

[PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support

2020-10-14 Thread Serge Semin
The controller driver supports two types of DWC USB3 devices: with a common interrupt lane and with individual interrupts for each mode. Add support for both these cases to the DWC USB3 DT schema. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/both of these cases su

[PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

2020-10-14 Thread Serge Semin
In accordance with the driver comments the PIPE3 de-emphasis can be tuned to be either -6dB, -2.5dB or disabled. Let's add the de-emphasis property restriction so the DT schema would make sure the controller DT node is equipped with correct value. Signed-off-by: Serge Semin --- Changelog v2

[PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions

2020-10-14 Thread Serge Semin
In accordance with the IP core databook the snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. Let's make sure the DT schema applies a correct restriction on the property. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ 1 file

[PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-14 Thread Serge Semin
opsys, Inc. is presented with just "snps" vendor prefix. Signed-off-by: Serge Semin --- Changelog v2: - Drop quotes from around the compat string constant. --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Docu

[PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-14 Thread Serge Semin
The host controller device might be designed to work for the particular products or applications. In that case its DT node is supposed to be equipped with the tpl-support property. Signed-off-by: Serge Semin --- Changelog v2: - Grammar fix: "s/it'/its" - Discard '|' from th

Re: [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-13 Thread Serge Semin
On Tue, Oct 13, 2020 at 07:42:03AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:19AM +0300, Serge Semin wrote: > > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > >

Re: [PATCH 14/18] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions

2020-10-13 Thread Serge Semin
On Tue, Oct 13, 2020 at 07:38:59AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:17AM +0300, Serge Semin wrote: > > In accordance with the IP core databook the > > snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. > > Let's make sure

Re: [PATCH 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-13 Thread Serge Semin
On Tue, Oct 13, 2020 at 07:36:24AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:13AM +0300, Serge Semin wrote: > > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > > Controller schema, but with additional vendor-specific properties, the > >

Re: [PATCH 07/18] dt-bindings: usb: Convert xHCI bindings to DT schema

2020-10-13 Thread Serge Semin
On Tue, Oct 13, 2020 at 07:30:04AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:10AM +0300, Serge Semin wrote: > > Currently the DT bindings of Generic xHCI Controllers are described by means > > of the legacy text file. Since such format is deprecated in favor of th

Re: [PATCH 01/18] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema

2020-10-13 Thread Serge Semin
On Tue, Oct 13, 2020 at 07:14:41AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:04AM +0300, Serge Semin wrote: > > The generic USB HCD properties have been described in the legacy bindings > > text file: Documentation/devicetree/bindings/usb/generic.txt . Let's > >

Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-12 Thread Serge Semin
On Mon, Oct 12, 2020 at 05:41:50PM +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 11, 2020 at 08:53:33PM +0300, Serge Semin wrote: > > On Sun, Oct 11, 2020 at 04:42:36PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote:

Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-12 Thread Serge Semin
On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>

Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-12 Thread Serge Semin
On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > Hi, > > On 11/10/2020 00:41, Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > > performed by the driver. Moreover the DT schema validation will fail, > > si

Re: [PATCH 17/18] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 12:04:06PM +0300, Sergei Shtylyov wrote: > On 11.10.2020 1:41, Serge Semin wrote: > > > TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 > > compatible sub-node to describe a fully functioning USB interface. > > Since DWC USB3

Re: [PATCH 13/18] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 11:56:21AM +0300, Sergei Shtylyov wrote: > On 11.10.2020 1:41, Serge Semin wrote: > > > In accordance with the driver comments the PIPE3 de-emphasis can be tunned > >Tuned. Oh. My spell checker accepted this as past participl

Re: [PATCH 11/18] dt-bindings: usb: dwc3: Add interrupt-names property support

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 11:53:07AM +0300, Sergei Shtylyov wrote: > On 11.10.2020 1:41, Serge Semin wrote: > > > The controller driver supports two types of DWC USB3 devices: with a > > common interrupt lane and with individual interrupts for each mode. Add > > bot

Re: [PATCH 05/18] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 11:47:37AM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.10.2020 1:41, Serge Semin wrote: > > > The host controller device might be designed to work for the particular > > products or applications. In that case

Re: [PATCH 05/18] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 11:47:37AM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.10.2020 1:41, Serge Semin wrote: > > > The host controller device might be designed to work for the particular > > products or applications. In that case

Re: [PATCH 04/18] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 11:49:10AM +0300, Sergei Shtylyov wrote: > On 11.10.2020 1:41, Serge Semin wrote: > > > Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types > >"That" missing after "types"? Thanks. It really is. I'll fix it in

Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 04:42:36PM +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote: > > It appears that the "maximum-speed" property can also accept the > > "wireless" value. Add it to the enumeration

[PATCH 14/18] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions

2020-10-10 Thread Serge Semin
In accordance with the IP core databook the snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. Let's make sure the DT schema applies a correct restriction on the property. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ 1 file

[PATCH 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-10-10 Thread Serge Semin
the DWC USB3 nodes are also validated against the usb-xhci.yaml schema. Note we have to discard the nodename restriction of being prefixed with "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes are supposed to be named as "^usb(@.*)". Signed-off-by: Ser

[PATCH 06/18] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property

2020-10-10 Thread Serge Semin
d in the generic USB HCD binding file so it would be validated against the nodes in which it's specified. Mark the property as deprecated to discourage the developers from using it. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 7 +++ 1 file changed, 7

[PATCH 13/18] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions

2020-10-10 Thread Serge Semin
In accordance with the driver comments the PIPE3 de-emphasis can be tunned to be either -6dB, or -2.5dB or disabled. Let's add the de-emphasis property restriction so the DT schema would make sure the controller DT node is equipped with correct values. Signed-off-by: Serge Semin

[PATCH 05/18] dt-bindings: usb: usb-hcd: Add "tpl-support" property

2020-10-10 Thread Serge Semin
The host controller device might be designed to work for the particular products or applications. In that case it' DT node is supposed to be equipped with the tpl-support property. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 6 ++ 1 file changed, 6

[PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes

2020-10-10 Thread Serge Semin
Amlogic G12A USB DT sub-nodes are supposed to be compatible with the generic DWC USB2 and USB3 devices. Since now we've got DT schemas for both of the later IP cores let's make sure that the Amlogic G12A USB DT nodes are fully evaluated including the DWC sub-nodes. Signed-off-by: Serge Semin

[PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property

2020-10-10 Thread Serge Semin
An empty snps,quirk-frame-length-adjustment won't cause any change performed by the driver. Moreover the DT schema validation will fail, since it expects the property being assigned with some value. So just discard the property declaration then from the example. Signed-off-by: Serge Semin

[PATCH 18/18] dt-bindings: usb: qcom,dwc3: Validate DWC3 sub-node

2020-10-10 Thread Serge Semin
to be named as generic USB HCD ("^usb(@.*)?") we have to accordingly extend the sub-nodes naming space and fix the DT node example. Signed-off-by: Serge Semin --- Alas there are many Qualcomm DTS files, which have got the Qualcomm DWC3 node defined with sub-nodes named as "^dwc3@.*"

[PATCH 17/18] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node

2020-10-10 Thread Serge Semin
TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 compatible sub-node to describe a fully functioning USB interface. Since DWC USB3 has now got a DT schema describing it' DT node, let's make sure the TI Keystone DWC3 sub-node passes validation against it. Signed-off-by: Serge

[PATCH 00/18] dt-bindings: usb: Add generic USB HCD, xHCI, DWC USB3 DT schema

2020-10-10 Thread Serge Semin
aven't fixed the problems denoted above in this patchset for now. So any help, suggestions on how they (especially #1) could be fixed, following up fixup patches would be appropriate. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Andy Gross Cc: Bjorn Andersson Cc: Manu G

[PATCH 0/3] usb: dwc3: ulpi: Fix UPLI registers read/write ops

2020-10-10 Thread Serge Semin
rt") Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (3): usb: dwc3: ulpi: Use VStsDone to detect PHY regs access completion usb: dwc3: ulpi: Replace CPU-based busyloop with Protocol-based one

[PATCH 3/3] usb: dwc3: ulpi: Fix USB2.0 HS/FS/LS PHY suspend regression

2020-10-10 Thread Serge Semin
tionally resume ULPI PHY") Signed-off-by: Serge Semin --- drivers/usb/dwc3/ulpi.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/usb/dwc3/ulpi.c b/drivers/usb/dwc3/ulpi.c index 0dbc826355a5..f23f4c9a557e 100644 --- a/drivers/usb/dwc3/ulpi.c ++

[PATCH 1/3] usb: dwc3: ulpi: Use VStsDone to detect PHY regs access completion

2020-10-10 Thread Serge Semin
, 2.70a, December 2013, p.388 Signed-off-by: Serge Semin --- drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/ulpi.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 2f04b3e42bf1..8d5e5bba1bc2 100644 --- a/drivers/usb/dwc3

[PATCH 01/18] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema

2020-10-10 Thread Serge Semin
The generic USB HCD properties have been described in the legacy bindings text file: Documentation/devicetree/bindings/usb/generic.txt . Let's convert it' content into the USB HCD DT schema properties so all USB DT nodes would be validated to have them properly utilized. Signed-off-by: Serge

[PATCH 2/3] usb: dwc3: ulpi: Replace CPU-based busyloop with Protocol-based one

2020-10-10 Thread Serge Semin
, 2004, pp. 30 - 36. Fixes: 88bc9d194ff6 ("usb: dwc3: add ULPI interface support") Signed-off-by: Serge Semin --- drivers/usb/dwc3/ulpi.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/ulpi.c b/drivers/usb/dwc3/ulpi.c index 20

[PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-10 Thread Serge Semin
It appears that the "maximum-speed" property can also accept the "wireless" value. Add it to the enumeration of the possible property values then. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 07/18] dt-bindings: usb: Convert xHCI bindings to DT schema

2020-10-10 Thread Serge Semin
, single interrupts source, and is supposed to optionally contain up to two reference clocks for the controller core and CSRs. Signed-off-by: Serge Semin --- .../devicetree/bindings/usb/generic-xhci.yaml | 63 +++ .../devicetree/bindings/usb/usb-xhci.txt | 41

[PATCH 03/18] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction

2020-10-10 Thread Serge Semin
There are only four OTG revisions are currently supported by the kernel: 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as invalid. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 12/18] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string

2020-10-10 Thread Serge Semin
opsys, Inc. is presented with just "snps" vendor prefix. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetr

[PATCH 09/18] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file

2020-10-10 Thread Serge Semin
With minor peculiarities (like uploading some vendor-specific firmware) these are just Generic xHCI controllers fully compatible with its properties. Make sure the Renesas USB xHCI DT nodes are also validated against the Generic xHCI DT schema. Signed-off-by: Serge Semin --- Documentation

[PATCH 04/18] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types

2020-10-10 Thread Serge Semin
Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types can be specified in the phy_type HCD property. Add them to the enumeration of the acceptable values. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/usb-hcd.yaml | 10 ++ 1 file changed, 6

[PATCH 11/18] dt-bindings: usb: dwc3: Add interrupt-names property support

2020-10-10 Thread Serge Semin
The controller driver supports two types of DWC USB3 devices: with a common interrupt lane and with individual interrupts for each mode. Add both of these cases support to the DWC USB3 DT schema. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 11

[PATCH 08/18] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-10 Thread Serge Semin
For some reason the "brcm,xhci-brcm-v2" compatible string has been missing in the original bindings file. Add it to the Generic xHCI Controllers DT schema since driver expects it to be supported. Signed-off-by: Serge Semin --- Documentation/devicetree/bindings/usb/generic-xhci.yaml |

Re: [PATCH v2] MIPS: replace add_memory_region with memblock

2020-10-09 Thread Serge Semin
On Fri, Oct 09, 2020 at 02:07:52PM +0200, Thomas Bogendoerfer wrote: > On Thu, Oct 08, 2020 at 06:20:06PM +0300, Serge Semin wrote: > > > Signed-off-by: Thomas Bogendoerfer > > > --- > > > Changes in v2: > > > fixed missing memblock include in fw/sni/s

Re: [PATCH v2] MIPS: replace add_memory_region with memblock

2020-10-08 Thread Serge Semin
On Thu, Oct 08, 2020 at 05:56:17PM +0100, Maciej W. Rozycki wrote: > On Thu, 8 Oct 2020, Serge Semin wrote: > > > > > At least I don't see a decent reason to preserve them. The memory > > > > registration > > > > method does nearly the same sanity checks

Re: [PATCH v2] MIPS: replace add_memory_region with memblock

2020-10-08 Thread Serge Semin
On Thu, Oct 08, 2020 at 09:49:46AM -0700, Florian Fainelli wrote: > > > On 10/8/2020 8:54 AM, Serge Semin wrote: > > On Thu, Oct 08, 2020 at 04:30:35PM +0100, Maciej W. Rozycki wrote: > > > On Thu, 8 Oct 2020, Serge Semin wrote: > > > > > > > At

Re: [PATCH v2] MIPS: replace add_memory_region with memblock

2020-10-08 Thread Serge Semin
On Thu, Oct 08, 2020 at 04:30:35PM +0100, Maciej W. Rozycki wrote: > On Thu, 8 Oct 2020, Serge Semin wrote: > > > At least I don't see a decent reason to preserve them. The memory > > registration > > method does nearly the same sanity checks. The memory reservation f

Re: [PATCH v2] MIPS: replace add_memory_region with memblock

2020-10-08 Thread Serge Semin
Hello Thomas On Thu, Oct 08, 2020 at 10:43:54AM +0200, Thomas Bogendoerfer wrote: > add_memory_region was the old interface for registering memory and > was already changed to used memblock internaly. Replace it by > directly calling memblock functions. Thanks for suggesting this cleanup. It's

[PATCH v4 08/21] spi: dw: Refactor data IO procedure

2020-10-07 Thread Serge Semin
and there in the tx_max(), rx_max(), dw_writer() and dw_reader() methods. Such modification will not only give us the more optimized IO procedures, but will make the data IO methods much more readable than before. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 37

[PATCH v4 19/21] spi: dw: Add poll-based SPI transfers support

2020-10-07 Thread Serge Semin
t iteration. Finally the errors status is checked on each iteration. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 40 ++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index bcfa22

[PATCH v4 02/21] spi: dw: Add DWC SSI capability

2020-10-07 Thread Serge Semin
controller setup to make the dw_spi_update_cr0() method looking coherent. Signed-off-by: Serge Semin --- Changelog v2: - Get back the in-code comments to the dw_spi_update_cr0() method and it' further derivatives. Changelog v3: - Remove dw_spi_update_cr0() callback assignment from the DW APB SSI PCI

[PATCH v4 00/21] spi: dw: Add full Baikal-T1 SPI Controllers support

2020-10-07 Thread Serge Semin
og v4: - Rename dw_spi_get_cr0() to dw_spi_prepare_cr0(). Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Ramil Zaripov Cc: Pavel Parkhomenko Cc: Andy Shevchenko Cc: Andy Shevchenko Cc: Lars Povlsen Cc: wuxu.wu Cc: Feng Tang Cc: Rob Herring Cc: linux-...@vger.kernel.org Cc: devicet...@vg

[PATCH v4 07/21] spi: dw: Add DW SPI controller config structure

2020-10-07 Thread Serge Semin
driver, but by the glue layer drivers too. This will be required in a coming further commit. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 29 + drivers/spi/spi-dw.h | 10 ++ 2 files changed, 27 insertions(+), 12 deletions(-) diff --git

[PATCH v4 09/21] spi: dw: Refactor IRQ-based SPI transfer procedure

2020-10-07 Thread Serge Semin
is sent out, we'll disable the Tx FIFO Empty IRQ. If there is still some data to receive, we'll adjust the Rx FIFO Threshold level, so the next IRQ would be raised at the moment of all incoming data being available in the Rx FIFO. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 33

[PATCH v4 21/21] spi: dw: Add Baikal-T1 SPI Controller glue driver

2020-10-07 Thread Serge Semin
of the DW SPI core module. Co-developed-by: Ramil Zaripov Signed-off-by: Ramil Zaripov Signed-off-by: Serge Semin --- drivers/spi/Kconfig | 28 drivers/spi/Makefile | 1 + drivers/spi/spi-dw-bt1.c | 339 +++ 3 files changed, 368 insertions

[PATCH v4 04/21] spi: dw: Update SPI bus speed in a config function

2020-10-07 Thread Serge Semin
to have a generic function name not related to CR0. Leave the too long line with the chip->clk_div setting as is for now, since it's going to be changed later anyway. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 28 ++-- 1 file changed, 14 insertions(+),

[PATCH v4 12/21] spi: dw: Discard chip enabling on DMA setup error

2020-10-07 Thread Serge Semin
returned from the dma_setup callback to be erroneous as it's supposed to be in the kernel. Signed-off-by: Serge Semin --- drivers/spi/spi-dw-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c index 89e5428c8de6

[PATCH v4 06/21] spi: dw: Update Rx sample delay in the config function

2020-10-07 Thread Serge Semin
Rx sample delay can be SPI device specific, and should be synchronously initialized with the rest of the communication and peripheral device related controller setups. So let's move the Rx-sample delay setup into the DW APB SSI configuration update method. Signed-off-by: Serge Semin --- drivers

[PATCH v4 20/21] dt-bindings: spi: dw: Add Baikal-T1 SPI Controllers

2020-10-07 Thread Serge Semin
-off-by: Serge Semin Reviewed-by: Rob Herring --- .../bindings/spi/snps,dw-apb-ssi.yaml | 33 +-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb

[PATCH v4 05/21] spi: dw: Simplify the SPI bus speed config procedure

2020-10-07 Thread Serge Semin
procedure by removing the clock-related fields from the peripheral chip data and update the DW SPI clock divider only if it's really changed. The later change is reached by keeping the effective SPI bus speed in the internal DW SPI private data. Signed-off-by: Serge Semin --- drivers/spi/spi-dw

<    1   2   3   4   5   6   7   8   9   10   >