Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message

Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h

Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message

Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h

Re: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: This patch adds SoC-specific parameter to avoid reading/writing specific registers wronly if this driver runs on a SoC which doesn't Wrongly? Perhaps "incorrectly"? have dedicated pins (e.g. R-Car D3). Signed-off-by: Yoshihiro Shimoda

Re: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: This patch adds SoC-specific parameter to avoid reading/writing specific registers wronly if this driver runs on a SoC which doesn't Wrongly? Perhaps "incorrectly"? have dedicated pins (e.g. R-Car D3). Signed-off-by: Yoshihiro Shimoda

Re: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

Hello! On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: The previous code assumed a channel has otg capability if a channel has interrupt property. But, it is not good because: - Battery charging feature also needs interrupt property. - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG

Re: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

Hello! On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: The previous code assumed a channel has otg capability if a channel has interrupt property. But, it is not good because: - Battery charging feature also needs interrupt property. - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG

Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file

Hello! On 8/29/2017 12:20 PM, Chunfeng Yun wrote: The mt8173-mtu3.txt actually holds the bindings for all mediatek SoCs with usb3 DRD IP, so add a generic compatible and change the name to mediatek,mtu3.txt. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring

Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file

Hello! On 8/29/2017 12:20 PM, Chunfeng Yun wrote: The mt8173-mtu3.txt actually holds the bindings for all mediatek SoCs with usb3 DRD IP, so add a generic compatible and change the name to mediatek,mtu3.txt. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring --- .../usb/{mt8173-mtu3.txt =>

Re: [PATCH] ravb: make mdiobb_ops const

| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) If you're fixing both Renesas drivers at once, your subject should be "renesas: make mdiobb_ops const". With that fixed, you have my: Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> MBR, Sergei

Re: [PATCH] ravb: make mdiobb_ops const

, 2 insertions(+), 2 deletions(-) If you're fixing both Renesas drivers at once, your subject should be "renesas: make mdiobb_ops const". With that fixed, you have my: Acked-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

Hello! On 8/21/2017 10:52 AM, Romain Perier wrote: Currently, if this logging function is used prior the phy driver is binded to the phy device (that is usually done from .ndo_open), s/binded/bound/. 'phydev->drv' might be NULL, resulting in a kernel crash. That is typically the case in

Re: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print

Hello! On 8/21/2017 10:52 AM, Romain Perier wrote: Currently, if this logging function is used prior the phy driver is binded to the phy device (that is usually done from .ndo_open), s/binded/bound/. 'phydev->drv' might be NULL, resulting in a kernel crash. That is typically the case in

Re: [PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

On 08/18/2017 04:08 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic

Re: [PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

On 08/18/2017 04:08 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc Signed-off-by:

Re: [PATCH] net: stmmac: socfgpa: Ensure emac bit set in sys manager for MII/GMII/SGMII.

Hello! On 8/18/2017 9:55 AM, Stephan Gatzka wrote: When using MII/GMII/SGMII in the Altera SoC, the phy needs to be wired through the FPGA. To ensure correct behavior, the appropriate bit in the System Manager FPGA Interface Group register needs to be set. Signed-off-by: Stephan Gatzka

Re: [PATCH] net: stmmac: socfgpa: Ensure emac bit set in sys manager for MII/GMII/SGMII.

Hello! On 8/18/2017 9:55 AM, Stephan Gatzka wrote: When using MII/GMII/SGMII in the Altera SoC, the phy needs to be wired through the FPGA. To ensure correct behavior, the appropriate bit in the System Manager FPGA Interface Group register needs to be set. Signed-off-by: Stephan Gatzka ---

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 08/17/2017 08:54 PM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 08/17/2017 08:54 PM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH V6 21/21] net-next/hinic: Add netpoll

Hello. On 08/17/2017 03:25 PM, Aviad Krawczyk wrote: Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++

Re: [PATCH V6 21/21] net-next/hinic: Add netpoll

Hello. On 08/17/2017 03:25 PM, Aviad Krawczyk wrote: Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 20 2

Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff

Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

Hello! On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

Hello! On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32746g-eval.dts

Re: [PATCH] sata: ahci-da850: Fix some error handling paths in 'ahci_da850_probe()'

Hello! On 8/16/2017 8:31 AM, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'platform_get_resource()' or 'devm_ioremap()' fail, return -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET --- drivers/ata/ahci_da850.c

Re: [PATCH] sata: ahci-da850: Fix some error handling paths in 'ahci_da850_probe()'

Hello! On 8/16/2017 8:31 AM, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'platform_get_resource()' or 'devm_ioremap()' fail, return -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET --- drivers/ata/ahci_da850.c | 8 ++-- 1 file changed,

Re: [PATCH] netfilter: fix indent on in statements

Hello! On 8/15/2017 9:50 AM, Colin King wrote: From: Colin Ian King The returns on some if statements are not indented correctly, s/in/if/ in the subject? add in the missing tab. Signed-off-by: Colin Ian King [...] MBR, Sergei

Re: [PATCH] netfilter: fix indent on in statements

Hello! On 8/15/2017 9:50 AM, Colin King wrote: From: Colin Ian King The returns on some if statements are not indented correctly, s/in/if/ in the subject? add in the missing tab. Signed-off-by: Colin Ian King [...] MBR, Sergei

Re: [PATCH 3/4] net: sh_eth: constify platform_device_id

dav...@gmail.com> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> though it seems too late as DaveM has taken the series... [...] MBR, Sergei

Re: [PATCH 3/4] net: sh_eth: constify platform_device_id

Hello! On 08/13/2017 02:12 PM, Arvind Yadav wrote: platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav Acked-by: Sergei

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 8/10/2017 3:59 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 8/10/2017 3:59 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN fixed transceiver bindings

On 08/03/2017 12:48 PM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN fixed transceiver bindings

On 08/03/2017 12:48 PM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH] hysdn: fix to a race condition in put_log_buffer

Hello! On 08/03/2017 02:33 PM, Anton Volkov wrote: The synchronization type that was used earlier to guard the loop that deletes unused log buffers may lead to a situation that prevents any thread from going through the loop. The patch deletes previously used synchronization mechanism and

Re: [PATCH] hysdn: fix to a race condition in put_log_buffer

Hello! On 08/03/2017 02:33 PM, Anton Volkov wrote: The synchronization type that was used earlier to guard the loop that deletes unused log buffers may lead to a situation that prevents any thread from going through the loop. The patch deletes previously used synchronization mechanism and

Re: [PATCH v3 3/4] dt-bindings: can: m_can: Include reference to new fixed transceiver binding

On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: Add information regarding fixed transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr

Re: [PATCH v3 3/4] dt-bindings: can: m_can: Include reference to new fixed transceiver binding

On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: Add information regarding fixed transceiver binding. This is especially important for MCAN since the IP allows CAN FD mode to run significantly faster than what most transceivers are capable of. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN fixed transceiver bindings

Hello! On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN fixed transceiver bindings

Hello! On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exists as its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328

Hello! On 08/02/2017 09:24 AM, David Wu wrote: The gmac2phy controller of rk3328 is connected to internal phy directly inside, add the node for the internal phy support. Signed-off-by: David Wu --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 25

Re: [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328

Hello! On 08/02/2017 09:24 AM, David Wu wrote: The gmac2phy controller of rk3328 is connected to internal phy directly inside, add the node for the internal phy support. Signed-off-by: David Wu --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 25 + 1 file changed, 25

[PATCH] phy: rockchip-inno-usb2: fix of_irq_get_byname() error checks

s 0 from rockchip_usb2phy_{host|otg}_port_init(), and thus fail the driver's probe. Fixes: 0e08d2a727e6 ("phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy") Fixes: 98898f3bc83c ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Sergei

[PATCH] phy: rockchip-inno-usb2: fix of_irq_get_byname() error checks

s 0 from rockchip_usb2phy_{host|otg}_port_init(), and thus fail the driver's probe. Fixes: 0e08d2a727e6 ("phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy") Fixes: 98898f3bc83c ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Sergei S

Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

On 07/30/2017 12:04 AM, Sergei Shtylyov wrote: of_irq_get_byname() may return 0 as well as negative error number on failure, while the driver only checks for the negative values. The driver would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never get a valid channel

Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

On 07/30/2017 12:04 AM, Sergei Shtylyov wrote: of_irq_get_byname() may return 0 as well as negative error number on failure, while the driver only checks for the negative values. The driver would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never get a valid channel

Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

Forgot to mention that the patch is against the Linus' repo.

Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

Forgot to mention that the patch is against the Linus' repo.

[PATCH] ti-msgmgr: fix of_irq_get_byname() error check

return -ENXIO from ti_msgmgr_queue_setup() and this fail the driver's probe iff of_irq_get_byname() returned 0. Fixes: aace66b170ce ("mailbox: Introduce TI message manager driver") Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/mailbox/ti-msgmgr

[PATCH] ti-msgmgr: fix of_irq_get_byname() error check

return -ENXIO from ti_msgmgr_queue_setup() and this fail the driver's probe iff of_irq_get_byname() returned 0. Fixes: aace66b170ce ("mailbox: Introduce TI message manager driver") Signed-off-by: Sergei Shtylyov --- drivers/mailbox/ti-msgmgr.c |4 ++-- 1 file changed, 2 insertions

Re: [PATCH 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller

Hello! On 7/27/2017 9:38 AM, Ryder Lee wrote: Add DT bindings for the onboard SATA controller present on the MediaTek SoCs. Signed-off-by: Ryder Lee --- Documentation/devicetree/bindings/ata/ahci-mtk.txt | 48 ++ 1 file changed, 48 insertions(+)

Re: [PATCH 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller

Hello! On 7/27/2017 9:38 AM, Ryder Lee wrote: Add DT bindings for the onboard SATA controller present on the MediaTek SoCs. Signed-off-by: Ryder Lee --- Documentation/devicetree/bindings/ata/ahci-mtk.txt | 48 ++ 1 file changed, 48 insertions(+) create mode 100644

Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764

On 07/25/2017 03:54 PM, Sergei Shtylyov wrote: Since release v2.6.29 the tree has a few references to the Kconfig symbol CPU_SUBTYPE_SH7764 and the Kconfig macro CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was never added to the tree. Perhaps no one noticed because

Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764

On 07/25/2017 03:54 PM, Sergei Shtylyov wrote: Since release v2.6.29 the tree has a few references to the Kconfig symbol CPU_SUBTYPE_SH7764 and the Kconfig macro CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was never added to the tree. Perhaps no one noticed because

Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764

Hello! On 03/11/2013 03:55 PM, Paul Bolle wrote: Since release v2.6.29 the tree has a few references to the Kconfig symbol CPU_SUBTYPE_SH7764 and the Kconfig macro CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was never added to the tree. Perhaps no one noticed because

Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764

Hello! On 03/11/2013 03:55 PM, Paul Bolle wrote: Since release v2.6.29 the tree has a few references to the Kconfig symbol CPU_SUBTYPE_SH7764 and the Kconfig macro CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was never added to the tree. Perhaps no one noticed because

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

Hello! On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

Hello! On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exist as Exists. its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

Hello! On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: Add documentation to describe usage of the new fixed transceiver binding. This new binding is applicable for any CAN device therefore it exist as Exists. its own document. Signed-off-by: Franklin S Cooper Jr ---

Re: [PATCH 1/3] can: m_can: Make hclk optional

Hello! On 7/20/2017 2:09 AM, Franklin S Cooper Jr wrote: Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls.

Re: [PATCH 1/3] can: m_can: Make hclk optional

Hello! On 7/20/2017 2:09 AM, Franklin S Cooper Jr wrote: Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls.

Re: [PATCH V2 net-next 21/21] net-next/hinic: Add select_queue and netpoll

On 7/19/2017 12:19 PM, Aviad Krawczyk wrote: Add more netdev operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 ++ drivers/net/ethernet/huawei/hinic/hinic_main.c |

Re: [PATCH V2 net-next 21/21] net-next/hinic: Add select_queue and netpoll

On 7/19/2017 12:19 PM, Aviad Krawczyk wrote: Add more netdev operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 ++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 35 ++ 2 files changed,

[tip:timers/urgent] clocksource/drivers/timer-of: Handle of_irq_get_byname() result correctly

Commit-ID: 32f2fea6e77e64cd4045ec2d5deb879aada3b476 Gitweb: http://git.kernel.org/tip/32f2fea6e77e64cd4045ec2d5deb879aada3b476 Author: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> AuthorDate: Mon, 17 Jul 2017 21:00:44 +0300 Committer: Thomas Gleixner <t...@linu

[tip:timers/urgent] clocksource/drivers/timer-of: Handle of_irq_get_byname() result correctly

Commit-ID: 32f2fea6e77e64cd4045ec2d5deb879aada3b476 Gitweb: http://git.kernel.org/tip/32f2fea6e77e64cd4045ec2d5deb879aada3b476 Author: Sergei Shtylyov AuthorDate: Mon, 17 Jul 2017 21:00:44 +0300 Committer: Thomas Gleixner CommitDate: Mon, 17 Jul 2017 22:43:00 +0200 clocksource/drivers

[PATCH v2] timer-of: handle of_irq_get_byname() result correctly

init routine") Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- The patch is against the 'tip.git' repo's 'timers/core' branch. Changes in version 2: - fix the function name in the subject; - fix the fat-fingered word in the description. drivers/clocksource/t

[PATCH v2] timer-of: handle of_irq_get_byname() result correctly

init routine") Signed-off-by: Sergei Shtylyov --- The patch is against the 'tip.git' repo's 'timers/core' branch. Changes in version 2: - fix the function name in the subject; - fix the fat-fingered word in the description. drivers/clocksource/timer-of.c | 12 ++-- 1 file c

Re: [PATCH] timer-of: handle of_irq_get() result correctly

Hello! On 07/16/2017 10:55 PM, Sergei Shtylyov wrote: of_irq_get_byname() may return a negative error number as well as 0 on failure, while timer_irq_init() only checks for 0, blithely continuing with the call to request_[percpu_]irq() -- those functions expect *unsigned int*, so would

Re: [PATCH] timer-of: handle of_irq_get() result correctly

Hello! On 07/16/2017 10:55 PM, Sergei Shtylyov wrote: of_irq_get_byname() may return a negative error number as well as 0 on failure, while timer_irq_init() only checks for 0, blithely continuing with the call to request_[percpu_]irq() -- those functions expect *unsigned int*, so would

[PATCH] timer-of: handle of_irq_get() result correctly

init routine") Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- The patcn is against the 'tip.git' repo's 'timers/core' branch. drivers/clocksource/timer-of.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Index: tip/drivers/clocks

[PATCH] timer-of: handle of_irq_get() result correctly

init routine") Signed-off-by: Sergei Shtylyov --- The patcn is against the 'tip.git' repo's 'timers/core' branch. drivers/clocksource/timer-of.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Index: tip/drivers/clocksource/

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. drivers/ata/pata_imx.c | 5 +++-- 1 file

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: Print error message on platform_get_irq failure before return. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Print the return value of platform_get_irq on failure. drivers/ata/pata_imx.c | 5 +++-- 1 file changed, 3 insertions(+),

Re: [PATCH] sata_highbank: fix error return code in ahci_highbank_probe()

On 06/30/2017 08:03 AM, Gustavo A. R. Silva wrote: Propagate the return value of platform_get_irq on failure. Needs the same explanations as the sata_rcar patch. Signed-off-by: Gustavo A. R. Silva [...] MBR, Sergei

Re: [PATCH] sata_highbank: fix error return code in ahci_highbank_probe()

On 06/30/2017 08:03 AM, Gustavo A. R. Silva wrote: Propagate the return value of platform_get_irq on failure. Needs the same explanations as the sata_rcar patch. Signed-off-by: Gustavo A. R. Silva [...] MBR, Sergei

Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

on error. Print error message and propagate the return value of platform_get_irq on failure. Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> You forgot to collect: Acked-by: Sergei Shtylyov &

Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

on error. Print error message and propagate the return value of platform_get_irq on failure. Cc: Sergei Shtylyov Signed-off-by: Gustavo A. R. Silva You forgot to collect: Acked-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 12:42 PM, Sergei Shtylyov wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. It's prolly also worth mentioning that enforcing the error # on return

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 12:42 PM, Sergei Shtylyov wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. It's prolly also worth mentioning that enforcing the error # on return

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

com> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> MBR, Sergei

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Signed-off-by: Gustavo A. R. Silva Acked-by: Sergei

Re: [PATCH] batman-adv: fix spelling mistake "ourselve" -> "ourself"

Hello! On 6/26/2017 12:56 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in batadv_dbg debug message Signed-off-by: Colin Ian King --- net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] batman-adv: fix spelling mistake "ourselve" -> "ourself"

Hello! On 6/26/2017 12:56 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in batadv_dbg debug message Signed-off-by: Colin Ian King --- net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/bat_v_ogm.c

Re: [PATCH] batman-adv: fix spelling mistake "ourselve" -> "ourself"

On 6/26/2017 1:01 PM, Sergei Shtylyov wrote: From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistake in batadv_dbg debug message Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 ins

Re: [PATCH] batman-adv: fix spelling mistake "ourselve" -> "ourself"

On 6/26/2017 1:01 PM, Sergei Shtylyov wrote: From: Colin Ian King Trivial fix to spelling mistake in batadv_dbg debug message Signed-off-by: Colin Ian King --- net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net

Re: [PATCH] virtio_net: lower limit on buffer size

On 06/02/2017 11:25 PM, J. Bruce Fields wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for

Re: [PATCH] virtio_net: lower limit on buffer size

On 06/02/2017 11:25 PM, J. Bruce Fields wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for

Re: [PATCH] virtio_net: lower limit on buffer size

Hello! On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing

Re: [PATCH] virtio_net: lower limit on buffer size

Hello! On 6/2/2017 2:56 AM, Michael S. Tsirkin wrote: commit d85b758f72b0 "virtio_net: fix support for small rings" Commit d85b758f72b0 ("virtio_net: fix support for small rings") was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

Hello! Why "soc_camera:" in the subject? The 'soc_camera" driver has been removed (replaced by a "normal" V4L2 driver). MBR, Sergei

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

Hello! Why "soc_camera:" in the subject? The 'soc_camera" driver has been removed (replaced by a "normal" V4L2 driver). MBR, Sergei

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

On 05/24/2017 11:39 PM, Jason A. Donenfeld wrote: I've only looked on the last 2 patches. You can add my: Reviewed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> if you want. :-) Will do. For the series, or just for 5/5? 5/5 only. :-) MBR, Sergei

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

On 05/24/2017 11:39 PM, Jason A. Donenfeld wrote: I've only looked on the last 2 patches. You can add my: Reviewed-by: Sergei Shtylyov if you want. :-) Will do. For the series, or just for 5/5? 5/5 only. :-) MBR, Sergei

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

trivially when/if he merges this v9, which would be faster.) Barring that, does this look good to you? Could I have your signed-off-by? I've only looked on the last 2 patches. You can add my: Reviewed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> if you want. :-) Regards, Jason

Re: [PATCH net-next v9 5/5] virtio_net: check return value of skb_to_sgvec always

trivially when/if he merges this v9, which would be faster.) Barring that, does this look good to you? Could I have your signed-off-by? I've only looked on the last 2 patches. You can add my: Reviewed-by: Sergei Shtylyov if you want. :-) Regards, Jason MBR, Sergei

<    2   3   4   5   6   7   8   9   10   11   >