Re: [PATCH] igb: Explicitly select page 0 at initialization

Hello. On 11/24/2016 1:32 PM, Matwey V. Kornilov wrote: The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were removed in 2a3cdea) explicitly selected the required page at every phy_reg This is not the way to cite a commit -- you need to specify at least 12 digits and

Re: [PATCH] igb: Explicitly select page 0 at initialization

Hello. On 11/24/2016 1:32 PM, Matwey V. Kornilov wrote: The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were removed in 2a3cdea) explicitly selected the required page at every phy_reg This is not the way to cite a commit -- you need to specify at least 12 digits and

Re: [PATCH] usb: xhci: Remove unuseful 'return' statement

Hello. On 11/24/2016 11:13 AM, Baolin Wang wrote: Since these 'return' statements are not generally useful in void function, remove them. Signed-off-by: Baolin Wang [...] diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 48a26d378..d6f59a3

Re: [PATCH] usb: xhci: Remove unuseful 'return' statement

Hello. On 11/24/2016 11:13 AM, Baolin Wang wrote: Since these 'return' statements are not generally useful in void function, remove them. Signed-off-by: Baolin Wang [...] diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 48a26d378..d6f59a3 100644 ---

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

Hello. On 11/17/2016 6:01 PM, Roger Quadros wrote: From: Felipe Balbi Some devices from Texas Instruments [1] suffer from a silicon bug where Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

Hello. On 11/17/2016 6:01 PM, Roger Quadros wrote: From: Felipe Balbi Some devices from Texas Instruments [1] suffer from a silicon bug where Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an IRQ for device

Re: [PATCH] net: 3com: typhoon: fix typhoon_get_link_ksettings

Hello. On 11/5/2016 6:11 PM, Philippe Reynes wrote: When moving from typhoon_get_settings to typhoon_getlink_ksettings in the commit commit f7a5537cd2a5 ("net: 3com: typhoon: use new api One "commit" is enough. :-) ethtool_{get|set}_link_ksettings"), we use a local variable supported

Re: [PATCH] net: 3com: typhoon: fix typhoon_get_link_ksettings

Hello. On 11/5/2016 6:11 PM, Philippe Reynes wrote: When moving from typhoon_get_settings to typhoon_getlink_ksettings in the commit commit f7a5537cd2a5 ("net: 3com: typhoon: use new api One "commit" is enough. :-) ethtool_{get|set}_link_ksettings"), we use a local variable supported

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

On 11/4/2016 7:30 PM, Jon Mason wrote: Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

On 11/4/2016 7:30 PM, Jon Mason wrote: Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17 insertions(+)

Re: [PATCH v4 3/4] usb: musb: Add a quirk flag to skip the phy set mode

Hello. On 11/04/2016 07:43 PM, Alexandre Bailon wrote: During the init, the driver will use the mode to configure the controller mode and the phy mode. PHY -- be consistent please... The PHY of DA8xx has some issues when the phy is forced in host or device. Again. Add way to skip

Re: [PATCH v4 3/4] usb: musb: Add a quirk flag to skip the phy set mode

Hello. On 11/04/2016 07:43 PM, Alexandre Bailon wrote: During the init, the driver will use the mode to configure the controller mode and the phy mode. PHY -- be consistent please... The PHY of DA8xx has some issues when the phy is forced in host or device. Again. Add way to skip

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

Hello. On 11/4/2016 8:11 AM, Jon Mason wrote: Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

Hello. On 11/4/2016 8:11 AM, Jon Mason wrote: Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device tree Signed-off-by: Jon Mason --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 + arch/arm64/boot/dts/broadcom/ns2.dtsi| 12 2 files changed, 17

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

On 11/3/2016 9:48 AM, Lu Baolu wrote: cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is Structure. not used any more. This patch removes it. Signed-off-by: Lu Baolu [...] MBR,

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

On 11/3/2016 9:48 AM, Lu Baolu wrote: cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is Structure. not used any more. This patch removes it. Signed-off-by: Lu Baolu [...] MBR, Sergei

Re: [PATCH v4 4/4] MIPS: Deprecate VPE Loader

Hello. On 11/2/2016 7:11 PM, Matt Redfearn wrote: The MIPS remote processor driver (CONFIG_MIPS_REMOTEPROC) provides a more standard mechanism for using one or more VPs as coprocessors running separate firmware. Here we deprecate this mechanism before it is removed. Signed-off-by: Matt

Re: [PATCH v4 4/4] MIPS: Deprecate VPE Loader

Hello. On 11/2/2016 7:11 PM, Matt Redfearn wrote: The MIPS remote processor driver (CONFIG_MIPS_REMOTEPROC) provides a more standard mechanism for using one or more VPs as coprocessors running separate firmware. Here we deprecate this mechanism before it is removed. Signed-off-by: Matt

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

On 11/02/2016 08:24 PM, Jon Mason wrote: Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

On 11/02/2016 08:24 PM, Jon Mason wrote: Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file changed, 11

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Hello. On 11/02/2016 08:08 PM, Jon Mason wrote: Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++-

Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac

Hello. On 11/02/2016 08:08 PM, Jon Mason wrote: Clean-up the documentation to the bgmac-amac driver, per suggestion by Rob Herring, and add details for NS2 support. Signed-off-by: Jon Mason --- Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++- 1 file changed, 11

Re: [PATCH v4 20/23] ARM: shmobile: rcar-gen2: Stop passing mode pins state to clock driver

On 10/21/2016 04:17 PM, Geert Uytterhoeven wrote: Now the R-Car Gen2 CPG clock driver obtains the state of the mode pins from the R-Car RST driver, there's no longer a need to pass this state explicitly. Hence we can just call of_clk_init() instead. Signed-off-by: Geert Uytterhoeven

Re: [PATCH v4 20/23] ARM: shmobile: rcar-gen2: Stop passing mode pins state to clock driver

On 10/21/2016 04:17 PM, Geert Uytterhoeven wrote: Now the R-Car Gen2 CPG clock driver obtains the state of the mode pins from the R-Car RST driver, there's no longer a need to pass this state explicitly. Hence we can just call of_clk_init() instead. Signed-off-by: Geert Uytterhoeven Acked-by:

Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY

Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++ 1 file changed, 45

Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY

Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++ 1 file changed, 45 insertions(+) diff --git

Re: [PATCH 1/2] swiotlb: Rate-limit printing when running out of SW-IOMMU space

On 10/31/2016 06:45 PM, Geert Uytterhoeven wrote: If the system runs out of SW-IOMMU space, changes are high successive s/changes/chances/? requests will fail, too, flooding the kernel log. This is true especially for streaming DMA, which is typically used repeatedly outside the

Re: [PATCH 1/2] swiotlb: Rate-limit printing when running out of SW-IOMMU space

On 10/31/2016 06:45 PM, Geert Uytterhoeven wrote: If the system runs out of SW-IOMMU space, changes are high successive s/changes/chances/? requests will fail, too, flooding the kernel log. This is true especially for streaming DMA, which is typically used repeatedly outside the

Re: [PATCH v2 5/7] MIPS: jz4740: DTS: Probe the jz4740-rtc driver from devicetree

Hello. On 10/31/2016 2:02 AM, Paul Cercueil wrote: Now that the jz4740-rtc driver supports devicetree, we can add a devicetree node for it. Signed-off-by: Paul Cercueil Acked-by: Maarten ter Huurne --- arch/mips/boot/dts/ingenic/jz4740.dtsi |

Re: [PATCH v2 5/7] MIPS: jz4740: DTS: Probe the jz4740-rtc driver from devicetree

Hello. On 10/31/2016 2:02 AM, Paul Cercueil wrote: Now that the jz4740-rtc driver supports devicetree, we can add a devicetree node for it. Signed-off-by: Paul Cercueil Acked-by: Maarten ter Huurne --- arch/mips/boot/dts/ingenic/jz4740.dtsi | 11 +++ 1 file changed, 11

Re: [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver

Hello. On 10/31/2016 2:02 AM, Paul Cercueil wrote: This commit adds documentation for the device-tree bindings of the jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and JZ4780 SoCs from Ingenic. Signed-off-by: Paul Cercueil Acked-by: Maarten ter

Re: [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver

Hello. On 10/31/2016 2:02 AM, Paul Cercueil wrote: This commit adds documentation for the device-tree bindings of the jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and JZ4780 SoCs from Ingenic. Signed-off-by: Paul Cercueil Acked-by: Maarten ter Huurne ---

Re: [PATCH v2] usb: musb: remove duplicated actions

On 10/26/2016 03:01 PM, Kirill Esipov wrote: Removing unnecessary duplicated actions that we've got while merging: "Merge 4.1-rc7 into usb-next" 19915e623458 See Documentation/SubmittingPatches, it should be: 19915e623458 ("Merge 4.1-rc7 into usb-next"). Perhaps the MUSB maintainer can

Re: [PATCH v2] usb: musb: remove duplicated actions

On 10/26/2016 03:01 PM, Kirill Esipov wrote: Removing unnecessary duplicated actions that we've got while merging: "Merge 4.1-rc7 into usb-next" 19915e623458 See Documentation/SubmittingPatches, it should be: 19915e623458 ("Merge 4.1-rc7 into usb-next"). Perhaps the MUSB maintainer can

Re: [PATCH] usb: musb: remove duplicated actions

Hello. On 10/26/2016 2:12 PM, Kirill Esipov wrote: Remove unnecessary duplicate actions (that we've got here: 19915e623458004547c1c2490b09bb923fe69337) You should also specify the commit's summary line in (""). And it's enough to specify 12 digits of SHA1 ID. Signed-off-by: Kirill

Re: [PATCH] usb: musb: remove duplicated actions

Hello. On 10/26/2016 2:12 PM, Kirill Esipov wrote: Remove unnecessary duplicate actions (that we've got here: 19915e623458004547c1c2490b09bb923fe69337) You should also specify the commit's summary line in (""). And it's enough to specify 12 digits of SHA1 ID. Signed-off-by: Kirill

Re: [PATCH 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

Hello. On 10/25/2016 05:39 PM, Alexandre Bailon wrote: From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c |

Re: [PATCH 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

Hello. On 10/25/2016 05:39 PM, Alexandre Bailon wrote: From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 76 ++-- 1

Re: [PATCH] clk: fix link error for rcar-gen2

Hello. On 10/21/2016 06:47 PM, Arnd Bergmann wrote: The addition of one more rcar-gen2 based SoC caused a build error (again) in my randconfig builds: arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init': setup-rcar-gen2.c:(.init.text+0x200): undefined reference to

Re: [PATCH] clk: fix link error for rcar-gen2

Hello. On 10/21/2016 06:47 PM, Arnd Bergmann wrote: The addition of one more rcar-gen2 based SoC caused a build error (again) in my randconfig builds: arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init': setup-rcar-gen2.c:(.init.text+0x200): undefined reference to

Re: [PATCH] MIPS: KASLR: Fix handling of NULL FDT

Hello. On 10/17/2016 01:04 PM, Matt Redfearn wrote: If platform code returns a NULL pointer to the FDT, initial_boot_params will not get set to a valid pointer and attempting to find the /chosen node in it will cause a NULL pointer dereference and the kernel to crash immediately on startup -

Re: [PATCH] MIPS: KASLR: Fix handling of NULL FDT

Hello. On 10/17/2016 01:04 PM, Matt Redfearn wrote: If platform code returns a NULL pointer to the FDT, initial_boot_params will not get set to a valid pointer and attempting to find the /chosen node in it will cause a NULL pointer dereference and the kernel to crash immediately on startup -

Re: [PATCH/RFT 11/12] ARM: dts: da850: Add the usb ohci device node

Hello. On 10/07/2016 07:42 PM, ahas...@baylibre.com wrote: From: Axel Haslam This adds the device tree node for the usb11 (ohci) controller present in the da850 family of SoC's. Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850.dtsi | 8

Re: [PATCH/RFT 11/12] ARM: dts: da850: Add the usb ohci device node

Hello. On 10/07/2016 07:42 PM, ahas...@baylibre.com wrote: From: Axel Haslam This adds the device tree node for the usb11 (ohci) controller present in the da850 family of SoC's. Signed-off-by: Axel Haslam --- arch/arm/boot/dts/da850.dtsi | 8 1 file changed, 8 insertions(+) diff

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

On 10/07/2016 07:27 PM, Sergei Shtylyov wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

On 10/07/2016 07:27 PM, Sergei Shtylyov wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The fix

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

Hello. On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

Hello. On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote: When hardware header is added without using cached one, neigh_resolve_output and neigh_connected_output reset skb to network header before adding it. When cached one is used, neigh_hh_output does not reset the skb to network header. The

Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages

Hello. On 10/04/2016 02:06 PM, Colin King wrote: From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- 1 file changed,

Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages

Hello. On 10/04/2016 02:06 PM, Colin King wrote: From: Colin Ian King Trival fix, dev_err messages are missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes

Hello. On 9/30/2016 3:11 PM, Johannes Thumshirn wrote: The call to krealloc() in wsm_buf_reserve() directly assigns the newly returned memory to buf->begin. This is all fine except when krealloc() failes we loose the ability to free the old memory pointed to by Fails. buf->begin. If we

Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes

Hello. On 9/30/2016 3:11 PM, Johannes Thumshirn wrote: The call to krealloc() in wsm_buf_reserve() directly assigns the newly returned memory to buf->begin. This is all fine except when krealloc() failes we loose the ability to free the old memory pointed to by Fails. buf->begin. If we

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

Hello. On 09/26/2016 06:44 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 26 Sep 2016 17:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

Hello. On 09/26/2016 06:44 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 26 Sep 2016 17:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. WARNING:

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

Hello. On 9/25/2016 2:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 25 Sep 2016 12:50:21 +0200 Do not use curly brackets at eight source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

Hello. On 9/25/2016 2:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 25 Sep 2016 12:50:21 +0200 Do not use curly brackets at eight source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- drivers/isdn/capi/capidrv.c | 30

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be

Re: [PATCH] mos7840: fix chars_in_buffer() return value

Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars

Re: [PATCH] mos7840: fix chars_in_buffer() return value

Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

On 09/23/2016 06:16 PM, David Howells wrote: Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

On 09/23/2016 06:16 PM, David Howells wrote: Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

Hello. On 09/23/2016 06:16 PM, David Howells wrote: When rxrpc_input_soft_acks() is parsing the soft-ACKs from an ACK packet, it updates the Tx packet annotations in the annotation buffer. If a soft-ACK is an ACK, then we overwrite unack'd, nak'd or to-be-retransmitted states and that is

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

Hello. On 09/23/2016 06:16 PM, David Howells wrote: When rxrpc_input_soft_acks() is parsing the soft-ACKs from an ACK packet, it updates the Tx packet annotations in the annotation buffer. If a soft-ACK is an ACK, then we overwrite unack'd, nak'd or to-be-retransmitted states and that is

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

Hello. On 9/23/2016 3:13 AM, David Miller wrote: Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. IIRC, I had only commented to v2, not v1. I'll wait longer next time. Thank you. :-) MBR, Sergei

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

Hello. On 9/23/2016 3:13 AM, David Miller wrote: Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. IIRC, I had only commented to v2, not v1. I'll wait longer next time. Thank you. :-) MBR, Sergei

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

Hello. On 9/23/2016 6:32 AM, Sean Wang wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. .. deleted What? Why? switch (of_get_phy_mode(np)) { + case

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

Hello. On 9/23/2016 6:32 AM, Sean Wang wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. .. deleted What? Why? switch (of_get_phy_mode(np)) { + case PHY_INTERFACE_MODE_TRGMII: +

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

Hello. On 09/22/2016 03:22 PM, David Miller wrote: By default, GMAC0 is connected to built-in switch called MT7530 through the proprietary interface called Turbo RGMII (TRGMII). TRGMII also supports well for RGMII as generic external PHY uses but requires some slight changes to the setup of

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

Hello. On 09/22/2016 03:22 PM, David Miller wrote: By default, GMAC0 is connected to built-in switch called MT7530 through the proprietary interface called Turbo RGMII (TRGMII). TRGMII also supports well for RGMII as generic external PHY uses but requires some slight changes to the setup of

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

I reviewed been merged already, why are you sending an incremental patch? Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sean Wang <sean.w...@mediatek.com> [...] MBR, Sergei

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

hy are you sending an incremental patch? Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang [...] MBR, Sergei

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

On 09/22/2016 01:44 PM, Sergei Shtylyov wrote: Looks like your patch summary and description got merged together in the subject. Also, the subject (summary) should contain driver name as a prefix: "pata_at91: Use ..." Signed-off-by: Harman Kalra <harman4li...@gmail.com&

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

On 09/22/2016 01:44 PM, Sergei Shtylyov wrote: Looks like your patch summary and description got merged together in the subject. Also, the subject (summary) should contain driver name as a prefix: "pata_at91: Use ..." Signed-off-by: Harman Kalra [...] MBR, Sergei

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. and adds a variable trgmii inside mtk_mac as the indication to make the

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. and adds a variable trgmii inside mtk_mac as the indication to make the difference between the MAC

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 - 1

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

Hello. On 9/21/2016 10:48 PM, Harman Kalra wrote: Looks like your patch summary and description got merged together in the subject. Signed-off-by: Harman Kalra [...] MBR, Sergei

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

Hello. On 9/21/2016 10:48 PM, Harman Kalra wrote: Looks like your patch summary and description got merged together in the subject. Signed-off-by: Harman Kalra [...] MBR, Sergei

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

Hello. On 9/20/2016 9:30 AM, Joel Stanley wrote: On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200:

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

Hello. On 9/20/2016 9:30 AM, Joel Stanley wrote: On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200:

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

On 9/20/2016 1:34 PM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node? Hi

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

On 9/20/2016 1:34 PM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node? Hi Sergei, Yes, strictly

Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader

Hello. On 9/20/2016 11:47 AM, Matt Redfearn wrote: The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more standard mechanism for using one or more VPs as coprocessors running separate firmware. Here we deprecate this mechanism before it is removed. Signed-off-by: Matt Redfearn

Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader

Hello. On 9/20/2016 11:47 AM, Matt Redfearn wrote: The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more standard mechanism for using one or more VPs as coprocessors running separate firmware. Here we deprecate this mechanism before it is removed. Signed-off-by: Matt Redfearn

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

Hello. On 9/20/2016 12:21 AM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node?

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

Hello. On 9/20/2016 12:21 AM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node?

Re: [PATCH v3 1/3] usb: chipidea: imx: Change switch order

Hello. On 9/19/2016 1:22 PM, Fabien Lahoudere wrote: Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index Switch. and then test for features if they exist for this index. Signed-off-by:

Re: [PATCH v3 1/3] usb: chipidea: imx: Change switch order

Hello. On 9/19/2016 1:22 PM, Fabien Lahoudere wrote: Each USB controller have different behaviour, so in order to avoid to have several "swicth(data->index)" and lock/unlock, we prefer to get the index Switch. and then test for features if they exist for this index. Signed-off-by:

Re: [RFC PATCH] xhci: do not halt the secondary HCD

Hello. On 9/19/2016 9:35 AM, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while

Re: [RFC PATCH] xhci: do not halt the secondary HCD

Hello. On 9/19/2016 9:35 AM, Joel Stanley wrote: We can't halt the secondary HCD, because it's also the primary HCD, which will cause problems if we have devices attached to the primary HCD, like a keyboard. We've been carrying this in our Linux-as-a-bootloader environment for a little while

Re: [PATCH] net: mvneta: mark symbols static where possible

Hello. On 9/18/2016 12:20 PM, Baoyou Xie wrote: We get 2 warnings when building kernel with W=1: drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes] drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous

Re: [PATCH] net: mvneta: mark symbols static where possible

Hello. On 9/18/2016 12:20 PM, Baoyou Xie wrote: We get 2 warnings when building kernel with W=1: drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes] drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous

Re: [PATCH net-next 11/11] rxrpc: Add config to inject packet loss

Hello. On 9/18/2016 2:22 AM, David Howells wrote: Add a configuration option to inject packet loss by discarding approximately every 8th packet received and approximately every 8th DATA packet transmitted. Note that no locking is used, but it shouldn't really matter. Signed-off-by: David

Re: [PATCH net-next 11/11] rxrpc: Add config to inject packet loss

Hello. On 9/18/2016 2:22 AM, David Howells wrote: Add a configuration option to inject packet loss by discarding approximately every 8th packet received and approximately every 8th DATA packet transmitted. Note that no locking is used, but it shouldn't really matter. Signed-off-by: David

Re: [RFC V3 PATCH 22/26] net/netpolicy: set per task policy by proc

On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Users may not want to change the source code to add per task net polic Policy? support. Or they may want to change a running task's net policy. prctl does not work for both cases. This patch adds

Re: [RFC V3 PATCH 22/26] net/netpolicy: set per task policy by proc

On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Users may not want to change the source code to add per task net polic Policy? support. Or they may want to change a running task's net policy. prctl does not work for both cases. This patch adds an interface in /proc,

Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

Hello. On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Net policy needs to know device information. Currently, it's enough to only get irq information of rx and tx queues. This patch introduces ndo ops to do so, not ethtool ops. Because there are

Re: [RFC V3 PATCH 03/26] net/netpolicy: get device queue irq information

Hello. On 09/12/2016 05:55 PM, kan.li...@intel.com wrote: From: Kan Liang Net policy needs to know device information. Currently, it's enough to only get irq information of rx and tx queues. This patch introduces ndo ops to do so, not ethtool ops. Because there are already several ways to

<    5   6   7   8   9   10   11   12   13   14   >