[PATCH v3] staging: lustre: libcfs: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky --- v3: Wrap commit message at 72 cols, and remove filename from subject line. v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h. drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++ drivers

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote: > This lines are way too long. You should break the commit message line > around 72nd column so that it looks nice when emailed. > > You can also omit the filename from the topic line as this is already in > the diff. Thanks for

[PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky --- v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h. drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++ drivers/staging/lustre/lustre/libcfs/module.c| 2 -- 2 files changed, 3

[PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h. drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++ drivers/staging/lustre/lustre/libcfs/module.c| 2

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote: This lines are way too long. You should break the commit message line around 72nd column so that it looks nice when emailed. You can also omit the filename from the topic line as this is already in the diff. Thanks for the

[PATCH v3] staging: lustre: libcfs: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- v3: Wrap commit message at 72 cols, and remove filename from subject line. v2: Don't break the build, and fix the warnings by defining the functions in libcfs.h. drivers/staging/lustre/include/linux/libcfs

Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote: > > If you look at the source code just below these functions you will find: > > EXPORT_SYMBOL(libcfs_arch_init); > EXPORT_SYMBOL(libcfs_arch_cleanup); > > So making these static is incorrect because they are being used outside >

[PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky --- drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c b/drivers/staging/lustre/lustre/libcfs/linux/linux

[PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

. Should it be static? Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c b/drivers/staging

Re: [PATCH] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote: If you look at the source code just below these functions you will find: EXPORT_SYMBOL(libcfs_arch_init); EXPORT_SYMBOL(libcfs_arch_cleanup); So making these static is incorrect because they are being used outside of this

[PATCH] staging: rtl8188eu: rtw_mlme.c: fix sparse warning

Fixes the following sparse warning for rtw_mlme.c: drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in 'rtw_free_assoc_resources' - different lock contexts for basic block Signed-off-by: Serguey Parkhomovsky --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 37

[PATCH] staging: rtl8188eu: rtw_mlme.c: fix sparse warning

Fixes the following sparse warning for rtw_mlme.c: drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in 'rtw_free_assoc_resources' - different lock contexts for basic block Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- drivers/staging/rtl8188eu

Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

> > This sort of test is generally better where the > individual tests are written on separate lines like: > > if ((data[idx] != pktdata[i]) || > (data[idx+1] != pktdata[i+1])) { > Thanks for all the suggestions, Joe. I'll upload a revised patch

[PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

This patch fixes two unnecessary else conditions that were found by checkpatch.pl. Signed-off-by: Serguey Parkhomovsky --- v2: use negation instead of comparing to false in if statement (suggested by Joe Perches) drivers/staging/rtl8712/rtl8712_efuse.c | 40

[PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

This patch fixes two unnecessary else conditions that were found by checkpatch.pl. Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- v2: use negation instead of comparing to false in if statement (suggested by Joe Perches) drivers/staging/rtl8712/rtl8712_efuse.c | 40

Re: [PATCH v2] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

This sort of test is generally better where the individual tests are written on separate lines like: if ((data[idx] != pktdata[i]) || (data[idx+1] != pktdata[i+1])) { Thanks for all the suggestions, Joe. I'll upload a revised patch soon.

[PATCH] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

This patch fixes two unnecessary else conditions that were found by checkpatch.pl. Signed-off-by: Serguey Parkhomovsky --- drivers/staging/rtl8712/rtl8712_efuse.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8712

[PATCH] staging: rtl8712: fix unnecessary elses after return/break in rtl8712_efuse.c

This patch fixes two unnecessary else conditions that were found by checkpatch.pl. Signed-off-by: Serguey Parkhomovsky sergueyparkhomov...@gmail.com --- drivers/staging/rtl8712/rtl8712_efuse.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git