[PATCH] ext4 crypto: prevent mount when blocksize != pagesize

2015-06-11 Thread Seunghun Lee
Encryption mode is unsupported when blocksize != pagesize. Signed-off-by: Seunghun Lee --- fs/ext4/super.c | 9 + 1 file changed, 9 insertions(+) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 31e85be..032c9e3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1583,6 +1583,15

[PATCH] ext4 crypto: prevent mount when blocksize != pagesize

2015-06-11 Thread Seunghun Lee
Encryption mode is unsupported when blocksize != pagesize. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ext4/super.c | 9 + 1 file changed, 9 insertions(+) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 31e85be..032c9e3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c

Re: [PATCH] ovl: Fix condition check for workdir

2015-01-09 Thread Seunghun Lee
On 01/09/2015 11:40 AM, hujianyang wrote: > On 2015/1/8 20:41, Seunghun Lee wrote: >> When file system is mounted read-only workdir is not needed. >> >> Signed-off-by: Seunghun Lee >> --- >> fs/overlayfs/super.c | 35 +++ >>

Re: [PATCH] ovl: Fix condition check for workdir

2015-01-09 Thread Seunghun Lee
On 01/09/2015 11:40 AM, hujianyang wrote: On 2015/1/8 20:41, Seunghun Lee wrote: When file system is mounted read-only workdir is not needed. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 35 +++ 1 file changed, 23 insertions

[PATCH] ovl: Fix condition check for workdir

2015-01-08 Thread Seunghun Lee
When file system is mounted read-only workdir is not needed. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 84f3144..4e50617 100644

[PATCH] ovl: Fix condition check for workdir

2015-01-08 Thread Seunghun Lee
When file system is mounted read-only workdir is not needed. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index 84f3144

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-07 Thread Seunghun Lee
Hi Hu, On 01/07/2015 11:56 AM, hujianyang wrote: > Hi, > > There maybe some misunderstandings here. I think your patch really > fix an important problem, but not in correct way. > > On 2015/1/6 22:02, Seunghun Lee wrote: >> After patch: >> root@qemux86:~# mount

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-07 Thread Seunghun Lee
Hi Hu, On 01/07/2015 11:56 AM, hujianyang wrote: Hi, There maybe some misunderstandings here. I think your patch really fix an important problem, but not in correct way. On 2015/1/6 22:02, Seunghun Lee wrote: After patch: root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread Seunghun Lee
On 01/04/2015 11:59 AM, hujianyang wrote: > I think this exporting of .remount_fs may allow people in userspace have the > ability to remount a filesystem with a new set of mounting options. Your new > adding function do nothing with the passing in parameters. I'm not sure if it > could be

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread Seunghun Lee
On 01/04/2015 11:59 AM, hujianyang wrote: I think this exporting of .remount_fs may allow people in userspace have the ability to remount a filesystem with a new set of mounting options. Your new adding function do nothing with the passing in parameters. I'm not sure if it could be

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper-fs is read-only or nonexistent. But now it can be remounted read-write and this can cause kernel panic. So we should prevent read-write remount when the above situation happens. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 11

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
On 01/02/2015 03:33 AM, Sedat Dilek wrote: > On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee wrote: >> Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. >> But now it can be remounted read-write and this can causes kernel panic. >> So we should preve

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
On 01/02/2015 03:33 AM, Sedat Dilek wrote: On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper-fs is read-only or nonexistent. But now it can be remounted read-write and this can cause kernel panic. So we should prevent read-write remount when the above situation happens. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 11 +++ 1 file

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
On 01/02/2015 12:24 AM, Sedat Dilek wrote: > On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger > wrote: >> On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee wrote: >>> Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. >>> But now it can be rem

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
On 01/02/2015 12:24 AM, Sedat Dilek wrote: On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger richard.weinber...@gmail.com wrote: On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 11

[PATCH] ovl: Prevent rw remount when it should be ro mount

2014-12-31 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 8 1 file changed

[PATCH] ovl: Prevent rw remount when it should be ro mount

2014-12-31 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 8

Re: [PATCH] vfs: move getname() from callers to do_mount()

2014-09-14 Thread Seunghun Lee
On September 15, 2014 2:18:50 PM GMT+09:00, Al Viro wrote: >On Mon, Sep 15, 2014 at 01:39:19PM +0900, Seunghun Lee wrote: >> 2014. 9. 15. 오전 3:13에 "Al Viro" wrote: >> > Applied with one modification: this getname/kern_path/putname is > >> Ok, I will resen

[PATCH] vfs: move getname() from callers to do_mount()

2014-09-14 Thread Seunghun Lee
It would make more sense to pass char __user * instead of char * in callers of do_mount() and do getname() inside do_mount(). Suggested-by: Al Viro Signed-off-by: Seunghun Lee --- arch/alpha/kernel/osf_sys.c | 23 ++- fs/compat.c | 20

[PATCH] vfs: move getname() from callers to do_mount()

2014-09-14 Thread Seunghun Lee
It would make more sense to pass char __user * instead of char * in callers of do_mount() and do getname() inside do_mount(). Suggested-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Seunghun Lee way...@gmail.com --- arch/alpha/kernel/osf_sys.c | 23 ++- fs/compat.c

Re: [PATCH] vfs: move getname() from callers to do_mount()

2014-09-14 Thread Seunghun Lee
On September 15, 2014 2:18:50 PM GMT+09:00, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Sep 15, 2014 at 01:39:19PM +0900, Seunghun Lee wrote: 2014. 9. 15. 오전 3:13에 Al Viro v...@zeniv.linux.org.uk wrote: Applied with one modification: this getname/kern_path/putname is Ok, I will resend

Re: [PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
On 09/13/2014 01:28 AM, Al Viro wrote: > On Sat, Sep 13, 2014 at 12:53:32AM +0900, Seunghun Lee wrote: >> In sys_mount, getname() checks dir_name. >> So do_mount needn't check dir_name again. > ... and simple grep shows four more call sites. At the very least, the > commit m

[PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
In sys_mount, getname() checks dir_name. So do_mount needn't check dir_name again. Signed-off-by: Seunghun Lee --- fs/namespace.c |5 - 1 file changed, 5 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index bfd03c6..bf8a9af 100644 --- a/fs/namespace.c +++ b/fs/namespace.c

[PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
In sys_mount, getname() checks dir_name. So do_mount needn't check dir_name again. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/namespace.c |5 - 1 file changed, 5 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index bfd03c6..bf8a9af 100644 --- a/fs/namespace.c +++ b

Re: [PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
On 09/13/2014 01:28 AM, Al Viro wrote: On Sat, Sep 13, 2014 at 12:53:32AM +0900, Seunghun Lee wrote: In sys_mount, getname() checks dir_name. So do_mount needn't check dir_name again. ... and simple grep shows four more call sites. At the very least, the commit message needs to cover those

Re: [PATCH] fat: Simplify calc_fat_clusters code

2014-09-02 Thread Seunghun Lee
On 09/03/2014 12:37 AM, OGAWA Hirofumi wrote: > Seunghun Lee writes: > >> diff --git a/fs/fat/inode.c b/fs/fat/inode.c >> index 756aead..6992dea 100644 >> --- a/fs/fat/inode.c >> +++ b/fs/fat/inode.c >> @@ -1307,12 +1307,9 @@ static unsigned long calc_fat

[PATCH] fat: Simplify calc_fat_clusters code

2014-09-02 Thread Seunghun Lee
Code for fat12 and fat16/32 can be merged to one. Signed-off-by: Seunghun Lee --- fs/fat/inode.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 756aead..6992dea 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1307,12

[PATCH] fat: Simplify calc_fat_clusters code

2014-09-02 Thread Seunghun Lee
Code for fat12 and fat16/32 can be merged to one. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/fat/inode.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 756aead..6992dea 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c

Re: [PATCH] fat: Simplify calc_fat_clusters code

2014-09-02 Thread Seunghun Lee
On 09/03/2014 12:37 AM, OGAWA Hirofumi wrote: Seunghun Lee way...@gmail.com writes: diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 756aead..6992dea 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1307,12 +1307,9 @@ static unsigned long calc_fat_clusters(struct super_block *sb

[PATCH] staging: dgnc: split two assignments into the two assignments on two lines.

2014-09-01 Thread Seunghun Lee
split two assignments into the two assignments on two lines. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/TODO |2 -- drivers/staging/dgnc/dgnc_cls.c| 15 ++- drivers/staging/dgnc/dgnc_driver.c | 10

[PATCH] ext4: fix comments about get_blocks

2014-09-01 Thread Seunghun Lee
get_blocks is renamed to get_block. Signed-off-by: Seunghun Lee --- fs/ext4/inode.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 3aa26e9..6c91fb3 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -590,7 +590,7 @@ found

[PATCH] ext4: fix comments about get_blocks

2014-09-01 Thread Seunghun Lee
get_blocks is renamed to get_block. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ext4/inode.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 3aa26e9..6c91fb3 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -590,7

[PATCH] staging: dgnc: split two assignments into the two assignments on two lines.

2014-09-01 Thread Seunghun Lee
split two assignments into the two assignments on two lines. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/TODO |2 -- drivers/staging/dgnc/dgnc_cls.c| 15

[PATCH] staging: dgnc: remove some unused macros

2014-08-31 Thread Seunghun Lee
These macros do nothing, so remove it. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h

[PATCH] staging: dgnc: remove some unused macros

2014-08-31 Thread Seunghun Lee
These macros do nothing, so remove it. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-19 Thread Seunghun Lee
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c| 51 drivers/staging/dgnc/dgnc_driver.c | 19 +-- drivers/staging

[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-19 Thread Seunghun Lee
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c| 51 drivers

Re: [PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-15 Thread Seunghun Lee
On 08/15/2014 03:08 PM, Greg KH wrote: > On Tue, Aug 12, 2014 at 10:30:14PM +0900, Seunghun Lee wrote: >> In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. >> >> So remove them and related codes. >> >> CC: Lidza Louina >> CC: Mark

Re: [PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-15 Thread Seunghun Lee
On 08/15/2014 03:08 PM, Greg KH wrote: On Tue, Aug 12, 2014 at 10:30:14PM +0900, Seunghun Lee wrote: In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net

[PATCH] staging: android: fix a possible memory leak

2014-08-13 Thread Seunghun Lee
Memory allocated by kstrdup should be freed. CC: Brian Swetland Signed-off-by: Seunghun Lee --- drivers/staging/android/logger.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c index 9b47e66..0bf0d24

[PATCH] staging: android: fix a possible memory leak

2014-08-13 Thread Seunghun Lee
Memory allocated by kstrdup should be freed. CC: Brian Swetland swetl...@google.com Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/android/logger.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/logger.c b/drivers/staging

[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-12 Thread Seunghun Lee
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c| 63 + drivers/staging/dgnc/dgnc_driver.c | 20 +-- drivers/staging

[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-12 Thread Seunghun Lee
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing. So remove them and related codes. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c| 63 + drivers

[PATCH 2/2] staging: dgnc: Remove unneeded dgnc_trace.c and dgnc_trace.h

2014-07-31 Thread Seunghun Lee
Removes unneeded dgnc_trace.c and dgnc_trace.h CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/Makefile |2 +- drivers/staging/dgnc/dgnc_cls.c|1 - drivers/staging/dgnc/dgnc_driver.c |1 - drivers/staging/dgnc/dgnc_neo.c|1

[PATCH 1/2] staging: dgnc: rephrase comment

2014-07-31 Thread Seunghun Lee
Rephrase comment to explain original intention of function. CC: Lidza Louina CC: Mark Hounschell Suggested-by: Tobias Klauser Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH 1/2] staging: dgnc: rephrase comment

2014-07-31 Thread Seunghun Lee
Rephrase comment to explain original intention of function. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Suggested-by: Tobias Klauser tklau...@distanz.ch Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c |8 1 file

[PATCH 2/2] staging: dgnc: Remove unneeded dgnc_trace.c and dgnc_trace.h

2014-07-31 Thread Seunghun Lee
Removes unneeded dgnc_trace.c and dgnc_trace.h CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/Makefile |2 +- drivers/staging/dgnc/dgnc_cls.c|1 - drivers/staging/dgnc

[PATCH] staging: dgnc: removes unused if defined code

2014-07-28 Thread Seunghun Lee
DGNC_TRACER and TRC_TO_KMEM are never defined. This patch removes if defined DGNC_TRACER and TRC_TO_KMEM code. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.c |4 --- drivers/staging/dgnc/dgnc_driver.h | 53

[PATCH] staging: dgnc: removes unused if defined code

2014-07-28 Thread Seunghun Lee
DGNC_TRACER and TRC_TO_KMEM are never defined. This patch removes if defined DGNC_TRACER and TRC_TO_KMEM code. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c |4 --- drivers

[PATCH] staging: dgnc: remove commented code

2014-07-25 Thread Seunghun Lee
This patch removes commented code in dgnc driver. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c |5 +- drivers/staging/dgnc/dgnc_trace.c | 123 - drivers/staging/dgnc/dgnc_trace.h | 10

[PATCH] staging: dgnc: remove commented code

2014-07-25 Thread Seunghun Lee
This patch removes commented code in dgnc driver. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c |5 +- drivers/staging/dgnc/dgnc_trace.c | 123

[PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL

2014-07-24 Thread Seunghun Lee
This patch fixes checkpatch errors "do not initialise statics to 0 or NULL" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_trace.c |2 +- drivers/staging/dgnc/dgnc_tty.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dg

[PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

2014-07-24 Thread Seunghun Lee
This patch fixes a checkpatch errors "Macros with complex values should be enclosed in parenthesis" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h | 40 drivers/staging/dgnc/digi.h| 60 ++-- drive

[PATCH 3/3] staging: dgnc: Fix space required after that ','

2014-07-24 Thread Seunghun Lee
This patch fixes checkpatch errors: "space required after that ','" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driv

[PATCH 3/3] staging: dgnc: Fix space required after that ','

2014-07-24 Thread Seunghun Lee
This patch fixes checkpatch errors: space required after that ',' Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc

[PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

2014-07-24 Thread Seunghun Lee
This patch fixes a checkpatch errors Macros with complex values should be enclosed in parenthesis Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h | 40 drivers/staging/dgnc/digi.h| 60

[PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL

2014-07-24 Thread Seunghun Lee
This patch fixes checkpatch errors do not initialise statics to 0 or NULL Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_trace.c |2 +- drivers/staging/dgnc/dgnc_tty.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH] staging: dgnc: Remove all C99 comments

2014-07-22 Thread Seunghun Lee
This patch fixes the following checkpatch error: ERROR: do not use C99 // comments CC: Lidza Louina Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h | 10 +- drivers/staging/dgnc/digi.h| 36 ++-- 2 files changed, 23

[PATCH] staging: dgnc: Remove all C99 comments

2014-07-22 Thread Seunghun Lee
This patch fixes the following checkpatch error: ERROR: do not use C99 // comments CC: Lidza Louina lidza.lou...@gmail.com Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_driver.h | 10 +- drivers/staging/dgnc/digi.h| 36

[PATCH] UBIFS: fix some comments

2014-07-01 Thread Seunghun Lee
This patch fixes some comments about return type. Signed-off-by: Seunghun Lee --- fs/ubifs/recovery.c |4 ++-- fs/ubifs/scan.c |5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c index c14adb2..933dda5 100644 --- a/fs

[PATCH] UBIFS: fix some comments

2014-07-01 Thread Seunghun Lee
This patch fixes some comments about return type. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ubifs/recovery.c |4 ++-- fs/ubifs/scan.c |5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c index c14adb2..933dda5

[PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-22 Thread Seunghun Lee
-off-by: Seunghun Lee --- drivers/staging/ced1401/usb1401.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.h b/drivers/staging/ced1401/usb1401.h index ea0fe63..8327e9c 100644 --- a/drivers/staging/ced1401/usb1401.h +++ b/drivers/staging

[PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-22 Thread Seunghun Lee
Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/ced1401/usb1401.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.h b/drivers/staging/ced1401/usb1401.h index ea0fe63..8327e9c 100644 --- a/drivers/staging/ced1401/usb1401.h +++ b

[PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-13 Thread Seunghun Lee
[noderef] *puBuf Signed-off-by: Seunghun Lee --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index ebbc509..963b941 100644 --- a/drivers/staging/ced1401/ced_ioc.c +++ b

[PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-13 Thread Seunghun Lee
[noderef] asn:1*puBuf Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index ebbc509..963b941 100644 --- a/drivers/staging

[PATCH 2/2] ext2: fix error handling in ext2_fill_super()

2014-05-15 Thread Seunghun Lee
ext2_fill_super is using err variable, but it is not applied to return value. This patch fixes it. Signed-off-by: Seunghun Lee --- fs/ext2/super.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index e3fc51e..7e36536 100644

[PATCH 1/2] ext2: fix type of return value ext2_fill_super()

2014-05-15 Thread Seunghun Lee
This patch fixes type of return value ext2_fill_super(). Signed-off-by: Seunghun Lee --- fs/ext2/super.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 3750031..e3fc51e 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -770,7

[PATCH 1/2] ext2: fix type of return value ext2_fill_super()

2014-05-15 Thread Seunghun Lee
This patch fixes type of return value ext2_fill_super(). Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ext2/super.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 3750031..e3fc51e 100644 --- a/fs/ext2/super.c +++ b/fs/ext2

[PATCH 2/2] ext2: fix error handling in ext2_fill_super()

2014-05-15 Thread Seunghun Lee
ext2_fill_super is using err variable, but it is not applied to return value. This patch fixes it. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ext2/super.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index e3fc51e

[PATCH] ext2: super: remove unnecessary goto statement

2014-05-07 Thread Seunghun Lee
This patch removes unnecessary goto failed, and moves kfree to failed. Signed-off-by: Seunghun Lee --- fs/ext2/super.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 3750031..7d20a50 100644 --- a/fs/ext2/super.c +++ b/fs

[PATCH] ext2: super: remove unnecessary goto statement

2014-05-07 Thread Seunghun Lee
This patch removes unnecessary goto failed, and moves kfree to failed. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/ext2/super.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 3750031..7d20a50 100644 --- a/fs/ext2

[RESEND] [PATCH] staging: android: fix missing a blank line after declarations

2014-04-30 Thread Seunghun Lee
This patch fixes "Missing a blank line after declarations" warnings. Signed-off-by: Seunghun Lee --- drivers/staging/android/alarm-dev.c |1 + drivers/staging/android/binder.c | 34 + drivers/staging/android/ion/ion.c

[RESEND] [PATCH] staging: android: fix missing a blank line after declarations

2014-04-30 Thread Seunghun Lee
This patch fixes Missing a blank line after declarations warnings. Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/android/alarm-dev.c |1 + drivers/staging/android/binder.c | 34 + drivers/staging/android/ion/ion.c

[PATCH] staging: android: fix missing a blank line after declarations

2014-04-29 Thread Seunghun Lee
This patch fixes "Missing a blank line after declarations" warnings. Signed-off-by: Seunghun Lee --- drivers/staging/android/alarm-dev.c |1 + drivers/staging/android/binder.c | 37 + drivers/staging/android/ion/ion.c

[PATCH] staging: android: fix missing a blank line after declarations

2014-04-29 Thread Seunghun Lee
This patch fixes Missing a blank line after declarations warnings. Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/android/alarm-dev.c |1 + drivers/staging/android/binder.c | 37 + drivers/staging/android/ion/ion.c

[PATCH] staging: android: uapi: fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warning and errors. Signed-off-by: Seunghun Lee --- drivers/staging/android/uapi/ion.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index f09e7c1..6aa4956

[PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warnings and errors. Signed-off-by: Seunghun Lee --- drivers/staging/android/uapi/binder.h |2 +- drivers/staging/android/uapi/ion.h| 20 +--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/uapi

[PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warnings and errors. Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/android/uapi/binder.h |2 +- drivers/staging/android/uapi/ion.h| 20 +--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH] staging: android: uapi: fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warning and errors. Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/android/uapi/ion.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index

[PATCH] module: fix coding style

2013-12-18 Thread Seunghun Lee
Fix coding style of module.h Signed-off-by: Seunghun Lee --- include/linux/module.h | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index 46e548f..eaf60ff 100644

[PATCH] module: fix coding style

2013-12-18 Thread Seunghun Lee
Fix coding style of module.h Signed-off-by: Seunghun Lee way...@gmail.com --- include/linux/module.h | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index 46e548f..eaf60ff