RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-07-09 Thread Shenwei Wang
Thank you, Thierry. Have you also reviewed and accepted the other 3 patches in this serial? Regards, Shenwei -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Monday, July 9, 2018 12:09 PM To: Shenwei Wang Cc: linux-...@vger.kernel.org; dl-linux-imx

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-07-09 Thread Shenwei Wang
Thank you, Thierry. Have you also reviewed and accepted the other 3 patches in this serial? Regards, Shenwei -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Monday, July 9, 2018 12:09 PM To: Shenwei Wang Cc: linux-...@vger.kernel.org; dl-linux-imx

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-07-06 Thread Shenwei Wang
2nd ping. Regards, Shenwei -Original Message- From: Shenwei Wang Sent: Tuesday, June 26, 2018 10:03 AM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-07-06 Thread Shenwei Wang
2nd ping. Regards, Shenwei -Original Message- From: Shenwei Wang Sent: Tuesday, June 26, 2018 10:03 AM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-06-26 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Friday, June 8, 2018 2:23 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

RE: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-06-26 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Friday, June 8, 2018 2:23 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

[PATCH v2 3/4] pwm: fsl-ftm: Enable support for the new SoC i.mx8qm

2018-06-08 Thread shenwei . wang
Enabled the support for the new SoC i.mx8qm by adding the compatible string of "fsl,imx8qm-ftm-pwm" and its per-compatible data with setting "has_enable_bits" to "true". Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 5 + 1 file changed, 5 inser

[PATCH v2 3/4] pwm: fsl-ftm: Enable support for the new SoC i.mx8qm

2018-06-08 Thread shenwei . wang
Enabled the support for the new SoC i.mx8qm by adding the compatible string of "fsl,imx8qm-ftm-pwm" and its per-compatible data with setting "has_enable_bits" to "true". Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 5 + 1 file changed, 5 inser

[PATCH v2 4/4] dt-bindings: pwm: fsl-ftm: Add compatible string for i.MX8QM

2018-06-08 Thread shenwei . wang
i.MX8QM integrates a new version of FTM IP block. It adds eight PWM enable bits in FTM_SC register. Add a new compatible string of "fsl,imx8qm-ftm-pwm" for i.MX8QM to differentiate it from the previous SoCs. Signed-off-by: Shenwei Wang --- Documentation/devicetree/bindings/pwm/pwm-f

[PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-06-08 Thread shenwei . wang
before accessing any FTM registers. Moreover, the clock can not be used as the source clock for the FTM IP block. This patch introduces the ipg_clk as the dedicated IP interface clock and by default it is the same as the ftm_sys clock if not specified. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm

[PATCH v2 4/4] dt-bindings: pwm: fsl-ftm: Add compatible string for i.MX8QM

2018-06-08 Thread shenwei . wang
i.MX8QM integrates a new version of FTM IP block. It adds eight PWM enable bits in FTM_SC register. Add a new compatible string of "fsl,imx8qm-ftm-pwm" for i.MX8QM to differentiate it from the previous SoCs. Signed-off-by: Shenwei Wang --- Documentation/devicetree/bindings/pwm/pwm-f

[PATCH v2 1/4] pwm: fsl-ftm: Added a dedicated IP interface clock

2018-06-08 Thread shenwei . wang
before accessing any FTM registers. Moreover, the clock can not be used as the source clock for the FTM IP block. This patch introduces the ipg_clk as the dedicated IP interface clock and by default it is the same as the ftm_sys clock if not specified. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm

[PATCH v2 2/4] pwm: fsl-ftm: Added the support of per-compatible data

2018-06-08 Thread shenwei . wang
of "has_enable_bits" is added via per-compatible data structure. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c index df0a1c0..e4c7

[PATCH v2 2/4] pwm: fsl-ftm: Added the support of per-compatible data

2018-06-08 Thread shenwei . wang
of "has_enable_bits" is added via per-compatible data structure. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c index df0a1c0..e4c7

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Shenwei Wang
- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Wednesday, June 6, 2018 3:34 AM To: Shenwei Wang Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x On Thu, May 24, 2018

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Shenwei Wang
- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Wednesday, June 6, 2018 3:34 AM To: Shenwei Wang Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x On Thu, May 24, 2018

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-05 Thread Shenwei Wang
Hello Thierry, Can you please share your comments on the patch? Thanks, Shenwei -Original Message- From: Shenwei Wang Sent: Wednesday, May 30, 2018 12:00 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH 1/1

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-05 Thread Shenwei Wang
Hello Thierry, Can you please share your comments on the patch? Thanks, Shenwei -Original Message- From: Shenwei Wang Sent: Wednesday, May 30, 2018 12:00 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH 1/1

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Thursday, May 24, 2018 1:09 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Thursday, May 24, 2018 1:09 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread shenwei . wang
e property, the driver set the PWM enable bit when a PWM channel is requested. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c ind

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread shenwei . wang
e property, the driver set the PWM enable bit when a PWM channel is requested. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c ind

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-24 Thread shenwei . wang
e property, the driver set the PWM enable bit when a PWM channel is requested. Signed-off-by: Shenwei Wang <shenwei.w...@nxp.com> --- drivers/pwm/pwm-fsl-ftm.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-24 Thread shenwei . wang
e property, the driver set the PWM enable bit when a PWM channel is requested. Signed-off-by: Shenwei Wang --- drivers/pwm/pwm-fsl-ftm.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c ind

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-18 Thread Shenwei Wang
...@linaro.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D > > On Tue, Sep 08, 2015 at 03:01:07PM +, Shenwei Wang wrote: > > > > arch/arm/mach-imx/Kconfig| 1 + > > > > arch/arm/mach

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-18 Thread Shenwei Wang
...@linaro.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D > > On Tue, Sep 08, 2015 at 03:01:07PM +, Shenwei Wang wrote: > > > > arch/arm/mach-imx/Kconfig| 1 + > > > > arch/arm/mach

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-08 Thread Shenwei Wang
> -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > > This patch adds a new suspend driver to manage the power states on IMX7D. > > It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states. > > > > Signed-of

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-08 Thread Shenwei Wang
> -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > > This patch adds a new suspend driver to manage the power states on IMX7D. > > It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states. > > > > Signe

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-03 Thread Shenwei Wang
2nd ping. Shenwei > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang > Sent: 2015年7月31日 16:34 > To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net >

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-09-03 Thread Shenwei Wang
2nd ping. Shenwei > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang > Sent: 2015年7月31日 16:34 > To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net >

RE: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-28 Thread Shenwei Wang
g > Yongcai-B20788 > Subject: Re: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation > > On Wed, 26 Aug 2015, Shenwei Wang wrote: > > u32 imx_gpcv2_get_wakeup_source(u32 **sources) { > > - if (!imx_gpcv2_instance) > > + struct gpcv2_irqchip_da

RE: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-28 Thread Shenwei Wang
Subject: Re: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation On Wed, 26 Aug 2015, Shenwei Wang wrote: u32 imx_gpcv2_get_wakeup_source(u32 **sources) { - if (!imx_gpcv2_instance) + struct gpcv2_irqchip_data *cd; + void __iomem *reg; + int i; + + cd

[PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-26 Thread Shenwei Wang
Based on Sudeep Holla's review comments, the implementation can be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND. This patch enables the flags in the struct irq_chip and removes the unnecessory syscore_ops callbacks. Signed-off-by: Shenwei Wang --- Change

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > > + > > > > if (sources) > > > > - *sources = imx_gpcv2_instance->wakeup_sources; > > > > + *sources = cd->wakeup_sources; > > > > > > > > return IMR_NUM; > > > > >

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
.kernel.org; Huang > Yongcai-B20788 > Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation > > typo in $subject Just noticed. Will change it. > On 26/08/15 16:49, Shenwei Wang wrote: > > Based on Sudeep Holla's review comments, the implementation can b

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
g > Yongcai-B20788 > Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation > > On Wed, 26 Aug 2015, Shenwei Wang wrote: > > u32 imx_gpcv2_get_wakeup_source(u32 **sources) { > > - if (!imx_gpcv2_instance) > > + struct gpcv2_irqchip_da

[PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
Based on Sudeep Holla's review comments, the implementation can be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND. This patch enables the flags in the struct irq_chip and removes the unnecessory syscore_ops callbacks. Signed-off-by: Shenwei Wang --- drivers

[PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation

2015-08-26 Thread Shenwei Wang
Based on Sudeep Holla's review comments, the implementation can be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND. This patch enables the flags in the struct irq_chip and removes the unnecessory syscore_ops callbacks. Signed-off-by: Shenwei Wang shenwei.w

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
-Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] + if (sources) - *sources = imx_gpcv2_instance-wakeup_sources; + *sources = cd-wakeup_sources; return IMR_NUM; You do not need the intermediate

[PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
Based on Sudeep Holla's review comments, the implementation can be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE and IRQCHIP_MASK_ON_SUSPEND. This patch enables the flags in the struct irq_chip and removes the unnecessory syscore_ops callbacks. Signed-off-by: Shenwei Wang shenwei.w

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation On Wed, 26 Aug 2015, Shenwei Wang wrote: u32 imx_gpcv2_get_wakeup_source(u32 **sources) { - if (!imx_gpcv2_instance) + struct gpcv2_irqchip_data *cd; + void __iomem *reg; + int i; + + cd

RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation

2015-08-26 Thread Shenwei Wang
-B20788 Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation typo in $subject Just noticed. Will change it. On 26/08/15 16:49, Shenwei Wang wrote: Based on Sudeep Holla's review comments, the implementation can be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE

[PATCH v3 1/1][Resend] misc: sram: add dev_pm_ops to support module power gate

2015-08-25 Thread Shenwei Wang
, which will save the data in the on-chip-ram right before power down and restore it after system resumes. A new property string named "can-power-gate" is added to the devicetree bindings too. Based-on-a-patch-by: Anson Huang Signed-off-by: Shenwei Wang --- Change log: PATCH v3

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
.@lists.infradead.org > Subject: RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Tue, 25 Aug 2015, Shenwei Wang wrote: > > > > IRQCHIP_SKIP_SET_WAKE flag can't be used here because the wakeup > > sources are required for power management.

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
.@lists.infradead.org > Subject: RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Tue, 25 Aug 2015, Shenwei Wang wrote: > > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > > IRQCHIP_MASK_ON_SUSPEND flag is for the hardware tha

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
.@lists.infradead.org > Subject: RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Tue, 25 Aug 2015, Shenwei Wang wrote: > > > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] All fine, what I am > > > saying is let irq-core know that you want

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
> -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > Sent: 2015年8月25日 11:24 > To: Wang Shenwei-B38339 > Cc: Sudeep Holla; shawn@linaro.org; t...@linutronix.de; > ja...@lakedaemon.net; Huang Yongcai-B20788; linux-kernel@vger.kernel.org; >

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
g; > linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > > > On 25/08/15 15:14, Shenwei Wang wrote: > > > > > >> -Original Message- > >> From: Sudeep Holla [mailto:sudeep.ho.

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
> -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > >>> IMX7D contains a new version of GPC IP block (GPCv2). It has two > >>> major > >>> functions: power management and wakeup source management. > >>> This patch adds a new irqchip driver to manage the interrupt

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
g; > linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > > > On 24/08/15 20:04, Shenwei Wang wrote: > > IMX7D contains a new version of GPC IP block (GPCv2). It has two major > > functions: power mana

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
-Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] IMX7D contains a new version of GPC IP block (GPCv2). It has two major functions: power management and wakeup source management. This patch adds a new irqchip driver to manage the interrupt wakeup sources on

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
...@lists.infradead.org Subject: Re: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On 25/08/15 15:14, Shenwei Wang wrote: -Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] [...] I don't see this driver doing anything extra apart from keeping

[PATCH v3 1/1][Resend] misc: sram: add dev_pm_ops to support module power gate

2015-08-25 Thread Shenwei Wang
, which will save the data in the on-chip-ram right before power down and restore it after system resumes. A new property string named can-power-gate is added to the devicetree bindings too. Based-on-a-patch-by: Anson Huang b20...@freescale.com Signed-off-by: Shenwei Wang shenwei.w...@freescale.com

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
-Original Message- From: Sudeep Holla [mailto:sudeep.ho...@arm.com] Sent: 2015年8月25日 11:24 To: Wang Shenwei-B38339 Cc: Sudeep Holla; shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net; Huang Yongcai-B20788; linux-kernel@vger.kernel.org;

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Tue, 25 Aug 2015, Shenwei Wang wrote: From: Sudeep Holla [mailto:sudeep.ho...@arm.com] All fine, what I am saying is let irq-core know that you want to mask the 2 non-wakeup irqs you have using MASK_ON_SUSPEND. So

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Tue, 25 Aug 2015, Shenwei Wang wrote: From: Thomas Gleixner [mailto:t...@linutronix.de] IRQCHIP_MASK_ON_SUSPEND flag is for the hardware that has no wakeup source capability. This GPCv2 block is designed

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Tue, 25 Aug 2015, Shenwei Wang wrote: IRQCHIP_SKIP_SET_WAKE flag can't be used here because the wakeup sources are required for power management. You could use it. Instead of copying the saved values, you can read

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-25 Thread Shenwei Wang
...@lists.infradead.org Subject: Re: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On 24/08/15 20:04, Shenwei Wang wrote: IMX7D contains a new version of GPC IP block (GPCv2). It has two major functions: power management and wakeup source management. This patch adds a new irqchip

RE: [PATCH v3 1/1] misc: sram: add dev_pm_ops to support module power gate

2015-08-24 Thread Shenwei Wang
Hi GregKH, Can you please take a look at this patch? Thanks, Shenwei > -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On > Behalf Of Shenwei Wang > Sent: 2015年7月30日 11:11 > To: gre...@linuxfoundation.org; a...@ar

[tip:irq/core] irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread tip-bot for Shenwei Wang
Commit-ID: e324c4dc4a5991d5b1171f434884a4026345e4b4 Gitweb: http://git.kernel.org/tip/e324c4dc4a5991d5b1171f434884a4026345e4b4 Author: Shenwei Wang AuthorDate: Mon, 24 Aug 2015 14:04:15 -0500 Committer: Thomas Gleixner CommitDate: Mon, 24 Aug 2015 21:49:34 +0200 irqchip/imx-gpcv2: IMX

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
g; Huang > Yongcai-B20788 > Subject: RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Mon, 24 Aug 2015, Shenwei Wang wrote: > > > Ok, last question. How is Anson related to this? He did not convey > > > your patch

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
> Subject: Re: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Mon, 24 Aug 2015, Shenwei Wang wrote: > > > > Signed-off-by: Shenwei Wang > > Signed-off-by: Anson Huang > > Ok, last question. How is Anson related to this?

[PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
will be the first block on the platform to be activated and signaled. Under normal wait mode during cpu idle, the system can be woke up by any enabled interrupts. Under standby or suspend mode, the system can only be woke up by the pre-defined wakeup sources. Signed-off-by: Shenwei Wang Signed-off-by: Anson

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > > +static int gpcv2_wakeup_source_save(void) { > > > > + struct gpcv2_irqchip_data *cd; > > > > + void __iomem *reg; > > > > + int i; > > > > + > > > > + cd = imx_gpcv2_instance; > > >

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
> Subject: Re: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Fri, 31 Jul 2015, Shenwei Wang wrote: > > +struct gpcv2_irqchip_data { > > + struct raw_spinlock rlock; > > + void __iomem *gpc_base; > > + u32 wakeup_sources

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Fri, 31 Jul 2015, Shenwei Wang wrote: +struct gpcv2_irqchip_data { + struct raw_spinlock rlock; + void __iomem *gpc_base; + u32 wakeup_sources[IMR_NUM]; + u32 enabled_irqs[IMR_NUM]; + u32 cpu2wakeup; Can you

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
-Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] +static int gpcv2_wakeup_source_save(void) { + struct gpcv2_irqchip_data *cd; + void __iomem *reg; + int i; + + cd = imx_gpcv2_instance; + if (!cd) +

[PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
will be the first block on the platform to be activated and signaled. Under normal wait mode during cpu idle, the system can be woke up by any enabled interrupts. Under standby or suspend mode, the system can only be woke up by the pre-defined wakeup sources. Signed-off-by: Shenwei Wang shenwei.w...@freescale.com

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
Subject: RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Mon, 24 Aug 2015, Shenwei Wang wrote: Ok, last question. How is Anson related to this? He did not convey your patch and in the first posted versions his SOB was never there. This patch was based

[tip:irq/core] irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread tip-bot for Shenwei Wang
Commit-ID: e324c4dc4a5991d5b1171f434884a4026345e4b4 Gitweb: http://git.kernel.org/tip/e324c4dc4a5991d5b1171f434884a4026345e4b4 Author: Shenwei Wang shenwei.w...@freescale.com AuthorDate: Mon, 24 Aug 2015 14:04:15 -0500 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Mon, 24 Aug

RE: [PATCH v3 1/1] misc: sram: add dev_pm_ops to support module power gate

2015-08-24 Thread Shenwei Wang
Hi GregKH, Can you please take a look at this patch? Thanks, Shenwei -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] On Behalf Of Shenwei Wang Sent: 2015年7月30日 11:11 To: gre...@linuxfoundation.org; a...@arndb.de Cc: Huang Yongcai

RE: [PATCH v9 1/1] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-24 Thread Shenwei Wang
] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Mon, 24 Aug 2015, Shenwei Wang wrote: Signed-off-by: Shenwei Wang shenwei.w...@freescale.com Signed-off-by: Anson Huang b20...@freescale.com Ok, last question. How is Anson related to this? He did not convey your patch

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-21 Thread Shenwei Wang
Ping. Shenwei > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang > Sent: 2015年7月31日 16:34 > To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net > Cc: linux-arm-ker...@l

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-08-21 Thread Shenwei Wang
Ping. Shenwei > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang > Sent: 2015年7月31日 16:34 > To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net > Cc: linux-arm-ker...@l

RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-08-21 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang Sent: 2015年7月31日 16:34 To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net Cc: linux-arm-ker...@lists.infradead.org; linux

RE: [PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-08-21 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Shenwei Wang Sent: 2015年7月31日 16:34 To: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net Cc: linux-arm-ker...@lists.infradead.org; linux

[PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-07-31 Thread Shenwei Wang
the power states on IMX7D. It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states. Signed-off-by: Shenwei Wang Signed-off-by: Anson Huang --- arch/arm/mach-imx/Kconfig| 1 + arch/arm/mach-imx/Makefile | 2 + arch/arm/mach-imx/common.h | 4

[PATCH v8 0/2] IMX GPCv2 drivers for wakeup source and suspend

2015-07-31 Thread Shenwei Wang
management. Supported the STANDBY power mode. Patch V1: Implemented the driver for IRQ wakeup sources. Shenwei Wang (2): irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources ARM: imx: support suspend states on imx7D arch/arm/mach-imx/Kconfig| 1 + arch/arm/mach-imx/Ma

[PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-31 Thread Shenwei Wang
will be the first block on the platform to be activated and signaled. Under normal wait mode during cpu idle, the system can be woke up by any enabled interrupts. Under standby or suspend mode, the system can only be woke up by the pre-defined wakeup sources. Signed-off-by: Shenwei Wang Signed-off-by: Anson

RE: [PATCH v7 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-31 Thread Shenwei Wang
> suspend > states..."? Good suggestion! Will change to support suspend states on imx7d. > On 2015-07-27 21:30, Shenwei Wang wrote: > > IMX7D contains a new version of GPC IP block (GPCv2). It has two major > > functions: power management and wakeup source manag

RE: [PATCH v7 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-31 Thread Shenwei Wang
states on imx7d. On 2015-07-27 21:30, Shenwei Wang wrote: IMX7D contains a new version of GPC IP block (GPCv2). It has two major functions: power management and wakeup source management. GPCv2 provides low power mode control for Cortex-A7 and Cortex-M4 domains. And it can support WAIT

[PATCH v8 2/2] ARM: imx: support suspend states on imx7D

2015-07-31 Thread Shenwei Wang
the power states on IMX7D. It currently supports SUSPEND_STANDBY and SUSPEND_MEM states. Signed-off-by: Shenwei Wang shenwei.w...@freescale.com Signed-off-by: Anson Huang b20...@freescale.com --- arch/arm/mach-imx/Kconfig| 1 + arch/arm/mach-imx/Makefile | 2 + arch/arm/mach-imx

[PATCH v8 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-31 Thread Shenwei Wang
will be the first block on the platform to be activated and signaled. Under normal wait mode during cpu idle, the system can be woke up by any enabled interrupts. Under standby or suspend mode, the system can only be woke up by the pre-defined wakeup sources. Signed-off-by: Shenwei Wang shenwei.w...@freescale.com

[PATCH v8 0/2] IMX GPCv2 drivers for wakeup source and suspend

2015-07-31 Thread Shenwei Wang
power mode. Patch V1: Implemented the driver for IRQ wakeup sources. Shenwei Wang (2): irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources ARM: imx: support suspend states on imx7D arch/arm/mach-imx/Kconfig| 1 + arch/arm/mach-imx/Makefile | 2 + arch/arm/mach

RE: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-28 Thread Shenwei Wang
.@lists.infradead.org > Subject: Re: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D > > On Tue, Jul 28, 2015 at 02:16:20PM +, Shenwei Wang wrote: > > > The files are named with "-imx7". It's a clear sign that the build > > > of the files should be con

RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
fradead.org > Subject: Re: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Tue, Jul 28, 2015 at 02:27:42PM +, Shenwei Wang wrote: > > > > +static int gpcv2_wakeup_source_save(void) { > > > > + struct imx_gpcv2_irq

RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
.@lists.infradead.org > Subject: Re: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Mon, Jul 27, 2015 at 02:29:59PM -0500, Shenwei Wang wrote: > > diff --git a/drivers/irqchip/irq-imx-gpcv2.c > > b/drivers/irqchip/irq-imx-gpcv2.c new file mode 1

RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
.@lists.infradead.org > Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Mon, Jul 27, 2015 at 02:50:15PM +, Shenwei Wang wrote: > > The following structure is currently used in both drivers. The members > > "gpc_base/ wakeup

RE: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-28 Thread Shenwei Wang
.@lists.infradead.org > Subject: Re: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D > > On Mon, Jul 27, 2015 at 06:24:26PM +, Shenwei Wang wrote: > > > > @@ -87,6 +87,8 @@ obj-$(CONFIG_SOC_IMX7D) += mach-imx7d.o > > > > > > > > ifeq ($(CO

RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Mon, Jul 27, 2015 at 02:50:15PM +, Shenwei Wang wrote: The following structure is currently used in both drivers. The members gpc_base/ wakeup_sources/enabled_irqs are now shared to PM driver. And the macro

RE: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-28 Thread Shenwei Wang
: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D On Mon, Jul 27, 2015 at 06:24:26PM +, Shenwei Wang wrote: @@ -87,6 +87,8 @@ obj-$(CONFIG_SOC_IMX7D) += mach-imx7d.o ifeq ($(CONFIG_SUSPEND),y) AFLAGS_suspend-imx6.o :=-Wa,-march=armv7-a +AFLAGS_suspend-imx7.o :=-Wa

RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Mon, Jul 27, 2015 at 02:29:59PM -0500, Shenwei Wang wrote: diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c new file mode 100644 index 000..3084f16 --- /dev/null +++ b/drivers

RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-28 Thread Shenwei Wang
: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources On Tue, Jul 28, 2015 at 02:27:42PM +, Shenwei Wang wrote: +static int gpcv2_wakeup_source_save(void) { + struct imx_gpcv2_irq *cd; We generally name variables in an abbrev of the types to make them

RE: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-28 Thread Shenwei Wang
: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D On Tue, Jul 28, 2015 at 02:16:20PM +, Shenwei Wang wrote: The files are named with -imx7. It's a clear sign that the build of the files should be controlled by something like related to imx7. Ideally, it should be CONFIG_SOC_IMX7

[PATCH v7 0/2] IMX GPCv2 drivers for wakeup source and suspend

2015-07-27 Thread Shenwei Wang
. Supported the SUSPEND_MEM power mode. Patch V2: Added the basic driver APIs for power management. Supported the STANDBY power mode. Patch V1: Implemented the driver for IRQ wakeup sources. Shenwei Wang (2): irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

[PATCH v7 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-27 Thread Shenwei Wang
the power states on IMX7D. It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states. Signed-off-by: Shenwei Wang Signed-off-by: Anson Huang --- arch/arm/mach-imx/Kconfig| 1 + arch/arm/mach-imx/Makefile | 2 + arch/arm/mach-imx/

[PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-27 Thread Shenwei Wang
will be the first block on the platform to be activated and signaled. Under normal wait mode during cpu idle, the system can be woke up by any enabled interrupts. Under standby or suspend mode, the system can only be woke up by the pre-defined wakeup sources. Signed-off-by: Shenwei Wang Signed-off-by: Anson

RE: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D

2015-07-27 Thread Shenwei Wang
> -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: 2015年7月27日 8:28 > To: Wang Shenwei-B38339 > Cc: shawn@linaro.org; t...@linutronix.de; ja...@lakedaemon.net; Huang > Yongcai-B20788; linux-kernel@vger.kernel.org; > linux-arm-ker...@lists.infradead.org >

RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-27 Thread Shenwei Wang
fradead.org > Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > > On Wed, Jul 22, 2015 at 12:07:38PM -0500, Shenwei Wang wrote: > > > > diff --git a/include/soc/imx/gpcv2.h b/include/soc/imx/gpcv2.h new > > > > f

RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources

2015-07-27 Thread Shenwei Wang
fradead.org > Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup > sources > > On Wed, Jul 22, 2015 at 12:07:38PM -0500, Shenwei Wang wrote: > > diff --git a/include/soc/imx/gpcv2.h b/include/soc/imx/gpcv2.h new > > file mode 100644 index 000..73

  1   2   >