Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

2018-02-01 Thread Shrikrishna Khare
> > Cleans up clang warning: > drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored > to 'rq' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Shrikrishna Khare <skh...@vmware.com>

Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

2018-02-01 Thread Shrikrishna Khare
> drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored > to 'rq' during its initialization is never read > > Signed-off-by: Colin Ian King Acked-by: Shrikrishna Khare

Re: [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-18 Thread Shrikrishna Khare
On Thu, 18 Jan 2018, Benjamin Poirier wrote: > On 2018/01/18 15:50, Benjamin Poirier wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > > overrun interrupt bursts", v4.15-rc1). Some

Re: [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-18 Thread Shrikrishna Khare
On Thu, 18 Jan 2018, Benjamin Poirier wrote: > On 2018/01/18 15:50, Benjamin Poirier wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > > overrun interrupt bursts", v4.15-rc1). Some

[PATCH net-next v2] vmxnet3: increase default rx ring sizes

2017-11-30 Thread Shrikrishna Khare
, the raw network bandwidth may not be very high, but the delays between when a VM is running or not running can also be relatively long. Signed-off-by: Shrikrishna Khare <skh...@vmware.com> Acked-by: Jin Heo <h...@vmware.com> Acked-by: Guolin Yang <gy...@vmware.com> Acked-by: Boon An

[PATCH net-next v2] vmxnet3: increase default rx ring sizes

2017-11-30 Thread Shrikrishna Khare
, the raw network bandwidth may not be very high, but the delays between when a VM is running or not running can also be relatively long. Signed-off-by: Shrikrishna Khare Acked-by: Jin Heo Acked-by: Guolin Yang Acked-by: Boon Ang --- v1->v2: revise commit message to explain the motivat

Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
On Tue, 28 Nov 2017, Andrew Lunn wrote: > > /* > > * Version numbers > > */ > > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k" > > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k" > > > > /* a 32-bit int, each byte encode a verion number in > > VMXNET3_DRIVER_VERSION */ > >

Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
On Tue, 28 Nov 2017, Andrew Lunn wrote: > > /* > > * Version numbers > > */ > > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k" > > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k" > > > > /* a 32-bit int, each byte encode a verion number in > > VMXNET3_DRIVER_VERSION */ > >

[PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
We often notice rx packet drops due to small default rx ring sizes and solve the problem by increasing the ring sizes. This patch increases the default rx ring sizes thereby reducing the probability of rx packet drops out of the box. Signed-off-by: Shrikrishna Khare <skh...@vmware.com>

[PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
We often notice rx packet drops due to small default rx ring sizes and solve the problem by increasing the ring sizes. This patch increases the default rx ring sizes thereby reducing the probability of rx packet drops out of the box. Signed-off-by: Shrikrishna Khare Acked-by: Jin Heo Acked

Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers

2016-10-19 Thread Shrikrishna Khare
tion.org > CC: "K. Y. Srinivasan" <k...@microsoft.com> > CC: Haiyang Zhang <haiya...@microsoft.com> > CC: "Michael S. Tsirkin" <m...@redhat.com> > CC: Shrikrishna Khare <skh...@vmware.com> > CC: "VMware, Inc." <pv-driv...@vmware.com> &

Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers

2016-10-19 Thread Shrikrishna Khare
; CC: "K. Y. Srinivasan" > CC: Haiyang Zhang > CC: "Michael S. Tsirkin" > CC: Shrikrishna Khare > CC: "VMware, Inc." > Signed-off-by: Jarod Wilson > --- The vmxnet3 part of the change looks good to me. Thanks, Shri

[PATCH net] vmxnet3: fix tx data ring copy for variable size

2016-08-19 Thread Shrikrishna Khare
at assumes fixed buffer size of 128. This patch fixes it by adding correct offset based on the actual data ring buffer size. Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +++- drivers/net/vmx

[PATCH net] vmxnet3: fix tx data ring copy for variable size

2016-08-19 Thread Shrikrishna Khare
at assumes fixed buffer size of 128. This patch fixes it by adding correct offset based on the actual data ring buffer size. Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 5

[PATCH net-next v5 6/7] vmxnet3: introduce command to register memory region

2016-06-16 Thread Shrikrishna Khare
and if possible, will be part of a different patch. This patch only exposes the emulation capability to the driver (vmxnet3_defs.h is identical between the driver and the emulation). Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> ---

[PATCH net-next v5 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-16 Thread Shrikrishna Khare
implementation to allow variable length transmit data ring buffers. The length of the buffer is read from the emulation during initialization. Signed-off-by: Sriram Rangarajan <rangaraj...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_de

[PATCH net-next v5 6/7] vmxnet3: introduce command to register memory region

2016-06-16 Thread Shrikrishna Khare
and if possible, will be part of a different patch. This patch only exposes the emulation capability to the driver (vmxnet3_defs.h is identical between the driver and the emulation). Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 17

[PATCH net-next v5 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-16 Thread Shrikrishna Khare
implementation to allow variable length transmit data ring buffers. The length of the buffer is read from the emulation during initialization. Signed-off-by: Sriram Rangarajan Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55

[PATCH net-next v5 0/7] vmxnet3: upgrade to version 3

2016-06-16 Thread Shrikrishna Khare
to add detailed commit messages. --- Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generalized command interface to configure the device vmxnet3: allow variable length transmit data ring buffer vmxnet3: add receive data ring support vmxnet3: add support

[PATCH net-next v5 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-16 Thread Shrikrishna Khare
and configuring different coalescing modes. Signed-off-by: Keyong Sun <s...@vmware.com> Signed-off-by: Manoj Tammali <tamma...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 33 ++- drivers/net/vmxnet3/vmxne

[PATCH net-next v5 0/7] vmxnet3: upgrade to version 3

2016-06-16 Thread Shrikrishna Khare
to add detailed commit messages. --- Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generalized command interface to configure the device vmxnet3: allow variable length transmit data ring buffer vmxnet3: add receive data ring support vmxnet3: add support

[PATCH net-next v5 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-16 Thread Shrikrishna Khare
and configuring different coalescing modes. Signed-off-by: Keyong Sun Signed-off-by: Manoj Tammali Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 33 ++- drivers/net/vmxnet3/vmxnet3_drv.c | 54 drivers/net/vmxnet3/vmxnet3_ethtool.c | 158

[PATCH net-next v5 7/7] vmxnet3: update to version 3

2016-06-16 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv

[PATCH net-next v5 7/7] vmxnet3: update to version 3

2016-06-16 Thread Shrikrishna Khare
With all vmxnet3 version 3 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 3, provided the emulation advertises support for version 3. Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3

[PATCH net-next v5 2/7] vmxnet3: introduce generalized command interface to configure the device

2016-06-16 Thread Shrikrishna Khare
<gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 8345

[PATCH net-next v5 2/7] vmxnet3: introduce generalized command interface to configure the device

2016-06-16 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 8345e0c..a26a69d 100644 --- a/drivers/net/vmxnet3

[PATCH net-next v5 4/7] vmxnet3: add receive data ring support

2016-06-16 Thread Shrikrishna Khare
is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 48 --- drive

[PATCH net-next v5 4/7] vmxnet3: add receive data ring support

2016-06-16 Thread Shrikrishna Khare
is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 48 --- drivers/net/vmxnet3

[PATCH net-next v5 1/7] vmxnet3: prepare for version 3 changes

2016-06-16 Thread Shrikrishna Khare
-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.

[PATCH net-next v5 1/7] vmxnet3: prepare for version 3 changes

2016-06-16 Thread Shrikrishna Khare
-by: Shrikrishna Khare --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.c | 4 ++-- drivers/net

[PATCH net-next v4 7/7] vmxnet3: update to version 3

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index d0

[PATCH net-next v4 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan <rangaraj...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_et

[PATCH net-next v4 7/7] vmxnet3: update to version 3

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index d0bcc1d9..c68fe49 100644

[PATCH net-next v4 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 9 +++--- drivers/net/vmxnet3/vmxnet3_int.h

[PATCH net-next v4 2/7] vmxnet3: introduce generic command interface to configure the device

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers

[PATCH net-next v4 4/7] vmxnet3: add receive data ring support

2016-06-14 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/v

[PATCH net-next v4 2/7] vmxnet3: introduce generic command interface to configure the device

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 8345e0c..a26a69d 100644

[PATCH net-next v4 4/7] vmxnet3: add receive data ring support

2016-06-14 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 48

[PATCH net-next v4 6/7] vmxnet3: introduce command to register memory region

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h i

[PATCH net-next v4 6/7] vmxnet3: introduce command to register memory region

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 274e145..c3a3164 100644 --- a/drivers/net

[PATCH net-next v4 0/7] vmxnet3: upgrade to version 3

2016-06-14 Thread Shrikrishna Khare
Changes in v4: - Following patch is updated. See that patch for details: vmxnet3: add support for get_coalesce, set_coalesce ethtool Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generic command interface to configure the device vmxnet3: allow variable

[PATCH net-next v4 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun <s...@vmware.com> Signed-off-by: Manoj Tammali <tamma...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- v1-v2: v1 patch used special values of rx-usecs to differentiate between coalescing modes. v2 uses relevant fields in struc

[PATCH net-next v4 0/7] vmxnet3: upgrade to version 3

2016-06-14 Thread Shrikrishna Khare
Changes in v4: - Following patch is updated. See that patch for details: vmxnet3: add support for get_coalesce, set_coalesce ethtool Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generic command interface to configure the device vmxnet3: allow variable

[PATCH net-next v4 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun Signed-off-by: Manoj Tammali Signed-off-by: Shrikrishna Khare --- v1-v2: v1 patch used special values of rx-usecs to differentiate between coalescing modes. v2 uses relevant fields in struct ethtool_coalesce to choose modes. Also, a new command VMXNET3_CMD_GET_COALESCE

[PATCH net-next v4 1/7] vmxnet3: prepare for version 3 changes

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/v

[PATCH net-next v4 1/7] vmxnet3: prepare for version 3 changes

2016-06-14 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.c

[PATCH net-next v3 6/7] vmxnet3: introduce command to register memory region

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h i

[PATCH net-next v3 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun <s...@vmware.com> Signed-off-by: Manoj Tammali <tamma...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 33 ++- drivers/net/vmxnet3/vmxnet3_drv.c | 54 d

[PATCH net-next v3 6/7] vmxnet3: introduce command to register memory region

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 274e145..c3a3164 100644 --- a/drivers/net

[PATCH net-next v3 5/7] vmxnet3: add support for get_coalesce, set_coalesce ethtool operations

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun Signed-off-by: Manoj Tammali Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 33 ++- drivers/net/vmxnet3/vmxnet3_drv.c | 54 drivers/net/vmxnet3/vmxnet3_ethtool.c | 160 ++ drivers/net

[PATCH net-next v3 7/7] vmxnet3: update to version 3

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index d0

[PATCH net-next v3 7/7] vmxnet3: update to version 3

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index d0bcc1d9..c68fe49 100644

[PATCH net-next v3 4/7] vmxnet3: add receive data ring support

2016-06-13 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/v

[PATCH net-next v3 1/7] vmxnet3: prepare for version 3 changes

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/v

[PATCH net-next v3 4/7] vmxnet3: add receive data ring support

2016-06-13 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 48

[PATCH net-next v3 1/7] vmxnet3: prepare for version 3 changes

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.c

[PATCH net-next v3 2/7] vmxnet3: introduce generic command interface to configure the device

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers

[PATCH net-next v3 2/7] vmxnet3: introduce generic command interface to configure the device

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 8345e0c..a26a69d 100644

[PATCH net-next v3 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan <rangaraj...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_et

[PATCH net-next v3 3/7] vmxnet3: allow variable length transmit data ring buffer

2016-06-13 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 9 +++--- drivers/net/vmxnet3/vmxnet3_int.h

[PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

2016-06-13 Thread Shrikrishna Khare
is open Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generic command interface to configure the device vmxnet3: allow variable length transmit data ring buffer vmxnet3: add receive data ring support vmxnet3: add support for get_coalesce, set_coalesce

[PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

2016-06-13 Thread Shrikrishna Khare
is open Shrikrishna Khare (7): vmxnet3: prepare for version 3 changes vmxnet3: introduce generic command interface to configure the device vmxnet3: allow variable length transmit data ring buffer vmxnet3: add receive data ring support vmxnet3: add support for get_coalesce, set_coalesce

Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
On Wed, 8 Jun 2016, Thomas Hellstrom wrote: > > mss = rcdlro->mss; > > if (unlikely(segCnt <= 1)) > > segCnt = 0; > > Based on this code, it looks like it can handle the case without taking > down the

Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
On Wed, 8 Jun 2016, Thomas Hellstrom wrote: > > mss = rcdlro->mss; > > if (unlikely(segCnt <= 1)) > > segCnt = 0; > > Based on this code, it looks like it can handle the case without taking > down the

[PATCH net v3] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare <skh...@vmware.com> Signed-off-by: Jin Heo <h...@vmware.com> --- v2: fix subject line v3: replace BUG_ON with WARN_ON_ONCE --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/v

[PATCH net v3] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare Signed-off-by: Jin Heo --- v2: fix subject line v3: replace BUG_ON with WARN_ON_ONCE --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3

Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
On Tue, 7 Jun 2016, David Miller wrote: > From: Shrikrishna Khare <skh...@vmware.com> > Date: Tue, 7 Jun 2016 22:55:17 -0700 > > > The device emulation may send segCnt of 1 for LRO packets. > > > > Signed-off-by: Shrikrishna Khare <skh...@vmwar

Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
On Tue, 7 Jun 2016, David Miller wrote: > From: Shrikrishna Khare > Date: Tue, 7 Jun 2016 22:55:17 -0700 > > > The device emulation may send segCnt of 1 for LRO packets. > > > > Signed-off-by: Shrikrishna Khare > > Signed-off-by: Jin Heo > > Plea

[PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare <skh...@vmware.com> Signed-off-by: Jin Heo <h...@vmware.com> --- v2: fix subject line --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 file

[PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets

2016-06-08 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare Signed-off-by: Jin Heo --- v2: fix subject line --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets

2016-06-07 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare <skh...@vmware.com> Signed-off-by: Jin Heo <h...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+),

[PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets

2016-06-07 Thread Shrikrishna Khare
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare Signed-off-by: Jin Heo --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-20 Thread Shrikrishna Khare
On Sun, 8 May 2016, Ben Hutchings wrote: > > Would a patch that maps 0 to 'no coalescing' be acceptable? That is: > > > > rx-usecs = 0 -> coalescing disabled. > > rx-usecs = 1 -> default (chosen by the device). > > rx-usecs = 2 -> adaptive coalescing. > > rx-usecs = 3 -> static coalescing. >

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-20 Thread Shrikrishna Khare
On Sun, 8 May 2016, Ben Hutchings wrote: > > Would a patch that maps 0 to 'no coalescing' be acceptable? That is: > > > > rx-usecs = 0 -> coalescing disabled. > > rx-usecs = 1 -> default (chosen by the device). > > rx-usecs = 2 -> adaptive coalescing. > > rx-usecs = 3 -> static coalescing. >

[PATCH net-next v2 6/7] Driver: Vmxnet3: Introduce command to register memory region

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h i

[PATCH net-next v2 1/7] Driver: Vmxnet3: Prepare for version 3 changes

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/v

[PATCH net-next v2 2/7] Driver: Vmxnet3: Introduce generic command interface to configure the device

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang <gy...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers

[PATCH net-next v2 6/7] Driver: Vmxnet3: Introduce command to register memory region

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 274e145..c3a3164 100644 --- a/drivers/net

[PATCH net-next v2 1/7] Driver: Vmxnet3: Prepare for version 3 changes

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.c

[PATCH net-next v2 2/7] Driver: Vmxnet3: Introduce generic command interface to configure the device

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Guolin Yang Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_defs.h b/drivers/net/vmxnet3/vmxnet3_defs.h index 8345e0c..a26a69d 100644

[PATCH net-next v2 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun <s...@vmware.com> Signed-off-by: Manoj Tammali <tamma...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- v1-v2: v1 patch used special values of rx-usecs to differentiate between coalescing modes. v2 uses relevant fields in struc

[PATCH net-next v2 4/7] Driver: Vmxnet3: Add Receive Data Ring support

2016-05-20 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/v

[PATCH net-next v2 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Keyong Sun Signed-off-by: Manoj Tammali Signed-off-by: Shrikrishna Khare --- v1-v2: v1 patch used special values of rx-usecs to differentiate between coalescing modes. v2 uses relevant fields in struct ethtool_coalesce to choose modes. Also, a new command VMXNET3_CMD_GET_COALESCE

[PATCH net-next v2 4/7] Driver: Vmxnet3: Add Receive Data Ring support

2016-05-20 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 48

[PATCH net-next v2 7/7] Driver: Vmxnet3: Update to Version 3

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 8

[PATCH net-next v2 7/7] Driver: Vmxnet3: Update to Version 3

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 86965cd..71ce4be 100644

[PATCH net-next v2 0/7] Driver: Vmxnet3: Version 3

2016-05-20 Thread Shrikrishna Khare
This patchset upgrades Vmxnet3 to Version 3. Changes in v2: - Following patch is updated. See that patch for details: Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool Shrikrishna Khare (7): Driver: Vmxnet3: Prepare for version 3 changes Driver: Vmxnet3: Introduce

[PATCH net-next v2 3/7] Driver: Vmxnet3: Allow variable length Transmit Data ring buffer

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan <rangaraj...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_et

[PATCH net-next v2 0/7] Driver: Vmxnet3: Version 3

2016-05-20 Thread Shrikrishna Khare
This patchset upgrades Vmxnet3 to Version 3. Changes in v2: - Following patch is updated. See that patch for details: Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool Shrikrishna Khare (7): Driver: Vmxnet3: Prepare for version 3 changes Driver: Vmxnet3: Introduce

[PATCH net-next v2 3/7] Driver: Vmxnet3: Allow variable length Transmit Data ring buffer

2016-05-20 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 9 +++--- drivers/net/vmxnet3/vmxnet3_int.h

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-08 Thread Shrikrishna Khare
On Sat, 7 May 2016, Ben Hutchings wrote: > On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote: > [...] > > +static int > > +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce > > *ec) > > +{ > [...] > > + switch

Re: [PATCH net-next 5/7] Driver: Vmxnet3: Add support for get_coalesce, set_coalesce ethtool operations

2016-05-08 Thread Shrikrishna Khare
On Sat, 7 May 2016, Ben Hutchings wrote: > On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote: > [...] > > +static int > > +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce > > *ec) > > +{ > [...] > > + switch

[PATCH net-next 3/7] Driver: Vmxnet3: Allow variable length Transmit Data ring buffer

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan <rangaraj...@vmware.com> Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_et

[PATCH net-next 3/7] Driver: Vmxnet3: Allow variable length Transmit Data ring buffer

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Sriram Rangarajan Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_defs.h| 12 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 55 ++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 9 +++--- drivers/net/vmxnet3/vmxnet3_int.h

[PATCH net-next 1/7] Driver: Vmxnet3: Prepare for version 3 changes

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/v

[PATCH net-next 1/7] Driver: Vmxnet3: Prepare for version 3 changes

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/Makefile | 4 ++-- drivers/net/vmxnet3/upt1_defs.h | 4 ++-- drivers/net/vmxnet3/vmxnet3_defs.h| 9 ++--- drivers/net/vmxnet3/vmxnet3_drv.c | 22 +- drivers/net/vmxnet3/vmxnet3_ethtool.c

[PATCH net-next 7/7] Driver: Vmxnet3: Update to Version 3

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index f

[PATCH net-next 7/7] Driver: Vmxnet3: Update to Version 3

2016-05-06 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index fe1c6ad..5f98fb2 100644

[PATCH net-next 4/7] Driver: Vmxnet3: Add Receive Data Ring support

2016-05-06 Thread Shrikrishna Khare
Receive Data Ring buffer length is configurable via ethtool -G ethX rx-mini Signed-off-by: Shrikrishna Khare <skh...@vmware.com> --- drivers/net/vmxnet3/vmxnet3_defs.h| 14 +++- drivers/net/vmxnet3/vmxnet3_drv.c | 153 +++--- drivers/net/v

[PATCH net-next 0/7] Driver: Vmxnet3: Version 3

2016-05-06 Thread Shrikrishna Khare
This patchset upgrades Vmxnet3 to Version 3. Shrikrishna Khare (7): Driver: Vmxnet3: Prepare for version 3 changes Driver: Vmxnet3: Introduce generic command interface to configure the device Driver: Vmxnet3: Allow variable length Transmit Data ring buffer Driver: Vmxnet3: Add

  1   2   >