Re: amd-pmc s2idle driver issues

2020-12-22 Thread Shyam Sundar S K
On 12/22/2020 10:14 PM, Deucher, Alexander wrote: > [AMD Public Use] > >> -Original Message- >> From: Alexander Monakov >> Sent: Tuesday, December 22, 2020 10:57 AM >> To: Deucher, Alexander >> Cc: platform-driver-...@vger.kernel.org; S-k, Shyam-sundar > sundar@amd.com>; Hans de

Re: [PATCH] ACPI: PM: s2idle: More x86-specific code to the x86 directory

2020-12-18 Thread Shyam Sundar S K
On 12/18/2020 12:53 AM, Rafael J. Wysocki wrote: > [CAUTION: External Email] > > From: Rafael J. Wysocki > > Some code in drivers/acpi/sleep.c (which is regarded as a generic > file) related to suspend-to-idle support has grown direct dependencies > on x86, but in fact it has been specific

Re: [PATCH] pinctrl: amd: Honor IRQ trigger type requested by the caller

2020-06-28 Thread Shyam Sundar S K
on only pen eject i.e. only-rising edge or only-falling edge is not honored. With this change, it was verified that pen-insert gpio key behavior is correct in both S0 and for wakeup from S3. Signed-off-by: Furquan Shaikh Signed-off-by: Shyam Sundar S K

Re: [PATCH] mmc: sdhci-pci: Only do AMD tuning for HS200

2018-04-09 Thread Shyam Sundar S K
e can implement an amd execute_tuning wrapper callback, and > then conditionally do the HS200 specific tuning for HS200, and otherwise > call back to the standard sdhci_execute_tuning(). > > Signed-off-by: Daniel Kurtz <djku...@chromium.org> Looks good. Acked-by: Shyam Sundar S K <shyam-sundar@amd.com>

Re: [PATCH] mmc: sdhci-pci: Only do AMD tuning for HS200

2018-04-09 Thread Shyam Sundar S K
e can implement an amd execute_tuning wrapper callback, and > then conditionally do the HS200 specific tuning for HS200, and otherwise > call back to the standard sdhci_execute_tuning(). > > Signed-off-by: Daniel Kurtz Looks good. Acked-by: Shyam Sundar S K

Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

2017-01-12 Thread Shyam Sundar S K
Hi Linus, You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch. Do you feel this patch needs to be taken ? Thanks, Shyam On 1/12/2017 1:19 PM, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann

Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning

2017-01-12 Thread Shyam Sundar S K
Hi Linus, You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch. Do you feel this patch needs to be taken ? Thanks, Shyam On 1/12/2017 1:19 PM, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann