we cannot directly
use the existing API. Hence moving rproc_char_device_add() before
device_add() in rproc_add().
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/char_dev.c#n537
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 10
From: Raghavendra Rao Ananta
For security reasons sysfs_emit() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.
Signed-off-by: Raghavendra Rao Ananta
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_sysfs.c | 4 ++--
1 file
On 3/3/2021 12:56 PM, Bjorn Andersson wrote:
On Wed 03 Mar 14:01 CST 2021, Siddharth Gupta wrote:
From: Raghavendra Rao Ananta
For security reasons scnprintf() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.
Thanks for the patch Siddharth
From: Raghavendra Rao Ananta
For security reasons scnprintf() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.
Signed-off-by: Raghavendra Rao Ananta
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_sysfs.c | 5 +++--
1 file
On 1/20/2021 1:10 AM, Christoph Hellwig wrote:
Can you give this patch a spin?
Thanks! This patch fixed the fallback mechanism for me. Attaching logs:
[ 84.410162][ T244] qcom_q6v5_pas .remoteproc-cdsp: Direct
firmware load for cdsp.bX failed with error -2
[ 84.418276][ T244]
On 1/15/2021 8:20 AM, Greg KH wrote:
On Tue, Jan 12, 2021 at 10:31:26AM -0800, Siddharth Gupta wrote:
On 1/8/2021 6:44 AM, Greg KH wrote:
On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote:
On 1/6/2021 2:33 AM, Greg KH wrote:
Since the binary attributes don't support splice_
On 1/14/2021 9:46 AM, Bjorn Andersson wrote:
On Wed 13 Jan 17:01 CST 2021, Siddharth Gupta wrote:
On 1/7/2021 4:21 PM, Bjorn Andersson wrote:
On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote:
Since the split elf blobs will always contain the hash segment, we rely on
I think
On 1/7/2021 4:21 PM, Bjorn Andersson wrote:
On Wed 06 Jan 15:23 CST 2021, Siddharth Gupta wrote:
Since the split elf blobs will always contain the hash segment, we rely on
I think it will sounds better if we add "should" in "we should rely on..."
Sure
the blob
On 1/8/2021 6:44 AM, Greg KH wrote:
On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote:
On 1/6/2021 2:33 AM, Greg KH wrote:
Since the binary attributes don't support splice_{read,write} functions the
calls to splice_{read,write} used the default kernel_{read,write} functions
On 1/6/2021 2:33 AM, Greg KH wrote:
On Tue, Jan 05, 2021 at 05:00:58PM -0800, Siddharth Gupta wrote:
On 1/4/2021 10:36 PM, Greg KH wrote:
On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote:
Hi all,
With the introduction of the filesystem change "fs: don't allow splice
The assumption that the elf program header will always have the hash
segment program header at index 1 may not hold true in all cases. This
change updates the read metadata function to find the hash program header
dynamically.
Signed-off-by: Siddharth Gupta
---
drivers/soc/qcom/mdt_loader.c
the firmware images are split or not. It figures this out by checking if
each program header's segment lies within the file or not.
Signed-off-by: Siddharth Gupta
---
drivers/soc/qcom/mdt_loader.c | 60 +++
1 file changed, 38 insertions(+), 22 deletions
Since the split elf blobs will always contain the hash segment, we rely on
the blob file to get the hash rather than assume that it will be present in
the mdt file. This change uses the hash index to read the appropriate elf
blob to get the hash segment.
Signed-off-by: Siddharth Gupta
This series of patches improves general functionality for the mdt loader.
Patch 1 adds the ability to dynamically detect hash segment location.
Patch 2 updates the logic used to identify whether the firmware is split or not.
Patch 3 updates the way the metadata is read and generated.
Siddharth
On 1/4/2021 10:36 PM, Greg KH wrote:
On Mon, Jan 04, 2021 at 02:43:45PM -0800, Siddharth Gupta wrote:
Hi all,
With the introduction of the filesystem change "fs: don't allow splice
read/write without explicit ops"[1] the fallback mechanism of the firmware
loader[2] no longer works
Hi all,
With the introduction of the filesystem change "fs: don't allow splice
read/write without explicit ops"[1] the fallback mechanism of the
firmware loader[2] no longer works when using sendfile[3] from the
userspace.
Since the binary attributes don't support splice_{read,write}
to collect a full/mini dump by specifying the coredump op.
Co-developed-by: Rishabh Bhatnagar
Signed-off-by: Rishabh Bhatnagar
Co-developed-by: Gurbir Arora
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_common.c | 147
of the
core dump elf.
Co-developed-by: Rishabh Bhatnagar
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_coredump.c| 140
drivers/remoteproc/remoteproc_elf_helpers.h | 26 ++
include/linux/remoteproc.h
Add minidump id for modem in sm8150 chipset so that the regions to be
included in the coredump generated upon a crash is based on the minidump
tables in SMEM instead of those in the ELF header.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1
duced priv_cleanup op in order to making the cleaning of
private elements used by the remoteproc more readable.
- Removed rproc_cleanup_priv as it is no longer needed.
- Switched to if/else format for rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Siddharth Gupta (4
by the
remoteproc driver it will be set to rproc_coredump by default.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux/remoteproc.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
to collect a full/mini dump by specifying the coredump op.
Co-developed-by: Rishabh Bhatnagar
Signed-off-by: Rishabh Bhatnagar
Co-developed-by: Gurbir Arora
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_minidump.h | 64 +++
drivers
Add minidump id for modem in sm8150 chipset so that the regions to be
included in the coredump generated upon a crash is based on the minidump
tables in SMEM instead of those in the ELF header.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1
by the
remoteproc driver it will be set to rproc_coredump by default.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux/remoteproc.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
aning of
private elements used by the remoteproc more readable.
- Removed rproc_cleanup_priv as it is no longer needed.
- Switched to if/else format for rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Siddharth Gupta (4):
remoteproc: core: Add ops to enab
of the
core dump elf.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_coredump.c| 140
drivers/remoteproc/remoteproc_elf_helpers.h | 26 ++
include/linux/remoteproc.h | 1 +
3 files changed
On 10/26/2020 2:09 PM, Bjorn Andersson wrote:
On Fri 02 Oct 21:05 CDT 2020, Siddharth Gupta wrote:
This change adds a new kind of core dump mechanism which instead of dumping
entire program segments of the firmware, dumps sections of the remoteproc
memory which are sufficient to allow
by the
remoteproc driver it will be set to rproc_coredump by default.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux/remoteproc.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
ed priv_cleanup op in order to making the cleaning of
private elements used by the remoteproc more readable.
- Removed rproc_cleanup_priv as it is no longer needed.
- Switched to if/else format for rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Sid
to collect a full/mini dump by specifying the coredump op.
Co-developed-by: Rishabh Bhatnagar
Signed-off-by: Rishabh Bhatnagar
Co-developed-by: Gurbir Arora
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_minidump.h | 64 +++
drivers
Add minidump id for modem in sm8150 chipset so that the regions to be
included in the coredump generated upon a crash is based on the minidump
tables in SMEM instead of those in the ELF header.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1
of the
core dump elf.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_coredump.c| 132
drivers/remoteproc/remoteproc_elf_helpers.h | 27 ++
include/linux/remoteproc.h | 1 +
3 files changed
On 9/25/2020 9:10 PM, Bjorn Andersson wrote:
On Thu 24 Sep 16:51 PDT 2020, Siddharth Gupta wrote:
This patch adds support for collecting minidump in the event of remoteproc
crash. Parse the minidump table based on remoteproc's unique minidump-id,
read all memory regions from the remoteproc's
Add minidump id for modem in sm8150 chipset.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
b/drivers/remoteproc
to collect a full/mini dump by specifying the coredump op.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_minidump.h | 64 +
drivers/remoteproc/qcom_q6v5_pas.c | 106
by the
remoteproc driver it will be set to rproc_coredump by default.The
priv_cleanup op cleans up the private resources used by the remoteproc.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux
rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Siddharth Gupta (3):
remoteproc: core: Add ops to enable custom coredump functionality
remoteproc: qcom: Add capability to collect minidumps
remoteproc: qcom: Add minidump id for sm8150 modem remoteproc
driver
Gentle remind to review this patch series.
Thanks,
Sid
On 9/10/2020 11:57 AM, Siddharth Gupta wrote:
Sometimes firmware sizes can be in ten's of MB's and reading
all the memory during coredump can consume lot of time and
memory.
Introducing support for mini-dumps. Mini-dump contains smallest
Add minidump id for modem in sm8150 chipset.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
b/drivers/remoteproc
by the
remoteproc driver it will be set to rproc_coredump by default.The
priv_cleanup op cleans up the private resources used by the remoteproc.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux
ntroduced priv_cleanup op in order to making the cleaning of
private elements used by the remoteproc more readable.
- Removed rproc_cleanup_priv as it is no longer needed.
- Switched to if/else format for rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Siddharth
to collect a full/mini dump by specifying the coredump op.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_minidump.h | 64 +
drivers/remoteproc/qcom_q6v5_pas.c | 106
rivate elements used by the remoteproc more readable.
- Removed rproc_cleanup_priv as it is no longer needed.
- Switched to if/else format for rproc_alloc in order to keep
the static const decalaration of adsp_minidump_ops.
Siddharth Gupta (3):
remoteproc: core: Add ops to enable custom co
Add minidump id for modem in sm8150 chipset.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
b/drivers/remoteproc
by the
remoteproc driver it will be set to rproc_coredump by default.The
priv_cleanup op cleans up the private resources used by the remoteproc.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux
to collect a full/mini dump by specifying the coredump op.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Gurbir Arora
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/qcom_minidump.h | 64 +
drivers/remoteproc/qcom_q6v5_pas.c | 106
by the
remoteproc driver it will be set to rproc_coredump by default.
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c | 6 +-
include/linux/remoteproc.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
Add the character device during rproc_add. This would create
a character device node at /dev/remoteproc. Userspace
applications can interact with the remote processor using this
interface.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c
character device interface together.
v2 -> v3:
- Move booting of remoteproc from open to a write call.
- Add ioctl interface for future functionality extension.
- Add an ioctl call to default to rproc shutdown on release.
v1 -> v2:
- Fixed comments from Bjorn and Matthew.
Siddharth Gupta
will allow remote processors to
be shutdown when the controlling userpsace application crashes or hangs.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
drivers/remoteproc/Kconfig | 9
On 7/22/2020 10:18 AM, Mathieu Poirier wrote:
On Tue, Jul 21, 2020 at 01:56:35PM -0700, Bjorn Andersson wrote:
On Tue 21 Jul 12:16 PDT 2020, Siddharth Gupta wrote:
On 7/15/2020 2:51 PM, Mathieu Poirier wrote:
On Wed, Jul 15, 2020 at 02:18:39PM -0600, Mathieu Poirier wrote:
On Tue, Jul 07
efault to rproc shutdown on release.
v1 -> v2:
- Fixed comments from Bjorn and Matthew.
Siddharth Gupta (2):
remoteproc: Add remoteproc character device interface
remoteproc: core: Register the character device interface
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
drivers/r
will allow remote processors to
be shutdown when the controlling userpsace application crashes or hangs.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
drivers/remoteproc/Kconfig | 9
Add the character device during rproc_add. This would create
a character device node at /dev/remoteproc. Userspace
applications can interact with the remote processor using this
interface.
Signed-off-by: Rishabh Bhatnagar
Signed-off-by: Siddharth Gupta
---
drivers/remoteproc/remoteproc_core.c
On 6/30/2020 12:43 AM, Arnaud POULIQUEN wrote:
On 6/30/20 7:38 AM, Siddharth Gupta wrote:
On 6/17/2020 1:44 AM, Arnaud POULIQUEN wrote:
On 6/16/20 9:56 PM, risha...@codeaurora.org wrote:
On 2020-04-30 01:30, Arnaud POULIQUEN wrote:
Hi Rishabh,
On 4/21/20 8:10 PM, Rishabh Bhatnagar wrote
On 6/17/2020 1:44 AM, Arnaud POULIQUEN wrote:
On 6/16/20 9:56 PM, risha...@codeaurora.org wrote:
On 2020-04-30 01:30, Arnaud POULIQUEN wrote:
Hi Rishabh,
On 4/21/20 8:10 PM, Rishabh Bhatnagar wrote:
Add the character device interface into remoteproc framework.
This interface can be used
Misuse of CONFIG_* in UAPI headers should result in an error. These config
options can be set in userspace by the user application which includes
these headers to control the APIs and structures being used in a kernel
which supports multiple targets.
Signed-off-by: Siddharth Gupta
---
scripts
On 5/4/2020 12:18 AM, Masahiro Yamada wrote:
On Sun, May 3, 2020 at 12:29 PM Siddharth Gupta wrote:
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes
configuration of different targets to userspace.
Sorry, I missed to point out this.
This statement is not precious
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes
configuration of different targets to userspace.
Signed-off-by: Siddharth Gupta
---
scripts/headers_install.sh | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/scripts/headers_install.sh b
Sure I will make the recommended changes and send a v2 of the patch.
Thanks,
Siddharth
On 5/2/2020 8:03 AM, Masahiro Yamada wrote:
On Sat, May 2, 2020 at 6:55 AM Siddharth Gupta wrote:
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes
configuration of different
Misuse of CONFIG_* in UAPI headers should result in an error as it exposes
configuration of different targets to userspace.
Signed-off-by: Siddharth Gupta
---
scripts/headers_install.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/headers_install.sh b/scripts
61 matches
Mail list logo
