Re: Can VFIO pin only a specific region of guest mem when use pass through devices?

On Tue, Oct 30, 2018 at 11:00:51AM +0800, Peter Xu wrote: > On Mon, Oct 29, 2018 at 12:29:22PM -0600, Alex Williamson wrote: > > On Mon, 29 Oct 2018 17:14:46 +0800 > > Jason Wang wrote: > > > > > On 2018/10/29 上午10:42, Simon Guo wrote: > > > > Hi, >

Re: Can VFIO pin only a specific region of guest mem when use pass through devices?

On Tue, Oct 30, 2018 at 11:00:51AM +0800, Peter Xu wrote: > On Mon, Oct 29, 2018 at 12:29:22PM -0600, Alex Williamson wrote: > > On Mon, 29 Oct 2018 17:14:46 +0800 > > Jason Wang wrote: > > > > > On 2018/10/29 上午10:42, Simon Guo wrote: > > > > Hi, >

Can VFIO pin only a specific region of guest mem when use pass through devices?

Hi, I am using network device pass through mode with qemu x86(-device vfio-pci,host=:xx:yy.z) and “intel_iommu=on” in host kernel command line, and it shows the whole guest memory were pinned(vfio_pin_pages()), viewed by the “top” RES memory output. I understand it is due to device can DMA

Can VFIO pin only a specific region of guest mem when use pass through devices?

Hi, I am using network device pass through mode with qemu x86(-device vfio-pci,host=:xx:yy.z) and “intel_iommu=on” in host kernel command line, and it shows the whole guest memory were pinned(vfio_pin_pages()), viewed by the “top” RES memory output. I understand it is due to device can DMA

Re: [PATCH v15 03/15] selftests/powerpc: Add ptrace tests for EBB

On Fri, Oct 07, 2016 at 08:44:48AM +1100, Michael Ellerman wrote: > wei.guo.si...@gmail.com writes: > > > From: Anshuman Khandual > > > > This patch adds ptrace interface test for EBB/PMU specific > > registers. This also adds some generic ptrace interface > > based

Re: [PATCH v15 03/15] selftests/powerpc: Add ptrace tests for EBB

On Fri, Oct 07, 2016 at 08:44:48AM +1100, Michael Ellerman wrote: > wei.guo.si...@gmail.com writes: > > > From: Anshuman Khandual > > > > This patch adds ptrace interface test for EBB/PMU specific > > registers. This also adds some generic ptrace interface > > based helper functions to be used

Re: [PATCH v14 13/15] selftests/powerpc: Add ptrace tests for TM SPR registers

system-ppc64 --enable-kvm -machine pseries,accel=kvm,usb=off -m > 4096 -realtime mlock=off -smp 4,sockets=1,cores=2,threads=2 -nographic > -vga none > > > > Signed-off-by: Anshuman Khandual <khand...@linux.vnet.ibm.com> > > Signed-off-by: Simon Guo <wei.guo.si...@gmail.

Re: [PATCH v14 13/15] selftests/powerpc: Add ptrace tests for TM SPR registers

es,accel=kvm,usb=off -m > 4096 -realtime mlock=off -smp 4,sockets=1,cores=2,threads=2 -nographic > -vga none > > > > Signed-off-by: Anshuman Khandual > > Signed-off-by: Simon Guo > > --- > >  tools/testing/selftests/powerpc/ptrace/Makefile|   3 +- >

Re: [PATCH v14 13/15] selftests/powerpc: Add ptrace tests for TM SPR registers

On Wed, Sep 14, 2016 at 03:04:12PM +1000, Cyril Bur wrote: > On Mon, 2016-09-12 at 15:33 +0800, wei.guo.si...@gmail.com wrote: > > From: Anshuman Khandual > > > > This patch adds ptrace interface test for TM SPR registers. This > > also adds ptrace interface based

Re: [PATCH v14 13/15] selftests/powerpc: Add ptrace tests for TM SPR registers

On Wed, Sep 14, 2016 at 03:04:12PM +1000, Cyril Bur wrote: > On Mon, 2016-09-12 at 15:33 +0800, wei.guo.si...@gmail.com wrote: > > From: Anshuman Khandual > > > > This patch adds ptrace interface test for TM SPR registers. This > > also adds ptrace interface based helper functions related to TM

Re: [PATCH] powerpc: set used_vsr/used_vr/used_spe in sigreturn path when MSR bits are active

On Tue, Jul 26, 2016 at 04:06:01PM +0800, wei.guo.si...@gmail.com wrote: > From: Simon Guo <wei.guo.si...@gmail.com> > > Normally, when MSR[VSX/VR/SPE] bits = 1, the used_vsr/used_vr/used_spe > bit have already been set. However signal frame locates at user space > and it

Re: [PATCH] powerpc: set used_vsr/used_vr/used_spe in sigreturn path when MSR bits are active

On Tue, Jul 26, 2016 at 04:06:01PM +0800, wei.guo.si...@gmail.com wrote: > From: Simon Guo > > Normally, when MSR[VSX/VR/SPE] bits = 1, the used_vsr/used_vr/used_spe > bit have already been set. However signal frame locates at user space > and it is controlled by user applic

Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected.

Hi David, On Wed, Aug 31, 2016 at 04:14:14PM -0700, David Rientjes wrote: > On Tue, 30 Aug 2016, wei.guo.si...@gmail.com wrote: > > > From: Simon Guo <wei.guo.si...@gmail.com> > > > > This patch adds mlock() test for multiple invocation on > > the same addr

Re: [PATCH 4/4] selftests/vm: add test for mlock() when areas are intersected.

Hi David, On Wed, Aug 31, 2016 at 04:14:14PM -0700, David Rientjes wrote: > On Tue, 30 Aug 2016, wei.guo.si...@gmail.com wrote: > > > From: Simon Guo > > > > This patch adds mlock() test for multiple invocation on > > the same address area, and verify it doe

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Thu, Jul 21, 2016 at 08:57:29PM +1000, Michael Ellerman wrote: > Can one of you send a properly formatted and signed-off patch. I will work on that. Thanks, Simon

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Thu, Jul 21, 2016 at 08:57:29PM +1000, Michael Ellerman wrote: > Can one of you send a properly formatted and signed-off patch. I will work on that. Thanks, Simon

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

Michael, Ben, On Fri, Jul 08, 2016 at 08:02:42PM +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-07-07 at 23:21 +1000, Benjamin Herrenschmidt wrote: > >>  > >> I think the right fix is that if a restore_sigcontext() has the MSR > >>

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

Michael, Ben, On Fri, Jul 08, 2016 at 08:02:42PM +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-07-07 at 23:21 +1000, Benjamin Herrenschmidt wrote: > >>  > >> I think the right fix is that if a restore_sigcontext() has the MSR > >> bits set, > >> it should set

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Fri, Jul 08, 2016 at 08:02:42PM +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-07-07 at 23:21 +1000, Benjamin Herrenschmidt wrote: > >>  > >> I think the right fix is that if a restore_sigcontext() has the MSR > >> bits set, > >>

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Fri, Jul 08, 2016 at 08:02:42PM +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > On Thu, 2016-07-07 at 23:21 +1000, Benjamin Herrenschmidt wrote: > >>  > >> I think the right fix is that if a restore_sigcontext() has the MSR > >> bits set, > >> it should set the

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Thu, Jul 07, 2016 at 11:21:18PM +1000, Benjamin Herrenschmidt wrote: > I think the right fix is that if a restore_sigcontext() has the MSR bits set, > it should set the corresponding used_* flag. > > Or is there a reason why that won't work ? That sounds reaonable to me. I will prepare a

Re: [v4] powerpc: Export thread_struct.used_vr/used_vsr to user space

On Thu, Jul 07, 2016 at 11:21:18PM +1000, Benjamin Herrenschmidt wrote: > I think the right fix is that if a restore_sigcontext() has the MSR bits set, > it should set the corresponding used_* flag. > > Or is there a reason why that won't work ? That sounds reaonable to me. I will prepare a

Re: [RESEND, v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

Hi Michael, On Tue, Jul 05, 2016 at 03:40:40PM +1000, Michael Ellerman wrote: > On Wed, 2016-06-04 at 07:00:12 UTC, Simon Guo wrote: > > These 2 fields track whether user process has used Altivec/VSX > > registers or not. They are used by kernel to setup signal frame > > on

Re: [RESEND, v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

Hi Michael, On Tue, Jul 05, 2016 at 03:40:40PM +1000, Michael Ellerman wrote: > On Wed, 2016-06-04 at 07:00:12 UTC, Simon Guo wrote: > > These 2 fields track whether user process has used Altivec/VSX > > registers or not. They are used by kernel to setup signal frame > > on

Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled

Hi, On Mon, May 09, 2016 at 05:22:15PM -0700, Shaohua Li wrote: > if trace isn't enabled, parsing cgroup path just wastes cpu > > Signed-off-by: Shaohua Li > --- > block/blk-throttle.c | 5 ++--- > include/linux/blktrace_api.h | 9 + > 2 files changed, 11

Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled

Hi, On Mon, May 09, 2016 at 05:22:15PM -0700, Shaohua Li wrote: > if trace isn't enabled, parsing cgroup path just wastes cpu > > Signed-off-by: Shaohua Li > --- > block/blk-throttle.c | 5 ++--- > include/linux/blktrace_api.h | 9 + > 2 files changed, 11 insertions(+), 3

Re: [RESEND][PATCH v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

Hi Michael, On Wed, Apr 06, 2016 at 03:00:12PM +0800, Simon Guo wrote: > These 2 fields track whether user process has used Altivec/VSX > registers or not. They are used by kernel to setup signal frame > on user stack correctly regarding vector part. > > CRIU(Checkpoint and Restor

Re: [RESEND][PATCH v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

Hi Michael, On Wed, Apr 06, 2016 at 03:00:12PM +0800, Simon Guo wrote: > These 2 fields track whether user process has used Altivec/VSX > registers or not. They are used by kernel to setup signal frame > on user stack correctly regarding vector part. > > CRIU(Checkpoint and Restor

[RESEND][PATCH v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo <wei.guo.si...@gmail.com> Reviewed-by: Laurent Dufour <lduf...@linux.vnet.ibm.com> --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/po

[RESEND][PATCH v2] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo Reviewed-by: Laurent Dufour --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/powerpc/kernel/ptrace.c | 39

[PATCH] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo <wei.guo.si...@gmail.com> Reviewed-by: Laurent Dufour <lduf...@linux.vnet.ibm.com> --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/po

[PATCH] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo Reviewed-by: Laurent Dufour --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/powerpc/kernel/ptrace.c | 39

[PATCH] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo <wei.guo.si...@gmail.com> Reviewed-by: Laurent Dufour <lduf...@linux.vnet.ibm.com> --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/po

[PATCH] powerpc: Export thread_struct.used_vr/used_vsr to user space

to setup signal frame correctly. And CRIU will need to restore these 2 fields for the restored process. Signed-off-by: Simon Guo Reviewed-by: Laurent Dufour --- arch/powerpc/include/uapi/asm/ptrace.h | 11 ++ arch/powerpc/kernel/ptrace.c | 39

[PATCH] powerpc: correct VSX used_vsr comment

used_vsr flag is set if process has used VSX register, instead of Altivec register. This patch corrects the wrong comment. Signed-off-by: Simon Guo <wei.guo.si...@gmail.com> --- arch/powerpc/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc: correct VSX used_vsr comment

used_vsr flag is set if process has used VSX register, instead of Altivec register. This patch corrects the wrong comment. Signed-off-by: Simon Guo --- arch/powerpc/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/processor.h

[PATCH 4.1.0-rc4] STAGING: Declare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c

Declare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by: Simon Guo --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4.1.0-rc4] STAGING: Declare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c

Declare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +- 1 file changed

[PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c

Delare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by: Simon Guo --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4.1.0-rc4] STAGING: Delare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c

Delare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +- 1 file changed, 1

[PATCH v2 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b

[PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 189 +++- 1 file changed, 91 insertions(+), 98 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index ba2e137..5d9050c 100644 --- a/drivers

[PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 189 +++- 1 file changed, 91 insertions(+), 98 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index ba2e137..5d9050c

[PATCH v2 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH 3.19.0-rc5 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b

[PATCH 3.19.0-rc5 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 189 +++- 1 file changed, 91 insertions(+), 98 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index ba2e137..5d9050c 100644 --- a/drivers

[PATCH 3.19.0-rc5 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 189 +++- 1 file changed, 91 insertions(+), 98 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index ba2e137..5d9050c

[PATCH 3.19.0-rc5 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH 3.19.0-rc5 03/03] STAGING: Fix pcl818.c coding style issue: no space before tabs

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - please, no space before tabs Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers

[PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b

[PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible It is fixed by reformatting the comment block to usual comment style. Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 195

Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Ian, At 2015/1/26 19:31, Ian Abbott wrote: Okay, but this comment block really needs reformatting to use the usual block comment style, and with spaces to line up the columns instead of tabs so it still looks okay when the " * " is removed from the start of each line of the block comment.

[PATCH 3.19.0-rc5 03/03] STAGING: Fix pcl818.c coding style issue: no space before tabs

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - please, no space before tabs Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible It is fixed by reformatting the comment block to usual comment style. Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 195

[PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging

Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Ian, At 2015/1/26 19:31, Ian Abbott wrote: Okay, but this comment block really needs reformatting to use the usual block comment style, and with spaces to line up the columns instead of tabs so it still looks okay when the * is removed from the start of each line of the block comment.

[PATCH 3.19.0-rc5 03/03] STAGING: Fix pcl818.c coding style issue: no space before tabs

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - please, no space before tabs Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers

[PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b

[PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 3.19.0-rc5 02/03] STAGING: Fix pcl818.c coding style issue: line over 80 characters

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions

[PATCH 3.19.0-rc5 03/03] STAGING: Fix pcl818.c coding style issue: no space before tabs

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - please, no space before tabs Signed-off-by: Simon Guo wei.guo.si...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 3.19.0-rc3 1/1] STAGING: Fix pcl818.c coding style issue

Correct coding style problem in pcl818.c. The coding style problems(29 warnings detected by checkpatch.pl) includes: - line over 80 characters - There is space before tabs The changed file has been verified with checkpatch.pl to be clean for warnings/errors. Signed-off-by: Simon Guo

[PATCH 3.19.0-rc3 1/1] STAGING: Fix pcl818.c coding style issue

Correct coding style problem in pcl818.c. The coding style problems(29 warnings detected by checkpatch.pl) includes: - line over 80 characters - There is space before tabs The changed file has been verified with checkpatch.pl to be clean for warnings/errors. Signed-off-by: Simon Guo wei.guo.si