Hi Ohad,
On Fri, Mar 15, 2013 at 10:29 AM, Erwan Yvin wrote:
> From: Erwan Yvin
>
> Implement the vringh callback functions in order
> to manage host virtio rings and handle kicks.
> This allows virtio device to request host-virtio-rings.
>
> Signed-off-by: Erwan Yvin
Any chance that you
Hi Ohad,
On Fri, Mar 15, 2013 at 10:29 AM, Erwan Yvin erwan.y...@stericsson.com wrote:
From: Erwan Yvin erwan.y...@stericsson.com
Implement the vringh callback functions in order
to manage host virtio rings and handle kicks.
This allows virtio device to request host-virtio-rings.
even noticed by checkpatch --strict,
but it does improve the style...
Acked-by: Sjur Brændeland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
There is quite a bit of churn for stuff not even noticed by checkpatch --strict,
but it does improve the style...
Acked-by: Sjur Brændeland sjur.brandel...@stericsson.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Hi Ohad,
On Thu, Feb 21, 2013 at 6:55 PM, Ohad Ben-Cohen wrote:
> On Thu, Feb 21, 2013 at 7:28 PM, Sjur Brændeland wrote:
>> The motivation for using vringh was to avoid copying buffers
>> when sending data from the modem to the host.
>
> I may be missing something here
Hi Ohad,
> I was wondering - can you please explain your motivation for using
> vringh in caif ?
>
> We have internally discussed supporting multiple remote processors
> talking to each other using rpmsg, and in that scenario using vringh
> can considerably simplifies the solution (no need to
Hi Ido,
On Wed, Feb 20, 2013 at 11:46 AM, Ido Yariv wrote:
> Hi Sjur,
>
> On Sun, Feb 10, 2013 at 12:39:12PM +0100, sjur.brandel...@stericsson.com
> wrote:
>> From: Sjur Brændeland
>>
>> Copy resource table from first to second firmware loading.
>> After
Hi Ido,
On Wed, Feb 20, 2013 at 11:46 AM, Ido Yariv i...@wizery.com wrote:
Hi Sjur,
On Sun, Feb 10, 2013 at 12:39:12PM +0100, sjur.brandel...@stericsson.com
wrote:
From: Sjur Brændeland sjur.brandel...@stericsson.com
Copy resource table from first to second firmware loading.
After
Hi Ohad,
I was wondering - can you please explain your motivation for using
vringh in caif ?
We have internally discussed supporting multiple remote processors
talking to each other using rpmsg, and in that scenario using vringh
can considerably simplifies the solution (no need to decide in
Hi Ohad,
On Thu, Feb 21, 2013 at 6:55 PM, Ohad Ben-Cohen o...@wizery.com wrote:
On Thu, Feb 21, 2013 at 7:28 PM, Sjur Brændeland sjurb...@gmail.com wrote:
The motivation for using vringh was to avoid copying buffers
when sending data from the modem to the host.
I may be missing something
On Wed, Feb 20, 2013 at 5:05 PM, Ohad Ben-Cohen wrote:
> Hi Sjur,
>
> On Tue, Feb 12, 2013 at 1:49 PM, wrote:
>> From: Sjur Brændeland
>>
>> Add functions for creating, deleting and kicking host-side virtio rings.
>>
>> The host ring is not integrated
On Wed, Feb 20, 2013 at 5:05 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Hi Sjur,
On Tue, Feb 12, 2013 at 1:49 PM, sjur.brandel...@stericsson.com wrote:
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add functions for creating, deleting and kicking host-side virtio rings.
The host
> Sjur Brændeland writes:
>> How about supporting struct vringh_kiov and struct kvec as well?
>> I currently get the following complaints with my V2 patch-set:
>>
>> drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of
>> ‘vringh_iov_init’ from i
Sjur Brændeland sjurb...@gmail.com writes:
How about supporting struct vringh_kiov and struct kvec as well?
I currently get the following complaints with my V2 patch-set:
drivers/net/caif/caif_virtio.c:486:2: warning: passing argument 1 of
‘vringh_iov_init’ from incompatible pointer type
Hi Rusty,
On Wed, Feb 13, 2013 at 11:16 AM, Rusty Russell wrote:
> Sjur BRENDELAND writes:
>>> > +static inline void ctx_prep_iov(struct cfv_napi_context *ctx)
>>> > +{
>>> > + if (ctx->riov.allocated) {
>>> > + kfree(ctx->riov.iov);
>>> > + ctx->riov.iov = NULL;
>>> > +
Hi Rusty,
On Wed, Feb 13, 2013 at 11:16 AM, Rusty Russell ru...@rustcorp.com.au wrote:
Sjur BRENDELAND sjur.brandel...@stericsson.com writes:
+static inline void ctx_prep_iov(struct cfv_napi_context *ctx)
+{
+ if (ctx-riov.allocated) {
+ kfree(ctx-riov.iov);
+
On Fri, Jan 11, 2013 at 7:37 AM, Rusty Russell wrote:
>virtio_host: host-side implementation of virtio rings (untested!)
>
>Getting use of virtio rings correct is tricky, and a recent patch saw
>an implementation of in-kernel rings (as separate from userspace).
How do you see the in-kernel API
On Fri, Jan 11, 2013 at 12:35 AM, Rusty Russell wrote:
> Hi Sjur!
>
> OK, the Internet was no help here, how do you pronounce Sjur?
> I'm guessing "shoor" rhyming with tour until I know better.
Thank you for asking! This is pretty close yes.
I usually tell people to pronounce it like
On Fri, Jan 11, 2013 at 12:35 AM, Rusty Russell ru...@rustcorp.com.au wrote:
Hi Sjur!
OK, the Internet was no help here, how do you pronounce Sjur?
I'm guessing shoor rhyming with tour until I know better.
Thank you for asking! This is pretty close yes.
I usually tell people to
On Fri, Jan 11, 2013 at 7:37 AM, Rusty Russell ru...@rustcorp.com.au wrote:
virtio_host: host-side implementation of virtio rings (untested!)
Getting use of virtio rings correct is tricky, and a recent patch saw
an implementation of in-kernel rings (as separate from userspace).
How do you see
Hi Rusty,
On Thu, Jan 10, 2013 at 11:30 AM, Rusty Russell wrote:
...
>I now have some lightly-tested code (via a userspace harness).
Great - thank you for looking into this. I will start integrating this
with my patches
when you send out a proper patch.
...
> diff --git
Hi Rusty,
On Thu, Jan 10, 2013 at 11:30 AM, Rusty Russell ru...@rustcorp.com.au wrote:
...
I now have some lightly-tested code (via a userspace harness).
Great - thank you for looking into this. I will start integrating this
with my patches
when you send out a proper patch.
...
diff --git
Set the vring addresses in the resource table so that
the remote device can read the actual addresses used.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c |5 +
include/linux/remoteproc.h |2 ++
2 files changed, 7 insertions(+), 0 deletions
Verify that firmware name is defined in rproc_add.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers/remoteproc/remoteproc_core.c
index
of resources is done before registering
the virtio devices.
- The virtio device uses resource bits, status and config
space in memory shared with the device.
Review comments and feedback are welcomed!
Thanks,
Sjur
Sjur Brændeland (11):
remoteproc: Code cleanup of resource parsing
remoteproc
Refatcor rproc_elf_find_rsc_table and split out the scanning
for the section header named resource table. This is done to
prepare for loading firmware once.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_elf_loader.c | 83 +---
1 files changed, 51
Call rproc_get_rsctab_addr() to get the address
of the resource table in shared memory.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
Support virtio configuration space and device status and
feature negotiation with remote device. This virtio device
can now access the resource table in shared memory.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c | 10 --
drivers/remoteproc
Add function find_rsc_table_va to firmware ops. This function
returns the location of the resource table in shared memory
after loading.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_elf_loader.c | 16 ++-
drivers/remoteproc/remoteproc_internal.h | 13
Postpone the registration of virtio devices until all
vritio ring resource has been allocated.
This fixes the following bug: The driver's start callback
is called before all vring notify ids are allocated and
max_notifyid will be increased after starting the remoteproc.
Signed-off-by: Sjur
Add information on the resource entry sequence number
to the callback functions.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
are no longer
located at start of device memory. But the vring address
can be read from the resource table. Also Carveout
must be located before the virtio rings in the resource
table.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c | 111
Combine the almost identical functions rproc_handle_virtio_rsc
and rproc_handle_boot_rsc.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c | 51 --
1 files changed, 12 insertions(+), 39 deletions(-)
diff --git a/drivers/remoteproc
Add state RPROC_LOADED as firmware loading and startup will be
different states.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_debugfs.c |1 +
include/linux/remoteproc.h |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers
Combine the almost identical functions rproc_handle_virtio_rsc
and rproc_handle_boot_rsc.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c | 51 --
1 files changed, 12 insertions(+), 39 deletions(-)
diff
Add state RPROC_LOADED as firmware loading and startup will be
different states.
Signed-off-by: Sjur Brændeland sjur.brandel...@steicsson.com
---
drivers/remoteproc/remoteproc_debugfs.c |1 +
include/linux/remoteproc.h |3 ++-
2 files changed, 3 insertions(+), 1 deletions
are no longer
located at start of device memory. But the vring address
can be read from the resource table. Also Carveout
must be located before the virtio rings in the resource
table.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc
Add information on the resource entry sequence number
to the callback functions.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/remoteproc
Postpone the registration of virtio devices until all
vritio ring resource has been allocated.
This fixes the following bug: The driver's start callback
is called before all vring notify ids are allocated and
max_notifyid will be increased after starting the remoteproc.
Signed-off-by: Sjur
Add function find_rsc_table_va to firmware ops. This function
returns the location of the resource table in shared memory
after loading.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_elf_loader.c | 16 ++-
drivers/remoteproc
Support virtio configuration space and device status and
feature negotiation with remote device. This virtio device
can now access the resource table in shared memory.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c | 10
Call rproc_get_rsctab_addr() to get the address
of the resource table in shared memory.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/remoteproc
Refatcor rproc_elf_find_rsc_table and split out the scanning
for the section header named resource table. This is done to
prepare for loading firmware once.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_elf_loader.c | 83
of resources is done before registering
the virtio devices.
- The virtio device uses resource bits, status and config
space in memory shared with the device.
Review comments and feedback are welcomed!
Thanks,
Sjur
Sjur Brændeland (11):
remoteproc: Code cleanup of resource parsing
remoteproc
Set the vring addresses in the resource table so that
the remote device can read the actual addresses used.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c |5 +
include/linux/remoteproc.h |2 ++
2 files changed, 7
Verify that firmware name is defined in rproc_add.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers
and disables use of tty console and
the virtio control queue.
Signed-off-by: Sjur Brændeland
Acked-by: Amit Shah
---
drivers/char/virtio_console.c | 192 ++-
include/uapi/linux/virtio_ids.h |1 +
2 files changed, 170 insertions(+), 23 deletions(-)
diff --git
ng.
NOTE: These two patches are identical to first two patches of the V8 patch-set,
but are rebased to virtio-next.
Regards,
Sjur
Sjur Brændeland (2):
virtio_console: Merge struct buffer_token into struct port_buffer
virtio_console: Add support for remoteproc serial
drivers/char/virti
Refactoring the splice functionality by unifying the approach for
sending scatter-lists and regular buffers. This simplifies
buffer handling and reduces code size. Splice will now allocate
a port_buffer and send_buf() and free_buf() can always be used
for any buffer.
Signed-off-by: Sjur
are identical to first two patches of the V8 patch-set,
but are rebased to virtio-next.
Regards,
Sjur
Sjur Brændeland (2):
virtio_console: Merge struct buffer_token into struct port_buffer
virtio_console: Add support for remoteproc serial
drivers/char/virtio_console.c | 317
Refactoring the splice functionality by unifying the approach for
sending scatter-lists and regular buffers. This simplifies
buffer handling and reduces code size. Splice will now allocate
a port_buffer and send_buf() and free_buf() can always be used
for any buffer.
Signed-off-by: Sjur
and disables use of tty console and
the virtio control queue.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
Acked-by: Amit Shah amit.s...@redhat.com
---
drivers/char/virtio_console.c | 192 ++-
include/uapi/linux/virtio_ids.h |1 +
2 files changed
Signed-off-by: Sjur Brændeland
---
>> Please pick the virtio spec from
>>
>> https://github.com/rustyrussell/virtio-spec
>>
>> and update the spec with info for remote-proc.
>
>Hi Sjur,
>
>I didn't hear back from you on this..
>
Hi Amit
Sorry f
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
Please pick the virtio spec from
https://github.com/rustyrussell/virtio-spec
and update the spec with info for remote-proc.
Hi Sjur,
I didn't hear back from you on this..
Hi Amit
Sorry for the delay. I've had this ready
Hi Ohad,
On Sat, Aug 11, 2012 at 2:34 PM, Ohad Ben-Cohen wrote:
> On Fri, Aug 10, 2012 at 6:30 PM, Ohad Ben-Cohen wrote:
>> This will solve all sort of open issues we have (or going to have soon):
>>
...
> 1. dynamically-allocated address of the vrings can be communicated
> 2. vdev statuses can
Refatcor rproc_elf_find_rsc_table and split out the scanning
for the section header named resource table. This is done to
prepare for loading firmware once when rproc is registered.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_elf_loader.c | 83
crating
virtio devices. This enables dynamically-allocated address and
kick-ids of vrings to be communicated to the remote device.
This also pave the way for implementing bi-directional virtio
config-space and virtio feature negotiation.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc
Add state RPROC_LOADED. Prepare for the state when the firmware
is loaded, but remote device is not started.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_debugfs.c |1 +
include/linux/remoteproc.h |3 ++-
2 files changed, 3 insertions(+), 1 deletion
Add support for bi-directional virtio configuration space,
visibility of device status to remote processor and
device feature-bit negotiation with remote device.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_core.c |4 ++--
drivers/remoteproc/remoteproc_virtio.c | 30
Add function find_rsc_table_va to firmware ops. This function
returns the location of the resource table in device memory
after the firmware is loaded.
Signed-off-by: Sjur Brændeland
---
drivers/remoteproc/remoteproc_elf_loader.c | 16 ++-
drivers/remoteproc/remoteproc_internal.h
From: Sjur Brændeland
This patch-set adds support for shared resource table between
Linux kernel and remote devices.
Features:
1. dynamically-allocated address of the vrings can be communicated
2. vdev statuses can be communicated
3. virtio config space becomes bi-directional
4. virtio feature
From: Sjur Brændeland s...@brendeland.net
This patch-set adds support for shared resource table between
Linux kernel and remote devices.
Features:
1. dynamically-allocated address of the vrings can be communicated
2. vdev statuses can be communicated
3. virtio config space becomes bi-directional
Add function find_rsc_table_va to firmware ops. This function
returns the location of the resource table in device memory
after the firmware is loaded.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_elf_loader.c | 16 ++-
drivers
Add support for bi-directional virtio configuration space,
visibility of device status to remote processor and
device feature-bit negotiation with remote device.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_core.c |4 ++--
drivers
Add state RPROC_LOADED. Prepare for the state when the firmware
is loaded, but remote device is not started.
Signed-off-by: Sjur Brændeland sjur.brandel...@steicsson.com
---
drivers/remoteproc/remoteproc_debugfs.c |1 +
include/linux/remoteproc.h |3 ++-
2 files changed, 3
crating
virtio devices. This enables dynamically-allocated address and
kick-ids of vrings to be communicated to the remote device.
This also pave the way for implementing bi-directional virtio
config-space and virtio feature negotiation.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
Refatcor rproc_elf_find_rsc_table and split out the scanning
for the section header named resource table. This is done to
prepare for loading firmware once when rproc is registered.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/remoteproc/remoteproc_elf_loader.c
Hi Ohad,
On Sat, Aug 11, 2012 at 2:34 PM, Ohad Ben-Cohen o...@wizery.com wrote:
On Fri, Aug 10, 2012 at 6:30 PM, Ohad Ben-Cohen o...@wizery.com wrote:
This will solve all sort of open issues we have (or going to have soon):
...
1. dynamically-allocated address of the vrings can be
);
>
> void unregister_virtio_device(struct virtio_device *dev)
> {
> + int index = dev->index; /* save for after device release */
> +
> device_unregister(>dev);
> - ida_simple_remove(_index_ida, dev->index);
> + ida_simple_remove(_i
>> > Note: This patch is compile tested only. I have done the removal
>> > of buffers from out-queue in handle_control_message()
>> > when host has acked the close request. This seems less
>> > racy than doing it in the release function.
>>
>> This confuses me... why are we doing this in case
>>
Note: This patch is compile tested only. I have done the removal
of buffers from out-queue in handle_control_message()
when host has acked the close request. This seems less
racy than doing it in the release function.
This confuses me... why are we doing this in case
; /* save for after device release */
+
device_unregister(dev-dev);
- ida_simple_remove(virtio_index_ida, dev-index);
+ ida_simple_remove(virtio_index_ida, index);
}
EXPORT_SYMBOL_GPL(unregister_virtio_device);
Acked-by: Sjur Brændeland sjur.brandel...@stericsson.com
Great
Hi Rusty,
> So, this adds another host-side virtqueue implementation.
>
> Can we combine them together conveniently? You pulled out more stuff
> into vring.h which is a start, but it's a bit overloaded.
> Perhaps we should separate the common fields into struct vring, and use
> it to build:
>
>
Hi Rusty,
So, this adds another host-side virtqueue implementation.
Can we combine them together conveniently? You pulled out more stuff
into vring.h which is a start, but it's a bit overloaded.
Perhaps we should separate the common fields into struct vring, and use
it to build:
From: Sjur Brændeland
Move the vring_virtqueue structure, memory barrier and debug
macros out from virtio_ring.c to the new header file vring.h.
This is done in order to allow other kernel modules to access the
virtio internal data-structures.
Signed-off-by: Sjur Brændeland
---
Tis patch
From: Sjur Brændeland
Add last avilable index to the vring_virtqueue structure,
this is done to prepare for implementation of the reversed vring.
Signed-off-by: Sjur Brændeland
---
drivers/virtio/vring.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/virtio/vring.h b
From: Sjur Brændeland
Add the CAIF Virtio Link layer, used for communicating with a
modem over shared memory. Virtio is used as the transport mechanism.
In the TX direction the virtio rings are used in the normal fashion,
sending data in the available ring. But in the rx direction the
the we
From: Sjur Brændeland
Enable option to force call of callback function even if
used ring is empty. This is needed for reversed vring.
Add a helper function __vring_interrupt and add extra
boolean argument for forcing callback when interrupt is called.
The original vring_interrupt semantic
irtio code. There are several
options on how to structure this, and feedback is welcomed.
Thanks,
Sjur
Sjur Brændeland (4):
virtio: Move definitions to header file vring.h
include/vring.h: Add support for reversed vritio rings.
virtio_ring: Call callback function even when used ring is empty
c
. There are several
options on how to structure this, and feedback is welcomed.
Thanks,
Sjur
Sjur Brændeland (4):
virtio: Move definitions to header file vring.h
include/vring.h: Add support for reversed vritio rings.
virtio_ring: Call callback function even when used ring is empty
caif_virtio
From: Sjur Brændeland sjur.brandel...@stericsson.com
Enable option to force call of callback function even if
used ring is empty. This is needed for reversed vring.
Add a helper function __vring_interrupt and add extra
boolean argument for forcing callback when interrupt is called.
The original
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add the CAIF Virtio Link layer, used for communicating with a
modem over shared memory. Virtio is used as the transport mechanism.
In the TX direction the virtio rings are used in the normal fashion,
sending data in the available ring
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add last avilable index to the vring_virtqueue structure,
this is done to prepare for implementation of the reversed vring.
Signed-off-by: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/virtio/vring.h |3 +++
1 file changed, 3
From: Sjur Brændeland sjur.brandel...@stericsson.com
Move the vring_virtqueue structure, memory barrier and debug
macros out from virtio_ring.c to the new header file vring.h.
This is done in order to allow other kernel modules to access the
virtio internal data-structures.
Signed-off-by: Sjur
From: Sjur Brændeland
Refactoring the splice functionality by unifying the approach for
sending scatter-lists and regular buffers. This simplifies
buffer handling and reduces code size. Splice will now allocate
a port_buffer and send_buf() and free_buf() can always be used
for any buffer
From: Sjur Brændeland
Add a simple serial connection driver called
VIRTIO_ID_RPROC_SERIAL (11) for communicating with a
remote processor in an asymmetric multi-processing
configuration.
This implementation reuses the existing virtio_console
implementation, and adds support for DMA allocation
From: Sjur Brændeland
Remove buffers from the out-queue when a rproc_serial device
is removed. Rproc_serial communicates with remote processors
that may crash and leave buffers in the out-queue. But the
virtio_console device is not supposed to leave buffers in the
out-queue when a port
From: Sjur Brændeland
This patch-set introduces a new virtio type "rproc_serial" for communicating
with remote processors over shared memory. The driver depends on the
the remoteproc framework. As preparation for introducing "rproc_serial"
I've done a refactoring of the tran
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch-set introduces a new virtio type rproc_serial for communicating
with remote processors over shared memory. The driver depends on the
the remoteproc framework. As preparation for introducing rproc_serial
I've done a refactoring
From: Sjur Brændeland sjur.brandel...@stericsson.com
Remove buffers from the out-queue when a rproc_serial device
is removed. Rproc_serial communicates with remote processors
that may crash and leave buffers in the out-queue. But the
virtio_console device is not supposed to leave buffers
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add a simple serial connection driver called
VIRTIO_ID_RPROC_SERIAL (11) for communicating with a
remote processor in an asymmetric multi-processing
configuration.
This implementation reuses the existing virtio_console
implementation, and adds
From: Sjur Brændeland sjur.brandel...@stericsson.com
Refactoring the splice functionality by unifying the approach for
sending scatter-lists and regular buffers. This simplifies
buffer handling and reduces code size. Splice will now allocate
a port_buffer and send_buf() and free_buf() can always
Hi Rusty,
> The free-outside-interrupt issue is usually dealt with by offloading to
> a wq, but your variant works (and isn't too ugly).
Ok, thanks.
>> +static void reclaim_dma_bufs(void)
>> +{
>> + unsigned long flags;
>> + struct port_buffer *buf, *tmp;
>> + LIST_HEAD(tmp_list);
Hi Rusty,
The free-outside-interrupt issue is usually dealt with by offloading to
a wq, but your variant works (and isn't too ugly).
Ok, thanks.
+static void reclaim_dma_bufs(void)
+{
+ unsigned long flags;
+ struct port_buffer *buf, *tmp;
+ LIST_HEAD(tmp_list);
+
+ if
Hi,
On Fri, Aug 10, 2012 at 5:30 PM, Ohad Ben-Cohen wrote:
> The general direction I have in mind is to put the resource table in
> its final location while we do the first pass of fw parsing.
>
> This will solve all sort of open issues we have (or going to have soon):
>
> 1.
Hi,
On Fri, Aug 10, 2012 at 5:30 PM, Ohad Ben-Cohen o...@wizery.com wrote:
The general direction I have in mind is to put the resource table in
its final location while we do the first pass of fw parsing.
This will solve all sort of open issues we have (or going to have soon):
1.
t might be implicitly valid today, but may break in the
>>> future).
>>>
>>> If you want, I can just change that before applying.
>>
>> Sounds good, please just go ahead and change this before applying.
>> Thank you.
>
> I'm going to squash the below i
Hi Ohad,
> Thanks, it looks good.
>
> It might be safer though to invoke ->setup() in probe/remove, instead
> of in start/stop (just like you essentially did before).
>
> This way we don't assume that stop is always called before remove (as
> assumption that might be implicitly valid today, but
).
If you want, I can just change that before applying.
Sounds good, please just go ahead and change this before applying.
Thank you.
I'm going to squash the below into the patch - please ack before I
apply and push - thanks!
Looks good, thanks.
Acked-by: Sjur Brændeland sjur.brandel
Hi Ohad,
Thanks, it looks good.
It might be safer though to invoke -setup() in probe/remove, instead
of in start/stop (just like you essentially did before).
This way we don't assume that stop is always called before remove (as
assumption that might be implicitly valid today, but may break
1 - 100 of 128 matches
Mail list logo
