[PATCH] MAINTAINERS: Remove myself as reviewer

This address is gonna bounce in the not too far away future. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index dc3ff3aaa588..4502f016be12 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH] MAINTAINERS: Remove myself as reviewer

This address is gonna bounce in the not too far away future. Signed-off-by: Soren Brinkmann --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index dc3ff3aaa588..4502f016be12 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2161,7 +2161,6 @@ F

[PATCH v2 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file

[PATCH v2 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard

[PATCH v2 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644

[PATCH v2 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board.

[PATCH 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file

[PATCH 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644

[PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard

[PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board.

[PATCH] gpio: zynq: Clarify quirk and provide helper function

or zynqmp. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/gpio/gpio-zynq.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index ed87c9a6e0e6..df0851464006 100644 --- a/d

[PATCH] gpio: zynq: Clarify quirk and provide helper function

or zynqmp. Signed-off-by: Soren Brinkmann --- drivers/gpio/gpio-zynq.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index ed87c9a6e0e6..df0851464006 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers

[PATCH] vivid: Enable 4k resolution for webcam capture device

Add 3840x2160 as valid resolution for the webcam capture input and adjust the webcam intervals accordingly. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- Hi, we'd like to use the vivid webcam capture device with a 4k resolution. This basically seems to do the trick, thoug

[PATCH] vivid: Enable 4k resolution for webcam capture device

Add 3840x2160 as valid resolution for the webcam capture input and adjust the webcam intervals accordingly. Signed-off-by: Soren Brinkmann --- Hi, we'd like to use the vivid webcam capture device with a 4k resolution. This basically seems to do the trick, though, I'm not sure

[PATCH LINUX v5 1/8] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial

[PATCH LINUX v5 6/8] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATCH LINUX v5 4/8] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- v4: - clarify workings of the ISR in the commit message --- drivers/tty/serial

[PATCH LINUX v5 2/8] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley

[PATCH LINUX v5 3/8] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v3: - changed this patch to not always enable the transmitter

[PATCH LINUX v5 7/8] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial

[PATCH LINUX v5 0/8] tty: xuartps: Fix lock ups

Hi, as requested by Peter, this is the first part of my series which has the patches reviewed by Peter. I'll submit the second part separately. There are no new changes within the patches. Thanks, Sören Sören Brinkmann (8): tty: xuartps: Beautify read-modify writes tty:

[PATCH LINUX v5 5/8] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12

[PATCH LINUX v5 8/8] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v4: - added Peter's additional

[PATCH LINUX v5 8/8] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurl

[PATCH LINUX v5 5/8] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> --- driver

[PATCH LINUX v5 0/8] tty: xuartps: Fix lock ups

Hi, as requested by Peter, this is the first part of my series which has the patches reviewed by Peter. I'll submit the second part separately. There are no new changes within the patches. Thanks, Sören Sören Brinkmann (8): tty: xuartps: Beautify read-modify writes tty:

[PATCH LINUX v5 1/8] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/tty/serial/xilinx_uartps.c | 15 +

[PATCH LINUX v5 6/8] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

[PATCH LINUX v5 4/8] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by: Moritz Fischer <moritz.fisc...@et

[PATCH LINUX v5 2/8] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Re

[PATCH LINUX v5 3/8] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Pete

[PATCH LINUX v5 7/8] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurl

[PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

Signed-off-by: Soren Brinkmann --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index 857eda5c7217..b5d1facadf16 100644 --- a/arch/arm64/boot/dts

[PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index 857eda5c7217..b5d1facadf16

[PATH TRIVIAL] Documentation: cpu-hotplug: Fix sysfs mount instructions

The instructions for mounting sysfs are inconsistent in instructing to create the directory '/sysfs' but then mounting sysfs to /sys. Also, indentation is slightly off. Signed-off-by: Soren Brinkmann --- Documentation/cpu-hotplug.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATH TRIVIAL] Documentation: cpu-hotplug: Fix sysfs mount instructions

The instructions for mounting sysfs are inconsistent in instructing to create the directory '/sysfs' but then mounting sysfs to /sys. Also, indentation is slightly off. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- Documentation/cpu-hotplug.txt | 2 +- 1 file chan

[PATCH LINUX v4 13/13] tty: xuartps: Remove '_OFFSET' suffix from #defines

Remove the _OFFSET suffix from all register defines which makes code a little easier to read and avoids a few line breaks. Suggested-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 221 ++--- 1

[PATCH LINUX v4 03/13] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v3: - changed this patch to not always enable the transmitter

[PATCH LINUX v4 05/13] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12

[PATCH LINUX v4 11/13] tty: xuartps: Cleanup: Reformat if-else

Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- v4: - clarify workings of the ISR in the commit message --- drivers/tty/serial

[PATCH LINUX v4 01/13] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial

[PATCH LINUX v4 00/13] tty: xuartps: Fix lock ups

Hi, I picked up all the review tags from Peter and Moritz and addressed Peter's comments. Most patches are unchanged but I added the info Peter suggested/provided to some commit messages. The patches "tty: xuartps: Move request_irq to after setting up the HW", "tty: xuartps: Improve sysrq

[PATCH LINUX v4 02/13] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley

[PATCH LINUX v4 09/13] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- v4: - added Peter's additional

[PATCH LINUX v4 08/13] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial

[PATCH LINUX v4 12/13] tty: xuartps: Improve sysrq handling

ied to simply call uart_handle_sysrq. Suggested-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/

[PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

Request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. Reported-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - this patch has been added. Thanks to Peter for pointing it out and providing commit

[PATCH LINUX v4 07/13] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann Reviewed-by: Peter Hurley --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATCH LINUX v4 10/13] tty: xuartps: Refactor IRQ handling

The system could deadlock handling RX IRQs when RX-related IRQ conditions became true while the receiver was disabled. To avoid this, enable/disable the RX/TX IRQs together with the receiver/transmitter. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 18

[PATCH LINUX v4 08/13] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurl

[PATCH LINUX v4 12/13] tty: xuartps: Improve sysrq handling

ied to simply call uart_handle_sysrq. Suggested-by: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- v4: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 20 +--- 1 file changed, 5 insertions(+), 15 del

[PATCH LINUX v4 09/13] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Fixes a problem where every char received after a parity or frame error in the current isr will also be tagged as a parity or frame error. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurl

[PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

Request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. Reported-by: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- v4: - this patch has been a

[PATCH LINUX v4 07/13] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driver

[PATCH LINUX v4 10/13] tty: xuartps: Refactor IRQ handling

The system could deadlock handling RX IRQs when RX-related IRQ conditions became true while the receiver was disabled. To avoid this, enable/disable the RX/TX IRQs together with the receiver/transmitter. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/

[PATCH LINUX v4 01/13] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/tty/serial/xilinx_uartps.c | 15 +

[PATCH LINUX v4 00/13] tty: xuartps: Fix lock ups

Hi, I picked up all the review tags from Peter and Moritz and addressed Peter's comments. Most patches are unchanged but I added the info Peter suggested/provided to some commit messages. The patches "tty: xuartps: Move request_irq to after setting up the HW", "tty: xuartps: Improve sysrq

[PATCH LINUX v4 02/13] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Re

[PATCH LINUX v4 13/13] tty: xuartps: Remove '_OFFSET' suffix from #defines

Remove the _OFFSET suffix from all register defines which makes code a little easier to read and avoids a few line breaks. Suggested-by: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- v4: - added this patch --- driver

[PATCH LINUX v4 11/13] tty: xuartps: Cleanup: Reformat if-else

Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(

[PATCH LINUX v4 04/13] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Bits in the ISR are cleared by writing them as '1'. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by: Moritz Fischer <moritz.fisc...@et

[PATCH LINUX v4 05/13] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> --- driver

[PATCH LINUX v4 03/13] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> Reviewed-by: Pete

[PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 6a7cd4e057ae..ef114d7a0623

[PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 deletions

[PATCH LINUX v3 03/10] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley Signed-off-by: Soren Brinkmann --- v3: - changed this patch to not always enable the transmitter, but keep the check

[PATCH LINUX v3 02/10] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- drivers/tty/serial

[PATCH LINUX v3 10/10] tty: xuartps: Cleanup: Reformat if-else

Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers

[PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

Hi, here is v3 of this series. It's largely the same as before, but I adjusted 'tty: xuartps: Don't consider circular buffer when enabling transmitter' according to Peter's suggestions. I also spent some time trying to get Peter's test for flow control and xchar running. The xchar thing fails

[PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATCH LINUX v3 07/10] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATCH LINUX v3 06/10] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 6ffd3bbe3e18

[PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

Hi, here is v3 of this series. It's largely the same as before, but I adjusted 'tty: xuartps: Don't consider circular buffer when enabling transmitter' according to Peter's suggestions. I also spent some time trying to get Peter's test for flow control and xchar running. The xchar thing fails

[PATCH LINUX v3 10/10] tty: xuartps: Cleanup: Reformat if-else

Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(

[PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drive

[PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 20 1 file chang

[PATCH LINUX v3 03/10] tty: xuartps: Don't consider circular buffer when enabling transmitter

Restarting the transmitter even if the circ buffer is empty may be necessary to push out remaining data when the port is restarted after being stopped. Cc: Peter Hurley <pe...@hurleysoftware.com> Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- v3: - change

[PATCH LINUX v3 02/10] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.

[PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/

[PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_ua

[PATCH LINUX v3 07/10] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/

[PATCH LINUX v3 06/10] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_ua

[PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

start_tx must start transmitting characters. Regardless of the state of the circular buffer, always enable the transmitter hardware. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial

[PATH RESEND v2 07/10] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 6 ++ 1 file

[PATH RESEND v2 10/10] tty: xuartps: Cleanup: Reformat if-else

Convert an if-else into the more common early return on error, reducing the indent level of the happy path. Signed-off-by: Soren Brinkmann --- v2: - added this patch --- drivers/tty/serial/xilinx_uartps.c | 124 ++--- 1 file changed, 62 insertions(+), 62

[PATH RESEND v2 05/10] tty: xuartps: Improve startup function

The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 deletions

[PATH RESEND v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATH RESEND v2 00/10] tty: xuartps: Fix lock ups

Hi, I guess this series got probably lost during the merge window. Hence, I resend the patches. This is v2, hopefully without any build issues. The changes are the same as before, just the warning reported by kbuild test robot about unused variables have been fixed. And, I added one more patch

[PATH RESEND v2 08/10] tty: xuartps: Move RX path into helper function

Move RX-related IRQ handling into a helper function. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial

[PATH RESEND v2 06/10] tty: xuartps: Keep lock for whole ISR

The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 167e0f4bcf7a

[PATH RESEND v2 02/10] tty: xuartps: Use spinlock to serialize HW access

Instead of disabling the IRQ, use the spin lock to serialize accesses to the HW. This protects the driver from interference of non-IRQ callbacks with each other and makes the driver more consistent in its serialization method. Signed-off-by: Soren Brinkmann --- v2: - remove unused variable

[PATH RESEND v2 01/10] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index

[PATH RESEND v2 04/10] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index df6778d17949..b7fc30639292

[PATH RESEND v2 04/10] tty: xuartps: Clear interrupt status register in shutdown

When shutting down the UART, clear the interrupt status register. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c

[PATH RESEND v2 01/10] tty: xuartps: Beautify read-modify writes

Non-functional, formatting changes to ease reading the code. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drive

[PATH RESEND v2 07/10] tty: xuartps: Acquire port lock for shutdown

Shutting down the UART port can happen while console operations are in progress. Holding the port lock serializes these operations and avoids the UART HW to be disabled in the middle of console prints. Signed-off-by: Soren Brinkmann <soren.brinkm...@xilinx.com> --- drivers/tty/

  1   2   3   4   5   6   7   8   9   10   >