[PATCH v3 1/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-05 Thread Sowjanya Komatineni
this patch remove this quirk for Tegra210. Fixes: b5a84ecf025a ("mmc: tegra: Add Tegra210 support") Cc: stable # 5.4 Acked-by: Adrian Hunter Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-t

[PATCH v3 2/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186

2020-08-05 Thread Sowjanya Komatineni
tch remove this quirk for Tegra186. Fixes: 4346b7c7941d ("mmc: tegra: Add Tegra186 support") Cc: stable # 5.4 Acked-by: Adrian Hunter Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.

[PATCH v3 0/6] Fix timeout clock used by hardware data timeout

2020-08-05 Thread Sowjanya Komatineni
s tag [v2]: Includes minor fix - Patch-0006: parentheses around operand of '!' Sowjanya Komatineni (6): sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210 sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186 arm64: tegra: Add missing t

[PATCH v3 6/6] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-05 Thread Sowjanya Komatineni
025a ("mmc: tegra: Add Tegra210 support") Cc: stable # 5.4 Acked-by: Adrian Hunter Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/mmc/host/sdhci-tegra.c b/dr

[PATCH v3 3/6] arm64: tegra: Add missing timeout clock to Tegra210 SDMMC

2020-08-05 Thread Sowjanya Komatineni
ock should be kept enabled by SDMMC driver. Fixes: 742af7e7a0a1 ("arm64: tegra: Add Tegra210 support") Cc: stable # 5.4 Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --g

[PATCH v3 4/6] arm64: tegra: Add missing timeout clock to Tegra186 SDMMC nodes

2020-08-05 Thread Sowjanya Komatineni
by default. So, this clock should be kept enabled by the SDMMC driver. Fixes: 39cb62cb8973 ("arm64: tegra: Add Tegra186 support") Cc: stable # 5.4 Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 20 1 file changed, 12 insert

Re: [PATCH v2 6/6] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 1:06 AM, Adrian Hunter wrote: On 4/08/20 7:29 am, Sowjanya Komatineni wrote: commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") So that could be a Fixes tag also? Thanks Adrian. Will resend with fixes tag. Sowjanya Tegra210 and later has a separate sdmmc

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 7:19 AM, Dmitry Osipenko wrote: 05.08.2020 17:05, Dmitry Osipenko пишет: 05.08.2020 16:46, Thierry Reding пишет: On Mon, Aug 03, 2020 at 08:42:24AM -0700, Sowjanya Komatineni wrote: With the split of MIPI calibration into tegra_mipi_calibrate() and tegra_mipi_wait(), MIPI clock is

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 9:47 AM, Dmitry Osipenko wrote: 05.08.2020 19:33, Sowjanya Komatineni пишет: On 8/5/20 7:19 AM, Dmitry Osipenko wrote: 05.08.2020 17:05, Dmitry Osipenko пишет: 05.08.2020 16:46, Thierry Reding пишет: On Mon, Aug 03, 2020 at 08:42:24AM -0700, Sowjanya Komatineni wrote: With the

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 10:04 AM, Sowjanya Komatineni wrote: On 8/5/20 9:57 AM, Dmitry Osipenko wrote: 05.08.2020 19:50, Sowjanya Komatineni пишет: On 8/5/20 9:47 AM, Dmitry Osipenko wrote: 05.08.2020 19:33, Sowjanya Komatineni пишет: On 8/5/20 7:19 AM, Dmitry Osipenko wrote: 05.08.2020 17:05, Dmitry

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 10:34 AM, Dmitry Osipenko wrote: 05.08.2020 20:29, Sowjanya Komatineni пишет: ... UART_FST_MIPI_CAL is the clock used for calibration logic which is FSM that goes thru sequence codes and when done waits for pads to be in LP-11 to apply results. MIPI_CLK is controller gate clock

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 10:46 AM, Sowjanya Komatineni wrote: On 8/5/20 10:34 AM, Dmitry Osipenko wrote: 05.08.2020 20:29, Sowjanya Komatineni пишет: ... UART_FST_MIPI_CAL is the clock used for calibration logic which is FSM that goes thru sequence codes and when done waits for pads to be in LP-11 to

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 10:23 AM, Dmitry Osipenko wrote: 05.08.2020 20:04, Sowjanya Komatineni пишет: On 8/5/20 9:57 AM, Dmitry Osipenko wrote: 05.08.2020 19:50, Sowjanya Komatineni пишет: On 8/5/20 9:47 AM, Dmitry Osipenko wrote: 05.08.2020 19:33, Sowjanya Komatineni пишет: On 8/5/20 7:19 AM, Dmitry

Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-05 Thread Sowjanya Komatineni
On 8/5/20 9:57 AM, Dmitry Osipenko wrote: 05.08.2020 19:50, Sowjanya Komatineni пишет: On 8/5/20 9:47 AM, Dmitry Osipenko wrote: 05.08.2020 19:33, Sowjanya Komatineni пишет: On 8/5/20 7:19 AM, Dmitry Osipenko wrote: 05.08.2020 17:05, Dmitry Osipenko пишет: 05.08.2020 16:46, Thierry Reding

[PATCH v2 3/6] arm64: tegra: Add missing timeout clock to Tegra210 SDMMC

2020-08-03 Thread Sowjanya Komatineni
ock should be kept enabled by SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.

[PATCH v2 6/6] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-03 Thread Sowjanya Komatineni
C register SDHCI_TEGRA_VENDOR_SYS_SW_CTRL can be used to choose either TMCLK or SDCLK for data timeout. Default USE_TMCLK_FOR_DATA_TIMEOUT bit is set to 1 and TMCLK is used for data timeout by Tegra SDMMC hardware and having TMCLK not enabled is not recommended. So, this patch fixes it. Signed-off-by

[PATCH v2 2/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186

2020-08-03 Thread Sowjanya Komatineni
tch remove this quirk for Tegra186. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 2be3511..31ed321 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/driver

[PATCH v2 1/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-03 Thread Sowjanya Komatineni
this patch remove this quirk for Tegra210. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 0a3f9d0..2be3511 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++

[PATCH v2 5/6] arm64: tegra: Add missing timeout clock to Tegra194 SDMMC nodes

2020-08-03 Thread Sowjanya Komatineni
So, this clock should be kept enabled by SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/teg

[PATCH v2 4/6] arm64: tegra: Add missing timeout clock to Tegra186 SDMMC nodes

2020-08-03 Thread Sowjanya Komatineni
by default. So, this clock should be kept enabled by the SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm6

[PATCH v2 0/6] Fix timeout clock used by hardware data timeout

2020-08-03 Thread Sowjanya Komatineni
r fix - Patch-0006: parentheses around operand of '!' Sowjanya Komatineni (6): sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210 sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186 arm64: tegra: Add missing timeout clock to Tegra210 SDMMC ar

[PATCH v1 4/6] arm64: tegra: Add missing timeout clock to Tegra186 SDMMC nodes

2020-08-03 Thread Sowjanya Komatineni
by default. So, this clock should be kept enabled by the SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm6

[PATCH v1 6/6] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-03 Thread Sowjanya Komatineni
C register SDHCI_TEGRA_VENDOR_SYS_SW_CTRL can be used to choose either TMCLK or SDCLK for data timeout. Default USE_TMCLK_FOR_DATA_TIMEOUT bit is set to 1 and TMCLK is used for data timeout by Tegra SDMMC hardware and having TMCLK not enabled is not recommended. So, this patch fixes it. Signed-off-by

[PATCH v1 2/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra186

2020-08-03 Thread Sowjanya Komatineni
tch remove this quirk for Tegra186. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 2be3511..31ed321 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/driver

[PATCH v1 5/6] arm64: tegra: Add missing timeout clock to Tegra194 SDMMC nodes

2020-08-03 Thread Sowjanya Komatineni
So, this clock should be kept enabled by SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/teg

[PATCH v1 0/6] Fix timeout clock used by hardware data timeout

2020-08-03 Thread Sowjanya Komatineni
Tegra sdmmc driver. This series includes patches to fix this for Tegra210/Tegra186/Tegra194. These patches need to be manually backported for 4.9, 4.14, 4.19, 5.4 Will send patches to backport separately once these patches are ack'd. Sowjanya Komatineni (6): sdhci: tegra: R

[PATCH v1 3/6] arm64: tegra: Add missing timeout clock to Tegra210 SDMMC

2020-08-03 Thread Sowjanya Komatineni
ock should be kept enabled by SDMMC driver. Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.

[PATCH v1 1/6] sdhci: tegra: Remove SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK for Tegra210

2020-08-03 Thread Sowjanya Komatineni
this patch remove this quirk for Tegra210. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 0a3f9d0..2be3511 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++

[PATCH v8 05/10] media: tegra-video: Separate CSI stream enable and disable implementations

2020-08-03 Thread Sowjanya Komatineni
This patch separates implementation of CSI stream enable and disable into separate functions for readability. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/csi.c | 51 ++--- 1 file changed, 35 insertions(+), 16

[PATCH v8 03/10] media: tegra-video: Update format lookup to offset based

2020-08-03 Thread Sowjanya Komatineni
. Offset based look up is used with sensor device graph (non TPG) where format enumeration can list all supported formats for the specific sensor mbus codes. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-08-03 Thread Sowjanya Komatineni
get invoked. So added new API tegra_mipi_cancel_calibration() which disables MIPI clock and consumer drivers can call this in such cases. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/gpu/drm/tegra/dsi.c | 4 ++-- drivers/gpu/host1x/mipi.c | 19

[PATCH v8 04/10] dt-bindings: tegra: Update VI and CSI bindings with port info

2020-08-03 Thread Sowjanya Komatineni
Update VI and CSI bindings to add port and endpoint nodes as per media video-interfaces DT binding document. Acked-by: Rob Herring Signed-off-by: Sowjanya Komatineni --- .../display/tegra/nvidia,tegra20-host1x.txt| 92 +- 1 file changed, 90 insertions(+), 2

[PATCH v8 06/10] media: tegra-video: Add support for external sensor capture

2020-08-03 Thread Sowjanya Komatineni
this driver supports V4L2 video node centric only. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/Kconfig| 1 + drivers/staging/media/tegra-video/TODO | 4 - drivers/staging/media/tegra-video/csi.c | 139 +- drivers/staging/media/tegra-video/csi.h

[PATCH v8 07/10] media: tegra-video: Add support for selection ioctl ops

2020-08-03 Thread Sowjanya Komatineni
support, this patch also updates try format to use try crop rectangle either from subdev frame size enumeration or from subdev crop boundary. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 106 + 1 file changed, 106 insertions(+) diff

[PATCH v8 02/10] media: tegra-video: Enable TPG based on kernel config

2020-08-03 Thread Sowjanya Komatineni
Tegra internal TPG mode is only for Tegra vi and csi testing without a real sensor and driver should default support real sensor. So, This patch adds CONFIG_VIDEO_TEGRA_TPG and enables Tegra internal TPG mode only when this config is selected. Signed-off-by: Sowjanya Komatineni --- drivers

[PATCH v8 10/10] media: tegra-video: Compute settle times based on the clock rate

2020-08-03 Thread Sowjanya Komatineni
receiver will ignore any HS transitions on clock lane starting from the beginning of T-CLK-PREPARE. T-HS-SETTLE time is the interval during which recevier will ignore any HS transitions on data lane starting from the beginning of T-HS-PREPARE. Signed-off-by: Sowjanya Komatineni --- drivers/staging

[PATCH v8 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-08-03 Thread Sowjanya Komatineni
receiver is able to catch the very first clock transition. So, CSI receiver is always enabled prior to sensor streaming and trigger of calibration start is done during CSI subdev streaming and status of calibration is verified after sensor stream on. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya

[PATCH v8 01/10] media: tegra-video: Fix channel format alignment

2020-08-03 Thread Sowjanya Komatineni
clamps width as per Tegra minimum and maximum limits. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video

[PATCH v8 00/10] Support for Tegra video capture from external sensor

2020-08-03 Thread Sowjanya Komatineni
and source endpoint for csi. - Use data-lanes endpoint property for csi. - Update tegra_mipi_request() to take device node pointer argument rather than adding extra API. - Remove checking for clk pointer before clk_disable. Sowjanya Komatineni (10): media: tegra

[PATCH v7 03/10] media: tegra-video: Update format lookup to offset based

2020-07-31 Thread Sowjanya Komatineni
. Offset based look up is used with sensor device graph (non TPG) where format enumeration can list all supported formats for the specific sensor mbus codes. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH v7 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-31 Thread Sowjanya Komatineni
get invoked. So added new API tegra_mipi_cancel_calibration() which disables MIPI clock and consumer drivers can call this in such cases. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/gpu/drm/tegra/dsi.c | 4 ++-- drivers/gpu/host1x/mipi.c | 19

[PATCH v7 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-07-31 Thread Sowjanya Komatineni
receiver is able to catch the very first clock transition. So, CSI receiver is always enabled prior to sensor streaming and trigger of calibration start is done during CSI subdev streaming and status of calibration is verified after sensor stream on. Signed-off-by: Sowjanya Komatineni --- drivers

[PATCH v7 02/10] media: tegra-video: Enable TPG based on kernel config

2020-07-31 Thread Sowjanya Komatineni
Tegra internal TPG mode is only for Tegra vi and csi testing without a real sensor and driver should default support real sensor. So, This patch adds CONFIG_VIDEO_TEGRA_TPG and enables Tegra internal TPG mode only when this config is selected. Signed-off-by: Sowjanya Komatineni --- drivers

[PATCH v7 05/10] media: tegra-video: Separate CSI stream enable and disable implementations

2020-07-31 Thread Sowjanya Komatineni
This patch separates implementation of CSI stream enable and disable into separate functions for readability. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/csi.c | 51 ++--- 1 file changed, 35 insertions(+), 16

[PATCH v7 01/10] media: tegra-video: Fix channel format alignment

2020-07-31 Thread Sowjanya Komatineni
clamps width as per Tegra minimum and maximum limits. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video

[PATCH v7 06/10] media: tegra-video: Add support for external sensor capture

2020-07-31 Thread Sowjanya Komatineni
this driver supports V4L2 video node centric only. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/Kconfig| 1 + drivers/staging/media/tegra-video/TODO | 4 - drivers/staging/media/tegra-video/csi.c | 130 - drivers/staging/media/tegra-video/csi.h

[PATCH v7 07/10] media: tegra-video: Add support for selection ioctl ops

2020-07-31 Thread Sowjanya Komatineni
support, this patch also updates try format to use try crop rectangle either from subdev frame size enumeration or from subdev crop boundary. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 106 + 1 file changed, 106 insertions(+) diff

[PATCH v7 00/10] Support for Tegra video capture from external sensor

2020-07-31 Thread Sowjanya Komatineni
source endpoint for csi. - Use data-lanes endpoint property for csi. - Update tegra_mipi_request() to take device node pointer argument rather than adding extra API. - Remove checking for clk pointer before clk_disable. Sowjanya Komatineni (10): media: tegra-video

[PATCH v7 10/10] media: tegra-video: Compute settle times based on the clock rate

2020-07-31 Thread Sowjanya Komatineni
receiver will ignore any HS transitions on clock lane starting from the beginning of T-CLK-PREPARE. T-HS-SETTLE time is the interval during which recevier will ignore any HS transitions on data lane starting from the beginning of T-HS-PREPARE. Signed-off-by: Sowjanya Komatineni --- drivers/staging

[PATCH v7 04/10] dt-bindings: tegra: Update VI and CSI bindings with port info

2020-07-31 Thread Sowjanya Komatineni
Update VI and CSI bindings to add port and endpoint nodes as per media video-interfaces DT binding document. Acked-by: Rob Herring Signed-off-by: Sowjanya Komatineni --- .../display/tegra/nvidia,tegra20-host1x.txt| 92 +- 1 file changed, 90 insertions(+), 2

Re: [RFC PATCH v6 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-07-31 Thread Sowjanya Komatineni
On 7/31/20 1:42 PM, Dmitry Osipenko wrote: 31.07.2020 19:29, Sowjanya Komatineni пишет: On 7/31/20 9:14 AM, Dmitry Osipenko wrote: 31.07.2020 18:46, Sowjanya Komatineni пишет: On 7/31/20 4:39 AM, Dmitry Osipenko wrote: 31.07.2020 12:02, Sowjanya Komatineni пишет: ... @@ -249,13 +249,47

Re: [PATCH v3 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-07-31 Thread Sowjanya Komatineni
On 7/31/20 9:26 AM, Sakari Ailus wrote: Hi Sowjanya, Thanks for the patch. On Mon, Jul 20, 2020 at 10:01:34AM -0700, Sowjanya Komatineni wrote: IMX274 has VANA analog 2.8V supply, VDIG digital core 1.8V supply, and VDDL digital io 1.2V supply which are optional based on camera module design

Re: [RFC PATCH v6 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-07-31 Thread Sowjanya Komatineni
On 7/31/20 9:14 AM, Dmitry Osipenko wrote: 31.07.2020 18:46, Sowjanya Komatineni пишет: On 7/31/20 4:39 AM, Dmitry Osipenko wrote: 31.07.2020 12:02, Sowjanya Komatineni пишет: ... @@ -249,13 +249,47 @@ static int tegra_csi_enable_stream(struct v4l2_subdev *subdev)   return ret

Re: [RFC PATCH v6 00/10] Support for Tegra video capture from external sensor

2020-07-31 Thread Sowjanya Komatineni
Sorry Wolfram. Will remove from CC list on my next replies.. On 7/31/20 6:40 AM, Wolfram Sang wrote: On Fri, Jul 31, 2020 at 02:02:39AM -0700, Sowjanya Komatineni wrote: This series adds support for video capture from external camera sensor to Tegra video driver. No need anymore to CC me or

Re: [RFC PATCH v6 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-07-31 Thread Sowjanya Komatineni
On 7/31/20 4:39 AM, Dmitry Osipenko wrote: 31.07.2020 12:02, Sowjanya Komatineni пишет: ... @@ -249,13 +249,47 @@ static int tegra_csi_enable_stream(struct v4l2_subdev *subdev) return ret; } + if (csi_chan->mipi) { + ret = tegra_mipi_enable(csi_c

[RFC PATCH v6 03/10] media: tegra-video: Update format lookup to offset based

2020-07-31 Thread Sowjanya Komatineni
. Offset based look up is used with sensor device graph (non TPG) where format enumeration can list all supported formats for the specific sensor mbus codes. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[RFC PATCH v6 07/10] media: tegra-video: Add support for selection ioctl ops

2020-07-31 Thread Sowjanya Komatineni
support, this patch also updates try format to use try crop rectangle either from subdev frame size enumeration or from subdev crop boundary. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 106 + 1 file changed, 106 insertions(+) diff

[RFC PATCH v6 06/10] media: tegra-video: Add support for external sensor capture

2020-07-31 Thread Sowjanya Komatineni
this driver supports V4L2 video node centric only. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/Kconfig| 1 + drivers/staging/media/tegra-video/TODO | 4 - drivers/staging/media/tegra-video/csi.c | 130 - drivers/staging/media/tegra-video/csi.h

[RFC PATCH v6 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-31 Thread Sowjanya Komatineni
get invoked. So added new API tegra_mipi_cancel_calibration() which disables MIPI clock and consumer drivers can call this in such cases. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/gpu/drm/tegra/dsi.c | 4 ++-- drivers/gpu/host1x/mipi.c | 19

[RFC PATCH v6 04/10] dt-bindings: tegra: Update VI and CSI bindings with port info

2020-07-31 Thread Sowjanya Komatineni
Update VI and CSI bindings to add port and endpoint nodes as per media video-interfaces DT binding document. Acked-by: Rob Herring Signed-off-by: Sowjanya Komatineni --- .../display/tegra/nvidia,tegra20-host1x.txt| 92 +- 1 file changed, 90 insertions(+), 2

[RFC PATCH v6 05/10] media: tegra-video: Separate CSI stream enable and disable implementations

2020-07-31 Thread Sowjanya Komatineni
This patch separates implementation of CSI stream enable and disable into separate functions for readability. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/csi.c | 51 ++--- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a

[RFC PATCH v6 09/10] media: tegra-video: Add CSI MIPI pads calibration

2020-07-31 Thread Sowjanya Komatineni
receiver is able to catch the very first clock transition. So, CSI receiver is always enabled prior to sensor streaming and trigger of calibration start is done during CSI subdev streaming and status of calibration is verified after sensor stream on. Signed-off-by: Sowjanya Komatineni --- drivers

[RFC PATCH v6 02/10] media: tegra-video: Enable TPG based on kernel config

2020-07-31 Thread Sowjanya Komatineni
Tegra internal TPG mode is only for Tegra vi and csi testing without a real sensor and driver should default support real sensor. So, This patch adds CONFIG_VIDEO_TEGRA_TPG and enables Tegra internal TPG mode only when this config is selected. Signed-off-by: Sowjanya Komatineni --- drivers

[RFC PATCH v6 00/10] Support for Tegra video capture from external sensor

2020-07-31 Thread Sowjanya Komatineni
. - Remove checking for clk pointer before clk_disable. Sowjanya Komatineni (10): media: tegra-video: Fix channel format alignment media: tegra-video: Enable TPG based on kernel config media: tegra-video: Update format lookup to offset based dt-bindings: tegra: Update VI and CSI bindings

[RFC PATCH v6 01/10] media: tegra-video: Fix channel format alignment

2020-07-31 Thread Sowjanya Komatineni
clamps width as per Tegra minimum and maximum limits. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video

[RFC PATCH v6 10/10] media: tegra-video: Compute settle times based on the clock rate

2020-07-31 Thread Sowjanya Komatineni
receiver will ignore any HS transitions on clock lane starting from the beginning of T-CLK-PREPARE. T-HS-SETTLE time is the interval during which recevier will ignore any HS transitions on data lane starting from the beginning of T-HS-PREPARE. Signed-off-by: Sowjanya Komatineni --- drivers/staging

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:53 PM, Dmitry Osipenko wrote: 30.07.2020 03:55, Sowjanya Komatineni пишет: On 7/29/20 5:52 PM, Sowjanya Komatineni wrote: On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very cri

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:52 PM, Sowjanya Komatineni wrote: On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very critical error? Hence just printing a warning message should be enough. Using dev_err to r

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very critical error? Hence just printing a warning message should be enough. Using dev_err to report calibration failure. Are you suggesting t

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:27 PM, Sowjanya Komatineni wrote: On 7/29/20 4:59 PM, Sowjanya Komatineni wrote: On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 4:59 PM, Sowjanya Komatineni wrote: On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret < 0) +    dev_err(csi_chan->csi->dev, + 

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret < 0) +    dev_err(csi_chan->csi->dev, +    "MIPI calibration failed: %d\n

Re: [RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 4:42 PM, Dmitry Osipenko wrote: 29.07.2020 20:55, Sowjanya Komatineni пишет: On 7/29/20 10:08 AM, Dmitry Osipenko wrote: 28.07.2020 19:04, Sowjanya Komatineni пишет: ... +void tegra_mipi_cancel_calibration(struct tegra_mipi_device *device) +{ Doesn't MIPI_CAL need to be

Re: [RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 10:08 AM, Dmitry Osipenko wrote: 28.07.2020 19:04, Sowjanya Komatineni пишет: ... +void tegra_mipi_cancel_calibration(struct tegra_mipi_device *device) +{ Doesn't MIPI_CAL need to be reset here? No need to reset MIPI CAL Could you please explain why. There is a calibration

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 8:59 AM, Sowjanya Komatineni wrote: On 7/28/20 3:30 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: +    /* + * TRM has incorrectly documented to wait for done status from + * calibration logic after CSI interface power on. + * As per the

Re: [RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 4:03 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: With the split of MIPI calibration into tegra_mipi_calibrate() and tegra_mipi_wait(), MIPI clock is not kept enabled till the calibration is done. So, this patch skips disabling MIPI clock after

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 3:30 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: + /* +* TRM has incorrectly documented to wait for done status from +* calibration logic after CSI interface power on. +* As per the design, calibration results are latched

[RFC PATCH v5 03/14] i2c: tegra: Fix the error path in tegra_i2c_runtime_resume

2020-07-27 Thread Sowjanya Komatineni
tegra_i2c_runtime_resume does not disable prior enabled clocks properly. This patch fixes it. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/i2c/busses/i2c-tegra.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses

[RFC PATCH v5 04/14] i2c: tegra: Fix runtime resume to re-init VI I2C

2020-07-27 Thread Sowjanya Komatineni
VI I2C is on host1x bus and is part of VE power domain. During suspend/resume VE power domain goes through power off/on. So, controller reset followed by i2c re-initialization is required after the domain power up. This patch fixes it. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya

[RFC PATCH v5 14/14] media: tegra-video: Compute settle times based on the clock rate

2020-07-27 Thread Sowjanya Komatineni
receiver will ignore any HS transitions on clock lane starting from the beginning of T-CLK-PREPARE. T-HS-SETTLE time is the interval during which recevier will ignore any HS transitions on data lane starting from the beginning of T-HS-PREPARE. Signed-off-by: Sowjanya Komatineni --- drivers/staging

[RFC PATCH v5 07/14] media: tegra-video: Enable TPG based on kernel config

2020-07-27 Thread Sowjanya Komatineni
Tegra internal TPG mode is only for Tegra vi and csi testing without a real sensor and driver should default support real sensor. So, This patch adds CONFIG_VIDEO_TEGRA_TPG and enables Tegra internal TPG mode only when this config is selected. Signed-off-by: Sowjanya Komatineni --- drivers

Re: [RFC PATCH v4 04/14] i2c: tegra: Fix runtime resume to re-init VI I2C

2020-07-27 Thread Sowjanya Komatineni
On 7/26/20 4:53 PM, Dmitry Osipenko wrote: 24.07.2020 02:51, Sowjanya Komatineni пишет: VI I2C is on host1x bus and is part of VE power domain. During suspend/resume VE power domain goes through power off/on. So, controller reset followed by i2c re-initialization is required after the

[RFC PATCH v5 10/14] media: tegra-video: Add support for external sensor capture

2020-07-27 Thread Sowjanya Komatineni
this driver supports V4L2 video node centric only. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/Kconfig| 1 + drivers/staging/media/tegra-video/TODO | 4 - drivers/staging/media/tegra-video/csi.c | 130 +- drivers/staging/media/tegra-video/csi.h

[RFC PATCH v5 11/14] media: tegra-video: Add support for selection ioctl ops

2020-07-27 Thread Sowjanya Komatineni
support, this patch also updates try format to use try crop rectangle either from subdev frame size enumeration or from subdev crop boundary. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 106 + 1 file changed, 106 insertions(+) diff

[RFC PATCH v5 08/14] media: tegra-video: Update format lookup to offset based

2020-07-27 Thread Sowjanya Komatineni
. Offset based look up is used with sensor device graph (non TPG) where format enumeration can list all supported formats for the specific sensor mbus codes. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[RFC PATCH v5 09/14] dt-bindings: tegra: Update VI and CSI bindings with port info

2020-07-27 Thread Sowjanya Komatineni
Update VI and CSI bindings to add port and endpoint nodes as per media video-interfaces DT binding document. Acked-by: Rob Herring Signed-off-by: Sowjanya Komatineni --- .../display/tegra/nvidia,tegra20-host1x.txt| 92 +- 1 file changed, 90 insertions(+), 2

[RFC PATCH v5 06/14] media: tegra-video: Fix channel format alignment

2020-07-27 Thread Sowjanya Komatineni
clamps width as per Tegra minimum and maximum limits. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video

[RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-27 Thread Sowjanya Komatineni
get invoked. So added new API tegra_mipi_cancel_calibration() which disables MIPI clock and consumer drivers can call this in such cases. Signed-off-by: Sowjanya Komatineni --- drivers/gpu/drm/tegra/dsi.c | 4 ++-- drivers/gpu/host1x/mipi.c | 19 ++- include/linux/host1x.h

[RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-27 Thread Sowjanya Komatineni
receiver is able to catch the very first clock transition. So, CSI receiver is always enabled prior to sensor streaming and trigger of calibration start is done during CSI subdev streaming and status of calibration is verified after sensor stream on. Signed-off-by: Sowjanya Komatineni --- drivers

[RFC PATCH v5 00/14] Support for Tegra video capture from external sensor

2020-07-27 Thread Sowjanya Komatineni
data-lanes endpoint property for csi. - Update tegra_mipi_request() to take device node pointer argument rather than adding extra API. - Remove checking for clk pointer before clk_disable. Sowjanya Komatineni (14): i2c: tegra: Don't mark VI I2C as IRQ safe runti

[RFC PATCH v5 02/14] i2c: tegra: Remove NULL pointer check before clk_enable/disable/prepare/unprepare

2020-07-27 Thread Sowjanya Komatineni
Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/i2c/busses/i2c-tegra.c | 64 +++--- 1 file changed, 23 insertions(+), 41 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 3be1018..c91307b9 100644 --- a

[RFC PATCH v5 01/14] i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM

2020-07-27 Thread Sowjanya Komatineni
driver marks all I2C devices as IRQ safe and VI I2C device does not require IRQ safe as it will not be used for atomic transfers. This patch has fix to make VI I2C as non-IRQ safe. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/i2c/busses/i2c-tegra.c | 10 +- 1

[RFC PATCH v5 05/14] i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c

2020-07-27 Thread Sowjanya Komatineni
VI I2C is on host1x bus so APB DMA can't be used for Tegra210 VI I2C and there are no tx and rx dma channels for VI I2C. So, avoid attempt of requesting DMA channels. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file chang

[RFC PATCH v4 01/14] i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM

2020-07-23 Thread Sowjanya Komatineni
driver marks all I2C devices as IRQ safe and VI I2C device does not require IRQ safe as it will not be used for atomic transfers. This patch has fix to make VI I2C as non-IRQ safe. Signed-off-by: Sowjanya Komatineni --- drivers/i2c/busses/i2c-tegra.c | 10 +- 1 file changed, 9 insertions

[RFC PATCH v4 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-23 Thread Sowjanya Komatineni
receiver is able to catch the very first clock transition. So, CSI receiver is always enabled prior to sensor streaming and trigger of calibration start is done during CSI subdev streaming and status of calibration is verified after sensor stream on. Signed-off-by: Sowjanya Komatineni --- drivers

[RFC PATCH v4 14/14] media: tegra-video: Compute settle times based on the clock rate

2020-07-23 Thread Sowjanya Komatineni
receiver will ignore any HS transitions on clock lane starting from the beginning of T-CLK-PREPARE. T-HS-SETTLE time is the interval during which recevier will ignore any HS transitions on data lane starting from the beginning of T-HS-PREPARE. Signed-off-by: Sowjanya Komatineni --- drivers/staging

[RFC PATCH v4 07/14] media: tegra-video: Enable TPG based on kernel config

2020-07-23 Thread Sowjanya Komatineni
Tegra internal TPG mode is only for Tegra vi and csi testing without a real sensor and driver should default support real sensor. So, This patch adds CONFIG_VIDEO_TEGRA_TPG and enables Tegra internal TPG mode only when this config is selected. Signed-off-by: Sowjanya Komatineni --- drivers

[RFC PATCH v4 06/14] media: tegra-video: Fix channel format alignment

2020-07-23 Thread Sowjanya Komatineni
clamps width as per Tegra minimum and maximum limits. Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/vi.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video

[RFC PATCH v4 04/14] i2c: tegra: Fix runtime resume to re-init VI I2C

2020-07-23 Thread Sowjanya Komatineni
VI I2C is on host1x bus and is part of VE power domain. During suspend/resume VE power domain goes through power off/on. So, controller reset followed by i2c re-initialization is required after the domain power up. This patch fixes it. Signed-off-by: Sowjanya Komatineni --- drivers/i2c

[RFC PATCH v4 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-23 Thread Sowjanya Komatineni
get invoked. So added new API tegra_mipi_cancel_calibrate() which disables MIPI clock and consumer drivers can call this in such cases. Signed-off-by: Sowjanya Komatineni --- drivers/gpu/drm/tegra/dsi.c | 4 ++-- drivers/gpu/host1x/mipi.c | 19 ++- include/linux/host1x.h

<    1   2   3   4   5   6   7   8   9   10   >