[PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-06-12 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-of

[PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-06-12 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-06-12 Thread Sreekanth Reddy
Product Name String Format bits to the BiosOptions field Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 17 ++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h b

[PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-12 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-06-12 Thread Sreekanth Reddy
DMA mapping of scatter gather list fails for a SCSI command. So that SML will retry this SCSI cmd after some time. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b

[PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-06-12 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy

[PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-06-12 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index b97039b..0ffe763 100644

[PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-06-12 Thread Sreekanth Reddy
-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 89 ++-- 1 file changed, 75 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 42bb731..5405a2f 100644 --- a/drivers/scsi

[PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-12 Thread Sreekanth Reddy
HBA 0x1000 0x97 0x1137 0x155 Cisco 12G Modular SAS Pass through Controller 0x1000 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 29 +++

[PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-12 Thread Sreekanth Reddy
firmware to discover the reinserted drive successfully instated of just retrying failed command for five times(doesn't giving enough time for firmware to complete the drive discovery) and failing the IO permanently even though drive came back successfully. Signed-off-by: Sreekanth Reddy ---

[PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-12 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 14

[PATCH 03/20] [SCSI] mpt3sas: Don't block the drive when drive addition under the control of SML

2015-06-12 Thread Sreekanth Reddy
(such as Inquiry, Report LUNs etc). Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 +++- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 +++ drivers/scsi/mpt3sas/mpt3sas_transport.c | 18 ++ 3 files changed, 28 insertions(+), 1 deletion(-) diff

[PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-12 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding String 0x10000x0097 0x1028 0x1F46 DELL 12Gbps HBA Signed-off-by: Sr

[PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-06-12 Thread Sreekanth Reddy
image to HashImageType. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 6 -- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 27 +-- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 4 +++- 3 files changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-06-12 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 293ad23..9396a76 100644

[PATCH 00/20] mpt3sas: driver update

2015-06-12 Thread Sreekanth Reddy
This patch set contains all the features and defect fixes from Phase4 to Phase8. Please review this patch set and consider these patches for next kernel release. Sreekanth Reddy (20): [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support [SCSI] mpt3sas

[PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-12 Thread Sreekanth Reddy
processing the reply post descriptor. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 70 + drivers/scsi/mpt3sas/mpt3sas_base.h | 7 +++- 2 files changed, 69 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-12 Thread Sreekanth Reddy
would be issued. 3.If IOC is in reset state then driver will wait for 10 seconds to exit out of reset state. If the HBA continues to be in reset state, then the HBA wouldn't be claimed by the driver. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas

[PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-12 Thread Sreekanth Reddy
processing the reply post descriptor. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 70 + drivers/scsi/mpt3sas/mpt3sas_base.h | 7 +++- 2 files changed, 69 insertions(+), 8 deletions(-) diff --git

[PATCH 00/20] mpt3sas: driver update

2015-06-12 Thread Sreekanth Reddy
This patch set contains all the features and defect fixes from Phase4 to Phase8. Please review this patch set and consider these patches for next kernel release. Sreekanth Reddy (20): [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support [SCSI] mpt3sas

[PATCH 03/20] [SCSI] mpt3sas: Don't block the drive when drive addition under the control of SML

2015-06-12 Thread Sreekanth Reddy
(such as Inquiry, Report LUNs etc). Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 +++- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 +++ drivers/scsi/mpt3sas/mpt3sas_transport.c | 18 ++ 3 files changed, 28

[PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-12 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi

[PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-12 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. VendorID DeviceID SubsystemVendor ID SubsystemDevice ID Dell Branding String 0x10000x0097 0x1028 0x1F46DELL 12Gbps HBA Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com

[PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-06-12 Thread Sreekanth Reddy
image to HashImageType. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 6 -- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 27 +-- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 4 +++- 3 files changed, 28 insertions(+), 9

[PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-06-12 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-06-12 Thread Sreekanth Reddy
Product Name String Format bits to the BiosOptions field Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 17 ++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git

[PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-12 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++- 1 file

[PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-06-12 Thread Sreekanth Reddy
DMA mapping of scatter gather list fails for a SCSI command. So that SML will retry this SCSI cmd after some time. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-06-12 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy

[PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-06-12 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index

[PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-12 Thread Sreekanth Reddy
Cisco 12G Modular SAS Pass through Controller 0x1000 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 29

[PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-12 Thread Sreekanth Reddy
the reinserted drive successfully instated of just retrying failed command for five times(doesn't giving enough time for firmware to complete the drive discovery) and failing the IO permanently even though drive came back successfully. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers

[PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-06-12 Thread Sreekanth Reddy
-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 89 ++-- 1 file changed, 75 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 42bb731

[PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-12 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 + 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/scsi

[PATCH 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-12 Thread Sreekanth Reddy
. This information can be used by the user to identify the location of the desired drive in the topology. Driver will get these information by reading the sas device page0. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 + drivers/scsi

[PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-06-12 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-06-12 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. VendorID DeviceID SubsystemVendor ID SubsystemDevice ID Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-off-by: Sreekanth Reddy sreekanth.re

[PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-06-12 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-12 Thread Sreekanth Reddy
On Fri, Jun 12, 2015 at 4:58 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Fri, Jun 12, 2015 at 03:12:16PM +0530, Sreekanth Reddy wrote: Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi

Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-12 Thread Sreekanth Reddy
Thanks Johannes, we will take care of this point in our current on-development mpt2sas/mpt3sas merging activity. Thanks, Sreekanth On Fri, Jun 12, 2015 at 4:39 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Fri, Jun 12, 2015 at 03:12:13PM +0530, Sreekanth Reddy wrote: In this patch

Re: [PATCH v3] fusion: remove dead MTRR code

2015-06-05 Thread Sreekanth Reddy
On Thu, Jun 4, 2015 at 11:11 PM, Luis R. Rodriguez wrote: > On Thu, Jun 04, 2015 at 10:20:23AM +0530, Sreekanth Reddy wrote: >> Hi Luis, >> >> Sorry for delay in response. Actually I was looking for the history of >> this section of code but I couldn't find it. Anyway

Re: [PATCH v3] fusion: remove dead MTRR code

2015-06-05 Thread Sreekanth Reddy
On Thu, Jun 4, 2015 at 11:11 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Thu, Jun 04, 2015 at 10:20:23AM +0530, Sreekanth Reddy wrote: Hi Luis, Sorry for delay in response. Actually I was looking for the history of this section of code but I couldn't find it. Anyway this is dead code

Re: [PATCH v3] fusion: remove dead MTRR code

2015-06-03 Thread Sreekanth Reddy
Hi Luis, Sorry for delay in response. Actually I was looking for the history of this section of code but I couldn't find it. Anyway this is dead code and we are fine with removing this dead code. James, Please consider this patch as Acked-by: "Sreekanth Reddy" Regards, Sreekanth O

Re: [PATCH v3] fusion: remove dead MTRR code

2015-06-03 Thread Sreekanth Reddy
Hi Luis, Sorry for delay in response. Actually I was looking for the history of this section of code but I couldn't find it. Anyway this is dead code and we are fine with removing this dead code. James, Please consider this patch as Acked-by: Sreekanth Reddy sreekanth.re...@avagotech.com

[PATCH v2] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-12 Thread Sreekanth Reddy
thread to complete it's work of registering the sas device's saved in the sas_device_init_list list with the SML before it free's the removal device's data (if the device's data is alread freed then this thread will simple exit from this function). Signed-off-by: Sreekanth Reddy --- drivers/scsi

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-12 Thread Sreekanth Reddy
; On 05/04/2015 05:05 PM, Sreekanth Reddy wrote: > > I have applied this patch on the latest upstream mpt3sas driver, then I > > have compiled and loaded the driver. > > In the driver logs I didn't see any attached drives are added to the OS, > > 'fdisk -l' command also

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-12 Thread Sreekanth Reddy
wrote: On 05/04/2015 05:05 PM, Sreekanth Reddy wrote: I have applied this patch on the latest upstream mpt3sas driver, then I have compiled and loaded the driver. In the driver logs I didn't see any attached drives are added to the OS, 'fdisk -l' command also doesn't list the drives

[PATCH v2] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-12 Thread Sreekanth Reddy
thread to complete it's work of registering the sas device's saved in the sas_device_init_list list with the SML before it free's the removal device's data (if the device's data is alread freed then this thread will simple exit from this function). Signed-off-by: Sreekanth Reddy sreekanth.re

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-04 Thread Sreekanth Reddy
iver won't find this device in the sas_device_list or in a sas_device_init_list and so driver will ignore this device removal event. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.h | 2 ++ drivers/scsi/mpt2sas/mpt2sas_scsih.c | 45 +++- dri

Re: [PATCH] mpt2sas: mpt3sas: Fix memory corruption during initialization

2015-05-04 Thread Sreekanth Reddy
won't find this device in the sas_device_list or in a sas_device_init_list and so driver will ignore this device removal event. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt2sas/mpt2sas_base.h | 2 ++ drivers/scsi/mpt2sas/mpt2sas_scsih.c | 45

Re: [PATCH 00/20] mpt3sas: driver update

2015-04-07 Thread Sreekanth Reddy
Hi Chris, There are no corresponding mpt2sas driver's patches, The last phase for mpt2sas drivers is Phase20 and this phase driver is already exits in the upstream kernel. Also mpt2sas driver is completely in maintains mode and there won't be any new features. Whereas mpt3sas is at its initial

Re: [PATCH 00/20] mpt3sas: driver update

2015-04-07 Thread Sreekanth Reddy
Hi Chris, There are no corresponding mpt2sas driver's patches, The last phase for mpt2sas drivers is Phase20 and this phase driver is already exits in the upstream kernel. Also mpt2sas driver is completely in maintains mode and there won't be any new features. Whereas mpt3sas is at its initial

[PATCH 03/20] [SCSI] mpt3sas: Added module parameter 'unblock_io' to unblock IO's during disk addition

2015-03-30 Thread Sreekanth Reddy
if the driver receives RC_PHY_CHANGED reason code when the device addition is within the SAS Transport layer. An module parameter 'unblock_io' is introduced which needs to be set to have this functionality enabled. By default this functionality is disabled. Signed-off-by: Sreekanth Reddy

[PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-03-30 Thread Sreekanth Reddy
image to HashImageType. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 6 -- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 27 +-- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 4 +++- 3 files changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index a182d26..29ecfd1 100644

[PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-03-30 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding String 0x10000x0097 0x1028 0x1F46 DELL 12Gbps HBA Signed-off-by: Sr

[PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-03-30 Thread Sreekanth Reddy
ime for the firmware to discover the reinserted drive successfully instated of just retrying failed command for five times( doesn't giving enough time for firmware to complete the drive discovery) and failing the IO permanently even though drive came back successfully. Signed-off-by: Sreekanth Reddy ---

[PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 8f99024..402c2ee 100644

[PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-03-30 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy

[PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-03-30 Thread Sreekanth Reddy
HBA 0x1000 0x97 0x1137 0x155 Cisco 12G Modular SAS Pass through Controller 0x1000 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 29 +++

[PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-03-30 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-of

[PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-03-30 Thread Sreekanth Reddy
Product Name String Format bits to the BiosOptions field Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 17 ++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h b

[PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-03-30 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-03-30 Thread Sreekanth Reddy
), when DMA mapping of scatter gather list fails for a SCSI command. So that SML will retry this SCSI cmd after some time. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 1fd1e7f..706f0a5 100644

[PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-03-30 Thread Sreekanth Reddy
. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 96 +--- 1 file changed, 78 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 0070f78..8e324bc 100644 --- a/drivers

[PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-03-30 Thread Sreekanth Reddy
processing the reply post descriptor. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 70 + drivers/scsi/mpt3sas/mpt3sas_base.h | 7 +++- 2 files changed, 69 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-03-30 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 + 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers

[PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-03-30 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 14

[PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-03-30 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-03-30 Thread Sreekanth Reddy
would be issued. 3.If IOC is in reset state then driver will wait for 10 seconds to exit out of reset state. If the HBA continues to be in reset state, then the HBA wouldn't be claimed by the driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 65

[PATCH 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-03-30 Thread Sreekanth Reddy
vice. This information can be used by the user to identify the location of the desired drive in the topology. Driver will get these information by reading the sas device page0. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 + drivers/scsi/mpt3sas/mpt3sas_scsih.c |

[PATCH 00/20] mpt3sas: driver update

2015-03-30 Thread Sreekanth Reddy
tead of posting large set of patches at once. Regards, Sreekanth Sreekanth Reddy (20): [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operati

[PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-03-30 Thread Sreekanth Reddy
Created a thread using alloc_ordered_workqueue() API in order to process the works from firmware Work-queue sequentially instead of create_singlethread_workqueue() API. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++- 1 file

[PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to 9.100.00.00 Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index

[PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-03-30 Thread Sreekanth Reddy
Product Name String Format bits to the BiosOptions field Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 17 ++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git

[PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-03-30 Thread Sreekanth Reddy
), when DMA mapping of scatter gather list fails for a SCSI command. So that SML will retry this SCSI cmd after some time. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-03-30 Thread Sreekanth Reddy
Added dma_mapping_error() API after mapping an address with dma_map_single() API. Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains about mpt3sas driver not calling dma_mapping_error after mapping an address with dma_map_single Signed-off-by: Sreekanth Reddy

[PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-03-30 Thread Sreekanth Reddy
Cisco 12G Modular SAS Pass through Controller 0x1000 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 29

[PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-03-30 Thread Sreekanth Reddy
. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 96 +--- 1 file changed, 78 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 0070f78

[PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-03-30 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. VendorID DeviceID SubsystemVendor ID SubsystemDevice ID Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Signed-off-by: Sreekanth Reddy sreekanth.re

[PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-03-30 Thread Sreekanth Reddy
image to HashImageType. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 6 -- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 27 +-- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 4 +++- 3 files changed, 28 insertions(+), 9

[PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas Driver version to v5.100.00.00 Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-03-30 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. VendorID DeviceID SubsystemVendor ID SubsystemDevice ID Dell Branding String 0x10000x0097 0x1028 0x1F46DELL 12Gbps HBA Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com

[PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-03-30 Thread Sreekanth Reddy
the reinserted drive successfully instated of just retrying failed command for five times( doesn't giving enough time for firmware to complete the drive discovery) and failing the IO permanently even though drive came back successfully. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com

[PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-03-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[PATCH 03/20] [SCSI] mpt3sas: Added module parameter 'unblock_io' to unblock IO's during disk addition

2015-03-30 Thread Sreekanth Reddy
if the driver receives RC_PHY_CHANGED reason code when the device addition is within the SAS Transport layer. An module parameter 'unblock_io' is introduced which needs to be set to have this functionality enabled. By default this functionality is disabled. Signed-off-by: Sreekanth Reddy

[PATCH 00/20] mpt3sas: driver update

2015-03-30 Thread Sreekanth Reddy
of posting large set of patches at once. Regards, Sreekanth Sreekanth Reddy (20): [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state

[PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-03-30 Thread Sreekanth Reddy
Update MPI2 strings to MPI2.5. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers

[PATCH 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-03-30 Thread Sreekanth Reddy
would be issued. 3.If IOC is in reset state then driver will wait for 10 seconds to exit out of reset state. If the HBA continues to be in reset state, then the HBA wouldn't be claimed by the driver. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas

[PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-03-30 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpi/mpi2.h | 5 +++-- drivers/scsi

[PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-03-30 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 + 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/scsi

[PATCH 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-03-30 Thread Sreekanth Reddy
. This information can be used by the user to identify the location of the desired drive in the topology. Driver will get these information by reading the sas device page0. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 + drivers/scsi

[PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-03-30 Thread Sreekanth Reddy
processing the reply post descriptor. Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi/mpt3sas/mpt3sas_base.c | 70 + drivers/scsi/mpt3sas/mpt3sas_base.h | 7 +++- 2 files changed, 69 insertions(+), 8 deletions(-) diff --git

[PATCH] [SCSI] mpt2sas, mpt3sas: fix sparse warings restricted __le16 degrades to integer

2015-01-12 Thread Sreekanth Reddy
Fixed sparse warings 'restricted __le16 degrades to integer' generated from below titled patch [PATCH v2 02/22] [SCSI] mpt2sas, mpt3sas: Added support to log message when Temperature Threshold exceeds for any Sensor Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_scsih.c | 12

[PATCH] [SCSI] mpt2sas, mpt3sas: fix sparse warings restricted __le16 degrades to integer

2015-01-12 Thread Sreekanth Reddy
Fixed sparse warings 'restricted __le16 degrades to integer' generated from below titled patch [PATCH v2 02/22] [SCSI] mpt2sas, mpt3sas: Added support to log message when Temperature Threshold exceeds for any Sensor Signed-off-by: Sreekanth Reddy sreekanth.re...@avagotech.com --- drivers/scsi

[PATCH v2 03/22] [SCSI] mpt2sas, mpt3sas: Fail the host reset initiated due to discovery related I/O timeouts at driver load time

2015-01-11 Thread Sreekanth Reddy
set for discovery related I/O timeout. Instead it would return Failure for the host reset resulting in the flaky disk getting removed by the SCSI Mid layer, so other disks would be added correctly. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen --- drivers/scsi/mpt2sas/mpt2sas_scsih.c

[PATCH v2 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2015-01-11 Thread Sreekanth Reddy
in cpumask argument. 4. then call the free_cpumask_var API to free the memory allocated in step 2. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen --- drivers/scsi/mpt2sas/mpt2sas_base.c | 24 +--- drivers/scsi/mpt2sas/mpt2sas_base.h | 1 + drivers/scsi/mpt3sas

[PATCH v2 05/22] [SCSI] mpt2sas: MPI2 Rev BB (2.00.20) specification and 2.00.35 header files

2015-01-11 Thread Sreekanth Reddy
Change List in this MPI2 specification, 1. Added SSUTimeout field to MPI2_CONFIG_PAGE_BIOS_1, and more defines for the BiosOptions field. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen --- drivers/scsi/mpt2sas/mpi/mpi2.h | 5 +++-- drivers/scsi/mpt2sas/mpi/mpi2_cnfg.h

[PATCH v2 04/22] [SCSI] mpt2sas: Bump driver version to 19.100.00.00

2015-01-11 Thread Sreekanth Reddy
Bump driver version to 19.100.00.00. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen --- drivers/scsi/mpt2sas/mpt2sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h index

<    1   2   3   4   5   6   >