Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Srinivas Eeda
On 11/24/2015 01:46 PM, Mark Fasheh wrote: On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: Hi Gang, On 11/03/2015 03:54 PM, Gang He wrote: Hi Junxiao, Thank for your reviewing. Current design, we use a sysfile as a interface to check/fix a file (via pass a ino number). But, this

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Srinivas Eeda
On 11/24/2015 01:46 PM, Mark Fasheh wrote: On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: Hi Gang, On 11/03/2015 03:54 PM, Gang He wrote: Hi Junxiao, Thank for your reviewing. Current design, we use a sysfile as a interface to check/fix a file (via pass a ino number). But, this

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Srinivas Eeda
Hi Gang, thanks for pointing to explanation of the feature. What I am curious about is ... what were the real cases that you came across prompted this change and how this change would help in that case. Thanks, --Srini On 10/28/2015 09:44 PM, Gang He wrote: Hello Srini, There is a doc

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Srinivas Eeda
Hi Gang, thanks for pointing to explanation of the feature. What I am curious about is ... what were the real cases that you came across prompted this change and how this change would help in that case. Thanks, --Srini On 10/28/2015 09:44 PM, Gang He wrote: Hello Srini, There is a doc

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Srinivas Eeda
Hi Gang, thank you for implementing this. I would like to understand this better on where and how it helps ... would you mind sharing couple examples(real scenarios). Thanks, --Srini On 10/27/2015 11:25 PM, Gang He wrote: When there are errors in the ocfs2 filesystem, they are usually

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Srinivas Eeda
Hi Gang, thank you for implementing this. I would like to understand this better on where and how it helps ... would you mind sharing couple examples(real scenarios). Thanks, --Srini On 10/27/2015 11:25 PM, Gang He wrote: When there are errors in the ocfs2 filesystem, they are usually

Re: fuse scalability part 1

2015-09-29 Thread Srinivas Eeda
Hi Miklos, On 09/25/2015 05:11 AM, Miklos Szeredi wrote: On Thu, Sep 24, 2015 at 9:17 PM, Ashish Samant wrote: We did some performance testing without these patches and with these patches (with -o clone_fd option specified). We did 2 types of tests: 1. Throughput test : We did some

Re: fuse scalability part 1

2015-09-29 Thread Srinivas Eeda
Hi Miklos, On 09/25/2015 05:11 AM, Miklos Szeredi wrote: On Thu, Sep 24, 2015 at 9:17 PM, Ashish Samant wrote: We did some performance testing without these patches and with these patches (with -o clone_fd option specified). We did 2 types of tests: 1. Throughput

Re: [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables

2014-06-02 Thread Srinivas Eeda
Acked-by: Srinivas Eeda On 06/01/2014 06:53 AM, Rickard Strandqvist wrote: There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- fs/ocfs2/dir.c |2

Re: [PATCH] fs: ocfs2: dir.c: Cleaning up uninitialized variables

2014-06-02 Thread Srinivas Eeda
Acked-by: Srinivas Eeda srinivas.e...@oracle.com On 06/01/2014 06:53 AM, Rickard Strandqvist wrote: There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [Ocfs2-users] [OCFS2] Crash at o2net_shutdown_sc()

2013-03-01 Thread Srinivas Eeda
Yes that was the crash I was referring to which stopped me from testing my other patch on mainline. I think the crashes started since some workqueue patches introduced by commit 57b30ae77bf00d2318df711ef9a4d2a9be0a3a2a Earlier kernels should be fine. Patch

Re: [Ocfs2-users] [OCFS2] Crash at o2net_shutdown_sc()

2013-03-01 Thread Srinivas Eeda
Yes that was the crash I was referring to which stopped me from testing my other patch on mainline. I think the crashes started since some workqueue patches introduced by commit 57b30ae77bf00d2318df711ef9a4d2a9be0a3a2a Earlier kernels should be fine. Patch

Re: [Ocfs2-users] Kernel panic due to ocfs2

2013-02-27 Thread Srinivas Eeda
On 02/27/2013 03:52 AM, richard -rw- weinberger wrote: On Tue, Feb 26, 2013 at 8:54 AM, richard -rw- weinberger wrote: On Tue, Feb 26, 2013 at 7:31 AM, Srinivas Eeda wrote: This is due to a race in lock mastery/purge. I have recently fixed this problem but haven't yet submitted the patch

Re: [Ocfs2-users] Kernel panic due to ocfs2

2013-02-27 Thread Srinivas Eeda
On 02/27/2013 03:52 AM, richard -rw- weinberger wrote: On Tue, Feb 26, 2013 at 8:54 AM, richard -rw- weinberger richard.weinber...@gmail.com wrote: On Tue, Feb 26, 2013 at 7:31 AM, Srinivas Eeda srinivas.e...@oracle.com wrote: This is due to a race in lock mastery/purge. I have recently fixed