On 28/10/2020 18:24, Rob Herring wrote:
On Wed, Oct 28, 2020 at 10:19 AM Srinivas Kandagatla
wrote:
On 28/10/2020 15:01, Rob Herring wrote:
+- const: qcom,sm8250
This collides with the top level SoC compatible resulting in:
I did run dt_binding_check before sending out this
digital gain range is -84dB min to 40dB max, however this was not
correctly specified in the range.
Fix this by with correct range!
Fixes: 1cde8b822332 ("ASoC: wcd934x: add basic controls")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd934x.c | 2 +-
1 file changed, 1
Author: Srinivas Kandagatla
Date: Mon Oct 26 17:09:47 2020 +
ASoC: qcom: sm8250: add sound card qrb5165-rb5 support
pport")
Reported-by: Colin Ian King
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/sm8250.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c
index 7d43de6d909f..52c40512102f 100644
--- a/sound/soc/qcom/sm8250.c
+
digital gain range is -84dB min to 40dB max, however this was not
correctly specified in the range.
Fix this by with correct range!
Fixes: 8c4f021d806a ("ASoC: wcd9335: add basic controls")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd9335.c | 2 +-
1 file changed, 1
On 28/10/2020 15:01, Rob Herring wrote:
On Mon, Oct 26, 2020 at 05:09:46PM +, Srinivas Kandagatla wrote:
This patch adds bindings required for SM8250 based soundcards
for example Qualcomm Robotics RB5 Development Kit which makes
use of ADSP and Internal LPASS codec.
You didn't se
make use of devm_of_platform_populate to remove some redundant code!
Signed-off-by: Srinivas Kandagatla
---
Changes since v1: rebased on top of sound-next
sound/soc/qcom/qdsp6/q6adm.c | 10 +-
sound/soc/qcom/qdsp6/q6afe.c | 10 +-
sound/soc/qcom/qdsp6/q6asm.c | 10 +-
3
Thanks Pierre for review on all the patches.
On 26/10/2020 19:58, Pierre-Louis Bossart wrote:
Run cppcheck on this sort of code:
cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive
--enable=all --suppress=variableScope sound/soc/codecs/lpass-wsa-macro.c
I normally do sparse c
Looks good to me,
Reviewed-by: Srinivas Kandagatla
---
Changes from v11 to v12
- Machine driver:
- Use the definitaion of index LPASS_DP_RX in sc7180-lpass.h.
- Fix compatible string.
- Replace a comma with semicolon.
sound/soc/qcom/Kconfig | 12 ++
sound/soc/qcom/Makefile | 2
Thanks for doing this!
On 27/10/2020 03:22, Cheng-Yi Chiang wrote:
Add devicetree bindings documentation file for sc7180 sound card.
Signed-off-by: Cheng-Yi Chiang
Looks good to me!
Reviewed-by: Srinivas Kandagatla
---
Changes from v11 to v12
- Documentation:
- Change the file and
Add support to Qualcomm Robotics RB5 Development Kit based on
QRB5165 Robotics SoC. This board has 2 WSA881X smart speakers
with onboard DMIC connected to internal LPASS codec via WSA
and VA macros respectively.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/Kconfig | 11 ++
sound/soc
This patchset adds support to Qualcomm Robotics RB5 Development Kit based on
QRB5165 Robotics SoC. This board has 2 WSA881X smart speakers with onboard
DMIC connected to internal LPASS codec via WSA and VA macros respectively.
Srinivas Kandagatla (2):
ASoC: qcom: dt-bindings: Add SM8250
This patch adds bindings required for SM8250 based soundcards
for example Qualcomm Robotics RB5 Development Kit which makes
use of ADSP and Internal LPASS codec.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,sm8250.yaml | 161 ++
1 file changed, 161
On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Update SC7180 lpass_variant structure with proper I2S bitwidth
field bit positions, as bitwidth denotes 0 to 1 bits,
but previously used only 0 bit.
Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add su
On 23/10/2020 17:33, Mauro Carvalho Chehab wrote:
Fix the name of the enum on its kernel-doc markup:
enum slim_ch_aux_fmt -> enum slim_ch_aux_bit_fmt
Signed-off-by: Mauro Carvalho Chehab
---
drivers/slimbus/slimbus.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Add dapm widgets and routes for this codec.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-va-macro.c | 618 ++
1 file changed, 618 insertions(+)
diff --git a/sound/soc/codecs/lpass-va-macro.c
b/sound/soc/codecs/lpass-va-macro.c
index 6f1565cf0d01
This patch adds dapm widgets and routes on this codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-wsa-macro.c | 1014
1 file changed, 1014 insertions(+)
diff --git a/sound/soc/codecs/lpass-wsa-macro.c
b/sound/soc/codecs/lpass-wsa-macro.c
index
;clk: qcom : add sm8250 LPASS GFM
drivers"
patches posted at
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2352255.html
Thanks,
srini
Srinivas Kandagatla (6):
ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec
ASoC: codecs: lpass-wsa-macro: Add support to W
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
WSA macro block which is used for connecting with WSA Smart
speakers over soundwire.
This patch adds support to the codec part of the WSA Macro block.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |4
This binding is for LPASS has internal codec VA macro which is
for connecting with DMICs.
Signed-off-by: Srinivas Kandagatla
---
bindings depend on gfm headers from "clk: qcom : add sm8250 LPASS GFM drivers"
patches posted at
https://www.mail-archive.com/linux-kernel@vger.kernel.org/
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec
VA macro block which is used for connecting with DMICs.
This patch adds support to the codec part of the VA Macro block
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig | 4 +
sound/soc/codecs/Makefile
This binding is for LPASS has internal codec WSA macro which is
for connecting with WSA Smart speakers.
Signed-off-by: Srinivas Kandagatla
---
bindings depend on gfm headers from "clk: qcom : add sm8250 LPASS GFM drivers"
patches posted at
https://www.mail-archive.com/li
Always ON Clock controller is a block inside LPASS which controls
1 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,aoncc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-aoncc.h | 11
2 files changed
Audio Clock controller is a block inside LPASS which controls
2 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,audiocc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-audiocc.h | 13 +
2 files changed, 71
GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros.
This patch adds support to these muxes.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/Kconfig| 6 +
drivers/clk/qcom/Makefile | 1 +
drivers/clk/qcom/lpass-gfm-sm8250.c | 257
fw_name instead of name for parents
- use devm_platform_ioremap_resource
verified dt_binding_check to pass on rc1,
Srinivas Kandagatla (4):
dt-bindings: clock: Add support for LPASS Audio Clock Controller
dt-bindings: clock: Add support for LPASS Always ON Controller
clk: qcom: Add support to
LPASS Always ON Clock controller has one GFM mux to control VA
and TX clocks to codec macro on LPASS.
This patch adds support to this mux.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/lpass-gfm-sm8250.c | 63 +
1 file changed, 63 insertions(+)
diff --git
variants. This should scale much better!
Signed-off-by: Srinivas Kandagatla
---
I will post the ucm changes once this patch is merged!
sound/soc/qcom/sdm845.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index ab1bf23c21a6..6c2760e27ea6
Add missing supported rates and formats for the stream, without
which attempt to do playback will fail to find any matching rates/format.
Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wsa881x.c | 2 ++
1 fi
make use of devm_of_platform_populate to remove some redundant code!
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6adm.c | 10 +-
sound/soc/qcom/qdsp6/q6afe.c | 10 +-
sound/soc/qcom/qdsp6/q6asm.c | 9 +
3 files changed, 3 insertions(+), 26 deletions
On 22/10/2020 04:29, Tzung-Bi Shih wrote:
Hi, sorry for jumping into your discussion but I am trying to
summarize them to make sure we are on the same page. Pardon me to
manually copy-and-paste partial sentences to quote.
ACK:
- Don't expose DAI connections in compatible strings.
- Use "mode
On 20/10/2020 19:54, Cheng-yi Chiang wrote:
Not with the compatible string!
Currently card name, and long name are exactly same in all Qualcomm
soundcards, which makes it very difficult to identify how those boards
re wired up at UCM2 level. So the plan is to properly populate card long
name
On 20/10/2020 15:37, Mark Brown wrote:
I don't understand what "logic scattered in various dtsi files" means,
sorry.
Yes, that should work to describe the dailink we are using.
But a more tricky issue is how to do calls like setting PLL in dai startup ops.
...
I think that asking a generi
On 19/10/2020 23:42, Stephen Boyd wrote:
Quoting Srinivas Kandagatla (2020-10-16 07:12:37)
This patchset adds support for GFM Muxes found in LPASS
(Low Power Audio SubSystem) IP in Audio Clock Controller
and Always ON clock controller.
Clocks derived from these muxes are consumed by LPASS
GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros.
This patch adds support to these muxes.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/Kconfig| 6 +
drivers/clk/qcom/Makefile | 1 +
drivers/clk/qcom/lpass-gfm-sm8250.c | 257
on linux master,
Srinivas Kandagatla (4):
dt-bindings: clock: Add support for LPASS Audio Clock Controller
dt-bindings: clock: Add support for LPASS Always ON Controller
clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux clocks
clk: qcom: Add support to LPASS AON_CC Glitch Free Mux
LPASS Always ON Clock controller has one GFM mux to control VA
and TX clocks to codec macro on LPASS.
This patch adds support to this mux.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/lpass-gfm-sm8250.c | 63 +
1 file changed, 63 insertions(+)
diff --git
Always ON Clock controller is a block inside LPASS which controls
1 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,aoncc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-aoncc.h | 11
2 files changed
Audio Clock controller is a block inside LPASS which controls
2 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,audiocc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-audiocc.h | 13 +
2 files changed, 71
thanks Stephen,
On 14/10/2020 02:45, Stephen Boyd wrote:
Changes since v1:
-removed unnecessary Kconfig dependencies
- cleaned up header includes.
- moved to using pm_clk
- Moved to right place in Makefile
- moved to use module_platform_driver instead of builtin_platform_driver
- add
Hi Cheng,
Sorry for such late review w.r.t compatibles,
On 14/09/2020 09:06, Cheng-Yi Chiang wrote:
+---
+$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
+$schema:http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver
+
+mainta
c
create mode 100644 sound/soc/qcom/lpass-hdmi.h
Tested this series on DragonBoard 410c
Tested-by: Srinivas Kandagatla
Reviewed-by: Srinivas Kandagatla
/lpass-hdmi.c
create mode 100644 sound/soc/qcom/lpass-hdmi.h
Reviewed-by: Srinivas Kandagatla
On 05/10/2020 05:48, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/Kconfig | 5
d here.
Documentation/devicetree/bindings/nvmem/nvmem.yaml | 2 ++
.../devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++
for nvmem parts,
Acked-by: Srinivas Kandagatla
thanks,
--srini
Herring
Documentation/devicetree/bindings/nvmem/nvmem-consumer.yaml | 2 ++
Documentation/devicetree/bindings/nvmem/nvmem.yaml | 2 ++
for nvmem parts,
Acked-by: Srinivas Kandagatla
thanks,
srini
On 03/10/2020 00:14, Evan Green wrote:
You don't want either/or. You want both. At the time Srinivas didn't
see the point of having the SoC-specific compatible string here, but
now that we have a reason for it maybe he'll be convinced? IMO you
essentially want:
items:
- enum:
On 01/10/2020 22:49, Evan Green wrote:
Oh no, I realized this isn't nearly as beautiful when I try to move it
into the core. The low level read/write interface between the nvmem
core and the driver is a range. So to move this into the core I'd have
to implement all the overlap computation logi
!UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y]
&& QCOM_APR [=y] && I2C [=y] && SOUNDWIRE [=y]
Fixes: 520a1c396d19 ("ASoC: q6afe-clocks: add q6afe clock controller")
Signed-off-by: Randy Dunlap
Cc: Srinivas Kandagatla
Cc: Mark Brown
Cc
On 01/10/2020 17:27, Evan Green wrote:
On Thu, Oct 1, 2020 at 7:17 AM Srinivas Kandagatla
wrote:
Hi Evan,
On 29/09/2020 21:58, Evan Green wrote:
Some fuse ranges are protected by the XPU such that the AP cannot
access them. Attempting to do so causes an SError. Use the newly
introduced
Hi Evan,
On 29/09/2020 21:58, Evan Green wrote:
Some fuse ranges are protected by the XPU such that the AP cannot
access them. Attempting to do so causes an SError. Use the newly
introduced per-soc compatible string to attach the set of regions
we should not access. Then tiptoe around those regi
On 30/09/2020 07:39, Srinivasa Rao Mandadapu wrote:
+}
+
+static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned int reg)
+{
+ return true;
+}
I did ask this question in multiple reviews, but never got an answer!
Are all the dp/hdmi port register range really volatile!?
On 28/09/2020 10:53, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Thanks for doing the rework this patch looks much better now!
However I have few comments below!
Signed
: Srinivasa Rao
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-cpu.c | 2 +-
sound/soc/qcom/lpass-platform.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 0718a0f..12950d2 100644
--- a/sound
more readable.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-platform.c | 8
sound/soc/qcom/lpass.h | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc
Looks like there was a major typo in SPDX Licence version,
Not sure how it was missed.
This patch is to fix it.
Reported-by: Lukas Bulwahn
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6afe-clocks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc
Thanks Lukas for spotting this,
On 26/09/2020 18:01, Lukas Bulwahn wrote:
At the end of the file, you further state it licensed with GPL-2.0 with
the following line:
MODULE_LICENSE("GPL v2");
So, is this just a typo in the SPDX-License-Identifier or do you really
intend to license this file
use new devm_regmap_field_bulk_alloc to allocate fields as
it make the code more readable!
Signed-off-by: Srinivas Kandagatla
Tested-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 31 +++
1 file changed, 7 insertions(+), 24 deletions(-)
diff
this new api and a user of it.
Using new bulk api to allocate fields makes it much more cleaner code to read!
Changes since v1:
- Fix lot of spelling! No code changes!
Srinivas Kandagatla (2):
regmap: add support to regmap_field_bulk_alloc/free apis
ASoC: lpass-platform: use
Usage of regmap_field_alloc becomes much overhead when number of fields
exceed more than 3.
QCOM LPASS driver has extensively converted to use regmap_fields.
Using new bulk api to allocate fields makes it much more cleaner code to read!
Signed-off-by: Srinivas Kandagatla
Tested-by: Srinivasa
ernel test robot
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6adm.c| 2 ++
sound/soc/qcom/qdsp6/q6afe-clocks.c | 2 ++
sound/soc/qcom/qdsp6/q6afe-dai.c| 2 ++
sound/soc/qcom/qdsp6/q6afe.c| 2 ++
sound/soc/qcom/qdsp6/q6asm-dai.c| 2 ++
sound/soc/qcom/qds
er
'is_gapless' not described in 'q6asm_open_write'
sound/soc/qcom/qdsp6/q6asm.c:1053: warning: Function parameter or member
'stream_id' not described in 'q6asm_run'
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm.c | 3 +++
1 file changed,
removing of_match_ptr
Srinivas Kandagatla (2):
ASoC: qdsp6: add ifdef CONFIG_OF around of_device_id
ASoC: q6asm: fix kernel doc warnings
sound/soc/qcom/qdsp6/q6adm.c| 2 ++
sound/soc/qcom/qdsp6/q6afe-clocks.c | 2 ++
sound/soc/qcom/qdsp6/q6afe-dai.c| 2 ++
sound/soc/qcom/qdsp6
On 25/09/2020 17:17, Mark Brown wrote:
On Fri, Sep 25, 2020 at 09:49:24AM +0100, Srinivas Kandagatla wrote:
The of_device_id is included unconditionally by of.h header and used
in the driver as well. Remove of_match_ptr to fix W=1 compile test
warning with !CONFIG_OF:
It's better t
Thanks Pierre,
On 25/09/2020 14:12, Pierre-Louis Bossart wrote:
On 9/25/20 4:28 AM, Srinivas Kandagatla wrote:
Usage of regmap_field_alloc becomes much overhead when number of fields
exceed more than 3.
QCOM LPASS driver has extensively converted to use regmap_fileds.
Multiple typos
On 25/09/2020 13:41, Greg KH wrote:
On Fri, Sep 25, 2020 at 10:55:18AM +0100, Srinivas Kandagatla wrote:
logical address can be either assigned by the SLIMBus controller or the core.
Core uses IDA in cases where get_addr callback is not provided by the
controller.
Core already has this check
GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros.
This patch adds support to these muxes.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/Kconfig| 6 +
drivers/clk/qcom/Makefile | 1 +
drivers/clk/qcom/lpass-gfm-sm8250.c | 260
Audio Clock controller is a block inside LPASS which controls
2 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,audiocc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-audiocc.h | 13 +
2 files changed, 71
- add null check for of_device_get_match_data
verified dt_binding_check to pass on linux next
https://paste.ubuntu.com/p/6nVzjRwvsW/
Srinivas Kandagatla (4):
dt-bindings: clock: Add support for LPASS Audio Clock Controller
dt-bindings: clock: Add support for LPASS Always ON Controller
clk
LPASS Always ON Clock controller has one GFM mux to control VA
and TX clocks to codec macro on LPASS.
This patch adds support to this mux.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom/lpass-gfm-sm8250.c | 63 +
1 file changed, 63 insertions(+)
diff --git
Always ON Clock controller is a block inside LPASS which controls
1 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,aoncc-sm8250.yaml | 58 +++
.../clock/qcom,sm8250-lpass-aoncc.h | 11
2 files changed
quot;)
Signed-off-by: Srinivas Kandagatla
---
drivers/slimbus/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 58b63ae0e75a..1d2bc181da05 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -301,8 +301,6 @@ int slim_u
Hi Greg,
Here are few fixes found recently while testing Qualcomm SSR (SubSystem Restart)
feature on SDM845 SoC. Mostly the fixes are around when device absense is
reported.
If its not too late, can you take them for 5.10.
Many thanks,
Srini
Srinivas Kandagatla (3):
slimbus: core: check
: Add qcom SLIMBus NGD driver")
Signed-off-by: Srinivas Kandagatla
---
drivers/slimbus/qcom-ngd-ctrl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 743ee7b4e63f..218aefc3531c 100644
--- a/drivers/slimbus/qcom-
.
Fixes: 46a2bb5a7f7ea("slimbus: core: Add slim controllers support")
Signed-off-by: Srinivas Kandagatla
---
drivers/slimbus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index ae1e248a8fb8..58b63ae0e75a 10
han
Looks good to me! Thanks for the patch.
Reviewed-by: Srinivas Kandagatla
Acked-by: Srinivas Kandagatla
Greg,
Can you please pick this one? As don't have any nvmem pending patches to
send it together.
thanks,
srini
---
v3:
* rename __nvmem_cell_info_to_nvmem_ce
Usage of regmap_field_alloc becomes much overhead when number of fields
exceed more than 3.
QCOM LPASS driver has extensively converted to use regmap_fileds.
Using new bluk api to allocate fields makes it much more cleaner code to read!
Signed-off-by: Srinivas Kandagatla
Tested-by: Srinivasa
use new devm_regmap_field_bulk_alloc to allocate fields as
it make the code more readable!
Signed-off-by: Srinivas Kandagatla
Tested-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 31 +++
1 file changed, 7 insertions(+), 24 deletions(-)
diff
this new api and a user of it.
Using new bluk api to allocate fields makes it much more cleaner code to read!
Srinivas Kandagatla (2):
regmap: add support to regmap_field_bulk_alloc/free apis
ASoC: lpass-platform: use devm_regmap_field_bulk_alloc
drivers/base/regmap/regmap.c| 100
Fix this warning for all qdsp6 drivers.
Reported-by: kernel test robot
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6adm.c| 2 +-
sound/soc/qcom/qdsp6/q6afe-clocks.c | 2 +-
sound/soc/qcom/qdsp6/q6afe-dai.c| 2 +-
sound/soc/qcom/qdsp6/q6afe.c| 2 +-
sound/soc/
er
'is_gapless' not described in 'q6asm_open_write'
sound/soc/qcom/qdsp6/q6asm.c:1053: warning: Function parameter or member
'stream_id' not described in 'q6asm_run'
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm.c | 3 +++
1 file changed,
Here are fixes for two warnings types discovered while building qdsp6 drivers
without CONFIG_OF and with W=1
One of them was reported by Intel kernel test robot on q6afe-clocks patch, which
equally applies to rest of the qdsp6 drivers.
Srinivas Kandagatla (2):
ASoC: qdsp6: Drop of_match_ptr to
On 23/09/2020 17:23, Vadym Kochan wrote:
On Wed, Sep 23, 2020 at 04:51:06PM +0100, Srinivas Kandagatla wrote:
On 23/09/2020 15:51, Vadym Kochan wrote:
- return nvmem_cell_write(&cell, buf, cell.bytes);
+ rc = nvmem_cell_write(&cell, buf, cell.bytes);
+
On 23/09/2020 17:02, Vadym Kochan wrote:
You mean do not do such func attributes breaking as I did (moved them
line upper) ?
yes, for consistency reasons!
--srini
On 23/09/2020 15:51, Vadym Kochan wrote:
- return nvmem_cell_write(&cell, buf, cell.bytes);
+ rc = nvmem_cell_write(&cell, buf, cell.bytes);
+ if (rc)
+ kfree_const(cell->name);
+
+ return rc;
}
EXPORT_SYMBOL_GPL(nvmem_device_cell_write);
---
On 23/09/2020 15:13, Vadym Kochan wrote:
On Wed, Sep 23, 2020 at 03:10:36PM +0100, Srinivas Kandagatla wrote:
On 23/09/2020 14:53, Vadym Kochan wrote:
Fix missing 'kfree_const(cell->name)' when call to
nvmem_cell_info_to_nvmem_cell() in several places:
On 23/09/2020 14:53, Vadym Kochan wrote:
Fix missing 'kfree_const(cell->name)' when call to
nvmem_cell_info_to_nvmem_cell() in several places:
* after nvmem_cell_info_to_nvmem_cell() failed during
nvmem_add_cells()
* during nvmem_device_cell_{read,write}. This is fixed by
Hi Rob,
On 18/09/2020 18:29, Rob Herring wrote:
On Thu, 17 Sep 2020 14:28:47 +0100, Srinivas Kandagatla wrote:
Audio Clock controller is a block inside LPASS which controls
2 Glitch free muxes to LPASS codec Macros.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/clock/qcom,audiocc
Thanks Stephen for review,
On 22/09/2020 19:41, Stephen Boyd wrote:
Quoting Srinivas Kandagatla (2020-09-17 06:28:49)
GFM Muxes in AUDIO_CC control clocks to LPASS WSA and RX Codec Macros.
This patch adds support to these muxes.
Signed-off-by: Srinivas Kandagatla
---
drivers/clk/qcom
On 22/09/2020 13:53, Rohit Kumar wrote:
That's very much specific to reg, it's not true of the use of names in
general - Rob mentions cases like interrupts for example.
Ofcourse using names suffix for clocks and interrupts has been justified!
I don't mind having dependency on reg-names as
On 22/09/2020 12:08, Mark Brown wrote:
On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
Index is always preferred over name w.r.t device tree bind
On 15/09/2020 13:41, Vadym Kochan wrote:
Currently NVMEM core does not allow to register cells for an already
registered nvmem device and requires that this should be done before.
But there might a driver which needs to parse the nvmem device and then
register a cells table.
Introduce nvmem_p
On 22/09/2020 00:56, Vadym Kochan wrote:
Hi Srinivas,
On Tue, Sep 15, 2020 at 03:41:13PM +0300, Vadym Kochan wrote:
This series adds cells parser for the ONIE TLV attributes which are
stored on NVMEM device. It adds possibility to read the mac address (and
other info) by other drivers.
Beca
On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/Kconfig |
On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-cpu.c | 2 +-
sound/soc/qcom/lpass-platform.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --g
c(ida, gfp). Note: IDR will never actually allocate an ID
larger than INT_MAX.
Signed-off-by: Bartosz Golaszewski
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
From: Tian Tao
Use kobj_to_dev() instead of container_of()
Signed-off-by: Tian Tao
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 6cd3edb2eaf6
From: Vadym Kochan
of_parse_phandle() returns device_node with incremented ref count
which needs to be decremented by of_node_put() when device_node
is not used.
Fixes: e2a5402ec7c6 ("nvmem: Add nvmem_device based consumer apis.")
Signed-off-by: Vadym Kochan
Signed-off-by: Srinivas
Hi Greg,
Here is small set of nvmem patches for 5.10 which includes
- 2 enhancements to core using simple IDA and kobj_to_dev
- 1 fix in core w.r.t device tree node refcounting.
- removed write support for mtk-fuse.
Can you please queue them up for 5.10.
thanks for you help,
srini
Bartosz Golas
Chen
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/mtk-efuse.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
index 856d9c3fc38e..6a537d959f14 100644
--- a/drivers/nvmem/mtk-efuse.c
+++ b/drivers/nvmem/mtk-efuse.c
@@ -2
401 - 500 of 2033 matches
Mail list logo
