Re: [PATCH] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
I guess it makes sense to add it. Thanks. Regards, G On Wednesday 16 December 2015 07:15 PM, Pali Rohár wrote: > On Wednesday 16 December 2015 14:53:04 srinivas_g_go...@dell.com wrote: >> >> Update Srinivas Gowda as dcdbas driver Maintainer >> >> Signed-off-by: Srinivas Gowda >> Acked-by: Doug

[PATCH v2] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
Update Srinivas Gowda as dcdbas driver Maintainer. Also adding relevant mailing list to this version of the patch Signed-off-by: Srinivas Gowda Acked-by: Doug Warzecha --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
Update Srinivas Gowda as dcdbas driver Maintainer Signed-off-by: Srinivas Gowda Acked-by: Doug Warzecha --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 79c2e48..7e3a8d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3390,7

Re: [PATCH] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
I guess it makes sense to add it. Thanks. Regards, G On Wednesday 16 December 2015 07:15 PM, Pali Rohár wrote: > On Wednesday 16 December 2015 14:53:04 srinivas_g_go...@dell.com wrote: >> >> Update Srinivas Gowda as dcdbas driver Maintainer >> >> Signed-off-by: Srinivas Gowda

[PATCH v2] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
Update Srinivas Gowda as dcdbas driver Maintainer. Also adding relevant mailing list to this version of the patch Signed-off-by: Srinivas Gowda Acked-by: Doug Warzecha --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] MAINTAINERS: Update for dcdbas driver

2015-12-16 Thread Srinivas_G_Gowda
Update Srinivas Gowda as dcdbas driver Maintainer Signed-off-by: Srinivas Gowda Acked-by: Doug Warzecha --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 79c2e48..7e3a8d5

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-05 Thread Srinivas_G_Gowda
> > No, I did not see final else in ipmi_thread ever getting hit. > > I am looking at ipmi_thread_busy_wait(), > by default the below condition never gets set unitl I explicetly set > "kipmid_max_busy_us" to some value. > if (smi_info->intf_num < num_max_busy_us) > > This means by default

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-05 Thread Srinivas_G_Gowda
No, I did not see final else in ipmi_thread ever getting hit. I am looking at ipmi_thread_busy_wait(), by default the below condition never gets set unitl I explicetly set kipmid_max_busy_us to some value. if (smi_info-intf_num num_max_busy_us) This means by default max_busy_us is

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-04 Thread Srinivas_G_Gowda
On 12/03/2013 10:40 PM, Corey Minyard wrote: > On 12/03/2013 12:18 AM, srinivas_g_go...@dell.com wrote: >> Dell - Internal Use - Confidential >> >> Hi Corey, >>> Unfortunately, that would start the timer unnecessarily. You don't want to >>> start timers unnecessarily in the kernel or the power

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-04 Thread Srinivas_G_Gowda
On 12/03/2013 10:40 PM, Corey Minyard wrote: On 12/03/2013 12:18 AM, srinivas_g_go...@dell.com wrote: Dell - Internal Use - Confidential Hi Corey, Unfortunately, that would start the timer unnecessarily. You don't want to start timers unnecessarily in the kernel or the power management

RE: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-02 Thread Srinivas_G_Gowda
Dell - Internal Use - Confidential Hi Corey, > Unfortunately, that would start the timer unnecessarily. You don't want to > start timers unnecessarily in the kernel or the power management police will > come after you. I still see the issue after applying the patch. I have one

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-02 Thread Srinivas_G_Gowda
Thanks for the patch Corey. I am afraid that the system does not have interrupts enabled. It uses polling mode. When the error is seen, I know for a fact that in function ipmi_thread() smi_result is SI_SM_CALL_WITH_DELAY, I have some logs where in busy_wait always reads as 1. Not sure if it

Re: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-02 Thread Srinivas_G_Gowda
Thanks for the patch Corey. I am afraid that the system does not have interrupts enabled. It uses polling mode. When the error is seen, I know for a fact that in function ipmi_thread() smi_result is SI_SM_CALL_WITH_DELAY, I have some logs where in busy_wait always reads as 1. Not sure if it

RE: [PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-12-02 Thread Srinivas_G_Gowda
Dell - Internal Use - Confidential Hi Corey, Unfortunately, that would start the timer unnecessarily. You don't want to start timers unnecessarily in the kernel or the power management police will come after you. I still see the issue after applying the patch. I have one question,

[PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-11-25 Thread Srinivas_G_Gowda
Setting up mod_timer() for IPMI_READ_EVENT_MSG_BUFFER_CMD. Driver stalls in case we hit error cases for IPMI_READ_EVENT_MSG_BUFFER_CMD. Signed-off-by: Srinivas Gowda --- drivers/char/ipmi/ipmi_si_intf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/char/ipmi/ipmi_si_intf.c

[PATCH 1/1] ipmi: setting mod_timer for read_event_msg buffer cmd

2013-11-25 Thread Srinivas_G_Gowda
Setting up mod_timer() for IPMI_READ_EVENT_MSG_BUFFER_CMD. Driver stalls in case we hit error cases for IPMI_READ_EVENT_MSG_BUFFER_CMD. Signed-off-by: Srinivas Gowda srinivas_g_go...@dell.com --- drivers/char/ipmi/ipmi_si_intf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git