Re: [PATCH v2 0/6] OpenRISC header and sparse warning fixes for 5.9

2020-08-08 Thread Stafford Horne
On Thu, Aug 06, 2020 at 09:11:46PM +0200, Luc Van Oostenryck wrote: > On Thu, Aug 06, 2020 at 06:07:19AM +0900, Stafford Horne wrote: > > Hello, > > > > Changes since v1: > > - in "io: Fixup defines and move include to the end" added a linux/types.h > >

Re: [PATCH v2 5/6] openrisc: signal: Fix sparse address space warnings

2020-08-08 Thread Stafford Horne
On Thu, Aug 06, 2020 at 09:04:49PM +0200, Luc Van Oostenryck wrote: > On Thu, Aug 06, 2020 at 06:07:24AM +0900, Stafford Horne wrote: > > --- > > arch/openrisc/kernel/signal.c | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > >

Re: [PATCH v2 6/6] openrisc: uaccess: Add user address space check to access_ok

2020-08-08 Thread Stafford Horne
On Thu, Aug 06, 2020 at 09:02:29PM +0200, Luc Van Oostenryck wrote: > On Thu, Aug 06, 2020 at 06:07:25AM +0900, Stafford Horne wrote: > > Now that __user annotations are fixed for openrisc uaccess api's we can > > add checking to the access_ok macro. This patch adds the __chk_use

[PATCH v2 6/6] openrisc: uaccess: Add user address space check to access_ok

2020-08-05 Thread Stafford Horne
Now that __user annotations are fixed for openrisc uaccess api's we can add checking to the access_ok macro. This patch adds the __chk_user_ptr check, on normal builds the added check is a nop. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 3 ++- 1 file changed, 2

[PATCH v2 5/6] openrisc: signal: Fix sparse address space warnings

2020-08-05 Thread Stafford Horne
:32:got struct sigset_t * Signed-off-by: Stafford Horne --- arch/openrisc/kernel/signal.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c index 4f0754874d78..7ce0728412f6 100644 --- a/arch

[PATCH v2 4/6] openrisc: uaccess: Remove unused macro __addr_ok

2020-08-05 Thread Stafford Horne
Since commit b48b2c3e5043 ("openrisc: use generic strnlen_user() function") the macro __addr_ok is no longer used. It is safe to remove so this patch removes it. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 3 --- 1 file changed, 3 deletions(-) diff --

[PATCH v2 0/6] OpenRISC header and sparse warning fixes for 5.9

2020-08-05 Thread Stafford Horne
JLH/ Also this includes a few cleanups which I noticed while working on the warning fixups. -Stafford Stafford Horne (6): openrisc: io: Fixup defines and move include to the end openrisc: uaccess: Fix sparse address space warnings openrisc: uaccess: Use static inline function in access_ok

[PATCH v2 1/6] openrisc: io: Fixup defines and move include to the end

2020-08-05 Thread Stafford Horne
/io.h. Signed-off-by: Stafford Horne --- Changes since v1: - Add linux/types.h include following report from kbuild arch/openrisc/include/asm/io.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h index

[PATCH v2 2/6] openrisc: uaccess: Fix sparse address space warnings

2020-08-05 Thread Stafford Horne
:expected unsigned char const *__gu_addr net/ipv4/ip_sockglue.c:764:29:got unsigned char [noderef] __user * Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/uaccess.h

[PATCH v2 3/6] openrisc: uaccess: Use static inline function in access_ok

2020-08-05 Thread Stafford Horne
ly working on the access_ok macro to fixup sparse annotations in OpenRISC. Suggested-by: Linus Torvalds Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/uaccess.h b/arc

[PATCH 2/6] openrisc: uaccess: Fix sparse address space warnings

2020-08-03 Thread Stafford Horne
:expected unsigned char const *__gu_addr net/ipv4/ip_sockglue.c:764:29:got unsigned char [noderef] __user * Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/uaccess.h

[PATCH 0/6] OpenRISC header and sparse warning fixes for 5.9

2020-08-03 Thread Stafford Horne
(different address spaces) https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org/thread/MB6SE7BX425ENFTSIL6KAOB3CVS4WJLH/ Also this includes a few cleanups which I noticed while working on the warning fixups. -Stafford Stafford Horne (6): openrisc: io: Fixup defines and move include

[PATCH 5/6] openrisc: signal: Fix sparse address space warnings

2020-08-03 Thread Stafford Horne
:32:got struct sigset_t * Signed-off-by: Stafford Horne --- arch/openrisc/kernel/signal.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c index 4f0754874d78..7ce0728412f6 100644 --- a/arch

[PATCH 6/6] openrisc: uaccess: Add user address space check to access_ok

2020-08-03 Thread Stafford Horne
Now that __user annotations are fixed for openrisc uaccess api's we can add checking to the access_ok macro. This patch adds the __chk_user_ptr check, on normal builds the added check is a nop. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 3 ++- 1 file changed, 2

[PATCH 3/6] openrisc: uaccess: Use static inline function in access_ok

2020-08-03 Thread Stafford Horne
ly working on the access_ok macro to fixup sparse annotations in OpenRISC. Suggested-by: Linus Torvalds Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/uaccess.h b/arc

[PATCH 1/6] openrisc: io: Fixup defines and move include to the end

2020-08-03 Thread Stafford Horne
/io.h. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/io.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h index db02fb2077d9..ef985540b674 100644 --- a/arch/openrisc/include/asm/io.h +++ b/arch

[PATCH 4/6] openrisc: uaccess: Remove unused macro __addr_ok

2020-08-03 Thread Stafford Horne
Since commit b48b2c3e5043 ("openrisc: use generic strnlen_user() function") the macro __addr_ok is no longer used. It is safe to remove so this patch removes it. Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 3 --- 1 file changed, 3 deletions(-) diff --

[PATCH v2] asm-generic/io.h: Fix sparse warnings on big-endian architectures

2020-08-03 Thread Stafford Horne
: warning: incorrect type in argument 1 (different base types) ./include/asm-generic/io.h:225:22:expected unsigned int [usertype] value ./include/asm-generic/io.h:225:22:got restricted __le32 [usertype] Signed-off-by: Stafford Horne Acked-by: Arnd Bergmann --- Changes since v1: - Remove

Re: [PATCH] asm-generic/io.h: Fix sparse warnings on big-endian architectures

2020-08-03 Thread Stafford Horne
On Mon, Aug 03, 2020 at 09:50:59PM +0200, Arnd Bergmann wrote: > On Mon, Aug 3, 2020 at 5:11 PM Stafford Horne wrote: > > > > On big-endian architectures like OpenRISC, sparse outputs below warnings on > > asm-generic/io.h. This is due to io statements like: > > >

[PATCH] asm-generic/io.h: Fix sparse warnings on big-endian architectures

2020-08-03 Thread Stafford Horne
: warning: incorrect type in argument 1 (different base types) ./include/asm-generic/io.h:225:22:expected unsigned int [usertype] value ./include/asm-generic/io.h:225:22:got restricted __le32 [usertype] Signed-off-by: Stafford Horne --- include/asm-generic/io.h | 16 1 file

Re: [PATCH 14/24] openrisc: use asm-generic/mmu_context.h for no-op implementations

2020-07-29 Thread Stafford Horne
On Tue, Jul 28, 2020 at 01:33:55PM +1000, Nicholas Piggin wrote: > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openr...@lists.librecores.org > Signed-off-by: Nicholas Piggin > --- > arch/openrisc/include/asm/mmu_context.h | 8 +++- >

Re: [PATCH 05/15] h8300, nds32, openrisc: simplify detection of memory extents

2020-07-29 Thread Stafford Horne
00/kernel/setup.c| 8 +++- > arch/nds32/kernel/setup.c| 8 ++-- > arch/openrisc/kernel/setup.c | 9 ++--- > 3 files changed, 7 insertions(+), 18 deletions(-) Hi Mike, For the openrisc part: Acked-by: Stafford Horne > --- a/arch/openrisc/kernel/setup.c > +++ b/a

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-26 Thread Stafford Horne
On Sun, Jul 26, 2020 at 12:00:37PM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > > > > The return type of functions _inb, _inw and _inl are all u16 which looks > > wrong. This patch makes them u8, u16 and u32 respectively. > &

[PATCH] io: Fix return type of _inb and _inl

2020-07-25 Thread Stafford Horne
Signed-off-by: Stafford Horne --- include/asm-generic/io.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index 8b1e020e9a03..30a3aab312e6 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -456,7 +456,7

[PATCH] openrisc: Implement proper SMP tlb flushing

2020-07-24 Thread Stafford Horne
cpumask. This is used in the SMP flush routines. This mostly follows the riscv implementation. Signed-off-by: Stafford Horne --- arch/openrisc/kernel/smp.c | 85 ++ arch/openrisc/mm/tlb.c | 17 +--- 2 files changed, 89 insertions(+), 13 deletions(-) diff

[PATCH v2] openrisc: Fix oops caused when dumping stack

2020-07-24 Thread Stafford Horne
ask is not lost while we are walking it's stack. Fixes: eecac38b0423a ("openrisc: support framepointers and STACKTRACE_SUPPORT") Signed-off-by: Stafford Horne --- Changes since v1: - V1 was not properly locating the stack, adjust for redzone and pt_regs. arch/openrisc/kernel/stacktrace

Re: [PATCH 5.7 233/244] RISC-V: Acquire mmap lock before invoking walk_page_range

2020-07-22 Thread Stafford Horne
On Wed, Jul 22, 2020 at 03:11:35PM +, Atish Patra wrote: > On Wed, 2020-07-22 at 14:48 +0200, Greg KH wrote: > > On Tue, Jul 21, 2020 at 03:50:35PM -0700, Palmer Dabbelt wrote: > > > On Mon, 20 Jul 2020 12:14:03 PDT (-0700), Greg KH wrote: > > > > On Mon, Jul 20, 2020 at 06:50:10PM +,

Re: [PATCH] OPENRISC ARCHITECTURE: Replace HTTP links with HTTPS ones

2020-07-14 Thread Stafford Horne
On Tue, Jul 14, 2020 at 07:30:38PM +0200, Geert Uytterhoeven wrote: > On Tue, Jul 14, 2020 at 3:40 PM Jonathan Corbet wrote: > > On Tue, 14 Jul 2020 09:22:39 +0200 > > Geert Uytterhoeven wrote: > > > > > - website http://openrisc.io > > > > > + website https://openrisc.io

Re: [PATCH] OPENRISC ARCHITECTURE: Replace HTTP links with HTTPS ones

2020-07-14 Thread Stafford Horne
On Tue, Jul 14, 2020 at 09:22:39AM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 13, 2020 at 7:37 PM Jonathan Corbet wrote: > > On Fri, 10 Jul 2020 08:20:19 +0200 > > "Alexander A. Klimov" wrote: > > > Documentation/openrisc/openrisc_port.rst | 2 +- > > > 1 file changed, 1 insertion(+), 1

Re: [PATCH] Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER

2020-07-10 Thread Stafford Horne
On Fri, Jul 10, 2020 at 09:36:03PM +0200, Alexander A. Klimov wrote: > > > Am 10.07.20 um 12:36 schrieb Stafford Horne: > > On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: > > > On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: > > > &

Re: [PATCH] Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER

2020-07-10 Thread Stafford Horne
On Thu, Jul 09, 2020 at 08:14:09AM +0200, Greg KH wrote: > On Wed, Jul 08, 2020 at 08:41:54PM +0200, Alexander A. Klimov wrote: > > > > > > Am 08.07.20 um 12:39 schrieb Greg KH: > > > On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > > > > Rationale: > > > > Reduces attack

[PATCH] openrisc: Add support for external initrd images

2020-07-04 Thread Stafford Horne
linux,initrd-end = < 0x0820 >; }; Reported-by: Mateusz Holenko Signed-off-by: Stafford Horne --- arch/openrisc/kernel/setup.c | 8 +--- arch/openrisc/kernel/vmlinux.lds.S | 12 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/arc

Re: [PATCH v2] init: Align init_task to avoid conflict with MUTEX_FLAGS

2020-07-01 Thread Stafford Horne
Hello, Is there anyone willing to pick this up? I guess I could send it in the OpenRISC queue, but it doesn't really seem like the right thing. -Stafford On Sat, Jun 27, 2020 at 06:07:53AM +0900, Stafford Horne wrote: > When booting on 32-bit machines (seen on OpenRISC) I saw this warn

Re: [PATCH 2/8] opeinrisc: switch to generic version of pte allocation

2020-06-27 Thread Stafford Horne
ser page tables. > > The pte_alloc_one_kernel() is kept back because its implementation on > openrisc is different than the generic one. > > Signed-off-by: Mike Rapoport Thank's for this. Acked-by: Stafford Horne

[PATCH v2] init: Align init_task to avoid conflict with MUTEX_FLAGS

2020-06-26 Thread Stafford Horne
for MUTEX_FLAGS. Howerver, for 32-bit machines the symbol address only has 2 bits available. Fix this by setting init_task alignment to at least L1_CACHE_BYTES. Signed-off-by: Stafford Horne Acked-by: Peter Zijlstra (Intel) --- Changes since v1: - Make alignment unconditional suggested by Pet

Re: [PATCH] init: Align init_task to avoid conflict with MUTEX_FLAGS

2020-06-26 Thread Stafford Horne
On Fri, Jun 26, 2020 at 01:12:08PM +0200, Peter Zijlstra wrote: > On Fri, Jun 26, 2020 at 05:44:09AM +0900, Stafford Horne wrote: > > When booting on 32-bit machines (seen on OpenRISC) I saw this warning > > with CONFIG_DEBUG_MUTEXES turned on. > > > I traced this t

Re: [PATCH] openrisc: fix __user in raw_copy_to_user()'s prototype

2020-06-25 Thread Stafford Horne
On Mon, Jun 22, 2020 at 02:11:24PM +0200, Luc Van Oostenryck wrote: > raw_copy_to_user()'s prototype seems to be a copy & paste of > raw_copy_from_user() and as such has the __user annotation > in the 'from' argument instead of the 'to'. > > So, move the __user annotation in the prototype to the

[PATCH] init: Align init_task to avoid conflict with MUTEX_FLAGS

2020-06-25 Thread Stafford Horne
for MUTEX_FLAGS. Howerver, for 32-bit machines the symbol address only has 2 bits available. Fix this by setting init_task alignment to at least L1_CACHE_BYTES. Cc: Peter Zijlstra Signed-off-by: Stafford Horne --- init/init_task.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/init/ini

Re: [PATCH] openrisc: Fix oops caused when dumping stack

2020-06-17 Thread Stafford Horne
On Wed, Jun 17, 2020 at 06:07:01PM +0900, Stafford Horne wrote: > When dumping a stack siwth 'cat /proc/1/stack' the kernel would oops. I will fix this typo, s/siwth/with/. -Stafford

[PATCH] openrisc: Fix oops caused when dumping stack

2020-06-17 Thread Stafford Horne
ask is not lost while we are walking it's stack. Signed-off-by: Stafford Horne --- arch/openrisc/kernel/stacktrace.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/openrisc/kernel/stacktrace.c b/arch/openrisc/kernel/stacktrace.c index 43f140a28bc7..ac91614509c8 10

[PATCH] openrisc: Fix boot oops when DEBUG_VM is enabled

2020-06-17 Thread Stafford Horne
hen during page walks for DMA operations. This patch locks and unlocks the mmap lock for page walking. Fixes: 42fc541404f2 ("mmap locking API: add mmap_assert_locked() and mmap_assert_write_locked()" Cc: Michel Lespinasse Signed-off-by: Stafford Horne --- arch/openrisc/kernel/dma.c | 5 +

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-17 Thread Stafford Horne
On Wed, Jun 17, 2020 at 02:35:39PM +0900, Stafford Horne wrote: > On Tue, Jun 16, 2020 at 01:47:24PM -0700, Michel Lespinasse wrote: > > This makes me wonder actually - maybe there is a latent bug that got > > exposed after my change added the rwsem_is_l

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Stafford Horne
do { -Stafford > On Tue, Jun 16, 2020 at 12:41 PM Atish Patra wrote: > > > > On Tue, Jun 16, 2020 at 12:19 PM Stafford Horne wrote: > > > > > > On Tue, Jun 16, 2020 at 03:44:49AM -0700, Michel Lespinasse wrote: > > > > I am also unable to re

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-16 Thread Stafford Horne
_init+0x18/0x144 [4.34] [<(ptrval)>] ? schedule_tail+0x54/0x94 [4.34] [<(ptrval)>] ret_from_fork+0x1c/0x150 [4.34] Kernel panic - not syncing: BUG! [4.34] ---[ end Kernel panic - not syncing: BUG! ]--- > On Tue, Jun 16, 2020 at 1:40 AM Palmer Dabbel

Re: [PATCH 15/25] mm/openrisc: Use mm_fault_accounting()

2020-06-16 Thread Stafford Horne
onfig > has > CONFIG_PERF_EVENTS defined. > > CC: Jonas Bonn > CC: Stefan Kristiansson > CC: Stafford Horne > CC: openr...@lists.librecores.org > Signed-off-by: Peter Xu Acked-by: Stafford Horne

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-15 Thread Stafford Horne
On Tue, Jun 16, 2020 at 06:57:47AM +0900, Stafford Horne wrote: > On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: > > Hi, > > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. > > I added additional dump_stack and observed that it's

Re: mm lock issue while booting Linux on 5.8-rc1 for RISC-V

2020-06-15 Thread Stafford Horne
On Mon, Jun 15, 2020 at 12:28:11AM -0700, Atish Patra wrote: > Hi, > I encountered the following issue while booting 5.8-rc1 on Qemu for RV64. > I added additional dump_stack and observed that it's happening in bpf free > path. > It happens always if CONFIG_DEBUG_VM is enabled. VM_BUG_ON_MM is >

Re: [GIT PULL] OpenRISC updates for v5.8

2020-06-12 Thread Stafford Horne
CCing list. On Sat, Jun 13, 2020 at 11:17:57AM +0900, Stafford Horne wrote: > Hi Linus, > > Please consider for pull: > > The following changes since commit ae83d0b416db002fe95601e7f97f64b59514d936: > > Linux 5.7-rc2 (2020-04-19 14:35:30 -0700) > > are avai

[PATCH] openrisc: Fix issue with argument clobbering for clone/fork

2020-05-31 Thread Stafford Horne
registers. This was likely due to some old code hanging around. This patch fixes this up for clone and fork. This fork clobber is harmless but also useless so remove. Signed-off-by: Stafford Horne --- arch/openrisc/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[GIT PULL] OpenRISC updates for v5.4

2019-09-17 Thread Stafford Horne
ethernet works on FPGAs running OpenRISC! - Switch ioremap to use uncached semantics - from Christoph Hellwig Christoph Hellwig (1): openrisc: map as uncached in ioremap Stafford Horne (2): or1k: dts: Fix ethoc network

[PATCH 2/2] or1k: dts: Add ethoc device to SMP devicetree

2019-08-30 Thread Stafford Horne
This patch adds the ethoc device configuration to the OpenRISC basic SMP device tree config. This was tested with qemu. Signed-off-by: Stafford Horne --- arch/openrisc/boot/dts/simple_smp.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/openrisc/boot/dts/simple_smp.dts b

[PATCH 0/2] OpenRISC ethoc device tree fixes

2019-08-30 Thread Stafford Horne
. Stafford Horne (2): or1k: dts: Fix ethoc network configuration in or1ksim devicetree or1k: dts: Add ethoc device to SMP devicetree arch/openrisc/boot/dts/or1ksim.dts| 5 +++-- arch/openrisc/boot/dts/simple_smp.dts | 6 ++ 2 files changed, 9 insertions(+), 2 deletions(-) -- 2.21.0

[PATCH 1/2] or1k: dts: Fix ethoc network configuration in or1ksim devicetree

2019-08-30 Thread Stafford Horne
initialization to abort. Finally, we need to mark this device as big-endian as needed by openrisc. This was tested by me in qemu, the setup is documented on the qemu wiki: https://wiki.qemu.org/Documentation/Platforms/OpenRISC Signed-off-by: Stafford Horne --- arch/openrisc/boot/dts/or1ksim.dts | 5

Re: [PATCH 05/26] openrisc: map as uncached in ioremap

2019-08-23 Thread Stafford Horne
ristoph Hellwig > --- > arch/openrisc/include/asm/io.h | 20 +++- > arch/openrisc/include/asm/pgtable.h | 2 +- > arch/openrisc/mm/ioremap.c | 8 > 3 files changed, 8 insertions(+), 22 deletions(-) Acked-by: Stafford Horne Thanks, -Stafford

Re: [PATCH v2 01/21] openrisc: prefer memblock APIs returning virtual address

2019-01-26 Thread Stafford Horne
__pa(pte))); > > /* Fill the newly allocated page with PTE'S */ This seems reasonable to me. Acked-by: Stafford Horne

Re: [PATCH] arch/openrisc: Fix issues with access_ok()

2019-01-08 Thread Stafford Horne
On Tue, Jan 08, 2019 at 10:16:39AM -0800, Linus Torvalds wrote: > On Tue, Jan 8, 2019 at 10:10 AM Linus Torvalds > wrote: > > > > On Tue, Jan 8, 2019 at 5:15 AM Stafford Horne wrote: > > > > > > The commit 594cc251fdd0 ("make 'user_access_begin()' d

Re: [PATCH] arch: unexport asm/shmparam.h for all architectures

2019-01-08 Thread Stafford Horne
On Wed, Jan 09, 2019 at 12:32:28AM +0900, Masahiro Yamada wrote: > Hi Stafford, > > > > On Tue, Jan 8, 2019 at 8:12 PM Stafford Horne wrote: > > > > What is this patch based on? I tried to apply it to 5.0-rc1 and am having > > an > > issue with appl

[PATCH] arch/openrisc: Fix issues with access_ok()

2019-01-08 Thread Stafford Horne
ents twice. This patch fixes those 2 issues. I test booted this patch with v5.0-rc1 on qemu and it's working fine. Cc: Guenter Roeck Cc: Linus Torvalds Reported-by: Linus Torvalds Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/uaccess.h | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [PATCH] arch: unexport asm/shmparam.h for all architectures

2019-01-08 Thread Stafford Horne
Hi Masahiro, On Tue, Jan 08, 2019 at 08:38:27AM +0900, Masahiro Yamada wrote: > Most architectures do not export shmparam.h to user-space. > > $ find arch -name shmparam.h | sort > arch/alpha/include/asm/shmparam.h > arch/arc/include/asm/shmparam.h > arch/arm64/include/asm/shmparam.h >

Re: [PATCH] make 'user_access_begin()' do 'access_ok()'

2019-01-07 Thread Stafford Horne
On Mon, Jan 07, 2019 at 10:05:12AM -0800, Linus Torvalds wrote: > Gaah. Re-sending this for the kernel mailing list just for posterity. > I keep replying to emails that had the mailing list address wrong, and > then my reply will have it wrong too. > > I will learn to fix up the address just in

[GIT PULL] v4.21 Updates for OpenRISC

2018-12-31 Thread Stafford Horne
Hi Linus, Please consider for pull, The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd: Linux 4.20-rc7 (2018-12-16 15:46:55 -0800) are available in the Git repository at: git://github.com/openrisc/linux.git tags/for-linus for you to fetch changes up to

Re: [PATCH resend] openrisc: Fix broken paths to arch/or32

2018-12-19 Thread Stafford Horne
On Mon, Dec 03, 2018 at 01:20:47PM +0100, Geert Uytterhoeven wrote: > OpenRISC was mainlined as "openrisc", not "or32". > vmlinux.lds is generated from vmlinux.lds.S. > > Signed-off-by: Geert Uytterhoeven Thanks, Sorry for the delay. I will queue this up. -Stafford > --- >

Re: [PATCH] openrisc: make function cache_loop() inline

2018-11-13 Thread Stafford Horne
^ > arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm' > > Signed-off-by: Changbin Du > Reported-by: kbuild test robot > Cc: Stafford Horne > Cc: Masahiro Yamada Acked-by: Stafford Horne > --- > arch/openrisc/mm/cache.c | 2 +- >

Re: [PATCH] openrisc: make function cache_loop() inline

2018-11-13 Thread Stafford Horne
^ > arch/openrisc/include/asm/spr.h:20:27: error: impossible constraint in 'asm' > > Signed-off-by: Changbin Du > Reported-by: kbuild test robot > Cc: Stafford Horne > Cc: Masahiro Yamada Acked-by: Stafford Horne > --- > arch/openrisc/mm/cache.c | 2 +- >

Re: [PATCH 10/21] openrisc: use for_each_of_cpu_node iterator

2018-09-06 Thread Stafford Horne
u". > > This also fixes a leaked reference for cpus node. > > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openr...@lists.librecores.org > Signed-off-by: Rob Herring > --- > Please ack and I will take via the DT tree. This is dependent on th

Re: [PATCH 10/21] openrisc: use for_each_of_cpu_node iterator

2018-09-06 Thread Stafford Horne
u". > > This also fixes a leaked reference for cpus node. > > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openr...@lists.librecores.org > Signed-off-by: Rob Herring > --- > Please ack and I will take via the DT tree. This is dependent on th

[GIT PULL] OpenRISC updates for 4.19

2018-08-23 Thread Stafford Horne
Hi Linus, Please consider for pull. -Stafford The following changes since commit 1e4b044d22517cae7047c99038abb23243ca: Linux 4.18-rc4 (2018-07-08 16:34:02 -0700) are available in the Git repository at: git://github.com/openrisc/linux.git tags/for-linus for you to fetch changes up to

[GIT PULL] OpenRISC updates for 4.19

2018-08-23 Thread Stafford Horne
Hi Linus, Please consider for pull. -Stafford The following changes since commit 1e4b044d22517cae7047c99038abb23243ca: Linux 4.18-rc4 (2018-07-08 16:34:02 -0700) are available in the Git repository at: git://github.com/openrisc/linux.git tags/for-linus for you to fetch changes up to

[GIT PULL] OpenRISC fixes for 4.18

2018-07-02 Thread Stafford Horne
. - Fix bug in __pte_free_tlb() exposed in 4.18 by Matthew Wilcox's page table flag addition. - Fix issue booting on real hardware if delay slot detection emulation is disabled. Stafford Horne (2): openrisc: Call destructor

[GIT PULL] OpenRISC fixes for 4.18

2018-07-02 Thread Stafford Horne
. - Fix bug in __pte_free_tlb() exposed in 4.18 by Matthew Wilcox's page table flag addition. - Fix issue booting on real hardware if delay slot detection emulation is disabled. Stafford Horne (2): openrisc: Call destructor

[PATCH] openrisc: entry: Fix delay slot exception detection

2018-07-01 Thread Stafford Horne
ave tested this on QEMU with a patch ensuring it matches the hardware specification. Link: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg0.html Fixes: e6d20c55a4 ("openrisc: entry: Fix delay slot detection") Signed-off-by: Stafford Horne --- arch/openrisc/kernel/entry.

[PATCH] openrisc: entry: Fix delay slot exception detection

2018-07-01 Thread Stafford Horne
ave tested this on QEMU with a patch ensuring it matches the hardware specification. Link: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg0.html Fixes: e6d20c55a4 ("openrisc: entry: Fix delay slot detection") Signed-off-by: Stafford Horne --- arch/openrisc/kernel/entry.

Re: [PATCH v2 1/2] crypto: Fix -Wstringop-truncation warnings

2018-06-25 Thread Stafford Horne
On Mon, Jun 25, 2018 at 02:59:58PM +0200, Christophe LEROY wrote: > > > Le 25/06/2018 à 14:45, Stafford Horne a écrit : > > As of GCC 9.0.0 the build is reporting warnings like: > > > > crypto/ablkcipher.c: In function ‘crypto_ablkcipher_report’: > > c

Re: [PATCH v2 1/2] crypto: Fix -Wstringop-truncation warnings

2018-06-25 Thread Stafford Horne
On Mon, Jun 25, 2018 at 02:59:58PM +0200, Christophe LEROY wrote: > > > Le 25/06/2018 à 14:45, Stafford Horne a écrit : > > As of GCC 9.0.0 the build is reporting warnings like: > > > > crypto/ablkcipher.c: In function ‘crypto_ablkcipher_report’: > > c

[PATCH] openrisc: Call destructor during __pte_free_tlb

2018-06-17 Thread Stafford Horne
s either call the destructor like we are doing here or use pte_free. Fixes: 1d40a5ea01d53 ("mm: mark pages in use for page tables") Cc: Matthew Wilcox Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/pgalloc.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH] openrisc: Call destructor during __pte_free_tlb

2018-06-17 Thread Stafford Horne
s either call the destructor like we are doing here or use pte_free. Fixes: 1d40a5ea01d53 ("mm: mark pages in use for page tables") Cc: Matthew Wilcox Signed-off-by: Stafford Horne --- arch/openrisc/include/asm/pgalloc.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v5 4/4] mm: Mark pages in use for page tables

2018-06-17 Thread Stafford Horne
On Sun, Jun 17, 2018 at 11:52:22AM -0700, Matthew Wilcox wrote: > On Mon, Jun 18, 2018 at 12:09:31AM +0900, Stafford Horne wrote: > > On Wed, Mar 07, 2018 at 05:44:43AM -0800, Matthew Wilcox wrote: > > > Define a new PageTable bit in the page_type and use it to mark pages in

Re: [PATCH v5 4/4] mm: Mark pages in use for page tables

2018-06-17 Thread Stafford Horne
On Sun, Jun 17, 2018 at 11:52:22AM -0700, Matthew Wilcox wrote: > On Mon, Jun 18, 2018 at 12:09:31AM +0900, Stafford Horne wrote: > > On Wed, Mar 07, 2018 at 05:44:43AM -0800, Matthew Wilcox wrote: > > > Define a new PageTable bit in the page_type and use it to mark pages in

Re: [PATCH v5 4/4] mm: Mark pages in use for page tables

2018-06-17 Thread Stafford Horne
On Wed, Mar 07, 2018 at 05:44:43AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > Define a new PageTable bit in the page_type and use it to mark pages in > use as page tables. This can be helpful when debugging crashdumps or > analysing memory fragmentation. Add a KPF flag to report

Re: [PATCH v5 4/4] mm: Mark pages in use for page tables

2018-06-17 Thread Stafford Horne
On Wed, Mar 07, 2018 at 05:44:43AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > Define a new PageTable bit in the page_type and use it to mark pages in > use as page tables. This can be helpful when debugging crashdumps or > analysing memory fragmentation. Add a KPF flag to report

Re: [PATCH 2/2] [RFC] disable -Wattribute-alias warning for SYSCALL_DEFINEx()

2018-06-11 Thread Stafford Horne
On Tue, Dec 05, 2017 at 05:06:31PM +0100, Arnd Bergmann wrote: > gcc-8 warns for every single definition of a system call entry > point, e.g.: > > include/linux/compat.h:56:18: error: 'compat_sys_rt_sigprocmask' alias > between functions of incompatible types 'long int(int, compat_sigset_t *,

Re: [PATCH 2/2] [RFC] disable -Wattribute-alias warning for SYSCALL_DEFINEx()

2018-06-11 Thread Stafford Horne
On Tue, Dec 05, 2017 at 05:06:31PM +0100, Arnd Bergmann wrote: > gcc-8 warns for every single definition of a system call entry > point, e.g.: > > include/linux/compat.h:56:18: error: 'compat_sys_rt_sigprocmask' alias > between functions of incompatible types 'long int(int, compat_sigset_t *,

[GIT PULL] OpenRISC updates for 4.17

2018-04-14 Thread Stafford Horne
Hi Linus, Please consider for pull, The following changes since commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda: Linux 4.16 (2018-04-01 14:20:27 -0700) are available in the git repository at: git://github.com/openrisc/linux.git tags/for-linus for you to fetch changes up to

[GIT PULL] OpenRISC updates for 4.17

2018-04-14 Thread Stafford Horne
Hi Linus, Please consider for pull, The following changes since commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda: Linux 4.16 (2018-04-01 14:20:27 -0700) are available in the git repository at: git://github.com/openrisc/linux.git tags/for-linus for you to fetch changes up to

Re: [PATCH] openrisc: define mb() as its mandatory

2018-04-07 Thread Stafford Horne
On Sat, Apr 07, 2018 at 11:09:05AM +0200, Peter Zijlstra wrote: > On Sat, Apr 07, 2018 at 05:58:49AM +0900, Stafford Horne wrote: > > Following Peter Z's patch ("asm-generic: Disallow no-op mb() for SMP > > systems") which makes mb() mandatory for SMP architectures we

Re: [PATCH] openrisc: define mb() as its mandatory

2018-04-07 Thread Stafford Horne
On Sat, Apr 07, 2018 at 11:09:05AM +0200, Peter Zijlstra wrote: > On Sat, Apr 07, 2018 at 05:58:49AM +0900, Stafford Horne wrote: > > Following Peter Z's patch ("asm-generic: Disallow no-op mb() for SMP > > systems") which makes mb() mandatory for SMP architectures we

Re: linux-next: Signed-off-by missing for commit in the openrisc tree

2018-04-07 Thread Stafford Horne
On Sat, Apr 07, 2018 at 11:36:24PM +1000, Stephen Rothwell wrote: > Hi Stafford, > > Commit > > bf118b74c385 ("openrisc: remove unused __ARCH_HAVE_MMU define") > > is missing a Signed-off-by from its committer. Thanks this is updated now. -Stafford

Re: linux-next: Signed-off-by missing for commit in the openrisc tree

2018-04-07 Thread Stafford Horne
On Sat, Apr 07, 2018 at 11:36:24PM +1000, Stephen Rothwell wrote: > Hi Stafford, > > Commit > > bf118b74c385 ("openrisc: remove unused __ARCH_HAVE_MMU define") > > is missing a Signed-off-by from its committer. Thanks this is updated now. -Stafford

[PATCH] openrisc: define mb() as its mandatory

2018-04-06 Thread Stafford Horne
y. Signed-off-by: Stafford Horne <sho...@gmail.com> Link: https://lkml.org/lkml/2018/1/31/254 Cc: Peter Zijlstra <pet...@infradead.org> Cc: Will Deacon <will.dea...@arm.com> --- Notes: - Sorry, its been a while since we discussed this patch is the parent to this still going

[PATCH] openrisc: define mb() as its mandatory

2018-04-06 Thread Stafford Horne
y. Signed-off-by: Stafford Horne Link: https://lkml.org/lkml/2018/1/31/254 Cc: Peter Zijlstra Cc: Will Deacon --- Notes: - Sorry, its been a while since we discussed this patch is the parent to this still going in Peter? - I have not got around to updating our architecture spec for t

Re: [PATCH v5 12/16] openrisc: Switch to generic free_initrd_mem.

2018-03-29 Thread Stafford Horne
On Thu, Mar 29, 2018 at 07:32:03AM -0400, Shea Levy wrote: > The generic implementation is functionally identical. > > Signed-off-by: Shea Levy <s...@shealevy.com> Acked-by: Stafford Horne <sho...@gmail.com> > --- > arch/openrisc/mm/init.c | 7 --- >

Re: [PATCH v5 12/16] openrisc: Switch to generic free_initrd_mem.

2018-03-29 Thread Stafford Horne
On Thu, Mar 29, 2018 at 07:32:03AM -0400, Shea Levy wrote: > The generic implementation is functionally identical. > > Signed-off-by: Shea Levy Acked-by: Stafford Horne > --- > arch/openrisc/mm/init.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/a

Re: [PATCH v4 2/8] openrisc: Set CONFIG_MULTI_IRQ_HANDLER

2018-03-28 Thread Stafford Horne
for > now. This will go away by the end of the patch set. > > Signed-off-by: Palmer Dabbelt <pal...@sifive.com> Hi Palmer, Thanks for doing this work, its always nice to see generic code pulled out of architecture ports. Acked-by: Stafford Horne <sho...@gmail.com> > --- > arch

Re: [PATCH v4 2/8] openrisc: Set CONFIG_MULTI_IRQ_HANDLER

2018-03-28 Thread Stafford Horne
for > now. This will go away by the end of the patch set. > > Signed-off-by: Palmer Dabbelt Hi Palmer, Thanks for doing this work, its always nice to see generic code pulled out of architecture ports. Acked-by: Stafford Horne > --- > arch/openrisc/Kconfig | 4 > 1 file changed

Re: asm-generic: Disallow no-op mb() for SMP systems

2018-02-02 Thread Stafford Horne
On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implemen

Re: asm-generic: Disallow no-op mb() for SMP systems

2018-02-02 Thread Stafford Horne
On Thu, Feb 01, 2018 at 02:29:09PM +0100, Peter Zijlstra wrote: > On Thu, Feb 01, 2018 at 09:27:50PM +0900, Stafford Horne wrote: > > I tried to clarify some of this in the spec v1.2 [0] which help formalize > > some of > > the techniques we used for the SMP implemen

Re: asm-generic: Disallow no-op mb() for SMP systems

2018-02-01 Thread Stafford Horne
On Wed, Jan 31, 2018 at 02:26:10PM +0100, Peter Zijlstra wrote: > On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > > being

Re: asm-generic: Disallow no-op mb() for SMP systems

2018-02-01 Thread Stafford Horne
On Wed, Jan 31, 2018 at 02:26:10PM +0100, Peter Zijlstra wrote: > On Wed, Jan 31, 2018 at 01:17:37PM +, Will Deacon wrote: > > On Wed, Jan 31, 2018 at 02:00:34PM +0100, Peter Zijlstra wrote: > > > > > > While looking through the qspinlock users, I stumbled upon openrisc and > > > being

Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER

2018-01-26 Thread Stafford Horne
This looks fine to me too. We only assign the handle_arch_irq one time. I think not protecting against overrides was an oversight in the original implementation. Acked-by: Stafford Horne <sho...@gmail.com> -Stafford

Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER

2018-01-26 Thread Stafford Horne
This looks fine to me too. We only assign the handle_arch_irq one time. I think not protecting against overrides was an oversight in the original implementation. Acked-by: Stafford Horne -Stafford

<    1   2   3   4   5   6   7   8   9   10   >