Re: linux-next: manual merge of the bpf-next tree with the net-next tree

2021-01-25 Thread Stanislav Fomichev
Thanks, the merge resolution looks good to me! On Sun, Jan 24, 2021 at 4:12 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the bpf-next tree got a conflict in: > > net/ipv4/tcp.c > > between commit: > > 7eeba1706eba ("tcp: Add receive timestamp support for receive

Re: [PATCH bpf 0/2] selftests/bpf: test_progs: don't leak fd in bpf

2019-10-01 Thread Stanislav Fomichev
On 10/01, Brian Vazquez wrote: > This patch series fixes some fd leaks in tcp_rtt and > test_sockopt_inherit bpf prof_tests. Thanks! For the series: Reviewed-by: Stanislav Fomichev > Brian Vazquez (2): > selftests/bpf: test_progs: don't leak server_fd in tcp_rtt > selftests/

Re: [bpf-next v3 10/12] bpf: Implement bpf_prog_test_run for perf event programs

2019-07-11 Thread Stanislav Fomichev
On 07/08, Krzesimir Nowak wrote: > As an input, test run for perf event program takes struct > bpf_perf_event_data as ctx_in and struct bpf_perf_event_value as > data_in. For an output, it basically ignores ctx_out and data_out. > > The implementation sets an instance of struct

Re: [bpf-next v3 09/12] bpf: Split out some helper functions

2019-07-11 Thread Stanislav Fomichev
On 07/08, Krzesimir Nowak wrote: > The moved functions are generally useful for implementing > bpf_prog_test_run for other types of BPF programs - they don't have > any network-specific stuff in them, so I can use them in a test run > implementation for perf event BPF program too. It's a bit hard

Re: [PATCH bpf-next] bpf: cgroup: Fix build error without CONFIG_NET

2019-07-02 Thread Stanislav Fomichev
On 07/02, YueHaibing wrote: > If CONFIG_NET is not set, gcc building fails: > > kernel/bpf/cgroup.o: In function `cg_sockopt_func_proto': > cgroup.c:(.text+0x237e): undefined reference to `bpf_sk_storage_get_proto' > cgroup.c:(.text+0x2394): undefined reference to `bpf_sk_storage_delete_proto' >

Re: [bpf/tools] cd17d77705: kernel_selftests.bpf.test_sock_addr.sh.fail

2019-06-28 Thread Stanislav Fomichev
On 06/28, Andrii Nakryiko wrote: > On Thu, Jun 27, 2019 at 7:38 PM Stanislav Fomichev wrote: > > > > On 06/27, Andrii Nakryiko wrote: > > > On Thu, Jun 27, 2019 at 10:29 AM Stanislav Fomichev > > > wrote: > > > > > > > > On 06/27, Stanis

Re: [bpf/tools] cd17d77705: kernel_selftests.bpf.test_sock_addr.sh.fail

2019-06-27 Thread Stanislav Fomichev
On 06/27, Andrii Nakryiko wrote: > On Thu, Jun 27, 2019 at 10:29 AM Stanislav Fomichev wrote: > > > > On 06/27, Stanislav Fomichev wrote: > > > On 06/27, kernel test robot wrote: > > > > FYI, we noticed the following commit (built

Re: [bpf/tools] cd17d77705: kernel_selftests.bpf.test_sock_addr.sh.fail

2019-06-27 Thread Stanislav Fomichev
On 06/27, Stanislav Fomichev wrote: > On 06/27, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-7): > > > > commit: cd17d77705780e2270937fb3cbd2b985adab3edc ("bpf/tools: sync bpf.h") > > https://git.kernel.org/cgit/linux/

Re: [bpf/tools] cd17d77705: kernel_selftests.bpf.test_sock_addr.sh.fail

2019-06-27 Thread Stanislav Fomichev
On 06/27, kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: cd17d77705780e2270937fb3cbd2b985adab3edc ("bpf/tools: sync bpf.h") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > in testcase: kernel_selftests > with

Re: [bpf-next v2 08/10] bpf: Implement bpf_prog_test_run for perf event programs

2019-06-26 Thread Stanislav Fomichev
On 06/26, Krzesimir Nowak wrote: > On Tue, Jun 25, 2019 at 10:12 PM Stanislav Fomichev wrote: > > > > On 06/25, Krzesimir Nowak wrote: > > > As an input, test run for perf event program takes struct > > > bpf_perf_event_data as ctx_in and struct bpf_

Re: [bpf-next v2 08/10] bpf: Implement bpf_prog_test_run for perf event programs

2019-06-25 Thread Stanislav Fomichev
On 06/25, Krzesimir Nowak wrote: > As an input, test run for perf event program takes struct > bpf_perf_event_data as ctx_in and struct bpf_perf_event_value as > data_in. For an output, it basically ignores ctx_out and data_out. > > The implementation sets an instance of struct

Re: [bpf-next v2 03/10] selftests/bpf: Avoid another case of errno clobbering

2019-06-25 Thread Stanislav Fomichev
erifier wants to print a reason why > verifying a BPF program of a supported type failed. > > Fixes: 8184d44c9a57 ("selftests/bpf: skip verifier tests for unsupported > program types") > Cc: Stanislav Fomichev > Signed-off-by: Krzesimir Nowak > --- > tools/

Re: [selftests/bpf] 69d96519db: kernel_selftests.bpf.test_socket_cookie.fail

2019-06-24 Thread Stanislav Fomichev
On 06/24, Andrii Nakryiko wrote: > On Sun, Jun 23, 2019 at 5:59 PM Rong Chen wrote: > > > > On 6/22/19 6:27 AM, Stanislav Fomichev wrote: > > > On 06/21, Andrii Nakryiko wrote: > > >> ) > > >> > > >> On Fri, Jun 21, 2019 at 9:11 AM Stan

Re: [selftests/bpf] 69d96519db: kernel_selftests.bpf.test_socket_cookie.fail

2019-06-21 Thread Stanislav Fomichev
On 06/21, Andrii Nakryiko wrote: > ) > > On Fri, Jun 21, 2019 at 9:11 AM Stanislav Fomichev wrote: > > > > On 06/21, kernel test robot wrote: > > > FYI, we noticed the following commit (built with gcc-7): > > > > > > commit: 69d96519dbf0bfa18

Re: [PATCH] flow_dissector: Fix vlan header offset in __skb_flow_dissect

2019-06-20 Thread Stanislav Fomichev
On 06/20, Yuehaibing wrote: > On 2019/6/20 2:39, Stanislav Fomichev wrote: > > On 06/20, YueHaibing wrote: > >> We build vlan on top of bonding interface, which vlan offload > >> is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is > >> BOND_XMIT_POLICY_E

Re: [PATCH] flow_dissector: Fix vlan header offset in __skb_flow_dissect

2019-06-19 Thread Stanislav Fomichev
On 06/20, YueHaibing wrote: > We build vlan on top of bonding interface, which vlan offload > is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is > BOND_XMIT_POLICY_ENCAP34. > > __skb_flow_dissect() fails to get information from protocol headers > encapsulated within vlan, because 'nhoff'

Re: [PATCH] bpf: selftests: Fix warning in flow_dissector

2019-06-13 Thread Stanislav Fomichev
On 06/13, Arthur Fabre wrote: > Building the userspace part of the flow_dissector resulted in: > > prog_tests/flow_dissector.c: In function ‘tx_tap’: > prog_tests/flow_dissector.c:176:9: warning: implicit declaration > of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]

Re: [PATCH bpf-next 4/4] selftests/bpf: add auto-detach test

2019-05-22 Thread Stanislav Fomichev
On 05/22, Roman Gushchin wrote: > Add a kselftest to cover bpf auto-detachment functionality. > The test creates a cgroup, associates some resources with it, > attaches a couple of bpf programs and deletes the cgroup. > > Then it checks that bpf programs are going away in 5 seconds. > > Expected

Re: [PATCH bpf-next 3/4] selftests/bpf: enable all available cgroup v2 controllers

2019-05-22 Thread Stanislav Fomichev
On 05/22, Roman Gushchin wrote: > Enable all available cgroup v2 controllers when setting up > the environment for the bpf kselftests. It's required to properly test > the bpf prog auto-detach feature. Also it will generally increase > the code coverage. > > Signed-off-by: Roman Gushchin > --- >

Re: [PATCH 2/5] libbpf: add missing typedef

2019-05-20 Thread Stanislav Fomichev
On 05/20, Matteo Croce wrote: > On Mon, May 20, 2019 at 6:53 PM Stanislav Fomichev wrote: > > > > On 05/18, Matteo Croce wrote: > > > Sync tools/include/linux/types.h with the UAPI one to fix this build > > > error: > > > > > > make -C s

Re: [PATCH 2/5] libbpf: add missing typedef

2019-05-20 Thread Stanislav Fomichev
On 05/18, Matteo Croce wrote: > Sync tools/include/linux/types.h with the UAPI one to fix this build error: > > make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= > srctree=samples/bpf/../../ O= > HOSTCC samples/bpf/sock_example > In file included from

Re: [PATCH 02/12] perf tools: Separate generic code in dso_cache__read

2019-04-16 Thread Stanislav Fomichev
On 04/16, Jiri Olsa wrote: > Moving file specific code in dso_cache__read function > into separate file_read function. I'll add bpf specific > code in following patches. > > Link: http://lkml.kernel.org/n/tip-7f7d717uzrqt5ka2xp29i...@git.kernel.org > Signed-off-by: Jiri Olsa > --- >

Re: [PATCH v7 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd

2019-03-07 Thread Stanislav Fomichev
On 03/07, Song Liu wrote: > Both libbfd and libopcodes are distributed with binutil-dev/devel. When > libbfd presents, it is OK to assume libopcodes also presents. This has > been a safe assumption for bpftool. > > This patch adds -lopcodes to perf/Makefile.config. libopcodes will be > used in

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stanislav Fomichev
On Tue, Feb 19, 2019 at 5:07 PM Daniel Borkmann wrote: > > On 02/20/2019 01:41 AM, Alexei Starovoitov wrote: > > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > > wrote: > >> > >> Hi all, > >> > >> Today's linux-next merge of the net-next tree got a conflict in: > >> > >>

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stanislav Fomichev
On Tue, Feb 19, 2019 at 4:41 PM Alexei Starovoitov wrote: > > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > wrote: > > > > Hi all, > > > > Today's linux-next merge of the net-next tree got a conflict in: > > > > tools/testing/selftests/bpf/test_progs.c > > > > between commit: > > > >

Re: bpf: BPF_PROG_TEST_RUN leads to unkillable process

2019-02-04 Thread Stanislav Fomichev
eee1515d Mon Sep 17 00:00:00 2001 Message-Id: From: Stanislav Fomichev Date: Mon, 4 Feb 2019 09:17:37 -0800 Subject: [PATCH bpf] bpf/test_run: properly handle signal_pending Syzbot found out that running BPF_PROG_TEST_RUN with repeat=0x makes process unkillable. Let's move signal_pending out of

Re: BUG: vnet0 selects TX queue 11, but real number of TX queues is 11

2019-01-29 Thread Stanislav Fomichev
is: > ---8<--- > > > > > > > > > ---8<--- > > Doing a git-bisect with 4.20.3 last known good, and 4.20.4 as bad, this > commit turned up: > ---8<--- > commit 9ff0436e2c3575ffe64d359fb3b67aee237dc519 > Author: Stanisla

[tip:perf/urgent] perf build: Don't unconditionally link the libbfd feature test to -liberty and -lz

2019-01-03 Thread tip-bot for Stanislav Fomichev
Commit-ID: 14541b1e7e723859ff2c75c6fc10cdbbec6b8c34 Gitweb: https://git.kernel.org/tip/14541b1e7e723859ff2c75c6fc10cdbbec6b8c34 Author: Stanislav Fomichev AuthorDate: Thu, 15 Nov 2018 16:32:01 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Dec 2018 09:42:46 -0300 perf

Re: [PATCH] perf build: fix -lbfd feature check

2018-12-18 Thread Stanislav Fomichev
On Fri, Nov 16, 2018 at 5:34 AM Jiri Olsa wrote: > > On Thu, Nov 15, 2018 at 04:32:01PM -0800, Stanislav Fomichev wrote: > > Current libbfd feature test unconditionally links against -liberty and -lz. > > While it's required on some systems (e.g. opensuse), it's complete

[PATCH] perf build: fix -lbfd feature check

2018-11-15 Thread Stanislav Fomichev
l which is currently broken on debian (libbfd feature shows OFF, but we still unconditionally link against -lbfd and it works). Tested on debian with only -lbfd installed (without -liberty); I'd appreciate if somebody on the other systems can test this new detection method. Signed-off-by: Stanislav

[PATCH] perf build: fix -lbfd feature check

2018-11-15 Thread Stanislav Fomichev
l which is currently broken on debian (libbfd feature shows OFF, but we still unconditionally link against -lbfd and it works). Tested on debian with only -lbfd installed (without -liberty); I'd appreciate if somebody on the other systems can test this new detection method. Signed-off-by: Stanislav

Re: [PATCH v3] hrtimers: calculate expires_next after all timers are executed

2015-01-22 Thread Stanislav Fomichev
Hi Thomas, Slightly tested your version (with Vignesh's fixes), no issues so far, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH v3] hrtimers: calculate expires_next after all timers are executed

2015-01-22 Thread Stanislav Fomichev
Hi Thomas, Slightly tested your version (with Vignesh's fixes), no issues so far, thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH v3] hrtimers: calculate expires_next after all timers are executed

2015-01-20 Thread Stanislav Fomichev
without tick interrupt enabled. This eventually leads to RCU stall on that CPU: rcu_gp_kthread is not woken up because there is no tick. This fix runs expired timers first and only then tries to find next expiry time for all clocks. Signed-off-by: Stanislav Fomichev --- include/linux/hrtimer.h

[PATCH v3] hrtimers: calculate expires_next after all timers are executed

2015-01-20 Thread Stanislav Fomichev
without tick interrupt enabled. This eventually leads to RCU stall on that CPU: rcu_gp_kthread is not woken up because there is no tick. This fix runs expired timers first and only then tries to find next expiry time for all clocks. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru

Re: [PATCH v2] hrtimers: calculate expires_next after all timers are executed

2014-12-29 Thread Stanislav Fomichev
No, Thomas didn't yet push the fix. 27.12.2014, 02:34, "Stephen Boyd" : > On 06/22/2014 07:46 AM, Thomas Gleixner wrote: >>>  + for (i = 0; i < HRTIMER_MAX_CLOCK_BASES; i++) { >>>  + ktime_t expires; >>  So this adds the third incarnation of finding the next expiring timer >>  to the code. Not

Re: [PATCH v2] hrtimers: calculate expires_next after all timers are executed

2014-12-29 Thread Stanislav Fomichev
No, Thomas didn't yet push the fix. 27.12.2014, 02:34, Stephen Boyd sb...@codeaurora.org: On 06/22/2014 07:46 AM, Thomas Gleixner wrote:  + for (i = 0; i HRTIMER_MAX_CLOCK_BASES; i++) {  + ktime_t expires;  So this adds the third incarnation of finding the next expiring timer  to the code.

Re: [PATCHv4] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-18 Thread Stanislav Fomichev
tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace/trace_functions_graph.c | 7 3

Re: [PATCHv4] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-18 Thread Stanislav Fomichev
tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace

[tip:perf/core] perf trace: Add pagefault statistics

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: a2ea67d7b5618c868c1fe15a50af71b858d36887 Gitweb: http://git.kernel.org/tip/a2ea67d7b5618c868c1fe15a50af71b858d36887 Author: Stanislav Fomichev AuthorDate: Tue, 8 Jul 2014 22:05:16 +0400 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 8 Jul 2014 15:34:40 -0300 perf

[tip:perf/core] perf timechart: Fix rendering in Firefox

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: f8dda74fb4139f026571b46d8d17f67e75aa157c Gitweb: http://git.kernel.org/tip/f8dda74fb4139f026571b46d8d17f67e75aa157c Author: Stanislav Fomichev AuthorDate: Tue, 8 Jul 2014 20:03:40 +0400 Committer: Jiri Olsa CommitDate: Thu, 10 Jul 2014 00:22:53 +0200 perf timechart: Fix

[tip:perf/core] perf timechart: Implement IO mode

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: b97b59b93d10a54022afb06d5725d7aa55d98dd7 Gitweb: http://git.kernel.org/tip/b97b59b93d10a54022afb06d5725d7aa55d98dd7 Author: Stanislav Fomichev AuthorDate: Tue, 8 Jul 2014 20:03:41 +0400 Committer: Jiri Olsa CommitDate: Thu, 10 Jul 2014 00:22:54 +0200 perf timechart

[tip:perf/core] perf timechart: Conditionally update start_time on fork

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: 962e310af5dff432745ae7494096ed54b752e63e Gitweb: http://git.kernel.org/tip/962e310af5dff432745ae7494096ed54b752e63e Author: Stanislav Fomichev AuthorDate: Tue, 8 Jul 2014 20:03:42 +0400 Committer: Jiri Olsa CommitDate: Thu, 10 Jul 2014 00:22:54 +0200 perf timechart

[tip:perf/core] perf timechart: Add more options to IO mode

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: d243144af0b52fc5164a0823194f29a5979e236c Gitweb: http://git.kernel.org/tip/d243144af0b52fc5164a0823194f29a5979e236c Author: Stanislav Fomichev AuthorDate: Tue, 8 Jul 2014 20:03:43 +0400 Committer: Jiri Olsa CommitDate: Thu, 10 Jul 2014 00:22:54 +0200 perf timechart: Add

[tip:perf/core] perf timechart: Add more options to IO mode

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: d243144af0b52fc5164a0823194f29a5979e236c Gitweb: http://git.kernel.org/tip/d243144af0b52fc5164a0823194f29a5979e236c Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Tue, 8 Jul 2014 20:03:43 +0400 Committer: Jiri Olsa jo...@kernel.org CommitDate: Thu, 10 Jul

[tip:perf/core] perf trace: Add pagefault statistics

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: a2ea67d7b5618c868c1fe15a50af71b858d36887 Gitweb: http://git.kernel.org/tip/a2ea67d7b5618c868c1fe15a50af71b858d36887 Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Tue, 8 Jul 2014 22:05:16 +0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate

[tip:perf/core] perf timechart: Fix rendering in Firefox

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: f8dda74fb4139f026571b46d8d17f67e75aa157c Gitweb: http://git.kernel.org/tip/f8dda74fb4139f026571b46d8d17f67e75aa157c Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Tue, 8 Jul 2014 20:03:40 +0400 Committer: Jiri Olsa jo...@kernel.org CommitDate: Thu, 10 Jul

[tip:perf/core] perf timechart: Implement IO mode

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: b97b59b93d10a54022afb06d5725d7aa55d98dd7 Gitweb: http://git.kernel.org/tip/b97b59b93d10a54022afb06d5725d7aa55d98dd7 Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Tue, 8 Jul 2014 20:03:41 +0400 Committer: Jiri Olsa jo...@kernel.org CommitDate: Thu, 10 Jul

[tip:perf/core] perf timechart: Conditionally update start_time on fork

2014-07-16 Thread tip-bot for Stanislav Fomichev
Commit-ID: 962e310af5dff432745ae7494096ed54b752e63e Gitweb: http://git.kernel.org/tip/962e310af5dff432745ae7494096ed54b752e63e Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Tue, 8 Jul 2014 20:03:42 +0400 Committer: Jiri Olsa jo...@kernel.org CommitDate: Thu, 10 Jul

Re: [PATCHv3] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace/trace_functions_graph.c | 20

Re: [PATCHv2] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
Hi Steven, Did you have some spare time to check why I'm getting triple fault with the jump labels inside function tracers? Or will you just pull my another patch without them? On Thu, Jun 05, 2014 at 11:38:39AM +0400, Stanislav Fomichev wrote: > > You mean inside the function tracers. I

Re: [PATCHv2] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
Hi Steven, Did you have some spare time to check why I'm getting triple fault with the jump labels inside function tracers? Or will you just pull my another patch without them? On Thu, Jun 05, 2014 at 11:38:39AM +0400, Stanislav Fomichev wrote: You mean inside the function tracers. I could

Re: [PATCHv3] tracing: let user specify tracing_thresh after selecting function_graph

2014-07-15 Thread Stanislav Fomichev
tracer we register handler which reinitializes tracer depending on tracing_thresh. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- kernel/trace/trace.c | 65 kernel/trace/trace.h | 2 ++ kernel/trace

[PATCH] perf trace: add pagefault statistics

2014-07-08 Thread Stanislav Fomichev
0.033 0.246 91.00% arch_prctl 1 0.001 0.001 0.001 0.00% Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-07-08 Thread Stanislav Fomichev
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following: In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it. Signed-off-by: Stanislav Fomichev --- tools

[PATCH 4/4] perf timechart: add more options to IO mode

2014-07-08 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c | 75

[PATCH 2/4] perf timechart: implement IO mode

2014-07-08 Thread Stanislav Fomichev
). Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 620 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h | 6 +- 4 files changed

[PATCH v4 0/4] perf timechart io mode

2014-07-08 Thread Stanislav Fomichev
' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix rendering in Firefox perf timechart: implement IO mode perf timechart: conditionally upd

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-07-08 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-07-08 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools

[PATCH v4 0/4] perf timechart io mode

2014-07-08 Thread Stanislav Fomichev
' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf - pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix rendering in Firefox perf timechart: implement IO mode perf timechart: conditionally update

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-07-08 Thread Stanislav Fomichev
-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/util/svghelper.c | 72 ++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c index 6a0a13d07a28..27caf0f45469 100644 --- a/tools

[PATCH 4/4] perf timechart: add more options to IO mode

2014-07-08 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH 2/4] perf timechart: implement IO mode

2014-07-08 Thread Stanislav Fomichev
). Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 620 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h

[PATCH] perf trace: add pagefault statistics

2014-07-08 Thread Stanislav Fomichev
0.033 0.246 91.00% arch_prctl 1 0.001 0.001 0.001 0.00% Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-trace.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/perf/builtin-trace.c b/tools/perf

[tip:perf/core] perf trace: Add perf_event parameter to tracepoint_handler

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 0c82adcf141935b6312593a53f87342dbb12b704 Gitweb: http://git.kernel.org/tip/0c82adcf141935b6312593a53f87342dbb12b704 Author: Stanislav Fomichev AuthorDate: Thu, 26 Jun 2014 20:14:24 +0400 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 26 Jun 2014 16:00:45 -0300 perf

[tip:perf/core] perf trace: Add pagefaults record and replay support

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 1e28fe0a4ff8680d5a0fb84995fd2444dac19cc4 Gitweb: http://git.kernel.org/tip/1e28fe0a4ff8680d5a0fb84995fd2444dac19cc4 Author: Stanislav Fomichev AuthorDate: Thu, 26 Jun 2014 20:14:26 +0400 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 26 Jun 2014 17:43:24 -0300 perf

[tip:perf/core] perf trace: Add support for pagefault tracing

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 598d02c5a07b60e5c824184cdaf697b70f3c452a Gitweb: http://git.kernel.org/tip/598d02c5a07b60e5c824184cdaf697b70f3c452a Author: Stanislav Fomichev AuthorDate: Thu, 26 Jun 2014 20:14:25 +0400 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 26 Jun 2014 16:07:43 -0300 perf

[tip:perf/core] perf trace: Add possibility to switch off syscall events

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: e281a9606d7073c517f2571e83faaff029ddc1cf Gitweb: http://git.kernel.org/tip/e281a9606d7073c517f2571e83faaff029ddc1cf Author: Stanislav Fomichev AuthorDate: Thu, 26 Jun 2014 20:14:28 +0400 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 26 Jun 2014 17:48:07 -0300 perf

[tip:perf/core] perf trace: Add support for pagefault tracing

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 598d02c5a07b60e5c824184cdaf697b70f3c452a Gitweb: http://git.kernel.org/tip/598d02c5a07b60e5c824184cdaf697b70f3c452a Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Thu, 26 Jun 2014 20:14:25 +0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate

[tip:perf/core] perf trace: Add possibility to switch off syscall events

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: e281a9606d7073c517f2571e83faaff029ddc1cf Gitweb: http://git.kernel.org/tip/e281a9606d7073c517f2571e83faaff029ddc1cf Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Thu, 26 Jun 2014 20:14:28 +0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate

[tip:perf/core] perf trace: Add pagefaults record and replay support

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 1e28fe0a4ff8680d5a0fb84995fd2444dac19cc4 Gitweb: http://git.kernel.org/tip/1e28fe0a4ff8680d5a0fb84995fd2444dac19cc4 Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Thu, 26 Jun 2014 20:14:26 +0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate

[tip:perf/core] perf trace: Add perf_event parameter to tracepoint_handler

2014-07-05 Thread tip-bot for Stanislav Fomichev
Commit-ID: 0c82adcf141935b6312593a53f87342dbb12b704 Gitweb: http://git.kernel.org/tip/0c82adcf141935b6312593a53f87342dbb12b704 Author: Stanislav Fomichev stfomic...@yandex-team.ru AuthorDate: Thu, 26 Jun 2014 20:14:24 +0400 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
On Fri, Jun 27, 2014 at 10:53:30AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 27, 2014 at 12:43:07PM +0400, Stanislav Fomichev escreveu: > > > Where is it? > > > usleep (19155), 151 events, 84.4%, 0:

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
> Where is it? > usleep (19155), 151 events, 84.4%, 0:68 faults, 0.000 msec ^^^ maj:min -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
Where is it? usleep (19155), 151 events, 84.4%, 0:68 faults, 0.000 msec ^^^ maj:min -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 4/5] perf trace: add pagefault statistics

2014-06-27 Thread Stanislav Fomichev
On Fri, Jun 27, 2014 at 10:53:30AM -0300, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 27, 2014 at 12:43:07PM +0400, Stanislav Fomichev escreveu: Where is it? usleep (19155), 151 events, 84.4%, 0:68 faults, 0.000 msec

[PATCH v3 0/5] perf trace pagefaults

2014-06-26 Thread Stanislav Fomichev
in|maj]) - separated tracepoint_handler changes into additional patch - separated record/replay into additional patch - other fixes pointed out by Arnaldo Carvalho de Melo Stanislav Fomichev (5): perf trace: add perf_event parameter to tracepoint_handler perf trace: add support for pag

[PATCH 2/5] perf trace: add support for pagefault tracing

2014-06-26 Thread Stanislav Fomichev
): curl/5937 majfault [0x7fa7261978b6] => /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0@0x85288 (d.) 1862866.036 ( 0.000 ms): wget/8460 majfault [__clear_user+0x3f] => 0x659cb4 (?k) Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 37 ++ tools/perf/b

[PATCH 4/5] perf trace: add pagefault statistics

2014-06-26 Thread Stanislav Fomichev
'perf trace' can show summary of events using -S option. This commit also reports number of major/minor pagefault events in this summary. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/builtin-trace.c

[PATCH 1/5] perf trace: add perf_event parameter to tracepoint_handler

2014-06-26 Thread Stanislav Fomichev
It will be used by next pagefault tracing patches in the series. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f954c26de231

[PATCH 3/5] perf trace: add pagefaults record and replay support

2014-06-26 Thread Stanislav Fomichev
Previous commit added live pagefault trace support, this one adds record and replay support. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-trace.c | 63 +- 1 file changed, 45 insertions(+), 18 deletions(-) diff --git a/tools/perf/builtin

[PATCH 5/5] perf trace: add possibility to switch off syscall events

2014-06-26 Thread Stanislav Fomichev
Currently, we may either trace syscalls or syscalls+pagefaults. We'd like to be able to trace *only* pagefaults and this commit implements this feature. Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-trace.txt | 7 tools/perf/builtin-trace.c | 58

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-06-26 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c

[PATCH v5 0/4] perf timechart io mode

2014-06-26 Thread Stanislav Fomichev
into distinct commit - separated --io-xyz options into distinct commit - fixed 'error' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf -> pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix render

[PATCH 4/4] perf timechart: add more options to IO mode

2014-06-26 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c | 75

[PATCH 2/4] perf timechart: implement IO mode

2014-06-26 Thread Stanislav Fomichev
). Signed-off-by: Stanislav Fomichev --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h | 6 +- 4 files changed

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-06-26 Thread Stanislav Fomichev
Firefox doesn't correctly handle cases where we specify number in quotes and have some padding around the number, like the following: In this case, it doesn't draw the figure. This patch removes 'field width' component from fprintf strings to fix it. Signed-off-by: Stanislav Fomichev --- tools

[PATCH 4/4] perf timechart: add more options to IO mode

2014-06-26 Thread Stanislav Fomichev
--io-skip-eagain - don't show EAGAIN errors --io-min-time- make small io bursts visible --io-merge-dist - merge adjacent events Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-timechart.txt | 13 + tools/perf/builtin-timechart.c

[PATCH 2/4] perf timechart: implement IO mode

2014-06-26 Thread Stanislav Fomichev
). Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-timechart.txt | 25 +- tools/perf/builtin-timechart.c | 613 +++- tools/perf/util/svghelper.c | 98 - tools/perf/util/svghelper.h

[PATCH v5 0/4] perf timechart io mode

2014-06-26 Thread Stanislav Fomichev
into distinct commit - separated --io-xyz options into distinct commit - fixed 'error' shadowing - initialized variables in declaration when possible - removed assert usage - fprintf - pr_err - removed wrongly placed __maybe_unused Stanislav Fomichev (4): perf timechart: fix rendering

[PATCH 1/4] perf timechart: fix rendering in Firefox

2014-06-26 Thread Stanislav Fomichev
-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/util/svghelper.c | 72 ++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c index 6a0a13d07a28..27caf0f45469 100644 --- a/tools

[PATCH 3/4] perf timechart: conditionally update start_time on fork

2014-06-26 Thread Stanislav Fomichev
We don't need to overwrite current task start_time on fork, so update it only if it's zero. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-timechart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-timechart.c b/tools

[PATCH 5/5] perf trace: add possibility to switch off syscall events

2014-06-26 Thread Stanislav Fomichev
Currently, we may either trace syscalls or syscalls+pagefaults. We'd like to be able to trace *only* pagefaults and this commit implements this feature. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-trace.txt | 7 tools/perf/builtin-trace.c

[PATCH 3/5] perf trace: add pagefaults record and replay support

2014-06-26 Thread Stanislav Fomichev
Previous commit added live pagefault trace support, this one adds record and replay support. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-trace.c | 63 +- 1 file changed, 45 insertions(+), 18 deletions(-) diff

[PATCH 4/5] perf trace: add pagefault statistics

2014-06-26 Thread Stanislav Fomichev
'perf trace' can show summary of events using -S option. This commit also reports number of major/minor pagefault events in this summary. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-trace.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 1/5] perf trace: add perf_event parameter to tracepoint_handler

2014-06-26 Thread Stanislav Fomichev
It will be used by next pagefault tracing patches in the series. Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/builtin-trace.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c

[PATCH 2/5] perf trace: add support for pagefault tracing

2014-06-26 Thread Stanislav Fomichev
): curl/5937 majfault [0x7fa7261978b6] = /usr/lib/x86_64-linux-gnu/libkrb5.so.26.0.0@0x85288 (d.) 1862866.036 ( 0.000 ms): wget/8460 majfault [__clear_user+0x3f] = 0x659cb4 (?k) Signed-off-by: Stanislav Fomichev stfomic...@yandex-team.ru --- tools/perf/Documentation/perf-trace.txt | 37

[PATCH v3 0/5] perf trace pagefaults

2014-06-26 Thread Stanislav Fomichev
]) - separated tracepoint_handler changes into additional patch - separated record/replay into additional patch - other fixes pointed out by Arnaldo Carvalho de Melo Stanislav Fomichev (5): perf trace: add perf_event parameter to tracepoint_handler perf trace: add support for pagefault tracing

Re: [PATCH v4 0/4] perf timechart io mode

2014-06-25 Thread Stanislav Fomichev
> If the event type does not make sense how can you trust any other field -- > like event size? I don't mean corruption like this. I mean if event ordering is wrong or some event occurs in unexpected place we may just be tolerant and skip it with a warning. -- To unsubscribe from this list: send

  1   2   3   4   >