Re: [PATCH 08/18] xen/pvcalls: implement connect command

2017-05-18 Thread Stefano Stabellini
On Tue, 16 May 2017, Boris Ostrovsky wrote: > >>> + ret = xenbus_map_ring_valloc(dev, >u.connect.ref, 1, ); > >>> + if (ret < 0) { > >>> + sock_release(map->sock); > >>> + kfree(map); > >>> + goto out; > >>> + } > >>> + map->ring = page; > >>> + map->ring_order =

Re: [PATCH 08/18] xen/pvcalls: implement connect command

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:36 PM, Stefano Stabellini wrote: > > Allocate a socket. Keep track of socket <-> ring mappings with a new data > > structure, called sock_mapping. Implement the connect command by calling > > inet_stream_c

Re: [PATCH 08/18] xen/pvcalls: implement connect command

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:36 PM, Stefano Stabellini wrote: > > Allocate a socket. Keep track of socket <-> ring mappings with a new data > > structure, called sock_mapping. Implement the connect command by calling > > inet_stream_c

Re: [PATCH 06/18] xen/pvcalls: handle commands from the frontend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > When the other end notifies us that there are commands to be read > > (pvcalls_back_event), wake up the backend thread to parse the command. > > > > The command ring work

Re: [PATCH 06/18] xen/pvcalls: handle commands from the frontend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > When the other end notifies us that there are commands to be read > > (pvcalls_back_event), wake up the backend thread to parse the command. > > > > The command ring work

Re: [PATCH 07/18] xen/pvcalls: implement socket command

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Just reply with success to the other end for now. Delay the allocation > > of the actual socket to bind and/or connect. > > > > Signed-off-by: Stefano Stabellini &

Re: [PATCH 07/18] xen/pvcalls: implement socket command

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Just reply with success to the other end for now. Delay the allocation > > of the actual socket to bind and/or connect. > > > > Signed-off-by: Stefano Stabellini > &g

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > > > index 86eca19..876e577 100644 > > > --- a/drivers/xen/pvcalls-back.c > > > +++ b/drivers/xen/pvcalls-back.c > > > @@

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > > > index 86eca19..876e577 100644 > > > --- a/drivers/xen/pvcalls-back.c > > > +++ b/drivers/xen/pvcalls-back.c > > > @@

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce a per-frontend data structure named pvcalls_back_priv. It > > contains pointers to the command ring, its event channel, a list of > > active sockets and a tree of pas

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce a per-frontend data structure named pvcalls_back_priv. It > > contains pointers to the command ring, its event channel, a list of > > active sockets and a tree of pas

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > And why are you using a rw semaphore --- I only noticed two instances of use > > and both are writes. > > Yes, this is wrong, legacy from a previous version of the codebase. A > simple spin_lock should suffice for this use

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > And why are you using a rw semaphore --- I only noticed two instances of use > > and both are writes. > > Yes, this is wrong, legacy from a previous version of the codebase. A > simple spin_lock should suffice for this use

Re: [PATCH 04/18] xen/pvcalls: xenbus state handling

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce the code to handle xenbus state changes. > > > > Implement the probe function for the pvcalls backend. Write the > > supported versions, max-page-ord

Re: [PATCH 04/18] xen/pvcalls: xenbus state handling

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce the code to handle xenbus state changes. > > > > Implement the probe function for the pvcalls backend. Write the > > supported versions, max-page-ord

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/write

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/write

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Juergen Gross wrote: > On 15/05/17 22:35, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/writes. > >

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Juergen Gross wrote: > On 15/05/17 22:35, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/writes. > >

[PATCH 04/18] xen/pvcalls: xenbus state handling

2017-05-15 Thread Stefano Stabellini
-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 133 + 1 file changed, 133 insertions(+) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index 4

[PATCH 04/18] xen/pvcalls: xenbus state handling

2017-05-15 Thread Stefano Stabellini
-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 133 + 1 file changed, 133 insertions(+) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index 46a889a..86eca19 100644

[PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-15 Thread Stefano Stabellini
on release). It also has an unbound workqueue to schedule the work of parsing and executing commands on the command ring. pvcallss_lock protects the two lists. In pvcalls_back_global, keep a list of connected frontends. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.

[PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-15 Thread Stefano Stabellini
on release). It also has an unbound workqueue to schedule the work of parsing and executing commands on the command ring. pvcallss_lock protects the two lists. In pvcalls_back_global, keep a list of connected frontends. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr

[PATCH 06/18] xen/pvcalls: handle commands from the frontend

2017-05-15 Thread Stefano Stabellini
for now. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 115 + 1 file changed, 115 insertions(+) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/p

[PATCH 06/18] xen/pvcalls: handle commands from the frontend

2017-05-15 Thread Stefano Stabellini
for now. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 115 + 1 file changed, 115 insertions(+) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index 876e577

[PATCH 01/18] xen: introduce the pvcalls interface header

2017-05-15 Thread Stefano Stabellini
Introduce the C header file which defines the PV Calls interface. It is imported from xen/include/public/io/pvcalls.h. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: konrad.w...@oracle.com CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- include/xen/interface/io/pvc

[PATCH 07/18] xen/pvcalls: implement socket command

2017-05-15 Thread Stefano Stabellini
Just reply with success to the other end for now. Delay the allocation of the actual socket to bind and/or connect. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 31

[PATCH 01/18] xen: introduce the pvcalls interface header

2017-05-15 Thread Stefano Stabellini
Introduce the C header file which defines the PV Calls interface. It is imported from xen/include/public/io/pvcalls.h. Signed-off-by: Stefano Stabellini CC: konrad.w...@oracle.com CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- include/xen/interface/io/pvcalls.h | 117

[PATCH 07/18] xen/pvcalls: implement socket command

2017-05-15 Thread Stefano Stabellini
Just reply with success to the other end for now. Delay the allocation of the actual socket to bind and/or connect. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 31 ++- 1 file changed, 30

[PATCH 11/18] xen/pvcalls: implement accept command

2017-05-15 Thread Stefano Stabellini
to remember the passive socket from which an active socket was created. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 156 + 1 file changed, 156 inse

[PATCH 11/18] xen/pvcalls: implement accept command

2017-05-15 Thread Stefano Stabellini
to remember the passive socket from which an active socket was created. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 156 + 1 file changed, 156 insertions(+) diff --git a/drivers/xen

[PATCH 09/18] xen/pvcalls: implement bind command

2017-05-15 Thread Stefano Stabellini
to it are protected by a lock (the "copy_lock" spinlock). Initialize the workqueue in pvcalls_back_bind. Implement the bind command with inet_bind. The pass_sk_data_ready event handler will be added later. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov.

[PATCH 09/18] xen/pvcalls: implement bind command

2017-05-15 Thread Stefano Stabellini
to it are protected by a lock (the "copy_lock" spinlock). Initialize the workqueue in pvcalls_back_bind. Implement the bind command with inet_bind. The pass_sk_data_ready event handler will be added later. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr..

[PATCH 13/18] xen/pvcalls: implement release command

2017-05-15 Thread Stefano Stabellini
ved the socket from its list. Unmap indexes pages and data rings. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 94 +- 1 file changed, 93 insertions(+), 1

[PATCH 13/18] xen/pvcalls: implement release command

2017-05-15 Thread Stefano Stabellini
ved the socket from its list. Unmap indexes pages and data rings. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 94 +- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/driv

[PATCH 12/18] xen/pvcalls: implement poll command

2017-05-15 Thread Stefano Stabellini
nly support one outstanding poll (or accept) request for every passive socket at any given time. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 70 +- 1 fil

[PATCH 02/18] xen/pvcalls: introduce the pvcalls xenbus backend

2017-05-15 Thread Stefano Stabellini
Introduce a xenbus backend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.

[PATCH 12/18] xen/pvcalls: implement poll command

2017-05-15 Thread Stefano Stabellini
nly support one outstanding poll (or accept) request for every passive socket at any given time. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 70 +- 1 file changed, 69 insertions(+)

[PATCH 02/18] xen/pvcalls: introduce the pvcalls xenbus backend

2017-05-15 Thread Stefano Stabellini
Introduce a xenbus backend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com

[PATCH 16/18] xen/pvcalls: implement read

2017-05-15 Thread Stefano Stabellini
When an active socket has data available, add the relative sock_mapping to the ioworker list, increment the io and read counters, and schedule the ioworker. Implement the read function by reading from the socket, writing the data to the data ring. Set in_error on error. Signed-off-by: Stefano

[PATCH 16/18] xen/pvcalls: implement read

2017-05-15 Thread Stefano Stabellini
When an active socket has data available, add the relative sock_mapping to the ioworker list, increment the io and read counters, and schedule the ioworker. Implement the read function by reading from the socket, writing the data to the data ring. Set in_error on error. Signed-off-by: Stefano

[PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-15 Thread Stefano Stabellini
they are done with a request, they'll remove it from the list. A spinlock is used for protecting the list. Each ioworker is bound to a different cpu to maximize throughput. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/p

[PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-15 Thread Stefano Stabellini
they are done with a request, they'll remove it from the list. A spinlock is used for protecting the list. Each ioworker is bound to a different cpu to maximize throughput. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 64

[PATCH 18/18] xen: introduce a Kconfig option to enable the pvcalls backend

2017-05-15 Thread Stefano Stabellini
Also add pvcalls-back to the Makefile. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/Kconfig | 12 drivers/xen/Makefile | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/xen/Kconfig b/d

[PATCH 18/18] xen: introduce a Kconfig option to enable the pvcalls backend

2017-05-15 Thread Stefano Stabellini
Also add pvcalls-back to the Makefile. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/Kconfig | 12 drivers/xen/Makefile | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index

[PATCH 17/18] xen/pvcalls: implement write

2017-05-15 Thread Stefano Stabellini
, writing it to the socket by calling inet_sendmsg. Set out_error on error. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 80 +- 1 file changed, 79 inse

[PATCH 17/18] xen/pvcalls: implement write

2017-05-15 Thread Stefano Stabellini
, writing it to the socket by calling inet_sendmsg. Set out_error on error. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 80 +- 1 file changed, 79 insertions(+), 1 deletion(-) diff

[PATCH 15/18] xen/pvcalls: introduce the ioworker

2017-05-15 Thread Stefano Stabellini
track of how many outstanding requests we have in total assigned to the ioworker. The ioworker finishes when there are none. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 44

[PATCH 08/18] xen/pvcalls: implement connect command

2017-05-15 Thread Stefano Stabellini
closed (sk_state_change), set in_error to -ENOTCONN and notify the other end, as specified by the protocol. sk_data_ready will be implemented later. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-

[PATCH 15/18] xen/pvcalls: introduce the ioworker

2017-05-15 Thread Stefano Stabellini
track of how many outstanding requests we have in total assigned to the ioworker. The ioworker finishes when there are none. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 44 1 file c

[PATCH 08/18] xen/pvcalls: implement connect command

2017-05-15 Thread Stefano Stabellini
closed (sk_state_change), set in_error to -ENOTCONN and notify the other end, as specified by the protocol. sk_data_ready will be implemented later. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c

[PATCH 00/18] introduce the Xen PV Calls backend

2017-05-15 Thread Stefano Stabellini
and returns a value to the frontend and acts on the function call. For more information about PV Calls, please read: https://xenbits.xen.org/docs/unstable/misc/pvcalls.html I tried to split the source code into small pieces to make it easier to read and understand. Please review! Stefano

[PATCH 10/18] xen/pvcalls: implement listen command

2017-05-15 Thread Stefano Stabellini
Call inet_listen to implement the listen command. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 00/18] introduce the Xen PV Calls backend

2017-05-15 Thread Stefano Stabellini
and returns a value to the frontend and acts on the function call. For more information about PV Calls, please read: https://xenbits.xen.org/docs/unstable/misc/pvcalls.html I tried to split the source code into small pieces to make it easier to read and understand. Please review! Stefano

[PATCH 10/18] xen/pvcalls: implement listen command

2017-05-15 Thread Stefano Stabellini
Call inet_listen to implement the listen command. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers

[PATCH 14/18] xen/pvcalls: disconnect and module_exit

2017-05-15 Thread Stefano Stabellini
Implement backend_disconnect. Call pvcalls_back_release_active on active sockets and pvcalls_back_release_passive on passive sockets. Implement module_exit by calling backend_disconnect on frontend connections. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: boris.

[PATCH 14/18] xen/pvcalls: disconnect and module_exit

2017-05-15 Thread Stefano Stabellini
Implement backend_disconnect. Call pvcalls_back_release_active on active sockets and pvcalls_back_release_passive on passive sockets. Implement module_exit by calling backend_disconnect on frontend connections. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Greg KH wrote: > On Wed, May 03, 2017 at 03:59:15PM -0700, Stefano Stabellini wrote: > > On Wed, 3 May 2017, Boris Ostrovsky wrote: > > > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wr

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Greg KH wrote: > On Wed, May 03, 2017 at 03:59:15PM -0700, Stefano Stabellini wrote: > > On Wed, 3 May 2017, Boris Ostrovsky wrote: > > > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wr

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Boris Ostrovsky wrote: > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > >> On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > >>> On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: > On 02/21/2017

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Boris Ostrovsky wrote: > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > >> On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > >>> On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: > On 02/21/2017

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Stefano Stabellini
On Wed, 26 Apr 2017, Catalin Marinas wrote: > On Wed, Apr 26, 2017 at 10:00:30AM -0700, Stefano Stabellini wrote: > > On Wed, 26 Apr 2017, Catalin Marinas wrote: > > > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > > > On Tue, 2

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Stefano Stabellini
On Wed, 26 Apr 2017, Catalin Marinas wrote: > On Wed, Apr 26, 2017 at 10:00:30AM -0700, Stefano Stabellini wrote: > > On Wed, 26 Apr 2017, Catalin Marinas wrote: > > > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > > > On Tue, 2

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Stefano Stabellini
On Wed, 26 Apr 2017, Catalin Marinas wrote: > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > On Tue, 25 Apr 2017, Julien Grall wrote: > > > On 24/04/17 20:16, Stefano Stabellini wrote: > > > > Given the outstanding regression we n

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Stefano Stabellini
On Wed, 26 Apr 2017, Catalin Marinas wrote: > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > On Tue, 25 Apr 2017, Julien Grall wrote: > > > On 24/04/17 20:16, Stefano Stabellini wrote: > > > > Given the outstanding regression we n

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-25 Thread Stefano Stabellini
On Tue, 25 Apr 2017, Julien Grall wrote: > Hi Stefano, > > On 24/04/17 20:16, Stefano Stabellini wrote: > > Given the outstanding regression we need to fix as soon as possible, > > I'll queue these patches on the xentip tree for 4.12. > > It looks like there i

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-25 Thread Stefano Stabellini
On Tue, 25 Apr 2017, Julien Grall wrote: > Hi Stefano, > > On 24/04/17 20:16, Stefano Stabellini wrote: > > Given the outstanding regression we need to fix as soon as possible, > > I'll queue these patches on the xentip tree for 4.12. > > It looks like there i

Re: [PATCH 3/3 v2] xen: Implement EFI reset_system callback

2017-04-24 Thread Stefano Stabellini
0: deadbeef a7c27470 > [ 37.430190] [< (null)>] (null) > [ 37.434982] [] machine_restart+0x6c/0x70 > [ 37.440550] [] kernel_restart+0x6c/0x78 > [ 37.446030] [] SyS_reboot+0x130/0x228 > [ 37.451337] [] el0_svc_naked+0x24/0x28 > [ 37.456737] Cod

Re: [PATCH 3/3 v2] xen: Implement EFI reset_system callback

2017-04-24 Thread Stefano Stabellini
0: deadbeef a7c27470 > [ 37.430190] [< (null)>] (null) > [ 37.434982] [] machine_restart+0x6c/0x70 > [ 37.440550] [] kernel_restart+0x6c/0x78 > [ 37.446030] [] SyS_reboot+0x130/0x228 > [ 37.451337] [] el0_svc_naked+0x24/0x28 > [

Re: [PATCH 2/3 v2] arm/xen: Consolidate calls to shutdown hypercall in a single helper

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Julien Grall wrote: > Signed-off-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > Changes in v2: > - Patch added > --- > arch/arm/xen/enlighten.c | 16 ++-- &g

Re: [PATCH 2/3 v2] arm/xen: Consolidate calls to shutdown hypercall in a single helper

2017-04-24 Thread Stefano Stabellini
On Mon, 24 Apr 2017, Julien Grall wrote: > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Patch added > --- > arch/arm/xen/enlighten.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > >

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-24 Thread Stefano Stabellini
Hi Russell, Given the outstanding regression we need to fix as soon as possible, I'll queue these patches on the xentip tree for 4.12. Please shout if you disagree. Thank you. - Stefano On Wed, 19 Apr 2017, Stefano Stabellini wrote: > Hello Russell, > > Can I have y

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-24 Thread Stefano Stabellini
Hi Russell, Given the outstanding regression we need to fix as soon as possible, I'll queue these patches on the xentip tree for 4.12. Please shout if you disagree. Thank you. - Stefano On Wed, 19 Apr 2017, Stefano Stabellini wrote: > Hello Russell, > > Can I have y

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

2017-04-19 Thread Stefano Stabellini
Juergen, I have committed this patch to for-linus-4.12 and linux-next, I hope that's OK. Og Wed, 19 Apr 2017, Stefano Stabellini wrote: > On Wed, 19 Apr 2017, Arnd Bergmann wrote: > > All Xen frontends need to select this symbol to avoid a link error: > > > > net/bu

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

2017-04-19 Thread Stefano Stabellini
Juergen, I have committed this patch to for-linus-4.12 and linux-next, I hope that's OK. Og Wed, 19 Apr 2017, Stefano Stabellini wrote: > On Wed, 19 Apr 2017, Arnd Bergmann wrote: > > All Xen frontends need to select this symbol to avoid a link error: > > > > net/bu

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Stefano Stabellini
On Wed, 19 Apr 2017, Juergen Gross wrote: > On 19/04/17 19:25, Stefano Stabellini wrote: > > Hello Russell, > > > > Can I have your acked-by on the following fix (original patch is > > 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? > > Stefano, throu

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Stefano Stabellini
On Wed, 19 Apr 2017, Juergen Gross wrote: > On 19/04/17 19:25, Stefano Stabellini wrote: > > Hello Russell, > > > > Can I have your acked-by on the following fix (original patch is > > 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? > > Stefano, throu

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Stefano Stabellini
Hello Russell, Can I have your acked-by on the following fix (original patch is 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? Thanks, Stefano On Tue, 18 Apr 2017, Catalin Marinas wrote: > On Thu, Apr 13, 2017 at 02:04:21PM -0700, Stefano Stabellini wrote: > > The followi

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Stefano Stabellini
Hello Russell, Can I have your acked-by on the following fix (original patch is 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? Thanks, Stefano On Tue, 18 Apr 2017, Catalin Marinas wrote: > On Thu, Apr 13, 2017 at 02:04:21PM -0700, Stefano Stabellini wrote: > > The followi

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

2017-04-19 Thread Stefano Stabellini
en/9pfs: build 9pfs Xen transport driver") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thank you for the fix! Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > net/9p/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/9p/Kconfig

Re: [PATCH] xen/9pfs: select CONFIG_XEN_XENBUS_FRONTEND

2017-04-19 Thread Stefano Stabellini
en/9pfs: build 9pfs Xen transport driver") > Signed-off-by: Arnd Bergmann Thank you for the fix! Reviewed-by: Stefano Stabellini > --- > net/9p/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/9p/Kconfig b/net/9p/Kconfig > index 3f286f1bd1d3..e6014e0e

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-18 Thread Stefano Stabellini
On Tue, 18 Apr 2017, Juergen Gross wrote: > On 18/04/17 20:37, Stefano Stabellini wrote: > > On Thu, 6 Apr 2017, Juergen Gross wrote: > >> On 06/04/17 18:43, Daniel Kiper wrote: > >>> On Thu, Apr 06, 2017 at 06:22:44PM +0200, Juergen Gross wrote: > >>&

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-18 Thread Stefano Stabellini
On Tue, 18 Apr 2017, Juergen Gross wrote: > On 18/04/17 20:37, Stefano Stabellini wrote: > > On Thu, 6 Apr 2017, Juergen Gross wrote: > >> On 06/04/17 18:43, Daniel Kiper wrote: > >>> On Thu, Apr 06, 2017 at 06:22:44PM +0200, Juergen Gross wrote: > >>&

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-18 Thread Stefano Stabellini
On Thu, 6 Apr 2017, Juergen Gross wrote: > On 06/04/17 18:43, Daniel Kiper wrote: > > On Thu, Apr 06, 2017 at 06:22:44PM +0200, Juergen Gross wrote: > >> On 06/04/17 18:06, Daniel Kiper wrote: > >>> Hi Julien, > >>> > >>> On Thu, Apr 06, 2017 at 04:39:13PM +0100, Julien Grall wrote: > Hi

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-18 Thread Stefano Stabellini
On Thu, 6 Apr 2017, Juergen Gross wrote: > On 06/04/17 18:43, Daniel Kiper wrote: > > On Thu, Apr 06, 2017 at 06:22:44PM +0200, Juergen Gross wrote: > >> On 06/04/17 18:06, Daniel Kiper wrote: > >>> Hi Julien, > >>> > >>> On Thu, Apr 06, 2017 at 04:39:13PM +0100, Julien Grall wrote: > Hi

[PATCH 2/2] xen/arm,arm64: rename __generic_dma_ops to xen_get_dma_ops

2017-04-13 Thread Stefano Stabellini
Now that __generic_dma_ops is a xen specific function, rename it to xen_get_dma_ops. Change all the call sites appropriately. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> CC: li...@armlinux.org.uk CC: catalin.mari...@arm.com CC: will.dea...@arm.com CC: boris.ostrov...@oracle.

[PATCH 2/2] xen/arm,arm64: rename __generic_dma_ops to xen_get_dma_ops

2017-04-13 Thread Stefano Stabellini
Now that __generic_dma_ops is a xen specific function, rename it to xen_get_dma_ops. Change all the call sites appropriately. Signed-off-by: Stefano Stabellini CC: li...@armlinux.org.uk CC: catalin.mari...@arm.com CC: will.dea...@arm.com CC: boris.ostrov...@oracle.com CC: jgr...@suse.com CC

[PATCH 1/2] xen/arm,arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-13 Thread Stefano Stabellini
ops is returned naturally by get_dma_ops. The Xen code can retrieve the original dev->dma_ops from dev_archdata when needed. It also allows us to remove __generic_dma_ops from common headers. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Tested-by: Julien Grall <julien.gr...@arm

[PATCH 1/2] xen/arm,arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-13 Thread Stefano Stabellini
. The Xen code can retrieve the original dev->dma_ops from dev_archdata when needed. It also allows us to remove __generic_dma_ops from common headers. Signed-off-by: Stefano Stabellini Tested-by: Julien Grall Suggested-by: Catalin Marinas CC: li...@armlinux.org.uk CC: catalin.mari..

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-13 Thread Stefano Stabellini
On Thu, 13 Apr 2017, Julien Grall wrote: > Hi Stefano, > > Sorry for the late answer. > > On 12/04/17 00:39, Stefano Stabellini wrote: > > On Tue, 11 Apr 2017, Catalin Marinas wrote: > > > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > &g

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-13 Thread Stefano Stabellini
On Thu, 13 Apr 2017, Julien Grall wrote: > Hi Stefano, > > Sorry for the late answer. > > On 12/04/17 00:39, Stefano Stabellini wrote: > > On Tue, 11 Apr 2017, Catalin Marinas wrote: > > > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > &g

[PATCH] xen/9pfs: initialize len to 0 to detect xenbus_read errors

2017-04-13 Thread Stefano Stabellini
In order to use "len" to check for xenbus_read errors properly, we need to initialize len to 0 before passing it to xenbus_read. Signed-off-by: Stefano Stabellini <stef...@aporeto.com> CC: dan.carpen...@oracle.com CC: jgr...@suse.com CC: boris.ostrov...@oracle.com CC: Eric Van

[PATCH] xen/9pfs: initialize len to 0 to detect xenbus_read errors

2017-04-13 Thread Stefano Stabellini
In order to use "len" to check for xenbus_read errors properly, we need to initialize len to 0 before passing it to xenbus_read. Signed-off-by: Stefano Stabellini CC: dan.carpen...@oracle.com CC: jgr...@suse.com CC: boris.ostrov...@oracle.com CC: Eric Van Hensbergen CC: Ron M

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-11 Thread Stefano Stabellini
On Tue, 11 Apr 2017, Catalin Marinas wrote: > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > On 11/04/17 02:14, Bart Van Assche wrote: > > > On 04/10/17 17:31, Stefano Stabellini wrote: > > >> I think the reason is that, as you can see, if (de

Re: "Consolidate get_dma_ops" breaks Xen on ARM

2017-04-11 Thread Stefano Stabellini
On Tue, 11 Apr 2017, Catalin Marinas wrote: > On Tue, Apr 11, 2017 at 01:43:28PM +0100, Julien Grall wrote: > > On 11/04/17 02:14, Bart Van Assche wrote: > > > On 04/10/17 17:31, Stefano Stabellini wrote: > > >> I think the reason is that, as you can see, if (de

"Consolidate get_dma_ops" breaks Xen on ARM

2017-04-10 Thread Stefano Stabellini
Hi all, Julien Grall (CC'ed) discovered that the following commit breaks Xen on ARM: commit 815dd18788fe0d41899f51b91d0560279cf16b0d Author: Bart Van Assche Date: Fri Jan 20 13:04:04 2017 -0800 treewide: Consolidate get_dma_ops() implementations

"Consolidate get_dma_ops" breaks Xen on ARM

2017-04-10 Thread Stefano Stabellini
Hi all, Julien Grall (CC'ed) discovered that the following commit breaks Xen on ARM: commit 815dd18788fe0d41899f51b91d0560279cf16b0d Author: Bart Van Assche Date: Fri Jan 20 13:04:04 2017 -0800 treewide: Consolidate get_dma_ops() implementations The relevant changes are:

Re: [PATCH v7 0/7] Xen transport for 9pfs frontend driver

2017-04-10 Thread Stefano Stabellini
On Mon, 10 Apr 2017, Juergen Gross wrote: > On 05/04/17 21:03, Stefano Stabellini wrote: > > Hi all, > > > > This patch series implements a new transport for 9pfs, aimed at Xen > > systems. > > > > The transport is based on a traditional Xen frontend a

Re: [PATCH v7 0/7] Xen transport for 9pfs frontend driver

2017-04-10 Thread Stefano Stabellini
On Mon, 10 Apr 2017, Juergen Gross wrote: > On 05/04/17 21:03, Stefano Stabellini wrote: > > Hi all, > > > > This patch series implements a new transport for 9pfs, aimed at Xen > > systems. > > > > The transport is based on a traditional Xen frontend a

Re: [For Linux 4/4] xen/displif: add ABI for para-virtual display

2017-04-07 Thread Stefano Stabellini
On Fri, 7 Apr 2017, Oleksandr Andrushchenko wrote: > On 04/07/2017 07:36 PM, Stefano Stabellini wrote: > > On Fri, 7 Apr 2017, Oleksandr Andrushchenko wrote: > > > Hi, Julien! > > > > > > On 04/07/2017 04:50 PM, Julien Grall wrote: > > > >

<    5   6   7   8   9   10   11   12   13   14   >