[PATCH v2 12/12] w1: fix typo in comment

Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 1326bd52888a..94747eeff0fa 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -1196,7 +1196,7 @@ int w1_process(void *data

[PATCH v2 12/12] w1: fix typo in comment

Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 1326bd52888a..94747eeff0fa 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -1196,7 +1196,7 @@ int w1_process(void *data

[PATCH v2 08/12] w1: improve code-style of struct declarations

Among improving the readability of the struct declarations, this fixes a warning about incorrect brace placement raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1_netlink.h | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff

[PATCH v2 08/12] w1: improve code-style of struct declarations

Among improving the readability of the struct declarations, this fixes a warning about incorrect brace placement raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1_netlink.h | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff

[PATCH v2 00/11] w1: coding style and checkpatch fixes

mode - fixed commit messages to reflect more precisly the checkpatch warnings Steffen Vogel (12): w1: add SPDX identifiers w1: improve code-style by adhering tp 80 columns per line limit w1: add newlines after declarations w1: cleanup whitespaces according to coding style document w1

[PATCH v2 10/12] w1: use pointers instead of types to determine size of allocs

Get size of allocation based on pointer not type. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- drivers/w1/w1_int.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 4cbe1849fbfc..87094d99ccbe 100644 --- a/drivers/w1/w1

[PATCH v2 00/11] w1: coding style and checkpatch fixes

mode - fixed commit messages to reflect more precisly the checkpatch warnings Steffen Vogel (12): w1: add SPDX identifiers w1: improve code-style by adhering tp 80 columns per line limit w1: add newlines after declarations w1: cleanup whitespaces according to coding style document w1

[PATCH v2 10/12] w1: use pointers instead of types to determine size of allocs

Get size of allocation based on pointer not type. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- drivers/w1/w1_int.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 4cbe1849fbfc..87094d99ccbe 100644 --- a/drivers/w1/w1

[PATCH v2 03/12] w1: add newlines after declarations

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 6b3cdc5a09fb..48c20639f75f 100644

[PATCH v2 03/12] w1: add newlines after declarations

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 6b3cdc5a09fb..48c20639f75f 100644

[PATCH v2 01/12] w1: add SPDX identifiers

This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters

[PATCH v2 04/12] w1: cleanup whitespaces according to coding style document

These changes fix several warnings emitted by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 38 +++--- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_io.c | 40 +--- drivers/w1

[PATCH v2 01/12] w1: add SPDX identifiers

This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters

[PATCH v2 04/12] w1: cleanup whitespaces according to coding style document

These changes fix several warnings emitted by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 38 +++--- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_io.c | 40 +--- drivers/w1

[PATCH v2 05/12] w1: use octal numbers instead of macros for file mode

This satifies a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 184df1fe216b..a8ead2350521 100644 --- a/drivers/w1/w1.c

[PATCH v2 09/12] w1: using linux instead of asm prefix for includes

This fixes a warning raised by the checkpatch tool Signed-off-by: Steffen Vogel --- drivers/w1/w1_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 688778cccf65..65384b332a5a 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1

[PATCH v2 02/12] w1: improve code-style by adhering tp 80 columns per line limit

Furthermore indentation of broken lines has been fixed. This fixes several warnings raised by the checkpatch.pl script. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 160 +++- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_int.c

[PATCH v2 06/12] w1: do not log errors about failed memory allocations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index a8ead2350521..cbfc3f7012de 100644

[PATCH v2 05/12] w1: use octal numbers instead of macros for file mode

This satifies a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 184df1fe216b..a8ead2350521 100644 --- a/drivers/w1/w1.c

[PATCH v2 09/12] w1: using linux instead of asm prefix for includes

This fixes a warning raised by the checkpatch tool Signed-off-by: Steffen Vogel --- drivers/w1/w1_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 688778cccf65..65384b332a5a 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1

[PATCH v2 02/12] w1: improve code-style by adhering tp 80 columns per line limit

Furthermore indentation of broken lines has been fixed. This fixes several warnings raised by the checkpatch.pl script. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 160 +++- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_int.c

[PATCH v2 06/12] w1: do not log errors about failed memory allocations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index a8ead2350521..cbfc3f7012de 100644

[PATCH v2 07/12] w1: use __func__ for logging the function name

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 5 +++-- drivers/w1/w1_int.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index cbfc3f7012de..4cbe1849fbfc 100644 --- a/drivers

[PATCH v2 11/12] w1: replace non-standard %LX format-string by %llX

As indicated by checkpatch.pl script. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 87094d99ccbe..1326bd52888a 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -636,7 +636,7

[PATCH v2 07/12] w1: use __func__ for logging the function name

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 5 +++-- drivers/w1/w1_int.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index cbfc3f7012de..4cbe1849fbfc 100644 --- a/drivers

[PATCH v2 11/12] w1: replace non-standard %LX format-string by %llX

As indicated by checkpatch.pl script. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 87094d99ccbe..1326bd52888a 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -636,7 +636,7

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

Hi Joe, v2 of this patch set is almost ready. I reran checkpatch.pl with '--strict'. So more warnings will be fixed by the second version. See my comments below. On Sun, Oct 28, 2018 at 06:52:23PM -0700, Joe Perches wrote: > On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > > T

Re: [PATCH 8/9] w1: fix whitespaces of struct declarations

Hi Joe, v2 of this patch set is almost ready. I reran checkpatch.pl with '--strict'. So more warnings will be fixed by the second version. See my comments below. On Sun, Oct 28, 2018 at 06:52:23PM -0700, Joe Perches wrote: > On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote: > > T

Re: w1: coding style and checkpatch fixes

rvalds wrote: > [ This is not about your patch series per se, only about your email settings ] > > On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote: > > > > This is my first series of patches for the Linux kernel. > > I started by familiarizing myself with coding style and > &

Re: w1: coding style and checkpatch fixes

rvalds wrote: > [ This is not about your patch series per se, only about your email settings ] > > On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote: > > > > This is my first series of patches for the Linux kernel. > > I started by familiarizing myself with coding style and > &

[PATCH 8/9] w1: fix whitespaces of struct declarations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1_netlink.h | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h index 08cbf08f3649..7873eb54352e

[PATCH 8/9] w1: fix whitespaces of struct declarations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1_netlink.h | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h index 08cbf08f3649..7873eb54352e

[PATCH 5/9] w1: use octal numbers instead of macros for file mode

This satifies a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index f64da16dbec9..bad2ee26cd4e 100644 --- a/drivers/w1/w1.c

[PATCH 9/9] w1: using linux instead of asm prefix for includes

This fixes a warning raised by the checkpatch tool Signed-off-by: Steffen Vogel --- drivers/w1/w1_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 283c89708c7c..b18d82cde71e 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1

[PATCH 4/9] w1: cleanup whitespaces according to coding style document

These changes fix several warnings emitted by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 20 +--- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_io.c | 17 + drivers/w1/w1_netlink.c | 2 +- 4 files changed, 20 insertions

[PATCH 7/9] w1: use __func__ for logging the function name

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 3 ++- drivers/w1/w1_int.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index e8ce97e066ec..c790c79352a0 100644 --- a/drivers/w1

[PATCH 1/9] w1: add SPDX identifiers

This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters

[PATCH 2/9] w1: improve coding style by following strict 80 column line limit

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 56 + drivers/w1/w1_int.c | 3 ++- drivers/w1/w1_io.c | 29 +++-- drivers/w1/w1_netlink.c | 16 +- 4 files

[PATCH 5/9] w1: use octal numbers instead of macros for file mode

This satifies a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index f64da16dbec9..bad2ee26cd4e 100644 --- a/drivers/w1/w1.c

[PATCH 9/9] w1: using linux instead of asm prefix for includes

This fixes a warning raised by the checkpatch tool Signed-off-by: Steffen Vogel --- drivers/w1/w1_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c index 283c89708c7c..b18d82cde71e 100644 --- a/drivers/w1/w1_io.c +++ b/drivers/w1

[PATCH 4/9] w1: cleanup whitespaces according to coding style document

These changes fix several warnings emitted by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 20 +--- drivers/w1/w1_family.c | 2 +- drivers/w1/w1_io.c | 17 + drivers/w1/w1_netlink.c | 2 +- 4 files changed, 20 insertions

[PATCH 7/9] w1: use __func__ for logging the function name

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 3 ++- drivers/w1/w1_int.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index e8ce97e066ec..c790c79352a0 100644 --- a/drivers/w1

[PATCH 1/9] w1: add SPDX identifiers

This satisfies a checkpatch warning and is the preferred method for notating the license. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. Signed-off-by: Steffen Vogel --- drivers/w1/masters/ds1wm.c | 5 + drivers/w1/masters

[PATCH 2/9] w1: improve coding style by following strict 80 column line limit

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 56 + drivers/w1/w1_int.c | 3 ++- drivers/w1/w1_io.c | 29 +++-- drivers/w1/w1_netlink.c | 16 +- 4 files

w1: coding style and checkpatch fixes

Hi, This is my first series of patches for the Linux kernel. I started by familiarizing myself with coding style and satisfying my inner OCD by cleaning the 1-wire subsystem. Steffen

[PATCH 6/9] w1: do not log errors about failed memory allocations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bad2ee26cd4e..e8ce97e066ec 100644

[PATCH 3/9] w1: add newlines after declarations

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bd95dfe4041d..812186ce35d6 100644

w1: coding style and checkpatch fixes

Hi, This is my first series of patches for the Linux kernel. I started by familiarizing myself with coding style and satisfying my inner OCD by cleaning the 1-wire subsystem. Steffen

[PATCH 6/9] w1: do not log errors about failed memory allocations

This fixes a warning raised by the checkpatch tool. Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 7 +-- drivers/w1/w1_int.c | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bad2ee26cd4e..e8ce97e066ec 100644

[PATCH 3/9] w1: add newlines after declarations

This satisfies a checkpatch warning Signed-off-by: Steffen Vogel --- drivers/w1/w1.c | 23 +++ drivers/w1/w1_netlink.c | 7 +++ 2 files changed, 30 insertions(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bd95dfe4041d..812186ce35d6 100644