Re: [PATCH V3 2/2] clk: vc5: Add support for optional load capacitance

2021-02-11 Thread Stephen Boyd
Quoting Adam Ford (2021-02-07 10:51:39) > There are two registers which can set the load capacitance for > XTAL1 and XTAL2. These are optional registers when using an > external crystal. Parse the device tree and set the > corresponding registers accordingly. > > Signed-off-by: Adam Ford > ---

Re: [PATCH V3 1/2] dt-bindings: clk: versaclock5: Add optional load capacitance property

2021-02-11 Thread Stephen Boyd
Quoting Adam Ford (2021-02-07 10:51:38) > There are two registers which can set the load capacitance for > XTAL1 and XTAL2. These are optional registers when using an > external crystal. Since XTAL1 and XTAL2 will set to the same value, > update the binding to support a single property called >

Re: [PATCH 21/21] clk: zynqmp: divider: Add missing description for 'max_div'

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:40) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member > 'max_div' not described in 'zynqmp_clk_divider' > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: M

Re: [PATCH 17/21] clk: clk-xgene: Add description for 'mask' and fix formatting for 'flags'

2021-02-11 Thread Stephen Boyd
r member 'flags' > not described in 'xgene_clk_pmd' > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Loc Ho > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 19/21] clk: spear: Move prototype to accessible header

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:38) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/spear/spear1310_clock.c:385:13: warning: no previous prototype > for ‘spear1310_clk_init’ [-Wmissing-prototypes] > drivers/clk/spear/spear1340_clock.c:442:13: warning: no previous

Re: [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:37) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/qcom/clk-rpm.c:453:29: warning: ‘clk_rpm_branch_ops’ defined but > not used [-Wunused-const-variable=] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael

Re: [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'

2021-02-11 Thread Stephen Boyd
:77:32: warning: > ‘mmcc_xo_mmpll0_1_2_gpll0_map’ defined but not used [-Wunused-const-variable=] > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 15/21] clk: clk-npcm7xx: Remove unused static const tables 'npcm7xx_gates' and 'npcm7xx_divs_fx'

2021-02-11 Thread Stephen Boyd
but not > used [-Wunused-const-variable=] > > Cc: Avi Fishman > Cc: Tomer Maimon > Cc: Tali Perry > Cc: Patrick Venture > Cc: Nancy Yuen > Cc: Benjamin Fair > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Nuvoton Technologies > Cc: open...@lists.ozla

Re: [PATCH 14/21] clk: clk-fixed-mmio: Demote obvious kernel-doc abuse

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:33) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/clk-fixed-mmio.c:62: warning: Function parameter or member > 'pdev' not described in 'of_fixed_mmio_clk_probe' > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc

Re: [PATCH 10/21] clk: ti: dpll44xx: Fix some potential doc-rot

2021-02-11 Thread Stephen Boyd
xen_round_rate' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-o...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'

2021-02-11 Thread Stephen Boyd
> Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 09/21] clk: tegra: cvb: Provide missing description for 'tegra_cvb_add_opp_table()'s align param

2021-02-11 Thread Stephen Boyd
t; Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 07/21] clk: tegra: clk-tegra30: Remove unused variable 'reg'

2021-02-11 Thread Stephen Boyd
riable] > > Cc: Peter De Schrijver > Cc: Prashant Gaikwad > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-...@vger.kernel.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param

2021-02-11 Thread Stephen Boyd
Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 03/21] clk: ti: dpll3xxx: Fix some kernel-doc headers and promote other worthy ones

2021-02-11 Thread Stephen Boyd
> 'parent_rate' not described in 'omap3_clkoutx2_recalc' > drivers/clk/ti/dpll3xxx.c:755: warning: Excess function parameter 'clk' > description in 'omap3_clkoutx2_recalc' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-o...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 02/21] clk: ti: clkt_dpll: Fix some kernel-doc misdemeanours

2021-02-11 Thread Stephen Boyd
meter or member > 'parent_rate' not described in 'omap2_dpll_round_rate' > drivers/clk/ti/clkt_dpll.c:284: warning: Excess function parameter 'clk' > description in 'omap2_dpll_round_rate' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Richard Woodruff

Re: [PATCH 01/21] clk: zynq: pll: Fix kernel-doc formatting in 'clk_register_zynq_pll's header

2021-02-11 Thread Stephen Boyd
_register_zynq_pll' > drivers/clk/zynq/pll.c:187: warning: Function parameter or member > 'lock_index' not described in 'clk_register_zynq_pll' > drivers/clk/zynq/pll.c:187: warning: Function parameter or member 'lock' not > described in 'clk_register_zynq_pll' > > Cc: Michael T

Re: [PATCH 20/20] clk: zynq: clkc: Remove various instances of an unused variable 'clk'

2021-02-11 Thread Stephen Boyd
set but not used > [-Wunused-but-set-variable] > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: linux-...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 16/20] clk: ti: gate: Fix possible doc-rot in 'omap36xx_gate_clk_enable_with_hsdiv_restore'

2021-02-11 Thread Stephen Boyd
ction parameter 'clk' > description in 'omap36xx_gate_clk_enable_with_hsdiv_restore' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-o...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 19/20] clk: versatile: clk-icst: Fix worthy struct documentation block

2021-02-11 Thread Stephen Boyd
rning: cannot understand function > prototype: 'const struct icst_params icst525_apcp_cm_params = ' > > Cc: Linus Walleij > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 15/20] clk: ti: dpll: Fix misnaming of '_register_dpll()'s 'user' parameter

2021-02-11 Thread Stephen Boyd
> description in '_register_dpll' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-o...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 13/20] clk: ti: clockdomain: Fix description for 'omap2_init_clk_clkdm's hw param

2021-02-11 Thread Stephen Boyd
parameter 'clk' > description in 'omap2_init_clk_clkdm' > > Cc: Tero Kristo > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-o...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 12/20] clk: st: clkgen-fsyn: Fix worthy struct documentation demote partially filled one

2021-02-11 Thread Stephen Boyd
s/clk/st/clkgen-fsyn.c:466: warning: Function parameter or member 'pe' > not described in 'st_clk_quadfs_fsynth' > drivers/clk/st/clkgen-fsyn.c:466: warning: Function parameter or member > 'sdiv' not described in 'st_clk_quadfs_fsynth' > > Cc: Michael Turquette > Cc: Stephen B

Re: [PATCH 11/20] clk: st: clkgen-pll: Demote unpopulated kernel-doc header

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-20 01:30:31) > And remove an incorrect entry. > > Fixes the following W=1 kernel build warning(s): > > drivers/clk/st/clkgen-pll.c:142: warning: cannot understand function > prototype: 'struct clkgen_pll ' > > Cc: Michael Turquette > Cc:

Re: [PATCH 09/20] clk: mvebu: ap-cpu-clk: Demote non-conformant kernel-doc header

2021-02-11 Thread Stephen Boyd
ction parameter or member > 'ratio_state_offset' not described in 'cpu_dfs_regs' > drivers/clk/mvebu/ap-cpu-clk.c:52: warning: Function parameter or member > 'ratio_state_cluster_offset' not described in 'cpu_dfs_regs' > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Julia Lawal

Re: [PATCH 08/20] clk: socfpga: clk-pll-a10: Remove set but unused variable 'rc'

2021-02-11 Thread Stephen Boyd
] > > Cc: Dinh Nguyen > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 07/20] clk: socfpga: clk-pll: Remove unused variable 'rc'

2021-02-11 Thread Stephen Boyd
Cc: Dinh Nguyen > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used

2021-02-11 Thread Stephen Boyd
_fu540’ defined but > not used [-Wunused-const-variable=] > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Pragnesh Patel > Cc: Zong Li > Cc: linux-...@vger.kernel.org > Cc: linux-ri...@lists.infradead.org > Signed-off-by: Lee Jones > --- Applied to clk-next

Re: [PATCH 05/20] clk: bcm: clk-iproc-pll: Demote kernel-doc abuse

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-20 01:30:25) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/bcm/clk-iproc-pll.c:712: warning: Function parameter or member > 'pll' not described in 'iproc_pll_sw_cfg' > > Cc: Michael Turquette > Cc: Stephen Boyd >

Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here

2021-02-11 Thread Stephen Boyd
Quoting Lee Jones (2021-01-26 04:45:27) > Fixes the following W=1 kernel build warning(s): > > drivers/clk/clkdev.c: In function ‘vclkdev_alloc’: > drivers/clk/clkdev.c:173:3: warning: function ‘vclkdev_alloc’ might be a > candidate for ‘gnu_printf’ format attribute

Re: [PATCH V2] opp: Don't ignore clk_get() errors other than -ENOENT

2021-02-11 Thread Stephen Boyd
Quoting Viresh Kumar (2021-01-31 20:22:58) > Not all devices that need to use OPP core need to have clocks, a missing > clock is fine in which case -ENOENT shall be returned by clk_get(). > > Anything else is an error and must be handled properly. > > Reported-by: Dmitry Osipenko >

Re: [PATCH v5 3/4] usb: host: xhci-plat: Create platform device for onboard hubs in probe()

2021-02-11 Thread Stephen Boyd
Quoting Matthias Kaehlcke (2021-02-10 14:20:18) > > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote: > > > > This looks hackish... what if later we have something else than hub? > > Another if()? > > > > What if hub could be connected to something else than XHCI controller?

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

2021-02-11 Thread Stephen Boyd
Quoting Michael Tretter (2021-02-10 23:39:06) > On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote: > > Quoting Colin King (2021-02-10 10:49:38) > > > From: Colin Ian King > > > > > > The pointer 'divider' has previously been null checked followed by >

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-11 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-02-11 06:23:10) > On Wed, Feb 10, 2021 at 04:36:08PM -0800, Stephen Boyd wrote: > > Quoting Greg Kroah-Hartman (2020-12-09 06:51:33) > > > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote: > > > > On Mon, Dec 07, 2020 at

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

2021-02-10 Thread Stephen Boyd
Quoting Colin King (2021-02-10 10:49:38) > From: Colin Ian King > > The pointer 'divider' has previously been null checked followed by > a return, hence the subsequent null check is redundant deadcode > that can be removed. Clean up the code and remove it. > > Fixes: 9c789deea206 ("soc:

Re: [RFC v1] clk: core: support clocks that need to be enabled during re-parent

2021-02-10 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-01-23 10:42:27) > Hi Stephen, > > On Tue, Jun 25, 2019 at 08:52:45PM -0700, Stephen Boyd wrote: > > Quoting Weiyi Lu (2019-06-25 18:05:22) > > > On Tue, 2019-06-25 at 15:14 -0700, Stephen Boyd wrote: > > > > Quoting Weiyi Lu

Re: [PATCH v6 02/15] clk: tegra: Don't enable PLLE HW sequencer at init

2021-02-10 Thread Stephen Boyd
ned-off-by: JC Kuo > Acked-by: Thierry Reding > --- Acked-by: Stephen Boyd

Re: [PATCH v6 01/15] clk: tegra: Add PLLE HW power sequencer control

2021-02-10 Thread Stephen Boyd
driver to enable >PLLE hardware sequencer at proper time. > > 2. tegra210_plle_hw_sequence_is_enabled() for XUSB PADCTL driver to >check whether PLLE hardware sequencer has been enabled or not. > > Signed-off-by: JC Kuo > Acked-by: Thierry Reding > --- Acked-by: Stephen Boyd

Re: [PATCH] clk: socfpga: agilex: add clock driver for eASIC N5X platform

2021-02-10 Thread Stephen Boyd
Quoting Dinh Nguyen (2021-01-05 11:29:56) > Add support for Intel's eASIC N5X platform. The clock manager driver for > the N5X is very similar to the Agilex platform, we can re-use most of > the Agilex clock driver. > > This patch makes the necessary changes for the driver to differentiate >

Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description

2021-02-10 Thread Stephen Boyd
Quoting Daniel Palmer (2021-02-10 18:28:40) > Hi Stephen, > > On Wed, 10 Feb 2021 at 11:29, Stephen Boyd wrote: > > The child clks should be using clk_parent_data to point to the parent > > clks through DT. That way the name of the clk doesn't matter except for > > deb

[PATCH v6 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

2021-02-10 Thread Stephen Boyd
g far away it sets the switch bit to 0. For now this driver exposes a single sensor, but it could be expanded in the future via more MKBP bits if desired. Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Reviewed-by: Enric Balletbo i Serra Signed-off-b

[PATCH v6 2/3] dt-bindings: iio: Add cros ec proximity yaml doc

2021-02-10 Thread Stephen Boyd
Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Cc: Reviewed-by: Rob Herring Cc: Enric Balletbo i Serra Signed-off-by: Stephen Boyd --- .../google,cros-ec-mkbp-proximity.yaml| 37 +++ .../bindings/mfd/google,cros-ec.yaml | 7 2 files changed, 44

[PATCH v6 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define

2021-02-10 Thread Stephen Boyd
Some cros ECs support a front proximity MKBP event via 'EC_MKBP_FRONT_PROXIMITY'. Add this define so it can be used in a future patch. Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Acked-by: Enric Balletbo i Serra Signed-off-by: Stephen Boyd

[PATCH v6 0/3] iio: Add a ChromeOS EC MKBP proximity driver

2021-02-10 Thread Stephen Boyd
* Dropped CONFIG_OF usage * Sorted includes [1] https://lore.kernel.org/r/20201205004709.3126266-1-swb...@chromium.org Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Cc: Cc: Rob Herring Cc: Enric Balletbo i Serra Stephen Boyd (3): platform

Re: [PATCH V3 1/2] dt-bindings: clk: versaclock5: Add optional load capacitance property

2021-02-10 Thread Stephen Boyd
Quoting Adam Ford (2021-02-10 12:40:38) > On Wed, Feb 10, 2021 at 2:18 PM Rob Herring wrote: > > > > On Sun, Feb 07, 2021 at 12:51:38PM -0600, Adam Ford wrote: > > > There are two registers which can set the load capacitance for > > > XTAL1 and XTAL2. These are optional registers when using an >

Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-10 Thread Stephen Boyd
Quoting Maxime Ripard (2021-02-10 02:29:04) > Hi Mike, Stephen, > > On Tue, Feb 09, 2021 at 06:58:56PM +0100, Jernej Skrabec wrote: > > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > > one. Fix that. > > > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent

Re: [PATCH] lkdtm: don't move ctors to .rodata

2021-02-10 Thread Stephen Boyd
which calls into regular instrumentable text section as safe. The instrumentation markers are only active when CONFIG_DEBUG_ENTRY is enabled as the end marker emits a NOP to prevent the compiler from merging the annotation points. This means the objtool verification requires a kernel comp

Re: [PATCH v5 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

2021-02-10 Thread Stephen Boyd
Quoting Gwendal Grignou (2021-02-10 00:29:45) > On Tue, Feb 9, 2021 at 6:51 PM Stephen Boyd wrote: > > + if (event_type == EC_MKBP_EVENT_SWITCH) { > > + data = container_of(nb, struct cros_ec_mkbp_proximity_data, > > +

[PATCH v5 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define

2021-02-09 Thread Stephen Boyd
Some cros ECs support a front proximity MKBP event via 'EC_MKBP_FRONT_PROXIMITY'. Add this define so it can be used in a future patch. Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Acked-by: Enric Balletbo i Serra Signed-off-by: Stephen Boyd

[PATCH v5 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

2021-02-09 Thread Stephen Boyd
g far away it sets the switch bit to 0. For now this driver exposes a single sensor, but it could be expanded in the future via more MKBP bits if desired. Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Reviewed-by: Enric Balletbo i Serra Signed-off-b

[PATCH v5 2/3] dt-bindings: iio: Add cros ec proximity yaml doc

2021-02-09 Thread Stephen Boyd
Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Cc: Cc: Rob Herring Cc: Enric Balletbo i Serra Signed-off-by: Stephen Boyd --- Changes from v4: * Reduced example in iio binding and moved to mfd * Dropped unevaluatedProperties .../google,cros-ec-mkbp-proximity.yaml| 37

[PATCHv5 0/3] iio: Add a ChromeOS EC MKBP proximity driver

2021-02-09 Thread Stephen Boyd
...@chromium.org Cc: Dmitry Torokhov Cc: Benson Leung Cc: Guenter Roeck Cc: Douglas Anderson Cc: Gwendal Grignou Cc: Cc: Rob Herring Cc: Enric Balletbo i Serra Stephen Boyd (3): platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define dt-bindings: iio: Add cros ec proximity yaml doc iio

Re: [PATCH v4 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

2021-02-09 Thread Stephen Boyd
Quoting Stephen Boyd (2021-02-06 19:21:39) > Quoting Jonathan Cameron (2021-02-06 08:17:11) > > On Tue, 2 Feb 2021 10:44:34 -0800 > > Stephen Boyd wrote: > > > > > +static struct platform_driver cros_ec_mkbp_proximity_driver = { > > > + .driver = { &g

Re: [PATCH v4 2/3] dt-bindings: iio: Add cros ec proximity yaml doc

2021-02-09 Thread Stephen Boyd
Quoting Rob Herring (2021-02-09 13:13:47) > On Tue, Feb 02, 2021 at 10:44:33AM -0800, Stephen Boyd wrote: > > +description: Name for proximity sensor > > + > > +required: > > + - compatible > > + > > +unevaluatedProperties: false > > +a

Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description

2021-02-09 Thread Stephen Boyd
Quoting Daniel Palmer (2020-12-21 00:51:56) > Hi Stephen, > > On Mon, 21 Dec 2020 at 03:44, Stephen Boyd wrote: > > > > Quoting Daniel Palmer (2020-12-19 22:35:41) > > > Hi Stephen, > > > > > > On Sun, 20 Dec 2020 at 12:39, Step

Re: [PATCH mvebu v2 06/10] clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0

2021-02-09 Thread Stephen Boyd
gt; > Signed-off-by: Marek Behún > Signed-off-by: Pali Rohár > Fixes: 61c40f35f5cd ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate > from 300Mhz to 1.2GHz") > Cc: sta...@vger.kernel.org > --- Acked-by: Stephen Boyd

Re: [PATCH mvebu v2 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz

2021-02-09 Thread Stephen Boyd
armada-37xx-periph: add DVFS support for > cpu clocks") > Cc: sta...@vger.kernel.org # 61c40f35f5cd ("clk: mvebu: armada-37xx-periph: > Fix switching CPU rate from 300Mhz to 1.2GHz") > --- Acked-by: Stephen Boyd

Re: [PATCH mvebu v2 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock

2021-02-09 Thread Stephen Boyd
After this was fixed in the cpufreq driver, this method is not > needed anymore. > > Signed-off-by: Marek Behún > Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for > cpu clocks") > Cc: Gregory CLEMENT > Cc: Miquel Raynal > --- Acked-by: Stephen Boyd

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-09 Thread Stephen Boyd
Quoting Tudor Ambarus (2021-02-03 07:43:32) > These are all "early clocks" that require initialization just at > of_clk_init() time. Use CLK_OF_DECLARE() to declare them. > > This also fixes a problem that was spotted when fw_devlink was > set to 'on' by default: the boards failed to boot. The

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-09 Thread Stephen Boyd
Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > Hi, Michael, Stephen, > > Do you plan to take this patch for v5.12? > If fw_devlink will remain set to ON for v5.12, some of our boards will > no longer boot without this patch. Is fw_devlink defaulted to on for v5.12?

Re: [PATCH v2 02/14] clk: stm32mp1: merge 'ck_hse_rtc' and 'ck_rtc' into one clock

2021-02-09 Thread Stephen Boyd
Quoting gabriel.fernan...@foss.st.com (2021-01-26 01:01:08) > From: Gabriel Fernandez > > 'ck_rtc' has multiple clocks as input (ck_hsi, ck_lsi, and ck_hse). > A divider is available only on the specific rtc input for ck_hse. > This Merge will facilitate to have a more coherent clock tree > in

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-08 Thread Stephen Boyd
Quoting Saravana Kannan (2021-01-28 09:01:41) > On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus > wrote: > > > > The sama5d2 requires the clock provider initialized before timers. > > We can't use a platform driver for the sama5d2-pmc driver, as the > > platform_bus_init() is called later on, after

Re: [PATCH v3] clk: exynos7: Keep aclk_fsys1_200 enabled

2021-02-08 Thread Stephen Boyd
Quoting (2021-01-31 09:04:28) > This clock must be always enabled to allow access to any registers in > fsys1 CMU. Until proper solution based on runtime PM is applied > (similar to what was done for Exynos5433), fix this by calling > clk_prepare_enable() directly from clock provider driver. > >

Re: [PATCH] clk: mediatek: Select all the MT8183 clocks by default

2021-02-08 Thread Stephen Boyd
Quoting Enric Balletbo i Serra (2021-02-03 02:54:23) > If MT8183 SoC support is enabled, almost all machines will use topckgen, > apmixedsys, infracfg, mcucfg and subsystem clocks, so it feels wrong to > require each one to select that symbols manually. > > Instead, enable it whenever

Re: [PATCH v3 4/4] clk: axi-clkgen: use devm_platform_ioremap_resource() short-hand

2021-02-08 Thread Stephen Boyd
Quoting Alexandru Ardelean (2021-02-01 07:12:45) > No major functional change. Noticed while checking the driver code that > this could be used. > Saves two lines. > > Signed-off-by: Alexandru Ardelean > --- Applied to clk-next

Re: [PATCH v3 3/4] dt-bindings: clock: adi,axi-clkgen: add compatible string for ZynqMP support

2021-02-08 Thread Stephen Boyd
Quoting Alexandru Ardelean (2021-02-01 07:12:44) > The axi-clkgen driver now supports ZynqMP (UltraScale) as well, however the > driver needs to use different PFD & VCO limits. > > For ZynqMP, these needs to be selected by using the > 'adi,zynqmp-axi-clkgen-2.00.a' string. > > Signed-off-by:

Re: [PATCH v3 2/4] clk: clk-axiclkgen: add ZynqMP PFD and VCO limits

2021-02-08 Thread Stephen Boyd
Quoting Alexandru Ardelean (2021-02-01 07:12:43) > For ZynqMP (Ultrascale) the PFD and VCO limits are different. In order to > support these, this change adds a compatible string (i.e. > 'adi,zynqmp-axi-clkgen-2.00.a') which will take into account for these > limits and apply them. > >

Re: [PATCH v3 1/4] clk: axi-clkgen: replace ARCH dependencies with driver deps

2021-02-08 Thread Stephen Boyd
Quoting Alexandru Ardelean (2021-02-01 07:12:42) > The intent is to be able to run this driver to access the IP core in setups > where FPGA board is also connected via a PCIe bus. In such cases the number > of combinations explodes, where the host system can be an x86 with Xilinx >

Re: [PATCH v6 00/22] Mediatek MT8192 clock support

2021-02-08 Thread Stephen Boyd
Quoting Weiyi Lu (2020-12-22 05:09:25) > This series is based on v5.10-rc1. > The DT bindings fail, can you fix and resend? Documentation/devicetree/bindings/arm/mediatek/mediatek,msdc.yaml: 'additionalProperties' is a required property

Re: [PATCH v6 2/4] soc: qcom: Add SoC sleep stats driver

2021-02-08 Thread Stephen Boyd
Quoting Maulik Shah (2021-02-04 06:21:46) > From: Mahesh Sivasubramanian > > Let's add a driver to read the stats from remote processor and > export to debugfs. > > The driver creates "qcom_sleep_stats" directory in debugfs and > adds files for various low power mode available. Below is sample

Re: [PATCH v6 1/4] dt-bindings: Introduce SoC sleep stats bindings

2021-02-08 Thread Stephen Boyd
Quoting Maulik Shah (2021-02-04 06:21:45) > + > +description: > + Always On Processor/Resource Power Manager maintains statistics of the SoC > + sleep modes involving powering down of the rails and oscillator clock. > + > + Statistics includes SoC sleep mode type, number of times low power mode

Re: [PATCH v6 3/4] spmi: mediatek: Add support for MT6873/8192

2021-02-08 Thread Stephen Boyd
Quoting Hsin-Hsiung Wang (2021-02-06 21:19:13) > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > index a53bad541f1a..418848840999 100644 > --- a/drivers/spmi/Kconfig > +++ b/drivers/spmi/Kconfig > @@ -25,4 +25,13 @@ config SPMI_MSM_PMIC_ARB > This is required for communicating

Re: [PATCH v8 11/14] spmi: hisi-spmi-controller: move driver from staging

2021-02-08 Thread Stephen Boyd
Quoting Mauro Carvalho Chehab (2021-01-29 11:51:57) > The Hisilicon 6421v600 SPMI driver is ready for mainstream. > > So, move it from staging. > > Signed-off-by: Mauro Carvalho Chehab > --- Acked-by: Stephen Boyd Rob had some comments on the binding that don't look to be a

Re: [PATCH] spmi: spmi-pmic-arb: Fix hw_irq overflow

2021-02-08 Thread Stephen Boyd
Quoting Subbaraman Narayanamurthy (2021-02-08 11:33:04) > Currently, when handling the SPMI summary interrupt, the hw_irq > number is calculated based on SID, Peripheral ID, IRQ index and > APID. This is then passed to irq_find_mapping() to see if a > mapping exists for this hw_irq and if

Re: [PATCH v7 02/14] clk: tegra: Don't enable PLLE HW sequencer at init

2021-02-08 Thread Stephen Boyd
ned-off-by: JC Kuo > Acked-by: Thierry Reding > --- Acked-by: Stephen Boyd

Re: [PATCH] MAINTAINERS: Add section for NXP i.MX clock drivers

2021-02-08 Thread Stephen Boyd
Quoting Abel Vesa (2021-01-13 04:53:08) > Add a section for NXP i.MX clock drivers and list myself > as the maintainer. > > Signed-off-by: Abel Vesa > --- Applied to clk-next

Re: [PATCH v7 01/14] clk: tegra: Add PLLE HW power sequencer control

2021-02-08 Thread Stephen Boyd
driver to enable >PLLE hardware sequencer at proper time. > > 2. tegra210_plle_hw_sequence_is_enabled() for XUSB PADCTL driver to >check whether PLLE hardware sequencer has been enabled or not. > > Signed-off-by: JC Kuo > Acked-by: Thierry Reding > --- Acked-by: Stephen Boyd

Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

2021-02-08 Thread Stephen Boyd
Quoting Jernej Skrabec (2021-02-08 04:17:48) > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > one. Fix that. > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when > allowed") > Reviewed-by: Chen-Yu Tsai > Tested-by: Andre Heider > Signed-off-by:

Re: [PATCH] drm/msm/dp: Add a missing semi-colon

2021-02-08 Thread Stephen Boyd
Quoting Joe Perches (2021-02-06 21:06:54) > On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote: > > A missing semicolon here causes my external display to stop working. > > Indeed, missing the semicolon on the return statement leads to > > dp_panel_update_tu_timings()

Re: [PATCH v2 11/11] clk: qcom: gpucc-msm8998: Allow fabia gpupll0 rate setting

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:59) > The GPU PLL0 is not a fixed PLL and the rate can be set on it: > this is necessary especially on boards which bootloader is setting > a very low rate on this PLL before booting Linux, which would be > unsuitable for postdividing to reach

Re: [PATCH v2 11/11] clk: qcom: gpucc-msm8998: Allow fabia gpupll0 rate setting

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:59) > The GPU PLL0 is not a fixed PLL and the rate can be set on it: > this is necessary especially on boards which bootloader is setting > a very low rate on this PLL before booting Linux, which would be > unsuitable for postdividing to reach

Re: [PATCH v2 10/11] clk: qcom: gpucc-msm8998: Add resets, cxc, fix flags on gpu_gx_gdsc

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:58) > The GPU GX GDSC has GPU_GX_BCR reset and gfx3d_clk CXC, as stated > on downstream kernels (and as verified upstream, because otherwise > random lockups happen). > Also, add PWRSTS_RET and NO_RET_PERIPH: also as found downstream, > and also

Re: [PATCH v2 09/11] clk: qcom: mmcc-msm8998: Set bimc_smmu_gdsc always on

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:57) > This GDSC enables (or cuts!) power to the Multimedia Subsystem IOMMU > (mmss smmu), which has bootloader pre-set secure contexts. > In the event of a complete power loss, the secure contexts will be > reset and the hypervisor will crash

Re: [PATCH v2 08/11] clk: qcom: mmcc-msm8998: Add hardware clockgating registers to some clks

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:56) > Hardware clock gating is supported on some of the clocks declared in > there: ignoring that it does exist may lead to unstabilities on some > firmwares. > Add the HWCG registers where applicable to stop potential crashes. > > This was

Re: [PATCH v2 07/11] clk: qcom: mmcc-msm8998: Set CLK_GET_RATE_NOCACHE to pixel/byte clks

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:55) > The pixel and byte clocks rate should not be cached, as a VCO shutdown > may clear the frequency setup and this may not be set again due to the > cached rate being present. > This will also be useful when shadow clocks will be implemented

Re: [PATCH v2 07/11] clk: qcom: mmcc-msm8998: Set CLK_GET_RATE_NOCACHE to pixel/byte clks

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:55) > The pixel and byte clocks rate should not be cached, as a VCO shutdown > may clear the frequency setup and this may not be set again due to the > cached rate being present. > This will also be useful when shadow clocks will be implemented

Re: [PATCH v2 05/11] clk: qcom: gcc-msm8998: Mark gpu_cfg_ahb_clk as critical

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:53) > The GPU IOMMU depends on this clock and the hypervisor will crash > the SoC if this clock gets disabled because the secure contexts > that have been set on this IOMMU by the bootloader will become > unaccessible (or they get reset). > Mark

Re: [PATCH v2 06/11] clk: qcom: gcc-msm8998: Fix Alpha PLL type for all GPLLs

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:54) > All of the GPLLs in the MSM8998 Global Clock Controller are Fabia PLLs > and not generic alphas: this was producing bad effects over the entire > clock tree of MSM8998, where any GPLL child clock was declaring a false > clock rate, due to

Re: [PATCH v2 04/11] clk: qcom: gcc-msm8998: Add missing hmss_gpll0_clk_src clock

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:52) > To achieve CPR-Hardened functionality this clock must be on: add it > in order to be able to get it managed by the CPR3 driver. > > Signed-off-by: AngeloGioacchino Del Regno > > --- Applied to clk-next

Re: [PATCH v2 03/11] dt-bindings: clock: gcc-msm8998: Add HMSS_GPLL0_CLK_SRC definition

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:51) > Add new clock definition to gcc-msm8998 dt-bindings > > Signed-off-by: AngeloGioacchino Del Regno > > --- Applied to clk-next

Re: [PATCH v2 02/11] clk: qcom: gcc-msm8998: Wire up gcc_mmss_gpll0 clock

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:50) > This clock enables the GPLL0 output to the multimedia subsystem > clock controller. > > Signed-off-by: AngeloGioacchino Del Regno > > --- Applied to clk-next

Re: [PATCH v2 01/11] dt-bindings: clocks: gcc-msm8998: Add GCC_MMSS_GPLL0_CLK definition

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:49) > Add new clock definition to gcc-msm8998 dt-bindings. > > Signed-off-by: AngeloGioacchino Del Regno > > --- Applied to clk-next

Re: [PATCH v2 05/11] clk: qcom: gcc-msm8998: Mark gpu_cfg_ahb_clk as critical

2021-02-08 Thread Stephen Boyd
Quoting AngeloGioacchino Del Regno (2021-01-14 14:10:53) > The GPU IOMMU depends on this clock and the hypervisor will crash > the SoC if this clock gets disabled because the secure contexts > that have been set on this IOMMU by the bootloader will become > unaccessible (or they get reset). > Mark

Re: [PATCH] clk: qcom: smd-rpm: Add mdm9607 clocks

2021-02-08 Thread Stephen Boyd
Quoting Konrad Dybcio (2021-01-30 17:30:09) > Add support for RPM-managed clocks on the MDM9607 platform. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/clock/qcom,rpmcc.txt | 1 + > drivers/clk/qcom/clk-smd-rpm.c| 32 +++ > 2 files changed,

Re: [PATCH v5 1/5] clk: qcom: clk-alpha-pll: replace regval with val

2021-02-08 Thread Stephen Boyd
Quoting Vinod Koul (2021-01-26 23:08:07) > Driver uses regval variable for holding register values, replace with a > shorter one val > > Suggested-by: Stephen Boyd > Reviewed-by: Bjorn Andersson > Signed-off-by: Vinod Koul > --- Applied to clk-next

Re: [PATCH v5 5/5] clk: qcom: gcc: Add clock driver for SM8350

2021-02-08 Thread Stephen Boyd
Quoting Vinod Koul (2021-01-26 23:08:11) > From: Vivek Aknurwar > > This adds Global Clock controller (GCC) driver for SM8350 SoC > > Signed-off-by: Vivek Aknurwar > Signed-off-by: Jeevan Shriram > [vkoul: rebase and tidy up for upstream] > Signed-off-by: Vinod Koul > Reviewed-by: Bjorn

Re: [PATCH v5 3/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

2021-02-08 Thread Stephen Boyd
Quoting Vinod Koul (2021-01-26 23:08:09) > From: Vivek Aknurwar > > Lucid 5LPE is a slightly different Lucid PLL with different offsets and > porgramming sequence so add support for these > > Signed-off-by: Vivek Aknurwar > Signed-off-by: Jeevan Shriram > [vkoul: rebase and tidy up for

Re: [PATCH v5 2/5] clk: qcom: clk-alpha-pll: modularize alpha_pll_trion_set_rate()

2021-02-08 Thread Stephen Boyd
Quoting Vinod Koul (2021-01-26 23:08:08) > Trion 5LPE set rate uses code similar to alpha_pll_trion_set_rate() but > with different registers. Modularize these by moving out latch and latch > ack bits so that we can reuse the function. > > Suggested-by: AngeloGioacchino Del Regno > >

Re: [PATCH v5 4/5] dt-bindings: clock: Add SM8350 GCC clock bindings

2021-02-08 Thread Stephen Boyd
Quoting Vinod Koul (2021-01-26 23:08:10) > Add device tree bindings for global clock controller on SM8350 SoCs. > > Reviewed-by: Rob Herring > Reviewed-by: Bjorn Andersson > Signed-off-by: Vinod Koul > --- Applied to clk-next

Re: [PATCH v2 2/2] clk: qcom: gcc: Add global clock controller driver for SC8180x

2021-02-08 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-01-25 20:31:55) > Add clocks, resets and some of the GDSC provided by the global clock > controller found in the Qualcomm SC8180x platform. > > Signed-off-by: Bjorn Andersson > --- Applied to clk-next

<    1   2   3   4   5   6   7   8   9   10   >