Re: [PATCH v6] close_range.2: new page documenting close_range(2)

2021-03-22 Thread Stephen Kitt
On Sun, 21 Mar 2021 16:38:59 +0100, "Michael Kerrisk (man-pages)" wrote: > On 3/9/21 8:53 PM, Stephen Kitt wrote: > > On Thu, 28 Jan 2021 21:50:23 +0100, "Michael Kerrisk (man-pages)" > > wrote: > >> Thanks for your patch revision. I've merged it,

Re: [PATCH v6] close_range.2: new page documenting close_range(2)

2021-03-09 Thread Stephen Kitt
Hi Michael, On Thu, 28 Jan 2021 21:50:23 +0100, "Michael Kerrisk (man-pages)" wrote: > Thanks for your patch revision. I've merged it, and have > done some light editing, but I still have a question: Does this need anything more? I don’t see it in the man-pages repo. Regards, Stephen

[PATCH] vgacon: drop unused vga_init_done

2021-02-15 Thread Stephen Kitt
Commit 973c096f6a85 ("vgacon: remove software scrollback support") removed all uses of vga_init_done, so let's get rid of it entirely. Signed-off-by: Stephen Kitt --- drivers/video/console/vgacon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/console/vgacon.c

Re: [PATCH v6] close_range.2: new page documenting close_range(2)

2021-01-28 Thread Stephen Kitt
Hello Michael, On Thu, 28 Jan 2021 21:50:23 +0100, "Michael Kerrisk (man-pages)" wrote: > Thanks for your patch revision. I've merged it, and have > done some light editing, but I still have a question: > > On 1/23/21 5:11 PM, Stephen Kitt wrote: > > [...] >

[PATCH v6] close_range.2: new page documenting close_range(2)

2021-01-23 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de, 60997c3d45d9a67daf01c56d805ae4fec37e0bd8, and 582f1fb6b721facf04848d2ca57f34468da1813e. Signed-off-by: Stephen Kitt --- V6: bit mask, close-on-exec flag language improvements another close(2

Re: [PATCH v5] close_range.2: new page documenting close_range(2)

2020-12-23 Thread Stephen Kitt
Hi Michael, On Tue, 22 Dec 2020 21:36:28 +0100, "Michael Kerrisk (man-pages)" wrote: > On 12/21/20 8:46 PM, Stephen Kitt wrote: [...] > > +Errors closing a given file descriptor are currently ignored. > > +.PP > > +.I flags > > +can be 0 or set to one or bo

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Stephen Kitt
Hi Alex, On Mon, 21 Dec 2020 20:33:06 +0100, "Alejandro Colomar (man-pages)" wrote: > On 12/21/20 8:24 PM, Stephen Kitt wrote: > > On Sat, 19 Dec 2020 15:00:00 +0100, "Alejandro Colomar (man-pages)" > > wrote: > >> On 12/18/20 5:58 PM, Stephen K

[PATCH v5] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de, 60997c3d45d9a67daf01c56d805ae4fec37e0bd8, and 582f1fb6b721facf04848d2ca57f34468da1813e. Signed-off-by: Stephen Kitt --- V5: clarification of the open/close_range/execve sequence V4: sort flags

[PATCH v4] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de, 60997c3d45d9a67daf01c56d805ae4fec37e0bd8, and 582f1fb6b721facf04848d2ca57f34468da1813e. Signed-off-by: Stephen Kitt --- V4: sort flags alphabetically move commit references inside

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Stephen Kitt
Hi Alex, On Sat, 19 Dec 2020 15:00:00 +0100, "Alejandro Colomar (man-pages)" wrote: > On 12/18/20 5:58 PM, Stephen Kitt wrote: [...] > > +This program executes the command given on its command-line after > > +opening the files listed after the command, > > +and

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-20 Thread Stephen Kitt
Hi Alex, On Sat, 19 Dec 2020 15:00:00 +0100, "Alejandro Colomar (man-pages)" wrote: > Please see some comments below. > It's looking good ;) Thanks for your review and patience! > On 12/18/20 5:58 PM, Stephen Kitt wrote: > > This documents close_rang

[PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-18 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de, 60997c3d45d9a67daf01c56d805ae4fec37e0bd8, and 582f1fb6b721facf04848d2ca57f34468da1813e. Signed-off-by: Stephen Kitt --- V3: fix synopsis overflow copy notes from membarrier.2 re the lack

Re: Ping: [patch] close_range.2: new page documenting close_range(2)

2020-12-18 Thread Stephen Kitt
Hi Alex, Le 18/12/2020 11:12, Alejandro Colomar (man-pages) a écrit : Linux 5.10 has been recently released. Do you have any updates for this patch? Yes, I have a v3 in preparation, with _CLOEXEC and a code example. I'll wrap it up today. Regards, Stephen

Re: [PATCH v2] close_range.2: new page documenting close_range(2)

2020-12-10 Thread Stephen Kitt
Hi Alejandro, On Thu, 10 Dec 2020 01:24:28 +0100, "Alejandro Colomar (man-pages)" wrote: > A few more comments below. Thanks for all the detailed reviews! (Same goes to everyone reviewing this yesterday, thanks for helping turn my not-so-great attempt into something really useful.) > Michael,

[PATCH v2] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de and 60997c3d45d9a67daf01c56d805ae4fec37e0bd8. Signed-off-by: Stephen Kitt --- V2: unsigned int to match the kernel declarations groff and grammar tweaks CLOSE_RANGE_UNSHARE unshares

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Stephen Kitt
Le 09/12/2020 10:40, Christian Brauner a écrit : On Wed, Dec 09, 2020 at 09:50:38AM +0100, Michael Kerrisk (man-pages) wrote: > +.PP > +.I flags > +can be set to > +.B CLOSE_RANGE_UNSHARE > +to unshare the range of file descriptors from any other processes, > +.I instead > +of closing them.

[patch] close_range.2: new page documenting close_range(2)

2020-12-08 Thread Stephen Kitt
This documents close_range(2) based on information in 278a5fbaed89dacd04e9d052f4594ffd0e0585de and 60997c3d45d9a67daf01c56d805ae4fec37e0bd8. Signed-off-by: Stephen Kitt --- man2/close_range.2 | 112 + 1 file changed, 112 insertions(+) create mode

[PATCH] docs: clean up sysctl/kernel: titles, version

2020-12-08 Thread Stephen Kitt
This cleans up a few titles with extra colons, and removes the reference to kernel 2.2. The docs don't yet cover *all* of 5.10 or 5.11, but I think they're close enough. Most entries are documented, and have been checked against current kernels. Signed-off-by: Stephen Kitt --- Documentation

Re: [PATCH] docs: rewrite admin-guide/sysctl/abi.rst

2020-09-17 Thread Stephen Kitt
On Wed, 16 Sep 2020 12:43:10 -0600, Jonathan Corbet wrote: > On Fri, 11 Sep 2020 21:01:52 +0200 > Stephen Kitt wrote: > > Following the structure used in sysctl/kernel.rst, this updates > > abi.rst to use ReStructured Text more fully and updates the entries to > &g

[PATCH v2] docs: rewrite admin-guide/sysctl/abi.rst

2020-09-17 Thread Stephen Kitt
the existing entries are no longer present, so this removes them; * document vsyscall32. Mentions of the kernel version are dropped. Since the document is entirely rewritten, I've replaced the copyright statement. Signed-off-by: Stephen Kitt --- Changes since v1: - added SPDX-License-Identifier

Re: [PATCH] Fix references to nommu-mmap.rst

2020-09-11 Thread Stephen Kitt
Hi, This is still relevant as far as I can tell; master and docs-next still have references to the old nommu-mmap.rst. Regards, Stephen On Wed, 12 Aug 2020 11:22:30 +0200, Stephen Kitt wrote: > nommu-mmap.rst was moved to Documentation/admin-guide/mm; this patch > updates the remaining

[PATCH] docs: rewrite admin-guide/sysctl/abi.rst

2020-09-11 Thread Stephen Kitt
the existing entries are no longer present, so this removes them; * document vsyscall32. Mentions of the kernel version are dropped. Since the document is entirely rewritten, I've replaced the copyright statement. Signed-off-by: Stephen Kitt --- Documentation/admin-guide/sysctl/abi.rst | 71

[PATCH] hwmon: use simple i2c probe function

2020-08-21 Thread Stephen Kitt
use the id are converted as-is; drivers which did are modified to call i2c_match_id() with the same level of error-handling (if any) as before. This patch wraps up the transition for hwmon, with four stragglers not included in the previous large patch. Signed-off-by: Stephen Kitt --- drivers/hwmon/adc128

[PATCH] hwmon: (f75375s) use simple i2c probe

2020-08-21 Thread Stephen Kitt
As part of the ongoing i2c transition to the simple probe ("probe_new"), this patch uses i2c_match_id to retrieve the driver_data for the probed device. The id parameter is thus no longer necessary and the simple probe can be used instead. Signed-off-by: Stephen Kitt --- drivers/hwmon

[PATCH] hwmon: (tmp513) use simple i2c probe

2020-08-21 Thread Stephen Kitt
As part of the ongoing i2c transition to the simple probe ("probe_new"), this patch uses i2c_match_id to retrieve the driver_data for the probed device. The id parameter is thus no longer necessary and the simple probe can be used instead. Signed-off-by: Stephen Kitt --- drivers/hwmo

[PATCH] hwmon: (dme1737) use simple i2c probe

2020-08-21 Thread Stephen Kitt
As part of the ongoing i2c transition to the simple probe ("probe_new"), this patch uses i2c_match_id to retrieve the driver_data for the probed device. The id parameter is thus no longer necessary and the simple probe can be used instead. Signed-off-by: Stephen Kitt --- drivers/hwmon

Re: [PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

2020-08-21 Thread Stephen Kitt
On Fri, 14 Aug 2020 08:13:58 -0700, Guenter Roeck wrote: > On Thu, Aug 13, 2020 at 06:09:58PM +0200, Stephen Kitt wrote: > > This driver doesn't use the id information provided by the old i2c > > probe function, so it can trivially be converted to the simple > &g

[PATCH] drivers/hwmon/ltc2947-i2c.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/ltc2947-i2c.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH] hwmon: use simple i2c probe function

2020-08-13 Thread Stephen Kitt
in this patch because they have a different set of maintainers. They will be covered by other patches. Signed-off-by: Stephen Kitt --- drivers/hwmon/ad7414.c | 5 ++--- drivers/hwmon/ad7418.c | 9 + drivers/hwmon/adm1021.c | 9 + drivers/hwmon/adm1025.c | 5 +

[PATCH] drivers/hwmon/asc7621.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/asc7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] drivers/hwmon/lm73.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/lm73.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hw

[PATCH] drivers/hwmon/adm1177.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/adm1177.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH] drivers/hwmon/emc2103.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/emc2103.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] drivers/hwmon/w83791d.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/w83791d.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH] drivers/hwmon/w83793.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/w83793.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH] drivers/hwmon/adm1029.c: use simple i2c probe

2020-08-13 Thread Stephen Kitt
This driver doesn't use the id information provided by the old i2c probe function, so it can trivially be converted to the simple ("probe_new") form. Signed-off-by: Stephen Kitt --- drivers/hwmon/adm1029.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH] Fix references to nommu-mmap.rst

2020-08-12 Thread Stephen Kitt
nommu-mmap.rst was moved to Documentation/admin-guide/mm; this patch updates the remaining stale references to Documentation/mm. Fixes: 800c02f5d030 ("docs: move nommu-mmap.txt to admin-guide and rename to ReST") Signed-off-by: Stephen Kitt --- init/Kconfig | 2 +- mm/Kconfig

[PATCH v2] ARM: davinci: use simple i2c probe function

2020-08-09 Thread Stephen Kitt
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt --- Changes since v1:

Re: [PATCH] arch/arm: use simple i2c probe function

2020-08-09 Thread Stephen Kitt
Hi, On Sun, 9 Aug 2020 10:38:58 +0200, Krzysztof Kozlowski wrote: > On Fri, Aug 07, 2020 at 05:31:00PM +0200, Stephen Kitt wrote: > > The i2c probe functions here don't use the id information provided in > > their second argument, so the single-parameter i2c probe function > &

[PATCH v2] ARM: s3c64xx: use simple i2c probe function

2020-08-09 Thread Stephen Kitt
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt --- Changes since v1:

[PATCH v5] hwmon/pmbus: use simple i2c probe function

2020-08-08 Thread Stephen Kitt
onger assumes that the driver_data is an index into ltc2978_id. Signed-off-by: Stephen Kitt --- Changes since v1: - i2c_device_id declarations are left unchanged; - all drivers are converted, using client info or i2c_match_id(). Changes since v2: - updated the documentation; - fixed unbalanced

[PATCH v4] hwmon/pmbus: use simple i2c probe function

2020-08-08 Thread Stephen Kitt
onger assumes that the driver_data is an index into ltc2978_id. Signed-off-by: Stephen Kitt --- Changes since v1: - i2c_device_id declarations are left unchanged; - all drivers are converted, using client info or i2c_match_id(). Changes since v2: - updated the documentation; - fixed unbalanced

Re: [PATCH v3] hwmon/pmbus: use simple i2c probe function

2020-08-08 Thread Stephen Kitt
On Fri, 7 Aug 2020 21:07:07 +0200, Stephen Kitt wrote: > On Fri, 7 Aug 2020 10:32:31 -0700, Guenter Roeck wrote: > > On Fri, Aug 07, 2020 at 06:28:01PM +0200, Stephen Kitt wrote: > > > > > > -static int ltc2978_probe(struct i2c_client *client, > >

Re: [PATCH v3] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
On Fri, 7 Aug 2020 10:32:31 -0700, Guenter Roeck wrote: > On Fri, Aug 07, 2020 at 06:28:01PM +0200, Stephen Kitt wrote: > > > > -static int ltc2978_probe(struct i2c_client *client, > > -const struct i2c_device_id *id) > > +static int ltc2978_prob

Re: [PATCH v2] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
On Fri, 7 Aug 2020 08:23:29 -0700, Guenter Roeck wrote: > On 8/7/20 12:45 AM, Stephen Kitt wrote: > > pmbus_do_probe doesn't use the id information provided in its second > > argument, so this can be removed, which then allows using the > > single-parameter i2c probe

[PATCH v3] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
volves strcmp but is still cheaper than comparing all the device names when scanning the tables; * anything else is handled by calling i2c_match_id() with the same level of error-handling (if any) as before. Signed-off-by: Stephen Kitt --- Changes since v1: - i2c_device_id declarations are left uncha

[PATCH] arch/arm: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt --- arch/arm/mach-dav

[PATCH] arch/powerpc: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt --- arch/powerpc/platforms/

[PATCH v2] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
volves strcmp but is still cheaper than comparing all the device names when scanning the tables; * anything else is handled by calling i2c_match_id() with the same level of error-handling (if any) as before. Signed-off-by: Stephen Kitt --- Changes since v1: - i2c_device_id declarations are left uncha

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
On Thu, 6 Aug 2020 14:48:58 -0700, Guenter Roeck wrote: > On 8/6/20 1:12 PM, Stephen Kitt wrote: > > On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck > > wrote: > >> On 8/6/20 9:16 AM, Stephen Kitt wrote: [...] > >> Also, I am not convinced that replacemen

Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

2020-08-06 Thread Stephen Kitt
Hi Jon, You’ll see v2 of this patch show up soon, see the context below — this is a patch on top of Mauro’s conversion of the i2c docs to .rst. Regards, Stephen On Thu, 6 Aug 2020 10:33:56 +0200, Wolfram Sang wrote: > > > Maybe because I don't have the commit in my tree? Can you rebase on

Re: [PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Stephen Kitt
On Thu, 6 Aug 2020 12:15:55 -0700, Guenter Roeck wrote: > On 8/6/20 9:16 AM, Stephen Kitt wrote: > > pmbus_do_probe doesn't use the id information provided in its second > > argument, so this can be removed, which then allows using the > > single-parameter i2c probe

[PATCH] hwmon/pmbus: use simple i2c probe function

2020-08-06 Thread Stephen Kitt
ing probes. Additionally, in cases where the id information (driver_data) isn't used, the corresponding declarations are removed from the id_table, and .name is specified explicitly. Signed-off-by: Stephen Kitt --- drivers/hwmon/pmbus/bel-pfe.c | 2 +- drivers/hwmon/pmbus/ibm-cffps.c| 2 +

[PATCH v2] docs: remove the 2.6 "Upgrading I2C Drivers" guide

2020-08-06 Thread Stephen Kitt
All the drivers have long since been upgraded, and all the important information here is also included in the "Implementing I2C device drivers" guide. Signed-off-by: Stephen Kitt --- Documentation/i2c/index.rst | 1 - Documentation/i2c/upgrading-clients

Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

2020-08-06 Thread Stephen Kitt
Hi Wolfram, On Wed, 5 Aug 2020 23:53:51 +0200, Wolfram Sang wrote: > On Wed, Aug 05, 2020 at 08:31:49PM +0200, Stephen Kitt wrote: > > All the drivers have long since been upgraded, and all the important > > information here is also included in the "Implementing I2C devic

[PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

2020-08-05 Thread Stephen Kitt
All the drivers have long since been upgraded, and all the important information here is also included in the "Implementing I2C device drivers" guide. Signed-off-by: Stephen Kitt --- Documentation/i2c/upgrading-clients.rst | 285 1 file changed, 285 deletions(

Re: [PATCH] docs: process/index.rst: Fix reference to nonexistent document

2020-07-20 Thread Stephen Kitt
wrong. > > Signed-off-by: Daniel W. S. Almeida Fixes: c9b54d6f362c ("docs: move other kAPI documents to core-api") Reviewed-by: Stephen Kitt pgpWZ1bKPx1pE.pgp Description: OpenPGP digital signature

[PATCH] docs: sysctl/kernel: document random

2020-06-23 Thread Stephen Kitt
This documents the random directory, based on the behaviour seen in drivers/char/random.c. Signed-off-by: Stephen Kitt --- Documentation/admin-guide/sysctl/kernel.rst | 32 + 1 file changed, 32 insertions(+) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b

Re: linux-next: manual merge of the jc_docs tree with the vfs and net-next trees

2020-05-18 Thread Stephen Kitt
and commit: 2f4c33063ad7 ("docs: sysctl/kernel: document ngroups_max") from the jc_docs tree. Hmm...that's somewhat messy. I somehow managed to miss the change to kernel/sysctl.c that doesn't have much to do with documentation. Stephen (Kitt): I've reverted that change for n

[PATCH] sysctl: const-ify ngroups_max

2020-05-18 Thread Stephen Kitt
ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make it const, in the same way as cap_last_cap. Signed-off-by: Stephen Kitt --- This is split out from 2f4c33063ad7 ("docs: sysctl/kernel: document ngroups_max") which conflicted with f461d2dcd511 ("sysctl

[PATCH v2] docs: sysctl/kernel: document ngroups_max

2020-05-18 Thread Stephen Kitt
This is a read-only export of NGROUPS_MAX. Signed-off-by: Stephen Kitt --- Changes since v1: - drop changes to kernel/sysctl.c Documentation/admin-guide/sysctl/kernel.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation

Re: [PATCH] docs: sysctl/kernel: document unaligned controls

2020-05-15 Thread Stephen Kitt
On Fri, 15 May 2020 20:36:01 +0200, Stephen Kitt wrote: > On Fri, 15 May 2020 11:27:35 -0600, Jonathan Corbet wrote: > > On Fri, 15 May 2020 18:04:06 +0200 > > Stephen Kitt wrote: > > > > > diff --git a/Documentation/index.rst b/Documentation/index.rst > >

[PATCH v2] docs: sysctl/kernel: document unaligned controls

2020-05-15 Thread Stephen Kitt
This documents ignore-unaligned-usertrap, unaligned-dump-stack, and unaligned-trap, based on arch/arc/kernel/unaligned.c, arch/ia64/kernel/unaligned.c, and arch/parisc/kernel/unaligned.c. While we're at it, integrate unaligned-memory-access.txt into the docs tree. Signed-off-by: Stephen Kitt

Re: [PATCH] docs: sysctl/kernel: document unaligned controls

2020-05-15 Thread Stephen Kitt
On Fri, 15 May 2020 11:27:35 -0600, Jonathan Corbet wrote: > On Fri, 15 May 2020 18:04:06 +0200 > Stephen Kitt wrote: > > > diff --git a/Documentation/index.rst b/Documentation/index.rst > > index 9599c0f3eea8..17c38d899572 100644 > > --- a/Documentation/index.

[PATCH] docs: sysctl/kernel: document unaligned controls

2020-05-15 Thread Stephen Kitt
This documents ignore-unaligned-usertrap, unaligned-dump-stack, and unaligned-trap, based on arch/arc/kernel/unaligned.c, arch/ia64/kernel/unaligned.c, and arch/parisc/kernel/unaligned.c. While we’re at it, integrate unaligned-memory-access.txt into the docs tree. Signed-off-by: Stephen Kitt

[PATCH] docs: sysctl/kernel: document ngroups_max

2020-05-15 Thread Stephen Kitt
This is a read-only export of NGROUPS_MAX, so this patch also changes the declarations in kernel/sysctl.c to const. Signed-off-by: Stephen Kitt --- Documentation/admin-guide/sysctl/kernel.rst | 9 + kernel/sysctl.c | 4 ++-- 2 files changed, 11 insertions

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote: > On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > > What if we went back to your original proposal of an empty struct but > > added in an extern in front? That way we should get linker error on > &g

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 10:13:22 +0200 Stephen Kitt wrote: > > On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski > > wrote: > > > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > > > C

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
Hi, Thanks for taking the time to review my patch. On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski wrote: > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > Commit c7228317441f ("net: Use a more standard macro for > > INET_ADDR_COOKIE") added a __deprecated

Re: [PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Stephen Kitt
On Tue, 28 Apr 2020 14:07:46 -0700 (PDT), David Miller wrote: > From: Stephen Kitt > Date: Tue, 28 Apr 2020 09:52:31 +0200 > > > This patch changes INET_ADDR_COOKIE to declare a dummy typedef (so it > > makes checkpatch.pl complain, sorry...) > > This is trading

[PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Stephen Kitt
ribute warnings entirely and for good"), __deprecated doesn't do anything and should be avoided. This patch changes INET_ADDR_COOKIE to declare a dummy struct so that any subsequent use of the cookie's name will in all likelihood break the build. It also removes the __deprecated marker. Signed-

[PATCH v2 1/2] docs: sysctl/kernel: document ftrace entries

2020-04-29 Thread Stephen Kitt
Based on the ftrace documentation, the tp_printk boot parameter documentation, and the implementation in kernel/trace/trace.c. Signed-off-by: Stephen Kitt --- Changes since v2: - spelling and grammar fixes in ftrace_dump_on_oops ("outputing it" -> "outputting them")

[PATCH v2 2/2] docs: sysctl/kernel: document firmware_config

2020-04-29 Thread Stephen Kitt
Based on the firmware fallback mechanisms documentation and the implementation in drivers/base/firmware_loader/fallback.c. Signed-off-by: Stephen Kitt --- Documentation/admin-guide/sysctl/kernel.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/admin-guide

Re: [PATCH 2/3] docs: sysctl/kernel: document ftrace entries

2020-04-29 Thread Stephen Kitt
On Tue, 28 Apr 2020 12:41:33 -0600, Jonathan Corbet wrote: > On Thu, 23 Apr 2020 20:36:50 +0200 > Stephen Kitt wrote: > > Based on the ftrace documentation, the tp_printk boot parameter > > documentation, and the implementation in kernel/trace/trace.c. > > > &g

[PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-04-28 Thread Stephen Kitt
ild. It also removes the __deprecated marker. Signed-off-by: Stephen Kitt --- include/net/inet_hashtables.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h index ad64ba6a057f..8a1391d82406 100644 --- a/include/net/ine

Re: [PATCH v2] clk/ti/adpll: allocate room for terminating null

2019-10-19 Thread Stephen Kitt
On Thu, 17 Oct 2019 08:48:53 -0700, Stephen Boyd wrote: > Quoting Stephen Kitt (2019-09-27 11:05:59) > > The buffer allocated in ti_adpll_clk_get_name doesn't account for the > > terminating null. This patch switches to ka_sprintf to avoid > > overflowing. > > >

[PATCH v3] clk/ti/adpll: allocate room for terminating null

2019-10-19 Thread Stephen Kitt
The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch switches to devm_kasprintf to avoid overflowing. Signed-off-by: Stephen Kitt --- Changes since v2: - Move "adpll" into the format string and drop base_name entirely. Changes since v

[PATCH] drivers/clk: convert VL struct to struct_size

2019-09-27 Thread Stephen Kitt
There are a few manually-calculated variable-length struct allocations left, this converts them to use struct_size. Signed-off-by: Stephen Kitt --- drivers/clk/at91/sckc.c | 3 +-- drivers/clk/imgtec/clk-boston.c | 3 +-- drivers/clk/ingenic/tcu.c

Re: [PATCH] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Stephen Kitt
Le 27/09/2019 17:23, Tony Lindgren a écrit : * Stephen Kitt [190927 15:13]: The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch adds the extra byte, and switches to snprintf to avoid overflowing. Signed-off-by: Stephen Kitt --- drivers/clk/ti

Re: [PATCH v2] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Stephen Kitt
Le 27/09/2019 20:05, Stephen Kitt a écrit : The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch switches to ka_sprintf to avoid Aargh, devm_kasprintf of course... overflowing. Signed-off-by: Stephen Kitt --- drivers/clk/ti/adpll.c | 10

[PATCH v2] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Stephen Kitt
The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch switches to ka_sprintf to avoid overflowing. Signed-off-by: Stephen Kitt --- drivers/clk/ti/adpll.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/clk/ti

[PATCH] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Stephen Kitt
The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch adds the extra byte, and switches to snprintf to avoid overflowing. Signed-off-by: Stephen Kitt --- drivers/clk/ti/adpll.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-26 Thread Stephen Kitt
Le 26/09/2019 09:29, Rasmus Villemoes a écrit : On 26/09/2019 02.01, Stephen Kitt wrote: Le 25/09/2019 23:50, Andrew Morton a écrit : On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: Several uses of strlcpy and strscpy have had defects because the last argument of each function

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-25 Thread Stephen Kitt
of ALSA's strcpy calls to stracpy: From 89e9afa562f3351bc000f3aacb1041eafbe0204c Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Thu, 26 Sep 2019 01:36:20 +0200 Subject: [PATCH] ALSA: use stracpy in docs, USB and Intel HDMI This converts the Writing an ALSA driver manual to stracpy instead

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Stephen Kitt
On Mon, 22 Jul 2019 10:59:00 -0700, Joe Perches wrote: > On Mon, 2019-07-22 at 10:50 -0700, Kees Cook wrote: > > On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > > > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook > > > wrote: > > > > O

Re: [PATCH] docs: format kernel-parameters -- as code

2019-06-28 Thread Stephen Kitt
two hyphens; this patch formats them as code, > > "``--``", as done elsewhere in the documentation. > > > > Signed-off-by: Stephen Kitt > > A worthy fix, I've applied it. This seems like the sort of annoyance that > will bite us over and over, though. We mig

[PATCH] docs: stop suggesting strlcpy

2019-06-13 Thread Stephen Kitt
Since strlcpy is deprecated, the documentation shouldn't suggest using it. This patch fixes the examples to use strscpy instead. It also uses sizeof instead of underlying constants as far as possible, to simplify future changes to the corresponding data structures. Signed-off-by: Stephen Kitt

[PATCH] Drop unused isa_page_to_bus

2019-06-13 Thread Stephen Kitt
isa_page_to_bus is deprecated and no longer used anywhere, this patch removes it entirely. Signed-off-by: Stephen Kitt --- arch/alpha/include/asm/io.h | 5 - arch/arm/include/asm/io.h | 1 - arch/mips/include/asm/io.h | 2 -- arch/x86/include/asm/io.h | 1 - 4 files changed, 9

[tip:x86/mm] x86/mm: Fix the 56-bit addresses memory map in Documentation/x86/x86_64/mm.txt

2019-04-16 Thread tip-bot for Stephen Kitt
Commit-ID: 89502a01979033a1c0c0c4d6d9aef07e59021005 Gitweb: https://git.kernel.org/tip/89502a01979033a1c0c0c4d6d9aef07e59021005 Author: Stephen Kitt AuthorDate: Mon, 15 Apr 2019 17:08:53 +0200 Committer: Ingo Molnar CommitDate: Tue, 16 Apr 2019 09:00:34 +0200 x86/mm: Fix the 56-bit

[PATCH] Fix 56-bit addresses in Documentation/x86/x86_64/mm.txt

2019-04-15 Thread Stephen Kitt
This fixes a PT typo, and the following 56-bit address-space addresses: * the hole extends from 0100 to feff * the KASAN shadow memory area stops at fbff (see kasan.h) Signed-off-by: Stephen Kitt --- Documentation/x86/x86_64/mm.txt | 6 +++--- 1 file changed

Re: [PATCH] device_handler: remove VLAs

2018-03-12 Thread Stephen Kitt
On Mon, 12 Mar 2018 15:41:26 +, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Sat, 2018-03-10 at 14:14 +0100, Stephen Kitt wrote: > > The two patches I sent were supposed to be alternative solutions; see > > https://marc.info/?l=linux-scsi=152063671005295=2 for th

Re: [PATCH] device_handler: remove VLAs

2018-03-12 Thread Stephen Kitt
On Mon, 12 Mar 2018 15:41:26 +, Bart Van Assche wrote: > On Sat, 2018-03-10 at 14:14 +0100, Stephen Kitt wrote: > > The two patches I sent were supposed to be alternative solutions; see > > https://marc.info/?l=linux-scsi=152063671005295=2 for the > > introduction (I s

Re: [PATCH] device_handler: remove VLAs

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:48:10 +, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > > In preparation to enabling -Wvla, remove VLAs and replace them with > > fixed-length arrays instead. > > >

Re: [PATCH] device_handler: remove VLAs

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:48:10 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > > In preparation to enabling -Wvla, remove VLAs and replace them with > > fixed-length arrays instead. > > > > scsi_dh_{alua,emc,rdac

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > +/* > > + * SCSI command sizes are as follows, in bytes, for fixed size commands, > > per > > + * group: 6, 10

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > +/* > > + * SCSI command sizes are as follows, in bytes, for fixed size commands, > > per > > + * group: 6, 10, 10, 12, 16, 12, 10, 10. The

VLA removal, device_handler and COMMAND_SIZE

2018-03-09 Thread Stephen Kitt
Hi, I’ve been looking into removing some VLAs from device_handler drivers, prompted by https://lkml.org/lkml/2018/3/7/621 The uses in question here are quite straightforward, e.g. in drivers/scsi/device_handler/scsi_dh_alua.c: u8 cdb[COMMAND_SIZE(MAINTENANCE_IN)]; There’s no trivial

VLA removal, device_handler and COMMAND_SIZE

2018-03-09 Thread Stephen Kitt
Hi, I’ve been looking into removing some VLAs from device_handler drivers, prompted by https://lkml.org/lkml/2018/3/7/621 The uses in question here are quite straightforward, e.g. in drivers/scsi/device_handler/scsi_dh_alua.c: u8 cdb[COMMAND_SIZE(MAINTENANCE_IN)]; There’s no trivial

[PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-09 Thread Stephen Kitt
. This was prompted by https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Stephen Kitt <st...@sk2.org> --- block/scsi_ioctl.c | 8 drivers/target/Kconfig | 1 - include/scsi/scsi_common.h | 13 +++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a

[PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-09 Thread Stephen Kitt
. This was prompted by https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Stephen Kitt --- block/scsi_ioctl.c | 8 drivers/target/Kconfig | 1 - include/scsi/scsi_common.h | 13 +++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/scsi_ioctl.c b

  1   2   >