Commit fixed to handle the ifdef CONFIG_CIFS_SMB2 disabled problem you
noted, and repushed to my for-next branch. Thx for pointing this out.
On Tue, Nov 29, 2016 at 4:27 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) fai
On Mon, May 2, 2016 at 5:52 PM, Andreas Dilger wrote:
> On Apr 29, 2016, at 6:58 AM, David Howells wrote:
>>
>> Make windows attributes available for CIFS, NTFS and FAT to use in the
>> statx struct. The attribute flags map directly by value to those in the
>> CIFS PDU flags. Some of these bits
Sorry about the previous note, what I meant was that your first patch
makes the code a little clearer (this patch obviously fixes a bug).
On Thu, May 26, 2016 at 1:30 PM, Steve French wrote:
> Your patch makes code a little clearer, so I don't mind merging it,
> but the two values a
Your patch makes code a little clearer, so I don't mind merging it,
but the two values are the same so this patch should have no effect.
On Thu, May 26, 2016 at 4:52 AM, Jerome Marchand wrote:
> In sess_auth_rawntlmssp_authenticate(), the ntlmssp blob is allocated
> statically and its size is an
I fixed the build break (and some trivial compile warnings) due to the
change to the format of keyring_alloc and repushed the *"cifs: Create
dedicated keyring for spnego operations" patch to cifs-2.6.git
for-next
On Thu, May 19, 2016 at 6:14 PM, Stephen Rothwell wrote:
> Hi Steve,
>
> On Thu, 19
As noted below, it is easier to remove the obsolete comments and I
just pushed the following trivial patch to cifs-2.6.git for-next to do
that.
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=fea17ae8ac1c8c44b2fd1c02ae2e15b847d327d1
On Wed, May 18, 2016 at 8:17 PM, Stephen Rothwell wr
On Thu, May 5, 2016 at 5:54 PM, Steve French wrote:
> On Wed, May 4, 2016 at 8:46 AM, Arnd Bergmann wrote:
>> On Friday 29 April 2016 13:57:36 David Howells wrote:
>>> struct statx *buffer);
>>>
>>> This is an enhanced file stat function that provides a numbe
Reviewed-by: Steve French
Let me know if you want any of them to go in via the cifs tree or
prefer going in through your tree (other than patch 1 which could go
in the net-next tree are you indicated)
On Sat, Apr 9, 2016 at 3:43 PM, Al Viro wrote:
> Now that sendmsg/recvmsg do
Reviewed-by: Steve French
On Sun, Apr 24, 2016 at 7:24 PM, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom
> ---
> Documentation/filesystems/autofs4.txt | 6 +++---
> Documentation/filesystems/cifs/CHANGES | 2 +-
> Documentation/filesystems/proc.txt | 4 ++--
&
-get_richacl-and-set_richacl-inode-operations.patch
0024-xfs-Make-xfs_set_mode-non-static.patch
0042-ext4-Don-t-allow-unmapped-identifiers-in-richacls.patch
0043-xfs-Don-t-allow-unmapped-identifiers-in-richacls.patch
Reviewed-by: Steve French
On Wed, Mar 16, 2016 at 5:18 PM, Andreas Gruenbacher
wrote:
>
On Tue, Mar 15, 2016 at 2:14 AM, Christoph Hellwig wrote:
> On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote:
>> A loosely related question is what can be done for tools around existing
>> interfaces for ACLs. I recently found out NTFS-3g has this xattr:
>>
>
On Tue, Mar 15, 2016 at 3:17 PM, Volker Lendecke
wrote:
> On Tue, Mar 15, 2016 at 08:45:14AM -0700, Jeremy Allison wrote:
>> On Tue, Mar 15, 2016 at 12:11:03AM -0700, Christoph Hellwig wrote:
>> > People have long learned that we only have 'alloc' permissions. Any
>> > model that mixes allow and
On Fri, Mar 11, 2016 at 10:11 AM, Andreas Gruenbacher
wrote:
> On Fri, Mar 11, 2016 at 3:01 PM, Christoph Hellwig w
> The model is designed specifically to be compliant with the POSIX
> permission model. What assumptions are you talking about?
>
>> especially by adding allow and deny ACE at the s
19/0x20
>> [] entry_SYSCALL_64_fastpath+0x12/0x6a
>> Code: 4d 8d 6c 07 04 31 c0 4c 89 ee e8 47 6f e5 ff 31 c9 41 89 ce 44 89 f1
>> 48 c7 c7 28 b1 bd 88 31 c0 49 01 cd 4c 89 ee e8 2b 6f e5 ff <45> 0f b7 75 04
>> 48 c7 c7 31 b1 bd 88 31 c0 4d 01 ee 4c 89 f6 e8
>> RI
merged into cifs-2.6.git
Looks like alpha has a similar problem though
On Wed, Feb 24, 2016 at 12:45 AM, Yadan Fan wrote:
> This issue is involved from commit 02323db17e3a7 ("cifs: fix
> cifs_uniqueid_to_ino_t not to ever return 0"), when BITS_PER_LONG
> is 64 on s390x, the corresponding cifs_un
Merged into cifs-2.6.git and added cc: stable
On Wed, Feb 10, 2016 at 11:50 AM, Anton Protopopov
wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
>
> Signed-off-by: Anton Protopopov
> ---
> fs/cifs/cifsencrypt.c | 2 +-
>
merged into cifs-2.6.git for-next
On Mon, Jan 25, 2016 at 10:25 AM, Colin King wrote:
> From: Colin Ian King
>
> server_RFC1001_name is declared as a RFC1001_NAME_LEN_WITH_NULL sized
> char array in struct TCP_Server_Info so the null pointer check on
> server_RFC1001_name is redundant and can be
On Mon, Feb 1, 2016 at 10:34 AM, Insu Yun wrote:
> In worst case, "ip=" + sb_mountdata + ipv6 can be copied into mountdata.
> Therefore, for safe, it is better to add more size when allocating memory.
>
> Signed-off-by: Insu Yun
> ---
> fs/cifs/cifs_dfs_ref.c | 2 +-
> 1 file changed, 1 insertio
Is it worth storing the same creation time twice (in slightly
different formats, struct timespec and u64 DCE time) in cifsInodeInfo?
On Fri, Nov 20, 2015 at 8:55 AM, David Howells wrote:
> Return enhanced attributes from the CIFS filesystem. This includes the
> following:
>
> (1) Return the fil
On Tue, Nov 10, 2015 at 6:39 AM, Andreas Gruenbacher
wrote:
> On Tue, Nov 10, 2015 at 12:29 PM, Christoph Hellwig
> wrote:
>> On Mon, Nov 09, 2015 at 12:08:41PM +0100, Andreas Gruenbacher wrote:
>>> Here is another update to the richacl patch queue. This posting contains
>>> the patches ready t
On Wed, Oct 7, 2015 at 8:38 AM, Andreas Gruenbacher wrote:
> On Wed, Oct 7, 2015 at 9:50 AM, Christoph Hellwig wrote:
>> On Tue, Oct 06, 2015 at 02:26:09PM -0600, Andreas Dilger wrote:
>>> And any disk filesystems that have their own non-POSIX ACLs, such as HFS,
>>> NTFS, ZFS would presumably al
On Tue, Oct 6, 2015 at 3:26 PM, Andreas Dilger wrote:
> On Oct 6, 2015, at 7:12 AM, Andreas Gruenbacher wrote:
>>
>> On Tue, Oct 6, 2015 at 11:49 AM, Christoph Hellwig
>> wrote:
>>> On Mon, Oct 05, 2015 at 02:58:36PM -0400, Austin S Hemmelgarn wrote:
I think the point is that a new VFS fea
/grsecurity team
Signed-off-by: Steve French
Reported-by: PaX Team
CC: Emese Revfy
CC: Brad Spengler
CC: Stable
---
fs/cifs/inode.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index f621b44..6b66dd5 100644
--- a/fs/cifs
Corrected endian error and repushed
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=patch;h=79a5296f14b26ac8644239286ffd7a62dbbc385e
On Thu, Sep 17, 2015 at 6:41 PM, Steve French wrote:
> Nice catch.
>
> Merged into cifs-2.6.git for-next
--
Thanks,
Steve
--
To unsubscribe from
loooks reasonable to me - isn't this part of a larger patch series
though? Did you want it merged distinctly into cifs-2.6.git?
On Fri, Aug 7, 2015 at 2:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]:
{
>> err = PTR_ERR(od);
>> dprintk("%s: osduld_info_lookup => %d\n", __func__, err);
>> if (err == -ENODEV && retry_flag) {
>> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
>> index fdda62e6115e
On Wed, Jun 24, 2015 at 10:31 AM, Beata Michalska
wrote:
> On 06/24/2015 10:47 AM, Dmitry Monakhov wrote:
>> Beata Michalska writes:
>>
>>> Introduce configurable generic interface for file
>>> system-wide event notifications, to provide file
>>> systems with a common way of reporting any potenti
I tried file copies similar to "cp --reflink" over the network (from
cifs.ko client) with the new SMB3.11 dialect and
FSCTL_DUPLICATE_EXTENTS. As expected - spectacularly faster than
regular cp. Target file system was REFS in my tests at the SMB3 test
event this week.
Now that Samba is also addin
merged into cifs-2.6.git for-next
On Fri, Apr 3, 2015 at 7:11 AM, Jeff Layton wrote:
> On Tue, 24 Mar 2015 20:18:49 -0400
> Chengyu Song wrote:
>
>> posix_lock_file_wait may fail under certain circumstances, and its result is
>> usually checked/returned. But given the complexity of cifs, I'm not
On Tue, Mar 31, 2015 at 7:46 PM, Jeff Layton wrote:
> On Fri, 27 Mar 2015 00:28:01 -0500
> Steve French wrote:
>
>> null tcon is not likely in these paths in current
>> code, but obviously it does clarify the code to
>> check for null (if at all) before derefr
null tcon is not likely in these paths in current
code, but obviously it does clarify the code to
check for null (if at all) before derefrencing
rather than after.
Reported by Coverity (CID 1042666)
Signed-off-by: Steve French
---
fs/cifs/smb2pdu.c | 13 -
1 file changed, 8
Coverity reports a warning for referencing the beginning of the
SMB2/SMB3 frame using the ProtocolId field as an array. Although
it works the same either way, this patch should quiet the warning
and might be a little clearer.
Reported by Coverity (CID 741269)
Signed-off-by: Steve French
---
fs
Although unlikely to fail (and tree connect does not commonly send
a password since SECMODE_USER is the default for most servers)
do not ignore errors on SMBNTEncrypt in SMB Tree Connect.
Reported by Coverity (CID 1226853)
Signed-off-by: Steve French
---
fs/cifs/connect.c | 6 ++
1 file
-off-by: Steve French
---
fs/cifs/smb2pdu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 3417340..1b906de 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -2114,7 +2114,7 @@ SMB2_query_directory(const unsigned int xid, struct
Four small fixes to address warnings coverity analyzer displays
for fs/cifs.
Steve French (4):
[SMB3] Fix warning on uninitialized buftype
[CIFS] Don't ignore errors on encrypting password in SMBTcon
[SMB3] Fix dereference before null check warning
[SMB3] Fix coverity warning
fs
Have updated the wiki page with the cifs kernel changes/fixes by release
https://wiki.samba.org/index.php/LinuxCIFSKernel
and made a start at an SMB3 implementation status page although it
needs corrections/additions
https://wiki.samba.org/index.php/SMB3_kernel_status
Corrections/updates to tho
On Tue, Mar 24, 2015 at 7:18 PM, Chengyu Song wrote:
> posix_lock_file_wait may fail under certain circumstances, and its result is
> usually checked/returned. But given the complexity of cifs, I'm not sure if
> the result is intentially left unchecked and always expected to succeed.
>
> Signed-of
Nice catch.
Merged into cifs-2.6.git for-next
On Sat, Mar 21, 2015 at 6:08 PM, Taesoo Kim wrote:
> For example, when mount opt is redundently specified
> (e.g., "user=A,user=B,user=C"), kernel kept allocating new key/val
> with kstrdup() and overwrite previous ptr (to be freed).
>
> Althouhg mkf
Merged into cifs-2.6.git
On Wed, Feb 4, 2015 at 7:10 AM, Sachin Prabhu wrote:
> While attempting to clone a file on a samba server, we receive a
> STATUS_INVALID_DEVICE_REQUEST. This is mapped to -EOPNOTSUPP which
> isn't handled in smb2_clone_range(). We end up looping in the while loop
> making
Three small cifs fixes. One fixes a hang under stress, and the other two are
security related.
The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc:
Linux 3.19-rc5 (2015-01-18 18:02:20 +1200)
are available in the git repository at:
git://git.samba.org/sfrench/cifs-2.
merged into cifs-2.6.git
On Thu, Jan 22, 2015 at 7:16 AM, Niklas Cassel wrote:
> If CONFIG_CIFS_WEAK_PW_HASH is not set, CIFSSEC_MUST_LANMAN
> and CIFSSEC_MUST_PLNTXT is defined as 0.
>
> When setting new SecurityFlags without any MUST flags,
> your flags would be overwritten with CIFSSEC_MUST_LA
merged into cifs-2.6.git for-next
On Tue, Jan 6, 2015 at 4:59 PM, Herbert Xu wrote:
> On Tue, Jan 06, 2015 at 10:37:00PM +0100, Giel van Schijndel wrote:
>> When leaving a function use memzero_explicit instead of memset(0) to
>> clear stack allocated buffers. memset(0) may be optimized away.
>>
>
On Thu, Jan 8, 2015 at 5:49 AM, Christoph Hellwig wrote:
> On Tue, Jan 06, 2015 at 12:47:14AM -0800, Andrew Morton wrote:
>> > progress, which is a bit frustrating.
>>
>> I took a look at pread2() as well and I have two main issues:
>>
>> - The patchset includes a pwrite2() syscall which has nothi
Looks fine to me - will merge into cifs-2.6.git
On Tue, Jan 6, 2015 at 3:37 PM, Giel van Schijndel wrote:
> When leaving a function use memzero_explicit instead of memset(0) to
> clear stack allocated buffers. memset(0) may be optimized away.
>
> This particular buffer is highly likely to contain
A set of three minor cifs fixes.
Please pull the following changes since commit
9ea18f8cab5f1c36cdd0f09717e35ceb48c36a87:
Merge branch 'for-3.19/drivers' of git://git.kernel.dk/linux-block
(2014-12-13 14:22:26 -0800)
are available in the git repository at:
git://git.samba.org/sfrench/cifs-
merged into cifs-2.6.git
On Sat, Dec 13, 2014 at 11:29 PM, Kevin Cernekee wrote:
> On Sat, Dec 13, 2014 at 9:20 PM, Steve French wrote:
>> Probably harmless patch - but I didn't notice the warning on x86
>> kernel build (building on Fedora 21, gcc 4.9.2)
>
> Did you
Probably harmless patch - but I didn't notice the warning on x86
kernel build (building on Fedora 21, gcc 4.9.2)
On Fri, Dec 12, 2014 at 11:19 AM, Kevin Cernekee wrote:
> On Mon, Nov 10, 2014 at 1:09 PM, Kevin Cernekee wrote:
>> Commit 2ae83bf93882d1 ("[CIFS] Fix setting time before epoch (negat
y: Kevin Cernekee
> ---
> MAINTAINERS | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b36a4f0..4d8154d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2519,8 +2519,7 @@ M:Steve French
> L:
What would be required for a network file system to support the
RWF_NONBLOCK flag?
SMB3 operations are all async (on the wire) by default but they do
block on the network send and interim response.
On Tue, Oct 21, 2014 at 3:46 PM, Milosz Tanski wrote:
> Filesystems that generic_file_read_iter wi
52 PM, Steve French wrote:
> Same thing happened after pulling newly updated mainline kernel
> changes a few minutes ago.
>
> Black screen on boot just when you would expect x to be starting.
> Hung. Ctl-alt-F1 doesn't do anything.
>
> arch is x86_64.
>
> 3.17.1 works.
ot;fb"
[18.379] (II) LoadModule: "dri2"
[18.479] (II) LoadModule: "evdev"
[18.484] (II) LoadModule: "vmmouse"
On Fri, Oct 17, 2014 at 6:52 PM, Steve French wrote:
> This is vmware guest
>
> sfrench@ubuntu:~/xfstests$ cat /proc/cpuinfo
> processor
o see if I can
hook up a serial console (I had maximum kernel boot verbose in the
grub.cfg but nothing interesting before the black screen)
On Fri, Oct 17, 2014 at 6:44 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Oct 17, 2014 at 05:44:02PM -0500, Steve French wrote:
>> Anyone know a w
Anyone know a workaround for the problem booting current mainline?
3.17 works fine for me, but recent mainline since 3.17 goes to a black
screen near the end of boot as X is about to start.
I also tried the Ubuntu build of the day (which also is based on
current mainline but with the Ubuntu config
)
Pavel Shilovsky (1):
CIFS: Fix readpages retrying on reconnects
Steve French (1):
Fix problem recognizing symlinks
fs/cifs/file.c | 8 +---
fs/cifs/smb1ops.c | 2 +-
fs/cifs/smb2maperror.c | 2 ++
3 files changed, 4 insertions(+), 8
Merged into cifs-2.6.git for-next (and for-linus)
I would like to get this and also
http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=19e81573fca7b87ced7701e01ba164b968d929bd
upstream ASAP but timing is getting tight, will need to wait at least
a day for the normal linux-next build processes
On Wed, Sep 17, 2014 at 2:05 PM, Steve French wrote:
> Looking at more examples, some of which are much larger match tables
> maybe it has to do with how the final entry is defined. In this
> example the NULL match is explicitly stated.
>
> static const match_table_t cifs_s
2, "ntlmv2" },
{ Opt_sec_ntlmv2i, "ntlmv2i" },
{ Opt_sec_lanman, "lanman" },
{ Opt_sec_none, "none" },
{ Opt_sec_err, NULL }
};
On Wed, Sep 17, 2014 at 3:53 PM, Steve French wrote:
> For additional information the strings tha
ing args didn't seem to help in the cifs case
On Wed, Sep 17, 2014 at 3:36 PM, Randy Dunlap wrote:
> On 09/17/14 13:33, Randy Dunlap wrote:
>> On 09/17/14 11:20, Steve French wrote:
>>> Noticing something very strange with match_token. I had five strings
>>> I need
Noticing something very strange with match_token. I had five strings
I need to compare a version string (protocol dialect eg. "2.1" or
"3.0") against, to find which it matches (if any), but adding one to
the list (now checking for one of six strings instead of five) causes
the error case to alway
Merged into cifs-2.6.git for-next
Added Yalin Wang who reported the same problem/fix
On Mon, Sep 8, 2014 at 10:20 AM, Arnd Bergmann wrote:
> cifs provides two dummy functions 'sess_auth_lanman' and
> 'sess_auth_kerberos' for the case in which the respective
> features are not defined. However,
Does 64 bit signed division work on all archs?
Since do_div (currently used by cifs and ntfs to convert time formats
from DCE time to Linux time) does not handle negative numbers, and
there does not appear to be a kernel equivalent of Ildiv, I was
wondering if there really is a problem with simply
>
> This fixes the following compilation warning:
>
> fs/cifs/misc.c:578:1: warning: ‘cifs_oplock_break_wait’ defined but not
> used [-Wunused-function]
>
> Signed-off-by: Vincent Stehlé
> Cc: Steve French
> ---
>
> Hi,
>
> This can be seen with e.g. linux n
Thanks for pointing this out. I fixed the instances of this that you
spotted in the cifs.ko driver (pushed to cifs-2.6.git for-next) and
noted that you pointed it out in the commit message.
http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=59b04c5df75bd715002bb535930ae1982a739269
On Sat,
dd if=/dev/zero of=/mnt/testfile bs=60M count=25)
were more widely varied but averaged similar speeds for copy to server
for both NFSv3/v4/v4.1 and SMB3 (about 175MB/s)
On Sun, Jul 13, 2014 at 2:23 PM, Steve French wrote:
> Performance of Pavel's multicredit i/o SMB3 patches contin
I don't see this build warning, and I do see these functions used
outside the CONFIG_CIFS_WEAK_PW_HASH - are you using current
linux-next (or equivalently cifs-2.6.git for-next branch)There were
some updates to fs/cifs late last week.
On Mon, Jul 14, 2014 at 5:38 AM, Thierry Reding
wrote:
> From:
re or kvm) to compare though (to see if the larger
wsize and rsize help)
On Sun, Jul 13, 2014 at 2:23 PM, Steve French wrote:
> Performance of Pavel's multicredit i/o SMB3 patches continues to look
> good. Additional informal performance results below comparing cifs
> mounts with sm
Performance of Pavel's multicredit i/o SMB3 patches continues to look
good. Additional informal performance results below comparing cifs
mounts with smb3 mounts (vers=3.0) with and without Pavel's patch set.
I plan to do additional testing with large rsize/wsize (default with
Pavel's code is 1MB).
on to FILE_OPEN.
>>
>> Signed-off-by: Björn Baumbach
>> Signed-off-by: Stefan Metzmacher
>> Reviewed-by: Stefan Metzmacher
>> Cc: # v3.14+
>> Cc: Pavel Shilovsky
>> Cc: Steve French
>> ---
>> fs/cifs/link.c |2 +-
>> 1 file cha
merged into cifs-2.6.git
On Tue, May 13, 2014 at 7:30 PM, Fabian Frederick wrote:
> Also fixes array checkpatch warning and converts it to static const
> (suggested by Joe Perches).
>
> Cc: Joe Perches
> Cc: Steve French
> Cc: Andrew Morton
> Signed-off-by: Fabian
://lkml.org/lkml/2013/3/16/79 ?
On Tue, May 13, 2014 at 6:04 PM, Fabian Frederick wrote:
> Replace seq_printf where possible
>
> Cc: Steve French
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
> ---
> fs/cifs/cifsfs.c | 80
> --
merged into cifs-2.6.git for-next
On Tue, Dec 10, 2013 at 9:02 PM, Libo Chen wrote:
>
> Signed-off-by: Libo Chen
> ---
> fs/cifs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/ioctl.c b/fs/cifs/ioctl.c
> index 7749230..45cb59b 100644
> --- a/fs/cifs/ioc
merged into cifs-2.6.git
On Tue, Apr 15, 2014 at 3:06 AM, Michael Opdenacker
wrote:
> This issue was found by Coverity (CID 1202536)
>
> This proposes a fix for a statement that creates dead code.
> The "rc < 0" statement is within code that is run
> with "rc > 0".
>
> It seems like "err < 0" was
The patch is a little larger than usual for stable but for those where
the backport is trivial, seems reasonable candidate for stable.
On Tue, Feb 25, 2014 at 9:24 AM, Sitsofe Wheeler wrote:
> Hi,
>
> Is there any chance that 74d290da476f672ad756634d12aa707375d3564d
> ([CIFS] Provide sane values
It is there now. I had just (very briefly) deleted it for a few
minutes to update the branch with David Disseldorp's ack on an earlier
patch so you might have tried in the very few minutes it was gone
(Murphy's law?)
On Mon, Nov 18, 2013 at 5:20 PM, Stephen Rothwell wrote:
> Hi all,
>
> Fetching
r.
>
> Introduce the helpers get_mid() and compare_mid() to make the endian
> translation clear.
>
> Cc: Jeff Layton
> Cc: Steve French
> Signed-off-by: Tim Gardner
> ---
>
> V2 - get an endian appropriate copy of 'mid' for debug output in checkSMB()
t;
>> Introduce get_next_mid64() for the internal consumers that use the full 64
>> bit
>> multiplex identifier.
>>
>> Introduce the helpers get_mid() and compare_mid() to make the endian
>> translation clear.
>>
>> Cc: Jeff Layton
>> Cc: Steve
check_smb_header(). This seems
>> like redundant redundancy.
>>
>> Cc: Steve French
>> Signed-off-by: Tim Gardner
>> ---
>> fs/cifs/misc.c | 12 ++--
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/fs/cifs/misc.c
-- Forwarded message --
From: Steve French
Date: Tue, Oct 22, 2013 at 1:45 PM
Subject: Re: 3.11+ Problem with cifs links, bisected
To: Joao Correia
Cc: LKML , Pavel Shilovsky
, Jeff Layton
I wonder if this is a similar issue to what I fixed with
(Pavel's patch assumed
cp --reflink opens the target file for O_WRONLY before invoking the
(BTRFS) ioctl for clone file, but for copy offload over the network
the SMB2 specification requires that the target file be open O_RDWR.
I may be able to upgrade the target file handle on the fly by
reopening it in cifs.ko, and of
gt; while ntstatus_to_dos_map[].ntstatus is not 0. Granted,
> this is mostly theoretical, but could be used as a DOS attack
> if the error code in the SMB header is bogus.
>
> Cc: Steve French
> Signed-off-by: Tim Gardner
> ---
> fs/cifs/netmisc.c |4 +++-
> 1 file changed, 3 inse
Looks good.
Will plan to merge into cifs-2..6.git soon.
Probably should also go to stable kernels
On Sun, Oct 6, 2013 at 2:08 PM, Jan Klos wrote:
> When connecting to SMB2/3 shares, maximum file size is set to non-LFS maximum
> in superblock. This is due to cap_large_files bit being different
ned-off-by: Miklos Szeredi
> Cc: Steve French
> Cc: sta...@vger.kernel.org
> ---
> fs/cifs/dir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index d3e2eaa..5384c2a 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -5
Merged into cifs-2.6.git
On Mon, Sep 16, 2013 at 12:56 PM, Steve French wrote:
> On Mon, Sep 16, 2013 at 8:34 AM, David Howells wrote:
>>
>> Hi Steve,
>>
>> Could you pull a CIFS bugfix from my fscache branch?
>>
>> David
>
> Sounds fine. May h
On Mon, Sep 16, 2013 at 8:34 AM, David Howells wrote:
>
> Hi Steve,
>
> Could you pull a CIFS bugfix from my fscache branch?
>
> David
Sounds fine. May have to wait a day or so though due to pending merge
request (to upstream).
> ---
> The following changes since commit 5a6f282a2052bb13171b53f0
Andi,
Your patch looks reasonable. Would you repost the patch to
linux-cifs mailing list (and add any additional reviewers or testers
if you would like if you got feedback)?
On Mon, Jul 22, 2013 at 09:24:00PM +0200, Andi Shyti wrote:
In the cifs_reopen_file function, if the following statement
CIFS: Reconnect durable handles for SMB2
CIFS: Reopen the file if reconnect durable handle failed
CIFS: Fix a deadlock when a file is reopened
Steve French (3):
Limit allocation of crypto mechanisms to dialect which requires
[CIFS] use sensible file nlink values if unprovided
Wouldn't this be a candidate for stable?
On Thu, Jul 11, 2013 at 7:53 AM, Pavel Shilovsky wrote:
> 2013/7/7 Alexander E. Patrakov :
>> While playing a file from a CIFS-mounted samba share (over wireless,
>> if that matters), I got this deadlock:
>>
>> [ 2164.132440] ==
Yes that is fine - am updating with two minor changes to the tree.
will repost within three hours.
On Mon, Jun 24, 2013 at 6:51 PM, Stephen Rothwell wrote:
> Hi all,
>
> Attempting to fetch the cifs tree
> (git://git.samba.org/sfrench/cifs-2.6.git#for-next) produces this error:
>
> fatal: Couldn'
Fix one byte buffer overrun with prefixpaths on cifs mounts which can
cause a problem with mount depending on the string length.
The following changes since commit a93cb29acaa8f75618c3f202d1cf43c231984644:
Merge branch 'drm-fixes' of
git://people.freedesktop.org/~airlied/linux (2013-05-31 16:04
Fixes for a couple of DFS problems, a problem with extended security
negotiation and two other small cifs fixes.
The following changes since commit 62106e96279f66c52e2123782f9420af9dbe8cbe:
cifs: only set ops for inodes in I_NEW state (2013-05-24 12:55:39 -0500)
are available in the git reposi
One cifs fix to merge now - fixes possible DFS oops (I expect to
request a merge of 4 additional cifs fixes next week).
The following changes since commit ebb37277796269da36a8bc5d72ed1e8e1fb7d34b:
Merge branch 'for-3.10/drivers' of git://git.kernel.dk/linux-block
(2013-05-08 11:51:05 -0700)
ar
Well at least for SMB2 we know they should be ok
On Tue, May 14, 2013 at 6:09 AM, Jeff Layton wrote:
> On Tue, 14 May 2013 05:44:48 -0500
> Steve French wrote:
>
>> On Tue, May 14, 2013 at 3:51 AM, Jeff Layton wrote:
>> > On Fri, 10 May 2013 10:27:54 -0400
On Tue, May 14, 2013 at 3:51 AM, Jeff Layton wrote:
> On Fri, 10 May 2013 10:27:54 -0400
> Jeff Layton wrote:
>
>> On Fri, 10 May 2013 16:13:30 +0200
>> Miklos Szeredi wrote:
>>
>> > Hi,
>> >
>> > A while ago this was discussed:
>> >
>> > http://thread.gmane.org/gmane.linux.kernel.cifs/7779
>>
A set of cifs cleanup fixes. The only big one of this set optimizes
the cifs error logging, renaming cFYI and cERROR macros to cifs_dbg,
and in the process makes it clearer and reduces module size.
The following changes since commit 173192958d06b8d1eb44f56d74373052ad6a9a60:
Merge tag 'mmc-upda
Fixes a regression in cifs in which a password which begins with a
comma is parsed incorrectly as a blank password
The following changes since commit 66ade474237745a57b7e87da9a93c7ec69fd52bb:
Merge branch 'fixes' of git://git.linaro.org/people/rmk/linux-arm
(2013-04-03 16:15:17 -0700)
are avai
On Fri, Mar 15, 2013 at 3:43 PM, Joe Perches wrote:
> On Fri, 2013-03-15 at 15:16 -0500, Steve French wrote:
>
>> I would like to merge the three we have (one still has to be put in
>> for-next - the one from Jeff) for for-next in the next three or fouir
>> days -
Merged into cifs-2.6.git (for-next branch)
On Mon, Mar 11, 2013 at 11:22 AM, Silviu-Mihai Popescu
wrote:
> This replaces calls to kmalloc followed by memcpy with a single call to
> kmemdup. This was found via make coccicheck.
>
> Signed-off-by: Silviu-Mihai Popescu
> ---
> fs/cifs/cifs_spnego.c
Merged into cifs-2.6.git for-next branch
On Sun, Mar 10, 2013 at 7:29 AM, Dia Vasile
wrote:
> From: Dia Vasile
>
> Signed-off-by: Diana Vasile
> ---
> fs/cifs/smb2pdu.c |4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index
3 small CIFS Fixes (the most important of the three fixes a recent
problem authenticating
to Windows 8 using cifs rather than SMB2)
The following changes since commit 6c23cbbd5056b155401b0a2b5567d530e6c750c4:
Randy Dunlap (1):
futex: fix kernel-doc notation and spello
are available in t
On Fri, Mar 15, 2013 at 2:01 PM, Jeff Layton wrote:
>
> On Thu, 14 Mar 2013 12:24:37 -0700
> Joe Perches wrote:
>
> > It's not obvious from reading the macro names that these macros
> > are for debugging. Convert the names to a single more typical
> > kernel style cifs_dbg macro.
> >
> > c
301 - 400 of 524 matches
Mail list logo
