Re: [PATCH 1/4] x86/cpufeatures: Add Intel feature bits for Speculation Control

2018-01-20 Thread Steven Noonan
On Sat, Jan 20, 2018 at 4:03 AM, David Woodhouse wrote: > Add three feature bits exposed by new microcode on Intel CPUs for > speculation control. We would now be up to five bits in CPUID(7).RDX > so take them out of the 'scattered' features and make a proper word > for them

Re: [PATCH 1/4] x86/cpufeatures: Add Intel feature bits for Speculation Control

2018-01-20 Thread Steven Noonan
On Sat, Jan 20, 2018 at 4:03 AM, David Woodhouse wrote: > Add three feature bits exposed by new microcode on Intel CPUs for > speculation control. We would now be up to five bits in CPUID(7).RDX > so take them out of the 'scattered' features and make a proper word > for them instead. > >

Re: perf object code reading test crashes

2016-02-17 Thread Steven Noonan
On Wed, Feb 17, 2016 at 6:27 AM, Arnaldo Carvalho de Melo <a...@redhat.com> wrote: > Em Tue, Feb 16, 2016 at 10:42:19PM -0800, Steven Noonan escreveu: >> I oddly didn't run into this issue on every machine I tried, but >> there's some issues here: >> >> $ sudo per

Re: perf object code reading test crashes

2016-02-17 Thread Steven Noonan
On Wed, Feb 17, 2016 at 6:27 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 16, 2016 at 10:42:19PM -0800, Steven Noonan escreveu: >> I oddly didn't run into this issue on every machine I tried, but >> there's some issues here: >> >> $ sudo perf test 21 >

perf object code reading test crashes

2016-02-16 Thread Steven Noonan
I oddly didn't run into this issue on every machine I tried, but there's some issues here: $ sudo perf test 21 21: Test object code reading :*** Error in `perf': corrupted double-linked list: 0x023ffcd0 *** === Backtrace: =

perf object code reading test crashes

2016-02-16 Thread Steven Noonan
I oddly didn't run into this issue on every machine I tried, but there's some issues here: $ sudo perf test 21 21: Test object code reading :*** Error in `perf': corrupted double-linked list: 0x023ffcd0 *** === Backtrace: =

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-23 Thread Steven Noonan
On Thu, Apr 23, 2015 at 2:41 PM, Borislav Petkov wrote: > On Thu, Apr 23, 2015 at 11:22:39PM +0200, David Herrmann wrote: >> No it's not. O(256) equals O(1). > > Ok, you're right. Maybe O() was not the right thing to use when trying > to point out that iterating over 256 hash buckets and then

Re: [GIT PULL] kdbus for 4.1-rc1

2015-04-23 Thread Steven Noonan
On Thu, Apr 23, 2015 at 2:41 PM, Borislav Petkov b...@alien8.de wrote: On Thu, Apr 23, 2015 at 11:22:39PM +0200, David Herrmann wrote: No it's not. O(256) equals O(1). Ok, you're right. Maybe O() was not the right thing to use when trying to point out that iterating over 256 hash buckets and

4.0.0-rc4 NVMe NULL pointer dereference and hang

2015-03-22 Thread Steven Noonan
This happens on boot, and then eventually results in an RCU stall. [8.047533] nvme :05:00.0: Device not ready; aborting initialisation Note that the above is expected with this hardware (long story). Although 3.19.x prints the above and then continues gracefully, 4.0-rc breaks

4.0.0-rc4 NVMe NULL pointer dereference and hang

2015-03-22 Thread Steven Noonan
This happens on boot, and then eventually results in an RCU stall. [8.047533] nvme :05:00.0: Device not ready; aborting initialisation Note that the above is expected with this hardware (long story). Although 3.19.x prints the above and then continues gracefully, 4.0-rc breaks

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-10 Thread Steven Noonan
On Tue, Mar 10, 2015 at 12:23 AM, Hans de Goede wrote: > Hi, > > On 10-03-15 07:17, Steven Noonan wrote: >> >> Hi Benjamin, >> >> I just got a ThinkPad X250 in today and have tried out your patches on >> 3.19.1. Before the patches, the top Track

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-10 Thread Steven Noonan
Hi Benjamin, I just got a ThinkPad X250 in today and have tried out your patches on 3.19.1. Before the patches, the top TrackPoint buttons weren't working at all, but the clickpad was working fine. For the most part, your patches fixed the TrackPoint. There's something weird going on though. If

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-10 Thread Steven Noonan
Hi Benjamin, I just got a ThinkPad X250 in today and have tried out your patches on 3.19.1. Before the patches, the top TrackPoint buttons weren't working at all, but the clickpad was working fine. For the most part, your patches fixed the TrackPoint. There's something weird going on though. If

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-10 Thread Steven Noonan
On Tue, Mar 10, 2015 at 12:23 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 10-03-15 07:17, Steven Noonan wrote: Hi Benjamin, I just got a ThinkPad X250 in today and have tried out your patches on 3.19.1. Before the patches, the top TrackPoint buttons weren't working at all

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Steven Noonan
On Mon, Feb 9, 2015 at 9:56 AM, Steven Noonan wrote: > On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy > wrote: >> Hi Steven, >> >> On 02/09/2015 01:02 PM, Steven Noonan wrote: >>> On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy >>> wrote: >>>&

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Steven Noonan
On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy wrote: > Hi Steven, > > On 02/09/2015 01:02 PM, Steven Noonan wrote: >> On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy >> wrote: >>> The powerclamp driver injects idle periods to stay within the thermal >>>

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Steven Noonan
On Mon, Feb 9, 2015 at 9:56 AM, Steven Noonan ste...@uplinklabs.net wrote: On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Steven, On 02/09/2015 01:02 PM, Steven Noonan wrote: On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Steven Noonan
On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Steven, On 02/09/2015 01:02 PM, Steven Noonan wrote: On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: The powerclamp driver injects idle periods to stay within the thermal

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-08 Thread Steven Noonan
On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy wrote: > The powerclamp driver injects idle periods to stay within the thermal > constraints. > The driver does a fake idle by spawning per-cpu threads that call the mwait > instruction. This behavior of fake idle can confuse the other kernel >

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-08 Thread Steven Noonan
On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: The powerclamp driver injects idle periods to stay within the thermal constraints. The driver does a fake idle by spawning per-cpu threads that call the mwait instruction. This behavior of fake idle can confuse

Re: [PATCH] x86: change cachemode symbols to non-gpl to avoid breaking out-of-tree modules

2015-01-22 Thread Steven Noonan
On Thu, Jan 22, 2015 at 3:43 AM, Juergen Gross wrote: > Commit 281d4078bec366d60990add9d91a952953bd0d72 ("x86: Make page > cache mode a real type") introduced the symbols __cachemode2pte_tbl > and __pte2cachemode_tbl and exported them via EXPORT_SYMBOL_GPL. > This will break building out-of-tree

Re: [PATCH] x86: change cachemode symbols to non-gpl to avoid breaking out-of-tree modules

2015-01-22 Thread Steven Noonan
On Thu, Jan 22, 2015 at 3:43 AM, Juergen Gross jgr...@suse.com wrote: Commit 281d4078bec366d60990add9d91a952953bd0d72 (x86: Make page cache mode a real type) introduced the symbols __cachemode2pte_tbl and __pte2cachemode_tbl and exported them via EXPORT_SYMBOL_GPL. This will break building

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-21 Thread Steven Noonan
On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross wrote: > At the moment there are a lot of places that handle setting or getting > the page cache mode by treating the pgprot bits equal to the cache mode. > This is only true because there are a lot of assumptions about the setup > of the PAT MSR.

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-21 Thread Steven Noonan
On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross jgr...@suse.com wrote: At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a lot of assumptions about the setup of the

[PATCH] nf_log_ipv6: correct typo in module description

2014-11-27 Thread Steven Noonan
It incorrectly identifies itself as "IPv4" packet logging. Signed-off-by: Steven Noonan --- net/ipv6/netfilter/nf_log_ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/nf_log_ipv6.c b/net/ipv6/netfilter/nf_log_ipv6.c index 7b17a0b..41b9

[PATCH] nf_log_ipv6: correct typo in module description

2014-11-27 Thread Steven Noonan
It incorrectly identifies itself as IPv4 packet logging. Signed-off-by: Steven Noonan ste...@uplinklabs.net --- net/ipv6/netfilter/nf_log_ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/nf_log_ipv6.c b/net/ipv6/netfilter/nf_log_ipv6.c index 7b17a0b

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 2:43 PM, Steven Noonan wrote: > On Sat, Nov 1, 2014 at 6:17 AM, Steven Noonan wrote: >> On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan wrote: >>> I've been getting general protection faults in EFI modules at boot time >>> across several mac

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 6:17 AM, Steven Noonan wrote: > On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan wrote: >> I've been getting general protection faults in EFI modules at boot time >> across several machines. I originally thought it was just an EFI quirk >> on one mac

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan wrote: > I've been getting general protection faults in EFI modules at boot time > across several machines. I originally thought it was just an EFI quirk > on one machine so I blacklisted the rtc-efi module (which was the > offender

EFI-related general protection faults

2014-11-01 Thread Steven Noonan
I've been getting general protection faults in EFI modules at boot time across several machines. I originally thought it was just an EFI quirk on one machine so I blacklisted the rtc-efi module (which was the offender at the time), but I've seen it elsewhere since. Once this happens, the system is

EFI-related general protection faults

2014-11-01 Thread Steven Noonan
I've been getting general protection faults in EFI modules at boot time across several machines. I originally thought it was just an EFI quirk on one machine so I blacklisted the rtc-efi module (which was the offender at the time), but I've seen it elsewhere since. Once this happens, the system is

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan ste...@uplinklabs.net wrote: I've been getting general protection faults in EFI modules at boot time across several machines. I originally thought it was just an EFI quirk on one machine so I blacklisted the rtc-efi module (which was the offender

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 6:17 AM, Steven Noonan ste...@uplinklabs.net wrote: On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan ste...@uplinklabs.net wrote: I've been getting general protection faults in EFI modules at boot time across several machines. I originally thought it was just an EFI quirk

Re: EFI-related general protection faults

2014-11-01 Thread Steven Noonan
On Sat, Nov 1, 2014 at 2:43 PM, Steven Noonan ste...@uplinklabs.net wrote: On Sat, Nov 1, 2014 at 6:17 AM, Steven Noonan ste...@uplinklabs.net wrote: On Sat, Nov 1, 2014 at 6:00 AM, Steven Noonan ste...@uplinklabs.net wrote: I've been getting general protection faults in EFI modules at boot

[tip:core/urgent] compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles

2014-10-28 Thread tip-bot for Steven Noonan
Commit-ID: 5631b8fba640a4ab2f8a954f63a603fa34eda96b Gitweb: http://git.kernel.org/tip/5631b8fba640a4ab2f8a954f63a603fa34eda96b Author: Steven Noonan AuthorDate: Sat, 25 Oct 2014 15:09:42 -0700 Committer: Ingo Molnar CommitDate: Tue, 28 Oct 2014 11:03:40 +0100 compiler/gcc4+: Remove

[tip:core/urgent] compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles

2014-10-28 Thread tip-bot for Steven Noonan
Commit-ID: 5631b8fba640a4ab2f8a954f63a603fa34eda96b Gitweb: http://git.kernel.org/tip/5631b8fba640a4ab2f8a954f63a603fa34eda96b Author: Steven Noonan ste...@uplinklabs.net AuthorDate: Sat, 25 Oct 2014 15:09:42 -0700 Committer: Ingo Molnar mi...@kernel.org CommitDate: Tue, 28 Oct 2014 11

[PATCH] compiler-gcc*.h: remove inaccurate comment about 'asm goto' miscompiles

2014-10-25 Thread Steven Noonan
a9f18034) I left a comment in that claimed the bug was fixed in GCC 4.8.2+. This comment is inaccurate, and should be removed. [1] https://lkml.org/lkml/2014/2/12/797 Signed-off-by: Steven Noonan Cc: Ingo Molnar --- include/linux/compiler-gcc4.h | 1 - include/linux/compiler-gcc5.h | 1 - 2

[PATCH] compiler-gcc*.h: remove inaccurate comment about 'asm goto' miscompiles

2014-10-25 Thread Steven Noonan
a9f18034) I left a comment in that claimed the bug was fixed in GCC 4.8.2+. This comment is inaccurate, and should be removed. [1] https://lkml.org/lkml/2014/2/12/797 Signed-off-by: Steven Noonan ste...@uplinklabs.net Cc: Ingo Molnar mi...@kernel.org --- include/linux/compiler-gcc4.h | 1

Re: [compiler/gcc4] a9f180345f5: -100.0% last_state.is_incomplete_run

2014-10-02 Thread Steven Noonan
On Tue, Sep 30, 2014 at 1:14 AM, Fengguang Wu wrote: > Hi Steven, > > FYI, we noticed that your commit a9f180345f5378ac87d80ed0bea55ba421d83859 > ("compiler/gcc4: Make quirk for asm_volatile_goto() unconditional") fixed > a number of machine boot failures in our LKP test farm. This is really >

Re: [compiler/gcc4] a9f180345f5: -100.0% last_state.is_incomplete_run

2014-10-02 Thread Steven Noonan
On Tue, Sep 30, 2014 at 1:14 AM, Fengguang Wu fengguang...@intel.com wrote: Hi Steven, FYI, we noticed that your commit a9f180345f5378ac87d80ed0bea55ba421d83859 (compiler/gcc4: Make quirk for asm_volatile_goto() unconditional) fixed a number of machine boot failures in our LKP test farm. This

Re: Thunderbolt driver hotplug not working correctly

2014-08-15 Thread Steven Noonan
On Wed, Aug 13, 2014 at 4:05 PM, Andreas Noever wrote: > Hello Steven, > > I think that there are two problems: > - The Kernel does not notice that the device is gone. > - The first hotplug operation, after removing a coldplugged device fails. > > For the first one could you check whether thie

Re: Thunderbolt driver hotplug not working correctly

2014-08-15 Thread Steven Noonan
On Tue, Aug 12, 2014 at 3:55 PM, Andreas Noever wrote: > On Tue, Aug 12, 2014 at 11:01 AM, Steven Noonan wrote: >> Hello Andreas, >> >> I'm trying out the new Thunderbolt driver in Linus' tree and I'm >> noticing device hotplug isn't quite working correctly. >> &

Re: Thunderbolt driver hotplug not working correctly

2014-08-15 Thread Steven Noonan
On Tue, Aug 12, 2014 at 3:55 PM, Andreas Noever andreas.noe...@gmail.com wrote: On Tue, Aug 12, 2014 at 11:01 AM, Steven Noonan ste...@uplinklabs.net wrote: Hello Andreas, I'm trying out the new Thunderbolt driver in Linus' tree and I'm noticing device hotplug isn't quite working correctly

Re: Thunderbolt driver hotplug not working correctly

2014-08-15 Thread Steven Noonan
On Wed, Aug 13, 2014 at 4:05 PM, Andreas Noever andreas.noe...@gmail.com wrote: Hello Steven, I think that there are two problems: - The Kernel does not notice that the device is gone. - The first hotplug operation, after removing a coldplugged device fails. For the first one could you

Re: wlwifi - Microcode SW error detected.

2014-08-12 Thread Steven Noonan
I'm seeing this on linus/master right now... $ uname -r 3.16.0-ec2-10567-gc7a19c7 $ dmesg [...] [ 32.450641] ieee80211 phy0: Hardware restart was requested [ 32.451124] iwlwifi :04:00.0: L1 Enabled; Disabling L0S [ 32.451457] iwlwifi :04:00.0: L1 Enabled; Disabling L0S [

Thunderbolt driver hotplug not working correctly

2014-08-12 Thread Steven Noonan
Hello Andreas, I'm trying out the new Thunderbolt driver in Linus' tree and I'm noticing device hotplug isn't quite working correctly. I've got a Haswell 2013 MacBook Pro Retina and the Apple-vended Thunderbolt Ethernet adapter, which uses the tg3 driver. Here's what dmesg says when I unplug:

Thunderbolt driver hotplug not working correctly

2014-08-12 Thread Steven Noonan
Hello Andreas, I'm trying out the new Thunderbolt driver in Linus' tree and I'm noticing device hotplug isn't quite working correctly. I've got a Haswell 2013 MacBook Pro Retina and the Apple-vended Thunderbolt Ethernet adapter, which uses the tg3 driver. Here's what dmesg says when I unplug:

Re: wlwifi - Microcode SW error detected.

2014-08-12 Thread Steven Noonan
I'm seeing this on linus/master right now... $ uname -r 3.16.0-ec2-10567-gc7a19c7 $ dmesg [...] [ 32.450641] ieee80211 phy0: Hardware restart was requested [ 32.451124] iwlwifi :04:00.0: L1 Enabled; Disabling L0S [ 32.451457] iwlwifi :04:00.0: L1 Enabled; Disabling L0S [

[PATCH 1/2 v2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
for developer errors when making those comparisons. Suggested-by: Linus Torvalds Cc: NeilBrown Cc: Al Viro Signed-off-by: Steven Noonan --- v2: d_count() function was unsigned and there was another cast inside autofs4. Fixed those as well. fs/autofs4/root.c | 2 +- fs/dcache.c | 6

Re: [PATCH 1/2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
On Tue, Aug 5, 2014 at 2:44 PM, NeilBrown wrote: > On Tue, 5 Aug 2014 12:52:27 -0700 Steven Noonan > wrote: > >> There are numerous places where this is casted to a signed value anyway, for >> comparisons checking that the value hasn't been set to the 'dead' value of >&

[PATCH 2/2] lockref: replace lockref_get_not_zero with lockref_get_active

2014-08-05 Thread Steven Noonan
l Viro Signed-off-by: Steven Noonan --- fs/dcache.c | 2 +- include/linux/lockref.h | 2 +- lib/lockref.c | 13 +++-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index f7a592e..66ee98e 100644 --- a/fs/dcache.c +++ b/fs/dc

[PATCH 1/2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
for developer errors when making those comparisons. Suggested-by: Linus Torvalds Cc: NeilBrown Cc: Al Viro Signed-off-by: Steven Noonan --- fs/dcache.c | 6 +++--- include/linux/lockref.h | 2 +- lib/lockref.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 2/2] lockref: replace lockref_get_not_zero with lockref_get_active

2014-08-05 Thread Steven Noonan
: NeilBrown ne...@suse.de Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Steven Noonan ste...@uplinklabs.net --- fs/dcache.c | 2 +- include/linux/lockref.h | 2 +- lib/lockref.c | 13 +++-- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/dcache.c b

[PATCH 1/2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
for developer errors when making those comparisons. Suggested-by: Linus Torvalds torva...@linux-foundation.org Cc: NeilBrown ne...@suse.de Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Steven Noonan ste...@uplinklabs.net --- fs/dcache.c | 6 +++--- include/linux/lockref.h | 2 +- lib

Re: [PATCH 1/2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
On Tue, Aug 5, 2014 at 2:44 PM, NeilBrown ne...@suse.de wrote: On Tue, 5 Aug 2014 12:52:27 -0700 Steven Noonan ste...@uplinklabs.net wrote: There are numerous places where this is casted to a signed value anyway, for comparisons checking that the value hasn't been set to the 'dead' value

[PATCH 1/2 v2] lockref: make lockref count signed

2014-08-05 Thread Steven Noonan
for developer errors when making those comparisons. Suggested-by: Linus Torvalds torva...@linux-foundation.org Cc: NeilBrown ne...@suse.de Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Steven Noonan ste...@uplinklabs.net --- v2: d_count() function was unsigned and there was another cast inside autofs4

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 4, 2014 at 9:54 PM, Steven Noonan wrote: > On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: >> On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown wrote: >> > >> > I've been looking at last year's change to dentry refcounting which sets >

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: > On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown wrote: > > > > I've been looking at last year's change to dentry refcounting which sets > > the > > refcount to -128 (mark_dead()) when the dentry is gone. > > > > As this is an

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown ne...@suse.de wrote: I've been looking at last year's change to dentry refcounting which sets the refcount to -128 (mark_dead()) when the dentry is gone. As this is an

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 4, 2014 at 9:54 PM, Steven Noonan ste...@uplinklabs.net wrote: On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown ne...@suse.de wrote: I've been looking at last year's change to dentry refcounting which sets

Re: [PATCH] x86, efi: print debug values in Kib not MB

2014-07-29 Thread Steven Noonan
On Tue, Jul 29, 2014 at 3:54 PM, Prarit Bhargava wrote: > > > On 07/29/2014 06:36 PM, Borislav Petkov wrote: >> On Tue, Jul 29, 2014 at 06:32:56PM -0400, Prarit Bhargava wrote: >>> and it was best to keep the code simple with a KiB. >> >> You're missing the point - the output doesn't get simple

Re: [PATCH] x86, efi: print debug values in Kib not MB

2014-07-29 Thread Steven Noonan
On Tue, Jul 29, 2014 at 3:54 PM, Prarit Bhargava pra...@redhat.com wrote: On 07/29/2014 06:36 PM, Borislav Petkov wrote: On Tue, Jul 29, 2014 at 06:32:56PM -0400, Prarit Bhargava wrote: and it was best to keep the code simple with a KiB. You're missing the point - the output doesn't get

Re: general protection fault on 3.15.6

2014-07-25 Thread Steven Noonan
On Fri, Jul 25, 2014 at 9:42 PM, Steven Noonan wrote: > On Thu, Jul 24, 2014 at 12:06 AM, Alexander Holler > wrote: >> Am 23.07.2014 19:50, schrieb Steven Noonan: >> >>> (Oops, LKML doesn't like rich text, resending. Was trying to avoid >>> GMail's bad line

Re: general protection fault on 3.15.6

2014-07-25 Thread Steven Noonan
On Thu, Jul 24, 2014 at 12:06 AM, Alexander Holler wrote: > Am 23.07.2014 19:50, schrieb Steven Noonan: > >> (Oops, LKML doesn't like rich text, resending. Was trying to avoid >> GMail's bad line wrapping. Going to use Mutt instead.) >> >> I'm starting to wonder if i

Re: general protection fault on 3.15.6

2014-07-25 Thread Steven Noonan
On Thu, Jul 24, 2014 at 12:06 AM, Alexander Holler hol...@ahsoftware.de wrote: Am 23.07.2014 19:50, schrieb Steven Noonan: (Oops, LKML doesn't like rich text, resending. Was trying to avoid GMail's bad line wrapping. Going to use Mutt instead.) I'm starting to wonder if it's bad RAM

Re: general protection fault on 3.15.6

2014-07-25 Thread Steven Noonan
On Fri, Jul 25, 2014 at 9:42 PM, Steven Noonan ste...@uplinklabs.net wrote: On Thu, Jul 24, 2014 at 12:06 AM, Alexander Holler hol...@ahsoftware.de wrote: Am 23.07.2014 19:50, schrieb Steven Noonan: (Oops, LKML doesn't like rich text, resending. Was trying to avoid GMail's bad line wrapping

Re: general protection fault on 3.15.6

2014-07-23 Thread Steven Noonan
: [] ? copy_module_from_fd.isra.39+0x111/0x170 Jul 23 09:43:20 orcus kernel: [] SyS_finit_module+0x7e/0x80 Jul 23 09:43:20 orcus kernel: [] system_call_fastpath+0x1a/0x1f Jul 23 09:43:20 orcus kernel: ---[ end trace 71a1e508f45dbd1d ]--- On Mon, Jul 21, 2014 at 10:41:45AM -0700, Steven Noonan wrote

Re: general protection fault on 3.15.6

2014-07-23 Thread Steven Noonan
-0700, Steven Noonan wrote: On Mon, Jul 21, 2014 at 6:29 AM, Tejun Heo t...@kernel.org wrote: Hello, Steven. On Sun, Jul 20, 2014 at 09:27:42PM -0700, Steven Noonan wrote: My router/storage box suddenly stopped responding (originally noticed because dnsmasq wasn't responding) and I had

Re: general protection fault on 3.15.6

2014-07-21 Thread Steven Noonan
On Mon, Jul 21, 2014 at 6:29 AM, Tejun Heo wrote: > Hello, Steven. > > On Sun, Jul 20, 2014 at 09:27:42PM -0700, Steven Noonan wrote: >> My router/storage box suddenly stopped responding (originally noticed >> because dnsmasq wasn't responding) and I had to reboot it. I c

Re: general protection fault on 3.15.6

2014-07-21 Thread Steven Noonan
On Mon, Jul 21, 2014 at 6:29 AM, Tejun Heo t...@kernel.org wrote: Hello, Steven. On Sun, Jul 20, 2014 at 09:27:42PM -0700, Steven Noonan wrote: My router/storage box suddenly stopped responding (originally noticed because dnsmasq wasn't responding) and I had to reboot it. I checked

general protection fault on 3.15.6

2014-07-20 Thread Steven Noonan
My router/storage box suddenly stopped responding (originally noticed because dnsmasq wasn't responding) and I had to reboot it. I checked the systemd journal when it came back and these were the last thing in there for the previous boot. Any ideas about pinning down the cause? general protection

general protection fault on 3.15.6

2014-07-20 Thread Steven Noonan
My router/storage box suddenly stopped responding (originally noticed because dnsmasq wasn't responding) and I had to reboot it. I checked the systemd journal when it came back and these were the last thing in there for the previous boot. Any ideas about pinning down the cause? general protection

Re: Linux 3.15.2

2014-06-26 Thread Steven Noonan
On Thu, Jun 26, 2014 at 5:23 PM, Josh Boyer wrote: > On Thu, Jun 26, 2014 at 3:26 PM, Greg KH wrote: >> I'm announcing the release of the 3.15.2 kernel. >> >> All users of the 3.15 kernel series must upgrade. >> >> The updated 3.15.y git tree can be found at: >> >>

Re: Linux 3.15.2

2014-06-26 Thread Steven Noonan
On Thu, Jun 26, 2014 at 5:23 PM, Josh Boyer jwbo...@fedoraproject.org wrote: On Thu, Jun 26, 2014 at 3:26 PM, Greg KH gre...@linuxfoundation.org wrote: I'm announcing the release of the 3.15.2 kernel. All users of the 3.15 kernel series must upgrade. The updated 3.15.y git tree can be found

Re: [Intel-gfx] REGRESSION 3.14 i915 warning & mouse cursor vanishing

2014-06-10 Thread Steven Noonan
On Wed, Apr 16, 2014 at 3:03 PM, Steven Noonan wrote: > On Wed, Apr 16, 2014 at 2:46 PM, Jani Nikula > wrote: >> On Tue, 15 Apr 2014, Imre Deak wrote: >>> On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: >>>> On Mon, Apr 14, 2014 at 11:56:03AM -0700, S

Re: [PATCH] tell gcc optimizer to never introduce new data races

2014-06-10 Thread Steven Noonan
On Tue, Jun 10, 2014 at 10:46 AM, Linus Torvalds wrote: > On Tue, Jun 10, 2014 at 6:23 AM, Jiri Kosina wrote: >> We have been chasing a memory corruption bug, which turned out to be >> caused by very old gcc (4.3.4), which happily turned conditional load into >> a non-conditional one, and that

Re: [PATCH] tell gcc optimizer to never introduce new data races

2014-06-10 Thread Steven Noonan
On Tue, Jun 10, 2014 at 10:46 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Jun 10, 2014 at 6:23 AM, Jiri Kosina jkos...@suse.cz wrote: We have been chasing a memory corruption bug, which turned out to be caused by very old gcc (4.3.4), which happily turned conditional load

Re: [Intel-gfx] REGRESSION 3.14 i915 warning mouse cursor vanishing

2014-06-10 Thread Steven Noonan
On Wed, Apr 16, 2014 at 3:03 PM, Steven Noonan ste...@uplinklabs.net wrote: On Wed, Apr 16, 2014 at 2:46 PM, Jani Nikula jani.nik...@linux.intel.com wrote: On Tue, 15 Apr 2014, Imre Deak imre.d...@intel.com wrote: On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: On Mon, Apr 14, 2014

Re: [Intel-gfx] REGRESSION 3.14 i915 warning & mouse cursor vanishing

2014-04-16 Thread Steven Noonan
On Wed, Apr 16, 2014 at 2:46 PM, Jani Nikula wrote: > On Tue, 15 Apr 2014, Imre Deak wrote: >> On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: >>> On Mon, Apr 14, 2014 at 11:56:03AM -0700, Steven Noonan wrote: >>> > On Mon, Apr 14, 2014 at 11:35:0

Re: [Intel-gfx] REGRESSION 3.14 i915 warning mouse cursor vanishing

2014-04-16 Thread Steven Noonan
On Wed, Apr 16, 2014 at 2:46 PM, Jani Nikula jani.nik...@linux.intel.com wrote: On Tue, 15 Apr 2014, Imre Deak imre.d...@intel.com wrote: On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: On Mon, Apr 14, 2014 at 11:56:03AM -0700, Steven Noonan wrote: On Mon, Apr 14, 2014 at 11:35:05AM

Re: [Intel-gfx] REGRESSION 3.14 i915 warning & mouse cursor vanishing

2014-04-15 Thread Steven Noonan
On Tue, Apr 15, 2014 at 12:59 PM, Imre Deak wrote: > On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: >> On Mon, Apr 14, 2014 at 11:56:03AM -0700, Steven Noonan wrote: >> > On Mon, Apr 14, 2014 at 11:35:05AM -0700, Keith Packard wrote: >> &

Re: [Intel-gfx] REGRESSION 3.14 i915 warning mouse cursor vanishing

2014-04-15 Thread Steven Noonan
On Tue, Apr 15, 2014 at 12:59 PM, Imre Deak imre.d...@intel.com wrote: On Tue, 2014-04-15 at 21:43 +0200, Daniel Vetter wrote: On Mon, Apr 14, 2014 at 11:56:03AM -0700, Steven Noonan wrote: On Mon, Apr 14, 2014 at 11:35:05AM -0700, Keith Packard wrote: Steven Noonan ste...@uplinklabs.net

Re: REGRESSION 3.14 i915 warning & mouse cursor vanishing

2014-04-14 Thread Steven Noonan
On Mon, Apr 14, 2014 at 11:35:05AM -0700, Keith Packard wrote: > Steven Noonan writes: > > > Was using my machine normally, then my mouse cursor vanished. After > > switching > > to a VT and back to X11, my cursor came back. But I did notice a nasty > > trace in &

REGRESSION 3.14 i915 warning & mouse cursor vanishing

2014-04-14 Thread Steven Noonan
Was using my machine normally, then my mouse cursor vanished. After switching to a VT and back to X11, my cursor came back. But I did notice a nasty trace in dmesg (below). I have a few options specified on my command line related to i915, but these worked fine through 3.13.9:

REGRESSION 3.14 i915 warning mouse cursor vanishing

2014-04-14 Thread Steven Noonan
Was using my machine normally, then my mouse cursor vanished. After switching to a VT and back to X11, my cursor came back. But I did notice a nasty trace in dmesg (below). I have a few options specified on my command line related to i915, but these worked fine through 3.13.9:

Re: REGRESSION 3.14 i915 warning mouse cursor vanishing

2014-04-14 Thread Steven Noonan
On Mon, Apr 14, 2014 at 11:35:05AM -0700, Keith Packard wrote: Steven Noonan ste...@uplinklabs.net writes: Was using my machine normally, then my mouse cursor vanished. After switching to a VT and back to X11, my cursor came back. But I did notice a nasty trace in dmesg (below

Re: [PATCH 3.13 08/22] Revert "xen: properly account for _PAGE_NUMA during xen pte translations"

2014-04-10 Thread Steven Noonan
I realize it's late to protest on this given that 3.13.9 is out, but what is the path forward for those experiencing the original issue that the reverted commit was intended to correct? http://marc.info/?l=linux-kernel=139034684731087=2 On Mon, Mar 31, 2014 at 9:08 PM, Greg Kroah-Hartman wrote:

Re: [PATCH 3.13 08/22] Revert xen: properly account for _PAGE_NUMA during xen pte translations

2014-04-10 Thread Steven Noonan
I realize it's late to protest on this given that 3.13.9 is out, but what is the path forward for those experiencing the original issue that the reverted commit was intended to correct? http://marc.info/?l=linux-kernelm=139034684731087w=2 On Mon, Mar 31, 2014 at 9:08 PM, Greg Kroah-Hartman

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-08 Thread Steven Noonan
On Tue, Apr 8, 2014 at 8:16 AM, H. Peter Anvin wrote: > > > Of course, it would also be preferable if Amazon (or anything else) didn't > need Xen PV :( Well Amazon doesn't expose NUMA on PV, only on HVM guests. > On April 7, 2014 9:04:53 PM PDT, Steven Noonan wrote: >&g

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-08 Thread Steven Noonan
On Tue, Apr 8, 2014 at 8:16 AM, H. Peter Anvin h...@zytor.com wrote: snark Of course, it would also be preferable if Amazon (or anything else) didn't need Xen PV :( Well Amazon doesn't expose NUMA on PV, only on HVM guests. On April 7, 2014 9:04:53 PM PDT, Steven Noonan ste

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-07 Thread Steven Noonan
On Mon, Apr 7, 2014 at 2:25 PM, Mel Gorman wrote: > On Mon, Apr 07, 2014 at 12:42:40PM -0700, H. Peter Anvin wrote: >> On 04/07/2014 12:36 PM, Cyrill Gorcunov wrote: >> > On Mon, Apr 07, 2014 at 12:27:10PM -0700, H. Peter Anvin wrote: >> >> On 04/07/2014 11:28 AM, Mel Gorman wrote: >> >>> >> >>>

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-07 Thread Steven Noonan
On Mon, Apr 7, 2014 at 2:25 PM, Mel Gorman mgor...@suse.de wrote: On Mon, Apr 07, 2014 at 12:42:40PM -0700, H. Peter Anvin wrote: On 04/07/2014 12:36 PM, Cyrill Gorcunov wrote: On Mon, Apr 07, 2014 at 12:27:10PM -0700, H. Peter Anvin wrote: On 04/07/2014 11:28 AM, Mel Gorman wrote: I had

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-22 Thread Steven Noonan
On Fri, Feb 21, 2014 at 12:07 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 20, 2014 at 12:44:15PM -0800, Steven Noonan wrote: >> On Wed, Feb 19, 2014 at 1:01 PM, Steven Noonan wrote: >> > On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk >> > wrote: >>

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-22 Thread Steven Noonan
On Fri, Feb 21, 2014 at 12:07 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Thu, Feb 20, 2014 at 12:44:15PM -0800, Steven Noonan wrote: On Wed, Feb 19, 2014 at 1:01 PM, Steven Noonan ste...@uplinklabs.net wrote: On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk konrad.w

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-20 Thread Steven Noonan
On Wed, Feb 19, 2014 at 1:01 PM, Steven Noonan wrote: > On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk > wrote: >> On Tue, Feb 18, 2014 at 11:16:05PM -0800, Steven Noonan wrote: >>> I've been running into problems on an Xen HVM domU. I've got a guest with >&

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-20 Thread Steven Noonan
On Wed, Feb 19, 2014 at 1:01 PM, Steven Noonan ste...@uplinklabs.net wrote: On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Tue, Feb 18, 2014 at 11:16:05PM -0800, Steven Noonan wrote: I've been running into problems on an Xen HVM domU. I've got a guest

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-19 Thread Steven Noonan
On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 18, 2014 at 11:16:05PM -0800, Steven Noonan wrote: >> I've been running into problems on an Xen HVM domU. I've got a guest with >> NUMA >> enabled, 60GB of RAM, and 3 disks attached (incl

Re: [BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-19 Thread Steven Noonan
On Wed, Feb 19, 2014 at 9:41 AM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Tue, Feb 18, 2014 at 11:16:05PM -0800, Steven Noonan wrote: I've been running into problems on an Xen HVM domU. I've got a guest with NUMA enabled, 60GB of RAM, and 3 disks attached (including root volume

[BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-18 Thread Steven Noonan
I've been running into problems on an Xen HVM domU. I've got a guest with NUMA enabled, 60GB of RAM, and 3 disks attached (including root volume). 2 of the disks are in an MD RAID0 in the guest, with an ext4 filesystem on top of that. I was running the fio 'iometer-file-access-server.fio' example

[BISECTED] Xen HVM guest hangs since 3.12-rc5

2014-02-18 Thread Steven Noonan
I've been running into problems on an Xen HVM domU. I've got a guest with NUMA enabled, 60GB of RAM, and 3 disks attached (including root volume). 2 of the disks are in an MD RAID0 in the guest, with an ext4 filesystem on top of that. I was running the fio 'iometer-file-access-server.fio' example

  1   2   >