Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Sujit Reddy Thumma
On 5/28/2014 4:24 PM, Christoph Hellwig wrote: I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2):

Re: [ANNOUNCE] scsi patch queue tree

2014-05-28 Thread Sujit Reddy Thumma
On 5/28/2014 4:24 PM, Christoph Hellwig wrote: I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2):

Re: linux-next: build warning after merge of the scsi tree

2013-09-04 Thread Sujit Reddy Thumma
On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote: On 9/2/2013 1:58 PM, Stephen Rothwell wrote: Hi James, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler': drivers/scsi/ufs

Re: linux-next: build warning after merge of the scsi tree

2013-09-04 Thread Sujit Reddy Thumma
On 9/2/2013 1:58 PM, Stephen Rothwell wrote: Hi James, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler': drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is

Re: linux-next: build warning after merge of the scsi tree

2013-09-04 Thread Sujit Reddy Thumma
On 9/2/2013 1:58 PM, Stephen Rothwell wrote: Hi James, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler': drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is

Re: linux-next: build warning after merge of the scsi tree

2013-09-04 Thread Sujit Reddy Thumma
On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote: On 9/2/2013 1:58 PM, Stephen Rothwell wrote: Hi James, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler': drivers/scsi/ufs

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
On 7/2/2013 8:34 AM, Aaron Lu wrote: Fix this by releasing spin_lock_irq() before calling >pm_runtime_autosuspend() in blk_post_runtime_resume(). Hi Sujit, Thanks for testing out block layer runtime PM! As for the problem here, it is already fixed by: commit

[PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
+0x1ac/0x2ac) from [] (kthread+0x88/0x94) from [] (kernel_thread_exit+0x0/0x8) Fix this by releasing spin_lock_irq() before calling pm_runtime_autosuspend() in blk_post_runtime_resume(). Signed-off-by: Sujit Reddy Thumma Cc: sta...@vger.kernel.org --- block/blk-core.c |6 -- 1 files

[PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
-by: Sujit Reddy Thumma sthu...@codeaurora.org Cc: sta...@vger.kernel.org --- block/blk-core.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 33c33bc..2456116 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -3159,16

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread Sujit Reddy Thumma
On 7/2/2013 8:34 AM, Aaron Lu wrote: Fix this by releasing spin_lock_irq() before calling pm_runtime_autosuspend() in blk_post_runtime_resume(). Hi Sujit, Thanks for testing out block layer runtime PM! As for the problem here, it is already fixed by: commit

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-14 Thread Sujit Reddy Thumma
On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote: static struct scsi_host_template ufshcd_driver_template = { @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct ufs_hba **hba_handle, /* Configure LRB */ ufshcd_host_memory_configure(hba); - host->can_qu

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-14 Thread Sujit Reddy Thumma
On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote: static struct scsi_host_template ufshcd_driver_template = { @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct ufs_hba **hba_handle, /* Configure LRB */ ufshcd_host_memory_configure(hba); - host-can_queue

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-12 Thread Sujit Reddy Thumma
On 6/12/2013 11:04 AM, Santosh Y wrote: /** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor: buffer for sending/receiving descriptor + * @retries: number of times to try executing

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-12 Thread Sujit Reddy Thumma
On 6/12/2013 11:00 AM, Santosh Y wrote: +/* + * ufshcd_wait_for_register - wait for register value to change + * @hba - per-adapter interface + * @reg - mmio register offset + * @mask - mask to apply to read register value + * @val - wait condition + * @interval_us - polling interval in

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-12 Thread Sujit Reddy Thumma
On 6/12/2013 11:00 AM, Santosh Y wrote: +/* + * ufshcd_wait_for_register - wait for register value to change + * @hba - per-adapter interface + * @reg - mmio register offset + * @mask - mask to apply to read register value + * @val - wait condition + * @interval_us - polling interval in

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-12 Thread Sujit Reddy Thumma
On 6/12/2013 11:04 AM, Santosh Y wrote: /** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor: buffer for sending/receiving descriptor + * @retries: number of times to try executing

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:49 PM, Santosh Y wrote: -static inline void -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) +static int ufshcd_send_uic_command(struct ufs_hba *hba, + struct uic_command *uic_cmnd, int retries) { + int err = 0; + unsigned

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:57 PM, Santosh Y wrote: + +/** + * ufshcd_validate_dev_connection() - Check device connection status + * @hba: per-adapter instance + * + * Send NOP OUT UPIU and wait for NOP IN response to check whether the + * device Transport Protocol (UTP) layer is ready after a reset. + * If

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:57 PM, Santosh Y wrote: + +/** + * ufshcd_validate_dev_connection() - Check device connection status + * @hba: per-adapter instance + * + * Send NOP OUT UPIU and wait for NOP IN response to check whether the + * device Transport Protocol (UTP) layer is ready after a reset. + * If

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:49 PM, Santosh Y wrote: -static inline void -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) +static int ufshcd_send_uic_command(struct ufs_hba *hba, + struct uic_command *uic_cmnd, int retries) { + int err = 0; + unsigned

[PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-04-24 Thread Sujit Reddy Thumma
the device connection path and test whether the UTP layer on the device side is functional during initialization. Signed-off-by: Sujit Reddy Thumma --- drivers/scsi/ufs/ufshcd.c | 167 ++--- drivers/scsi/ufs/ufshcd.h |4 + 2 files changed, 162 insertions

[PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-04-24 Thread Sujit Reddy Thumma
the device connection path and test whether the UTP layer on the device side is functional during initialization. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org --- drivers/scsi/ufs/ufshcd.c | 167 ++--- drivers/scsi/ufs/ufshcd.h |4 + 2 files

[PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-04-23 Thread Sujit Reddy Thumma
at a time. Further, the command completion for DME_LINKSTARTUP is modified and the command completes in the context of the caller instead of a separate work. Signed-off-by: Sujit Reddy Thumma --- drivers/scsi/ufs/ufshcd.c | 257 + drivers/scsi/ufs

[PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-04-23 Thread Sujit Reddy Thumma
at a time. Further, the command completion for DME_LINKSTARTUP is modified and the command completes in the context of the caller instead of a separate work. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org --- drivers/scsi/ufs/ufshcd.c | 257