Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-25 Thread Suman Anna
Hi Arnaud, > On 09/25/2018 02:25 AM, Suman Anna wrote: >> Hi Srinivas, >> >> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >>> Some of the rpmsg devices need to switch on power domains to communicate >>> with remote processor. For example on Qualcomm

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-25 Thread Suman Anna
Hi Srini, On 09/25/2018 03:29 AM, Srinivas Kandagatla wrote: > Hi Suman, > > On 25/09/18 01:25, Suman Anna wrote: >> Hi Srinivas, >> >> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >>> Some of the rpmsg devices need to switch on power domains to c

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-25 Thread Suman Anna
Hi Srini, On 09/25/2018 03:29 AM, Srinivas Kandagatla wrote: > Hi Suman, > > On 25/09/18 01:25, Suman Anna wrote: >> Hi Srinivas, >> >> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >>> Some of the rpmsg devices need to switch on power domains to c

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-24 Thread Suman Anna
Hi Srinivas, On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: > Some of the rpmsg devices need to switch on power domains to communicate > with remote processor. For example on Qualcomm DB820c platform LPASS > power domain needs to switched on for any kind of audio services. > This patch adds

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-24 Thread Suman Anna
Hi Srinivas, On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: > Some of the rpmsg devices need to switch on power domains to communicate > with remote processor. For example on Qualcomm DB820c platform LPASS > power domain needs to switched on for any kind of audio services. > This patch adds

[PATCH 2/5] remoteproc: Check for NULL firmwares in sysfs interface

2018-09-14 Thread Suman Anna
on. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 2142b3ea726e..ce93f4d710f3 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b

[PATCH 2/5] remoteproc: Check for NULL firmwares in sysfs interface

2018-09-14 Thread Suman Anna
on. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 2142b3ea726e..ce93f4d710f3 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b

[PATCH 3/5] remoteproc: Add missing kernel-doc comment for auto-boot

2018-09-14 Thread Suman Anna
The commit ddf711872c9d ("remoteproc: Introduce auto-boot flag") introduced the auto-boot flag but missed adding the corresponding kernel-doc comment. Add the same. Signed-off-by: Suman Anna --- include/linux/remoteproc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/inc

[PATCH 1/5] remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs

2018-09-14 Thread Suman Anna
-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 47be411400e5..2142b3ea726e 100644 --- a/drivers/remoteproc

[PATCH 5/5] remoteproc/wkup_m3: Set deny_sysfs_ops flag

2018-09-14 Thread Suman Anna
The Wakeup M3 remote processor is controlled by the wkup_m3_ipc client driver, so set the newly introduced 'deny_sysfs_ops' flag to not allow any overriding of the remoteproc firmware or state from userspace. Signed-off-by: Suman Anna --- drivers/remoteproc/wkup_m3_rproc.c | 1 + 1 file changed

[PATCH 0/5] remoteproc sysfs fixes/improvements

2018-09-14 Thread Suman Anna
, and usage of it by Wkup M3 remoteproc driver regards Suman Suman Anna (5): remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs remoteproc: Check for NULL firmwares in sysfs interface remoteproc: Add missing kernel-doc comment for auto-boot remoteproc: Introduce

[PATCH 4/5] remoteproc: Introduce deny_sysfs_ops flag

2018-09-14 Thread Suman Anna
state/firmware change by introducing a state flag 'deny_sysfs_ops' that the individual remoteproc drivers can set based on their usage needs. The default behavior is to allow the sysfs operations as before. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 8 include

[PATCH 1/5] remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs

2018-09-14 Thread Suman Anna
-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 47be411400e5..2142b3ea726e 100644 --- a/drivers/remoteproc

[PATCH 5/5] remoteproc/wkup_m3: Set deny_sysfs_ops flag

2018-09-14 Thread Suman Anna
The Wakeup M3 remote processor is controlled by the wkup_m3_ipc client driver, so set the newly introduced 'deny_sysfs_ops' flag to not allow any overriding of the remoteproc firmware or state from userspace. Signed-off-by: Suman Anna --- drivers/remoteproc/wkup_m3_rproc.c | 1 + 1 file changed

[PATCH 0/5] remoteproc sysfs fixes/improvements

2018-09-14 Thread Suman Anna
, and usage of it by Wkup M3 remoteproc driver regards Suman Suman Anna (5): remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs remoteproc: Check for NULL firmwares in sysfs interface remoteproc: Add missing kernel-doc comment for auto-boot remoteproc: Introduce

[PATCH 4/5] remoteproc: Introduce deny_sysfs_ops flag

2018-09-14 Thread Suman Anna
state/firmware change by introducing a state flag 'deny_sysfs_ops' that the individual remoteproc drivers can set based on their usage needs. The default behavior is to allow the sysfs operations as before. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_sysfs.c | 8 include

[PATCH 3/5] remoteproc: Add missing kernel-doc comment for auto-boot

2018-09-14 Thread Suman Anna
The commit ddf711872c9d ("remoteproc: Introduce auto-boot flag") introduced the auto-boot flag but missed adding the corresponding kernel-doc comment. Add the same. Signed-off-by: Suman Anna --- include/linux/remoteproc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/inc

[PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-09-11 Thread Suman Anna
The current rpmsg_client_sample uses a fixed number of messages to be sent to each instance. This is currently set at 100. Introduce an optional module parameter 'count' so that the number of messages to be exchanged can be made flexible. Signed-off-by: Suman Anna --- samples/rpmsg

[PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-09-11 Thread Suman Anna
The current rpmsg_client_sample uses a fixed number of messages to be sent to each instance. This is currently set at 100. Introduce an optional module parameter 'count' so that the number of messages to be exchanged can be made flexible. Signed-off-by: Suman Anna --- samples/rpmsg

Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

2018-08-16 Thread Suman Anna
On 08/16/2018 07:49 PM, Bjorn Andersson wrote: > da8xx_rproc_mem size is of type size_t, so use %zx to format the debug > print of it to avoid a compile warning. > Thanks for the improvement, Acked-by: Suman Anna > Signed-off-by: Bjorn Andersson > --- > drivers/remoteproc/

Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

2018-08-16 Thread Suman Anna
On 08/16/2018 07:49 PM, Bjorn Andersson wrote: > da8xx_rproc_mem size is of type size_t, so use %zx to format the debug > print of it to avoid a compile warning. > Thanks for the improvement, Acked-by: Suman Anna > Signed-off-by: Bjorn Andersson > --- > drivers/remoteproc/

Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-08-13 Thread Suman Anna
Hi Bjorn, On 07/23/2018 06:27 PM, Suman Anna wrote: > The Davinci remoteproc driver does not support error recovery at > present, so mark the corresponding remoteproc flag appropriately > so that the debugfs flag shows the value as 'disabled' by default. > > Signed-off-by: Suman

Re: [PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-08-13 Thread Suman Anna
Hi Bjorn, On 07/23/2018 06:27 PM, Suman Anna wrote: > The Davinci remoteproc driver does not support error recovery at > present, so mark the corresponding remoteproc flag appropriately > so that the debugfs flag shows the value as 'disabled' by default. > > Signed-off-by: Suman

Re: New remoteproc driver for TI PRU

2018-08-06 Thread Suman Anna
Hi David, On 08/06/2018 11:32 AM, David Lechner wrote: > On 06/29/2018 07:17 PM, Suman Anna wrote: >> Hi David, >> >> On 06/29/2018 12:44 PM, David Lechner wrote: >>> On 06/29/2018 04:58 AM, Roger Quadros wrote: >>>> +Suman & Tero >>>>

Re: New remoteproc driver for TI PRU

2018-08-06 Thread Suman Anna
Hi David, On 08/06/2018 11:32 AM, David Lechner wrote: > On 06/29/2018 07:17 PM, Suman Anna wrote: >> Hi David, >> >> On 06/29/2018 12:44 PM, David Lechner wrote: >>> On 06/29/2018 04:58 AM, Roger Quadros wrote: >>>> +Suman & Tero >>>>

Re: [PATCH] remoteproc: Reset table_ptr in rproc_start() failure paths

2018-07-31 Thread Suman Anna
On 07/30/2018 11:15 PM, Bjorn Andersson wrote: > On Thu 26 Jul 18:15 PDT 2018, Suman Anna wrote: > >> Unwind the modified table_ptr and restore it to the local copy >> upon any subsequent failures in the rproc_start() function. This >> keeps the function to remain bala

Re: [PATCH] remoteproc: Reset table_ptr in rproc_start() failure paths

2018-07-31 Thread Suman Anna
On 07/30/2018 11:15 PM, Bjorn Andersson wrote: > On Thu 26 Jul 18:15 PDT 2018, Suman Anna wrote: > >> Unwind the modified table_ptr and restore it to the local copy >> upon any subsequent failures in the rproc_start() function. This >> keeps the function to remain bala

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-26 Thread Suman Anna
On 07/26/2018 06:51 PM, Suman Anna wrote: > Hi Loic, > > On 07/26/2018 02:48 AM, Loic PALLARDY wrote: >> Hi Suman, >>> >>> Hi Loic, >>> >>> On 07/06/2018 02:46 AM, Loic Pallardy wrote: >>>> If rproc_start() failed, rproc_resource_cle

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-26 Thread Suman Anna
On 07/26/2018 06:51 PM, Suman Anna wrote: > Hi Loic, > > On 07/26/2018 02:48 AM, Loic PALLARDY wrote: >> Hi Suman, >>> >>> Hi Loic, >>> >>> On 07/06/2018 02:46 AM, Loic Pallardy wrote: >>>> If rproc_start() failed, rproc_resource_cle

[PATCH] remoteproc: Reset table_ptr in rproc_start() failure paths

2018-07-26 Thread Suman Anna
between the failure labels as well. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_core.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index eadff6ce2f7f..afef2d491c5b 100644

[PATCH] remoteproc: Reset table_ptr in rproc_start() failure paths

2018-07-26 Thread Suman Anna
between the failure labels as well. Signed-off-by: Suman Anna --- drivers/remoteproc/remoteproc_core.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index eadff6ce2f7f..afef2d491c5b 100644

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-26 Thread Suman Anna
Hi Loic, On 07/26/2018 02:48 AM, Loic PALLARDY wrote: > Hi Suman, >> >> Hi Loic, >> >> On 07/06/2018 02:46 AM, Loic Pallardy wrote: >>> If rproc_start() failed, rproc_resource_cleanup() is called to clean >>> debugfs entries, then associated iommu mappings, carveouts and vdev. >>> Issue occurs

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-26 Thread Suman Anna
Hi Loic, On 07/26/2018 02:48 AM, Loic PALLARDY wrote: > Hi Suman, >> >> Hi Loic, >> >> On 07/06/2018 02:46 AM, Loic Pallardy wrote: >>> If rproc_start() failed, rproc_resource_cleanup() is called to clean >>> debugfs entries, then associated iommu mappings, carveouts and vdev. >>> Issue occurs

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_create_channel memory leak

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:08 PM, Loic Pallardy wrote: > In case of rpmsg_register_device() failure, vch previously > allocated must be free. > Isn't this already handled through the virtio_rpmsg_release_device() callback as part of the put_device() in rpmsg_register_device() failure. regards

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_create_channel memory leak

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:08 PM, Loic Pallardy wrote: > In case of rpmsg_register_device() failure, vch previously > allocated must be free. > Isn't this already handled through the virtio_rpmsg_release_device() callback as part of the put_device() in rpmsg_register_device() failure. regards

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_remove() release order

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:07 PM, Loic Pallardy wrote: > In rpmsg_remove() procedure, children are removed then Name > Service announcement endpoint is destroyed and device released. > > Issue with current implementation is if a NS announcement > creation request is ongoing (received before

Re: [PATCH 1/1] rpmsg: virtio_rpmsg_bus: Fix rpmsg_remove() release order

2018-07-25 Thread Suman Anna
Hi Loic, On 07/25/2018 04:07 PM, Loic Pallardy wrote: > In rpmsg_remove() procedure, children are removed then Name > Service announcement endpoint is destroyed and device released. > > Issue with current implementation is if a NS announcement > creation request is ongoing (received before

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-25 Thread Suman Anna
Hi Loic, On 07/06/2018 02:46 AM, Loic Pallardy wrote: > If rproc_start() failed, rproc_resource_cleanup() is called to clean > debugfs entries, then associated iommu mappings, carveouts and vdev. > Issue occurs when rproc_free_vring() is trying to reset vring resource > table entry. > At this

Re: [PATCH v2 1/1] remoteproc: correct rproc_free_vring() to avoid invalid kernel paging

2018-07-25 Thread Suman Anna
Hi Loic, On 07/06/2018 02:46 AM, Loic Pallardy wrote: > If rproc_start() failed, rproc_resource_cleanup() is called to clean > debugfs entries, then associated iommu mappings, carveouts and vdev. > Issue occurs when rproc_free_vring() is trying to reset vring resource > table entry. > At this

Re: [PATCH 1/1] remoteproc: replace "%p" with "%pK"

2018-07-25 Thread Suman Anna
On 07/06/2018 07:38 AM, Loic Pallardy wrote: > The format specifier "%p" can leak kernel addresses. > Use "%pK" instead. > > This patch proposes changes for remoteproc core only. > > Signed-off-by: Loic Pallardy Acked-by: Suman Anna > --- >

Re: [PATCH 1/1] remoteproc: replace "%p" with "%pK"

2018-07-25 Thread Suman Anna
On 07/06/2018 07:38 AM, Loic Pallardy wrote: > The format specifier "%p" can leak kernel addresses. > Use "%pK" instead. > > This patch proposes changes for remoteproc core only. > > Signed-off-by: Loic Pallardy Acked-by: Suman Anna > --- >

[PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-07-23 Thread Suman Anna
The Davinci remoteproc driver does not support error recovery at present, so mark the corresponding remoteproc flag appropriately so that the debugfs flag shows the value as 'disabled' by default. Signed-off-by: Suman Anna --- drivers/remoteproc/da8xx_remoteproc.c | 3 +++ 1 file changed, 3

[PATCH] remoteproc/davinci: Mark error recovery as disabled

2018-07-23 Thread Suman Anna
The Davinci remoteproc driver does not support error recovery at present, so mark the corresponding remoteproc flag appropriately so that the debugfs flag shows the value as 'disabled' by default. Signed-off-by: Suman Anna --- drivers/remoteproc/da8xx_remoteproc.c | 3 +++ 1 file changed, 3

[PATCH 2/2] mailbox/omap: use of_device_get_match_data() to get match data

2018-07-11 Thread Suman Anna
. This allows the driver to scale for 64-bit platforms by eliminating the unnecessary type-casting between a u32 and a void pointer types. Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 2/2] mailbox/omap: use of_device_get_match_data() to get match data

2018-07-11 Thread Suman Anna
. This allows the driver to scale for 64-bit platforms by eliminating the unnecessary type-casting between a u32 and a void pointer types. Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 0/2] OMAP Mailbox cleanups for 4.19

2018-07-11 Thread Suman Anna
in K3 AM654 SoC (support for that in OMAP Mailbox driver will be added once the base K3 AM654 pieces are part of mainline). regards Suman Suman Anna (2): mailbox/omap: switch to SPDX license identifier mailbox/omap: use of_device_get_match_data() to get match data drivers/mailbox/omap

[PATCH 1/2] mailbox/omap: switch to SPDX license identifier

2018-07-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the OMAP Mailbox driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 10 +- include/linux/omap-mailbox.h | 5 + 2 files changed, 2 insertions(+), 13

[PATCH 0/2] OMAP Mailbox cleanups for 4.19

2018-07-11 Thread Suman Anna
in K3 AM654 SoC (support for that in OMAP Mailbox driver will be added once the base K3 AM654 pieces are part of mainline). regards Suman Suman Anna (2): mailbox/omap: switch to SPDX license identifier mailbox/omap: use of_device_get_match_data() to get match data drivers/mailbox/omap

[PATCH 1/2] mailbox/omap: switch to SPDX license identifier

2018-07-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the OMAP Mailbox driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/mailbox/omap-mailbox.c | 10 +- include/linux/omap-mailbox.h | 5 + 2 files changed, 2 insertions(+), 13

Re: New remoteproc driver for TI PRU

2018-06-29 Thread Suman Anna
Hi David, On 06/29/2018 12:44 PM, David Lechner wrote: > On 06/29/2018 04:58 AM, Roger Quadros wrote: >> +Suman & Tero >> >> Hi David, >> >> On 24/06/18 00:08, David Lechner wrote: >>> >>> Date: Sat, 23 Jun 2018 15:43:59 -0500 >>> Subject: [PATCH 0/8] New remoteproc driver for TI PRU >>> >>> This

Re: New remoteproc driver for TI PRU

2018-06-29 Thread Suman Anna
Hi David, On 06/29/2018 12:44 PM, David Lechner wrote: > On 06/29/2018 04:58 AM, Roger Quadros wrote: >> +Suman & Tero >> >> Hi David, >> >> On 24/06/18 00:08, David Lechner wrote: >>> >>> Date: Sat, 23 Jun 2018 15:43:59 -0500 >>> Subject: [PATCH 0/8] New remoteproc driver for TI PRU >>> >>> This

Re: [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-31 Thread Suman Anna
Hi Rafael, On 05/18/2018 03:19 PM, Rafael J. Wysocki wrote: > On Friday, May 18, 2018 5:07:12 PM CEST Suman Anna wrote: >> On 04/02/2018 11:49 AM, Suman Anna wrote: >>> Hi Viresh, >>> >>> Please find the updated series replacing the previous patch [1] fixing &g

Re: [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-31 Thread Suman Anna
Hi Rafael, On 05/18/2018 03:19 PM, Rafael J. Wysocki wrote: > On Friday, May 18, 2018 5:07:12 PM CEST Suman Anna wrote: >> On 04/02/2018 11:49 AM, Suman Anna wrote: >>> Hi Viresh, >>> >>> Please find the updated series replacing the previous patch [1] fixing &g

[PATCH v3 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-31 Thread Suman Anna
://patchwork.kernel.org/patch/10308925/ Suman Anna (2): cpufreq: ti-cpufreq: Fix an incorrect error return value cpufreq: ti-cpufreq: Use devres managed API in probe() drivers/cpufreq/ti-cpufreq.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.17.0

[PATCH v3 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-31 Thread Suman Anna
://patchwork.kernel.org/patch/10308925/ Suman Anna (2): cpufreq: ti-cpufreq: Fix an incorrect error return value cpufreq: ti-cpufreq: Use devres managed API in probe() drivers/cpufreq/ti-cpufreq.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.17.0

[PATCH v3 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe()

2018-05-31 Thread Suman Anna
The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen Signed-off-by: Suman Anna Acked-by: Viresh Kumar --- drivers/cpufreq/ti-cpufreq.c

[PATCH v3 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

2018-05-31 Thread Suman Anna
829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen Cc: # v4.14+ Signed-off-by: Suman Anna Acked-by: Viresh Kumar --- drivers/cpufreq/ti-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/

[PATCH v3 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe()

2018-05-31 Thread Suman Anna
The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen Signed-off-by: Suman Anna Acked-by: Viresh Kumar --- drivers/cpufreq/ti-cpufreq.c

[PATCH v3 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

2018-05-31 Thread Suman Anna
829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen Cc: # v4.14+ Signed-off-by: Suman Anna Acked-by: Viresh Kumar --- drivers/cpufreq/ti-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/

[PATCH 0/5] rpmsg: Convert to use SPDX license identifiers

2018-05-31 Thread Suman Anna
. Patches done on top of latest upstream kernel. regards Suman Suman Anna (5): rpmsg: Switch to SPDX license identifier rpmsg: virtio_rpmsg_bus: Switch to SPDX license identifier rpmsg: smd: Switch to SPDX license identifier rpmsg: glink: Switch to SPDX license identifier rpmsg: char: Switch

[PATCH 0/5] rpmsg: Convert to use SPDX license identifiers

2018-05-31 Thread Suman Anna
. Patches done on top of latest upstream kernel. regards Suman Suman Anna (5): rpmsg: Switch to SPDX license identifier rpmsg: virtio_rpmsg_bus: Switch to SPDX license identifier rpmsg: smd: Switch to SPDX license identifier rpmsg: glink: Switch to SPDX license identifier rpmsg: char: Switch

[PATCH 1/5] rpmsg: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the rpmsg core source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/Kconfig | 2 ++ drivers/rpmsg/rpmsg_core.c | 10 +- drivers/rpmsg/rpmsg_internal.h | 10

[PATCH 1/5] rpmsg: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the rpmsg core source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/Kconfig | 2 ++ drivers/rpmsg/rpmsg_core.c | 10 +- drivers/rpmsg/rpmsg_internal.h | 10

[PATCH 2/5] rpmsg: virtio_rpmsg_bus: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the virtio rpmsg bus driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/virtio_rpmsg_bus.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rpmsg

[PATCH 2/5] rpmsg: virtio_rpmsg_bus: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the virtio rpmsg bus driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/virtio_rpmsg_bus.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rpmsg

[PATCH 3/5] rpmsg: smd: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the rpmsg SMD backend driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/qcom_smd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b

[PATCH 5/5] rpmsg: char: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
the same. Signed-off-by: Suman Anna --- drivers/rpmsg/rpmsg_char.c | 10 +- include/uapi/linux/rpmsg.h | 9 - 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 1efdf9ff8679..76a4477c6364 100644 --- a/drivers

[PATCH 3/5] rpmsg: smd: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in the rpmsg SMD backend driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/qcom_smd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b

[PATCH 5/5] rpmsg: char: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
the same. Signed-off-by: Suman Anna --- drivers/rpmsg/rpmsg_char.c | 10 +- include/uapi/linux/rpmsg.h | 9 - 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 1efdf9ff8679..76a4477c6364 100644 --- a/drivers

[PATCH 4/5] rpmsg: glink: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in various rpmsg glink driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/qcom_glink_native.c | 10 +- drivers/rpmsg/qcom_glink_native.h | 10 +- drivers/rpmsg

[PATCH 4/5] rpmsg: glink: Switch to SPDX license identifier

2018-05-31 Thread Suman Anna
Use the appropriate SPDX license identifier in various rpmsg glink driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/rpmsg/qcom_glink_native.c | 10 +- drivers/rpmsg/qcom_glink_native.h | 10 +- drivers/rpmsg

Re: Nokia N900: refcount_t underflow, use after free

2018-05-24 Thread Suman Anna
Pavel > >> regards >> Suman >> >>> >>> (Camera still does not work in -next... kills system. Oh well. Lets >>> debug that some other day.) >>> >>>> 8<

Re: Nokia N900: refcount_t underflow, use after free

2018-05-24 Thread Suman Anna
Pavel > >> regards >> Suman >> >>> >>> (Camera still does not work in -next... kills system. Oh well. Lets >>> debug that some other day.) >>> >>>> 8< -

Re: [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-18 Thread Suman Anna
On 04/02/2018 11:49 AM, Suman Anna wrote: > Hi Viresh, > > Please find the updated series replacing the previous patch [1] fixing > couple of issues in the TI CPUFreq driver. I have split up the patches > as per your comments on v1. Final code diff remains the same as before. >

Re: [PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-05-18 Thread Suman Anna
On 04/02/2018 11:49 AM, Suman Anna wrote: > Hi Viresh, > > Please find the updated series replacing the previous patch [1] fixing > couple of issues in the TI CPUFreq driver. I have split up the patches > as per your comments on v1. Final code diff remains the same as before. >

[PATCH 1/6] hwspinlock/core: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the Hwspinlock core driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/hwspinlock/Kconfig | 1 + drivers/hwspinlock/hwspinlock_core.c | 10 +- d

[PATCH 4/6] hwspinlock/sirf: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the CSR's SIRF hardware spinlock driver source file and drop the previous boilerplate license text. Cc: Wei Chen <wei.c...@csr.com> Cc: Barry Song <bao...@kernel.org> Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/hwspinlock

[PATCH 1/6] hwspinlock/core: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the Hwspinlock core driver source files and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/hwspinlock/Kconfig | 1 + drivers/hwspinlock/hwspinlock_core.c | 10 +- drivers/hwspinlock

[PATCH 4/6] hwspinlock/sirf: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the CSR's SIRF hardware spinlock driver source file and drop the previous boilerplate license text. Cc: Wei Chen Cc: Barry Song Signed-off-by: Suman Anna --- drivers/hwspinlock/sirf_hwspinlock.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 2/6] hwspinlock/omap: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the OMAP hwspinlock driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/hwspinlock/omap_hwspinlock.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff

[PATCH 2/6] hwspinlock/omap: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the OMAP hwspinlock driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/hwspinlock/omap_hwspinlock.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers

[PATCH 5/6] hwspinlock/u8500: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the U8500 HWSEM driver source file and drop the previous boilerplate license text. Cc: Mathieu J. Poirier <mathieu.poir...@linaro.org> Cc: Linus Walleij <linus.wall...@linaro.org> Signed-off-by: Suman Anna <s-a...@ti.com> ---

[PATCH 6/6] hwspinlock: sprd: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifiers in the Spreadtrum hardware spinlock driver source file and drop the previous boilerplate license text. Cc: Baolin Wang <baolin.w...@spreadtrum.com> Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/hwspinlock/sprd_hwspinlock.c | 10 +

[PATCH 5/6] hwspinlock/u8500: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the U8500 HWSEM driver source file and drop the previous boilerplate license text. Cc: Mathieu J. Poirier Cc: Linus Walleij Signed-off-by: Suman Anna --- drivers/hwspinlock/u8500_hsem.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions

[PATCH 6/6] hwspinlock: sprd: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifiers in the Spreadtrum hardware spinlock driver source file and drop the previous boilerplate license text. Cc: Baolin Wang Signed-off-by: Suman Anna --- drivers/hwspinlock/sprd_hwspinlock.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions

[PATCH 3/6] hwspinlock: qcom: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the Qualcomm Hwspinlock driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/hwspinlock/qcom_hwspinlock.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff

[PATCH 3/6] hwspinlock: qcom: Switch to SPDX license identifier

2018-05-11 Thread Suman Anna
Use the appropriate SPDX license identifier in the Qualcomm Hwspinlock driver source file and drop the previous boilerplate license text. Signed-off-by: Suman Anna --- drivers/hwspinlock/qcom_hwspinlock.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers

[PATCH 0/6] hwspinlock: Convert to use SPDX license identifiers

2018-05-11 Thread Suman Anna
at the earliest so that they can be picked up for 4.18. regards Suman Suman Anna (6): hwspinlock/core: Switch to SPDX license identifier hwspinlock/omap: Switch to SPDX license identifier hwspinlock: qcom: Switch to SPDX license identifier hwspinlock/sirf: Switch to SPDX license identifier

[PATCH 0/6] hwspinlock: Convert to use SPDX license identifiers

2018-05-11 Thread Suman Anna
at the earliest so that they can be picked up for 4.18. regards Suman Suman Anna (6): hwspinlock/core: Switch to SPDX license identifier hwspinlock/omap: Switch to SPDX license identifier hwspinlock: qcom: Switch to SPDX license identifier hwspinlock/sirf: Switch to SPDX license identifier

Re: [PATCH v6 5/7] remoteproc/davinci: use octal permissions for module_param()

2018-04-27 Thread Suman Anna
Acked-by from v3, so adding it back Acked-by: Suman Anna <s-a...@ti.com> regards Suman > --- > drivers/remoteproc/da8xx_remoteproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/da8xx_remoteproc.c > b/drivers/remoteproc/da

Re: [PATCH v6 5/7] remoteproc/davinci: use octal permissions for module_param()

2018-04-27 Thread Suman Anna
On 04/17/2018 12:30 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Checkpatch recommends to use octal perms instead of S_IRUGO. > > Signed-off-by: Bartosz Golaszewski Looks like you missed by Acked-by from v3, so adding it back Acked-by: Suman Anna

[PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

2018-04-02 Thread Suman Anna
829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen <zumeng.c...@gmail.com> Cc: sta...@vger.kernel.org Signed-off-by: Suman Anna <s-a...@ti.com> --- drivers/cpufreq/ti-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

2018-04-02 Thread Suman Anna
829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen Cc: sta...@vger.kernel.org Signed-off-by: Suman Anna --- drivers/cpufreq/ti-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufre

[PATCH v2 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe()

2018-04-02 Thread Suman Anna
The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen <zumeng.c...@gmail.com> Signed-off-by: Suman Anna <s-a...@ti.com> --- dri

[PATCH v2 2/2] cpufreq: ti-cpufreq: Use devres managed API in probe()

2018-04-02 Thread Suman Anna
The ti_cpufreq_probe() function uses regular kzalloc to allocate the ti_cpufreq_data structure and kfree for freeing this memory on failures. Simplify this code by using the devres managed API. Cc: Zumeng Chen Signed-off-by: Suman Anna --- drivers/cpufreq/ti-cpufreq.c | 7 ++- 1 file

[PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-04-02 Thread Suman Anna
Hi Viresh, Please find the updated series replacing the previous patch [1] fixing couple of issues in the TI CPUFreq driver. I have split up the patches as per your comments on v1. Final code diff remains the same as before. regards Suman [1] https://patchwork.kernel.org/patch/10308925/ Suman

[PATCH v2 0/2] ti-cpufreq: minor fixes/cleanups

2018-04-02 Thread Suman Anna
Hi Viresh, Please find the updated series replacing the previous patch [1] fixing couple of issues in the TI CPUFreq driver. I have split up the patches as per your comments on v1. Final code diff remains the same as before. regards Suman [1] https://patchwork.kernel.org/patch/10308925/ Suman

Re: [PATCH] cpufreq: ti-cpufreq: Fix couple of minor issues in probe()

2018-04-02 Thread Suman Anna
Hi Viresh, On 04/02/2018 01:32 AM, Viresh Kumar wrote: > On 26-03-18, 16:52, Suman Anna wrote: >> Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when >> failure") has fixed a memory leak in the failure path, however >> kmemleak still keeps reporting a

Re: [PATCH] cpufreq: ti-cpufreq: Fix couple of minor issues in probe()

2018-04-02 Thread Suman Anna
Hi Viresh, On 04/02/2018 01:32 AM, Viresh Kumar wrote: > On 26-03-18, 16:52, Suman Anna wrote: >> Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when >> failure") has fixed a memory leak in the failure path, however >> kmemleak still keeps reporting a

Re: [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework

2018-03-28 Thread Suman Anna
On 03/27/2018 12:24 AM, Sekhar Nori wrote: > Hi Suman, > > On Tuesday 27 March 2018 06:12 AM, Suman Anna wrote: >> I tried booting your tree [3] on the OMAPL138-LCDK board. I am using >> NFS, and I am unable to get to the console. I don't have any issues >> bootin

<    1   2   3   4   5   6   7   8   9   10   >