Re: [PATCH -next] ASoC: samsung: i2s: Add missing clk_disable_unprepare() on error in samsung_i2s_probe()

On 08/23/2016 05:16 PM, Wei Yongjun wrote: > Add the missing clk_disable_unprepare() before return > from samsung_i2s_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <weiyj...@gmail.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH -next] ASoC: samsung: i2s: Add missing clk_disable_unprepare() on error in samsung_i2s_probe()

On 08/23/2016 05:16 PM, Wei Yongjun wrote: > Add the missing clk_disable_unprepare() before return > from samsung_i2s_probe() in the error handling case. > > Signed-off-by: Wei Yongjun Acked-by: Sylwester Nawrocki

Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

On 08/22/2016 07:41 PM, Mark Brown wrote: > On Mon, Aug 22, 2016 at 07:22:47PM +0200, Sylwester Nawrocki wrote: > >> If we provided an interface like: > >> struct clk * arizona_get_mclk(struct arizona *arizona, int id); >> void arizona_put_mclk(struct clk *clk); >

Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

On 08/22/2016 07:41 PM, Mark Brown wrote: > On Mon, Aug 22, 2016 at 07:22:47PM +0200, Sylwester Nawrocki wrote: > >> If we provided an interface like: > >> struct clk * arizona_get_mclk(struct arizona *arizona, int id); >> void arizona_put_mclk(struct clk *clk); >

Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section

On 08/23/2016 04:35 AM, Chanwoo Choi wrote: >>> >>> +static const struct samsung_cmu_info aud_cmu __initconst = { >>> + .mux_clks = aud_mux_clks, >>> + .nr_mux_clks= ARRAY_SIZE(aud_mux_clks), >>> + .div_clks = aud_div_clks, >>> + .nr_div_clks=

Re: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section

On 08/23/2016 04:35 AM, Chanwoo Choi wrote: >>> >>> +static const struct samsung_cmu_info aud_cmu __initconst = { >>> + .mux_clks = aud_mux_clks, >>> + .nr_mux_clks= ARRAY_SIZE(aud_mux_clks), >>> + .div_clks = aud_div_clks, >>> + .nr_div_clks=

Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

On 08/22/2016 11:22 AM, Charles Keepax wrote: > Yeah I am not sure this is quite the correct approach, there are > quite a few corner cases that would not be covered well here. For > example an internally divided down 32k in which case both the 32k > and MCLK would come from the same pin, or using

Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

On 08/22/2016 11:22 AM, Charles Keepax wrote: > Yeah I am not sure this is quite the correct approach, there are > quite a few corner cases that would not be covered well here. For > example an internally divided down 32k in which case both the 32k > and MCLK would come from the same pin, or using

Re: [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings

Hi Chanwoo, On 08/22/2016 11:48 AM, Chanwoo Choi wrote: > This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4 > series without the behavior changes. > > Chanwoo Choi (5): > clk: samsung: exynos5433: Fix the checkpatch warnings > clk: samsung: exynos3250: Fix the

Re: [PATCH 0/5] clk: samsung: exynos: Fix the checkpatch warnings

Hi Chanwoo, On 08/22/2016 11:48 AM, Chanwoo Choi wrote: > This patches just fix the checkpatch warnings for exynos5433/3250/5260/5420/4 > series without the behavior changes. > > Chanwoo Choi (5): > clk: samsung: exynos5433: Fix the checkpatch warnings > clk: samsung: exynos3250: Fix the

Re: [PATCH] MAINTAINERS: Add myself as SAMSUNG SOC CLOCK DRIVERS

e exynos4415/5433 clock driver as author and handled the exynos3250 clock > driver. Lastly, adding the missing information of the exynos clock drivers. > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Tomasz Figa <tomasz.f...@gmail.com> > Signed-off-by: Chanwoo

Re: [PATCH] MAINTAINERS: Add myself as SAMSUNG SOC CLOCK DRIVERS

e exynos4415/5433 clock driver as author and handled the exynos3250 clock > driver. Lastly, adding the missing information of the exynos clock drivers. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Signed-off-by: Chanwoo Choi I'm going to apply this patch with commit

Re: [PATCH 6/7] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board

On 08/16/2016 08:35 AM, Chanwoo Choi wrote: > _1 { > + cs-gpios = < 3 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + > + wm5110: wm5110-codec@0 { > + compatible = "wlf,wm5110"; > + reg = <0x0>; > + spi-max-frequency = <2000>; > +

Re: [PATCH 6/7] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board

On 08/16/2016 08:35 AM, Chanwoo Choi wrote: > _1 { > + cs-gpios = < 3 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + > + wm5110: wm5110-codec@0 { > + compatible = "wlf,wm5110"; > + reg = <0x0>; > + spi-max-frequency = <2000>; > +

[RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

callbacks. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- I'm not sure it's a correct approach hence only an RFC patch. --- drivers/mfd/arizona-core.c | 105 --- include/linux/mfd/arizona/core.h | 9 2 files changed, 96 insertions(

[RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks

callbacks. Signed-off-by: Sylwester Nawrocki --- I'm not sure it's a correct approach hence only an RFC patch. --- drivers/mfd/arizona-core.c | 105 --- include/linux/mfd/arizona/core.h | 9 2 files changed, 96 insertions(+), 18 deletions(-) diff --git

Re: [PATCH 5/7] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC

Hi Chanwoo, On 08/16/2016 08:35 AM, Chanwoo Choi wrote: > This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on > Octa-core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports > PSCI (Power State Coordination Interface) v0.1. > --- >

Re: [PATCH 5/7] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC

Hi Chanwoo, On 08/16/2016 08:35 AM, Chanwoo Choi wrote: > This patch adds new Exynos5433 dtsi to support 64-bit Exynos5433 SoC based on > Octa-core CPUs (quad Cortex-A57 and quad Cortex-A53). And Exynos5433 supports > PSCI (Power State Coordination Interface) v0.1. > --- >

Re: [PATCH v2] MAINTAINERS: Switch to kernel.org account for Krzysztof Kozlowski

in Kim <kg...@kernel.org> > Cc: linux-samsung-...@vger.kernel.org Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> > --- > Changes since v1: > 1. Update also mailmap after Joe Perches suggestion. > > Affected drivers/subsystems: > 1. arch/arm, > 2. mfd, >

Re: [PATCH v2] MAINTAINERS: Switch to kernel.org account for Krzysztof Kozlowski

gt; Cc: linux-samsung-...@vger.kernel.org Acked-by: Sylwester Nawrocki > --- > Changes since v1: > 1. Update also mailmap after Joe Perches suggestion. > > Affected drivers/subsystems: > 1. arch/arm, > 2. mfd, > 3. power, > 4. regulator, > 5. clk, > 6. rtc, &

Re: [alsa-devel] [PATCH v5 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 05:29 PM, Lee Jones wrote: > I only just reviewed v4. OK, apologies for resending to fast. I assumed you might have no further comments after reviewing first patch from the series.

Re: [alsa-devel] [PATCH v5 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 05:29 PM, Lee Jones wrote: > I only just reviewed v4. OK, apologies for resending to fast. I assumed you might have no further comments after reviewing first patch from the series.

[PATCH v6 1/2] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v5: - none. Changes since v4: - text reformatting, added VIC

[PATCH v6 1/2] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki Acked-by: Rob Herring --- Changes since v5: - none. Changes since v4: - text reformatting, added VIC to the list of sub-devices, relative paths used

[PATCH v6 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song <ideal.s...@samsung.com> Signed-off-by: Beomho Seo <beomho@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v5: - BIT() used for the register bit

[PATCH v6 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song Signed-off-by: Beomho Seo Signed-off-by: Sylwester Nawrocki --- Changes since v5: - BIT() used for the register bit macro definitions, - removed unneeded dev->of_node test, - exynos_lpass_{suspend,res

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 10:50 PM, Lee Jones wrote: > On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > >> > On 08/09/2016 05:05 PM, Lee Jones wrote: >>>> > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, >>>>> > >> > +

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 10:50 PM, Lee Jones wrote: > On Tue, 09 Aug 2016, Sylwester Nawrocki wrote: > >> > On 08/09/2016 05:05 PM, Lee Jones wrote: >>>> > >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, >>>>> > >> > +

[PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

uired irq_chip setup, but there is no equivalent code for non OF/ACPI platforms. This patch mostly restores irq trigger type setting code which has been removed in commit ("net: ethernet: davicom: fix devicetree irq resource"). Fixes: b5a099c67a1c36b913 ("net: ethernet: davicom: fix devicetree irq resource&q

[PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

uired irq_chip setup, but there is no equivalent code for non OF/ACPI platforms. This patch mostly restores irq trigger type setting code which has been removed in commit ("net: ethernet: davicom: fix devicetree irq resource"). Fixes: b5a099c67a1c36b913 ("net: ethernet: davicom: fix devicetree irq resource&q

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 05:05 PM, Lee Jones wrote: >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, >> > + exynos_lpass_resume); > Put this up by the PM functions. Sorry, I don't understand this comment, which PM functions do you mean exactly? -- Thanks,

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 08/09/2016 05:05 PM, Lee Jones wrote: >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend, >> > + exynos_lpass_resume); > Put this up by the PM functions. Sorry, I don't understand this comment, which PM functions do you mean exactly? -- Thanks,

[PATCH v5 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song <ideal.s...@samsung.com> Signed-off-by: Beomho Seo <beomho@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v4: - none. Changes since v3: - mo

[PATCH v5 2/2] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song Signed-off-by: Beomho Seo Signed-off-by: Sylwester Nawrocki --- Changes since v4: - none. Changes since v3: - moved from sound/soc/samsung and rewritten as a MFD driver, - PMU register definitions moved

[PATCH v5 1/2] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v4: - text reformatting, added VIC to the list of sub-devic

[PATCH v5 1/2] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki Acked-by: Rob Herring --- Changes since v4: - text reformatting, added VIC to the list of sub-devices, relative paths used for the reference DT binding

Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS

On 08/05/2016 03:36 PM, Lee Jones wrote: > On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > >> This patch adds documentation of the DT bindings for the Samsung >> Exynos SoC Low Power Audio Subsystem. >> >> Signed-off-by: Sylwester Nawrocki <s.nawro...@sams

Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS

On 08/05/2016 03:36 PM, Lee Jones wrote: > On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > >> This patch adds documentation of the DT bindings for the Samsung >> Exynos SoC Low Power Audio Subsystem. >> >> Signed-off-by: Sylwester Nawrocki >> new file m

Re: [PATCH] clk: prevent __of_clk_get_hw_from_provider() from returning NULL

On 08/04/2016 10:57 PM, Stephen Boyd wrote: > On 07/19, Masahiro Yamada wrote: >> > The .get(_hw) callback of an OF clock provider can return a NULL >> > pointer in some cases. >> > >> > For example, of_clk_src_onecell_get() returns NULL for index 1 of a >> > sparse array of clocks like follows:

Re: [PATCH] clk: prevent __of_clk_get_hw_from_provider() from returning NULL

On 08/04/2016 10:57 PM, Stephen Boyd wrote: > On 07/19, Masahiro Yamada wrote: >> > The .get(_hw) callback of an OF clock provider can return a NULL >> > pointer in some cases. >> > >> > For example, of_clk_src_onecell_get() returns NULL for index 1 of a >> > sparse array of clocks like follows:

Re: [PATCH] phy: exynos-mipi-video: simplify check for coupled phy status

power domain if the coupled phy is already disabled. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH] phy: exynos-mipi-video: simplify check for coupled phy status

power domain if the coupled phy is already disabled. > > Signed-off-by: Marek Szyprowski Acked-by: Sylwester Nawrocki

Re: [alsa-devel] [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

On 07/22/2016 11:51 AM, Charles Keepax wrote: > On Tue, Jul 05, 2016 at 07:14:37PM +0200, Sylwester Nawrocki wrote: >> This patch adds the sound machine driver for TM2 and TM2E board. >> Speaker and headphone playback, Main Mic capture, Bluetooth, >> Voice call and external ac

Re: [alsa-devel] [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

On 07/22/2016 11:51 AM, Charles Keepax wrote: > On Tue, Jul 05, 2016 at 07:14:37PM +0200, Sylwester Nawrocki wrote: >> This patch adds the sound machine driver for TM2 and TM2E board. >> Speaker and headphone playback, Main Mic capture, Bluetooth, >> Voice call and external ac

Re: [alsa-devel] [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

On 07/21/2016 12:28 PM, Chanwoo Choi wrote: > When I test it, I can get the clock pointer by devm_clk_get() as following: > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > index 9728b3c5927f..5de4fc554aec 100644 > --- a/sound/soc/samsung/tm2_wm5110.c > +++

Re: [alsa-devel] [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

On 07/21/2016 12:28 PM, Chanwoo Choi wrote: > When I test it, I can get the clock pointer by devm_clk_get() as following: > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > index 9728b3c5927f..5de4fc554aec 100644 > --- a/sound/soc/samsung/tm2_wm5110.c > +++

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 07/05/2016 07:13 PM, Sylwester Nawrocki wrote: > This patch adds common driver for the Top block of the Samsung Exynos > SoC Low Power Audio Subsystem. This is a minimal driver which prepares > resources for IP blocks like I2S, audio DMA and UART and exposes a regmap > for t

Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

On 07/05/2016 07:13 PM, Sylwester Nawrocki wrote: > This patch adds common driver for the Top block of the Samsung Exynos > SoC Low Power Audio Subsystem. This is a minimal driver which prepares > resources for IP blocks like I2S, audio DMA and UART and exposes a regmap > for t

Re: [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

Hi Chanwoo, On 07/15/2016 07:18 AM, Chanwoo Choi wrote: >> +static int tm2_probe(struct platform_device *pdev) >> +{ >> +struct device *dev = >dev; >> +codec_dai_node = of_parse_phandle(dev->of_node, "audio-codec", 0); >> +if (!codec_dai_node) { >> +dev_err(dev,

Re: [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

Hi Chanwoo, On 07/15/2016 07:18 AM, Chanwoo Choi wrote: >> +static int tm2_probe(struct platform_device *pdev) >> +{ >> +struct device *dev = >dev; >> +codec_dai_node = of_parse_phandle(dev->of_node, "audio-codec", 0); >> +if (!codec_dai_node) { >> +dev_err(dev,

Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

mation > is already contained at the top of the file in the comments. > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Tomasz Figa <tomasz.f...@gmail.com> > Cc: Michael Turquette <mturque...@baylibre.com> > Cc: Stephen Boyd <sb...@codeaurora.org&g

Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

mation > is already contained at the top of the file in the comments. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-samsung-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Paul Gortmaker In case this is going to be applied directly to current clk-next: Acked-by: Sylwester Nawrocki

Re: [PATCH 2/2] soc: samsung: Add support for Exynos7 PMU

On 07/11/2016 04:44 PM, Abhilash Kesavan wrote: >>> + /* >>> >> +* Set clock freeze cycle count to 0 before and after arm clamp >>> >> or >>> >> +* reset signal transition >>> >> +*/ >>> >> + node = of_find_compatible_node(NULL, NULL, >>> >> +

Re: [PATCH 2/2] soc: samsung: Add support for Exynos7 PMU

On 07/11/2016 04:44 PM, Abhilash Kesavan wrote: >>> + /* >>> >> +* Set clock freeze cycle count to 0 before and after arm clamp >>> >> or >>> >> +* reset signal transition >>> >> +*/ >>> >> + node = of_find_compatible_node(NULL, NULL, >>> >> +

Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

On 07/07/2016 03:18 PM, Sylwester Nawrocki wrote: > On 07/07/2016 02:13 PM, Andi Shyti wrote: >> > Andi Shyti (2): >> > clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks >> > clk: exynos5433: enable sclk_ioclk for SPI3 > > Applied both patches,

Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

On 07/07/2016 03:18 PM, Sylwester Nawrocki wrote: > On 07/07/2016 02:13 PM, Andi Shyti wrote: >> > Andi Shyti (2): >> > clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks >> > clk: exynos5433: enable sclk_ioclk for SPI3 > > Applied both patches,

Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/07/2016 03:27 PM, Andi Shyti wrote: >>> > > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. >>> > > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, >>> > > which enables the clock line during boot time. >> > >> > I don't agree. Both flags should be avoided.

Re: [PATCH v4 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/07/2016 03:27 PM, Andi Shyti wrote: >>> > > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. >>> > > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, >>> > > which enables the clock line during boot time. >> > >> > I don't agree. Both flags should be avoided.

Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

On 07/07/2016 02:13 PM, Andi Shyti wrote: > Andi Shyti (2): > clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks > clk: exynos5433: enable sclk_ioclk for SPI3 Applied both patches, thanks.

Re: [PATCH v4 0/2] mark spi clocks as critical and enable spi3 clocks

On 07/07/2016 02:13 PM, Andi Shyti wrote: > Andi Shyti (2): > clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks > clk: exynos5433: enable sclk_ioclk for SPI3 Applied both patches, thanks.

Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular

On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS > arch/arm/mach-exynos/Kconfig: bool "Samsung EXYNOS" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a

Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular

On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS > arch/arm/mach-exynos/Kconfig: bool "Samsung EXYNOS" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a

Re: [PATCH v3 1/2] clk: samsung: cpu: Prepare for addition for Exynos7 CPU clocks

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote: > Exynos7 has the same CPU clock registers layout as that present > in Exynos5433 except for the bits in the MUX_STAT* registers. > Add a new CLK_CPU_HAS_MODIFIED_MUX_STAT flag to handle this change. > --- a/drivers/clk/samsung/clk-cpu.h > +++

Re: [PATCH v3 1/2] clk: samsung: cpu: Prepare for addition for Exynos7 CPU clocks

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote: > Exynos7 has the same CPU clock registers layout as that present > in Exynos5433 except for the bits in the MUX_STAT* registers. > Add a new CLK_CPU_HAS_MODIFIED_MUX_STAT flag to handle this change. > --- a/drivers/clk/samsung/clk-cpu.h > +++

Re: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote: > +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = { > + /* rate, m, p, s */ > + PLL_35XX_RATE(249600, 208, 2, 0), Please add U postfix to these constants to address compiler warning as reported by kbuild-...@01.org:

Re: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote: > +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = { > + /* rate, m, p, s */ > + PLL_35XX_RATE(249600, 208, 2, 0), Please add U postfix to these constants to address compiler warning as reported by kbuild-...@01.org:

Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

Patch applied, thanks.

Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular

Patch applied, thanks.

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/06/2016 06:51 AM, Andi Shyti wrote: > > I don't see anything wrong on the above. We could make it as: > @@ -640,13 +639,7 @@ static void s3c64xx_spi_config(struct > s3c64xx_spi_driver_data *sdd) > > writel(val, regs + S3C64XX_SPI_MODE_CFG); > > - if

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/06/2016 06:51 AM, Andi Shyti wrote: > > I don't see anything wrong on the above. We could make it as: > @@ -640,13 +639,7 @@ static void s3c64xx_spi_config(struct > s3c64xx_spi_driver_data *sdd) > > writel(val, regs + S3C64XX_SPI_MODE_CFG); > > - if

[PATCH v4 3/4] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem

This patch adds DT binding documentation for Exnos5433 based TM2 and TM2E boards sound subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v2: - none. Changes since initial version: - dropped clocks,

[PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

lowski <k.kozlow...@samsung.com> [s.nawrocki: rebased to 4.7, adjustment to the ASoC core changes, removed unused ops and direct calls to the max98504 function, added parsing of "audio-amplifier" and "audio-codec" properties, added TDM API calls, switched to gpiod API] S

[PATCH v4 3/4] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem

This patch adds DT binding documentation for Exnos5433 based TM2 and TM2E boards sound subsystem. Signed-off-by: Sylwester Nawrocki Acked-by: Rob Herring --- Changes since v2: - none. Changes since initial version: - dropped clocks, clock-names properties, instead properties from the CODEC

[PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

, adjustment to the ASoC core changes, removed unused ops and direct calls to the max98504 function, added parsing of "audio-amplifier" and "audio-codec" properties, added TDM API calls, switched to gpiod API] Signed-off-by: Sylwester Nawrocki --- Changes since v3: - removed S

[PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song <ideal.s...@samsung.com> Signed-off-by: Beomho Seo <beomho@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- Changes since v3: - moved from sound/soc/samsung and

[PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver

Subsystem is operational after system suspend/resume cycle. Signed-off-by: Inha Song Signed-off-by: Beomho Seo Signed-off-by: Sylwester Nawrocki --- Changes since v3: - moved from sound/soc/samsung and rewritten as a MFD driver, - PMU register definitions moved to include/linux/mfd/syscon

[PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> --- There were few rather significant additions since v3 and I had to drop tags: Acked-by: Rob Herring <r...@kernel.or

[PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS

This patch adds documentation of the DT bindings for the Samsung Exynos SoC Low Power Audio Subsystem. Signed-off-by: Sylwester Nawrocki --- There were few rather significant additions since v3 and I had to drop tags: Acked-by: Rob Herring Acked-by: Krzysztof Kozlowski Changes since v3

[PATCH v4 0/4] ASoC: samsung: Sound support for Exynos5433 TM2(E) boards

as the dependencies between LPASS Top block and its IP sub-blocks are properly taken care of. Sylwester Nawrocki (4): mfd: Add DT bindings documentation for Samsung Exynos LPASS mfd: Add Samsung Exynos Low Power Audio Subsystem driver ASoC: samsung: Add DT bindings documentation for TM2 sound

[PATCH v4 0/4] ASoC: samsung: Sound support for Exynos5433 TM2(E) boards

as the dependencies between LPASS Top block and its IP sub-blocks are properly taken care of. Sylwester Nawrocki (4): mfd: Add DT bindings documentation for Samsung Exynos LPASS mfd: Add Samsung Exynos Low Power Audio Subsystem driver ASoC: samsung: Add DT bindings documentation for TM2 sound

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/04/2016 12:26 PM, Andi Shyti wrote: > The single clock lines are not configured in the exynos5433 dts, > but in the drivers/clk/samsung/clk-exynos5433.c file and it's the > only place where we can set the flags. I meant we could amend which clocks are specified at the SPI bus device DT

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 07/04/2016 12:26 PM, Andi Shyti wrote: > The single clock lines are not configured in the exynos5433 dts, > but in the drivers/clk/samsung/clk-exynos5433.c file and it's the > only place where we can set the flags. I meant we could amend which clocks are specified at the SPI bus device DT

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 06/30/2016 09:15 AM, Andi Shyti wrote: > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. In general I would rather disagree. > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, > which enables the clock line during boot time. > > Suggested-by: Tomasz Figa

Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks

On 06/30/2016 09:15 AM, Andi Shyti wrote: > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. In general I would rather disagree. > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, > which enables the clock line during boot time. > > Suggested-by: Tomasz Figa >

Re: [GIT PULL 4/8] ARM: exynos: Topic branch with driver changes for v4.8

r. This pulls in >>> >> an external dependency from media tree (Sylwester Nawrocki). >>> >> >>> >> Below you will find two pull-request-changelogs >>> >> >>> >> >>> >> Be

Re: [GIT PULL 4/8] ARM: exynos: Topic branch with driver changes for v4.8

r. This pulls in >>> >> an external dependency from media tree (Sylwester Nawrocki). >>> >> >>> >> Below you will find two pull-request-changelogs >>> >> >>> >> >>> >> Be

Re: [PATCH 0/3] clk: samsung: exynos5433: Add CLK_IGNORE_UNUSED flag and

On 06/10/2016 06:56 AM, Chanwoo Choi wrote: > This patch-set add the CLK_IGNORE_UNUSED flag to the specific clocks because > the specific clocks should remain the enable state. This patch-set support the > PCIE (PCI Express), serial3(AUD Uart) device and fix the hang issue for > suspend-to-ram. >

Re: [PATCH 0/3] clk: samsung: exynos5433: Add CLK_IGNORE_UNUSED flag and

On 06/10/2016 06:56 AM, Chanwoo Choi wrote: > This patch-set add the CLK_IGNORE_UNUSED flag to the specific clocks because > the specific clocks should remain the enable state. This patch-set support the > PCIE (PCI Express), serial3(AUD Uart) device and fix the hang issue for > suspend-to-ram. >

Re: [RFC PATCH 03/15] clk: samsung: exynos4: fixup reg access on be

On 06/08/2016 08:30 PM, Matthew Leach wrote: > Use the byte-order aware big endian accessors, allowing for kernels > running under big-endian. > > Signed-off-by: Matthew Leach Patch applied, thanks.

Re: [RFC PATCH 03/15] clk: samsung: exynos4: fixup reg access on be

On 06/08/2016 08:30 PM, Matthew Leach wrote: > Use the byte-order aware big endian accessors, allowing for kernels > running under big-endian. > > Signed-off-by: Matthew Leach Patch applied, thanks.

Re: [RFC PATCH 01/15] clock: exynos: fixup endian in pll clk

On 06/08/2016 08:30 PM, Matthew Leach wrote: > Fix the clk endian access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach We should have gotten rid of those __raw_{readl, writel} calls earlier for other reasons too. Thanks for

Re: [RFC PATCH 01/15] clock: exynos: fixup endian in pll clk

On 06/08/2016 08:30 PM, Matthew Leach wrote: > Fix the clk endian access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach We should have gotten rid of those __raw_{readl, writel} calls earlier for other reasons too. Thanks for the fix, patch applied!

Re: [PATCH 2/3] clk: samsung: exynos5410: Add WDT, ACLK266 and SSS clocks

On 06/01/2016 11:45 AM, Krzysztof Kozlowski wrote: > Add clock hierarchy for Security SubSystem clock and watchdog. > > Signed-off-by: Krzysztof Kozlowski A applied patches: [PATCH 1/3] dt-bindings: clock: Add watchdog and SSS clock IDs to Exynos5410 [PATCH 2/3] clk:

Re: [PATCH 2/3] clk: samsung: exynos5410: Add WDT, ACLK266 and SSS clocks

On 06/01/2016 11:45 AM, Krzysztof Kozlowski wrote: > Add clock hierarchy for Security SubSystem clock and watchdog. > > Signed-off-by: Krzysztof Kozlowski A applied patches: [PATCH 1/3] dt-bindings: clock: Add watchdog and SSS clock IDs to Exynos5410 [PATCH 2/3] clk: samsung: exynos5410: Add

Re: [PATCH 2/3] clk: samsung: exynos5410: Add WDT, ACLK266 and SSS clocks

On 06/01/2016 04:55 PM, Javier Martinez Canillas wrote: > On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote: >> > Add clock hierarchy for Security SubSystem clock and watchdog. >> > >> > Signed-off-by: Krzysztof Kozlowski >> > --- > Reviewed-by: Javier Martinez Canillas

Re: [PATCH 2/3] clk: samsung: exynos5410: Add WDT, ACLK266 and SSS clocks

On 06/01/2016 04:55 PM, Javier Martinez Canillas wrote: > On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote: >> > Add clock hierarchy for Security SubSystem clock and watchdog. >> > >> > Signed-off-by: Krzysztof Kozlowski >> > --- > Reviewed-by: Javier Martinez Canillas Patches 1/3, 2/3

Re: [PATCH 4/4] ARM: exynos_defconfig: Save defconfig on current linux-next

), > - EXT4_FS (selected by EXT3_FS) > - SND_SOC_ODROIDX2 (obsolete since commit ee12a817bb4b ("ASoC: samsung: >Remove unused Odroid x2/u3 machine driver"), replaced with > SND_SIMPLE_CARD). > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Signed-

Re: [PATCH 4/4] ARM: exynos_defconfig: Save defconfig on current linux-next

), > - EXT4_FS (selected by EXT3_FS) > - SND_SOC_ODROIDX2 (obsolete since commit ee12a817bb4b ("ASoC: samsung: >Remove unused Odroid x2/u3 machine driver"), replaced with > SND_SIMPLE_CARD). > > Cc: Sylwester Nawrocki > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki

Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock

On 05/31/2016 08:56 PM, Javier Martinez Canillas wrote: > On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote: >> > Add clock for TMU to the Exynos5410 clock driver. >> > >> > Signed-off-by: Krzysztof Kozlowski >> > --- >> > drivers/clk/samsung/clk-exynos5410.c | 1 + >> > 1 file

Re: [PATCH 2/6] clk: samsung: exynos5410: Add TMU clock

On 05/31/2016 08:56 PM, Javier Martinez Canillas wrote: > On 05/31/2016 02:39 PM, Krzysztof Kozlowski wrote: >> > Add clock for TMU to the Exynos5410 clock driver. >> > >> > Signed-off-by: Krzysztof Kozlowski >> > --- >> > drivers/clk/samsung/clk-exynos5410.c | 1 + >> > 1 file changed, 1

<    4   5   6   7   8   9   10   11   12   13   >