Re: [PATCH v5 00/22] ARM: dts: exynos: Add initial support for Odroid XU

On 05/28/2016 11:54 AM, Krzysztof Kozlowski wrote: > > The clock changes can go to clock tree. ARM changes to samsung-soc tree. > Please provide me a tag with include/dt-bindings/clock commits so I can > merge it. I applied the clock tree patches and here is the tag for the three

Re: [PATCH v5 00/22] ARM: dts: exynos: Add initial support for Odroid XU

On 05/28/2016 11:54 AM, Krzysztof Kozlowski wrote: > > The clock changes can go to clock tree. ARM changes to samsung-soc tree. > Please provide me a tag with include/dt-bindings/clock commits so I can > merge it. I applied the clock tree patches and here is the tag for the three

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

On 04/14/2016 06:42 AM, Alim Akhtar wrote: > This patch adds CLK_IS_CRITICAL flag to ACLK_CCORE_133 and ACLK_FSYS0_200 > clocks. These clocks are critical for accessing CMU_CCORE and CMU_FSYS0 > blocks registers. Let these clocks to be enabled all the time. > > Signed-off-by: Alim Akhtar

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

On 04/14/2016 06:42 AM, Alim Akhtar wrote: > This patch adds CLK_IS_CRITICAL flag to ACLK_CCORE_133 and ACLK_FSYS0_200 > clocks. These clocks are critical for accessing CMU_CCORE and CMU_FSYS0 > blocks registers. Let these clocks to be enabled all the time. > > Signed-off-by: Alim Akhtar Patch

Re: [PATCH 1/2] clk: exynos5420: Set ID for aclk333 gate clock

On 05/24/2016 07:41 PM, Javier Martinez Canillas wrote: > The aclk333 clock needs to be ungated during the MFC power domain switch, > so set the clock ID to allow the Exynos power domain logic to lookup this > clock if is defined in the MFC PD device tree node. > > Signed-off-by: Javier Martinez

Re: [PATCH 1/2] clk: exynos5420: Set ID for aclk333 gate clock

On 05/24/2016 07:41 PM, Javier Martinez Canillas wrote: > The aclk333 clock needs to be ungated during the MFC power domain switch, > so set the clock ID to allow the Exynos power domain logic to lookup this > clock if is defined in the MFC PD device tree node. > > Signed-off-by: Javier Martinez

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

Hi Alim, On 05/25/2016 08:04 AM, Alim Akhtar wrote: > Looks like this patch is not available on your tree. Thanks for the reminder, I'll apply it next week, after 3.7-rc1 is released. -- Regards, Sylwester

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

Hi Alim, On 05/25/2016 08:04 AM, Alim Akhtar wrote: > Looks like this patch is not available on your tree. Thanks for the reminder, I'll apply it next week, after 3.7-rc1 is released. -- Regards, Sylwester

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

On 04/15/2016 02:37 PM, Alim Akhtar wrote: > On 04/14/2016 01:20 PM, Krzysztof Kozlowski wrote: >> > On 04/14/2016 06:42 AM, Alim Akhtar wrote: >>> >> This patch adds CLK_IS_CRITICAL flag to ACLK_CCORE_133 and ACLK_FSYS0_200 >>> >> clocks. These clocks are critical for accessing CMU_CCORE and

Re: [PATCH v2 6/8] clk: samsung: exynos542x: Add the clock id for ACLK

On 04/15/2016 11:05 AM, Krzysztof Kozlowski wrote: > On 04/15/2016 08:32 AM, Chanwoo Choi wrote: >> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI >> Bus. This clock should be handled in Bus frequency scaling driver. >> >> Cc:

Re: [PATCH] clk: samsung: exynos7: Don't gate CMU_{CCORE, FSYS0} blocks clock

On 04/15/2016 02:37 PM, Alim Akhtar wrote: > On 04/14/2016 01:20 PM, Krzysztof Kozlowski wrote: >> > On 04/14/2016 06:42 AM, Alim Akhtar wrote: >>> >> This patch adds CLK_IS_CRITICAL flag to ACLK_CCORE_133 and ACLK_FSYS0_200 >>> >> clocks. These clocks are critical for accessing CMU_CCORE and

Re: [PATCH v2 6/8] clk: samsung: exynos542x: Add the clock id for ACLK

On 04/15/2016 11:05 AM, Krzysztof Kozlowski wrote: > On 04/15/2016 08:32 AM, Chanwoo Choi wrote: >> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI >> Bus. This clock should be handled in Bus frequency scaling driver. >> >> Cc: Sylwester N

Re: [PATCH] clk: samsung: exynos7: Enable clocks for CMU_CCORE and CMU_FSYS0 blocks

On 04/13/2016 08:26 AM, Tomasz Figa wrote: >> > @@ -205,7 +206,11 @@ static struct samsung_cmu_info topc_cmu_info >> > __initdata = { >> > >> > static void __init exynos7_clk_topc_init(struct device_node *np) >> > { >> > + struct clk *clk; >> > + >> > samsung_cmu_register_one(np,

Re: [PATCH] clk: samsung: exynos7: Enable clocks for CMU_CCORE and CMU_FSYS0 blocks

On 04/13/2016 08:26 AM, Tomasz Figa wrote: >> > @@ -205,7 +206,11 @@ static struct samsung_cmu_info topc_cmu_info >> > __initdata = { >> > >> > static void __init exynos7_clk_topc_init(struct device_node *np) >> > { >> > + struct clk *clk; >> > + >> > samsung_cmu_register_one(np,

Re: [PATCH] clk: samsung: exynos7: Enable clocks for CMU_CCORE and CMU_FSYS0 blocks

On 04/12/2016 01:07 PM, Alim Akhtar wrote: > This patch enables clocks for CMU_CCORE and CMU_FSYS0 blocks. This is > required before accessing registers of these blocks. Patch applied, thanks!

Re: [PATCH] clk: samsung: exynos7: Enable clocks for CMU_CCORE and CMU_FSYS0 blocks

On 04/12/2016 01:07 PM, Alim Akhtar wrote: > This patch enables clocks for CMU_CCORE and CMU_FSYS0 blocks. This is > required before accessing registers of these blocks. Patch applied, thanks!

Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

On 03/31/2016 02:28 PM, Chanwoo Choi wrote: >> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions >> > of which the return value is being tested return only ERR_PTR() values. >> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs >> > like >> > if

Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

On 03/31/2016 02:28 PM, Chanwoo Choi wrote: >> > You should use IS_ERR() instead of IS_ERR_OR_NULL(), since functions >> > of which the return value is being tested return only ERR_PTR() values. >> > IS_ERR_OR_NULL() suggest NULL values are possible and then constructs >> > like >> > if

Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

On 03/31/2016 11:05 AM, Chanwoo Choi wrote: > +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 > flags) > +{ > + new_opp = devfreq_recommended_opp(dev, freq, flags); > + if (IS_ERR_OR_NULL(new_opp)) { > + dev_err(dev, "failed to get recommed opp

Re: [PATCH v7 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver

On 03/31/2016 11:05 AM, Chanwoo Choi wrote: > +static int exynos_bus_target(struct device *dev, unsigned long *freq, u32 > flags) > +{ > + new_opp = devfreq_recommended_opp(dev, freq, flags); > + if (IS_ERR_OR_NULL(new_opp)) { > + dev_err(dev, "failed to get recommed opp

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/29/2016 03:48 AM, Krzysztof Kozlowski wrote: > On 28.03.2016 09:44, Chanwoo Choi wrote: >> You mean that separate patch1 include only the new clock id >> about both UART2 and MMC2 >> and the patch2/patch3 just use the new clock id as following: >> >> patch1 dt-bindings: Add the clock id of

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/29/2016 03:48 AM, Krzysztof Kozlowski wrote: > On 28.03.2016 09:44, Chanwoo Choi wrote: >> You mean that separate patch1 include only the new clock id >> about both UART2 and MMC2 >> and the patch2/patch3 just use the new clock id as following: >> >> patch1 dt-bindings: Add the clock id of

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/29/2016 03:48 AM, Krzysztof Kozlowski wrote: > On 28.03.2016 09:44, Chanwoo Choi wrote: >> > You mean that separate patch1 include only the new clock id about both >> > UART2 and MMC2 >> > and the patch2/patch3 just use the new clock id as following: >> > >> > patch1 dt-bindings: Add the

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/29/2016 03:48 AM, Krzysztof Kozlowski wrote: > On 28.03.2016 09:44, Chanwoo Choi wrote: >> > You mean that separate patch1 include only the new clock id about both >> > UART2 and MMC2 >> > and the patch2/patch3 just use the new clock id as following: >> > >> > patch1 dt-bindings: Add the

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/28/2016 02:44 AM, Chanwoo Choi wrote: > You mean that separate patch1 include only the new clock id about both UART2 > and MMC2 > and the patch2/patch3 just use the new clock id as following: > > patch1 dt-bindings: Add the clock id of UART2 and MMC2 for Exynos3250 > patch2 clk: samsung:

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

On 03/28/2016 02:44 AM, Chanwoo Choi wrote: > You mean that separate patch1 include only the new clock id about both UART2 > and MMC2 > and the patch2/patch3 just use the new clock id as following: > > patch1 dt-bindings: Add the clock id of UART2 and MMC2 for Exynos3250 > patch2 clk: samsung:

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

Hi Chanwoo, On 03/25/2016 12:39 AM, Chanwoo Choi wrote: > diff --git a/include/dt-bindings/clock/exynos3250.h > b/include/dt-bindings/clock/exynos3250.h >> index ddb874130d86..c796ff02ceeb 100644 >> --- a/include/dt-bindings/clock/exynos3250.h >> +++ b/include/dt-bindings/clock/exynos3250.h ...

Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock

Hi Chanwoo, On 03/25/2016 12:39 AM, Chanwoo Choi wrote: > diff --git a/include/dt-bindings/clock/exynos3250.h > b/include/dt-bindings/clock/exynos3250.h >> index ddb874130d86..c796ff02ceeb 100644 >> --- a/include/dt-bindings/clock/exynos3250.h >> +++ b/include/dt-bindings/clock/exynos3250.h ...

Re: [PATCH 3/3] phy: exynos-mipi-video: Add support for Exynos 5420 and 5433 SoCs

patible case) or by moving MIPI DPHY reset registers to > separate system register controllers (Exynos 5433 case). In both case > also additional 5th PHY (MIPI CSIS 2) has been added. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH 3/3] phy: exynos-mipi-video: Add support for Exynos 5420 and 5433 SoCs

patible case) or by moving MIPI DPHY reset registers to > separate system register controllers (Exynos 5433 case). In both case > also additional 5th PHY (MIPI CSIS 2) has been added. > > Signed-off-by: Marek Szyprowski Acked-by: Sylwester Nawrocki

Re: [PATCH 2/3] phy: exynos-mipi-video: Rewrite handling of phy registers

g.com> I've tested this patch series on Trats2 and an exynos5433 based board and it seems to be all working well. Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester

Re: [PATCH 2/3] phy: exynos-mipi-video: Rewrite handling of phy registers

this patch series on Trats2 and an exynos5433 based board and it seems to be all working well. Acked-by: Sylwester Nawrocki -- Thanks, Sylwester

Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions

ivers/pinctrl/samsung/pinctrl-exynos.c | 1 - > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 +++ > drivers/pinctrl/samsung/pinctrl-s3c24xx.c| 2 +- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c| 2 +- > drivers/pinctrl/samsung/pinctrl-samsung.c| 12 +--- >

Re: [PATCH 8/8] drivers/pinctrl: clean up samsung modular vs. non-modular distinctions

rl/samsung/pinctrl-s3c24xx.c| 2 +- > drivers/pinctrl/samsung/pinctrl-s3c64xx.c| 2 +- > drivers/pinctrl/samsung/pinctrl-samsung.c| 12 +--- > 5 files changed, 6 insertions(+), 26 deletions(-) Acked-by: Sylwester Nawrocki -- Thanks, Sylwester

Re: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)"

On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu The patch looks OK, but could you also provide a proper commit message? > Signed-off-by: Zeng Zhaoxiu > --- > drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++- > 1 file

Re: [PATCH 05/10] exynos4-is: Replace "hweight32(mask) == 1" with "is_power_of_2(mask)"

On 12/06/2015 11:44 AM, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu The patch looks OK, but could you also provide a proper commit message? > Signed-off-by: Zeng Zhaoxiu > --- > drivers/media/platform/exynos4-is/fimc-is-regs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: > The fimc_md_parse_port_node() function return 0 if an endpoint node is > not found but according to Documentation/devicetree/bindings/graph.txt, > a port must always have at least one enpoint. > > So return an -EINVAL errno code to the

Re: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint

On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote: > The fimc_md_parse_port_node() function return 0 if an endpoint node is > not found but according to Documentation/devicetree/bindings/graph.txt, > a port must always have at least one enpoint. > > So return an -EINVAL errno code to the

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

Hi Javier, Krzysztof, On 03/05/2016 05:35 AM, Krzysztof Kozlowski wrote: > 2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas : >> > Hello, >> > >> > This series have two trivial fixes for issues that I noticed while >> > reading as a reference the driver's functions that

Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic

Hi Javier, Krzysztof, On 03/05/2016 05:35 AM, Krzysztof Kozlowski wrote: > 2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas : >> > Hello, >> > >> > This series have two trivial fixes for issues that I noticed while >> > reading as a reference the driver's functions that parse the graph >> >

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > ---

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > ---

Re: [PATCH 13/41] clk: samsung: Remove CLK_IS_ROOT

On 03/01/2016 07:59 PM, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > --- > drivers/clk/samsung/clk-exynos4.c| 12 +++

Re: [PATCH 13/41] clk: samsung: Remove CLK_IS_ROOT

On 03/01/2016 07:59 PM, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sylwester Nawrocki > Signed-off-by: Stephen Boyd > --- > drivers/clk/samsung/clk-exynos4.c| 12 +++--- > drivers/clk/samsung/clk-exynos4415.c | 2 +- >

Re: [PATCH v5 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

v7 for ARMv7). > > Instead build clock drivers only for respective SoC's architecture. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Re: [PATCH v5 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

v7 for ARMv7). > > Instead build clock drivers only for respective SoC's architecture. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Sylwester Nawrocki

Re: [PATCH v4 2/2] s5p-mfc: add the support of V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME.

On 19/01/16 08:07, Wu-Cheng Li wrote: > There is a new control V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME to > force an encoder key frame. It is the same as requesting > V4L2_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE_I_FRAME. > > Signed-off-by: Wu-Cheng Li <wuchen...@chromium.org> Acked-b

Re: [PATCH v4 2/2] s5p-mfc: add the support of V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME.

On 19/01/16 08:07, Wu-Cheng Li wrote: > There is a new control V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME to > force an encoder key frame. It is the same as requesting > V4L2_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE_I_FRAME. > > Signed-off-by: Wu-Cheng Li Acked-by: Sylwester Nawrocki

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

drivers/clk/samsung/Kconfig | 1 - > 3 files changed, 4 insertions(+), 6 deletions(-) For the samsung code changes: Acked-by: Sylwester Nawrocki -- Thanks, Sylwester

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

g | 8 +++- > drivers/clk/samsung/Kconfig | 1 - > 3 files changed, 4 insertions(+), 6 deletions(-) For the samsung code changes: Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Thanks, Sylwester

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

Mike, On 22/12/15 19:44, Mike Turquette wrote: > This is superseded by the pull request found in Message-ID: > <5671a456.9030...@samsung.com>, correct? The two pull requests are based on same branch, first 2 commits are tagged with for-4.5-clk-exynos5420 tag and the whole branch is tagged as

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

Mike, On 22/12/15 19:44, Mike Turquette wrote: > This is superseded by the pull request found in Message-ID: > <5671a456.9030...@samsung.com>, correct? The two pull requests are based on same branch, first 2 commits are tagged with for-4.5-clk-exynos5420 tag and the whole branch is tagged as

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

Krzysztof, On 09/12/15 14:36, Krzysztof Kozlowski wrote: > W dniu 09.12.2015 o 19:14, Sylwester Nawrocki pisze: >> > Adding Stephen and linux-clk at Cc. >> > >> > On 09/12/15 05:49, Krzysztof Kozlowski wrote: >>> >> On 08.12.2015 22:46, Marek Szypro

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

Krzysztof, On 09/12/15 14:36, Krzysztof Kozlowski wrote: > W dniu 09.12.2015 o 19:14, Sylwester Nawrocki pisze: >> > Adding Stephen and linux-clk at Cc. >> > >> > On 09/12/15 05:49, Krzysztof Kozlowski wrote: >>> >> On 08.12.2015 22:46, Marek Szypro

Re: [PATCH] clk: exynos: use irqsave version of spin_lock to avoid deadlock with irqs

lock is used by gate/mux clocks during enable/disable calls. > > This deadlock, can be reproduced by enabling CPUfreq (ondemand or > userspace) and decoding video with s5p-mfc driver. > Signed-off-by: Marek Szyprowski > CC: sta...@vger.kernel.org # v4.2+ Acked-by: Sylwester Nawrocki

Re: [PATCH] clk: exynos: use irqsave version of spin_lock to avoid deadlock with irqs

lock is used by gate/mux clocks during enable/disable calls. > > This deadlock, can be reproduced by enabling CPUfreq (ondemand or > userspace) and decoding video with s5p-mfc driver. > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > CC: sta...@vger.kernel.org # v4

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

folks, this can go through samsung-soc? I guess it makes more sense that making a stable branch with just this patch to be pulled into arm-soc and clk tree. I'm fine with applying this patch through arm-soc, but I think we also need Mike's or Stephen ack for this. Acked-by: Sylwester Nawrocki -- Tha

Re: [PATCH 1/2] clk: samsung: exynos5422: add missing parent GSCL block clocks

ose that, with ack from clock folks, this can go through samsung-soc? I guess it makes more sense that making a stable branch with just this patch to be pulled into arm-soc and clk tree. I'm fine with applying this patch through arm-soc, but I think we also need Mike's or Stephen ack

Re: [PATCH v3 03/10] clk: samsung: exynos5420: add cpu clock configuration data and instantiate cpu clock

ned-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 06/10] clk: samsung: exynos5800: fix cpu clock configuration data

> Cc: Mike Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v3 06/10] clk: samsung: exynos5800: fix cpu clock configuration data

Tomasz Figa <tomasz.f...@gmail.com> > Cc: Mike Turquette <mturque...@linaro.org> > Cc: Javier Martinez Canillas <jav...@osg.samsung.com> > Cc: Thomas Abraham <thomas...@samsung.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Acked-by: Sylw

Re: [PATCH v3 03/10] clk: samsung: exynos5420: add cpu clock configuration data and instantiate cpu clock

...@linaro.org> > Cc: Javier Martinez Canillas <jav...@osg.samsung.com> > Signed-off-by: Thomas Abraham <thomas...@samsung.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- Regards, Sylwester

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

On 19/11/15 10:16, Tomasz Figa wrote: > 2015-11-19 13:51 GMT+09:00 Krzysztof Kozlowski : >> > On 19.11.2015 13:18, Tomasz Figa wrote: >>> >> However, I don't think we can disable compilation of particular >>> >> 64-bit SoCs, so maybe there isn't much sense in splitting their >>> >> clock drivers

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

On 19/11/15 10:16, Tomasz Figa wrote: > 2015-11-19 13:51 GMT+09:00 Krzysztof Kozlowski : >> > On 19.11.2015 13:18, Tomasz Figa wrote: >>> >> However, I don't think we can disable compilation of particular >>> >> 64-bit SoCs, so maybe there isn't much sense in splitting

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

> EXYNOS7_COMMON_CLK? As for all ARM64 SoC there is single defconfig and >> binary. > > Yes, it can be one config symbol for all clocks of ARMv8 Exynos SoCs. > From my point of view both has some advantages and disadvantages (kernel > size, granularity, number of Kconfig symbols et

Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

Exynos SoC clock file under >> EXYNOS7_COMMON_CLK? As for all ARM64 SoC there is single defconfig and >> binary. > > Yes, it can be one config symbol for all clocks of ARMv8 Exynos SoCs. > From my point of view both has some advantages and disadvantages (kernel > size, granularit

Re: [PATCH] arm: dts: Fix audio card detection on peach boards

On 12/10/15 08:47, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > index 8f4d76c..525a93a 100644 >> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts

Re: [PATCH] arm: dts: Fix audio card detection on peach boards

On 12/10/15 08:47, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > index 8f4d76c..525a93a 100644 >> > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts

Re: [PATCH 5/7] [media] use v4l2_get_timestamp where possible

> > Signed-off-by: Arnd Bergmann > --- For: drivers/media/platform/exynos4-is/fimc-lite.c drivers/media/platform/s3c-camif/camif-capture.c Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized

for timestamps across suspend or settimeofday(). > > This changes the driver to use the normal v4l2_get_timestamp() > function like all other drivers. > > Signed-off-by: Arnd Bergmann Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH 5/7] [media] use v4l2_get_timestamp where possible

> > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- For: drivers/media/platform/exynos4-is/fimc-lite.c drivers/media/platform/s3c-camif/camif-capture.c Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized

for timestamps across suspend or settimeofday(). > > This changes the driver to use the normal v4l2_get_timestamp() > function like all other drivers. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> -- To unsubscribe

Re: [PATCH] clk: samsung: fix cpu clock's flags checking

Michael Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Reported-by: Dan Carpenter > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [PATCH] clk: samsung: fix cpu clock's flags checking

Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Sylwester Nawrocki s.nawro

Re: [PATCH 18/26] clk: samsung: Convert to clk_hw based provider APIs

On 31/07/15 19:03, Stephen Boyd wrote: > We're removing struct clk from the clk provider API, so switch > this code to using the clk_hw based provider APIs. > > Cc: Chanwoo Choi > Cc: Sylwester Nawrocki > Cc: Krzysztof Kozlowski > Cc: Kukjin Kim > Signed-off-

Re: [PATCH 02/26] clk: Replace __clk_get_num_parents with clk_hw_get_num_parents()

parents = clk_hw_get_num_parents(>hw); ? > int i; > > if (mix->mux_flags & CLK_MUX_INDEX_BIT) With the above fixed Acked-by: Sylwester Nawrocki -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 02/26] clk: Replace __clk_get_num_parents with clk_hw_get_num_parents()

; if (mix-mux_flags CLK_MUX_INDEX_BIT) With the above fixed Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 18/26] clk: samsung: Convert to clk_hw based provider APIs

On 31/07/15 19:03, Stephen Boyd wrote: We're removing struct clk from the clk provider API, so switch this code to using the clk_hw based provider APIs. Cc: Chanwoo Choi cw00.c...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com Cc

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

On 07/22/2015 08:41 AM, Krzysztof Kozlowski wrote: On 22.07.2015 07:42, Stephen Boyd wrote: >On 06/12, Krzysztof Kozlowski wrote: [...] >>Signed-off-by: Krzysztof Kozlowski >>Cc: >>Fixes: c63c57433003 ("ARM: dts: Add ADC's dt data to read raw data for exynos4x12")

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

gt; GATE(CLK_MIPI_HSI, "mipi_hsi", "aclk133", GATE_IP_FSYS, 10, 0, 0), > GATE(CLK_CHIPID, "chipid", "aclk100", E4X12_GATE_IP_PERIR, 0, 0, 0), > GATE(CLK_SYSREG, "sysreg", "aclk100", E4X12_GATE_IP_PERIR, 1, > -- Sylwester Nawrocki Samsung R Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

On 07/22/2015 08:41 AM, Krzysztof Kozlowski wrote: On 22.07.2015 07:42, Stephen Boyd wrote: On 06/12, Krzysztof Kozlowski wrote: [...] Signed-off-by: Krzysztof Kozlowskik.kozlow...@samsung.com Cc:sta...@vger.kernel.org Fixes: c63c57433003 (ARM: dts: Add ADC's dt data to read raw data for

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

(CLK_TSADC, tsadc, aclk133, E4X12_GATE_BUS_FSYS1, 16, 0, 0), GATE(CLK_MIPI_HSI, mipi_hsi, aclk133, GATE_IP_FSYS, 10, 0, 0), GATE(CLK_CHIPID, chipid, aclk100, E4X12_GATE_IP_PERIR, 0, 0, 0), GATE(CLK_SYSREG, sysreg, aclk100, E4X12_GATE_IP_PERIR, 1, -- Sylwester Nawrocki

Re: [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock

by Bartlomiej: - split Exynos5250 support from the original patch - moved E5250_CPU_DIV[0,1]() macros to clk-exynos5250.c Cc: Tomasz Figa Cc: Michael Turquette Cc: Javier Martinez Canillas Signed-off-by: Thomas Abraham Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sylwester Nawrocki

Re: [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock

this whole series applied through one, e.g samsung-soc tree? If so, here is my ack. Acked-by: Sylwester Nawrocki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 4/7] clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock

+++ 1 file changed, 50 insertions(+) I guess you prefer to have this whole series applied through one, e.g samsung-soc tree? If so, here is my ack. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 1/4] clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock

Abrahamthomas...@samsung.com Signed-off-by: Bartlomiej Zolnierkiewiczb.zolnier...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

On 09/07/15 02:23, Krzysztof Kozlowski wrote: > drivers/clk/samsung/clk-exynos4.c | 2 ++ > 1 file changed, 2 insertions(+) > >>> >>> Patch looks good to me. >>> >>> Reviewed-by: Javier Martinez Canillas >>> >> >>> >> Hi Tomasz and Sylwester, >>> >> >>>

Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC

On 09/07/15 02:23, Krzysztof Kozlowski wrote: drivers/clk/samsung/clk-exynos4.c | 2 ++ 1 file changed, 2 insertions(+) Patch looks good to me. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Hi Tomasz and Sylwester, Any comments on this version of

Re: [PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

o, feel free to do any changes in this code. Acked-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

Re: [PATCH 05/12] media/i2c/sr030pc30: Remove compat control ops

in this code. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

s a cyclic >> dependency, so it is left as "select". >> >> Signed-off-by: Arun Ramamurthy > > Need your ACK for this patch. For drivers/media/platform/exynos4-is/Kconfig drivers/video/fbdev/exynos/Kconfig Acked-by: Sylwester Nawrocki -- T

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

...@broadcom.com Need your ACK for this patch. For drivers/media/platform/exynos4-is/Kconfig drivers/video/fbdev/exynos/Kconfig Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v4] clk: Show correct information when fail to set clock rate

; > clock rate. >> > >> > Cc: Mike Turquette >> > Cc: Stephen Boyd >> > Cc: Sylwester Nawrocki >> > Signed-off-by: Chanwoo Choi >> > --- > > Seems fine to me. Sylwester? I'm fine with that too. Acked-by: Sylwester Nawrocki

Re: [PATCH v4] clk: Show correct information when fail to set clock rate

Cc: Stephen Boyd sb...@codeaurora.org Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- Seems fine to me. Sylwester? I'm fine with that too. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- Thanks, Sylwester -- To unsubscribe from

Re: [PATCH 1/6] clk: add CLK_RECALC_NEW_RATES clock flag for Exynos cpu clock support

On 03/04/15 18:43, Bartlomiej Zolnierkiewicz wrote: > This flag is needed to fix the issue with wrong dividers being setup > by Common Clock Framework when using the new Exynos cpu clock support. > > The issue happens because clk_core_set_rate_nolock() calls > clk_calc_new_rates(clk, rate)

Re: [PATCH 1/6] clk: add CLK_RECALC_NEW_RATES clock flag for Exynos cpu clock support

On 03/04/15 18:43, Bartlomiej Zolnierkiewicz wrote: This flag is needed to fix the issue with wrong dividers being setup by Common Clock Framework when using the new Exynos cpu clock support. The issue happens because clk_core_set_rate_nolock() calls clk_calc_new_rates(clk, rate) before

Re: [PATCH 08/19] clk: samsung: Silence sparse warnings

On 06/05/15 09:39, Stephen Boyd wrote: > drivers/clk/samsung/clk-exynos5260.c:138:40: warning: Using plain integer as > NULL pointer > Cc: Sylwester Nawrocki > Signed-off-by: Stephen Boyd > --- > drivers/clk/samsung/clk-exynos5260.c | 26 +- >

Re: [PATCH 08/19] clk: samsung: Silence sparse warnings

On 06/05/15 09:39, Stephen Boyd wrote: drivers/clk/samsung/clk-exynos5260.c:138:40: warning: Using plain integer as NULL pointer Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/clk/samsung/clk-exynos5260.c | 26

<    5   6   7   8   9   10   11   12   13   14   >